@theia/task 1.23.0-next.4 → 1.23.0-next.42

package/src/node/task-server.slow-spec.ts

@@ -105,7 +105,7 @@ describe('Task server / back-end', function (): void {
         const messages: string[] = [];
 
         // hook-up to terminal's ws and confirm that it outputs expected tasks' output
-        await new Promise((resolve, reject) => {
+        await new Promise<void>((resolve, reject) => {
             const channel = new TestWebSocketChannel({ server, path: `${terminalsPath}/${terminalId}` });
             channel.onError(reject);
             channel.onClose((code, reason) => reject(new Error(`channel is closed with '${code}' code and '${reason}' reason`)));
@@ -137,7 +137,7 @@ describe('Task server / back-end', function (): void {
         // create task using raw process
         const taskInfo: TaskInfo = await taskServer.run(createProcessTaskConfig('process', executable, [someString]), wsRoot);
 
-        await new Promise((resolve, reject) => {
+        await new Promise<void>((resolve, reject) => {
             const toDispose = taskWatcher.onTaskExit((event: TaskExitedEvent) => {
                 if (event.taskId === taskInfo.taskId && event.code === 0) {
                     if (typeof taskInfo.terminalId === 'number') {
@@ -242,8 +242,9 @@ describe('Task server / back-end', function (): void {
             taskWatcher.onTaskExit((event: TaskExitedEvent) => {
                 if (event.taskId !== taskInfo.taskId || event.code === undefined) {
                     reject(new Error(JSON.stringify(event)));
+                } else {
+                    resolve(event.code);
                 }
-                resolve(event.code);
             });
         });
         // node-pty reports different things on Linux/macOS vs Windows when
@@ -422,8 +423,8 @@ function createTaskConfigTaskLongRunning(processType: ProcessType): TaskConfigur
     };
 }
 
-function checkSuccessfulProcessExit(taskInfo: TaskInfo, taskWatcher: TaskWatcher): Promise<object> {
-    return new Promise<object>((resolve, reject) => {
+function checkSuccessfulProcessExit(taskInfo: TaskInfo, taskWatcher: TaskWatcher): Promise<void> {
+    return new Promise<void>((resolve, reject) => {
         const toDispose = taskWatcher.onTaskExit((event: TaskExitedEvent) => {
             if (event.taskId === taskInfo.taskId && event.code === 0) {
                 toDispose.dispose();

package/src/node/test/task-test-container.ts

@@ -44,7 +44,7 @@ export function createTaskTestContainer(): Container {
     testContainer.rebind(TerminalProcess).to(TestTerminalProcess);
 
     testContainer.rebind(ProcessUtils).toConstantValue(new class extends ProcessUtils {
-        terminateProcessTree(): void { } // don't actually kill the tree, it breaks the tests.
+        override terminateProcessTree(): void { } // don't actually kill the tree, it breaks the tests.
     });
 
     return testContainer;
@@ -52,7 +52,7 @@ export function createTaskTestContainer(): Container {
 
 class TestTerminalProcess extends TerminalProcess {
 
-    protected emitOnStarted(): void {
+    protected override emitOnStarted(): void {
         if (process.env['THEIA_TASK_TEST_DEBUG']) {
             console.log(`START ${this.id} ${JSON.stringify([this.executable, this.options.commandLine, ...this.arguments])}`);
             this.outputStream.on('data', data => console.debug(`${this.id} OUTPUT: ${data.toString().trim()}`));