@theia/plugin-ext 1.76.0-next.4 → 1.76.0-next.42

package/lib/plugin/telemetry-ext.spec.js

@@ -18,34 +18,139 @@ Object.defineProperty(exports, "__esModule", { value: true });
 const chai = require("chai");
 const telemetry_ext_1 = require("./telemetry-ext");
 const expect = chai.expect;
-describe('TelemetryLogger', () => {
+describe('TelemetryExtImpl', () => {
     const sender = {
         sendEventData: () => { },
         sendErrorData: () => { }
     };
-    it('reflects the current telemetry enabled state', () => {
+    const expectations = {
+        off: { isTelemetryEnabled: false, isUsageEnabled: false, isErrorsEnabled: false },
+        crash: { isTelemetryEnabled: false, isUsageEnabled: false, isErrorsEnabled: false },
+        error: { isTelemetryEnabled: false, isUsageEnabled: false, isErrorsEnabled: true },
+        all: { isTelemetryEnabled: true, isUsageEnabled: true, isErrorsEnabled: true }
+    };
+    for (const level of ['off', 'crash', 'error', 'all']) {
+        const expected = expectations[level];
+        it(`derives the enablement states from telemetry level '${level}'`, () => {
+            const telemetry = new telemetry_ext_1.TelemetryExtImpl();
+            telemetry.$onDidChangeTelemetryLevel(level);
+            const logger = telemetry.createTelemetryLogger(sender);
+            expect(telemetry.level).to.equal(level);
+            expect(telemetry.isTelemetryEnabled).to.equal(expected.isTelemetryEnabled);
+            expect(logger.isUsageEnabled).to.equal(expected.isUsageEnabled);
+            expect(logger.isErrorsEnabled).to.equal(expected.isErrorsEnabled);
+        });
+        it(`applies telemetry level '${level}' to loggers created before the level arrived`, () => {
+            const telemetry = new telemetry_ext_1.TelemetryExtImpl();
+            const logger = telemetry.createTelemetryLogger(sender);
+            telemetry.$onDidChangeTelemetryLevel(level);
+            expect(logger.isUsageEnabled).to.equal(expected.isUsageEnabled);
+            expect(logger.isErrorsEnabled).to.equal(expected.isErrorsEnabled);
+        });
+    }
+    it('only fires onDidChangeTelemetryEnabled when the boolean it reports changes', () => {
+        const telemetry = new telemetry_ext_1.TelemetryExtImpl();
+        const fired = [];
+        telemetry.onDidChangeTelemetryEnabled(enabled => fired.push(enabled));
+        telemetry.$onDidChangeTelemetryLevel('crash');
+        telemetry.$onDidChangeTelemetryLevel('error');
+        telemetry.$onDidChangeTelemetryLevel('all');
+        telemetry.$onDidChangeTelemetryLevel('off');
+        expect(fired).to.deep.equal([true, false]);
+    });
+    it('fires onDidChangeEnableStates once per transition that changes an enablement state', () => {
         const telemetry = new telemetry_ext_1.TelemetryExtImpl();
         const logger = telemetry.createTelemetryLogger(sender);
-        expect(logger.telemetryEnabled).to.equal(false);
-        expect(logger.isUsageEnabled).to.equal(false);
-        expect(logger.isErrorsEnabled).to.equal(false);
-        telemetry.isTelemetryEnabled = true;
-        expect(logger.telemetryEnabled).to.equal(true);
-        expect(logger.isUsageEnabled).to.equal(true);
-        expect(logger.isErrorsEnabled).to.equal(true);
-        telemetry.isTelemetryEnabled = false;
-        expect(logger.telemetryEnabled).to.equal(false);
+        let changes = 0;
+        logger.onDidChangeEnableStates(() => changes++);
+        telemetry.$onDidChangeTelemetryLevel('crash'); // off -> crash: both stay false
+        expect(changes).to.equal(0);
+        telemetry.$onDidChangeTelemetryLevel('error'); // errors become enabled
+        expect(changes).to.equal(1);
+        telemetry.$onDidChangeTelemetryLevel('all'); // usage becomes enabled
+        expect(changes).to.equal(2);
+        telemetry.$onDidChangeTelemetryLevel('off');
+        expect(changes).to.equal(3);
+    });
+    it('stops following the level once the logger is disposed', () => {
+        const telemetry = new telemetry_ext_1.TelemetryExtImpl();
+        const logger = telemetry.createTelemetryLogger(sender);
+        let changes = 0;
+        logger.onDidChangeEnableStates(() => changes++);
+        logger.dispose();
+        telemetry.$onDidChangeTelemetryLevel('all');
         expect(logger.isUsageEnabled).to.equal(false);
-        expect(logger.isErrorsEnabled).to.equal(false);
+        logger.isUsageEnabled = true;
+        expect(changes).to.equal(0);
     });
-    it('emits enable-state changes when telemetry is toggled', () => {
+    it('logs rather than propagates a sender that fails to flush on disposal', async () => {
+        const telemetry = new telemetry_ext_1.TelemetryExtImpl();
+        const logged = [];
+        const consoleError = console.error;
+        console.error = (...args) => { logged.push(args); };
+        try {
+            telemetry.createTelemetryLogger({ ...sender, flush: () => { throw new Error('boom'); } }).dispose();
+            telemetry.createTelemetryLogger({ ...sender, flush: () => Promise.reject(new Error('boom')) }).dispose();
+            await new Promise(resolve => setTimeout(resolve, 0));
+        }
+        finally {
+            console.error = consoleError;
+        }
+        expect(logged).to.have.lengthOf(2);
+    });
+    it('ignores a repeated telemetry level', () => {
         const telemetry = new telemetry_ext_1.TelemetryExtImpl();
         const logger = telemetry.createTelemetryLogger(sender);
         let changes = 0;
         logger.onDidChangeEnableStates(() => changes++);
-        telemetry.isTelemetryEnabled = true;
-        telemetry.isTelemetryEnabled = false;
-        expect(changes).to.equal(2);
+        telemetry.$onDidChangeTelemetryLevel('all');
+        telemetry.$onDidChangeTelemetryLevel('all');
+        expect(changes).to.equal(1);
+    });
+});
+describe('TelemetryLogger', () => {
+    function createSender() {
+        const events = [];
+        const errors = [];
+        return {
+            events,
+            errors,
+            sendEventData: (eventName) => events.push(eventName),
+            sendErrorData: (error) => errors.push(error)
+        };
+    }
+    it('delivers errors but suppresses usage at telemetry level \'error\'', () => {
+        const telemetry = new telemetry_ext_1.TelemetryExtImpl();
+        telemetry.$onDidChangeTelemetryLevel('error');
+        const sender = createSender();
+        const logger = telemetry.createTelemetryLogger(sender);
+        logger.logUsage('usage-event');
+        logger.logError('error-event');
+        logger.logError(new Error('boom'));
+        expect(sender.events).to.deep.equal(['error-event']);
+        expect(sender.errors).to.have.lengthOf(1);
+    });
+    it('suppresses usage that a plugin re-enables while the telemetry level forbids it', () => {
+        const telemetry = new telemetry_ext_1.TelemetryExtImpl();
+        telemetry.$onDidChangeTelemetryLevel('off');
+        const sender = createSender();
+        const logger = telemetry.createTelemetryLogger(sender);
+        logger.isUsageEnabled = true;
+        logger.isErrorsEnabled = true;
+        logger.logUsage('usage-event');
+        logger.logError('error-event');
+        expect(sender.events).to.be.empty;
+    });
+    it('refuses to let a plugin assign the telemetry level of its logger', () => {
+        const telemetry = new telemetry_ext_1.TelemetryExtImpl();
+        telemetry.$onDidChangeTelemetryLevel('off');
+        const sender = createSender();
+        const logger = telemetry.createTelemetryLogger(sender);
+        expect(Reflect.set(logger, 'level', 'all')).to.be.false;
+        logger.logUsage('usage-event');
+        expect(logger.level).to.equal('off');
+        expect(logger.isUsageEnabled).to.be.false;
+        expect(sender.events).to.be.empty;
     });
 });
 //# sourceMappingURL=telemetry-ext.spec.js.map

package/lib/plugin/telemetry-ext.spec.js.map

@@ -1 +1 @@
-{"version":3,"file":"telemetry-ext.spec.js","sourceRoot":"","sources":["../../src/plugin/telemetry-ext.spec.ts"],"names":[],"mappings":";AAAA,gFAAgF;AAChF,wCAAwC;AACxC,EAAE;AACF,2EAA2E;AAC3E,mEAAmE;AACnE,wCAAwC;AACxC,EAAE;AACF,4EAA4E;AAC5E,8EAA8E;AAC9E,6EAA6E;AAC7E,yDAAyD;AACzD,uDAAuD;AACvD,EAAE;AACF,gFAAgF;AAChF,gFAAgF;;AAEhF,6BAA6B;AAC7B,mDAAmD;AAEnD,MAAM,MAAM,GAAG,IAAI,CAAC,MAAM,CAAC;AAE3B,QAAQ,CAAC,iBAAiB,EAAE,GAAG,EAAE;IAC7B,MAAM,MAAM,GAAG;QACX,aAAa,EAAE,GAAG,EAAE,GAAG,CAAC;QACxB,aAAa,EAAE,GAAG,EAAE,GAAG,CAAC;KAC3B,CAAC;IAEF,EAAE,CAAC,8CAA8C,EAAE,GAAG,EAAE;QACpD,MAAM,SAAS,GAAG,IAAI,gCAAgB,EAAE,CAAC;QACzC,MAAM,MAAM,GAAG,SAAS,CAAC,qBAAqB,CAAC,MAAM,CAAC,CAAC;QAEvD,MAAM,CAAC,MAAM,CAAC,gBAAgB,CAAC,CAAC,EAAE,CAAC,KAAK,CAAC,KAAK,CAAC,CAAC;QAChD,MAAM,CAAC,MAAM,CAAC,cAAc,CAAC,CAAC,EAAE,CAAC,KAAK,CAAC,KAAK,CAAC,CAAC;QAC9C,MAAM,CAAC,MAAM,CAAC,eAAe,CAAC,CAAC,EAAE,CAAC,KAAK,CAAC,KAAK,CAAC,CAAC;QAE/C,SAAS,CAAC,kBAAkB,GAAG,IAAI,CAAC;QAEpC,MAAM,CAAC,MAAM,CAAC,gBAAgB,CAAC,CAAC,EAAE,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;QAC/C,MAAM,CAAC,MAAM,CAAC,cAAc,CAAC,CAAC,EAAE,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;QAC7C,MAAM,CAAC,MAAM,CAAC,eAAe,CAAC,CAAC,EAAE,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;QAE9C,SAAS,CAAC,kBAAkB,GAAG,KAAK,CAAC;QAErC,MAAM,CAAC,MAAM,CAAC,gBAAgB,CAAC,CAAC,EAAE,CAAC,KAAK,CAAC,KAAK,CAAC,CAAC;QAChD,MAAM,CAAC,MAAM,CAAC,cAAc,CAAC,CAAC,EAAE,CAAC,KAAK,CAAC,KAAK,CAAC,CAAC;QAC9C,MAAM,CAAC,MAAM,CAAC,eAAe,CAAC,CAAC,EAAE,CAAC,KAAK,CAAC,KAAK,CAAC,CAAC;IACnD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,sDAAsD,EAAE,GAAG,EAAE;QAC5D,MAAM,SAAS,GAAG,IAAI,gCAAgB,EAAE,CAAC;QACzC,MAAM,MAAM,GAAG,SAAS,CAAC,qBAAqB,CAAC,MAAM,CAAC,CAAC;QACvD,IAAI,OAAO,GAAG,CAAC,CAAC;QAEhB,MAAM,CAAC,uBAAuB,CAAC,GAAG,EAAE,CAAC,OAAO,EAAE,CAAC,CAAC;QAEhD,SAAS,CAAC,kBAAkB,GAAG,IAAI,CAAC;QACpC,SAAS,CAAC,kBAAkB,GAAG,KAAK,CAAC;QAErC,MAAM,CAAC,OAAO,CAAC,CAAC,EAAE,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC;IAChC,CAAC,CAAC,CAAC;AACP,CAAC,CAAC,CAAC"}
+{"version":3,"file":"telemetry-ext.spec.js","sourceRoot":"","sources":["../../src/plugin/telemetry-ext.spec.ts"],"names":[],"mappings":";AAAA,gFAAgF;AAChF,wCAAwC;AACxC,EAAE;AACF,2EAA2E;AAC3E,mEAAmE;AACnE,wCAAwC;AACxC,EAAE;AACF,4EAA4E;AAC5E,8EAA8E;AAC9E,6EAA6E;AAC7E,yDAAyD;AACzD,uDAAuD;AACvD,EAAE;AACF,gFAAgF;AAChF,gFAAgF;;AAEhF,6BAA6B;AAE7B,mDAAmD;AAEnD,MAAM,MAAM,GAAG,IAAI,CAAC,MAAM,CAAC;AAE3B,QAAQ,CAAC,kBAAkB,EAAE,GAAG,EAAE;IAC9B,MAAM,MAAM,GAAG;QACX,aAAa,EAAE,GAAG,EAAE,GAAG,CAAC;QACxB,aAAa,EAAE,GAAG,EAAE,GAAG,CAAC;KAC3B,CAAC;IAQF,MAAM,YAAY,GAAwC;QACtD,GAAG,EAAE,EAAE,kBAAkB,EAAE,KAAK,EAAE,cAAc,EAAE,KAAK,EAAE,eAAe,EAAE,KAAK,EAAE;QACjF,KAAK,EAAE,EAAE,kBAAkB,EAAE,KAAK,EAAE,cAAc,EAAE,KAAK,EAAE,eAAe,EAAE,KAAK,EAAE;QACnF,KAAK,EAAE,EAAE,kBAAkB,EAAE,KAAK,EAAE,cAAc,EAAE,KAAK,EAAE,eAAe,EAAE,IAAI,EAAE;QAClF,GAAG,EAAE,EAAE,kBAAkB,EAAE,IAAI,EAAE,cAAc,EAAE,IAAI,EAAE,eAAe,EAAE,IAAI,EAAE;KACjF,CAAC;IAEF,KAAK,MAAM,KAAK,IAAI,CAAC,KAAK,EAAE,OAAO,EAAE,OAAO,EAAE,KAAK,CAAU,EAAE,CAAC;QAC5D,MAAM,QAAQ,GAAG,YAAY,CAAC,KAAK,CAAC,CAAC;QAErC,EAAE,CAAC,uDAAuD,KAAK,GAAG,EAAE,GAAG,EAAE;YACrE,MAAM,SAAS,GAAG,IAAI,gCAAgB,EAAE,CAAC;YACzC,SAAS,CAAC,0BAA0B,CAAC,KAAK,CAAC,CAAC;YAC5C,MAAM,MAAM,GAAG,SAAS,CAAC,qBAAqB,CAAC,MAAM,CAAC,CAAC;YAEvD,MAAM,CAAC,SAAS,CAAC,KAAK,CAAC,CAAC,EAAE,CAAC,KAAK,CAAC,KAAK,CAAC,CAAC;YACxC,MAAM,CAAC,SAAS,CAAC,kBAAkB,CAAC,CAAC,EAAE,CAAC,KAAK,CAAC,QAAQ,CAAC,kBAAkB,CAAC,CAAC;YAC3E,MAAM,CAAC,MAAM,CAAC,cAAc,CAAC,CAAC,EAAE,CAAC,KAAK,CAAC,QAAQ,CAAC,cAAc,CAAC,CAAC;YAChE,MAAM,CAAC,MAAM,CAAC,eAAe,CAAC,CAAC,EAAE,CAAC,KAAK,CAAC,QAAQ,CAAC,eAAe,CAAC,CAAC;QACtE,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,4BAA4B,KAAK,+CAA+C,EAAE,GAAG,EAAE;YACtF,MAAM,SAAS,GAAG,IAAI,gCAAgB,EAAE,CAAC;YACzC,MAAM,MAAM,GAAG,SAAS,CAAC,qBAAqB,CAAC,MAAM,CAAC,CAAC;YACvD,SAAS,CAAC,0BAA0B,CAAC,KAAK,CAAC,CAAC;YAE5C,MAAM,CAAC,MAAM,CAAC,cAAc,CAAC,CAAC,EAAE,CAAC,KAAK,CAAC,QAAQ,CAAC,cAAc,CAAC,CAAC;YAChE,MAAM,CAAC,MAAM,CAAC,eAAe,CAAC,CAAC,EAAE,CAAC,KAAK,CAAC,QAAQ,CAAC,eAAe,CAAC,CAAC;QACtE,CAAC,CAAC,CAAC;IACP,CAAC;IAED,EAAE,CAAC,4EAA4E,EAAE,GAAG,EAAE;QAClF,MAAM,SAAS,GAAG,IAAI,gCAAgB,EAAE,CAAC;QACzC,MAAM,KAAK,GAAc,EAAE,CAAC;QAC5B,SAAS,CAAC,2BAA2B,CAAC,OAAO,CAAC,EAAE,CAAC,KAAK,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC,CAAC;QAEtE,SAAS,CAAC,0BAA0B,CAAC,OAAO,CAAC,CAAC;QAC9C,SAAS,CAAC,0BAA0B,CAAC,OAAO,CAAC,CAAC;QAC9C,SAAS,CAAC,0BAA0B,CAAC,KAAK,CAAC,CAAC;QAC5C,SAAS,CAAC,0BAA0B,CAAC,KAAK,CAAC,CAAC;QAE5C,MAAM,CAAC,KAAK,CAAC,CAAC,EAAE,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,IAAI,EAAE,KAAK,CAAC,CAAC,CAAC;IAC/C,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,oFAAoF,EAAE,GAAG,EAAE;QAC1F,MAAM,SAAS,GAAG,IAAI,gCAAgB,EAAE,CAAC;QACzC,MAAM,MAAM,GAAG,SAAS,CAAC,qBAAqB,CAAC,MAAM,CAAC,CAAC;QACvD,IAAI,OAAO,GAAG,CAAC,CAAC;QAChB,MAAM,CAAC,uBAAuB,CAAC,GAAG,EAAE,CAAC,OAAO,EAAE,CAAC,CAAC;QAEhD,SAAS,CAAC,0BAA0B,CAAC,OAAO,CAAC,CAAC,CAAC,gCAAgC;QAC/E,MAAM,CAAC,OAAO,CAAC,CAAC,EAAE,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC;QAE5B,SAAS,CAAC,0BAA0B,CAAC,OAAO,CAAC,CAAC,CAAC,wBAAwB;QACvE,MAAM,CAAC,OAAO,CAAC,CAAC,EAAE,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC;QAE5B,SAAS,CAAC,0BAA0B,CAAC,KAAK,CAAC,CAAC,CAAC,wBAAwB;QACrE,MAAM,CAAC,OAAO,CAAC,CAAC,EAAE,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC;QAE5B,SAAS,CAAC,0BAA0B,CAAC,KAAK,CAAC,CAAC;QAC5C,MAAM,CAAC,OAAO,CAAC,CAAC,EAAE,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC;IAChC,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,uDAAuD,EAAE,GAAG,EAAE;QAC7D,MAAM,SAAS,GAAG,IAAI,gCAAgB,EAAE,CAAC;QACzC,MAAM,MAAM,GAAG,SAAS,CAAC,qBAAqB,CAAC,MAAM,CAAC,CAAC;QACvD,IAAI,OAAO,GAAG,CAAC,CAAC;QAChB,MAAM,CAAC,uBAAuB,CAAC,GAAG,EAAE,CAAC,OAAO,EAAE,CAAC,CAAC;QAEhD,MAAM,CAAC,OAAO,EAAE,CAAC;QACjB,SAAS,CAAC,0BAA0B,CAAC,KAAK,CAAC,CAAC;QAC5C,MAAM,CAAC,MAAM,CAAC,cAAc,CAAC,CAAC,EAAE,CAAC,KAAK,CAAC,KAAK,CAAC,CAAC;QAE9C,MAAM,CAAC,cAAc,GAAG,IAAI,CAAC;QAC7B,MAAM,CAAC,OAAO,CAAC,CAAC,EAAE,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC;IAChC,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,sEAAsE,EAAE,KAAK,IAAI,EAAE;QAClF,MAAM,SAAS,GAAG,IAAI,gCAAgB,EAAE,CAAC;QACzC,MAAM,MAAM,GAAc,EAAE,CAAC;QAC7B,MAAM,YAAY,GAAG,OAAO,CAAC,KAAK,CAAC;QACnC,OAAO,CAAC,KAAK,GAAG,CAAC,GAAG,IAAe,EAAE,EAAE,GAAG,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,CAAC;QAC/D,IAAI,CAAC;YACD,SAAS,CAAC,qBAAqB,CAAC,EAAE,GAAG,MAAM,EAAE,KAAK,EAAE,GAAG,EAAE,GAAG,MAAM,IAAI,KAAK,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,OAAO,EAAE,CAAC;YACpG,SAAS,CAAC,qBAAqB,CAAC,EAAE,GAAG,MAAM,EAAE,KAAK,EAAE,GAAG,EAAE,CAAC,OAAO,CAAC,MAAM,CAAC,IAAI,KAAK,CAAC,MAAM,CAAC,CAAC,EAAE,CAAC,CAAC,OAAO,EAAE,CAAC;YACzG,MAAM,IAAI,OAAO,CAAC,OAAO,CAAC,EAAE,CAAC,UAAU,CAAC,OAAO,EAAE,CAAC,CAAC,CAAC,CAAC;QACzD,CAAC;gBAAS,CAAC;YACP,OAAO,CAAC,KAAK,GAAG,YAAY,CAAC;QACjC,CAAC;QAED,MAAM,CAAC,MAAM,CAAC,CAAC,EAAE,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC;IACvC,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,oCAAoC,EAAE,GAAG,EAAE;QAC1C,MAAM,SAAS,GAAG,IAAI,gCAAgB,EAAE,CAAC;QACzC,MAAM,MAAM,GAAG,SAAS,CAAC,qBAAqB,CAAC,MAAM,CAAC,CAAC;QACvD,IAAI,OAAO,GAAG,CAAC,CAAC;QAChB,MAAM,CAAC,uBAAuB,CAAC,GAAG,EAAE,CAAC,OAAO,EAAE,CAAC,CAAC;QAEhD,SAAS,CAAC,0BAA0B,CAAC,KAAK,CAAC,CAAC;QAC5C,SAAS,CAAC,0BAA0B,CAAC,KAAK,CAAC,CAAC;QAE5C,MAAM,CAAC,OAAO,CAAC,CAAC,EAAE,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC;IAChC,CAAC,CAAC,CAAC;AACP,CAAC,CAAC,CAAC;AAEH,QAAQ,CAAC,iBAAiB,EAAE,GAAG,EAAE;IAS7B,SAAS,YAAY;QACjB,MAAM,MAAM,GAAa,EAAE,CAAC;QAC5B,MAAM,MAAM,GAAY,EAAE,CAAC;QAC3B,OAAO;YACH,MAAM;YACN,MAAM;YACN,aAAa,EAAE,CAAC,SAAiB,EAAE,EAAE,CAAC,MAAM,CAAC,IAAI,CAAC,SAAS,CAAC;YAC5D,aAAa,EAAE,CAAC,KAAY,EAAE,EAAE,CAAC,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC;SACtD,CAAC;IACN,CAAC;IAED,EAAE,CAAC,mEAAmE,EAAE,GAAG,EAAE;QACzE,MAAM,SAAS,GAAG,IAAI,gCAAgB,EAAE,CAAC;QACzC,SAAS,CAAC,0BAA0B,CAAC,OAAO,CAAC,CAAC;QAC9C,MAAM,MAAM,GAAG,YAAY,EAAE,CAAC;QAC9B,MAAM,MAAM,GAAG,SAAS,CAAC,qBAAqB,CAAC,MAAM,CAAC,CAAC;QAEvD,MAAM,CAAC,QAAQ,CAAC,aAAa,CAAC,CAAC;QAC/B,MAAM,CAAC,QAAQ,CAAC,aAAa,CAAC,CAAC;QAC/B,MAAM,CAAC,QAAQ,CAAC,IAAI,KAAK,CAAC,MAAM,CAAC,CAAC,CAAC;QAEnC,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,EAAE,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,aAAa,CAAC,CAAC,CAAC;QACrD,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,EAAE,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC;IAC9C,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,gFAAgF,EAAE,GAAG,EAAE;QACtF,MAAM,SAAS,GAAG,IAAI,gCAAgB,EAAE,CAAC;QACzC,SAAS,CAAC,0BAA0B,CAAC,KAAK,CAAC,CAAC;QAC5C,MAAM,MAAM,GAAG,YAAY,EAAE,CAAC;QAC9B,MAAM,MAAM,GAAG,SAAS,CAAC,qBAAqB,CAAC,MAAM,CAAC,CAAC;QAEvD,MAAM,CAAC,cAAc,GAAG,IAAI,CAAC;QAC7B,MAAM,CAAC,eAAe,GAAG,IAAI,CAAC;QAC9B,MAAM,CAAC,QAAQ,CAAC,aAAa,CAAC,CAAC;QAC/B,MAAM,CAAC,QAAQ,CAAC,aAAa,CAAC,CAAC;QAE/B,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,EAAE,CAAC,EAAE,CAAC,KAAK,CAAC;IACtC,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,kEAAkE,EAAE,GAAG,EAAE;QACxE,MAAM,SAAS,GAAG,IAAI,gCAAgB,EAAE,CAAC;QACzC,SAAS,CAAC,0BAA0B,CAAC,KAAK,CAAC,CAAC;QAC5C,MAAM,MAAM,GAAG,YAAY,EAAE,CAAC;QAC9B,MAAM,MAAM,GAAG,SAAS,CAAC,qBAAqB,CAAC,MAAM,CAAC,CAAC;QAEvD,MAAM,CAAC,OAAO,CAAC,GAAG,CAAC,MAAM,EAAE,OAAO,EAAE,KAAK,CAAC,CAAC,CAAC,EAAE,CAAC,EAAE,CAAC,KAAK,CAAC;QACxD,MAAM,CAAC,QAAQ,CAAC,aAAa,CAAC,CAAC;QAE/B,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,EAAE,CAAC,KAAK,CAAC,KAAK,CAAC,CAAC;QACrC,MAAM,CAAC,MAAM,CAAC,cAAc,CAAC,CAAC,EAAE,CAAC,EAAE,CAAC,KAAK,CAAC;QAC1C,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,EAAE,CAAC,EAAE,CAAC,KAAK,CAAC;IACtC,CAAC,CAAC,CAAC;AACP,CAAC,CAAC,CAAC"}

package/package.json

@@ -1,40 +1,41 @@
 {
   "name": "@theia/plugin-ext",
-  "version": "1.76.0-next.4+21b9b5342",
+  "version": "1.76.0-next.42+b0f9e63a6",
   "description": "Theia - Plugin Extension",
   "main": "lib/common/index.js",
   "typings": "lib/common/index.d.ts",
   "dependencies": {
-    "@theia/ai-core": "1.76.0-next.4+21b9b5342",
-    "@theia/ai-mcp": "1.76.0-next.4+21b9b5342",
-    "@theia/bulk-edit": "1.76.0-next.4+21b9b5342",
-    "@theia/callhierarchy": "1.76.0-next.4+21b9b5342",
-    "@theia/console": "1.76.0-next.4+21b9b5342",
-    "@theia/core": "1.76.0-next.4+21b9b5342",
-    "@theia/debug": "1.76.0-next.4+21b9b5342",
-    "@theia/editor": "1.76.0-next.4+21b9b5342",
-    "@theia/editor-preview": "1.76.0-next.4+21b9b5342",
-    "@theia/file-search": "1.76.0-next.4+21b9b5342",
-    "@theia/filesystem": "1.76.0-next.4+21b9b5342",
-    "@theia/markers": "1.76.0-next.4+21b9b5342",
-    "@theia/messages": "1.76.0-next.4+21b9b5342",
-    "@theia/monaco": "1.76.0-next.4+21b9b5342",
+    "@theia/ai-core": "1.76.0-next.42+b0f9e63a6",
+    "@theia/ai-mcp": "1.76.0-next.42+b0f9e63a6",
+    "@theia/bulk-edit": "1.76.0-next.42+b0f9e63a6",
+    "@theia/callhierarchy": "1.76.0-next.42+b0f9e63a6",
+    "@theia/console": "1.76.0-next.42+b0f9e63a6",
+    "@theia/core": "1.76.0-next.42+b0f9e63a6",
+    "@theia/debug": "1.76.0-next.42+b0f9e63a6",
+    "@theia/editor": "1.76.0-next.42+b0f9e63a6",
+    "@theia/editor-preview": "1.76.0-next.42+b0f9e63a6",
+    "@theia/file-search": "1.76.0-next.42+b0f9e63a6",
+    "@theia/filesystem": "1.76.0-next.42+b0f9e63a6",
+    "@theia/markers": "1.76.0-next.42+b0f9e63a6",
+    "@theia/messages": "1.76.0-next.42+b0f9e63a6",
+    "@theia/monaco": "1.76.0-next.42+b0f9e63a6",
     "@theia/monaco-editor-core": "1.108.201",
-    "@theia/navigator": "1.76.0-next.4+21b9b5342",
-    "@theia/notebook": "1.76.0-next.4+21b9b5342",
-    "@theia/output": "1.76.0-next.4+21b9b5342",
-    "@theia/plugin": "1.76.0-next.4+21b9b5342",
-    "@theia/plugin-utils": "1.76.0-next.4+21b9b5342",
-    "@theia/preferences": "1.76.0-next.4+21b9b5342",
-    "@theia/scm": "1.76.0-next.4+21b9b5342",
-    "@theia/search-in-workspace": "1.76.0-next.4+21b9b5342",
-    "@theia/task": "1.76.0-next.4+21b9b5342",
-    "@theia/terminal": "1.76.0-next.4+21b9b5342",
-    "@theia/test": "1.76.0-next.4+21b9b5342",
-    "@theia/timeline": "1.76.0-next.4+21b9b5342",
-    "@theia/typehierarchy": "1.76.0-next.4+21b9b5342",
-    "@theia/variable-resolver": "1.76.0-next.4+21b9b5342",
-    "@theia/workspace": "1.76.0-next.4+21b9b5342",
+    "@theia/navigator": "1.76.0-next.42+b0f9e63a6",
+    "@theia/notebook": "1.76.0-next.42+b0f9e63a6",
+    "@theia/output": "1.76.0-next.42+b0f9e63a6",
+    "@theia/plugin": "1.76.0-next.42+b0f9e63a6",
+    "@theia/plugin-utils": "1.76.0-next.42+b0f9e63a6",
+    "@theia/preferences": "1.76.0-next.42+b0f9e63a6",
+    "@theia/scm": "1.76.0-next.42+b0f9e63a6",
+    "@theia/search-in-workspace": "1.76.0-next.42+b0f9e63a6",
+    "@theia/task": "1.76.0-next.42+b0f9e63a6",
+    "@theia/telemetry": "1.76.0-next.42+b0f9e63a6",
+    "@theia/terminal": "1.76.0-next.42+b0f9e63a6",
+    "@theia/test": "1.76.0-next.42+b0f9e63a6",
+    "@theia/timeline": "1.76.0-next.42+b0f9e63a6",
+    "@theia/typehierarchy": "1.76.0-next.42+b0f9e63a6",
+    "@theia/variable-resolver": "1.76.0-next.42+b0f9e63a6",
+    "@theia/workspace": "1.76.0-next.42+b0f9e63a6",
     "@types/mime": "^2.0.3",
     "@vscode/debugprotocol": "^1.68.0",
     "@vscode/proxy-agent": "^0.13.2",
@@ -99,5 +100,5 @@
   "nyc": {
     "extends": "../../configs/nyc.json"
   },
-  "gitHead": "21b9b534224c55152fca0b67af7f8a8283dad2bd"
+  "gitHead": "b0f9e63a6d331135265869a341dce7c7f1eef158"
 }

package/src/common/plugin-api-rpc.ts

@@ -125,6 +125,7 @@ import * as notebookCommon from '@theia/notebook/lib/common';
 import { CellExecutionUpdateType, CellRange, NotebookCellExecutionState } from '@theia/notebook/lib/common';
 import { LanguagePackBundle } from './language-pack-service';
 import { AccessibilityInformation } from '@theia/core/lib/common/accessibility';
+import { TelemetryLevel } from '@theia/telemetry/lib/common/telemetry-types';
 
 import { TreeDelta } from '@theia/test/lib/common/tree-delta';
 import { TestItemDTO, TestOutputDTO, TestRunDTO, TestRunProfileDTO, TestRunRequestDTO, TestStateChangeDTO } from './test-types';
@@ -258,6 +259,12 @@ export interface PluginManagerInitializeParams {
     webview: WebviewInitData
     jsonValidation: PluginJsonValidationContribution[]
     supportedActivationEvents?: string[]
+    /**
+     * The telemetry level the plugin host starts with. Defaults to `off` when absent.
+     *
+     * @experimental
+     */
+    telemetryLevel?: TelemetryLevel
 }
 
 export interface PluginManagerStartParams {
@@ -2362,6 +2369,13 @@ export interface TelemetryMain {
 }
 
 export interface TelemetryExt {
+    /**
+     * Applies the telemetry level the user consented to. Only changes are sent this way;
+     * the initial level arrives with `PluginManagerInitializeParams`.
+     *
+     * @experimental
+     */
+    $onDidChangeTelemetryLevel(level: TelemetryLevel): void;
 }
 
 // endregion
@@ -2524,7 +2538,7 @@ export const MAIN_RPC_CONTEXT = {
     THEMING_EXT: createProxyIdentifier<ThemingExt>('ThemingExt'),
     COMMENTS_EXT: createProxyIdentifier<CommentsExt>('CommentsExt'),
     TABS_EXT: createProxyIdentifier<TabsExt>('TabsExt'),
-    TELEMETRY_EXT: createProxyIdentifier<TelemetryExt>('TelemetryExt)'),
+    TELEMETRY_EXT: createProxyIdentifier<TelemetryExt>('TelemetryExt'),
     TESTING_EXT: createProxyIdentifier<TestingExt>('TestingExt'),
     URI_EXT: createProxyIdentifier<UriExt>('UriExt'),
     MCP_SERVER_DEFINITION_REGISTRY_EXT: createProxyIdentifier<McpServerDefinitionRegistryExt>('McpServerDefinitionRegistryExt'),

package/src/hosted/browser/hosted-plugin.ts

@@ -73,6 +73,7 @@ import {
 } from '../common/hosted-plugin';
 import { isRemote } from '@theia/core/lib/browser/browser';
 import { WorkspaceTrustService } from '@theia/workspace/lib/browser/workspace-trust-service';
+import { TelemetryConsentProvider } from '@theia/telemetry/lib/common/telemetry-consent-provider';
 
 export type DebugActivationEvent = 'onDebugResolve' | 'onDebugInitialConfigurations' | 'onDebugAdapterProtocolTracker' | 'onDebugDynamicConfigurations';
 
@@ -183,6 +184,9 @@ export class HostedPluginSupport extends AbstractHostedPluginSupport<PluginManag
     @inject(WorkspaceTrustService)
     protected readonly workspaceTrustService: WorkspaceTrustService;
 
+    @inject(TelemetryConsentProvider)
+    protected readonly telemetryConsentProvider: TelemetryConsentProvider;
+
     @inject(ILogger) @named('plugin-ext:HostedPluginSupport')
     protected override readonly logger: ILogger;
 
@@ -245,7 +249,7 @@ export class HostedPluginSupport extends AbstractHostedPluginSupport<PluginManag
     }
 
     protected createTheiaReadyPromise(): Promise<unknown> {
-        return Promise.all([this.preferenceServiceImpl.ready, this.workspaceService.roots]);
+        return Promise.all([this.preferenceServiceImpl.ready, this.workspaceService.roots, this.telemetryConsentProvider.ready]);
     }
 
     protected override runOperation(operation: () => Promise<void>): Promise<void> {
@@ -364,7 +368,8 @@ export class HostedPluginSupport extends AbstractHostedPluginSupport<PluginManag
                 },
                 jsonValidation,
                 pluginKind: isRemote ? ExtensionKind.Workspace : ExtensionKind.UI,
-                supportedActivationEvents
+                supportedActivationEvents,
+                telemetryLevel: this.telemetryConsentProvider.level
             });
             if (toDisconnect.disposed) {
                 return undefined;

package/src/hosted/browser/worker/worker-main.ts

@@ -34,6 +34,7 @@ import { loadManifest } from './plugin-manifest-loader';
 import { EnvExtImpl } from '../../../plugin/env';
 import { DebugExtImpl } from '../../../plugin/debug/debug-ext';
 import { LocalizationExtImpl } from '../../../plugin/localization-ext';
+import { TelemetryExtImpl } from '../../../plugin/telemetry-ext';
 import pluginHostModule from './worker-plugin-module';
 import { PLUGINS_BASE_PATH } from '@theia/plugin-utils/lib/common/constants';
 
@@ -162,6 +163,7 @@ const messageRegistryExt = container.get(MessageRegistryExt);
 const clipboardExt = container.get(ClipboardExt);
 const webviewExt = container.get(WebviewsExtImpl);
 const localizationExt = container.get(LocalizationExtImpl);
+const telemetryExt = container.get(TelemetryExtImpl);
 const storageProxy = container.get(KeyValueStorageProxy);
 
 const apiFactory = createAPIFactory(
@@ -175,7 +177,8 @@ const apiFactory = createAPIFactory(
     messageRegistryExt,
     clipboardExt,
     webviewExt,
-    localizationExt
+    localizationExt,
+    telemetryExt
 );
 let defaultApi: typeof theia;
 

package/src/hosted/browser/worker/worker-plugin-module.ts

@@ -36,6 +36,7 @@ import { WorkerEnvExtImpl } from './worker-env-ext';
 import { DebugExtImpl } from '../../../plugin/debug/debug-ext';
 import { LocalizationExtImpl } from '../../../plugin/localization-ext';
 import { EncodingService } from '@theia/core/lib/common/encoding-service';
+import { TelemetryExtImpl } from '../../../plugin/telemetry-ext';
 
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 const ctx = self as any;
@@ -79,4 +80,5 @@ export default new ContainerModule(bind => {
     bind(WebviewsExtImpl).toSelf().inSingletonScope();
     bind(TerminalServiceExtImpl).toSelf().inSingletonScope();
     bind(MinimalTerminalServiceExt).toService(TerminalServiceExtImpl);
+    bind(TelemetryExtImpl).toSelf().inSingletonScope();
 });

package/src/hosted/node/plugin-host-module.ts

@@ -39,6 +39,7 @@ import { setupPluginHostLogger } from './plugin-host-logger';
 import { LmExtImpl } from '../../plugin/lm-ext';
 import { LanguageModelToolsExtImpl } from '../../plugin/lm-tool-ext';
 import { EncodingService } from '@theia/core/lib/common/encoding-service';
+import { TelemetryExtImpl } from '../../plugin/telemetry-ext';
 
 export default new ContainerModule(bind => {
     const channel = new IPCChannel();
@@ -76,4 +77,5 @@ export default new ContainerModule(bind => {
     bind(WebviewsExtImpl).toSelf().inSingletonScope();
     bind(MinimalTerminalServiceExt).toService(TerminalServiceExtImpl);
     bind(TerminalServiceExtImpl).toSelf().inSingletonScope();
+    bind(TelemetryExtImpl).toSelf().inSingletonScope();
 });

package/src/hosted/node/plugin-host-rpc.ts

@@ -31,6 +31,7 @@ import {
 import { PluginMetadata, PluginModel, PluginPackage } from '../../common/plugin-protocol';
 import { createAPIFactory } from '../../plugin/plugin-context';
 import { EnvExtImpl } from '../../plugin/env';
+import { TelemetryExtImpl } from '../../plugin/telemetry-ext';
 import { PreferenceRegistryExtImpl } from '../../plugin/preference-registry';
 import { ExtPluginApi, ExtPluginApiBackendInitializationFn } from '../../common/plugin-ext-api-contribution';
 import { DebugExtImpl } from '../../plugin/debug/debug-ext';
@@ -64,7 +65,8 @@ export interface ExtInterfaces {
     webviewExt: WebviewsExtImpl,
     terminalServiceExt: TerminalServiceExtImpl,
     secretsExt: SecretsExtImpl,
-    localizationExt: LocalizationExtImpl
+    localizationExt: LocalizationExtImpl,
+    telemetryExt: TelemetryExtImpl
 }
 
 /**
@@ -352,6 +354,9 @@ export class PluginHostRPC extends AbstractPluginHostRPC<PluginManagerExtImpl, P
     @inject(SecretsExtImpl)
     protected readonly secretsExt: SecretsExtImpl;
 
+    @inject(TelemetryExtImpl)
+    protected readonly telemetryExt: TelemetryExtImpl;
+
     constructor() {
         super('PLUGIN_HOST', '/scanners/backend-init-theia.js',
             {
@@ -380,18 +385,19 @@ export class PluginHostRPC extends AbstractPluginHostRPC<PluginManagerExtImpl, P
             webviewExt: this.webviewExt,
             terminalServiceExt: this.terminalServiceExt,
             secretsExt: this.secretsExt,
-            localizationExt: this.localizationExt
+            localizationExt: this.localizationExt,
+            telemetryExt: this.telemetryExt
         };
     }
 
     protected createAPIFactory(extInterfaces: ExtInterfaces): PluginAPIFactory {
         const {
             envExt, debugExt, preferenceRegistryExt, editorsAndDocumentsExt, workspaceExt,
-            messageRegistryExt, clipboardExt, webviewExt, localizationExt
+            messageRegistryExt, clipboardExt, webviewExt, localizationExt, telemetryExt
         } = extInterfaces;
         return createAPIFactory(this.rpc, this.pluginManager, envExt, debugExt, preferenceRegistryExt,
             editorsAndDocumentsExt, workspaceExt, messageRegistryExt, clipboardExt, webviewExt,
-            localizationExt);
+            localizationExt, telemetryExt);
     }
 
     protected initExtApi(extApi: ExtPluginApi): void {

package/src/main/browser/editors-and-documents-main.spec.ts

@@ -0,0 +1,140 @@
+// *****************************************************************************
+// Copyright (C) 2026 JuliaHub, Inc. and others.
+//
+// This program and the accompanying materials are made available under the
+// terms of the Eclipse Public License v. 2.0 which is available at
+// http://www.eclipse.org/legal/epl-2.0.
+//
+// This Source Code may also be made available under the following Secondary
+// Licenses when the conditions for such availability set forth in the Eclipse
+// Public License v. 2.0 are satisfied: GNU General Public License, version 2
+// with the GNU Classpath Exception which is available at
+// https://www.gnu.org/software/classpath/license.html.
+//
+// SPDX-License-Identifier: EPL-2.0 OR GPL-2.0-only WITH Classpath-exception-2.0
+// *****************************************************************************
+
+import { enableJSDOM } from '@theia/core/lib/browser/test/jsdom';
+let disableJSDOM = enableJSDOM();
+
+import { expect } from 'chai';
+import { Emitter, URI } from '@theia/core';
+import { BaseWidget, Navigatable, Saveable, SaveableSource, Widget } from '@theia/core/lib/browser';
+import { SaveableService } from '@theia/core/lib/browser/saveable-service';
+import { EditorManager, EditorWidget } from '@theia/editor/lib/browser';
+import { EditorsAndDocumentsMain } from './editors-and-documents-main';
+
+disableJSDOM();
+
+class TestSaveable implements Saveable {
+    dirty = true;
+    readonly onDirtyChanged = new Emitter<void>().event;
+    readonly onContentChanged = new Emitter<void>().event;
+    saveCount = 0;
+
+    async save(): Promise<void> {
+        this.saveCount++;
+        this.dirty = false;
+    }
+}
+
+/** Navigatable to the resource, but with nothing to save. */
+class TestNavigatableWidget extends BaseWidget implements Navigatable {
+    constructor(private readonly uri: URI) {
+        super();
+    }
+
+    getResourceUri(): URI {
+        return this.uri;
+    }
+
+    createMoveToUri(): URI {
+        return this.uri;
+    }
+}
+
+/** Stands in for a `CustomEditorWidget`: saveable and navigatable, but not an `EditorWidget`. */
+class TestSaveableWidget extends TestNavigatableWidget implements SaveableSource {
+    readonly saveable = new TestSaveable();
+}
+
+function createEditorsAndDocumentsMain(
+    editor: EditorWidget | undefined,
+    widgets: Widget[]
+): EditorsAndDocumentsMain {
+    // Bypass the constructor's RPC/container wiring: `save` and `saveAs` only touch the
+    // editor manager, the shell and the saveable service.
+    const main = Object.create(EditorsAndDocumentsMain.prototype) as EditorsAndDocumentsMain;
+    const fields = main as unknown as Record<string, unknown>;
+    fields.editorManager = { getByUri: async () => editor } as unknown as EditorManager;
+    fields.shell = { widgets };
+    fields.saveResourceService = new SaveableService();
+    return main;
+}
+
+describe('EditorsAndDocumentsMain#save', () => {
+
+    before(() => {
+        disableJSDOM = enableJSDOM();
+    });
+
+    after(() => {
+        disableJSDOM();
+    });
+
+    const uri = new URI('custom-editor:/some/resource?viewType=test');
+
+    it('saves a saveable widget that the editor manager does not know', async () => {
+        const widget = new TestSaveableWidget(uri);
+        const main = createEditorsAndDocumentsMain(undefined, [widget]);
+
+        const saved = await main.save(uri);
+
+        expect(widget.saveable.saveCount).to.equal(1);
+        expect(saved?.toString()).to.equal(uri.toString());
+    });
+
+    it('prefers the text editor when the editor manager has one', async () => {
+        const editor = new TestSaveableWidget(uri);
+        const custom = new TestSaveableWidget(uri);
+        const main = createEditorsAndDocumentsMain(editor as unknown as EditorWidget, [custom]);
+
+        await main.save(uri);
+
+        expect(editor.saveable.saveCount).to.equal(1);
+        expect(custom.saveable.saveCount).to.equal(0);
+    });
+
+    it('leaves widgets bound to another resource alone', async () => {
+        const other = new TestSaveableWidget(new URI('custom-editor:/other/resource'));
+        const main = createEditorsAndDocumentsMain(undefined, [other]);
+
+        const saved = await main.save(uri);
+
+        expect(other.saveable.saveCount).to.equal(0);
+        expect(saved).to.be.undefined;
+    });
+
+    it('ignores a widget that is navigatable to the resource but not saveable', async () => {
+        const main = createEditorsAndDocumentsMain(undefined, [new TestNavigatableWidget(uri)]);
+
+        expect(await main.save(uri)).to.be.undefined;
+    });
+
+    it('resolves saveAs through the same fallback', async () => {
+        const widget = new TestSaveableWidget(uri);
+        const main = createEditorsAndDocumentsMain(undefined, [widget]);
+        const saveAsTargets: Widget[] = [];
+        // `SaveableService.canSaveAs` is unconditionally false on the base class, so the
+        // service is stubbed to reach the `saveAs` branch at all.
+        (main as unknown as Record<string, unknown>).saveResourceService = {
+            canSaveAs: (candidate: Widget) => candidate === widget,
+            saveAs: async (target: Widget) => { saveAsTargets.push(target); return uri; }
+        };
+
+        const saved = await main.saveAs(uri);
+
+        expect(saveAsTargets).to.deep.equal([widget]);
+        expect(saved?.toString()).to.equal(uri.toString());
+    });
+});

package/src/main/browser/editors-and-documents-main.ts

@@ -33,6 +33,7 @@ import { MonacoEditor } from '@theia/monaco/lib/browser/monaco-editor';
 import { TextEditorMain } from './text-editor-main';
 import { DisposableCollection, Emitter, URI } from '@theia/core';
 import { EditorManager, EditorWidget } from '@theia/editor/lib/browser';
+import { ApplicationShell, NavigatableWidget, Saveable, Widget } from '@theia/core/lib/browser';
 import { SaveableService } from '@theia/core/lib/browser/saveable-service';
 import { TabsMainImpl } from './tabs/tabs-main';
 import { NotebookCellEditorService, NotebookEditorWidgetService } from '@theia/notebook/lib/browser';
@@ -48,6 +49,7 @@ export class EditorsAndDocumentsMain implements Disposable {
 
     private readonly modelService: EditorModelService;
     private readonly editorManager: EditorManager;
+    private readonly shell: ApplicationShell;
     private readonly saveResourceService: SaveableService;
     private readonly encodingRegistry: EncodingRegistry;
 
@@ -69,6 +71,7 @@ export class EditorsAndDocumentsMain implements Disposable {
         this.proxy = rpc.getProxy(MAIN_RPC_CONTEXT.EDITORS_AND_DOCUMENTS_EXT);
 
         this.editorManager = container.get(EditorManager);
+        this.shell = container.get(ApplicationShell);
         this.modelService = container.get(EditorModelService);
         this.saveResourceService = container.get(SaveableService);
         this.encodingRegistry = container.get(EncodingRegistry);
@@ -183,22 +186,31 @@ export class EditorsAndDocumentsMain implements Disposable {
     }
 
     async save(uri: URI): Promise<URI | undefined> {
-        const editor = await this.editorManager.getByUri(uri);
-        if (!editor) {
+        const widget = await this.getSaveTarget(uri);
+        if (!widget) {
             return undefined;
         }
-        return this.saveResourceService.save(editor);
+        return this.saveResourceService.save(widget);
     }
 
     async saveAs(uri: URI): Promise<URI | undefined> {
-        const editor = await this.editorManager.getByUri(uri);
-        if (!editor) {
+        const widget = await this.getSaveTarget(uri);
+        if (!widget) {
             return undefined;
         }
-        if (!this.saveResourceService.canSaveAs(editor)) {
+        if (!this.saveResourceService.canSaveAs(widget)) {
             return undefined;
         }
-        return this.saveResourceService.saveAs(editor);
+        return this.saveResourceService.saveAs(widget);
+    }
+
+    /**
+     * Resolve the widget holding `uri`, preferring a text editor. Custom editors and notebooks
+     * are not opened by the `EditorManager`, so they are only reachable through the shell.
+     */
+    protected async getSaveTarget(uri: URI): Promise<Widget | undefined> {
+        return await this.editorManager.getByUri(uri)
+            ?? this.shell.widgets.find(widget => Saveable.get(widget) && NavigatableWidget.getUri(widget)?.isEqual(uri));
     }
 
     saveAll(includeUntitled?: boolean): Promise<boolean> {