@theia/plugin-ext 1.29.0-next.9 → 1.29.1

package/src/main/node/plugin-localization-backend-contribution.ts

@@ -0,0 +1,42 @@
+// *****************************************************************************
+// Copyright (C) 2021 TypeFox and others.
+//
+// This program and the accompanying materials are made available under the
+// terms of the Eclipse Public License v. 2.0 which is available at
+// http://www.eclipse.org/legal/epl-2.0.
+//
+// This Source Code may also be made available under the following Secondary
+// Licenses when the conditions for such availability set forth in the Eclipse
+// Public License v. 2.0 are satisfied: GNU General Public License, version 2
+// with the GNU Classpath Exception which is available at
+// https://www.gnu.org/software/classpath/license.html.
+//
+// SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
+// *****************************************************************************
+
+import { inject, injectable } from '@theia/core/shared/inversify';
+import { LocalizationBackendContribution } from '@theia/core/lib/node/i18n/localization-backend-contribution';
+import { PluginDeployer } from '../../common/plugin-protocol';
+import { PluginDeployerImpl } from './plugin-deployer-impl';
+import { Deferred } from '@theia/core/lib/common/promise-util';
+
+@injectable()
+export class PluginLocalizationBackendContribution extends LocalizationBackendContribution {
+    @inject(PluginDeployer)
+    protected readonly pluginDeployer: PluginDeployerImpl;
+    protected readonly pluginsDeployed = new Deferred();
+
+    override async initialize(): Promise<void> {
+        this.pluginDeployer.onDidDeploy(() => {
+            this.pluginsDeployed.resolve();
+        });
+        await super.initialize();
+    }
+
+    override async waitForInitialization(): Promise<void> {
+        await Promise.all([
+            super.waitForInitialization(),
+            this.pluginsDeployed.promise,
+        ]);
+    }
+}

package/src/plugin/authentication-ext.ts

@@ -34,13 +34,6 @@ export class AuthenticationExtImpl implements AuthenticationExt {
     private proxy: AuthenticationMain;
     private authenticationProviders: Map<string, theia.AuthenticationProvider> = new Map<string, theia.AuthenticationProvider>();
 
-    private _providerIds: string[] = [];
-
-    private _providers: theia.AuthenticationProviderInformation[] = [];
-
-    private onDidChangeAuthenticationProvidersEmitter = new Emitter<theia.AuthenticationProvidersChangeEvent>();
-    readonly onDidChangeAuthenticationProviders: Event<theia.AuthenticationProvidersChangeEvent> = this.onDidChangeAuthenticationProvidersEmitter.event;
-
     private onDidChangeSessionsEmitter = new Emitter<theia.AuthenticationSessionsChangeEvent>();
     readonly onDidChangeSessions: Event<theia.AuthenticationSessionsChangeEvent> = this.onDidChangeSessionsEmitter.event;
 
@@ -48,18 +41,6 @@ export class AuthenticationExtImpl implements AuthenticationExt {
         this.proxy = rpc.getProxy(PLUGIN_RPC_CONTEXT.AUTHENTICATION_MAIN);
     }
 
-    getProviderIds(): Promise<ReadonlyArray<string>> {
-        return this.proxy.$getProviderIds();
-    }
-
-    get providerIds(): string[] {
-        return this._providerIds;
-    }
-
-    get providers(): ReadonlyArray<theia.AuthenticationProviderInformation> {
-        return Object.freeze(this._providers.slice());
-    }
-
     async getSession(requestingExtension: InternalPlugin, providerId: string, scopes: readonly string[],
         options: theia.AuthenticationGetSessionOptions & ({ createIfNone: true } | { forceNewSession: true } | { forceNewSession: { detail: string } })):
         Promise<theia.AuthenticationSession>;
@@ -76,29 +57,14 @@ export class AuthenticationExtImpl implements AuthenticationExt {
         return this.proxy.$getSession(providerId, scopes, extensionId, extensionName, options);
     }
 
-    async logout(providerId: string, sessionId: string): Promise<void> {
-        return this.proxy.$removeSession(providerId, sessionId);
-    }
-
     registerAuthenticationProvider(id: string, label: string, provider: theia.AuthenticationProvider, options?: theia.AuthenticationProviderOptions): theia.Disposable {
         if (this.authenticationProviders.get(id)) {
             throw new Error(`An authentication provider with id '${id}' is already registered.`);
         }
 
         this.authenticationProviders.set(id, provider);
-        if (this._providerIds.indexOf(id) === -1) {
-            this._providerIds.push(id);
-        }
-
-        if (!this._providers.find(p => p.id === id)) {
-            this._providers.push({
-                id,
-                label
-            });
-        }
-
         const listener = provider.onDidChangeSessions(e => {
-            this.proxy.$sendDidChangeSessions(id, e);
+            this.proxy.$onDidChangeSessions(id, e);
         });
 
         this.proxy.$registerAuthenticationProvider(id, label, !!options?.supportsMultipleAccounts);
@@ -106,16 +72,6 @@ export class AuthenticationExtImpl implements AuthenticationExt {
         return new Disposable(() => {
             listener.dispose();
             this.authenticationProviders.delete(id);
-            const index = this._providerIds.findIndex(pid => id === pid);
-            if (index > -1) {
-                this._providerIds.splice(index);
-            }
-
-            const i = this._providers.findIndex(p => p.id === id);
-            if (i > -1) {
-                this._providers.splice(i);
-            }
-
             this.proxy.$unregisterAuthenticationProvider(id);
         });
     }
@@ -163,30 +119,7 @@ export class AuthenticationExtImpl implements AuthenticationExt {
         throw new Error(`Unable to find authentication provider with handle: ${providerId}`);
     }
 
-    $onDidChangeAuthenticationSessions(id: string, label: string): Promise<void> {
-        this.onDidChangeSessionsEmitter.fire({ provider: { id, label } });
-        return Promise.resolve();
-    }
-
-    async $onDidChangeAuthenticationProviders(added: theia.AuthenticationProviderInformation[], removed: theia.AuthenticationProviderInformation[]): Promise<void> {
-        added.forEach(id => {
-            if (this._providers.indexOf(id) === -1) {
-                this._providers.push(id);
-            }
-        });
-
-        removed.forEach(p => {
-            const index = this._providers.findIndex(provider => provider.id === p.id);
-            if (index > -1) {
-                this._providers.splice(index);
-            }
-        });
-
-        this.onDidChangeAuthenticationProvidersEmitter.fire({ added, removed });
-    }
-
-    $setProviders(providers: theia.AuthenticationProviderInformation[]): Promise<void> {
-        this._providers.push(...providers);
-        return Promise.resolve(undefined);
+    async $onDidChangeAuthenticationSessions(provider: theia.AuthenticationProviderInformation): Promise<void> {
+        this.onDidChangeSessionsEmitter.fire({ provider });
     }
 }

package/src/plugin/debug/debug-ext.ts

@@ -31,7 +31,7 @@ import uuid = require('uuid');
 import { DebugAdapter } from '@theia/debug/lib/common/debug-model';
 import { PluginDebugAdapterCreator } from './plugin-debug-adapter-creator';
 import { NodeDebugAdapterCreator } from '../node/debug/plugin-node-debug-adapter-creator';
-import { DebugProtocol } from 'vscode-debugprotocol';
+import { DebugProtocol } from '@vscode/debugprotocol';
 
 interface ConfigurationProviderRecord {
     handle: number;

package/src/plugin/languages/code-action.ts

@@ -145,20 +145,17 @@ export class CodeActionAdapter {
         return this.cacheId++;
     }
 
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
-    private static _isCommand(smth: any): smth is theia.Command {
-        return typeof (<theia.Command>smth).command === 'string';
+    private static _isCommand(arg: unknown): arg is theia.Command {
+        return !!arg && typeof arg === 'object' && typeof (arg as theia.Command).command === 'string';
     }
 
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
-    private static _isSelection(obj: any): obj is Selection {
-        return (
-            obj
-            && (typeof obj.selectionStartLineNumber === 'number')
-            && (typeof obj.selectionStartColumn === 'number')
-            && (typeof obj.positionLineNumber === 'number')
-            && (typeof obj.positionColumn === 'number')
-        );
+    private static _isSelection(obj: unknown): obj is Selection {
+        const selection = obj as Selection;
+        return !!obj && typeof obj === 'object'
+            && typeof selection.selectionStartLineNumber === 'number'
+            && typeof selection.selectionStartColumn === 'number'
+            && typeof selection.positionLineNumber === 'number'
+            && typeof selection.positionColumn === 'number';
     }
 
 }

package/src/plugin/languages/document-highlight.ts

@@ -55,8 +55,7 @@ export class DocumentHighlightAdapter {
         });
     }
 
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
-    private isDocumentHighlightArray(array: any): array is types.DocumentHighlight[] {
+    private isDocumentHighlightArray(array: unknown): array is types.DocumentHighlight[] {
         return Array.isArray(array) && array.length > 0 && array[0] instanceof types.DocumentHighlight;
     }
 }

package/src/plugin/languages/util.ts

@@ -17,12 +17,10 @@
 import * as theia from '@theia/plugin';
 import * as types from '../types-impl';
 
-// eslint-disable-next-line @typescript-eslint/no-explicit-any
-export function isLocationArray(array: any): array is types.Location[] {
+export function isLocationArray(array: unknown): array is types.Location[] {
     return Array.isArray(array) && array.length > 0 && array[0] instanceof types.Location;
 }
 
-// eslint-disable-next-line @typescript-eslint/no-explicit-any
-export function isDefinitionLinkArray(array: any): array is theia.DefinitionLink[] {
+export function isDefinitionLinkArray(array: unknown): array is theia.DefinitionLink[] {
     return Array.isArray(array) && array.length > 0 && array[0].hasOwnProperty('targetUri') && array[0].hasOwnProperty('targetRange');
 }

package/src/plugin/plugin-context.ts

@@ -144,7 +144,8 @@ import {
     ExtensionMode,
     LinkedEditingRanges,
     LanguageStatusSeverity,
-    TextDocumentChangeReason
+    TextDocumentChangeReason,
+    InputBoxValidationSeverity
 } from './types-impl';
 import { AuthenticationExtImpl } from './authentication-ext';
 import { SymbolKind } from '../common/plugin-api-rpc-model';
@@ -224,50 +225,14 @@ export function createAPIFactory(
 
     return function (plugin: InternalPlugin): typeof theia {
         const authentication: typeof theia.authentication = {
-            // support older (< 1.53.0) and newer version of authentication provider registration
-            registerAuthenticationProvider(
-                id: string | theia.AuthenticationProvider, label?: string, provider?: theia.AuthenticationProvider, options?: theia.AuthenticationProviderOptions):
-                theia.Disposable {
-                // collect registration data based on registration type: new (all parameters given) vs old (data stored in provider)
-                const isNewRegistration = typeof id === 'string';
-                const regProvider = isNewRegistration ? provider! : id;
-                const regId = isNewRegistration ? id : regProvider.id;
-                const regLabel = isNewRegistration ? label! : regProvider.label;
-                const regOptions = isNewRegistration ? options : { supportsMultipleAccounts: regProvider.supportsMultipleAccounts };
-
-                // ensure that all methods of the new AuthenticationProvider are available or delegate otherwise
-                if (!regProvider['createSession']) {
-                    regProvider['createSession'] = (scopes: string[]) => regProvider.login(scopes);
-                }
-                if (!regProvider['removeSession']) {
-                    regProvider['removeSession'] = (sessionId: string) => regProvider.logout(sessionId);
-                }
-                return authenticationExt.registerAuthenticationProvider(regId, regLabel, regProvider, regOptions);
-            },
-            get onDidChangeAuthenticationProviders(): theia.Event<theia.AuthenticationProvidersChangeEvent> {
-                return authenticationExt.onDidChangeAuthenticationProviders;
-            },
-            getProviderIds(): Thenable<ReadonlyArray<string>> {
-                return Promise.resolve(authenticationExt.providerIds);
-            },
-            get providerIds(): string[] {
-                return authenticationExt.providerIds;
-            },
-            get providers(): ReadonlyArray<theia.AuthenticationProviderInformation> {
-                return authenticationExt.providers;
+            registerAuthenticationProvider(id: string, label: string, provider: theia.AuthenticationProvider, options?: theia.AuthenticationProviderOptions): theia.Disposable {
+                return authenticationExt.registerAuthenticationProvider(id, label, provider, options);
             },
             getSession(providerId: string, scopes: string[], options: theia.AuthenticationGetSessionOptions) {
                 return authenticationExt.getSession(plugin, providerId, scopes, options as any);
             },
-            logout(providerId: string, sessionId: string): Thenable<void> {
-                return authenticationExt.logout(providerId, sessionId);
-            },
             get onDidChangeSessions(): theia.Event<theia.AuthenticationSessionsChangeEvent> {
                 return authenticationExt.onDidChangeSessions;
-            },
-            async hasSession(providerId: string, scopes: readonly string[]): Promise<boolean> {
-                const session = await authenticationExt.getSession(plugin, providerId, scopes, { silent: true });
-                return !!session;
             }
         };
         const commands: typeof theia.commands = {
@@ -392,7 +357,7 @@ export function createAPIFactory(
                 }
             },
             // eslint-disable-next-line @typescript-eslint/no-explicit-any
-            showQuickPick(items: any, options: theia.QuickPickOptions, token?: theia.CancellationToken): any {
+            showQuickPick(items: any, options?: theia.QuickPickOptions, token?: theia.CancellationToken): any {
                 return quickOpenExt.showQuickPick(items, options, token);
             },
             createQuickPick<T extends QuickPickItem>(): QuickPick<T> {
@@ -1061,7 +1026,8 @@ export function createAPIFactory(
             FileDecoration,
             CancellationError,
             ExtensionMode,
-            LinkedEditingRanges
+            LinkedEditingRanges,
+            InputBoxValidationSeverity
         };
     };
 }

package/src/plugin/preference-registry.spec.ts

@@ -112,7 +112,6 @@ describe('PreferenceRegistryExtImpl:', () => {
         });
     });
 
-    /* eslint-disable no-unused-expressions */
     describe('toConfigurationChangeEvent', () => {
         // E.g. deletion of a `tasks.json`.
         it('Handles deletion of a section', () => {
@@ -252,4 +251,49 @@ describe('PreferenceRegistryExtImpl:', () => {
             expect(valuesRetrieved.tabSize).equal(4);
         });
     });
+
+    describe('Proxy Behavior', () => {
+        const deepConfig = {
+            'python.linting.enabled': true,
+            'python.linting.flake8Args': [],
+            'python.linting.flake8CategorySeverity.E': 'Error',
+            'python.linting.flake8CategorySeverity.F': 'Error',
+            'python.linting.flake8CategorySeverity.W': 'Warning',
+            'python.linting.flake8Enabled': false,
+            'python.linting.flake8Path': 'flake8',
+            'python.linting.ignorePatterns': ['.vscode/*.py', '**/site-packages/**/*.py'],
+            'python.linting.lintOnSave': true,
+            'python.linting.maxNumberOfProblems': 100,
+            'python.linting.banditArgs': [],
+            'python.linting.banditEnabled': false,
+            'python.linting.banditPath': 'bandit',
+            'python.linting.mypyArgs': [
+                '--ignore-missing-imports',
+                '--follow-imports=silent',
+                '--show-column-numbers'
+            ],
+            'python.linting.mypyCategorySeverity.error': 'Error',
+            'python.linting.mypyCategorySeverity.note': 'Information',
+            'python.linting.mypyEnabled': false,
+            'python.linting.mypyPath': 'mypy',
+        };
+        // https://github.com/eclipse-theia/theia/issues/11501
+        it("Doesn't violate proxy rules and return a proxy when the underlying object is expected.", () => {
+            preferenceRegistryExtImpl.init({
+                [PreferenceScope.Default]: deepConfig,
+                [PreferenceScope.User]: {},
+                [PreferenceScope.Workspace]: {},
+                [PreferenceScope.Folder]: {
+                    [workspaceRoot.toString()]: {},
+                }
+            });
+            const pythonConfig = preferenceRegistryExtImpl.getConfiguration('python', workspaceRoot);
+            const lintConfig = pythonConfig.get<Record<string, unknown>>('linting')!;
+            const stringDictionary = Object.create(null);
+            Object.keys(lintConfig).forEach(key => {
+                stringDictionary[key] = lintConfig[key];
+            });
+            expect(Boolean('Made it this far without throwing an error')).to.be.true;
+        });
+    });
 });

package/src/plugin/preference-registry.ts

@@ -129,6 +129,11 @@ export class PreferenceRegistryExtImpl implements PreferenceRegistryExt {
                         }
                         return new Proxy(target, {
                             get: (targ: any, prop: string) => {
+                                const config = Object.getOwnPropertyDescriptor(targ, prop);
+                                // This check ensures that https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Proxy/Proxy/get#invariants are satisfied
+                                if (config?.configurable === false && config?.writable === false) {
+                                    return targ[prop];
+                                }
                                 if (typeof prop === 'string' && prop.toLowerCase() === 'tojson') {
                                     cloneTarget();
                                     return () => clonedTarget;

package/src/plugin/quick-open.ts

@@ -24,13 +24,14 @@ import { CancellationToken } from '@theia/core/lib/common/cancellation';
 import { RPCProtocol } from '../common/rpc-protocol';
 import { Emitter, Event } from '@theia/core/lib/common/event';
 import { DisposableCollection } from '@theia/core/lib/common/disposable';
-import { QuickInputButtons, QuickPickItemKind, ThemeIcon } from './types-impl';
+import { InputBoxValidationSeverity, QuickInputButtons, QuickPickItemKind, ThemeIcon } from './types-impl';
 import { URI } from '@theia/core/shared/vscode-uri';
 import * as path from 'path';
 import { convertToTransferQuickPickItems } from './type-converters';
 import { PluginPackage } from '../common/plugin-protocol';
 import { QuickInputButtonHandle } from '@theia/core/lib/browser';
 import { MaybePromise } from '@theia/core/lib/common/types';
+import Severity from '@theia/monaco-editor-core/esm/vs/base/common/severity';
 
 const canceledName = 'Canceled';
 /**
@@ -65,7 +66,7 @@ export function getDarkIconUri(iconPath: URI | { light: URI; dark: URI; }): URI
 export class QuickOpenExtImpl implements QuickOpenExt {
     private proxy: QuickOpenMain;
     private onDidSelectItem: undefined | ((handle: number) => void);
-    private validateInputHandler?: (input: string) => MaybePromise<string | null | undefined>;
+    private validateInputHandler?: (input: string) => MaybePromise<string | theia.InputBoxValidationMessage | null | undefined>;
     private _sessions = new Map<number, QuickInputExt>(); // Each quickinput will have a number so that we know where to fire events
     private _instances = 0;
 
@@ -155,11 +156,36 @@ export class QuickOpenExtImpl implements QuickOpenExt {
         return this.proxy.$showInputBox(options, typeof this.validateInputHandler === 'function');
     }
 
-    $validateInput(input: string): Promise<string | null | undefined> | undefined {
-        if (this.validateInputHandler) {
-            return Promise.resolve(this.validateInputHandler(input));
+    async $validateInput(input: string): Promise<string | { content: string; severity: Severity; } | null | undefined> {
+        if (!this.validateInputHandler) {
+            return;
+        }
+
+        const result = await this.validateInputHandler(input);
+        if (!result || typeof result === 'string') {
+            return result;
         }
-        return undefined;
+
+        let severity: Severity;
+        switch (result.severity) {
+            case InputBoxValidationSeverity.Info:
+                severity = Severity.Info;
+                break;
+            case InputBoxValidationSeverity.Warning:
+                severity = Severity.Warning;
+                break;
+            case InputBoxValidationSeverity.Error:
+                severity = Severity.Error;
+                break;
+            default:
+                severity = result.message ? Severity.Error : Severity.Ignore;
+                break;
+        }
+
+        return {
+            content: result.message,
+            severity
+        };
     }
 
     // ---- QuickInput

package/src/plugin/type-converters.ts

@@ -137,9 +137,8 @@ export function toPosition(position: Position): types.Position {
     return new types.Position(position.lineNumber - 1, position.column - 1);
 }
 
-// eslint-disable-next-line @typescript-eslint/no-explicit-any
-function isDecorationOptions(something: any): something is theia.DecorationOptions {
-    return (typeof something.range !== 'undefined');
+function isDecorationOptions(arg: unknown): arg is theia.DecorationOptions {
+    return !!arg && typeof arg === 'object' && typeof (arg as theia.DecorationOptions).range !== 'undefined';
 }
 
 export function isDecorationOptionsArr(something: theia.Range[] | theia.DecorationOptions[]): something is theia.DecorationOptions[] {
@@ -182,11 +181,10 @@ interface Codeblock {
     value: string;
 }
 
-// eslint-disable-next-line @typescript-eslint/no-explicit-any
-function isCodeblock(thing: any): thing is Codeblock {
-    return thing && typeof thing === 'object'
-        && typeof (<Codeblock>thing).language === 'string'
-        && typeof (<Codeblock>thing).value === 'string';
+function isCodeblock(arg: unknown): arg is Codeblock {
+    return !!arg && typeof arg === 'object'
+        && typeof (arg as Codeblock).language === 'string'
+        && typeof (arg as Codeblock).value === 'string';
 }
 
 export function fromMarkdown(markup: theia.MarkdownString | theia.MarkedString): MarkdownStringDTO {
@@ -625,64 +623,58 @@ export function toSymbolTag(kind: model.SymbolTag): types.SymbolTag {
     }
 }
 
-// eslint-disable-next-line @typescript-eslint/no-explicit-any
-export function isModelLocation(thing: any): thing is model.Location {
-    if (!thing) {
-        return false;
-    }
-    return isModelRange((<model.Location>thing).range) &&
-        isUriComponents((<model.Location>thing).uri);
-}
-
-// eslint-disable-next-line @typescript-eslint/no-explicit-any
-export function isModelRange(thing: any): thing is model.Range {
-    if (!thing) {
+export function isModelLocation(arg: unknown): arg is model.Location {
+    if (!arg) {
         return false;
     }
-    return (('startLineNumber' in thing) && typeof thing.startLineNumber === 'number') &&
-        (('startColumn' in thing) && typeof thing.startColumn === 'number') &&
-        (('endLineNumber' in thing) && typeof thing.endLineNumber === 'number') &&
-        (('endColumn' in thing) && typeof thing.endColumn === 'number');
+    return !!arg &&
+        typeof arg === 'object' &&
+        isModelRange((arg as model.Location).range) &&
+        isUriComponents((arg as model.Location).uri);
 }
 
-// eslint-disable-next-line @typescript-eslint/no-explicit-any
-export function isUriComponents(thing: any): thing is UriComponents {
-    if (!thing) {
-        return false;
-    }
-    return (('scheme' in thing) && typeof thing.scheme === 'string') &&
-        (('path' in thing) && typeof thing.path === 'string') &&
-        (('query' in thing) && typeof thing.query === 'string') &&
-        (('fragment' in thing) && typeof thing.fragment === 'string');
+export function isModelRange(arg: unknown): arg is model.Range {
+    const range = arg as model.Range;
+    return !!arg && typeof arg === 'object' &&
+        typeof range.startLineNumber === 'number' &&
+        typeof range.startColumn === 'number' &&
+        typeof range.endLineNumber === 'number' &&
+        typeof range.endColumn === 'number';
 }
 
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
-export function isModelCallHierarchyItem(thing: any): thing is model.CallHierarchyItem {
-    if (!thing) {
-        return false;
-    }
-    return isModelRange(thing.range)
-        && isModelRange(thing.selectionRange)
-        && isUriComponents(thing.uri)
-        && !!thing.name;
-}
-
-// eslint-disable-next-line @typescript-eslint/no-explicit-any
-export function isModelCallHierarchyIncomingCall(thing: any): thing is model.CallHierarchyIncomingCall {
-    if (!thing) {
-        return false;
-    }
-    const maybeIncomingCall = thing as model.CallHierarchyIncomingCall;
-    return 'from' in maybeIncomingCall && 'fromRanges' in maybeIncomingCall && isModelCallHierarchyItem(maybeIncomingCall.from);
-}
-
-// eslint-disable-next-line @typescript-eslint/no-explicit-any
-export function isModelCallHierarchyOutgoingCall(thing: any): thing is model.CallHierarchyOutgoingCall {
-    if (!thing) {
-        return false;
-    }
-    const maybeOutgoingCall = thing as model.CallHierarchyOutgoingCall;
-    return 'to' in maybeOutgoingCall && 'fromRanges' in maybeOutgoingCall && isModelCallHierarchyItem(maybeOutgoingCall.to);
+export function isUriComponents(arg: unknown): arg is UriComponents {
+    const uriComponents = arg as UriComponents;
+    return !!arg && typeof arg === 'object' &&
+        typeof uriComponents.scheme === 'string' &&
+        typeof uriComponents.path === 'string' &&
+        typeof uriComponents.query === 'string' &&
+        typeof uriComponents.fragment === 'string';
+}
+
+export function isModelCallHierarchyItem(arg: unknown): arg is model.CallHierarchyItem {
+    const item = arg as model.CallHierarchyItem;
+    return !!item && typeof item === 'object'
+        && isModelRange(item.range)
+        && isModelRange(item.selectionRange)
+        && isUriComponents(item.uri)
+        && !!item.name;
+}
+
+export function isModelCallHierarchyIncomingCall(arg: unknown): arg is model.CallHierarchyIncomingCall {
+    const maybeIncomingCall = arg as model.CallHierarchyIncomingCall;
+    return !!arg && typeof arg === 'object' &&
+        'from' in maybeIncomingCall &&
+        'fromRanges' in maybeIncomingCall &&
+        isModelCallHierarchyItem(maybeIncomingCall.from);
+}
+
+export function isModelCallHierarchyOutgoingCall(arg: unknown): arg is model.CallHierarchyOutgoingCall {
+    const maybeOutgoingCall = arg as model.CallHierarchyOutgoingCall;
+    return !!arg && typeof arg === 'object' &&
+        'to' in maybeOutgoingCall &&
+        'fromRanges' in maybeOutgoingCall &&
+        isModelCallHierarchyItem(maybeOutgoingCall.to);
 }
 
 export function toLocation(value: model.Location): types.Location {