@theia/monaco 1.18.0 → 1.21.0-next.12

package/src/browser/monaco-command.ts

@@ -18,12 +18,13 @@ import { injectable, inject, optional } from '@theia/core/shared/inversify';
 import { Position, Location } from '@theia/core/shared/vscode-languageserver-types';
 import { CommandContribution, CommandRegistry, CommandHandler } from '@theia/core/lib/common/command';
 import { CommonCommands, QuickInputService, ApplicationShell } from '@theia/core/lib/browser';
-import { EditorCommands, EditorManager } from '@theia/editor/lib/browser';
+import { EditorCommands, EditorManager, EditorWidget } from '@theia/editor/lib/browser';
 import { MonacoEditor } from './monaco-editor';
 import { MonacoCommandRegistry, MonacoEditorCommandHandler } from './monaco-command-registry';
 import { MonacoEditorService } from './monaco-editor-service';
 import { MonacoTextModelService } from './monaco-text-model-service';
 import { ProtocolToMonacoConverter } from './protocol-to-monaco-converter';
+import { nls } from '@theia/core/lib/common/nls';
 
 export namespace MonacoCommands {
 
@@ -191,6 +192,7 @@ export class MonacoEditorCommandHandlers implements CommandContribution {
         this.monacoCommandRegistry.registerHandler(EditorCommands.CONFIG_EOL.id, this.newConfigEolHandler());
         this.monacoCommandRegistry.registerHandler(EditorCommands.INDENT_USING_SPACES.id, this.newConfigTabSizeHandler(true));
         this.monacoCommandRegistry.registerHandler(EditorCommands.INDENT_USING_TABS.id, this.newConfigTabSizeHandler(false));
+        this.monacoCommandRegistry.registerHandler(EditorCommands.REVERT_EDITOR.id, this.newRevertActiveEditorHandler());
         this.monacoCommandRegistry.registerHandler(EditorCommands.REVERT_AND_CLOSE.id, this.newRevertAndCloseActiveEditorHandler());
     }
 
@@ -214,11 +216,10 @@ export class MonacoEditorCommandHandlers implements CommandContribution {
     }
     protected configureIndentation(editor: MonacoEditor): void {
         const items = [true, false].map(useSpaces => ({
-            label: `Indent Using ${useSpaces ? 'Spaces' : 'Tabs'}`,
+            label: nls.localize(`vscode/indentation/indentUsing${useSpaces ? 'Spaces' : 'Tabs'}`, `Indent Using ${useSpaces ? 'Spaces' : 'Tabs'}`),
             execute: () => this.configureTabSize(editor, useSpaces)
-        })
-        );
-        this.quickInputService?.showQuickPick(items, { placeholder: 'Select Action' });
+        }));
+        this.quickInputService?.showQuickPick(items, { placeholder: nls.localizeByDefault('Select Action') });
     }
 
     protected newConfigEolHandler(): MonacoEditorCommandHandler {
@@ -234,7 +235,7 @@ export class MonacoEditorCommandHandlers implements CommandContribution {
             execute: () => this.setEol(editor, lineEnding)
         })
         );
-        this.quickInputService?.showQuickPick(items, { placeholder: 'Select End of Line Sequence' });
+        this.quickInputService?.showQuickPick(items, { placeholder: nls.localizeByDefault('Select End of Line Sequence') });
     }
 
     protected setEol(editor: MonacoEditor, lineEnding: string): void {
@@ -260,7 +261,7 @@ export class MonacoEditorCommandHandlers implements CommandContribution {
             const sizes = Array.from(Array(8), (_, x) => x + 1);
             const tabSizeOptions = sizes.map(size =>
             ({
-                label: size === tabSize ? `${size}   Configured Tab Size` : size.toString(),
+                label: size === tabSize ? size + '   ' + nls.localizeByDefault('Configured Tab Size') : size.toString(),
                 // eslint-disable-next-line @typescript-eslint/no-explicit-any
                 execute: () => model.updateOptions({
                     tabSize: size || tabSize,
@@ -268,27 +269,40 @@ export class MonacoEditorCommandHandlers implements CommandContribution {
                 })
             })
             );
-            this.quickInputService?.showQuickPick(tabSizeOptions, { placeholder: 'Select Tab Size for Current File' });
+            this.quickInputService?.showQuickPick(tabSizeOptions, { placeholder: nls.localizeByDefault('Select Tab Size for Current File') });
         }
     }
 
+    protected newRevertActiveEditorHandler(): MonacoEditorCommandHandler {
+        return {
+            execute: () => this.revertEditor(this.getActiveEditor().editor),
+        };
+    }
+
     protected newRevertAndCloseActiveEditorHandler(): MonacoEditorCommandHandler {
         return {
-            execute: async () => this.revertAndCloseActiveEditor()
+            execute: async () => this.revertAndCloseActiveEditor(this.getActiveEditor())
         };
     }
 
-    protected async revertAndCloseActiveEditor(): Promise<void> {
-        const editor = this.editorManager.currentEditor;
+    protected getActiveEditor(): { widget?: EditorWidget, editor?: MonacoEditor } {
+        const widget = this.editorManager.currentEditor;
+        return { widget, editor: widget && MonacoEditor.getCurrent(this.editorManager) };
+    }
+
+    protected async revertEditor(editor?: MonacoEditor): Promise<void> {
         if (editor) {
-            const monacoEditor = MonacoEditor.getCurrent(this.editorManager);
-            if (monacoEditor) {
-                try {
-                    await monacoEditor.document.revert();
-                    editor.close();
-                } catch (error) {
-                    await this.shell.closeWidget(editor.id, { save: false });
-                }
+            return editor.document.revert();
+        }
+    }
+
+    protected async revertAndCloseActiveEditor(current: { widget?: EditorWidget, editor?: MonacoEditor }): Promise<void> {
+        if (current.editor && current.widget) {
+            try {
+                await this.revertEditor(current.editor);
+                current.widget.close();
+            } catch (error) {
+                await this.shell.closeWidget(current.widget.id, { save: false });
             }
         }
     }

package/src/browser/monaco-editor-model.ts

@@ -14,14 +14,13 @@
  * SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
  ********************************************************************************/
 
-import { Position } from '@theia/core/shared/vscode-languageserver-types';
+import { Position, Range } from '@theia/core/shared/vscode-languageserver-types';
 import { TextDocumentSaveReason, TextDocumentContentChangeEvent } from '@theia/core/shared/vscode-languageserver-protocol';
 import { TextEditorDocument, EncodingMode, FindMatchesOptions, FindMatch, EditorPreferences, DEFAULT_WORD_SEPARATORS } from '@theia/editor/lib/browser';
 import { DisposableCollection, Disposable } from '@theia/core/lib/common/disposable';
 import { Emitter, Event } from '@theia/core/lib/common/event';
 import { CancellationTokenSource, CancellationToken } from '@theia/core/lib/common/cancellation';
 import { Resource, ResourceError, ResourceVersion } from '@theia/core/lib/common/resource';
-import { Range } from '@theia/core/shared/vscode-languageserver-types';
 import { Saveable, SaveOptions } from '@theia/core/lib/browser/saveable';
 import { MonacoToProtocolConverter } from './monaco-to-protocol-converter';
 import { ProtocolToMonacoConverter } from './protocol-to-monaco-converter';

package/src/browser/monaco-editor-provider.ts

@@ -19,7 +19,7 @@ import URI from '@theia/core/lib/common/uri';
 import { EditorPreferenceChange, EditorPreferences, TextEditor, DiffNavigator } from '@theia/editor/lib/browser';
 import { DiffUris } from '@theia/core/lib/browser/diff-uris';
 import { inject, injectable, named } from '@theia/core/shared/inversify';
-import { DisposableCollection, deepClone, Disposable, } from '@theia/core/lib/common';
+import { DisposableCollection, deepClone, Disposable } from '@theia/core/lib/common';
 import { TextDocumentSaveReason } from '@theia/core/shared/vscode-languageserver-protocol';
 import { MonacoCommandServiceFactory } from './monaco-command-service';
 import { MonacoContextMenuService } from './monaco-context-menu';

package/src/browser/monaco-frontend-module.ts

@@ -86,7 +86,7 @@ export default new ContainerModule((bind, unbind, isBound, rebind) => {
     bind(MonacoLanguages).toSelf().inSingletonScope();
     rebind(LanguageService).toService(MonacoLanguages);
     bind(WorkspaceSymbolCommand).toSelf().inSingletonScope();
-    for (const identifier of [CommandContribution, KeybindingContribution, QuickAccessContribution]) {
+    for (const identifier of [CommandContribution, KeybindingContribution, MenuContribution, QuickAccessContribution]) {
         bind(identifier).toService(WorkspaceSymbolCommand);
     }
 

package/src/browser/monaco-languages.ts

@@ -14,16 +14,14 @@
  * SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
  ********************************************************************************/
 
-import { Diagnostic } from '@theia/core/shared/vscode-languageserver-types';
+import { Diagnostic, SymbolInformation } from '@theia/core/shared/vscode-languageserver-types';
 import { injectable, inject, postConstruct } from '@theia/core/shared/inversify';
 import { ProblemManager } from '@theia/markers/lib/browser/problem/problem-manager';
 import URI from '@theia/core/lib/common/uri';
-import { Mutable } from '@theia/core/lib/common/types';
+import { MaybePromise, Mutable } from '@theia/core/lib/common/types';
 import { Disposable } from '@theia/core/lib/common/disposable';
-import { MaybePromise } from '@theia/core/lib/common/types';
 import { CancellationToken } from '@theia/core/lib/common/cancellation';
 import { WorkspaceSymbolParams } from '@theia/core/shared/vscode-languageserver-protocol';
-import { SymbolInformation } from '@theia/core/shared/vscode-languageserver-types';
 import { Language, LanguageService } from '@theia/core/lib/browser/language-service';
 import { MonacoDiagnosticCollection } from './monaco-diagnostic-collection';
 import { ProtocolToMonacoConverter } from './protocol-to-monaco-converter';

package/src/browser/monaco-loader.ts

@@ -16,7 +16,7 @@
 
 /* eslint-disable @typescript-eslint/no-explicit-any */
 
-import { nls } from '@theia/core/lib/browser/nls';
+import { nls } from '@theia/core/lib/common/nls';
 
 export function loadVsRequire(context: any): Promise<any> {
     // Monaco uses a custom amd loader that over-rides node's require.
@@ -48,11 +48,15 @@ export function loadVsRequire(context: any): Promise<any> {
 
 export function loadMonaco(vsRequire: any): Promise<void> {
     return new Promise<void>(resolve => {
-        if (nls.locale && ['de', 'es', 'fr', 'it', 'ja', 'ko', 'ru', 'zh-cn', 'zh-tw'].includes(nls.locale)) {
+        if (nls.locale) {
             vsRequire.config({
                 'vs/nls': {
                     availableLanguages: {
                         '*': nls.locale
+                    },
+                    loadBundle: (_name: string, _language: string, callback: (err: unknown, messages: Record<string, string[]>) => void) => {
+                        // The `monaco-nls.json` is build using the `translate-monaco.js` script file
+                        callback(undefined, createMessageBundle(require('../../data/monaco-nls.json')));
                     }
                 }
             });
@@ -162,3 +166,28 @@ export function clearMonacoQuickAccessProviders(): void {
     // Clear Monaco QuickAccessRegistry as it currently includes monaco internal providers and not Theia's providers
     registry.clear();
 }
+
+function createMessageBundle(bundle: Record<string, Record<string, string>>): Record<string, string[]> {
+    const result: Record<string, string[]> = {};
+    for (const [fullName, items] of Object.entries(bundle)) {
+        const nameIndex = fullName.lastIndexOf('/');
+        let name = fullName;
+        if (nameIndex >= 0) {
+            name = fullName.substring(nameIndex + 1);
+        }
+        const array: string[] = [];
+        const keys = Object.keys(items);
+        for (let i = 0; i < keys.length; i++) {
+            let key = keys[i];
+            if (key.startsWith('_duplicate/')) {
+                const index = Number(key.substring('_duplicate/'.length));
+                key = keys[index];
+                keys[i] = key;
+            }
+            const fullItemName = `vscode/${name}/${key}`;
+            array.push(nls.localize(fullItemName, items[key]));
+        }
+        result[fullName] = array;
+    }
+    return result;
+}

package/src/browser/monaco-menu.ts

@@ -16,8 +16,9 @@
 
 import { injectable, inject } from '@theia/core/shared/inversify';
 import { MenuContribution, MenuModelRegistry, MAIN_MENU_BAR, MenuPath } from '@theia/core/lib/common';
-import { EDITOR_CONTEXT_MENU } from '@theia/editor/lib/browser';
+import { EditorMainMenu, EDITOR_CONTEXT_MENU } from '@theia/editor/lib/browser';
 import { MonacoCommandRegistry } from './monaco-command-registry';
+import { nls } from '@theia/core/lib/common/nls';
 import MenuRegistry = monaco.actions.MenuRegistry;
 
 export interface MonacoActionGroup {
@@ -27,6 +28,7 @@ export interface MonacoActionGroup {
 export namespace MonacoMenus {
     export const SELECTION = [...MAIN_MENU_BAR, '3_selection'];
     export const PEEK_CONTEXT_SUBMENU: MenuPath = [...EDITOR_CONTEXT_MENU, 'navigation', 'peek_submenu'];
+    export const MARKERS_GROUP = [...EditorMainMenu.GO, '5_markers_group'];
 }
 
 @injectable()
@@ -50,7 +52,7 @@ export class MonacoEditorMenuContribution implements MenuContribution {
 
         this.registerPeekSubmenu(registry);
 
-        registry.registerSubmenu(MonacoMenus.SELECTION, 'Selection');
+        registry.registerSubmenu(MonacoMenus.SELECTION, nls.localizeByDefault('Selection'));
         for (const item of MenuRegistry.getMenuItems(monaco.actions.MenuId.MenubarSelectionMenu)) {
             if (!monaco.actions.isIMenuItem(item)) {
                 continue;
@@ -64,10 +66,54 @@ export class MonacoEditorMenuContribution implements MenuContribution {
                 registry.registerMenuAction(menuPath, { commandId, order, label });
             }
         }
+
+        // Builtin monaco language features commands.
+        registry.registerMenuAction(EditorMainMenu.LANGUAGE_FEATURES_GROUP, {
+            commandId: 'editor.action.quickOutline',
+            label: nls.localizeByDefault('Go to Symbol in Editor...'),
+            order: '1'
+        });
+        registry.registerMenuAction(EditorMainMenu.LANGUAGE_FEATURES_GROUP, {
+            commandId: 'editor.action.revealDefinition',
+            order: '2'
+        });
+        registry.registerMenuAction(EditorMainMenu.LANGUAGE_FEATURES_GROUP, {
+            commandId: 'editor.action.revealDeclaration',
+            order: '3'
+        });
+        registry.registerMenuAction(EditorMainMenu.LANGUAGE_FEATURES_GROUP, {
+            commandId: 'editor.action.goToTypeDefinition',
+            order: '4'
+        });
+        registry.registerMenuAction(EditorMainMenu.LANGUAGE_FEATURES_GROUP, {
+            commandId: 'editor.action.goToImplementation',
+            order: '5'
+        });
+        registry.registerMenuAction(EditorMainMenu.LANGUAGE_FEATURES_GROUP, {
+            commandId: 'editor.action.goToReferences',
+            order: '6'
+        });
+
+        registry.registerMenuAction(EditorMainMenu.LOCATION_GROUP, {
+            commandId: 'editor.action.jumpToBracket',
+            order: '2'
+        });
+
+        // Builtin monaco problem commands.
+        registry.registerMenuAction(MonacoMenus.MARKERS_GROUP, {
+            commandId: 'editor.action.marker.nextInFiles',
+            label: nls.localizeByDefault('Next Problem'),
+            order: '1'
+        });
+        registry.registerMenuAction(MonacoMenus.MARKERS_GROUP, {
+            commandId: 'editor.action.marker.prevInFiles',
+            label: nls.localizeByDefault('Previous Problem'),
+            order: '2'
+        });
     }
 
     protected registerPeekSubmenu(registry: MenuModelRegistry): void {
-        registry.registerSubmenu(MonacoMenus.PEEK_CONTEXT_SUBMENU, 'Peek');
+        registry.registerSubmenu(MonacoMenus.PEEK_CONTEXT_SUBMENU, nls.localizeByDefault('Peek'));
 
         for (const item of MenuRegistry.getMenuItems(monaco.actions.MenuId.EditorContextPeek)) {
             if (!monaco.actions.isIMenuItem(item)) {

package/src/browser/monaco-quick-input-service.ts

@@ -17,7 +17,8 @@
 
 import {
     InputBox, InputOptions, KeybindingRegistry, PickOptions,
-    QuickInputButton, QuickInputService, QuickPick, QuickPickItem, QuickPickItemButtonEvent, QuickPickItemHighlights, QuickPickOptions, QuickPickSeparator
+    QuickInputButton, QuickInputService, QuickPick, QuickPickItem,
+    QuickPickItemButtonEvent, QuickPickItemHighlights, QuickPickOptions, QuickPickSeparator
 } from '@theia/core/lib/browser';
 import { CancellationToken, Event } from '@theia/core/lib/common';
 import { injectable, inject } from '@theia/core/shared/inversify';
@@ -251,7 +252,15 @@ export class MonacoQuickInputService implements QuickInputService {
                 });
                 wrapped.onDidTriggerItemButton((evt: QuickPickItemButtonEvent<T>) => {
                     if (options.onDidTriggerItemButton) {
-                        options.onDidTriggerItemButton(evt);
+                        // https://github.com/theia-ide/vscode/blob/standalone/0.23.x/src/vs/base/parts/quickinput/browser/quickInput.ts#L1387
+                        options.onDidTriggerItemButton(
+                            {
+                                ...evt,
+                                removeItem: () => {
+                                    wrapped.items = wrapped.items.filter(item => item !== evt.item);
+                                    wrapped.activeItems = wrapped.activeItems.filter(item => item !== evt.item);
+                                }
+                            });
                     }
                 });
                 wrapped.onDidChangeSelection((selectedItems: Array<T>) => {

package/src/browser/monaco-status-bar-contribution.ts

@@ -15,7 +15,7 @@
  ********************************************************************************/
 
 import { injectable, inject } from '@theia/core/shared/inversify';
-import { DisposableCollection } from '@theia/core';
+import { DisposableCollection, nls } from '@theia/core';
 import { FrontendApplicationContribution, FrontendApplication, StatusBar, StatusBarAlignment } from '@theia/core/lib/browser';
 import { EditorCommands, EditorManager, EditorWidget } from '@theia/editor/lib/browser';
 import { MonacoEditor } from './monaco-editor';
@@ -66,13 +66,15 @@ export class MonacoStatusBarContribution implements FrontendApplicationContribut
         if (editor && editorModel) {
             const modelOptions = editorModel.getOptions();
             const tabSize = modelOptions.tabSize;
-            const useSpaceOrTab = modelOptions.insertSpaces ? 'Spaces' : 'Tab Size';
+            const useSpaceOrTab = modelOptions.insertSpaces
+                ? nls.localizeByDefault('Spaces: {0}', tabSize)
+                : nls.localizeByDefault('Tab Size: {0}', tabSize);
             this.statusBar.setElement('editor-status-tabbing-config', {
                 text: `${useSpaceOrTab}: ${tabSize}`,
                 alignment: StatusBarAlignment.RIGHT,
                 priority: 10,
                 command: EditorCommands.CONFIG_INDENTATION.id,
-                tooltip: 'Select Indentation'
+                tooltip: nls.localizeByDefault('Select Indentation')
             });
         }
     }
@@ -91,7 +93,7 @@ export class MonacoStatusBarContribution implements FrontendApplicationContribut
                 alignment: StatusBarAlignment.RIGHT,
                 priority: 11,
                 command: EditorCommands.CONFIG_EOL.id,
-                tooltip: 'Select End Of Line Sequence'
+                tooltip: nls.localizeByDefault('Select End of Line Sequence')
             });
         }
     }

package/src/browser/monaco-workspace.ts

@@ -205,14 +205,14 @@ export class MonacoWorkspace {
      * Applies given edits to the given model.
      * The model is saved if no editors is opened for it.
      */
-    applyBackgroundEdit(model: MonacoEditorModel, editOperations: monaco.editor.IIdentifiedSingleEditOperation[]): Promise<void> {
+    applyBackgroundEdit(model: MonacoEditorModel, editOperations: monaco.editor.IIdentifiedSingleEditOperation[], shouldSave = true): Promise<void> {
         return this.suppressOpenIfDirty(model, async () => {
             const editor = MonacoEditor.findByDocument(this.editorManager, model)[0];
             const cursorState = editor && editor.getControl().getSelections() || [];
             model.textEditorModel.pushStackElement();
             model.textEditorModel.pushEditOperations(cursorState, editOperations, () => cursorState);
             model.textEditorModel.pushStackElement();
-            if (!editor) {
+            if (!editor && shouldSave) {
                 await model.save();
             }
         });

package/src/browser/style/index.css

@@ -99,6 +99,13 @@
   font-family: sans-serif;
 }
 
+.monaco-editor .monaco-list .monaco-list-row.focused,
+.monaco-editor .monaco-list .monaco-list-row.focused,
+.monaco-editor .monaco-list .monaco-list-row.focused .suggest-icon {
+  color: var(--theia-list-activeSelectionForeground) !important;
+  background-color: var(--theia-list-activeSelectionBackground) !important;
+}
+
 /* Monaco Quick Input */
 .quick-input-widget {
   width: 600px !important;
@@ -221,3 +228,18 @@
 .monaco-editor .find-widget .matchesCount {
   font-family: var(--theia-ui-font-family);
 }
+
+.monaco-editor .monaco-action-bar .action-label.codicon {
+  color: var(--theia-foreground);
+}
+
+.monaco-editor .monaco-action-bar .action-item.active {
+	transform: none;
+}
+
+.monaco-editor .peekview-widget .monaco-list-row.focused.selected .label-name,
+.monaco-editor .peekview-widget .monaco-list-row.focused.selected .label-description,
+.monaco-editor .peekview-widget .monaco-list-row.focused.selected .monaco-highlighted-label,
+.monaco-editor .peekview-widget .monaco-list-row.focused.selected .codicon {
+  color: var(--theia-list-activeSelectionForeground) !important;
+}

package/src/browser/workspace-symbol-command.ts

@@ -17,25 +17,25 @@
 import { injectable, inject } from '@theia/core/shared/inversify';
 import { environment } from '@theia/core/shared/@theia/application-package/lib/environment';
 import { KeybindingContribution, KeybindingRegistry, OpenerService, LabelProvider } from '@theia/core/lib/browser';
-
 import { QuickAccessContribution, QuickAccessProvider, QuickInputService, QuickAccessRegistry, QuickPicks, QuickPickItem, findMatches } from '@theia/core/lib/browser/quick-input';
 import {
-    CommandRegistry, CommandHandler, Command, SelectionService, CancellationToken
+    CommandRegistry, CommandHandler, Command, SelectionService, CancellationToken,
+    CommandContribution, MenuContribution, MenuModelRegistry, nls
 } from '@theia/core/lib/common';
-import { CommandContribution } from '@theia/core/lib/common';
 import { Range, Position, SymbolInformation } from '@theia/core/shared/vscode-languageserver-types';
 import { WorkspaceSymbolParams } from '@theia/core/shared/vscode-languageserver-protocol';
 import { MonacoLanguages, WorkspaceSymbolProvider } from './monaco-languages';
 import URI from '@theia/core/lib/common/uri';
+import { EditorMainMenu } from '@theia/editor/lib/browser';
 
 @injectable()
-export class WorkspaceSymbolCommand implements QuickAccessProvider, CommandContribution, KeybindingContribution, CommandHandler, QuickAccessContribution {
+export class WorkspaceSymbolCommand implements QuickAccessProvider, CommandContribution, KeybindingContribution, MenuContribution, CommandHandler, QuickAccessContribution {
     public static readonly PREFIX = '#';
 
-    private command: Command = {
+    private command = Command.toDefaultLocalizedCommand({
         id: 'languages.workspace.symbol',
         label: 'Go to Symbol in Workspace...'
-    };
+    });
 
     @inject(MonacoLanguages) protected readonly languages: MonacoLanguages;
     @inject(OpenerService) protected readonly openerService: OpenerService;
@@ -56,6 +56,13 @@ export class WorkspaceSymbolCommand implements QuickAccessProvider, CommandContr
         commands.registerCommand(this.command, this);
     }
 
+    registerMenus(menus: MenuModelRegistry): void {
+        menus.registerMenuAction(EditorMainMenu.WORKSPACE_GROUP, {
+            commandId: this.command.id,
+            order: '2'
+        });
+    }
+
     private isElectron(): boolean {
         return environment.electron.is();
     }
@@ -72,7 +79,7 @@ export class WorkspaceSymbolCommand implements QuickAccessProvider, CommandContr
             getInstance: () => this,
             prefix: WorkspaceSymbolCommand.PREFIX,
             placeholder: '',
-            helpEntries: [{ description: 'Go to Symbol in Workspace', needsEditor: false }]
+            helpEntries: [{ description: nls.localizeByDefault('Go to Symbol in Workspace'), needsEditor: false }]
         });
     }
 
@@ -100,7 +107,9 @@ export class WorkspaceSymbolCommand implements QuickAccessProvider, CommandContr
                     const filteredSymbols = symbols.filter(el => el && el.length !== 0);
                     if (filteredSymbols.length === 0) {
                         items.push({
-                            label: filter.length === 0 ? 'Type to search for symbols' : 'No symbols matching',
+                            label: filter.length === 0
+                                ? nls.localize('theia/monaco/typeToSearchForSymbols', 'Type to search for symbols')
+                                : nls.localize('theia/monaco/noSymbolsMatching', 'No symbols matching'),
                         });
                     }
                 }).catch();

package/src/typings/monaco/index.d.ts

@@ -904,7 +904,7 @@ declare module monaco.services {
         removeDecorationType: monaco.editor.ICodeEditorService['removeDecorationType'];
         resolveDecorationOptions: monaco.editor.ICodeEditorService['resolveDecorationOptions'];
         /**
-         * It respects inline and emebedded editors in comparison to `getActiveCodeEditor`
+         * It respects inline and embedded editors in comparison to `getActiveCodeEditor`
          * which only respect standalone and diff modified editors.
          */
         getFocusedCodeEditor(): monaco.editor.ICodeEditor | undefined;
@@ -997,7 +997,7 @@ declare module monaco.services {
         private readonly _instantiatedModes: { [modeId: string]: IMode; };
         private readonly _onLanguagesMaybeChanged: Emitter<void>;
         readonly onDidCreateMode: monaco.IEvent<IMode>;
-        createByFilepathOrFirstLine(rsource: monaco.Uri | null, firstLine?: string): ILanguageSelection;
+        createByFilepathOrFirstLine(resource: monaco.Uri | null, firstLine?: string): ILanguageSelection;
         getLanguageIdentifier(modeId: string | LanguageId): LanguageIdentifier | null;
     }
 
@@ -1917,6 +1917,11 @@ declare module monaco.quickInput {
         button: IQuickInputButton;
         item: T;
     }
+
+    // https://github.com/theia-ide/vscode/blob/standalone/0.23.x/src/vs/base/parts/quickinput/common/quickInput.ts#L324
+    export interface IQuickPickItemButtonContext<T extends IQuickPickItem> extends IQuickPickItemButtonEvent<T> {
+        removeItem(): void;
+    }
 }
 
 declare module monaco.quickOpen {
@@ -2346,7 +2351,7 @@ declare module monaco.list {
             private user: string,
             container: HTMLElement,
             virtualDelegate: IListVirtualDelegate<T>,
-            renderers: IListRenderer<any /* TODO@joao */, any>[],
+            renderers: IListRenderer<any, any>[],
             private _options: IListOptions<T> = DefaultOptions
         )