@theia/external-terminal 1.34.3 → 1.34.4

package/src/electron-node/external-terminal-backend-module.ts

@@ -1,40 +1,40 @@
-// *****************************************************************************
-// Copyright (C) 2021 Ericsson and others.
-//
-// This program and the accompanying materials are made available under the
-// terms of the Eclipse Public License v. 2.0 which is available at
-// http://www.eclipse.org/legal/epl-2.0.
-//
-// This Source Code may also be made available under the following Secondary
-// Licenses when the conditions for such availability set forth in the Eclipse
-// Public License v. 2.0 are satisfied: GNU General Public License, version 2
-// with the GNU Classpath Exception which is available at
-// https://www.gnu.org/software/classpath/license.html.
-//
-// SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
-// *****************************************************************************
-
-import { ContainerModule, interfaces } from '@theia/core/shared/inversify';
-import { ConnectionHandler, JsonRpcConnectionHandler } from '@theia/core/lib/common';
-import { isWindows, isOSX } from '@theia/core/lib/common/os';
-import { ExternalTerminalService, externalTerminalServicePath } from '../common/external-terminal';
-import { MacExternalTerminalService } from './mac-external-terminal-service';
-import { LinuxExternalTerminalService } from './linux-external-terminal-service';
-import { WindowsExternalTerminalService } from './windows-external-terminal-service';
-
-export function bindExternalTerminalService(bind: interfaces.Bind): void {
-    const serviceProvider: interfaces.ServiceIdentifier<ExternalTerminalService> =
-        isWindows ? WindowsExternalTerminalService : isOSX ? MacExternalTerminalService : LinuxExternalTerminalService;
-    bind(serviceProvider).toSelf().inSingletonScope();
-    bind(ExternalTerminalService).toService(serviceProvider);
-
-    bind(ConnectionHandler).toDynamicValue(ctx =>
-        new JsonRpcConnectionHandler(externalTerminalServicePath, () =>
-            ctx.container.get(ExternalTerminalService)
-        )
-    ).inSingletonScope();
-}
-
-export default new ContainerModule(bind => {
-    bindExternalTerminalService(bind);
-});
+// *****************************************************************************
+// Copyright (C) 2021 Ericsson and others.
+//
+// This program and the accompanying materials are made available under the
+// terms of the Eclipse Public License v. 2.0 which is available at
+// http://www.eclipse.org/legal/epl-2.0.
+//
+// This Source Code may also be made available under the following Secondary
+// Licenses when the conditions for such availability set forth in the Eclipse
+// Public License v. 2.0 are satisfied: GNU General Public License, version 2
+// with the GNU Classpath Exception which is available at
+// https://www.gnu.org/software/classpath/license.html.
+//
+// SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
+// *****************************************************************************
+
+import { ContainerModule, interfaces } from '@theia/core/shared/inversify';
+import { ConnectionHandler, JsonRpcConnectionHandler } from '@theia/core/lib/common';
+import { isWindows, isOSX } from '@theia/core/lib/common/os';
+import { ExternalTerminalService, externalTerminalServicePath } from '../common/external-terminal';
+import { MacExternalTerminalService } from './mac-external-terminal-service';
+import { LinuxExternalTerminalService } from './linux-external-terminal-service';
+import { WindowsExternalTerminalService } from './windows-external-terminal-service';
+
+export function bindExternalTerminalService(bind: interfaces.Bind): void {
+    const serviceProvider: interfaces.ServiceIdentifier<ExternalTerminalService> =
+        isWindows ? WindowsExternalTerminalService : isOSX ? MacExternalTerminalService : LinuxExternalTerminalService;
+    bind(serviceProvider).toSelf().inSingletonScope();
+    bind(ExternalTerminalService).toService(serviceProvider);
+
+    bind(ConnectionHandler).toDynamicValue(ctx =>
+        new JsonRpcConnectionHandler(externalTerminalServicePath, () =>
+            ctx.container.get(ExternalTerminalService)
+        )
+    ).inSingletonScope();
+}
+
+export default new ContainerModule(bind => {
+    bindExternalTerminalService(bind);
+});

package/src/electron-node/linux-external-terminal-service.ts

@@ -1,95 +1,95 @@
-// *****************************************************************************
-// Copyright (C) 2021 Ericsson and others.
-//
-// This program and the accompanying materials are made available under the
-// terms of the Eclipse Public License v. 2.0 which is available at
-// http://www.eclipse.org/legal/epl-2.0.
-//
-// This Source Code may also be made available under the following Secondary
-// Licenses when the conditions for such availability set forth in the Eclipse
-// Public License v. 2.0 are satisfied: GNU General Public License, version 2
-// with the GNU Classpath Exception which is available at
-// https://www.gnu.org/software/classpath/license.html.
-//
-// SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
-// *****************************************************************************
-
-import * as cp from 'child_process';
-import * as fs from '@theia/core/shared/fs-extra';
-import { injectable } from '@theia/core/shared/inversify';
-import { OS } from '@theia/core/lib/common/os';
-import { FileUri } from '@theia/core/lib/node/file-uri';
-import { ExternalTerminalService, ExternalTerminalConfiguration } from '../common/external-terminal';
-
-/*---------------------------------------------------------------------------------------------
- *  Copyright (c) Microsoft Corporation. All rights reserved.
- *  Licensed under the MIT License. See License.txt in the project root for license information.
- *--------------------------------------------------------------------------------------------*/
-// some code copied and modified from https://github.com/microsoft/vscode/blob/1.52.1/src/vs/workbench/contrib/externalTerminal/node/externalTerminalService.ts
-
-@injectable()
-export class LinuxExternalTerminalService implements ExternalTerminalService {
-    protected DEFAULT_TERMINAL_LINUX_READY: Promise<string>;
-
-    async openTerminal(configuration: ExternalTerminalConfiguration, cwd: string): Promise<void> {
-        await this.spawnTerminal(configuration, FileUri.fsPath(cwd));
-    }
-
-    async getDefaultExec(): Promise<string> {
-        return this.getDefaultTerminalLinux();
-    }
-
-    /**
-     * Spawn the external terminal for the given options.
-     * - The method spawns the terminal application based on the preferences, else uses the default value.
-     * @param configuration the preference configuration.
-     * @param cwd the optional current working directory to spawn from.
-     */
-    protected async spawnTerminal(configuration: ExternalTerminalConfiguration, cwd?: string): Promise<void> {
-
-        // Use the executable value from the preferences if available, else fallback to the default.
-        const terminalConfig = configuration['terminal.external.linuxExec'];
-        const execPromise = terminalConfig ? Promise.resolve(terminalConfig) : this.getDefaultTerminalLinux();
-
-        return new Promise<void>((resolve, reject) => {
-            execPromise.then(exec => {
-                const env = cwd ? { cwd } : undefined;
-                const child = cp.spawn(exec, [], env);
-                child.on('error', reject);
-                child.on('exit', resolve);
-            });
-        });
-    }
-
-    /**
-     * Get the default terminal application on Linux.
-     * - The following method uses environment variables to identify the best default possible for each distro.
-     *
-     * @returns the default application on Linux.
-     */
-    protected async getDefaultTerminalLinux(): Promise<string> {
-        if (!this.DEFAULT_TERMINAL_LINUX_READY) {
-            this.DEFAULT_TERMINAL_LINUX_READY = new Promise(async resolve => {
-                if (OS.type() === OS.Type.Linux) {
-                    const isDebian = await fs.pathExists('/etc/debian_version');
-                    if (isDebian) {
-                        resolve('x-terminal-emulator');
-                    } else if (process.env.DESKTOP_SESSION === 'gnome' || process.env.DESKTOP_SESSION === 'gnome-classic') {
-                        resolve('gnome-terminal');
-                    } else if (process.env.DESKTOP_SESSION === 'kde-plasma') {
-                        resolve('konsole');
-                    } else if (process.env.COLORTERM) {
-                        resolve(process.env.COLORTERM);
-                    } else if (process.env.TERM) {
-                        resolve(process.env.TERM);
-                    } else {
-                        resolve('xterm');
-                    }
-                } else {
-                    resolve('xterm');
-                }
-            });
-        }
-        return this.DEFAULT_TERMINAL_LINUX_READY;
-    }
-}
+// *****************************************************************************
+// Copyright (C) 2021 Ericsson and others.
+//
+// This program and the accompanying materials are made available under the
+// terms of the Eclipse Public License v. 2.0 which is available at
+// http://www.eclipse.org/legal/epl-2.0.
+//
+// This Source Code may also be made available under the following Secondary
+// Licenses when the conditions for such availability set forth in the Eclipse
+// Public License v. 2.0 are satisfied: GNU General Public License, version 2
+// with the GNU Classpath Exception which is available at
+// https://www.gnu.org/software/classpath/license.html.
+//
+// SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
+// *****************************************************************************
+
+import * as cp from 'child_process';
+import * as fs from '@theia/core/shared/fs-extra';
+import { injectable } from '@theia/core/shared/inversify';
+import { OS } from '@theia/core/lib/common/os';
+import { FileUri } from '@theia/core/lib/node/file-uri';
+import { ExternalTerminalService, ExternalTerminalConfiguration } from '../common/external-terminal';
+
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the MIT License. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+// some code copied and modified from https://github.com/microsoft/vscode/blob/1.52.1/src/vs/workbench/contrib/externalTerminal/node/externalTerminalService.ts
+
+@injectable()
+export class LinuxExternalTerminalService implements ExternalTerminalService {
+    protected DEFAULT_TERMINAL_LINUX_READY: Promise<string>;
+
+    async openTerminal(configuration: ExternalTerminalConfiguration, cwd: string): Promise<void> {
+        await this.spawnTerminal(configuration, FileUri.fsPath(cwd));
+    }
+
+    async getDefaultExec(): Promise<string> {
+        return this.getDefaultTerminalLinux();
+    }
+
+    /**
+     * Spawn the external terminal for the given options.
+     * - The method spawns the terminal application based on the preferences, else uses the default value.
+     * @param configuration the preference configuration.
+     * @param cwd the optional current working directory to spawn from.
+     */
+    protected async spawnTerminal(configuration: ExternalTerminalConfiguration, cwd?: string): Promise<void> {
+
+        // Use the executable value from the preferences if available, else fallback to the default.
+        const terminalConfig = configuration['terminal.external.linuxExec'];
+        const execPromise = terminalConfig ? Promise.resolve(terminalConfig) : this.getDefaultTerminalLinux();
+
+        return new Promise<void>((resolve, reject) => {
+            execPromise.then(exec => {
+                const env = cwd ? { cwd } : undefined;
+                const child = cp.spawn(exec, [], env);
+                child.on('error', reject);
+                child.on('exit', resolve);
+            });
+        });
+    }
+
+    /**
+     * Get the default terminal application on Linux.
+     * - The following method uses environment variables to identify the best default possible for each distro.
+     *
+     * @returns the default application on Linux.
+     */
+    protected async getDefaultTerminalLinux(): Promise<string> {
+        if (!this.DEFAULT_TERMINAL_LINUX_READY) {
+            this.DEFAULT_TERMINAL_LINUX_READY = new Promise(async resolve => {
+                if (OS.type() === OS.Type.Linux) {
+                    const isDebian = await fs.pathExists('/etc/debian_version');
+                    if (isDebian) {
+                        resolve('x-terminal-emulator');
+                    } else if (process.env.DESKTOP_SESSION === 'gnome' || process.env.DESKTOP_SESSION === 'gnome-classic') {
+                        resolve('gnome-terminal');
+                    } else if (process.env.DESKTOP_SESSION === 'kde-plasma') {
+                        resolve('konsole');
+                    } else if (process.env.COLORTERM) {
+                        resolve(process.env.COLORTERM);
+                    } else if (process.env.TERM) {
+                        resolve(process.env.TERM);
+                    } else {
+                        resolve('xterm');
+                    }
+                } else {
+                    resolve('xterm');
+                }
+            });
+        }
+        return this.DEFAULT_TERMINAL_LINUX_READY;
+    }
+}

package/src/electron-node/mac-external-terminal-service.ts

@@ -1,70 +1,70 @@
-// *****************************************************************************
-// Copyright (C) 2021 Ericsson and others.
-//
-// This program and the accompanying materials are made available under the
-// terms of the Eclipse Public License v. 2.0 which is available at
-// http://www.eclipse.org/legal/epl-2.0.
-//
-// This Source Code may also be made available under the following Secondary
-// Licenses when the conditions for such availability set forth in the Eclipse
-// Public License v. 2.0 are satisfied: GNU General Public License, version 2
-// with the GNU Classpath Exception which is available at
-// https://www.gnu.org/software/classpath/license.html.
-//
-// SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
-// *****************************************************************************
-
-import * as cp from 'child_process';
-import { injectable } from '@theia/core/shared/inversify';
-import { FileUri } from '@theia/core/lib/node/file-uri';
-import { ExternalTerminalService, ExternalTerminalConfiguration } from '../common/external-terminal';
-
-/*---------------------------------------------------------------------------------------------
- *  Copyright (c) Microsoft Corporation. All rights reserved.
- *  Licensed under the MIT License. See License.txt in the project root for license information.
- *--------------------------------------------------------------------------------------------*/
-// some code copied and modified from https://github.com/microsoft/vscode/blob/1.52.1/src/vs/workbench/contrib/externalTerminal/node/externalTerminalService.ts
-
-@injectable()
-export class MacExternalTerminalService implements ExternalTerminalService {
-    protected osxOpener = '/usr/bin/open';
-    protected defaultTerminalApp = 'Terminal.app';
-
-    async openTerminal(configuration: ExternalTerminalConfiguration, cwd: string): Promise<void> {
-        await this.spawnTerminal(configuration, FileUri.fsPath(cwd));
-    }
-
-    async getDefaultExec(): Promise<string> {
-        return this.getDefaultTerminalOSX();
-    }
-
-    /**
-     * Spawn the external terminal for the given options.
-     * - The method spawns the terminal application based on the preferences, else uses the default value.
-     * @param configuration the preference configuration.
-     * @param cwd the optional current working directory to spawn from.
-     */
-    protected async spawnTerminal(configuration: ExternalTerminalConfiguration, cwd?: string): Promise<void> {
-
-        // Use the executable value from the preferences if available, else fallback to the default.
-        const terminalConfig = configuration['terminal.external.osxExec'];
-        const terminalApp = terminalConfig || this.getDefaultTerminalOSX();
-
-        return new Promise<void>((resolve, reject) => {
-            const args = ['-a', terminalApp];
-            if (cwd) {
-                args.push(cwd);
-            }
-            const child = cp.spawn(this.osxOpener, args);
-            child.on('error', reject);
-            child.on('exit', () => resolve());
-        });
-    }
-
-    /**
-     * Get the default terminal app on OSX.
-     */
-    protected getDefaultTerminalOSX(): string {
-        return this.defaultTerminalApp;
-    }
-}
+// *****************************************************************************
+// Copyright (C) 2021 Ericsson and others.
+//
+// This program and the accompanying materials are made available under the
+// terms of the Eclipse Public License v. 2.0 which is available at
+// http://www.eclipse.org/legal/epl-2.0.
+//
+// This Source Code may also be made available under the following Secondary
+// Licenses when the conditions for such availability set forth in the Eclipse
+// Public License v. 2.0 are satisfied: GNU General Public License, version 2
+// with the GNU Classpath Exception which is available at
+// https://www.gnu.org/software/classpath/license.html.
+//
+// SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
+// *****************************************************************************
+
+import * as cp from 'child_process';
+import { injectable } from '@theia/core/shared/inversify';
+import { FileUri } from '@theia/core/lib/node/file-uri';
+import { ExternalTerminalService, ExternalTerminalConfiguration } from '../common/external-terminal';
+
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the MIT License. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+// some code copied and modified from https://github.com/microsoft/vscode/blob/1.52.1/src/vs/workbench/contrib/externalTerminal/node/externalTerminalService.ts
+
+@injectable()
+export class MacExternalTerminalService implements ExternalTerminalService {
+    protected osxOpener = '/usr/bin/open';
+    protected defaultTerminalApp = 'Terminal.app';
+
+    async openTerminal(configuration: ExternalTerminalConfiguration, cwd: string): Promise<void> {
+        await this.spawnTerminal(configuration, FileUri.fsPath(cwd));
+    }
+
+    async getDefaultExec(): Promise<string> {
+        return this.getDefaultTerminalOSX();
+    }
+
+    /**
+     * Spawn the external terminal for the given options.
+     * - The method spawns the terminal application based on the preferences, else uses the default value.
+     * @param configuration the preference configuration.
+     * @param cwd the optional current working directory to spawn from.
+     */
+    protected async spawnTerminal(configuration: ExternalTerminalConfiguration, cwd?: string): Promise<void> {
+
+        // Use the executable value from the preferences if available, else fallback to the default.
+        const terminalConfig = configuration['terminal.external.osxExec'];
+        const terminalApp = terminalConfig || this.getDefaultTerminalOSX();
+
+        return new Promise<void>((resolve, reject) => {
+            const args = ['-a', terminalApp];
+            if (cwd) {
+                args.push(cwd);
+            }
+            const child = cp.spawn(this.osxOpener, args);
+            child.on('error', reject);
+            child.on('exit', () => resolve());
+        });
+    }
+
+    /**
+     * Get the default terminal app on OSX.
+     */
+    protected getDefaultTerminalOSX(): string {
+        return this.defaultTerminalApp;
+    }
+}

package/src/electron-node/windows-external-terminal-service.ts

@@ -1,110 +1,110 @@
-// *****************************************************************************
-// Copyright (C) 2021 Ericsson and others.
-//
-// This program and the accompanying materials are made available under the
-// terms of the Eclipse Public License v. 2.0 which is available at
-// http://www.eclipse.org/legal/epl-2.0.
-//
-// This Source Code may also be made available under the following Secondary
-// Licenses when the conditions for such availability set forth in the Eclipse
-// Public License v. 2.0 are satisfied: GNU General Public License, version 2
-// with the GNU Classpath Exception which is available at
-// https://www.gnu.org/software/classpath/license.html.
-//
-// SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
-// *****************************************************************************
-
-import * as cp from 'child_process';
-import * as path from 'path';
-import { injectable } from '@theia/core/shared/inversify';
-import { FileUri } from '@theia/core/lib/node/file-uri';
-import { ExternalTerminalService, ExternalTerminalConfiguration } from '../common/external-terminal';
-
-/*---------------------------------------------------------------------------------------------
- *  Copyright (c) Microsoft Corporation. All rights reserved.
- *  Licensed under the MIT License. See License.txt in the project root for license information.
- *--------------------------------------------------------------------------------------------*/
-// some code copied and modified from https://github.com/microsoft/vscode/blob/1.52.1/src/vs/workbench/contrib/externalTerminal/node/externalTerminalService.ts
-
-@injectable()
-export class WindowsExternalTerminalService implements ExternalTerminalService {
-    protected readonly CMD = 'cmd.exe';
-    protected DEFAULT_TERMINAL_WINDOWS: string;
-
-    async openTerminal(configuration: ExternalTerminalConfiguration, cwd: string): Promise<void> {
-        await this.spawnTerminal(configuration, FileUri.fsPath(cwd));
-    }
-
-    async getDefaultExec(): Promise<string> {
-        return this.getDefaultTerminalWindows();
-    }
-
-    /**
-     * Spawn the external terminal for the given options.
-     * - The method spawns the terminal application based on the preferences, else uses the default value.
-     * @param configuration the preference configuration.
-     * @param cwd the optional current working directory to spawn from.
-     */
-    protected async spawnTerminal(configuration: ExternalTerminalConfiguration, cwd?: string): Promise<void> {
-
-        // Use the executable value from the preferences if available, else fallback to the default.
-        const terminalConfig = configuration['terminal.external.windowsExec'];
-        const exec = terminalConfig || this.getDefaultTerminalWindows();
-
-        // Make the drive letter uppercase on Windows (https://github.com/microsoft/vscode/issues/9448).
-        if (cwd && cwd[1] === ':') {
-            cwd = cwd[0].toUpperCase() + cwd.substr(1);
-        }
-
-        // cmder ignores the environment cwd and instead opts to always open in %USERPROFILE%
-        // unless otherwise specified.
-        const basename = path.basename(exec).toLowerCase();
-        if (basename === 'cmder' || basename === 'cmder.exe') {
-            cp.spawn(exec, cwd ? [cwd] : undefined);
-            return;
-        }
-
-        const cmdArgs = ['/c', 'start', '/wait'];
-        // The "" argument is the window title. Without this, exec doesn't work when the path contains spaces.
-        if (exec.indexOf(' ') >= 0) {
-            cmdArgs.push('""');
-        }
-
-        cmdArgs.push(exec);
-
-        // Add starting directory parameter for Windows Terminal app.
-        if (basename === 'wt' || basename === 'wt.exe') {
-            cmdArgs.push('-d .');
-        }
-
-        return new Promise<void>(async (resolve, reject) => {
-            const env = cwd ? { cwd } : undefined;
-            const command = this.getWindowsShell();
-            const child = cp.spawn(command, cmdArgs, env);
-            child.on('error', reject);
-            child.on('exit', resolve);
-        });
-    }
-
-    /**
-     * Get the default terminal application on Windows.
-     * - The following method uses environment variables to identify the best default possible value.
-     *
-     * @returns the default application on Windows.
-     */
-    protected getDefaultTerminalWindows(): string {
-        if (!this.DEFAULT_TERMINAL_WINDOWS) {
-            const isWoW64 = !!process.env.hasOwnProperty('PROCESSOR_ARCHITEW6432');
-            this.DEFAULT_TERMINAL_WINDOWS = `${process.env.windir ? process.env.windir : 'C:\\Windows'}\\${isWoW64 ? 'Sysnative' : 'System32'}\\cmd.exe`;
-        }
-        return this.DEFAULT_TERMINAL_WINDOWS;
-    }
-
-    /**
-     * Find the Windows Shell process to start up (defaults to cmd.exe).
-     */
-    protected getWindowsShell(): string {
-        // Find the path to cmd.exe if possible (%compsec% environment variable).
-        return process.env.compsec || this.CMD;
-    }
-}
+// *****************************************************************************
+// Copyright (C) 2021 Ericsson and others.
+//
+// This program and the accompanying materials are made available under the
+// terms of the Eclipse Public License v. 2.0 which is available at
+// http://www.eclipse.org/legal/epl-2.0.
+//
+// This Source Code may also be made available under the following Secondary
+// Licenses when the conditions for such availability set forth in the Eclipse
+// Public License v. 2.0 are satisfied: GNU General Public License, version 2
+// with the GNU Classpath Exception which is available at
+// https://www.gnu.org/software/classpath/license.html.
+//
+// SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
+// *****************************************************************************
+
+import * as cp from 'child_process';
+import * as path from 'path';
+import { injectable } from '@theia/core/shared/inversify';
+import { FileUri } from '@theia/core/lib/node/file-uri';
+import { ExternalTerminalService, ExternalTerminalConfiguration } from '../common/external-terminal';
+
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the MIT License. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+// some code copied and modified from https://github.com/microsoft/vscode/blob/1.52.1/src/vs/workbench/contrib/externalTerminal/node/externalTerminalService.ts
+
+@injectable()
+export class WindowsExternalTerminalService implements ExternalTerminalService {
+    protected readonly CMD = 'cmd.exe';
+    protected DEFAULT_TERMINAL_WINDOWS: string;
+
+    async openTerminal(configuration: ExternalTerminalConfiguration, cwd: string): Promise<void> {
+        await this.spawnTerminal(configuration, FileUri.fsPath(cwd));
+    }
+
+    async getDefaultExec(): Promise<string> {
+        return this.getDefaultTerminalWindows();
+    }
+
+    /**
+     * Spawn the external terminal for the given options.
+     * - The method spawns the terminal application based on the preferences, else uses the default value.
+     * @param configuration the preference configuration.
+     * @param cwd the optional current working directory to spawn from.
+     */
+    protected async spawnTerminal(configuration: ExternalTerminalConfiguration, cwd?: string): Promise<void> {
+
+        // Use the executable value from the preferences if available, else fallback to the default.
+        const terminalConfig = configuration['terminal.external.windowsExec'];
+        const exec = terminalConfig || this.getDefaultTerminalWindows();
+
+        // Make the drive letter uppercase on Windows (https://github.com/microsoft/vscode/issues/9448).
+        if (cwd && cwd[1] === ':') {
+            cwd = cwd[0].toUpperCase() + cwd.substr(1);
+        }
+
+        // cmder ignores the environment cwd and instead opts to always open in %USERPROFILE%
+        // unless otherwise specified.
+        const basename = path.basename(exec).toLowerCase();
+        if (basename === 'cmder' || basename === 'cmder.exe') {
+            cp.spawn(exec, cwd ? [cwd] : undefined);
+            return;
+        }
+
+        const cmdArgs = ['/c', 'start', '/wait'];
+        // The "" argument is the window title. Without this, exec doesn't work when the path contains spaces.
+        if (exec.indexOf(' ') >= 0) {
+            cmdArgs.push('""');
+        }
+
+        cmdArgs.push(exec);
+
+        // Add starting directory parameter for Windows Terminal app.
+        if (basename === 'wt' || basename === 'wt.exe') {
+            cmdArgs.push('-d .');
+        }
+
+        return new Promise<void>(async (resolve, reject) => {
+            const env = cwd ? { cwd } : undefined;
+            const command = this.getWindowsShell();
+            const child = cp.spawn(command, cmdArgs, env);
+            child.on('error', reject);
+            child.on('exit', resolve);
+        });
+    }
+
+    /**
+     * Get the default terminal application on Windows.
+     * - The following method uses environment variables to identify the best default possible value.
+     *
+     * @returns the default application on Windows.
+     */
+    protected getDefaultTerminalWindows(): string {
+        if (!this.DEFAULT_TERMINAL_WINDOWS) {
+            const isWoW64 = !!process.env.hasOwnProperty('PROCESSOR_ARCHITEW6432');
+            this.DEFAULT_TERMINAL_WINDOWS = `${process.env.windir ? process.env.windir : 'C:\\Windows'}\\${isWoW64 ? 'Sysnative' : 'System32'}\\cmd.exe`;
+        }
+        return this.DEFAULT_TERMINAL_WINDOWS;
+    }
+
+    /**
+     * Find the Windows Shell process to start up (defaults to cmd.exe).
+     */
+    protected getWindowsShell(): string {
+        // Find the path to cmd.exe if possible (%compsec% environment variable).
+        return process.env.compsec || this.CMD;
+    }
+}