@theia/core 1.77.0-next.4 → 1.77.0-next.43

package/src/common/core-preferences.ts

@@ -153,18 +153,18 @@ export const corePreferenceSchema: PreferenceSchema = {
         'http.proxy': {
             type: 'string',
             pattern: '^https?://([^:]*(:[^@]*)?@)?([^:]+|\\[[:0-9a-fA-F]+\\])(:\\d+)?/?$|^$',
-            markdownDescription: nls.localizeByDefault('The proxy setting to use. If not set, will be inherited from the `http_proxy` and `https_proxy` environment variables. When during [remote development](https://aka.ms/vscode-remote) the {0} setting is disabled this setting can be configured in the local and the remote settings separately.'),
+            markdownDescription: nls.localize('theia/core/http/proxy', 'The proxy setting to use. If not set, will be inherited from the `http_proxy` and `https_proxy` environment variables.'),
             scope: PreferenceScope.User
         },
         'http.proxyStrictSSL': {
             type: 'boolean',
             default: true,
-            description: nls.localizeByDefault('Controls whether the proxy server certificate should be verified against the list of supplied CAs. When during [remote development](https://aka.ms/vscode-remote) the {0} setting is disabled this setting can be configured in the local and the remote settings separately.'),
+            description: nls.localize('theia/core/http/proxyStrictSSL', 'Controls whether the proxy server certificate should be verified against the list of supplied CAs.'),
             scope: PreferenceScope.User
         },
         'http.proxyAuthorization': {
             type: 'string',
-            markdownDescription: nls.localizeByDefault('The value to send as the `Proxy-Authorization` header for every network request. When during [remote development](https://aka.ms/vscode-remote) the {0} setting is disabled this setting can be configured in the local and the remote settings separately.'),
+            markdownDescription: nls.localize('theia/core/http/proxyAuthorization', 'The value to send as the `Proxy-Authorization` header for every network request.'),
             scope: PreferenceScope.User
         },
         'http.proxySupport': {
@@ -177,13 +177,13 @@ export const corePreferenceSchema: PreferenceSchema = {
                 nls.localizeByDefault('Enable proxy support for extensions, override request options.'),
             ],
             default: 'override',
-            description: nls.localizeByDefault('Use the proxy support for extensions. When during [remote development](https://aka.ms/vscode-remote) the {0} setting is disabled this setting can be configured in the local and the remote settings separately.'),
+            description: nls.localize('theia/core/http/proxySupport', 'Use the proxy support for extensions.'),
             scope: PreferenceScope.User
         },
         'http.systemCertificates': {
             type: 'boolean',
             default: true,
-            description: nls.localizeByDefault('Controls whether CA certificates should be loaded from the OS. On Windows and macOS, a reload of the window is required after turning this off. When during [remote development](https://aka.ms/vscode-remote) the {0} setting is disabled this setting can be configured in the local and the remote settings separately.'),
+            description: nls.localize('theia/core/http/systemCertificates', 'Controls whether CA certificates should be loaded from the OS. On Windows and macOS, a reload of the window is required after turning this off.'),
             scope: PreferenceScope.User
         },
         'workbench.list.openMode': {

package/src/node/messaging/binary-message-pipe.spec.ts

@@ -0,0 +1,81 @@
+// *****************************************************************************
+// Copyright (C) 2026 Ivan Baksheev and others.
+//
+// This program and the accompanying materials are made available under the
+// terms of the Eclipse Public License v. 2.0 which is available at
+// http://www.eclipse.org/legal/epl-2.0.
+//
+// This Source Code may also be made available under the following Secondary
+// Licenses when the conditions for such availability set forth in the Eclipse
+// Public License v. 2.0 are satisfied: GNU General Public License, version 2
+// with the GNU Classpath Exception which is available at
+// https://www.gnu.org/software/classpath/license.html.
+//
+// SPDX-License-Identifier: EPL-2.0 OR GPL-2.0-only WITH Classpath-exception-2.0
+// *****************************************************************************
+
+import { expect } from 'chai';
+import { PassThrough } from 'stream';
+import { BinaryMessagePipe } from './binary-message-pipe';
+
+class TestBinaryMessagePipe extends BinaryMessagePipe {
+    override encodeMessageStart(message: Uint8Array): Uint8Array {
+        return super.encodeMessageStart(message);
+    }
+
+    override get messageStartByteLength(): number {
+        return super.messageStartByteLength;
+    }
+}
+
+describe('BinaryMessagePipe', () => {
+    const payload = Buffer.alloc(64, 0x41);
+    let headerLength: number;
+    let headerSplit: number;
+    let stream: PassThrough;
+    let pipe: TestBinaryMessagePipe;
+    let messages: Buffer[];
+    let frame: Buffer;
+
+    beforeEach(() => {
+        stream = new PassThrough();
+        pipe = new TestBinaryMessagePipe(stream);
+        headerLength = pipe.messageStartByteLength;
+        headerSplit = Math.floor(headerLength / 2);
+        messages = [];
+        frame = encodeFrame(payload);
+        pipe.onMessage(message => messages.push(Buffer.from(message)));
+    });
+
+    afterEach(() => {
+        pipe.dispose();
+        stream.destroy();
+    });
+
+    it('accumulates consecutive chunks that are shorter than the header', () => {
+        stream.emit('data', frame.subarray(0, headerSplit));
+        stream.emit('data', frame.subarray(headerSplit, headerLength));
+        stream.emit('data', frame.subarray(headerLength));
+
+        expect(messages).to.deep.equal([payload]);
+    });
+
+    it('receives the original payload when the header is split between chunks', () => {
+        stream.emit('data', frame.subarray(0, headerSplit));
+        stream.emit('data', frame.subarray(headerSplit));
+
+        expect(messages).to.deep.equal([payload]);
+    });
+
+    it('preserves the next frame in the same chunk after a partial header', () => {
+        const nextPayload = Buffer.from('next');
+        stream.emit('data', frame.subarray(0, headerSplit));
+        stream.emit('data', Buffer.concat([frame.subarray(headerSplit), encodeFrame(nextPayload)]));
+
+        expect(messages).to.deep.equal([payload, nextPayload]);
+    });
+
+    function encodeFrame(message: Uint8Array): Buffer {
+        return Buffer.concat([Buffer.from(pipe.encodeMessageStart(message)), Buffer.from(message)]);
+    }
+});

package/src/node/messaging/binary-message-pipe.ts

@@ -57,6 +57,10 @@ export class BinaryMessagePipe implements Disposable {
     }
 
     protected handleNewMessage(chunk: Uint8Array): void {
+        if (this.cachedMessageData.partialMessageStart) {
+            chunk = Buffer.concat([this.cachedMessageData.partialMessageStart, chunk]);
+            this.cachedMessageData.partialMessageStart = undefined;
+        }
         if (chunk.byteLength < this.messageStartByteLength) {
             // The chunk only contains a part of the encoded message start
             this.cachedMessageData.partialMessageStart = chunk;
@@ -137,10 +141,7 @@ export class BinaryMessagePipe implements Disposable {
      * @throws An error if the message start can not be read successfully.
      */
     protected readMessageStart(chunk: Uint8Array): number {
-        const messageData = this.cachedMessageData.partialMessageStart ? Buffer.concat([this.cachedMessageData.partialMessageStart, chunk]) : chunk;
-        this.cachedMessageData.partialMessageStart = undefined;
-
-        const reader = new Uint8ArrayReadBuffer(messageData);
+        const reader = new Uint8ArrayReadBuffer(chunk);
         const identifier = reader.readString();
 
         if (identifier !== BinaryMessagePipe.MESSAGE_START_IDENTIFIER) {