@theia/ai-ide 1.72.1 → 1.72.3

package/src/browser/ai-configuration/tools-configuration-widget.tsx

@@ -197,31 +197,120 @@ export class AIToolsConfigurationWidget extends AITableConfigurationWidget<ToolI
 
     protected override renderHeader(): React.ReactNode {
         return (
-            <div className="ai-tools-configuration-header">
-                <div style={{ fontWeight: 500 }}>
-                    {nls.localize('theia/ai/ide/toolsConfiguration/default/label', 'Default Tool Confirmation Mode:')}
+            <>
+                <div className="ai-tools-configuration-header">
+                    <div style={{ fontWeight: 500 }}>
+                        {nls.localize('theia/ai/ide/toolsConfiguration/default/label', 'Default Tool Confirmation Mode:')}
+                    </div>
+                    <select
+                        className="theia-select"
+                        value={this.defaultState}
+                        onChange={this.handleDefaultStateChange}
+                    >
+                        {TOOL_OPTIONS.map(opt => (
+                            <option key={opt.value} value={opt.value}>{opt.label}</option>
+                        ))}
+                    </select>
+                    <button
+                        className='theia-button secondary ai-tools-reset-button'
+                        style={{ marginLeft: 'auto' }}
+                        title={nls.localize('theia/ai/ide/toolsConfiguration/resetAllTooltip', 'Reset all tools to default')}
+                        onClick={() => this.resetAllToolsToDefault()}
+                    >
+                        {nls.localize('theia/ai/ide/toolsConfiguration/resetAll', 'Reset All')}
+                    </button>
                 </div>
-                <select
-                    className="theia-select"
-                    value={this.defaultState}
-                    onChange={this.handleDefaultStateChange}
-                >
-                    {TOOL_OPTIONS.map(opt => (
-                        <option key={opt.value} value={opt.value}>{opt.label}</option>
-                    ))}
-                </select>
+                {this.renderRecommendedDefaultsBanner()}
+            </>
+        );
+    }
+
+    protected renderRecommendedDefaultsBanner(): React.ReactNode {
+        if (this.defaultState !== ToolConfirmationMode.CONFIRM) {
+            return undefined;
+        }
+        return (
+            <div className="ai-tools-recommended-defaults-banner">
+                <span className="ai-tools-recommended-defaults-text">
+                    {nls.localize(
+                        'theia/ai/ide/toolsConfiguration/recommendedDefaults/message',
+                        'Tool calls currently require approval. Auto-allow all built-in tools at once.' +
+                        ' Tools that require extra confirmation (e.g. shell execution), MCP tools,' +
+                        ' and any tools added later will still ask before running.'
+                    )}
+                </span>
                 <button
-                    className='theia-button secondary ai-tools-reset-button'
-                    style={{ marginLeft: 'auto' }}
-                    title={nls.localize('theia/ai/ide/toolsConfiguration/resetAllTooltip', 'Reset all tools to default')}
-                    onClick={() => this.resetAllToolsToDefault()}
+                    className='theia-button main'
+                    onClick={() => this.allowCurrentTools()}
                 >
-                    {nls.localize('theia/ai/ide/toolsConfiguration/resetAll', 'Reset All')}
+                    {nls.localize('theia/ai/ide/toolsConfiguration/recommendedDefaults/apply', 'Allow Default Tools')}
                 </button>
             </div>
         );
     }
 
+    protected async allowCurrentTools(): Promise<void> {
+        const dialog = new ConfirmDialog({
+            title: nls.localize('theia/ai/ide/toolsConfiguration/recommendedDefaults/dialogTitle', 'Allow Default Tools?'),
+            msg: this.buildAllowCurrentToolsMessage(),
+            ok: nls.localize('theia/ai/ide/toolsConfiguration/recommendedDefaults/dialogConfirm', 'I understand, allow'),
+            cancel: nls.localizeByDefault('Cancel')
+        });
+        const confirmed = await dialog.open();
+        if (!confirmed) {
+            return;
+        }
+        // Leave the global default at CONFIRM so any tool added later still requires confirmation.
+        // Skip tools that require extra consent (confirmAlwaysAllow), MCP tools (third-party code
+        // that should require informed per-tool consent), and tools the user has explicitly disabled.
+        const updates: Array<{ toolId: string; mode: ToolConfirmationMode; toolRequest: ToolRequest }> = [];
+        for (const tool of this.toolInvocationRegistry.getAllFunctions()) {
+            if (tool.confirmAlwaysAllow) {
+                continue;
+            }
+            if (tool.name.startsWith('mcp_')) {
+                continue;
+            }
+            if (this.toolConfirmationModes[tool.name] === ToolConfirmationMode.DISABLED) {
+                continue;
+            }
+            updates.push({ toolId: tool.name, mode: ToolConfirmationMode.ALWAYS_ALLOW, toolRequest: tool });
+        }
+        await this.confirmationManager.setConfirmationModes(updates);
+    }
+
+    protected buildAllowCurrentToolsMessage(): HTMLElement {
+        const container = document.createElement('div');
+        const lines = [
+            nls.localize(
+                'theia/ai/ide/toolsConfiguration/recommendedDefaults/msg/line1',
+                'This sets all currently registered built-in tools to "Always Allow".'
+            ),
+            nls.localize(
+                'theia/ai/ide/toolsConfiguration/recommendedDefaults/msg/line2',
+                'Tools that require extra confirmation (such as shell execution) will still ask before running.'
+            ),
+            nls.localize(
+                'theia/ai/ide/toolsConfiguration/recommendedDefaults/msg/line3',
+                'MCP tools are third-party and are not included. You can allow them individually in this view.'
+            ),
+            nls.localize(
+                'theia/ai/ide/toolsConfiguration/recommendedDefaults/msg/line4',
+                'Tools added later will still default to "Confirm" so you can review them.'
+            ),
+            nls.localize(
+                'theia/ai/ide/toolsConfiguration/recommendedDefaults/msg/line5',
+                'You can change this later in this view.'
+            )
+        ];
+        for (const line of lines) {
+            const p = document.createElement('p');
+            p.textContent = line;
+            container.appendChild(p);
+        }
+        return container;
+    }
+
     protected getEffectiveState(toolName: string): ToolConfirmationMode {
         // If there's an explicit setting for this tool, use it
         const explicitSetting = this.toolConfirmationModes[toolName];

package/src/browser/ide-chat-welcome-message-provider.tsx

@@ -24,7 +24,9 @@ import { AgentService, FrontendLanguageModelRegistry } from '@theia/ai-core/lib/
 import { PreferenceService } from '@theia/core/lib/common';
 import { DEFAULT_CHAT_AGENT_PREF, BYPASS_MODEL_REQUIREMENT_PREF } from '@theia/ai-chat/lib/common/ai-chat-preferences';
 import { ChatAgentRecommendationService, ChatAgentService } from '@theia/ai-chat/lib/common';
-import { OPEN_AI_CONFIG_VIEW } from './ai-configuration/ai-configuration-view-contribution';
+import { ToolConfirmationManager } from '@theia/ai-chat/lib/browser/chat-tool-preference-bindings';
+import { DEFAULT_TOOL_CONFIRMATION_PREFERENCE, TOOL_CONFIRMATION_PREFERENCE, ToolConfirmationMode } from '@theia/ai-chat/lib/common/chat-tool-preferences';
+import { OPEN_AI_CONFIG_VIEW, OPEN_AI_CONFIG_VIEW_TOOLS } from './ai-configuration/ai-configuration-view-contribution';
 import { AIActivationService } from '@theia/ai-core/lib/browser';
 import { FrontendApplicationConfigProvider } from '@theia/core/lib/browser/frontend-application-config-provider';
 import { WorkspaceCommands } from '@theia/workspace/lib/browser/workspace-commands';
@@ -83,6 +85,9 @@ export class IdeChatWelcomeMessageProvider implements ChatWelcomeMessageProvider
     @inject(AgentService)
     protected agentService: AgentService;
 
+    @inject(ToolConfirmationManager)
+    protected readonly toolConfirmationManager: ToolConfirmationManager;
+
     @inject(AIActivationService)
     protected readonly activationService: AIActivationService;
 
@@ -120,6 +125,9 @@ export class IdeChatWelcomeMessageProvider implements ChatWelcomeMessageProvider
                         this._modelRequirementBypassed = effectiveValue;
                         this.notifyStateChanged();
                     }
+                } else if (e.preferenceName === DEFAULT_TOOL_CONFIRMATION_PREFERENCE || e.preferenceName === TOOL_CONFIRMATION_PREFERENCE) {
+                    // Re-render so the tool-confirmation explainer is hidden once the user configures confirmation behavior.
+                    this.notifyStateChanged();
                 }
             })
         );
@@ -186,6 +194,19 @@ export class IdeChatWelcomeMessageProvider implements ChatWelcomeMessageProvider
         return this._defaultAgent;
     }
 
+    /**
+     * Whether to show the tool-confirmation explainer on the welcome screen.
+     *
+     * Only shown while the user is still in the default state, i.e. every tool call is confirmed and
+     * no per-tool overrides exist. Once the user has changed the default mode (e.g. to always allow
+     * or to disable tools) or pre-approved individual tools (including via bulk approval), they are
+     * already aware of the mechanism, so the explainer is suppressed.
+     */
+    protected get shouldShowToolConfirmationInfo(): boolean {
+        return this.toolConfirmationManager.getDefaultConfirmationMode() === ToolConfirmationMode.CONFIRM
+            && Object.keys(this.toolConfirmationManager.getAllConfirmationSettings()).length === 0;
+    }
+
     protected setModelRequirementBypassed(bypassed: boolean): void {
         this.preferenceService.set(BYPASS_MODEL_REQUIREMENT_PREF, bypassed, PreferenceScope.User);
     }
@@ -227,6 +248,27 @@ Attach context with *#{3}*, *#{4}*, *#{5}*, or click {6}. [Learn more](https://t
                 className="theia-WelcomeMessage-Content"
                 markdownOptions={{ supportHtml: true }}
             />
+            {this.shouldShowToolConfirmationInfo && (
+                <div className="theia-alert theia-info-alert theia-WelcomeMessage-Alert">
+                    <div className="theia-message-header">
+                        <span className={codicon('info')}></span>
+                        <span>{nls.localize('theia/ai/ide/toolConfirmationInfo/header', 'Tool confirmation')}</span>
+                    </div>
+                    <div className="theia-message-content">
+                        <LocalizedMarkdown
+                            localizationKey="theia/ai/ide/toolConfirmationInfo"
+                            defaultMarkdown={
+                                'AI agents may want to use tools to act on your workspace. ' +
+                                'By default each tool call needs your confirmation. ' +
+                                'You can change this default or pre-approve individual tools in the [Tools configuration view]({0}).'
+                            }
+                            args={[`command:${OPEN_AI_CONFIG_VIEW_TOOLS.id}`]}
+                            markdownRenderer={this.markdownRenderer}
+                            markdownOptions={{ isTrusted: { enabledCommands: [OPEN_AI_CONFIG_VIEW_TOOLS.id] } }}
+                        />
+                    </div>
+                </div>
+            )}
         </div>;
     }
 

package/src/browser/style/index.css

@@ -1251,6 +1251,22 @@
   border-radius: 3px;
 }
 
+.ai-tools-recommended-defaults-banner {
+  display: flex;
+  align-items: center;
+  gap: calc(var(--theia-ui-padding) * 2);
+  margin-bottom: calc(var(--theia-ui-padding) * 2);
+  padding: calc(var(--theia-ui-padding) * 1.5);
+  background-color: var(--theia-editorInfo-background, var(--theia-editor-background));
+  border: var(--theia-border-width) solid var(--theia-editorInfo-border, var(--theia-widget-border));
+  border-radius: 3px;
+}
+
+.ai-tools-recommended-defaults-text {
+  flex: 1;
+  line-height: var(--theia-content-line-height);
+}
+
 .ai-tools-configuration-default-section {
   margin-bottom: calc(var(--theia-ui-padding) * 2);
 }

package/src/browser/todo-tool-renderer.tsx

@@ -20,11 +20,16 @@ import { ResponseNode } from '@theia/ai-chat-ui/lib/browser/chat-tree-view';
 import { ChatResponseContent, ToolCallChatResponseContent } from '@theia/ai-chat/lib/common';
 import { ReactNode } from '@theia/core/shared/react';
 import * as React from '@theia/core/shared/react';
-import { codicon, ContextMenuRenderer, OpenerService } from '@theia/core/lib/browser';
+import { codicon, ContextMenuRenderer, KeybindingRegistry, OpenerService } from '@theia/core/lib/browser';
 import { nls } from '@theia/core';
 import { TODO_WRITE_FUNCTION_ID, TodoItem, isValidTodoItem } from '../common/todo-tool';
-import { withToolCallConfirmation } from '@theia/ai-chat-ui/lib/browser/chat-response-renderer/tool-confirmation';
+import { ToolConfirmationKeybindingHints, withToolCallConfirmation } from '@theia/ai-chat-ui/lib/browser/chat-response-renderer/tool-confirmation';
+import {
+    APPROVE_LATEST_TOOL_CONFIRMATION_COMMAND,
+    DENY_LATEST_TOOL_CONFIRMATION_COMMAND
+} from '@theia/ai-chat-ui/lib/browser/tool-confirmation-keybinding-contribution';
 import { ToolConfirmationManager } from '@theia/ai-chat/lib/browser/chat-tool-preference-bindings';
+import { PendingToolConfirmationTracker } from '@theia/ai-chat/lib/browser/pending-tool-confirmation-tracker';
 import { ToolInvocationRegistry } from '@theia/ai-core';
 
 interface TodoListComponentProps {
@@ -95,6 +100,12 @@ export class TodoToolRenderer implements ChatResponsePartRenderer<ToolCallChatRe
     @inject(ToolInvocationRegistry)
     protected toolInvocationRegistry: ToolInvocationRegistry;
 
+    @inject(PendingToolConfirmationTracker)
+    protected pendingToolConfirmationTracker: PendingToolConfirmationTracker;
+
+    @inject(KeybindingRegistry)
+    protected keybindingRegistry: KeybindingRegistry;
+
     canHandle(response: ChatResponseContent): number {
         if (ToolCallChatResponseContent.is(response) && response.name === TODO_WRITE_FUNCTION_ID) {
             return 20;
@@ -128,7 +139,9 @@ export class TodoToolRenderer implements ChatResponsePartRenderer<ToolCallChatRe
                     chatId,
                     requestCanceled: parentNode.response.isCanceled,
                     contextMenuRenderer: this.contextMenuRenderer,
-                    openerService: this.openerService
+                    openerService: this.openerService,
+                    pendingTracker: this.pendingToolConfirmationTracker,
+                    keybindingHints: this.getKeybindingHints()
                 }}
             />
         );
@@ -156,4 +169,18 @@ export class TodoToolRenderer implements ChatResponsePartRenderer<ToolCallChatRe
             return undefined;
         }
     }
+
+    protected getKeybindingHints(): ToolConfirmationKeybindingHints {
+        const allow = this.formatKeybinding(APPROVE_LATEST_TOOL_CONFIRMATION_COMMAND.id);
+        const deny = this.formatKeybinding(DENY_LATEST_TOOL_CONFIRMATION_COMMAND.id);
+        return { allow, deny };
+    }
+
+    protected formatKeybinding(commandId: string): string | undefined {
+        const bindings = this.keybindingRegistry.getKeybindingsForCommand(commandId);
+        if (!bindings.length) {
+            return undefined;
+        }
+        return this.keybindingRegistry.acceleratorFor(bindings[0], '+').join('+');
+    }
 }

package/src/browser/user-interaction-tool-renderer.tsx

@@ -20,11 +20,16 @@ import { ResponseNode } from '@theia/ai-chat-ui/lib/browser/chat-tree-view';
 import { ChatResponseContent, ToolCallChatResponseContent } from '@theia/ai-chat/lib/common';
 import { ReactNode } from '@theia/core/shared/react';
 import * as React from '@theia/core/shared/react';
-import { codicon, ContextMenuRenderer, OpenerService } from '@theia/core/lib/browser';
+import { codicon, ContextMenuRenderer, KeybindingRegistry, OpenerService } from '@theia/core/lib/browser';
 import { nls } from '@theia/core/lib/common/nls';
 import { useMarkdownRendering } from '@theia/ai-chat-ui/lib/browser/chat-response-renderer/markdown-part-renderer';
-import { withToolCallConfirmation } from '@theia/ai-chat-ui/lib/browser/chat-response-renderer/tool-confirmation';
+import { ToolConfirmationKeybindingHints, withToolCallConfirmation } from '@theia/ai-chat-ui/lib/browser/chat-response-renderer/tool-confirmation';
+import {
+    APPROVE_LATEST_TOOL_CONFIRMATION_COMMAND,
+    DENY_LATEST_TOOL_CONFIRMATION_COMMAND
+} from '@theia/ai-chat-ui/lib/browser/tool-confirmation-keybinding-contribution';
 import { ToolConfirmationManager } from '@theia/ai-chat/lib/browser/chat-tool-preference-bindings';
+import { PendingToolConfirmationTracker } from '@theia/ai-chat/lib/browser/pending-tool-confirmation-tracker';
 import { ToolInvocationRegistry } from '@theia/ai-core';
 import { UserInteractionTool } from './user-interaction-tool';
 import {
@@ -499,6 +504,12 @@ export class UserInteractionToolRenderer implements ChatResponsePartRenderer<Too
     @inject(OpenerService)
     protected openerService: OpenerService;
 
+    @inject(PendingToolConfirmationTracker)
+    protected pendingToolConfirmationTracker: PendingToolConfirmationTracker;
+
+    @inject(KeybindingRegistry)
+    protected keybindingRegistry: KeybindingRegistry;
+
     canHandle(response: ChatResponseContent): number {
         if (ToolCallChatResponseContent.is(response) && response.name === USER_INTERACTION_FUNCTION_ID) {
             return 20;
@@ -551,9 +562,25 @@ export class UserInteractionToolRenderer implements ChatResponsePartRenderer<Too
                     chatId,
                     requestCanceled: parentNode.response.isCanceled,
                     contextMenuRenderer: this.contextMenuRenderer,
-                    openerService: this.openerService
+                    openerService: this.openerService,
+                    pendingTracker: this.pendingToolConfirmationTracker,
+                    keybindingHints: this.getKeybindingHints()
                 }}
             />
         );
     }
+
+    protected getKeybindingHints(): ToolConfirmationKeybindingHints {
+        const allow = this.formatKeybinding(APPROVE_LATEST_TOOL_CONFIRMATION_COMMAND.id);
+        const deny = this.formatKeybinding(DENY_LATEST_TOOL_CONFIRMATION_COMMAND.id);
+        return { allow, deny };
+    }
+
+    protected formatKeybinding(commandId: string): string | undefined {
+        const bindings = this.keybindingRegistry.getKeybindingsForCommand(commandId);
+        if (!bindings.length) {
+            return undefined;
+        }
+        return this.keybindingRegistry.acceleratorFor(bindings[0], '+').join('+');
+    }
 }