@theholocron/holocron-plugin-sentry 5.0.0-alpha.223 → 5.0.0-alpha.225

package/dist/index.mjs

@@ -34,16 +34,23 @@ function resolveRelayToken(input = {}) {
 /** What the integration needs to read: the alert's event. It is also why reading its secret needs the same scope. */
 const INTEGRATION_SCOPES = ["event:read"];
 const DEFAULT_FREQUENCY = 5;
-/** The alert action that sends through an integration: it points at the integration's numeric app id. */
-const sentryAppAction = (appId) => ({
-	type: "sentry_app",
+/**
+* The alert action that sends through an integration, in the shape Sentry's own page writes when "Send a notification via
+* an integration" is picked: a `webhook` action named by the integration's slug. (A `sentry_app` action with the numeric
+* id is accepted too, but the page shows it as an unknown integration.)
+*/
+const integrationAction = (slug) => ({
+	type: "webhook",
 	config: {
-		targetType: "sentry_app",
-		targetIdentifier: String(appId)
+		targetType: null,
+		targetDisplay: null,
+		targetIdentifier: slug
 	},
 	data: {}
 });
-const targetsApp = (action, appId) => action.type === "sentry_app" && String(action.config["targetIdentifier"]) === String(appId);
+const sendsThrough = (action, slug) => action.type === "webhook" && action.config["targetIdentifier"] === slug;
+/** The `sentry_app` form an earlier version wrote for this integration, which the page cannot name. */
+const isLegacyAction = (action, appId) => action.type === "sentry_app" && String(action.config["targetIdentifier"]) === String(appId);
 /** A workflow as Sentry returned it, as the body to send back (the nested ids are not part of an update). */
 function toInput(wf) {
 	return {
@@ -76,7 +83,7 @@ function toInput(wf) {
 	};
 }
 /** Sentry's own "high priority issues" rule, which is the default for a new alert. */
-function newWorkflow(name, frequency, detectorIds, appId) {
+function newWorkflow(name, frequency, detectorIds, slug) {
 	return {
 		name,
 		enabled: true,
@@ -98,7 +105,7 @@ function newWorkflow(name, frequency, detectorIds, appId) {
 		actionFilters: [{
 			logicType: "all",
 			conditions: [],
-			actions: [sentryAppAction(appId)]
+			actions: [integrationAction(slug)]
 		}]
 	};
 }
@@ -148,12 +155,12 @@ async function detectorsFor(client, org, slugs) {
 	});
 }
 /** The alert rule: one workflow for every project, found by name, made if missing, reconciled if not. */
-async function ensureRule(client, org, input, appId, detectorIds) {
+async function ensureRule(client, org, input, install, detectorIds) {
 	const workflows = await client.workflows.list(org);
 	const frequency = input.rule.frequency ?? DEFAULT_FREQUENCY;
 	const existing = workflows.find((w) => w.name === input.rule.name);
 	if (!existing) {
-		await client.workflows.create(org, newWorkflow(input.rule.name, frequency, detectorIds, appId));
+		await client.workflows.create(org, newWorkflow(input.rule.name, frequency, detectorIds, install.slug));
 		return {
 			created: true,
 			updated: []
@@ -177,16 +184,19 @@ async function ensureRule(client, org, input, appId, detectorIds) {
 		next.detectorIds = [...existing.detectorIds, ...missing];
 		updated.push("projects");
 	}
-	if (!existing.actionFilters.some((f) => f.actions.some((a) => targetsApp(a, appId)))) {
+	const sends = existing.actionFilters.some((f) => f.actions.some((a) => sendsThrough(a, install.slug)));
+	const legacy = existing.actionFilters.some((f) => f.actions.some((a) => isLegacyAction(a, install.appId)));
+	if (legacy) for (const f of next.actionFilters) f.actions = f.actions.filter((a) => !isLegacyAction(a, install.appId));
+	if (!sends) {
 		const open = next.actionFilters.find((f) => f.conditions.length === 0);
-		if (open) open.actions.push(sentryAppAction(appId));
+		if (open) open.actions.push(integrationAction(install.slug));
 		else next.actionFilters.push({
 			logicType: "all",
 			conditions: [],
-			actions: [sentryAppAction(appId)]
+			actions: [integrationAction(install.slug)]
 		});
-		updated.push("action");
 	}
+	if (legacy || !sends) updated.push("action");
 	if (updated.length === 0) return {
 		created: false,
 		updated
@@ -208,7 +218,10 @@ async function ensureSentryRelay(client, org, input) {
 	const integration = await ensureIntegration(client, org, input);
 	const install = (await client.sentryApps.installations(org)).find((i) => i.app.slug === integration.app.slug);
 	if (!install) throw new Error(`the integration \`${integration.app.name}\` is not installed on ${org}`);
-	const rule = await ensureRule(client, org, input, install.app.sentryAppId, detectorIds);
+	const rule = await ensureRule(client, org, input, {
+		slug: install.app.slug,
+		appId: install.app.sentryAppId
+	}, detectorIds);
 	const clientSecret = await secretOf(client, integration.app);
 	return {
 		integration: {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@theholocron/holocron-plugin-sentry",
-  "version": "5.0.0-alpha.223",
+  "version": "5.0.0-alpha.225",
   "description": "Holocron plugin for Sentry. Implements the errors capability against Sentry's management API — project provisioning and DSN retrieval.",
   "keywords": [
     "errors",
@@ -48,12 +48,12 @@
     "tsx": "4.23.15",
     "typescript": "^5.9.3",
     "vitest": "^4.1.11",
-    "@theholocron/cli": "5.0.0-alpha.223"
+    "@theholocron/cli": "5.0.0-alpha.225"
   },
   "peerDependencies": {
     "@theholocron/misc-utils": "^1.16.0",
     "@theholocron/sentry-client": "^1.54.0",
-    "@theholocron/cli": "5.0.0-alpha.223"
+    "@theholocron/cli": "5.0.0-alpha.225"
   },
   "peerDependenciesMeta": {
     "@theholocron/sentry-client": {}