@theholocron/holocron-plugin-github 5.0.0-alpha.257 → 5.0.0-alpha.259

package/dist/index.mjs

@@ -4,6 +4,7 @@ import { createGitHubClient, createGitHubClient as createGitHubClient$1 } from "
 import { mkdir, readFile, readdir, rm, stat, writeFile } from "node:fs/promises";
 import { dirname, join } from "node:path";
 import { findRootSync } from "@theholocron/fs-utils";
+import { ProviderApiError as ProviderApiError$1 } from "@theholocron/http-client";
 import { errorMessage } from "@theholocron/misc-utils";
 // src/auth.ts
 const resolveReadToken = createFeatureResolver({
@@ -497,9 +498,71 @@ async function syncLabels(client, repo, canonical, stale) {
 	}
 	return `${created} created, ${updated} updated, ${deleted} deleted`;
 }
+// src/capabilities/rejected-properties.ts
+/** The values `repo setup` sends for `true_false` properties; anything else is rejected. */
+const BOOLEANS = /* @__PURE__ */ new Set(["true", "false"]);
+/**
+* What is wrong with `values` when compared with the organization's property definitions, one sentence per
+* problem, in the order the properties are given: a property the organization does not define, a value a
+* `single_select` or `multi_select` property does not allow, or a `true_false` property that is not `true` or
+* `false`. A `string` or `url` property has nothing to check here. Empty when every value fits its definition.
+*/
+function rejectedProperties(values, schema) {
+	const byName = new Map(schema.map((property) => [property.property_name, property]));
+	const problems = [];
+	for (const [name, value] of Object.entries(values)) {
+		const definition = byName.get(name);
+		if (!definition) {
+			problems.push(`${name} is not a custom property of the organization`);
+			continue;
+		}
+		const sent = Array.isArray(value) ? value : [value];
+		if (definition.value_type === "true_false") {
+			for (const item of sent.filter((item) => !BOOLEANS.has(item))) problems.push(`${name} is "${item}", but it takes only true or false`);
+			continue;
+		}
+		const allowed = definition.allowed_values ?? [];
+		if (definition.value_type !== "single_select" && definition.value_type !== "multi_select") continue;
+		for (const item of sent.filter((item) => !allowed.includes(item))) problems.push(`${name} has "${item}", which is not one of its allowed values (${allowed.join(", ")})`);
+	}
+	return problems;
+}
 // src/capabilities/properties.ts
+/** GitHub's own message from a 422 body (`{"message": ..., "errors": [...]}`), or the start of the body when it is not JSON. */
+function githubMessage(details) {
+	const raw = String(details ?? "").trim();
+	try {
+		const body = JSON.parse(raw);
+		const errors = Array.isArray(body.errors) ? body.errors.map((e) => JSON.stringify(e)).join(", ") : "";
+		const message = typeof body.message === "string" ? body.message : raw;
+		return errors ? `${message}: ${errors}` : message;
+	} catch {
+		return raw.slice(0, 300);
+	}
+}
+/** The organization's property definitions, or `undefined` when they cannot be read (permission, an older client). */
+async function orgSchema(client, repo) {
+	try {
+		return await client.properties.orgSchema(repo.split("/")[0]);
+	} catch {
+		return;
+	}
+}
+/**
+* Sets the repo's custom properties. When GitHub answers 422 the error says which value it refused: the values
+* are compared with the organization's property definitions (read-only), and GitHub's own message is added.
+* One refused value fails the whole request, so none of the properties is set.
+*/
 async function syncProperties(client, repo, values) {
-	await client.properties.setProperties(repo, values);
+	try {
+		await client.properties.setProperties(repo, values);
+	} catch (err) {
+		if (!(err instanceof ProviderApiError$1) || err.status !== 422) throw err;
+		const schema = await orgSchema(client, repo);
+		const problems = schema ? rejectedProperties(values, schema) : [];
+		const said = githubMessage(err.details);
+		throw new Error(`GitHub refused the custom properties (422), so none was set: ${problems.length > 0 ? problems.join("; ") : "no value differs from the organization's definitions, or they could not be read"}. GitHub said: ${said}`, { cause: err });
+	}
 	return `${Object.keys(values).length} properties set`;
 }
 // src/capabilities/teams.ts

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@theholocron/holocron-plugin-github",
-  "version": "5.0.0-alpha.257",
+  "version": "5.0.0-alpha.259",
   "description": "Holocron plugin for GitHub. Implements source, ci, secrets, environments, and issues capabilities against the GitHub REST API.",
   "keywords": [
     "ci",
@@ -44,21 +44,21 @@
     "tsx": "4.23.15",
     "typescript": "^5.9.3",
     "vitest": "^5.0.5",
-    "@theholocron/cli": "5.0.0-alpha.257",
+    "@theholocron/cli": "5.0.0-alpha.259",
     "@theholocron/eslint-config": "^8.9.0-alpha.3",
     "@theholocron/fs-utils": "^1.16.1-alpha.1",
-    "@theholocron/github-client": "^1.57.1-alpha.1",
+    "@theholocron/github-client": "^1.57.1-alpha.2",
     "@theholocron/misc-utils": "^1.16.1-alpha.1",
-    "@theholocron/http-client": "^1.57.1-alpha.1",
-    "@theholocron/vitest-config": "^8.9.0-alpha.3",
     "@theholocron/tsconfig": "^8.9.0-alpha.3",
+    "@theholocron/vitest-config": "^8.9.0-alpha.3",
+    "@theholocron/http-client": "^1.57.1-alpha.2",
     "@theholocron/tsdown-config": "^8.9.0-alpha.3"
   },
   "peerDependencies": {
     "@theholocron/fs-utils": "^1.16.0",
     "@theholocron/github-client": "^1.51.0",
     "@theholocron/misc-utils": "^1.16.0",
-    "@theholocron/cli": "5.0.0-alpha.257"
+    "@theholocron/cli": "5.0.0-alpha.259"
   },
   "engines": {
     "node": ">=22"