@theholocron/holocron-plugin-github 2.0.0-alpha.19 → 2.0.0-alpha.21

package/dist/index.d.mts

@@ -1,62 +1,14 @@
-import { Auth, Ci, CiRun, CiRunFilter, Environment, Environments, Issue, IssueSearchFilter, Issues, LifecycleResult, LifecycleSlot, RepoRef, RepoSettings, Ruleset, SecretScope, Secrets, Source, TrackerDoctorReport, TrackerUser } from "@theholocron/cli";
+import { Auth, AuthError, Ci, CiRun, CiRunFilter, Environment, Environments, Issue, IssueSearchFilter, Issues, LifecycleResult, LifecycleSlot, RepoRef, RepoSettings, ResolveTokenInput, RestClient, RestClient as RestClient$1, Ruleset, SecretScope, Secrets, Source, TrackerDoctorReport, TrackerUser } from "@theholocron/cli";
 
 //#region src/auth.d.ts
-/**
- * Token resolution for the GitHub plugin. See README §Auth.
- *
- * Resolution order (matches the standard 4-step precedence set by
- * `.notes/tech-auth-bootstrap.spec.md`):
- *   1. explicit `token` argument (from `--token` flag)
- *   2. HOLOCRON_GH_TOKEN env var (preferred over GITHUB_TOKEN — clearer intent)
- *   3. GITHUB_TOKEN env var (auto-injected in GH Actions)
- *   4. keyring (com.theholocron.cli / "github")
- *   5. AuthError naming all four options + the bootstrap hint
- *
- * No `gh auth token` fallback by design — it usually has narrower
- * scopes than admin commands need.
- */
-declare class AuthError extends Error {
-  name: string;
-}
-interface ResolveTokenInput {
-  /** From `--token` CLI flag. */
-  cliToken?: string;
-  /** Env vars; passed in for testability. Defaults to `process.env`. */
-  env?: NodeJS.ProcessEnv;
-  /** Keyring lookup fn; passed in for testability. Defaults to `getToken(provider)`. */
-  keyring?: (provider: string) => string | null;
-}
-declare function resolveToken(input?: ResolveTokenInput): string;
+declare const resolveToken: (input?: import("@theholocron/http-client").ResolveTokenInput) => string;
 //#endregion
 //#region src/rest.d.ts
-/**
- * Thin REST wrapper around api.github.com.
- *
- * Adapted from rando-id/rando.id `packages/cli/src/adapters/gh-rest.ts`
- * `request<T>` method into a standalone class so each capability can
- * hold a reference and share the same auth/error handling.
- *
- * Errors throw `ProviderApiError` from `@theholocron/cli`, which the
- * orchestrator catches to soft-skip rather than abort the whole pipeline.
- */
-interface RestClientOptions {
+declare function createGitHubRestClient(opts: {
   token: string;
-  fetch?: typeof fetch;
   baseUrl?: string;
-}
-interface RequestOptions {
-  method?: "GET" | "POST" | "PATCH" | "PUT" | "DELETE";
-  body?: unknown;
-  /** Skip JSON parse when true (204 No Content endpoints). */
-  expectNoContent?: boolean;
-}
-declare class GitHubRestClient {
-  private readonly token;
-  private readonly fetchImpl;
-  readonly baseUrl: string;
-  constructor(opts: RestClientOptions);
-  request<T>(path: string, opts?: RequestOptions): Promise<T>;
-}
+  fetch?: typeof fetch;
+}): RestClient$1;
 //#endregion
 //#region src/sodium.d.ts
 /**
@@ -80,7 +32,7 @@ declare class GitHubSource implements Source {
   private readonly repoPath;
   private readonly repoRoot;
   private readonly workflowDir;
-  constructor(rest: GitHubRestClient, opts: SourceOptions);
+  constructor(rest: RestClient, opts: SourceOptions);
   whoami(): Promise<{
     login: string;
   }>;
@@ -112,7 +64,7 @@ declare class GitHubSecrets implements Secrets {
   readonly key: "secrets";
   readonly providerName = "github";
   private readonly repoBase;
-  constructor(rest: GitHubRestClient, opts: SecretsOptions);
+  constructor(rest: RestClient, opts: SecretsOptions);
   listSecrets(scope: SecretScope): Promise<string[]>;
   setSecret(scope: SecretScope, name: string, value: string): Promise<void>;
   deleteSecret(scope: SecretScope, name: string): Promise<void>;
@@ -129,7 +81,7 @@ declare class GitHubEnvironments implements Environments {
   readonly key: "environments";
   readonly providerName = "github";
   private readonly base;
-  constructor(rest: GitHubRestClient, opts: EnvironmentsOptions);
+  constructor(rest: RestClient, opts: EnvironmentsOptions);
   listEnvironments(): Promise<Environment[]>;
   upsertEnvironment(env: Environment): Promise<void>;
   deleteEnvironment(name: string): Promise<void>;
@@ -145,7 +97,7 @@ declare class GitHubCi implements Ci {
   readonly key: "ci";
   readonly providerName = "github";
   private readonly base;
-  constructor(rest: GitHubRestClient, opts: CiOptions);
+  constructor(rest: RestClient, opts: CiOptions);
   listRuns(filter?: CiRunFilter): Promise<CiRun[]>;
   getRun(id: string | number): Promise<CiRun>;
   /**
@@ -182,7 +134,7 @@ declare class GitHubIssues implements Issues {
   private readonly repoName;
   private readonly base;
   private readonly labels;
-  constructor(rest: GitHubRestClient, opts: IssuesOptions);
+  constructor(rest: RestClient, opts: IssuesOptions);
   getMyself(): Promise<TrackerUser>;
   search(filter: IssueSearchFilter): Promise<Issue[]>;
   get(key: string): Promise<Issue>;
@@ -247,7 +199,7 @@ interface GitHubPluginOptions extends ResolveTokenInput {
 }
 interface PluginContext {
   options: GitHubPluginOptions;
-  rest: GitHubRestClient;
+  rest: RestClient;
   repo: string;
   repoRoot: string;
 }
@@ -275,4 +227,4 @@ declare function createPlugin(options: GitHubPluginOptions): {
  */
 declare const AUTH_HINT: string;
 //#endregion
-export { AUTH_HINT, type Auth, AuthError, GitHubCi, GitHubEnvironments, GitHubIssues, GitHubPluginOptions, GitHubRestClient, GitHubSecrets, GitHubSource, PluginContext, ResolveTokenInput, type VerifyTokenFailure, type VerifyTokenResult, type VerifyTokenSuccess, ci, createContext, createPlugin, encryptSecret, environments, issues, resolveToken, secrets, source, verifyToken };
+export { AUTH_HINT, type Auth, AuthError, GitHubCi, GitHubEnvironments, GitHubIssues, GitHubPluginOptions, GitHubSecrets, GitHubSource, PluginContext, type ResolveTokenInput, type VerifyTokenFailure, type VerifyTokenResult, type VerifyTokenSuccess, ci, createContext, createGitHubRestClient, createPlugin, encryptSecret, environments, issues, resolveToken, secrets, source, verifyToken };

package/dist/index.mjs

@@ -1,32 +1,14 @@
 import { createRequire } from "node:module";
-import { ProviderApiError, getToken } from "@theholocron/cli";
+import { AuthError, createResolveToken, createRestClient } from "@theholocron/cli";
 import { mkdir, readFile, readdir, rm, stat, writeFile } from "node:fs/promises";
 import { dirname, join } from "node:path";
 //#region src/auth.ts
-/**
-* Token resolution for the GitHub plugin. See README §Auth.
-*
-* Resolution order (matches the standard 4-step precedence set by
-* `.notes/tech-auth-bootstrap.spec.md`):
-*   1. explicit `token` argument (from `--token` flag)
-*   2. HOLOCRON_GH_TOKEN env var (preferred over GITHUB_TOKEN — clearer intent)
-*   3. GITHUB_TOKEN env var (auto-injected in GH Actions)
-*   4. keyring (com.theholocron.cli / "github")
-*   5. AuthError naming all four options + the bootstrap hint
-*
-* No `gh auth token` fallback by design — it usually has narrower
-* scopes than admin commands need.
-*/
-var AuthError = class extends Error {
-	name = "AuthError";
-};
-function resolveToken(input = {}) {
-	const env = input.env ?? process.env;
-	const keyring = input.keyring ?? getToken;
-	const token = input.cliToken || env.HOLOCRON_GH_TOKEN || env.GITHUB_TOKEN || keyring("github");
-	if (!token) throw new AuthError("no GitHub token found. Pass --token <PAT>, set HOLOCRON_GH_TOKEN / GITHUB_TOKEN, or run: holocron auth set github <PAT>");
-	return token;
-}
+const resolveToken = createResolveToken({
+	envName: "HOLOCRON_GH_TOKEN",
+	vendorEnvName: "GITHUB_TOKEN",
+	keyringService: "github",
+	errorMessage: "no GitHub token found. Pass --token <PAT>, set HOLOCRON_GH_TOKEN / GITHUB_TOKEN, or run: holocron auth set github <PAT>"
+});
 //#endregion
 //#region src/repo.ts
 var RepoError = class extends Error {
@@ -619,53 +601,18 @@ async function ensureDir(path) {
 }
 //#endregion
 //#region src/rest.ts
-/**
-* Thin REST wrapper around api.github.com.
-*
-* Adapted from rando-id/rando.id `packages/cli/src/adapters/gh-rest.ts`
-* `request<T>` method into a standalone class so each capability can
-* hold a reference and share the same auth/error handling.
-*
-* Errors throw `ProviderApiError` from `@theholocron/cli`, which the
-* orchestrator catches to soft-skip rather than abort the whole pipeline.
-*/
-var GitHubRestClient = class {
-	token;
-	fetchImpl;
-	baseUrl;
-	constructor(opts) {
-		this.token = opts.token;
-		this.fetchImpl = opts.fetch ?? globalThis.fetch;
-		let url = opts.baseUrl ?? "https://api.github.com";
-		while (url.endsWith("/")) url = url.slice(0, -1);
-		this.baseUrl = url;
-	}
-	async request(path, opts = {}) {
-		const url = `${this.baseUrl}${path}`;
-		const headers = {
+function createGitHubRestClient(opts) {
+	return createRestClient({
+		baseUrl: opts.baseUrl ?? "https://api.github.com",
+		token: opts.token,
+		extraHeaders: {
 			accept: "application/vnd.github+json",
-			authorization: `Bearer ${this.token}`,
 			"x-github-api-version": "2022-11-28"
-		};
-		const init = {
-			method: opts.method ?? "GET",
-			headers
-		};
-		if (opts.body !== void 0) {
-			headers["content-type"] = "application/json";
-			init.body = JSON.stringify(opts.body);
-		}
-		const res = await this.fetchImpl(url, init);
-		if (!res.ok) {
-			const body = await res.text().catch(() => "");
-			throw new ProviderApiError(`GitHub ${init.method} ${path} → ${res.status}`, res.status, body);
-		}
-		if (opts.expectNoContent || res.status === 204) return;
-		const text = await res.text();
-		if (!text) return void 0;
-		return JSON.parse(text);
-	}
-};
+		},
+		vendor: "GitHub",
+		fetch: opts.fetch
+	});
+}
 //#endregion
 //#region src/verify-token.ts
 /**
@@ -679,10 +626,11 @@ var GitHubRestClient = class {
 * what we don't have yet at bootstrap time.
 */
 async function verifyToken(token, opts = {}) {
-	const restOpts = { token };
-	if (opts.baseUrl !== void 0) restOpts.baseUrl = opts.baseUrl;
-	if (opts.fetch !== void 0) restOpts.fetch = opts.fetch;
-	const rest = new GitHubRestClient(restOpts);
+	const rest = createGitHubRestClient({
+		token,
+		baseUrl: opts.baseUrl,
+		fetch: opts.fetch
+	});
 	try {
 		const me = await rest.request("/user");
 		return {
@@ -701,7 +649,7 @@ async function verifyToken(token, opts = {}) {
 function createContext(options) {
 	return {
 		options,
-		rest: new GitHubRestClient({
+		rest: createGitHubRestClient({
 			token: resolveToken(options),
 			baseUrl: options.baseUrl,
 			fetch: options.fetch
@@ -751,4 +699,4 @@ function createPlugin(options) {
 */
 const AUTH_HINT = "generate a Personal Access Token at https://github.com/settings/tokens (scopes: repo, admin:repo_hook — plus admin:org for org-level ops), then run: holocron auth set github <PAT>";
 //#endregion
-export { AUTH_HINT, AuthError, GitHubCi, GitHubEnvironments, GitHubIssues, GitHubRestClient, GitHubSecrets, GitHubSource, ci, createContext, createPlugin, encryptSecret, environments, issues, resolveToken, secrets, source, verifyToken };
+export { AUTH_HINT, AuthError, GitHubCi, GitHubEnvironments, GitHubIssues, GitHubSecrets, GitHubSource, ci, createContext, createGitHubRestClient, createPlugin, encryptSecret, environments, issues, resolveToken, secrets, source, verifyToken };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@theholocron/holocron-plugin-github",
-  "version": "2.0.0-alpha.19",
+  "version": "2.0.0-alpha.21",
   "description": "Holocron plugin for GitHub. Implements source, ci, secrets, environments, and issues capabilities against the GitHub REST API.",
   "homepage": "https://github.com/theholocron/holocron/tree/main/packages/holocron-plugin-github#readme",
   "bugs": "https://github.com/theholocron/holocron/issues",
@@ -21,17 +21,18 @@
     }
   },
   "peerDependencies": {
-    "@theholocron/cli": "2.0.0-alpha.19"
+    "@theholocron/cli": "2.0.0-alpha.21"
   },
   "dependencies": {
     "libsodium-wrappers": "^0.7.15"
   },
   "devDependencies": {
-    "@theholocron/eslint-config": "^5.1.1",
-    "@theholocron/tsconfig": "^4.1.0",
-    "@tsconfig/node-lts": "^24.0.0",
+    "@types/node": "^26",
+    "@theholocron/eslint-config": "^5.2.0",
+    "@theholocron/tsconfig": "^6.0.0",
+    "@theholocron/tsdown-config": "^5.1.2",
+    "@theholocron/vitest-config": "^5.2.0",
     "@types/libsodium-wrappers": "^0.7.14",
-    "@vitest/coverage-v8": "^3.2.6",
     "@vitest/eslint-plugin": "^1.6.23",
     "eslint": "^10.7.0",
     "eslint-plugin-n": "^18.2.2",
@@ -39,8 +40,8 @@
     "tsdown": "^0.22.3",
     "tsx": "^4.22.4",
     "typescript": "^5.9.3",
-    "vitest": "^3.2.6",
-    "@theholocron/cli": "2.0.0-alpha.19"
+    "vitest": "^4.1.10",
+    "@theholocron/cli": "2.0.0-alpha.21"
   },
   "publishConfig": {
     "access": "public"