@thehammer/danx-dashboard-mcp 0.1.216 → 0.1.219

package/dist/lifecycle.js

@@ -36,6 +36,8 @@
  *  - Descriptions trimmed of DX-card historical narration where cheap to do
  *    without re-deriving the byte-for-byte target DX-3394 measured.
  */
+import { readFile, stat } from "node:fs/promises";
+import { basename, isAbsolute } from "node:path";
 import { z } from "zod";
 /**
  * The five canonical agent-visible `danxbot_complete` statuses. DX-3394
@@ -114,15 +116,37 @@ async function postWorkerRoute(url, body, toolName, bearer) {
         return { raw: text };
     }
 }
-function parseOptionalAbsolutePathArray(field, value) {
-    if (value === undefined)
+/** Must match `MAX_DECODED_BYTES` in danxbot's `src/issues/attachment-limits.ts` (duplicated, not imported: this package is published on its own). */
+const MAX_ATTACHMENT_BYTES = 25 * 1024 * 1024;
+/**
+ * DX-4251 — read each attached path HERE, in the MCP server process beside the
+ * agent, and return its bytes. The dashboard that serves the reply route can
+ * run on a different host than the agent (dedicated topology), so a path could
+ * never be resolved over there.
+ */
+async function readAttachments(paths) {
+    if (paths === undefined)
         return [];
-    return value.map((entry, idx) => {
-        if (!entry.startsWith("/")) {
-            throw new Error(`field "${field}"[${idx}] must be an absolute path (got "${entry}")`);
+    return Promise.all(paths.map(async (entry, idx) => {
+        if (!isAbsolute(entry)) {
+            throw new Error(`field "files"[${idx}] must be an absolute path (got "${entry}")`);
         }
-        return entry;
-    });
+        const info = await stat(entry);
+        // DX-4251: a directory stats as size 0 (Windows) or 4096 (Linux); name it, never read it as a file.
+        if (!info.isFile())
+            throw new Error(`field "files"[${idx}] "${entry}" is not a file`);
+        if (info.size === 0)
+            throw new Error(`field "files"[${idx}] "${entry}" is an empty file`);
+        if (info.size > MAX_ATTACHMENT_BYTES) {
+            throw new Error(`field "files"[${idx}] "${entry}" is ${info.size} bytes, over the ${MAX_ATTACHMENT_BYTES}-byte attachment limit`);
+        }
+        return { filename: basename(entry), base64: (await readFile(entry)).toString("base64") };
+    }));
+}
+/** A refused callback's body is the only place the server says why — relay it, never just the status. */
+async function responseFailure(label, response) {
+    const text = await response.text();
+    return new Error(`${label} returned HTTP ${response.status}${text ? `: ${text}` : ""}`);
 }
 /**
  * Registers every lifecycle tool on `server` via the caller's `strictTool`
@@ -190,25 +214,26 @@ export function registerLifecycleTools(strictTool) {
     });
     // ---------------- danxbot_slack_reply ----------------
     const slackReply = strictTool("danxbot_slack_reply", "Post the FINAL user-facing reply to the originating Slack thread. Call exactly once per dispatch, " +
-        "immediately before danxbot_complete. Optionally attach result files via files[] (absolute local paths " +
-        "on the shared filesystem) — text + attachments land as ONE atomic thread post. For intermediate " +
+        "immediately before danxbot_complete. Optionally attach result files via files[] (absolute paths of files on YOUR own " +
+        "disk — their bytes are uploaded, so this works whichever host the dashboard runs on) — text + attachments " +
+        "land as ONE atomic thread post. For intermediate " +
         "progress use danxbot_slack_post_update instead.", {
         text: z.string().describe("The final reply text to post to the Slack thread."),
         files: z
             .array(z.string())
             .optional()
-            .describe("Optional absolute local paths to files to attach to the reply."),
+            .describe("Optional absolute paths of files on your own disk to attach; their bytes are uploaded."),
     }, async (args) => {
         const url = readLifecycleUrlsFromEnv().slackReply;
         if (!url)
             throw new Error("danxbot_slack_reply called outside a Slack dispatch");
-        const files = parseOptionalAbsolutePathArray("files", args.files);
+        const files = await readAttachments(args.files);
         const body = { text: args.text };
         if (files.length > 0)
             body.files = files;
         const response = await postJson(url, body, dashboardBearer());
         if (!response.ok)
-            throw new Error(`Slack reply API returned HTTP ${response.status}`);
+            throw await responseFailure("Slack reply API", response);
         return {
             content: [
                 {
@@ -228,7 +253,7 @@ export function registerLifecycleTools(strictTool) {
             throw new Error("danxbot_slack_post_update called outside a Slack dispatch");
         const response = await postJson(url, { text: args.text }, dashboardBearer());
         if (!response.ok)
-            throw new Error(`Slack update API returned HTTP ${response.status}`);
+            throw await responseFailure("Slack update API", response);
         return { content: [{ type: "text", text: "Update posted to Slack thread" }] };
     });
     // ---------------- link_thread_to_issue ----------------

package/dist/terms-halt.js

@@ -1,7 +1,9 @@
 const TERMS_ACCEPTANCE_PATH = "/api/account/terms-acceptance";
 // Mirrors `termsAcceptUrl("/")` in src/lib/terms-accept-path.ts (a published package cannot import it);
 // terms-gate.integration.test.ts pins the server's link to the same literal. Only meaningful for an
-// operator session: a dispatch's DANXBOT_DASHBOARD_URL is internal, and a dispatch's own agent credential is never terms-gated.
+// operator session: a dispatch's DANXBOT_DASHBOARD_URL is internal, and a dispatch's own key is its
+// owner's API key (DX-4191), so a dispatched agent can meet this refusal too and hands the link to the
+// owner's operator.
 const ACCEPT_SCREEN_PATH = "/terms/accept?return=%2F";
 /** Keep in step with `termsRefusalInstruction` in src/dashboard/route-policy.ts. */
 export function haltText(acceptUrl, owner) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@thehammer/danx-dashboard-mcp",
-  "version": "0.1.216",
+  "version": "0.1.219",
   "description": "Stdio MCP server fronting danxbot's dashboard API for agents (operator sessions and dispatched workers alike): the generic danxbot_api/danxbot_api_list/danxbot_api_spec tools reach any route the caller's credential may call, plus dedicated agent-specific tools (plan_connect, danxbot_complete, and other per-dispatch lifecycle callbacks) (DX-3465, PLN-11 R-25).",
   "license": "MIT",
   "type": "module",