@thehammer/danx-dashboard-mcp 0.1.189 → 0.1.190

package/dist/bridge.js

@@ -34,7 +34,7 @@
  *   5. Streams through `runListener` (`listen.ts`), which reconnects within the
  *      ticket, and re-mints when that ticket's lease runs out or a fresh ticket
  *      is refused once.
- *   6. Writes JSON Lines to stdout: ONE `{type:"ready", boards, cardCount, degraded}`
+ *   6. Writes JSON Lines to stdout: ONE `{type:"ready", boards, cardCount, degraded, inventoryError}`
  *      once a ticket has been minted and streaming is about to start —
  *      DX-2970's `fetchPlanInventory`, a single BEST-EFFORT (never a gate)
  *      read of the connected plan's real board/card counts, purely so a
@@ -140,6 +140,13 @@ function formatDigest(entries) {
     return [header, ...entries.map((e) => e.text)].join("\n");
 }
 export const BRIDGE_SUBCOMMAND = "bridge";
+/**
+ * DX-3912 — the longest heartbeat `reason` the bridge sends: one under the dashboard's own
+ * limit (`HEARTBEAT_REASON_MAX_CHARS` = 200, `src/issues/db/plan-session-heartbeat.ts`),
+ * because `oneLine` appends a "…" to a truncated string and a longer reason refuses the whole
+ * heartbeat. `bridge.test.ts` asserts the cap.
+ */
+const HEARTBEAT_REASON_MAX_CODE_POINTS = 199;
 export const STREAM_TICKET_PATH = "/api/plan-sessions/me/stream-ticket";
 // DX-2970 — the bare (no `fields=`) cheap-scalars read, used ONLY to report the
 // connected plan's real `boards`/`cardCount` on the `ready` record (see
@@ -449,15 +456,29 @@ export async function mintTicket(options, deps) {
         leaseMs: ticket.leaseMs,
     };
 }
-/** What is wrong with a 2xx bare `/api/plans/mine` body, or `null` when it carries a usable inventory. */
+/**
+ * What is wrong with a 2xx bare `/api/plans/mine` body, or `null` when it carries a usable inventory.
+ *
+ * DX-3912 — the field names here are the plan resource's WIRE names (`boards`, `card_count`,
+ * snake_case since DX-3428), the same ones `src/resources/plan/plan-resource.ts` emits; the
+ * contract test `src/issues/__tests__/plan-inventory-bridge-contract.test.ts` runs this parser
+ * on the server's own response, so a rename there fails that test instead of silently
+ * degrading every bridge. A missing field lists the keys the body DID carry, so a rename is
+ * named in the first message anyone reads.
+ */
 function badInventoryReason(body) {
-    if (typeof body !== "object" || body === null)
+    if (!isRecord(body))
         return "the body is not a JSON object";
-    const b = body;
-    if (!Array.isArray(b.boards) || b.boards.some((x) => typeof x !== "string"))
-        return "boards is not a string array";
-    if (typeof b.cardCount !== "number" || !Number.isSafeInteger(b.cardCount) || b.cardCount < 0) {
-        return "cardCount is not a non-negative integer";
+    if (!("boards" in body))
+        return `boards is missing (response keys: ${Object.keys(body).join(", ")})`;
+    if (!Array.isArray(body.boards) || body.boards.some((x) => typeof x !== "string")) {
+        return "boards is not an array of strings";
+    }
+    if (!("card_count" in body))
+        return `card_count is missing (response keys: ${Object.keys(body).join(", ")})`;
+    const count = body.card_count;
+    if (typeof count !== "number" || !Number.isSafeInteger(count) || count < 0) {
+        return `card_count is not a non-negative integer (got ${typeof count === "number" ? count : typeof count})`;
     }
     return null;
 }
@@ -485,7 +506,7 @@ export async function fetchPlanInventory(options, deps) {
         return { kind: "unavailable", detail: `plan inventory read HTTP ${status}: ${bad}` };
     }
     const b = body;
-    return { kind: "ok", boards: b.boards, cardCount: b.cardCount };
+    return { kind: "ok", boards: b.boards, cardCount: b.card_count };
 }
 /**
  * DX-2920 — a stream admission refusal (`listen.ts`'s STRUCTURED `refused`
@@ -604,7 +625,8 @@ export async function runBridge(options, deps) {
     let connectionState = "reconnecting";
     let stoppedReason = null;
     let heartbeatSuppressed = false;
-    let lastInventoryOk = true;
+    // DX-3912 — `null` is "the inventory read succeeded"; a string is why it did not.
+    let lastInventoryError = null;
     // DX-3099 — consecutive heartbeat POSTs that failed to LAND while this
     // process still believed `connectionState === "streaming"`. Reset to 0 the
     // moment a heartbeat lands, or the moment state leaves "streaming" for any
@@ -619,7 +641,9 @@ export async function runBridge(options, deps) {
     // process, so an in-process re-mint never touches its state.
     const sessionStats = new OperatorSessionStats(options.transcriptPath ?? null, deps.makeStatsWatcher);
     const connectionNow = () => connectionState === "streaming"
-        ? { state: "streaming", inventory: lastInventoryOk ? "ok" : "unavailable" }
+        ? lastInventoryError === null
+            ? { state: "streaming", inventory: "ok" }
+            : { state: "streaming", inventory: "unavailable", reason: oneLine(lastInventoryError, HEARTBEAT_REASON_MAX_CODE_POINTS) }
         : connectionState === "stopped"
             ? { state: "stopped", reason: stoppedReason ?? undefined }
             : { state: "reconnecting" };
@@ -822,23 +846,24 @@ export async function runBridge(options, deps) {
             readyEmitted = true;
             const inventory = await fetchPlanInventory(options, deps);
             // DX-3028 (AC1, code-review + architecture-review finding) — this is
-            // the ONE place `lastInventoryOk` is ever written; the 15s heartbeat
+            // the ONE place `lastInventoryError` is ever written; the 15s heartbeat
             // reads it on every "streaming" tick (see `heartbeatTick` above). Must
             // agree with the SAME `ready` record's own `degraded` decision below —
             // a heartbeat reporting `inventory:"ok"` while the `ready` record just
             // told the operator `degraded:true` would be exactly the untruthful
             // state AC1 exists to prevent.
-            lastInventoryOk = inventory.kind === "ok";
+            lastInventoryError = inventory.kind === "ok" ? null : inventory.detail;
             if (inventory.kind === "ok") {
                 deps.write({
                     type: "ready",
                     boards: inventory.boards,
                     cardCount: inventory.cardCount,
                     degraded: inventory.boards.length === 0 || inventory.cardCount === 0,
+                    inventoryError: null,
                 });
             }
             else {
-                deps.write({ type: "ready", boards: null, cardCount: null, degraded: true });
+                deps.write({ type: "ready", boards: null, cardCount: null, degraded: true, inventoryError: inventory.detail });
             }
         }
         backoff = MINT_INITIAL_BACKOFF_MS;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@thehammer/danx-dashboard-mcp",
-  "version": "0.1.189",
+  "version": "0.1.190",
   "description": "Stdio MCP server fronting danxbot's dashboard API for agents (operator sessions and dispatched workers alike): the generic danxbot_api/danxbot_api_list/danxbot_api_spec tools reach any route the caller's credential may call, plus dedicated agent-specific tools (plan_connect, danxbot_complete, and other per-dispatch lifecycle callbacks) (DX-3465, PLN-11 R-25).",
   "license": "MIT",
   "type": "module",