@thehammer/danx-dashboard-mcp 0.1.186 → 0.1.187

package/dist/activity.js

@@ -22,7 +22,16 @@
  * and the transcript producer (`createActivityObserver`) keys its row on that file's
  * basename, `agent-<agent_id>`. Reporting the bare `agent_id` would upsert a SECOND row for
  * the same sub-agent, so the hook-side key is the same basename: the two producers converge
- * on one row. (`transcript_path` cannot supply it: on these events it is the MAIN session's
+ * on one row. The hooks docs disagree on whether `agent_id` already carries the `agent-`
+ * prefix, so {@link subagentActivityId} normalizes both forms to the one key.
+ *
+ * KNOWN LIMITS (DX-3284, pinned in `plan-session-activity.test.ts`):
+ *   - a sub-agent RESUMED after its SubagentStop reports a second start, but the server's
+ *     first finish wins, so the row stays closed;
+ *   - a SubagentStop with no `agent_id` (Claude Code's internal agents) is refused below, and
+ *     the plugin leaves a failure trace. One WITH an id but no recorded start is
+ *     indistinguishable from a stop that beat its (async) start, so it is recorded as an
+ *     already-finished row — it never counts as running. (`transcript_path` cannot supply it: on these events it is the MAIN session's
  * transcript — only `SubagentStop`'s `agent_transcript_path` names the sub-agent's own, and
  * it is used below to REFUSE a mismatch, never to guess one.)
  *
@@ -62,9 +71,19 @@ export const ACTIVITY_REQUEST_TIMEOUT_MS = 5_000;
 /** The hook events this subcommand accepts, exactly as Claude Code names them in `hook_event_name`. */
 export const ACTIVITY_HOOK_EVENTS = ["SubagentStart", "SubagentStop", "PostToolUse"];
 const USAGE = `usage: CLAUDE_CODE_SESSION_ID=<session-id> danx-dashboard-mcp ${ACTIVITY_SUBCOMMAND} <${ACTIVITY_HOOK_EVENTS.join("|")}> <event-at ISO-8601 UTC>  (the hook's JSON envelope on stdin)`;
-/** A sub-agent's transcript file basename — the key `createActivityObserver` reports it under. */
+const SUBAGENT_PREFIX = "agent-";
+/**
+ * A sub-agent's transcript file basename — the key `createActivityObserver` reports it under.
+ *
+ * DX-3284: the hooks documentation shows `agent_id` BOTH ways — SubagentStart's example carries
+ * the `agent-` prefix (`agent-abc123`), SubagentStop's does not (`def456`, against the file
+ * `agent-def456.jsonl`). The key is `agent-` + the id with ONE leading `agent-` stripped, so both
+ * forms converge on the transcript producer's row; keying on the raw id would leave a phantom
+ * `agent-agent-<id>` row that no stop ever closes.
+ */
 export function subagentActivityId(agentId) {
-    return `agent-${agentId}`;
+    const bare = agentId.startsWith(SUBAGENT_PREFIX) ? agentId.slice(SUBAGENT_PREFIX.length) : agentId;
+    return `${SUBAGENT_PREFIX}${bare}`;
 }
 function nonEmptyString(value) {
     return typeof value === "string" && value !== "";
@@ -107,7 +126,10 @@ export function activityChangeFromHook(event, envelope, eventAtMs) {
             },
         };
     }
-    if (!nonEmptyString(e.agent_id))
+    // A SubagentStop from one of Claude Code's own internal agents carries no `agent_id`: it names
+    // no activity, so it is refused here (the plugin leaves a failure trace) and nothing is
+    // written — a stop must never invent a row.
+    if (!nonEmptyString(e.agent_id) || e.agent_id === SUBAGENT_PREFIX)
         return { ok: false, reason: "no_agent_id" };
     const activityId = subagentActivityId(e.agent_id);
     if (event === "SubagentStop" && e.agent_transcript_path !== undefined) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@thehammer/danx-dashboard-mcp",
-  "version": "0.1.186",
+  "version": "0.1.187",
   "description": "Stdio MCP server fronting danxbot's dashboard API for agents (operator sessions and dispatched workers alike): the generic danxbot_api/danxbot_api_list/danxbot_api_spec tools reach any route the caller's credential may call, plus dedicated agent-specific tools (plan_connect, danxbot_complete, and other per-dispatch lifecycle callbacks) (DX-3465, PLN-11 R-25).",
   "license": "MIT",
   "type": "module",
@@ -31,7 +31,7 @@
   },
   "dependencies": {
     "@modelcontextprotocol/sdk": "1.29.0",
-    "@thehammer/danx-session-telemetry": "0.1.18",
+    "@thehammer/danx-session-telemetry": "0.1.19",
     "zod": "^3.25.76"
   },
   "devDependencies": {