@thehammer/danx-dashboard-mcp 0.1.177 → 0.1.180

package/dist/lifecycle.js

@@ -77,6 +77,7 @@ export function readLifecycleUrlsFromEnv() {
         slackRecoveryMessage: opt("DANXBOT_SLACK_RECOVERY_MESSAGE_URL"),
         slackRecoveryCreateOrLink: opt("DANXBOT_SLACK_RECOVERY_CREATE_OR_LINK_URL"),
         qualityGate: opt("DANXBOT_QUALITY_GATE_URL"),
+        requestCodeReview: opt("DANXBOT_REQUEST_CODE_REVIEW_URL"),
         evaluatorSummary: opt("DANXBOT_EVALUATOR_SUMMARY_URL"),
         saveTemplateApp: opt("DANXBOT_TEMPLATE_APP_SAVE_URL"),
         loadTemplateApp: opt("DANXBOT_TEMPLATE_APP_LOAD_URL"),
@@ -323,18 +324,27 @@ export function registerLifecycleTools(strictTool) {
         return { content: [{ type: "text", text: JSON.stringify(result) }] };
     });
     // ---------------- quality_gate_complete (absorbs quality_gate_skip, DX-3394 problem 1682) ----------------
-    const qualityGateComplete = strictTool("quality_gate_complete", "Sign off a registered quality gate. Two flavors by the gate's PHASE: (PLAN, e.g. plan-architecture) — " +
-        "runs as its own dispatch; this call is that dispatch's TERMINAL call: status='pass' releases the " +
-        "dispatch (the picker launches the next gate or the work agent); status='fail' BLOCKS the card (your " +
-        "message becomes the reason) and stops the dispatch (do NOT follow up with danxbot_complete); " +
-        "status='retry' — the fixer loop: you edited the card into a sounder plan and want a fresh pass. " +
-        "(CODE, e.g. code-quality) — runs INLINE in your WORK session: stamps the gate + stores findings and " +
-        "does NOTHING else. You CONTINUE: fix any blocking findings, re-run to a pass, then finalize and " +
-        "complete the card normally. status='skipped' — the gate is OBVIOUSLY UNNECESSARY for this diff " +
-        "(a single-line / docs-only change, or nothing in this gate's lane): use `message` as the mandatory " +
-        `justification (≥${QUALITY_GATE_SKIP_REASON_MIN_CHARS} chars, the permanent accountability record a ` +
-        "reviewer will read) — never skip to dodge a real review. A skipped required gate does not block " +
-        "transitioning the card to complete (through danxbot_api) and does not re-dispatch a PRE gate.", {
+    const qualityGateComplete = strictTool("quality_gate_complete", "Sign off a registered quality gate. NEVER visible to (or callable by) the WORK dispatch that authored " +
+        "the diff — DX-3741: every gate, PLAN or CODE, runs as its OWN independent gate-reviewer dispatch, so " +
+        "seeing this tool at all means you ARE that reviewer, not the author. Two flavors by the gate's PHASE: " +
+        "(PLAN, e.g. plan-architecture) — reviews the CARD's plan before any code exists; this call is your " +
+        "dispatch's TERMINAL call: status='pass' releases the dispatch (the picker launches the next gate or " +
+        "the work agent); status='fail' BLOCKS the card (your message becomes the reason) and stops the " +
+        "dispatch (do NOT follow up with danxbot_complete); status='retry' — the fixer loop: you edited the " +
+        "card into a sounder plan and want a fresh pass. (CODE, e.g. code-quality) — reviews `git diff " +
+        "origin/main...HEAD` on the author's `card/<id>` branch, already pushed to origin; this call is ALSO " +
+        "your dispatch's TERMINAL call: report every finding via `findings[]`; status='fail' releases the " +
+        "dispatch and — BELOW the per-gate review-pass cap — does NOT block the card: the author's WORK " +
+        "session, re-dispatched, reads your findings, fixes them, and calls request_code_review again, which " +
+        "re-dispatches every requested code gate fresh; AT the cap (3 review passes, the runaway backstop) a " +
+        "'fail' DOES block the card instead, exactly like a PLAN-phase fail — you are not told which round " +
+        "this is, so sign 'fail' on the findings alone and let the dispatcher enforce the cap; " +
+        "status='pass' releases the dispatch toward the next requested code gate or back to WORK to finalize; " +
+        "status='retry' is PLAN-phase only, refused here. status='skipped' — the gate is OBVIOUSLY " +
+        "UNNECESSARY for this diff (a single-line / docs-only change, or nothing in this gate's lane): use " +
+        `\`message\` as the mandatory justification (≥${QUALITY_GATE_SKIP_REASON_MIN_CHARS} chars, the ` +
+        "permanent accountability record a human will read) — never skip to dodge a real review. You never " +
+        "edit files and never transition the card yourself, on either phase.", {
         gate: z.string().describe("Registered gate name, e.g. 'plan-architecture' or 'code-quality'."),
         status: z.enum(["pass", "fail", "retry", "skipped"]),
         message: z
@@ -367,6 +377,21 @@ export function registerLifecycleTools(strictTool) {
         const result = await postWorkerRoute(url, body, "quality_gate_complete", agentBearer());
         return { content: [{ type: "text", text: JSON.stringify(result) }] };
     });
+    // ---------------- request_code_review (DX-3741) ----------------
+    const requestCodeReview = strictTool("request_code_review", "TERMINAL for this dispatch — call it when your diff is done and its own tests are green, instead of " +
+        "danxbot_complete. Pushes your branch (card/<id> to origin/card/<id>), then dispatches every code " +
+        "gate this card carries as its OWN independent gate-reviewer dispatch (you never sign or review your " +
+        "own diff — DX-3741). Ends this dispatch 'completed' and releases the card to ToDo; when the card is " +
+        "re-dispatched to you, read its quality_gates (through danxbot_api): every code gate pass/skipped → " +
+        "run agent-finalize.sh and complete normally; any fail → fix its findings, then call " +
+        "request_code_review again (never sign or remove a code gate yourself — removal is refused, 409). " +
+        "Takes no arguments. A card with no code gates has nothing to request — finalize directly instead.", {}, async () => {
+        const url = readLifecycleUrlsFromEnv().requestCodeReview;
+        if (!url)
+            throw new Error("request_code_review called outside a work dispatch");
+        const result = await postWorkerRoute(url, {}, "request_code_review", agentBearer());
+        return { content: [{ type: "text", text: JSON.stringify(result) }] };
+    });
     // ---------------- danxbot_set_evaluator_summary ----------------
     const evaluatorSummary = strictTool("danxbot_set_evaluator_summary", "Write the root-cause summary for a 3-strike broken agent. ONLY the system-evaluator dispatch sees this " +
         "tool. Call exactly once at the END of the dispatch, immediately before danxbot_complete. A dispatch " +
@@ -424,6 +449,7 @@ export function registerLifecycleTools(strictTool) {
         slackRecoveryMessage,
         slackRecoveryCreateOrLink,
         qualityGateComplete,
+        requestCodeReview,
         evaluatorSummary,
         saveTemplateApp,
         loadTemplateApp,
@@ -453,6 +479,7 @@ export function applyLifecycleVisibility(tools, urls) {
     setVisible(tools.slackRecoveryMessage, !!urls.slackRecoveryMessage);
     setVisible(tools.slackRecoveryCreateOrLink, !!urls.slackRecoveryCreateOrLink);
     setVisible(tools.qualityGateComplete, !!urls.qualityGate);
+    setVisible(tools.requestCodeReview, !!urls.requestCodeReview);
     setVisible(tools.evaluatorSummary, !!urls.evaluatorSummary);
     setVisible(tools.saveTemplateApp, !!urls.saveTemplateApp);
     setVisible(tools.loadTemplateApp, !!urls.loadTemplateApp);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@thehammer/danx-dashboard-mcp",
-  "version": "0.1.177",
+  "version": "0.1.180",
   "description": "Stdio MCP server fronting danxbot's dashboard API for agents (operator sessions and dispatched workers alike): the generic danxbot_api/danxbot_api_list/danxbot_api_spec tools reach any route the caller's credential may call, plus dedicated agent-specific tools (plan_connect, danxbot_complete, and other per-dispatch lifecycle callbacks) (DX-3465, PLN-11 R-25).",
   "license": "MIT",
   "type": "module",