@theguild/federation-composition 0.9.0 → 0.10.0

package/README.md

@@ -12,7 +12,8 @@ Supports all Federation versions. Drop-in replacement for `@apollo/composition`.
 - produces Supergraph SDL (can be used with Apollo Router and every tool that supports Supergraph
   SDL)
 - does not support Hints
-- a lot faster! 5x faster when composing and validating simple schemas, but 28x faster at big scale.
+- 5x faster when composing and validating small to medium schemas (a bit slower for huge schemas)
+- 2x less memory usage
 
 ## Installation
 

package/cjs/specifications/link.js

@@ -34,10 +34,41 @@ function printLink(link) {
                 },
                 value: {
                     kind: graphql_1.Kind.LIST,
-                    values: link.imports.map(im => ({
-                        kind: graphql_1.Kind.STRING,
-                        value: im.name,
-                    })),
+                    values: link.imports.map(im => {
+                        if (!im.alias) {
+                            return {
+                                kind: graphql_1.Kind.STRING,
+                                value: im.name,
+                            };
+                        }
+                        return {
+                            kind: graphql_1.Kind.OBJECT,
+                            fields: [
+                                {
+                                    kind: graphql_1.Kind.OBJECT_FIELD,
+                                    name: {
+                                        kind: graphql_1.Kind.NAME,
+                                        value: 'name',
+                                    },
+                                    value: {
+                                        kind: graphql_1.Kind.STRING,
+                                        value: im.name,
+                                    },
+                                },
+                                {
+                                    kind: graphql_1.Kind.OBJECT_FIELD,
+                                    name: {
+                                        kind: graphql_1.Kind.NAME,
+                                        value: 'as',
+                                    },
+                                    value: {
+                                        kind: graphql_1.Kind.STRING,
+                                        value: im.alias,
+                                    },
+                                },
+                            ],
+                        };
+                    }),
                 },
             },
         ],
@@ -162,7 +193,11 @@ function mergeLinks(links) {
     return Array.from(groupByIdentity.entries()).map(([identity, link]) => ({
         identity,
         version: link.highestVersion,
-        imports: Array.from(link.imports).map(link => ({ kind: link.kind, name: link.name })),
+        imports: Array.from(link.imports).map(link => ({
+            kind: link.kind,
+            name: link.name,
+            alias: link.alias,
+        })),
         name: link.name,
     }));
 }

package/cjs/subgraph/helpers.js

@@ -37,10 +37,10 @@ function validateDirectiveAgainstOriginal(providedDirectiveNode, directiveName,
             if (expectedType !== providedType) {
                 const isNonNullableString = providedType === 'String!';
                 const allowedFieldSetTypes = isFederationV2
-                    ? ['FieldSet!', 'federation__FieldSet!', '_FieldSet!']
+                    ? ['FieldSet!', 'federation__FieldSet!', '_FieldSet!', '[String!]!']
                     : ['_FieldSet!', 'String', 'String!'];
                 const fieldSetTypesInSpec = isFederationV2
-                    ? ['FieldSet!', 'federation__FieldSet!', '_FieldSet!']
+                    ? ['FieldSet!', 'federation__FieldSet!', '_FieldSet!', '[String!]!']
                     : ['_FieldSet!', 'FieldSet!', 'String'];
                 const expectsFieldSet = fieldSetTypesInSpec.includes(expectedType);
                 if (!isNonNullableString && expectsFieldSet) {

package/cjs/subgraph/state.js

@@ -104,6 +104,9 @@ function createSubgraphStateBuilder(graph, typeDefs, version, links) {
                         throw new Error(`Expected to find an object type`);
                     }
                     objectTypeBuilder.field.setType(typeDef.name.value, node.name.value, (0, helpers_js_1.printOutputType)(node.type));
+                    if (typeDef.kind === graphql_1.Kind.OBJECT_TYPE_EXTENSION) {
+                        objectTypeBuilder.field.setExtension(typeDef.name.value, node.name.value);
+                    }
                     if (version === 'v1.0' &&
                         (typeDef.kind === graphql_1.Kind.OBJECT_TYPE_DEFINITION ||
                             typeDef.name.value === expectedQueryTypeName ||
@@ -596,6 +599,9 @@ function objectTypeFactory(state, renameObject) {
             setType(typeName, fieldName, fieldType) {
                 getOrCreateObjectField(state, renameObject, typeName, fieldName).type = fieldType;
             },
+            setExtension(typeName, fieldName) {
+                getOrCreateObjectField(state, renameObject, typeName, fieldName).extension = true;
+            },
             setDirective(typeName, fieldName, directive) {
                 getOrCreateObjectField(state, renameObject, typeName, fieldName).ast.directives.push(directive);
             },
@@ -1108,6 +1114,7 @@ function getOrCreateObjectField(state, renameObject, typeName, fieldName) {
         external: false,
         inaccessible: false,
         authenticated: false,
+        extension: false,
         policies: [],
         scopes: [],
         used: false,
@@ -1147,6 +1154,7 @@ function getOrCreateInterfaceField(state, typeName, fieldName) {
         required: false,
         provided: false,
         shareable: false,
+        extension: false,
         tags: new Set(),
         args: new Map(),
         ast: {

package/cjs/subgraph/validation/rules/elements/provides.js

@@ -106,12 +106,14 @@ function ProvidesRules(context) {
                     context.reportError(new graphql_1.GraphQLError(`On field "${fieldCoordinate}", for @provides(fields: ${printedFieldsValue}): field ${info.typeDefinition.name.value}.${info.fieldName} cannot be included because it has arguments (fields with argument are not allowed in @provides)`, { nodes: directiveNode, extensions: { code: 'PROVIDES_FIELDS_HAS_ARGS' } }));
                 },
                 interceptNonExternalField(info) {
-                    isValid = false;
-                    context.reportError(new graphql_1.GraphQLError(`On field "${fieldCoordinate}", for @provides(fields: ${printedFieldsValue}): field "${info.typeDefinition.name.value}.${info.fieldName}" should not be part of a @provides since it is already provided by this subgraph (it is not marked @external)`, {
-                        extensions: {
-                            code: 'PROVIDES_FIELDS_MISSING_EXTERNAL',
-                        },
-                    }));
+                    if (context.satisfiesVersionRange('> v1.0')) {
+                        isValid = false;
+                        context.reportError(new graphql_1.GraphQLError(`On field "${fieldCoordinate}", for @provides(fields: ${printedFieldsValue}): field "${info.typeDefinition.name.value}.${info.fieldName}" should not be part of a @provides since it is already provided by this subgraph (it is not marked @external)`, {
+                            extensions: {
+                                code: 'PROVIDES_FIELDS_MISSING_EXTERNAL',
+                            },
+                        }));
+                    }
                 },
                 interceptExternalField(info) {
                     const keyDirectives = info.typeDefinition.directives?.filter(directive => context.isAvailableFederationDirective('key', directive));

package/cjs/subgraph/validation/rules/elements/requires.js

@@ -33,7 +33,7 @@ function RequiresRules(context) {
                 return;
             }
             const printedFieldsValue = (0, printer_js_1.print)(fieldsArg.value);
-            if (fieldsArg.value.kind !== graphql_1.Kind.STRING) {
+            if (fieldsArg.value.kind !== graphql_1.Kind.STRING && fieldsArg.value.kind !== graphql_1.Kind.ENUM) {
                 context.reportError(new graphql_1.GraphQLError(`On field "${fieldCoordinate}", for @requires(fields: ${printedFieldsValue}): Invalid value for argument "fields": must be a string.`, {
                     nodes: directiveNode,
                     extensions: {
@@ -106,12 +106,14 @@ function RequiresRules(context) {
                     }
                 },
                 interceptNonExternalField(info) {
-                    isValid = false;
-                    context.reportError(new graphql_1.GraphQLError(`On field "${fieldCoordinate}", for @requires(fields: ${printedFieldsValue}): field "${info.typeDefinition.name.value}.${info.fieldName}" should not be part of a @requires since it is already provided by this subgraph (it is not marked @external)`, {
-                        extensions: {
-                            code: 'REQUIRES_FIELDS_MISSING_EXTERNAL',
-                        },
-                    }));
+                    if (context.satisfiesVersionRange('> v1.0')) {
+                        isValid = false;
+                        context.reportError(new graphql_1.GraphQLError(`On field "${fieldCoordinate}", for @requires(fields: ${printedFieldsValue}): field "${info.typeDefinition.name.value}.${info.fieldName}" should not be part of a @requires since it is already provided by this subgraph (it is not marked @external)`, {
+                            extensions: {
+                                code: 'REQUIRES_FIELDS_MISSING_EXTERNAL',
+                            },
+                        }));
+                    }
                 },
             });
             if (isValid) {

package/cjs/subgraph/validation/validate-state.js

@@ -6,7 +6,7 @@ const format_js_1 = require("../../utils/format.js");
 const state_js_1 = require("../../utils/state.js");
 const state_js_2 = require("../state.js");
 const specifiedScalars = new Set(graphql_1.specifiedScalarTypes.map(t => t.name));
-function validateSubgraphState(state) {
+function validateSubgraphState(state, context) {
     const errors = [];
     function reportError(message) {
         errors.push(new graphql_1.GraphQLError(message, {
@@ -16,7 +16,7 @@ function validateSubgraphState(state) {
         }));
     }
     validateRootTypes(state, reportError);
-    validateDirectives(state, reportError);
+    validateDirectives(state, reportError, context);
     validateTypes(state, reportError);
     return errors;
 }
@@ -58,13 +58,19 @@ function validateRootTypes(state, reportError) {
 function capitalize(str) {
     return str.charAt(0).toUpperCase() + str.slice(1).toLowerCase();
 }
-function validateDirectives(state, reportError) {
+function validateDirectives(state, reportError, context) {
     for (const directive of state.types.values()) {
         if (isDirective(directive)) {
+            if (context.isLinkSpecDirective(directive.name)) {
+                continue;
+            }
             validateName(reportError, directive.name);
             for (const [argName, arg] of directive.args) {
                 validateName(reportError, argName);
                 const argInputTypeName = (0, state_js_1.stripTypeModifiers)(arg.type);
+                if (context.isLinkSpecType(argInputTypeName)) {
+                    continue;
+                }
                 if (!isInputType(state, argInputTypeName)) {
                     reportError(`The type of @${directive.name}(${arg.name}:) must be Input Type ` +
                         `but got: ${arg.type}.`);

package/cjs/subgraph/validation/validate-subgraph.js

@@ -162,7 +162,7 @@ function validateSubgraph(subgraph, stateBuilder, federation, __internal) {
             : null,
         subgraph.typeDefs,
     ].filter(onlyDocumentNode));
-    const subgraphStateErrors = (0, validate_state_js_1.validateSubgraphState)(stateBuilder.state);
+    const subgraphStateErrors = (0, validate_state_js_1.validateSubgraphState)(stateBuilder.state, validationContext);
     const simpleValidationContext = (0, validation_context_js_1.createSimpleValidationContext)(fullTypeDefs, typeNodeInfo);
     (0, graphql_1.visit)(fullTypeDefs, (0, graphql_1.visitInParallel)(graphqlRules.map(rule => {
         if (rulesToSkip.includes(rule.name)) {
@@ -322,7 +322,9 @@ function cleanSubgraphTypeDefsFromSubgraphSpec(typeDefs) {
     const queryTypeName = schemaDef?.operationTypes?.find(op => op.operation === graphql_1.OperationTypeNode.QUERY)?.type.name
         .value ?? 'Query';
     typeDefs.definitions = typeDefs.definitions.filter(def => {
-        if (def.kind === graphql_1.Kind.SCALAR_TYPE_DEFINITION && def.name.value === '_Any') {
+        if ((def.kind === graphql_1.Kind.SCALAR_TYPE_DEFINITION ||
+            def.kind === graphql_1.Kind.INPUT_OBJECT_TYPE_DEFINITION) &&
+            def.name.value === '_Any') {
             return false;
         }
         if (def.kind === graphql_1.Kind.UNION_TYPE_DEFINITION && def.name.value === '_Entity') {

package/cjs/subgraph/validation/validation-context.js

@@ -3,8 +3,12 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.createSubgraphValidationContext = exports.createSimpleValidationContext = void 0;
 const graphql_1 = require("graphql");
 const federation_js_1 = require("../../specifications/federation.js");
+const link_js_1 = require("../../specifications/link.js");
 const state_js_1 = require("../../utils/state.js");
 const state_js_2 = require("../state.js");
+const linkSpec = (0, graphql_1.parse)(link_js_1.sdl);
+const linkSpecDirectives = linkSpec.definitions.filter((def) => def.kind === graphql_1.Kind.DIRECTIVE_DEFINITION);
+const linkSpecTypes = linkSpec.definitions.filter(graphql_1.isTypeDefinitionNode);
 function createSimpleValidationContext(typeDefs, typeNodeInfo) {
     let reportedErrors = [];
     const directiveDefinitionMap = new Map();
@@ -155,6 +159,12 @@ function createSubgraphValidationContext(subgraph, federation, typeNodeInfo, sta
     }
     return {
         stateBuilder,
+        isLinkSpecDirective(name) {
+            return linkSpecDirectives.some(d => d.name.value === name);
+        },
+        isLinkSpecType(name) {
+            return linkSpecTypes.some(t => t.name.value === name);
+        },
         isAvailableFederationType(name) {
             const alternativeNames = typeAlternativeNamesMap.get(name);
             if (alternativeNames) {

package/cjs/supergraph/composition/directive.js

@@ -31,11 +31,13 @@ function directiveBuilder() {
                 argState.byGraph.set(graph.id, {
                     type: arg.type,
                     defaultValue: arg.defaultValue,
+                    version: graph.version,
                 });
             }
             directiveState.byGraph.set(graph.id, {
                 locations: directive.locations,
                 repeatable: directive.repeatable,
+                version: graph.version,
             });
         },
         composeSupergraphNode(directive) {
@@ -64,6 +66,7 @@ function getOrCreateDirective(state, directiveName) {
         return existing;
     }
     const def = {
+        kind: 'directive',
         name: directiveName,
         locations: new Set(),
         byGraph: new Map(),

package/cjs/supergraph/composition/enum-type.js

@@ -39,6 +39,7 @@ function enumTypeBuilder() {
             }
             enumTypeState.byGraph.set(graph.id, {
                 inaccessible: type.inaccessible,
+                version: graph.version,
             });
             for (const value of type.values.values()) {
                 const valueState = getOrCreateEnumValue(enumTypeState, value.name);
@@ -54,6 +55,7 @@ function enumTypeBuilder() {
                 }
                 valueState.byGraph.set(graph.id, {
                     inaccessible: value.inaccessible,
+                    version: graph.version,
                 });
             }
         },
@@ -114,6 +116,7 @@ function getOrCreateEnumType(state, typeName) {
         return existing;
     }
     const def = {
+        kind: 'enum',
         name: typeName,
         values: new Map(),
         tags: new Set(),

package/cjs/supergraph/composition/input-object-type.js

@@ -19,6 +19,7 @@ function inputObjectTypeBuilder() {
             }
             inputObjectTypeState.byGraph.set(graph.id, {
                 inaccessible: type.inaccessible,
+                version: graph.version,
             });
             for (const field of type.fields.values()) {
                 const fieldState = getOrCreateField(inputObjectTypeState, field.name, field.type);
@@ -42,6 +43,7 @@ function inputObjectTypeBuilder() {
                     type: field.type,
                     inaccessible: field.inaccessible,
                     defaultValue: field.defaultValue,
+                    version: graph.version,
                 });
             }
         },
@@ -95,6 +97,7 @@ function getOrCreateInputObjectType(state, typeName) {
         return existing;
     }
     const def = {
+        kind: 'input',
         name: typeName,
         tags: new Set(),
         hasDefinition: false,

package/cjs/supergraph/composition/interface-type.js

@@ -36,6 +36,7 @@ function interfaceTypeBuilder() {
                 keys: type.keys,
                 interfaces: type.interfaces,
                 implementedBy: type.implementedBy,
+                version: graph.version,
             });
             for (const field of type.fields.values()) {
                 const fieldState = getOrCreateInterfaceField(interfaceTypeState, field.name, field.type);
@@ -69,6 +70,7 @@ function interfaceTypeBuilder() {
                     override: field.override,
                     provides: field.provides,
                     requires: field.requires,
+                    version: graph.version,
                 });
                 for (const arg of field.args.values()) {
                     const argState = getOrCreateArg(fieldState, arg.name, arg.type);
@@ -91,6 +93,7 @@ function interfaceTypeBuilder() {
                     argState.byGraph.set(graph.id, {
                         type: arg.type,
                         defaultValue: arg.defaultValue,
+                        version: graph.version,
                     });
                 }
             }
@@ -197,6 +200,7 @@ function getOrCreateInterfaceType(state, typeName) {
         return existing;
     }
     const def = {
+        kind: 'interface',
         name: typeName,
         tags: new Set(),
         inaccessible: false,

package/cjs/supergraph/composition/object-type.js

@@ -63,6 +63,7 @@ function objectTypeBuilder() {
                 inaccessible: type.inaccessible,
                 shareable: type.shareable,
                 interfaces: type.interfaces,
+                version: graph.version,
             });
             const typeInGraph = objectTypeState.byGraph.get(graph.id);
             for (const field of type.fields.values()) {
@@ -120,8 +121,10 @@ function objectTypeBuilder() {
                     provided: field.provided,
                     required: field.required,
                     shareable: field.shareable,
+                    extension: field.extension,
                     used: field.used,
                     usedAsKey,
+                    version: graph.version,
                 });
                 for (const arg of field.args.values()) {
                     const argState = getOrCreateArg(fieldState, arg.name, arg.type);
@@ -148,6 +151,7 @@ function objectTypeBuilder() {
                         type: arg.type,
                         inaccessible: arg.inaccessible,
                         defaultValue: arg.defaultValue,
+                        version: graph.version,
                     });
                 }
             }
@@ -157,7 +161,7 @@ function objectTypeBuilder() {
             const joinTypes = isQuery
                 ?
                     Array.from(graphs.values()).map(graph => ({
-                        graph: graph.id,
+                        graph: graph.graph.id,
                     }))
                 :
                     Array.from(objectType.byGraph.entries())
@@ -220,12 +224,12 @@ function objectTypeBuilder() {
                 }
                 return true;
             }
-            function createJoinFields(fieldInGraphs, field, { hasDifferentOutputType, overridesMap, }) {
+            function createJoinFields(fieldInGraphs, field, { hasDifferentOutputType, }) {
                 return fieldInGraphs
                     .map(([graphId, meta]) => {
                     const type = hasDifferentOutputType ? meta.type : undefined;
                     const override = meta.override ?? undefined;
-                    const usedOverridden = provideUsedOverriddenValue(field.name, meta, overridesMap, fieldNamesOfImplementedInterfaces, graphId);
+                    const usedOverridden = provideUsedOverriddenValue(field, meta, fieldNamesOfImplementedInterfaces, graphId, graphNameToId);
                     const external = shouldSetExternalOnJoinField(meta, graphId, field);
                     const provides = meta.provides ?? undefined;
                     const requires = meta.requires ?? undefined;
@@ -261,7 +265,6 @@ function objectTypeBuilder() {
                     const hasDifferentOutputType = fieldInGraphs.some(([_, meta]) => meta.type !== field.type);
                     const isDefinedEverywhere = field.byGraph.size === (isQuery ? graphs.size : objectType.byGraph.size);
                     let joinFields = [];
-                    const overridesMap = {};
                     const differencesBetweenGraphs = {
                         override: false,
                         type: false,
@@ -277,10 +280,6 @@ function objectTypeBuilder() {
                         }
                         if (meta.override !== null) {
                             differencesBetweenGraphs.override = true;
-                            const originalGraphId = graphNameToId(meta.override);
-                            if (originalGraphId) {
-                                overridesMap[originalGraphId] = graphId;
-                            }
                         }
                         if (meta.provides !== null) {
                             differencesBetweenGraphs.provides = true;
@@ -299,7 +298,7 @@ function objectTypeBuilder() {
                             !fieldInGraph.usedAsKey &&
                             !fieldInGraph.required &&
                             !fieldInGraph.provided &&
-                            !provideUsedOverriddenValue(field.name, fieldInGraph, overridesMap, fieldNamesOfImplementedInterfaces, graphId) &&
+                            !provideUsedOverriddenValue(field, fieldInGraph, fieldNamesOfImplementedInterfaces, graphId, graphNameToId) &&
                             graphs.get(graphId).version === 'v1.0') {
                             return null;
                         }
@@ -315,7 +314,7 @@ function objectTypeBuilder() {
                             joinFields = graphsWithOverride.map(([graphId, meta]) => ({
                                 graph: graphId,
                                 override: meta.override ?? undefined,
-                                usedOverridden: provideUsedOverriddenValue(field.name, meta, overridesMap, fieldNamesOfImplementedInterfaces, graphId),
+                                usedOverridden: provideUsedOverriddenValue(field, meta, fieldNamesOfImplementedInterfaces, graphId, graphNameToId),
                                 type: differencesBetweenGraphs.type ? meta.type : undefined,
                                 external: meta.external ?? undefined,
                                 provides: meta.provides ?? undefined,
@@ -343,7 +342,7 @@ function objectTypeBuilder() {
                             const graphsToEmit = fieldInGraphs.filter(([graphId, f]) => {
                                 const isExternal = f.external === true;
                                 const isOverridden = overriddenGraphs.includes(graphId);
-                                const needsToPrintUsedOverridden = provideUsedOverriddenValue(field.name, f, overridesMap, fieldNamesOfImplementedInterfaces, graphId);
+                                const needsToPrintUsedOverridden = provideUsedOverriddenValue(field, f, fieldNamesOfImplementedInterfaces, graphId, graphNameToId);
                                 const isRequired = f.required === true;
                                 return (isExternal && isRequired) || needsToPrintUsedOverridden || !isOverridden;
                             });
@@ -353,7 +352,7 @@ function objectTypeBuilder() {
                                 joinFields = graphsToEmit.map(([graphId, meta]) => ({
                                     graph: graphId,
                                     override: meta.override ?? undefined,
-                                    usedOverridden: provideUsedOverriddenValue(field.name, meta, overridesMap, fieldNamesOfImplementedInterfaces, graphId),
+                                    usedOverridden: provideUsedOverriddenValue(field, meta, fieldNamesOfImplementedInterfaces, graphId, graphNameToId),
                                     type: differencesBetweenGraphs.type ? meta.type : undefined,
                                     external: meta.external ?? undefined,
                                     provides: meta.provides ?? undefined,
@@ -364,7 +363,6 @@ function objectTypeBuilder() {
                         else if (hasDifferencesBetweenGraphs) {
                             joinFields = createJoinFields(fieldInGraphs, field, {
                                 hasDifferentOutputType,
-                                overridesMap,
                             });
                         }
                     }
@@ -376,11 +374,11 @@ function objectTypeBuilder() {
                             const graphsToPrintJoinField = fieldInGraphs.filter(([graphId, meta]) => meta.override !== null ||
                                 meta.external === true ||
                                 (meta.shareable && !overriddenGraphs.includes(graphId)) ||
-                                provideUsedOverriddenValue(field.name, meta, overridesMap, fieldNamesOfImplementedInterfaces, graphId));
+                                provideUsedOverriddenValue(field, meta, fieldNamesOfImplementedInterfaces, graphId, graphNameToId));
                             joinFields = graphsToPrintJoinField.map(([graphId, meta]) => ({
                                 graph: graphId,
                                 override: meta.override ?? undefined,
-                                usedOverridden: provideUsedOverriddenValue(field.name, meta, overridesMap, fieldNamesOfImplementedInterfaces, graphId),
+                                usedOverridden: provideUsedOverriddenValue(field, meta, fieldNamesOfImplementedInterfaces, graphId, graphNameToId),
                                 type: differencesBetweenGraphs.type ? meta.type : undefined,
                                 external: meta.external ?? undefined,
                                 provides: meta.provides ?? undefined,
@@ -390,7 +388,6 @@ function objectTypeBuilder() {
                         else {
                             joinFields = createJoinFields(fieldInGraphs, field, {
                                 hasDifferentOutputType,
-                                overridesMap,
                             });
                         }
                     }
@@ -470,12 +467,12 @@ function objectTypeBuilder() {
     };
 }
 exports.objectTypeBuilder = objectTypeBuilder;
-function provideUsedOverriddenValue(fieldName, fieldStateInGraph, overridesMap, fieldNamesOfImplementedInterfaces, graphId) {
-    const inGraphs = fieldNamesOfImplementedInterfaces[fieldName];
+function provideUsedOverriddenValue(field, fieldStateInGraph, fieldNamesOfImplementedInterfaces, graphId, graphNameToId) {
+    const inGraphs = fieldNamesOfImplementedInterfaces[field.name];
     const hasMatchingInterfaceFieldInGraph = inGraphs && inGraphs.has(graphId);
     const isUsedAsNonExternalKey = fieldStateInGraph.usedAsKey && !fieldStateInGraph.external;
-    const hasOverride = typeof overridesMap[graphId] === 'string';
-    if (hasOverride && (isUsedAsNonExternalKey || hasMatchingInterfaceFieldInGraph)) {
+    const isOverridden = field.override && graphNameToId(field.override) === graphId;
+    if (isOverridden && (isUsedAsNonExternalKey || hasMatchingInterfaceFieldInGraph)) {
         return true;
     }
     return false;
@@ -486,6 +483,7 @@ function getOrCreateObjectType(state, typeName) {
         return existing;
     }
     const def = {
+        kind: 'object',
         name: typeName,
         tags: new Set(),
         hasDefinition: false,

package/cjs/supergraph/composition/scalar-type.js

@@ -31,6 +31,7 @@ function scalarTypeBuilder() {
             });
             scalarTypeState.byGraph.set(graph.id, {
                 inaccessible: type.inaccessible,
+                version: graph.version,
             });
         },
         composeSupergraphNode(scalarType) {
@@ -62,6 +63,7 @@ function getOrCreateScalarType(state, typeName) {
         return existing;
     }
     const def = {
+        kind: 'scalar',
         name: typeName,
         tags: new Set(),
         inaccessible: false,

package/cjs/supergraph/composition/union-type.js

@@ -18,6 +18,7 @@ function unionTypeBuilder() {
             }
             unionTypeState.byGraph.set(graph.id, {
                 members: type.members,
+                version: graph.version,
             });
             for (const member of type.members) {
                 unionTypeState.members.add(member);
@@ -52,6 +53,7 @@ function getOrCreateUnionType(state, typeName) {
         return existing;
     }
     const def = {
+        kind: 'union',
         name: typeName,
         members: new Set(),
         tags: new Set(),