@thead-vantage/react 2.7.0 → 2.9.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@thead-vantage/react",
-  "version": "2.7.0",
+  "version": "2.9.0",
   "description": "React components and utilities for TheAd Vantage ad platform integration",
   "main": "./src/index.ts",
   "module": "./src/index.ts",

package/src/components/AdBanner.tsx

@@ -124,7 +124,7 @@ export function AdBanner({
         rel="noopener noreferrer"
         className="block"
       >
-        {ad.type === 'image' ? (
+        {(ad.type === 'image' || ad.type === 'standard') && ad.contentUrl ? (
           <Image
             src={ad.contentUrl}
             alt={ad.name}

package/src/components/AdDisplay.tsx

@@ -2,7 +2,13 @@
 
 import { useEffect, useState } from 'react';
 import Image from 'next/image';
-import { fetchAds, trackImpression, trackClick, type AdData } from '../lib/ads';
+import { 
+  fetchAds, 
+  trackImpression, 
+  trackClick, 
+  type AdData, 
+  type AdsResponse 
+} from '../lib/ads';
 
 interface AdDisplayProps {
   position?: string;
@@ -21,12 +27,15 @@ export default function AdDisplay({ position, className = '' }: AdDisplayProps)
         setLoading(true);
         setError(null);
         
-        const params: Record<string, string> = {};
-        if (position) {
-          params.position = position;
-        }
+        // Build params object - fetchAds accepts Record<string, string> | undefined
+        // Note: fetchAds is different from fetchAdBanner (which requires platformId/apiKey)
+        const params: Record<string, string> | undefined = position 
+          ? { position } 
+          : undefined;
         
-        const response = await fetchAds(params);
+        // Explicitly type to avoid confusion with fetchAdBanner's FetchAdBannerParams
+        const fetchAdsTyped: (params?: Record<string, string>) => Promise<AdsResponse> = fetchAds;
+        const response = await fetchAdsTyped(params);
         
         if (response.success && response.ad) {
           setAd(response.ad);

package/src/lib/ads.ts

@@ -56,6 +56,9 @@ export interface FetchAdBannerParams {
 /**
  * Fetch ads from TheAd Vantage platform (generic)
  * In development mode, uses mock data and prevents tracking
+ * 
+ * @param params - Optional query parameters as key-value pairs
+ * @returns Promise resolving to AdsResponse
  */
 export async function fetchAds(params?: Record<string, string>): Promise<AdsResponse> {
   try {
@@ -183,6 +186,14 @@ export async function fetchAdBanner(params: FetchAdBannerParams): Promise<AdBann
       };
     };
 
+    // Helper to normalize ad type - "standard" should be treated as "image"
+    const normalizeAdType = (ad: Ad): Ad => {
+      if (ad.type === 'standard' && ad.contentUrl) {
+        return { ...ad, type: 'image' };
+      }
+      return ad;
+    };
+
     // Handle both single ad and array of ads
     if (data.ads && Array.isArray(data.ads) && data.ads.length > 0) {
       // If we get an array, use the first ad and ensure it's Ad type
@@ -190,10 +201,13 @@ export async function fetchAdBanner(params: FetchAdBannerParams): Promise<AdBann
       console.log('[AdBanner] Processing ads array, first ad:', JSON.stringify(firstAd, null, 2));
       
       // Check if it's already an Ad, otherwise convert from AdData
-      const ad: Ad = isAd(firstAd) 
+      let ad: Ad = isAd(firstAd) 
         ? firstAd 
         : convertToAd(firstAd as AdData);
       
+      // Normalize the type (standard -> image)
+      ad = normalizeAdType(ad);
+      
       console.log('[AdBanner] Converted ad:', JSON.stringify(ad, null, 2));
       
       return {
@@ -206,10 +220,19 @@ export async function fetchAdBanner(params: FetchAdBannerParams): Promise<AdBann
     }
 
     // Handle single ad response - convert AdData to Ad
-    // Since data.ad is typed as AdData, we always convert it
     if (data.ad) {
       console.log('[AdBanner] Processing single ad:', JSON.stringify(data.ad, null, 2));
-      const ad: Ad = convertToAd(data.ad);
+      
+      // Check if it's already in Ad format or needs conversion
+      let ad: Ad;
+      if (isAd(data.ad)) {
+        // Already in Ad format, normalize the type
+        ad = normalizeAdType(data.ad);
+      } else {
+        // Convert from AdData format
+        ad = convertToAd(data.ad);
+      }
+      
       console.log('[AdBanner] Converted ad:', JSON.stringify(ad, null, 2));
       
       return {