@thead-vantage/react 2.12.0 → 2.14.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@thead-vantage/react",
-  "version": "2.12.0",
+  "version": "2.14.0",
   "description": "React components and utilities for TheAd Vantage ad platform integration",
   "main": "./src/index.ts",
   "module": "./src/index.ts",

package/src/lib/ads.ts

@@ -378,6 +378,15 @@ export async function trackImpression(adId: string): Promise<void> {
       trackingUrl = trackingUrl.replace(/\/$/, '') + '/api/ads/track';
     }
     
+    // Normalize URL to HTTPS and ensure www (avoid 308 redirects)
+    if (trackingUrl.startsWith('http://')) {
+      trackingUrl = trackingUrl.replace('http://', 'https://');
+    }
+    // Ensure www to avoid redirects
+    if (trackingUrl.includes('thead-vantage.com') && !trackingUrl.includes('www.')) {
+      trackingUrl = trackingUrl.replace('thead-vantage.com', 'www.thead-vantage.com');
+    }
+    
     // Check if we should skip tracking (dev mode)
     const useDevFlags = shouldUseDevFlags();
     if (useDevFlags) {
@@ -387,6 +396,8 @@ export async function trackImpression(adId: string): Promise<void> {
     
     const response = await fetch(trackingUrl, {
       method: 'POST',
+      mode: 'cors', // Explicitly enable CORS
+      credentials: 'omit', // Don't send cookies
       headers: {
         'Content-Type': 'application/json',
         'Accept': 'application/json',
@@ -407,7 +418,14 @@ export async function trackImpression(adId: string): Promise<void> {
       console.log(`[DEV] Impression tracking skipped for ad: ${adId}`);
     }
   } catch (error) {
-    console.error('Error tracking impression:', error);
+    // Handle CORS errors gracefully (tracking failures shouldn't break the app)
+    if (error instanceof TypeError && (error.message.includes('CORS') || error.message.includes('Failed to fetch'))) {
+      // This is expected until the server configures CORS for /api/ads/track endpoint
+      // The ad still displays correctly, tracking just won't work until server-side CORS is fixed
+      console.debug(`[AdBanner] Tracking impression failed (CORS): The /api/ads/track endpoint needs CORS headers configured on the server. Ad still displayed successfully.`);
+    } else {
+      console.error('Error tracking impression:', error);
+    }
     // Don't throw - tracking failures shouldn't break the app
   }
 }
@@ -430,6 +448,15 @@ export async function trackClick(adId: string): Promise<void> {
       trackingUrl = trackingUrl.replace(/\/$/, '') + '/api/ads/track';
     }
     
+    // Normalize URL to HTTPS and ensure www (avoid 308 redirects)
+    if (trackingUrl.startsWith('http://')) {
+      trackingUrl = trackingUrl.replace('http://', 'https://');
+    }
+    // Ensure www to avoid redirects
+    if (trackingUrl.includes('thead-vantage.com') && !trackingUrl.includes('www.')) {
+      trackingUrl = trackingUrl.replace('thead-vantage.com', 'www.thead-vantage.com');
+    }
+    
     // Check if we should skip tracking (dev mode)
     const useDevFlags = shouldUseDevFlags();
     if (useDevFlags) {
@@ -439,6 +466,8 @@ export async function trackClick(adId: string): Promise<void> {
     
     const response = await fetch(trackingUrl, {
       method: 'POST',
+      mode: 'cors', // Explicitly enable CORS
+      credentials: 'omit', // Don't send cookies
       headers: {
         'Content-Type': 'application/json',
         'Accept': 'application/json',
@@ -459,7 +488,14 @@ export async function trackClick(adId: string): Promise<void> {
       console.log(`[DEV] Click tracking skipped for ad: ${adId}`);
     }
   } catch (error) {
-    console.error('Error tracking click:', error);
+    // Handle CORS errors gracefully (tracking failures shouldn't break the app)
+    if (error instanceof TypeError && (error.message.includes('CORS') || error.message.includes('Failed to fetch'))) {
+      // This is expected until the server configures CORS for /api/ads/track endpoint
+      // The ad still works correctly, click tracking just won't work until server-side CORS is fixed
+      console.debug(`[AdBanner] Tracking click failed (CORS): The /api/ads/track endpoint needs CORS headers configured on the server. Ad still works correctly.`);
+    } else {
+      console.error('Error tracking click:', error);
+    }
     // Don't throw - tracking failures shouldn't break the app
   }
 }