@the-portland-company/shell 0.84.0 → 0.86.0

package/CHANGELOG.md

@@ -1,3 +1,22 @@
+## 0.86.0
+
+Campaign Mode gets a Tribes row. Spec cited: Specs/Tribes §2.3–§2.4 and Specs/Left-Navigation §9.2 (decided 2026-10-16 by Ben: Campaign and Relationship Tribes are separate; Campaign Tribes live in Campaign Mode).
+
+- **Campaign tree.** Race data now lists Battleground · District data · **Tribes** (`users-round`), linking to `https://battleground.politogyvrm.com/tribes` (org carried as before). It is a page of the Battleground app at `/tribes`, so it is the only active row there.
+- **Relationship tree unchanged.** Relationship Tribes stay inside Contacts → Tribes; there is still no Relationship Tribes row.
+- **Release order.** Publish after the Battleground app serves `/tribes`, so the row never links to a missing page.
+- Tests: `__tests__/standardNav.test.ts`.
+
+## 0.85.0
+
+The mode switcher, the rail and the rows always show one mode. Spec cited: Specs/Left-Navigation §9.1, §9.2, §9.4 and §11.1 ("the rail never shows a mix of two modes").
+
+- **Why.** Reported by Ben and measured on production 2026-10-16 on "We need Steve": after picking Campaign, Contacts (and Forms, Surveys, CTAs) drew the red "Campaign mode" rail and the Campaign search placeholder around Relationship rows, even after a reload. These apps had no registry mode, so the switcher took the user's last choice (`vrm.activeMode`) while the rows stayed Relationship.
+- **Registry.** `contacts`, `forms`, `surveys` and `ctas` are pinned to `mode: 'relationship'`: they are Relationship rows only (§9.1) and Campaign has none of them (§9.2). Same fix as the Dashboard's earlier pin. Clicking another mode still goes to that mode's landing.
+- **Unpinned apps** (Settings: the Account section is in every mode, §9.4) draw the tree of the mode their switcher shows, so rows, rail colour and label agree. Core (`vrm`) is unchanged.
+- **Loading Screen.** For an unpinned app it stays up until the organization's Modes are read, so the rail never changes mode under the user. `NavMode` gains optional `resolved` (false while the id is a stand-in).
+- Tests: `__tests__/modeNavAgree.test.tsx`; `frame-grants.test.tsx` updated for the new pins.
+
 ## 0.84.0
 
 An organization switch lands on the new organization's Relationship Dashboard. Spec cited: Specs/Left-Navigation §6 and §11.2 (v21, decided 2026-10-15 by Ben; supersedes the 2026-10-06 rule that kept mode, page and tab).

package/dist/app-chrome.cjs

@@ -2443,13 +2443,19 @@ function standardPolitogyNav(opts) {
     const rows = [
       // Left-Navigation §9.2: Race data -> Research -> GOTV -> Account.
       // Battleground is the Campaign landing page; there is no Campaign
-      // Dashboard row, and Voter Contact and Tribes have no row.
+      // Dashboard row, and Voter Contact has no row. Campaign Tribes has its
+      // own row after District data (decided 2026-10-16).
       { kind: "section", label: "Race data" },
       // Battleground is the Campaign Mode landing page, its own app on its own
       // host (registry key `battleground`; Specs/Left-Navigation §9.2, §13, §14).
       { label: "Battleground", icon: icon("crosshair"), href: withOrg(`${BATTLEGROUND_ORIGIN}battleground`) },
       // District Data is its own Campaign Mode app on its own host (registry key `districts`).
       { label: "District data", icon: icon("landmark"), href: withOrg(`${DISTRICTS_ORIGIN}districts`) },
+      // Campaign Tribes (Specs/Tribes §2.3–§2.4, Left-Navigation §9.2; decided
+      // 2026-10-16, Ben): a page of the Battleground app at /tribes, so it is
+      // the only active row there (Battleground's /battleground prefix does
+      // not match it). Relationship Tribes stay inside Contacts.
+      { label: "Tribes", icon: icon("usersRound"), href: withOrg(`${BATTLEGROUND_ORIGIN}tribes`) },
       { kind: "section", label: "Research" },
       {
         label: "Polling",
@@ -4593,10 +4599,19 @@ var CORE_APP = "vrm";
 var DEFAULT_SIGN_OUT_URL = "/auth/signout";
 var POLITOGY_APPS = {
   vrm: { title: "Politogy VRM", origin: "https://app.politogyvrm.com", storagePrefix: "vrm" },
+  // Contacts, Forms, Surveys and CTAs are Relationship rows only (Specs/
+  // Left-Navigation §9.1; Campaign has none of them, §9.2), so they are
+  // PINNED to Relationship like the Dashboard below. Left unscoped, the mode
+  // switcher and rail colour took the user's last mode choice while the rows
+  // stayed Relationship: after picking Campaign, Contacts drew the red
+  // "Campaign mode" rail around Relationship rows, even after a reload
+  // (measured 2026-10-16 on We need Steve; §11.1 "the rail never shows a mix
+  // of two modes").
   contacts: {
     title: "Contacts",
     origin: "https://contacts.politogyvrm.com",
     storagePrefix: "contacts",
+    mode: "relationship",
     pageTitle: false
   },
   // 'title' for forms/surveys/polls/ctas for the same reason as petitions
@@ -4605,11 +4620,11 @@ var POLITOGY_APPS = {
   // page header falls back to the static registry title forever, so the
   // designed "<mode> mode" eyebrow + H2 + subtitle block never gets the real
   // per-page title an app passes it (UI-Platform → Page header).
-  forms: { title: "Forms", origin: "https://forms.politogyvrm.com", storagePrefix: "forms", grants: ["title"] },
-  surveys: { title: "Surveys", origin: "https://surveys.politogyvrm.com", storagePrefix: "surveys", grants: ["title"] },
+  forms: { title: "Forms", origin: "https://forms.politogyvrm.com", storagePrefix: "forms", mode: "relationship", grants: ["title"] },
+  surveys: { title: "Surveys", origin: "https://surveys.politogyvrm.com", storagePrefix: "surveys", mode: "relationship", grants: ["title"] },
   // Specs/Left-Navigation §9.2: Polling is a Campaign row (Research).
   polls: { title: "Polls", origin: "https://polls.politogyvrm.com", storagePrefix: "polls", mode: "campaign", grants: ["title"] },
-  ctas: { title: "CTAs", origin: "https://ctas.politogyvrm.com", storagePrefix: "ctas", grants: ["title"] },
+  ctas: { title: "CTAs", origin: "https://ctas.politogyvrm.com", storagePrefix: "ctas", mode: "relationship", grants: ["title"] },
   // V2 apps that replace retired app.politogyvrm.com pages (Reference/
   // UI-Platform v42 "Retirement of app.politogyvrm.com"). Dashboard is the
   // Relationship Dashboard, the Relationship Mode landing page, and nothing
@@ -4833,7 +4848,7 @@ function FrameBody({
   const coreOrgs = chrome?.orgs ?? [];
   const activeCoreOrg = coreOrgs.find((o) => o.id === chrome?.orgId) ?? null;
   const navDisplay = chrome?.navDisplay ?? "both";
-  const navMode = appMode ?? "relationship";
+  const navMode = appMode ?? (app !== CORE_APP && isStandardNavMode(mode.id) ? mode.id : "relationship");
   const activeOrgId = chrome?.orgId ?? null;
   const derivedNavItems = react.useMemo(
     () => standardPolitogyNav({
@@ -4876,7 +4891,7 @@ function FrameBody({
       {
         visible: bootVisible,
         bootProgress,
-        syntheticReady: (appReady ?? chromeResolved) && !chrome?.orgPending,
+        syntheticReady: (appReady ?? chromeResolved) && !chrome?.orgPending && (appMode !== void 0 || mode.resolved !== false),
         onExitComplete: () => setBootVisible(false)
       },
       bootGeneration
@@ -5596,6 +5611,7 @@ function useChromeMode(arg = {}) {
   const orgId = ctx?.orgId ?? null;
   const orgPending = ctx?.orgPending ?? false;
   const [entitled, setEntitled] = react.useState(null);
+  const [settledOrgId, setSettledOrgId] = react.useState(null);
   const [selectedModeId, setSelectedModeId] = react.useState(null);
   react.useEffect(() => {
     try {
@@ -5610,6 +5626,7 @@ function useChromeMode(arg = {}) {
     const bootMe = me;
     if (bootMe && bootMe.account === orgId && bootMe.modes !== void 0) {
       setEntitled(bootMe.modes ?? null);
+      setSettledOrgId(orgId);
       return;
     }
     let cancelled = false;
@@ -5617,7 +5634,9 @@ function useChromeMode(arg = {}) {
       if (cancelled) return;
       const modes = data?.modes ?? null;
       setEntitled(modes);
+      setSettledOrgId(orgId);
     }).catch(() => {
+      if (!cancelled) setSettledOrgId(orgId);
     });
     return () => {
       cancelled = true;
@@ -5631,6 +5650,9 @@ function useChromeMode(arg = {}) {
     id: current.id,
     label: current.label,
     icon: current.icon,
+    // A registry pin is final at once; otherwise the mode is final when the
+    // active org's Modes are in (or nothing can be read: no chrome or no org).
+    resolved: Boolean(pinned) || !dedupedFetch || !orgId || settledOrgId === orgId && !orgPending,
     // Left-Navigation §7 / Reference/UI-Platform: always the row of three icon
     // buttons. A mode the organization does not hold is shown dimmed and not
     // selectable, never hidden. Before entitlements land only the current mode