@the-portland-company/shell 0.76.18 → 0.78.0

package/CHANGELOG.md

@@ -1,3 +1,25 @@
+## 0.78.0
+
+Dashboard, Battleground and District Data are three features in two Modes; no Polls row in the Relationship left bar. Specs cited: Reference/UI-Platform "Dashboard, Battleground and District Data are three features in two Modes" (decided 2026-10-12, Ben), Specs/Left-Navigation §9.1 and §9.2.
+
+- **New registry rows `battleground` and `districts`**, both `mode: 'campaign'`, titles "Battleground" and "District Data". The Dashboard deployment must render those two pages with `app="battleground"` / `app="districts"`, never `app="dashboard"`: the `dashboard` row is unscoped, so it draws the Relationship rail, which is how both pages showed inside Relationship Mode with a "Dashboard · Battleground · District Data" strip above the header (measured 2026-10-12). Their hosts are decided (`battleground.politogyvrm.com`, `districts.politogyvrm.com`; UI-Platform, 2026-10-12) but not live, so both origins and both left-bar links stay on the dashboard host until each goes live.
+- **`dashboard` row unchanged** in behavior; its comment now says it is the Relationship Dashboard only.
+
+Polls: Spec cited: Specs/Left-Navigation §9.1 ("Polls is not a Relationship row. Polling is a Campaign Mode feature only").
+
+- **Relationship tree.** `standardPolitogyNav` no longer adds a `Polls` row to the Collect section (it was restored in 0.75.0). Collect is Calls to action, Forms, Surveys. Seen live on dashboard.politogyvrm.com in Relationship Mode on 2026-10-12.
+- **Campaign tree unchanged.** `Polling` stays under Research, and the `polls` registry entry is already `mode: 'campaign'`, so the Polls app keeps an active row.
+- **For consumers.** `hiddenItems: ['Polls']` is now a no-op and can be dropped.
+- Tests: `__tests__/standardNav.test.ts`.
+
+## 0.77.0
+
+No theme control in the account menu. Specs cited: Reference/UI-Platform "Theme — light only (Dark Mode retired)" and "There is no theme control … Apps must not render any theme control"; Reference/Global-Rules "Theming — Light Only".
+
+- **Breaking for the eye only.** `PolitogyAppFrame` no longer passes `theme` to the account menu, so the "Appearance" radio group (one option, "Light", since 0.73.0 made the theme light only) is gone from every app. `NavUserMenu.theme` stays optional for a caller that still passes it; nothing in the shell does.
+- `./theme-preference` and `useThemePreference` are unchanged: they still resolve every stored preference to light and keep the cross-app cookie contract for the apps that import them.
+- **Audit note (closeout 2026-10-12, item 1).** The "Known shell defect — dark theme restored in 0.68.0" paragraph in Reference/UI-Platform is stale: 0.73.0 (#116, 2026-10-06) removed dark rendering, `chrome.css` ships no `.dark` block (the remaining mentions are comments), and the pre-paint script hardcodes light. The runtime Brand token sheet (specs app, `lib/brand-authoring.ts`) still emits `.dark {}` blocks that nothing applies.
+
 ## 0.76.18
 
 Consolidates 0.76.16 and 0.76.17, neither of which reached npm (their publish gates failed). Specs cited: Global-Rules v38, UI-Platform v46, Specs/Left-Navigation (no Tribes row, §9.1), Specs/System-Communications §6.3 and §12.2 (Binding, 2026-10-03).

package/dist/app-chrome.cjs

@@ -487,92 +487,6 @@ function notificationsFeedToPayload(feed, orgId) {
     badge: feed.badge
   };
 }
-
-// src/theme-preference.ts
-var THEME_STORAGE_KEY = "politogy_theme";
-var THEME_COOKIE = "politogy_theme";
-var THEME_PENDING_COOKIE = "politogy_theme_pending";
-var VALID2 = ["light", "dark", "system"];
-function isThemePreference(v) {
-  return typeof v === "string" && VALID2.includes(v);
-}
-function readThemeCookie() {
-  if (typeof document === "undefined") return null;
-  try {
-    const m = document.cookie.match(
-      new RegExp(`(?:^|;\\s*)${THEME_COOKIE}=([^;]+)`)
-    );
-    const v = m ? decodeURIComponent(m[1]) : null;
-    return isThemePreference(v) ? v : null;
-  } catch {
-    return null;
-  }
-}
-function writeThemeCookie(pref) {
-  if (typeof document === "undefined" || typeof window === "undefined") return;
-  const host = window.location.hostname;
-  const onParentDomain = /(^|\.)politogyvrm\.com$/i.test(host);
-  const domainAttr = onParentDomain ? "; Domain=.politogyvrm.com" : "";
-  const secure = window.location.protocol === "https:" ? "; Secure" : "";
-  document.cookie = `${THEME_COOKIE}=${encodeURIComponent(
-    pref
-  )}; Path=/; Max-Age=31536000; SameSite=Lax${domainAttr}${secure}`;
-}
-function writeSharedCookie(name, value, maxAgeSeconds) {
-  if (typeof document === "undefined" || typeof window === "undefined") return;
-  const host = window.location.hostname;
-  const domainAttr = /(^|\.)politogyvrm\.com$/i.test(host) ? "; Domain=.politogyvrm.com" : "";
-  const secure = window.location.protocol === "https:" ? "; Secure" : "";
-  document.cookie = `${name}=${encodeURIComponent(
-    value
-  )}; Path=/; Max-Age=${maxAgeSeconds}; SameSite=Lax${domainAttr}${secure}`;
-}
-function markThemeChoicePending(pref) {
-  writeSharedCookie(THEME_PENDING_COOKIE, pref, 31536e3);
-}
-function readPendingThemeChoice() {
-  if (typeof document === "undefined") return null;
-  try {
-    const m = document.cookie.match(
-      new RegExp(`(?:^|;\\s*)${THEME_PENDING_COOKIE}=([^;]+)`)
-    );
-    const v = m ? decodeURIComponent(m[1]) : null;
-    return isThemePreference(v) ? v : null;
-  } catch {
-    return null;
-  }
-}
-function clearPendingThemeChoice() {
-  writeSharedCookie(THEME_PENDING_COOKIE, "", 0);
-}
-function resolveTheme(_pref) {
-  return "light";
-}
-function applyThemePreference(pref) {
-  if (typeof document === "undefined") return;
-  const resolved = resolveTheme();
-  const d = document.documentElement;
-  d.classList.toggle("dark", resolved === "dark");
-  try {
-    d.setAttribute("data-theme", resolved);
-    d.style.colorScheme = resolved;
-  } catch {
-  }
-}
-`(function(){try{
-var KEY=${JSON.stringify(THEME_STORAGE_KEY)};
-var VALID=["light","dark","system"];
-function fromCookie(){try{var m=document.cookie.match(/(?:^|;\\s*)${THEME_COOKIE}=([^;]+)/);return m?decodeURIComponent(m[1]):null;}catch(e){return null;}}
-var cookie=fromCookie();
-var ls=null;try{ls=localStorage.getItem(KEY);}catch(e){}
-var pref=cookie||ls||"system";
-if(VALID.indexOf(pref)===-1)pref="system";
-if(cookie&&cookie!==ls){try{localStorage.setItem(KEY,cookie);}catch(e){}}
-var dark=false;
-var d=document.documentElement;
-if(dark)d.classList.add("dark");else d.classList.remove("dark");
-try{d.setAttribute("data-theme",dark?"dark":"light");d.style.colorScheme=dark?"dark":"light";}catch(e){}
-}catch(e){}})();`;
 var CORE_APP_ORIGIN = "https://app.politogyvrm.com";
 var CORE_BILLING_PATH = "/organization-settings/subscription-billing/text-email";
 var CORE_BILLING_URL = `${CORE_APP_ORIGIN}${CORE_BILLING_PATH}`;
@@ -2201,102 +2115,6 @@ var NAV_DISPLAY_OPTIONS = [
   { value: "tabs", label: "Tabs Only" },
   { value: "both", label: "Both" }
 ];
-function useThemePreference() {
-  const ctx = react.useContext(NavChromeContext);
-  const fetchJson = ctx?.fetchJson ?? null;
-  const [value, setValueState] = react.useState("system");
-  const reconciled = react.useRef(false);
-  react.useEffect(() => {
-    const cookie = readThemeCookie();
-    let ls = null;
-    try {
-      ls = localStorage.getItem(THEME_STORAGE_KEY);
-    } catch {
-    }
-    const pref = cookie ?? (isThemePreference(ls) ? ls : null) ?? "system";
-    setValueState(pref);
-    applyThemePreference();
-  }, []);
-  const meCtx = react.useContext(NavChromeContext);
-  react.useEffect(() => {
-    if (reconciled.current) return;
-    const pending = readPendingThemeChoice();
-    if (pending) {
-      if (meCtx?.me) reconciled.current = true;
-      setValueState(pending);
-      applyThemePreference();
-      writeThemeCookie(pending);
-      try {
-        localStorage.setItem(THEME_STORAGE_KEY, pending);
-      } catch {
-      }
-      if (!meCtx?.me) return;
-      fetchJson?.("me/preferences", {
-        method: "PATCH",
-        headers: { "Content-Type": "application/json" },
-        body: JSON.stringify({ themePreference: pending })
-      }).then(() => clearPendingThemeChoice()).catch(() => {
-      });
-      return;
-    }
-    const pref = meCtx?.me?.themePreference;
-    if (isThemePreference(pref)) {
-      reconciled.current = true;
-      setValueState(pref);
-      applyThemePreference();
-      writeThemeCookie(pref);
-      try {
-        localStorage.setItem(THEME_STORAGE_KEY, pref);
-      } catch {
-      }
-    }
-  }, [meCtx?.me]);
-  react.useEffect(() => {
-    const onStorage = (e) => {
-      if (e.key === THEME_STORAGE_KEY && isThemePreference(e.newValue)) {
-        setValueState(e.newValue);
-        applyThemePreference(e.newValue);
-      }
-    };
-    const onWake = () => {
-      const cookie = readThemeCookie();
-      if (cookie) {
-        setValueState((prev) => {
-          if (cookie !== prev) applyThemePreference();
-          return cookie;
-        });
-      }
-    };
-    window.addEventListener("storage", onStorage);
-    window.addEventListener("focus", onWake);
-    document.addEventListener("visibilitychange", onWake);
-    return () => {
-      window.removeEventListener("storage", onStorage);
-      window.removeEventListener("focus", onWake);
-      document.removeEventListener("visibilitychange", onWake);
-    };
-  }, []);
-  const setValue = react.useCallback(
-    (next) => {
-      setValueState(next);
-      applyThemePreference();
-      writeThemeCookie(next);
-      try {
-        localStorage.setItem(THEME_STORAGE_KEY, next);
-      } catch {
-      }
-      markThemeChoicePending(next);
-      fetchJson?.("me/preferences", {
-        method: "PATCH",
-        headers: { "Content-Type": "application/json" },
-        body: JSON.stringify({ themePreference: next })
-      }).then(() => clearPendingThemeChoice()).catch(() => {
-      });
-    },
-    [fetchJson]
-  );
-  return { value, setValue };
-}
 var standardNavIcons = {
   home: lu.LuHouse,
   users: lu.LuUsers,
@@ -2543,16 +2361,9 @@ function standardPolitogyNav(opts) {
         href: withOrg("https://surveys.politogyvrm.com/surveys"),
         children: APP_SURVEYS_CHILDREN.map((c) => ({ label: c.label, icon: icon(c.icon), href: withOrg(c.href) }))
       },
-      // Polls (polls.politogyvrm.com) — kept in the default Collect section;
-      // apps that want it hidden pass `hiddenItems: ['Polls']`. Regression:
-      // dropped entirely in 03c4dc2 when app.politogyvrm.com retired; restored
-      // here (this row is independent of the retired app).
-      {
-        label: "Polls",
-        icon: icon("chartNoAxes"),
-        href: withOrg(POLLS_ORIGIN),
-        children: APP_POLLS_CHILDREN.map((c) => ({ label: c.label, icon: icon(c.icon), href: withOrg(c.href) }))
-      },
+      // No Polls row here: Polling is a Campaign Mode feature only
+      // (Specs/Left-Navigation §9.1 "Polls is not a Relationship row"). Its
+      // row is "Polling" under Research in the Campaign tree below.
       ...accountRows()
     ];
   };
@@ -2566,11 +2377,14 @@ function standardPolitogyNav(opts) {
       // Battleground is the Campaign landing page; there is no Campaign
       // Dashboard row, and Voter Contact and Tribes have no row.
       { kind: "section", label: "Race data" },
-      // Battleground moved to the Dashboard app (dashboard.politogyvrm.com)
-      // until a dedicated Battleground host is decided (UI-Platform route table).
+      // Battleground is its own Campaign Mode app (registry key
+      // `battleground`), not part of the Dashboard. It is served from the
+      // dashboard deployment only until battleground.politogyvrm.com is live
+      // (Reference/UI-Platform, decided 2026-10-12).
       { label: "Battleground", icon: icon("crosshair"), href: withOrg(`${DASHBOARD_ORIGIN}battleground`) },
-      // District data moved to the Dashboard app (dashboard.politogyvrm.com)
-      // per Reference/UI-Platform v44.
+      // District Data is its own Campaign Mode app (registry key
+      // `districts`); served from the dashboard deployment until
+      // districts.politogyvrm.com is live.
       { label: "District data", icon: icon("landmark"), href: withOrg(`${DASHBOARD_ORIGIN}districts`) },
       { kind: "section", label: "Research" },
       {
@@ -4731,11 +4545,23 @@ var POLITOGY_APPS = {
   polls: { title: "Polls", origin: "https://polls.politogyvrm.com", storagePrefix: "polls", mode: "campaign", grants: ["title"] },
   ctas: { title: "CTAs", origin: "https://ctas.politogyvrm.com", storagePrefix: "ctas", grants: ["title"] },
   // V2 apps that replace retired app.politogyvrm.com pages (Reference/
-  // UI-Platform v42 "Retirement of app.politogyvrm.com"). Dashboard hosts the
-  // Relationship Dashboard + Campaign Battleground/District data/Campaigns
-  // (Specs/Relationship-Dashboard); Settings hosts org settings & billing
-  // (Specs/Organization-Settings).
+  // UI-Platform v42 "Retirement of app.politogyvrm.com"). Dashboard is the
+  // Relationship Dashboard, the Relationship Mode landing page, and nothing
+  // else (Specs/Relationship-Dashboard §1A "Relationship Mode only"); Settings
+  // hosts org settings & billing (Specs/Organization-Settings).
   dashboard: { title: "Dashboard", origin: "https://dashboard.politogyvrm.com", storagePrefix: "dashboard" },
+  // Battleground (the Campaign Mode landing page) and District Data are
+  // Campaign Mode features, each its own app (Specs/Left-Navigation §9.2;
+  // Reference/UI-Platform, decided 2026-10-12). They are never rendered with
+  // `app="dashboard"`: that frame is the Relationship rail, which is how they
+  // came to show inside Relationship Mode. Their hosts are decided
+  // (UI-Platform, 2026-10-12): battleground.politogyvrm.com and
+  // districts.politogyvrm.com. Neither is live yet, so the pages are still
+  // served from the dashboard deployment and the origin below is that host.
+  // When a host goes live, change its origin here and its row's href in
+  // standardNav in the same release.
+  battleground: { title: "Battleground", origin: "https://dashboard.politogyvrm.com", storagePrefix: "battleground", mode: "campaign" },
+  districts: { title: "District Data", origin: "https://dashboard.politogyvrm.com", storagePrefix: "districts", mode: "campaign" },
   settings: { title: "Settings", origin: "https://settings.politogyvrm.com", storagePrefix: "settings" },
   petitions: {
     title: "Petitions",
@@ -5597,7 +5423,6 @@ function useChromeUserMenu({
   email
 }) {
   const state = useChromeState();
-  const theme = useThemePreference();
   const activeOrg = state?.orgs.find((o) => o.id === state.orgId) ?? null;
   const orgSuffix = activeOrg ? `?org=${activeOrg.id}` : "";
   const coreBase = getCoreBaseUrl();
@@ -5608,7 +5433,9 @@ function useChromeUserMenu({
     roles: (state?.orgs ?? []).filter((o) => o.rawRole || o.role).map((o) => ({ role: o.rawRole ?? o.role, orgName: o.name })),
     accounts: [{ id: userId, name: userName, email, avatarUrl: null, active: true }],
     addAccountHref: `${coreBase}/my-profile#accounts`,
-    theme: { value: theme.value, onChange: theme.setValue },
+    // No theme control: the product is light only (Reference/UI-Platform
+    // "Theme — light only"; shell 0.73.0 stopped applying dark). The account
+    // menu rendered an "Appearance" radio with one option until 0.77.0.
     navDisplay: state ? { value: state.navDisplay, onChange: state.setNavDisplay } : void 0
   };
 }