@the-portland-company/shell 0.47.0-rc.2 → 0.47.0

package/CHANGELOG.md

@@ -64,9 +64,25 @@ Dark mode keeps the platform's neutral ramp. The Brand sheet resets the Mode
 SURFACES to the guaranteed-invalid value under `.dark` so they fall through to
 the neutrals; only the accent, a foreground colour, carries over.
 
-Active sub-rows also gain a 3px left rail drawn from `--nav-row-active-rail`,
-which resolves `transparent` unless the Mode declared a chrome group — so for
-every other app the span renders invisible and out of flow.
+Active sub-rows also gain a 3px left rail drawn from
+`var(--mode-accent, transparent)` — invisible and out of flow for any app whose
+Mode declares no chrome group.
+
+**Where Mode SURFACES are read matters, and the rule is not obvious.** They are
+resolved at the point of use with the pre-0.47 value as an inline fallback:
+
+```
+bg-[color:var(--mode-accent-surface,var(--panel-elevated))]
+```
+
+Not through an alias declared in the `[data-politogy-mode]` block — that block
+does not match an app which is not mode-scoped, so the alias would be unset and
+a bare `var()` is invalid at computed-value time, dropping the property to its
+initial value. And not through a `:root` alias either — `.dark` is a separate
+top-level selector, so a `:root` alias substitutes the LIGHT value and inherits
+it into dark. Point of use is the only placement correct in both themes, scoped
+and unscoped. Two tests enforce it; both mistakes were made and caught during
+the release candidates.
 
 Needs the matching Brand API release (`tokens.modes.<id>.chrome`).
 
@@ -108,6 +124,19 @@ a silent effect.
 
 A grant is for a fact only the app HAS, never for a look.
 
+### Added — the brand lockup follows the Mode
+
+`brandLogoSrc` became core-only in 0.43, so every mode-scoped app rendered the
+Relationship lockup — a red wordmark on a purple `vrm` badge — whatever Mode it
+was scoped to. Petition Mode shipped a green Petition lockup in V1 and lost it in
+that migration.
+
+Resolved from the registry by Mode, like the accent:
+`MODE_BRAND_LOGOS = { petition: '/brand/logos/petition-mode-logo.svg' }`. Only
+Modes with a shipped lockup are listed; everything else keeps today's default.
+The path is app-relative, so add the asset to the app's `public/` before adding
+a Mode here.
+
 ### Changed — prereleases publish under the `next` dist-tag
 
 `npm publish` tags `latest` whatever the semver, so an rc would silently become

package/dist/app-chrome.cjs

@@ -2075,7 +2075,7 @@ function NavRow({
 }) {
   const Icon = item.icon;
   const isSub = variant === "sub";
-  const activeClasses = isSub ? "bg-[color:var(--nav-row-active-surface)] text-[color:var(--color-accent)] shadow-sm" : "bg-[color:var(--color-accent)] text-white shadow-sm";
+  const activeClasses = isSub ? "bg-[color:var(--mode-accent-surface,var(--panel-elevated))] text-[color:var(--color-accent)] shadow-sm" : "bg-[color:var(--color-accent)] text-white shadow-sm";
   const wrapperClasses = [
     "group relative block overflow-hidden rounded-md transition",
     active ? activeClasses : "text-[color:var(--muted)] hover:text-white"
@@ -2092,16 +2092,16 @@ function NavRow({
         style: { background: NAV_HOVER_GRADIENT }
       }
     ) : (
-      // Active-row rail, in the Mode's accent. `--nav-row-active-rail`
-      // resolves `transparent` unless the Mode declared a chrome group, so
-      // for every app without one this span is present but invisible and
-      // nothing moves (it is absolutely positioned and out of flow).
+      // Active-row rail, in the Mode's accent. `--mode-accent` is only set by
+      // a declared Mode chrome group, and the inline `transparent` fallback
+      // is what every other app gets — so this span is present but invisible
+      // there, and being absolutely positioned it moves nothing.
       /* @__PURE__ */ jsxRuntime.jsx(
         "span",
         {
           "aria-hidden": "true",
           className: "pointer-events-none absolute inset-y-0 left-0 w-[3px] rounded-l-md",
-          style: { background: "var(--nav-row-active-rail)" }
+          style: { background: "var(--mode-accent, transparent)" }
         }
       )
     ),