@the-open-engine/zeroshot 6.38.1 → 6.39.1

package/src/quality-gates.js

@@ -1,148 +1,88 @@
-const { readRepoSettings } = require('../lib/repo-settings');
-
-function hasOwn(value, key) {
-  return Object.prototype.hasOwnProperty.call(value || {}, key);
-}
-
-function hasDefinedOwn(value, key) {
-  return hasOwn(value, key) && value[key] !== undefined;
-}
-
+"use strict";
+const repoSettingsAccess = require("./repo-settings-access");
+const { isRecord, propertyValue, readRepoSettingsValue, selectOwnProperty } = repoSettingsAccess;
 function getGateId(gate) {
-  if (typeof gate.id === 'string' && gate.id.trim()) {
-    return gate.id.trim();
-  }
-
-  if (typeof gate.name === 'string' && gate.name.trim()) {
-    return gate.name.trim();
-  }
-
-  return null;
+    if (typeof gate.id === 'string' && gate.id.trim()) {
+        return gate.id.trim();
+    }
+    if (typeof gate.name === 'string' && gate.name.trim()) {
+        return gate.name.trim();
+    }
+    return null;
 }
-
 function normalizeStringGate(gate) {
-  const id = gate.trim();
-  return id ? { id } : null;
+    const id = gate.trim();
+    return id ? { id } : null;
 }
-
 function setOptionalString(target, source, key) {
-  if (typeof source[key] === 'string' && source[key].trim()) {
-    target[key] = source[key].trim();
-  }
+    const value = source[key];
+    if (typeof value === 'string' && value.trim()) {
+        target[key] = value.trim();
+    }
 }
-
 function normalizeObjectGate(gate) {
-  if (!gate || typeof gate !== 'object') {
-    return null;
-  }
-
-  const id = getGateId(gate);
-  if (!id) {
-    return null;
-  }
-
-  const normalized = { id };
-  setOptionalString(normalized, gate, 'scope');
-  setOptionalString(normalized, gate, 'description');
-  setOptionalString(normalized, gate, 'command');
-  setOptionalString(normalized, gate, 'profile');
-  setOptionalString(normalized, gate, 'proofProfile');
-  if (gate.commandProof === true) {
-    normalized.commandProof = true;
-  }
-  return normalized;
+    if (!isRecord(gate)) {
+        return null;
+    }
+    const id = getGateId(gate);
+    if (!id) {
+        return null;
+    }
+    const normalized = { id };
+    setOptionalString(normalized, gate, 'scope');
+    setOptionalString(normalized, gate, 'description');
+    setOptionalString(normalized, gate, 'command');
+    setOptionalString(normalized, gate, 'profile');
+    setOptionalString(normalized, gate, 'proofProfile');
+    if (gate.commandProof === true) {
+        normalized.commandProof = true;
+    }
+    return normalized;
+}
+function isRequiredQualityGate(gate) {
+    return gate !== null;
 }
-
 function normalizeRequiredQualityGates(value) {
-  if (!Array.isArray(value)) {
-    return [];
-  }
-
-  return value
-    .map((gate) => {
-      if (typeof gate === 'string') {
-        return normalizeStringGate(gate);
-      }
-      return normalizeObjectGate(gate);
+    if (!Array.isArray(value)) {
+        return [];
+    }
+    return value
+        .map((gate) => {
+        if (typeof gate === 'string') {
+            return normalizeStringGate(gate);
+        }
+        return normalizeObjectGate(gate);
     })
-    .filter(Boolean);
+        .filter(isRequiredQualityGate);
 }
-
 function getRequiredQualityGateSource(options, repoSettings) {
-  if (hasDefinedOwn(options, 'requiredQualityGates')) {
-    return options.requiredQualityGates;
-  }
-
-  if (
-    options.ship &&
-    typeof options.ship === 'object' &&
-    hasDefinedOwn(options.ship, 'requiredQualityGates')
-  ) {
-    return options.ship.requiredQualityGates;
-  }
-
-  const settingsShip = repoSettings?.ship;
-  if (
-    settingsShip &&
-    typeof settingsShip === 'object' &&
-    hasOwn(settingsShip, 'requiredQualityGates')
-  ) {
-    return settingsShip.requiredQualityGates;
-  }
-
-  if (hasOwn(repoSettings, 'requiredQualityGates')) {
-    return repoSettings.requiredQualityGates;
-  }
-
-  return [];
+    const explicitSource = selectOwnProperty('requiredQualityGates', [options, propertyValue(options, 'ship')], { skipUndefined: true });
+    if (explicitSource !== undefined) {
+        return explicitSource;
+    }
+    const repoSource = selectOwnProperty('requiredQualityGates', [
+        propertyValue(repoSettings, 'ship'),
+        repoSettings,
+    ]);
+    return repoSource === undefined ? [] : repoSource;
 }
-
 function resolveRequiredQualityGates(options = {}) {
-  const repoSettingsResult = readRepoSettings(options.cwd || process.cwd());
-  const repoSettings = repoSettingsResult.settings || {};
-  const source = getRequiredQualityGateSource(options, repoSettings);
-  return normalizeRequiredQualityGates(source);
+    const repoSettings = readRepoSettingsValue(options.cwd || process.cwd());
+    const source = getRequiredQualityGateSource(options, repoSettings);
+    return normalizeRequiredQualityGates(source);
 }
-
 function getClusterRequiredQualityGateSource(config, options) {
-  if (hasDefinedOwn(options, 'requiredQualityGates')) {
-    return options.requiredQualityGates;
-  }
-
-  if (
-    options.ship &&
-    typeof options.ship === 'object' &&
-    hasDefinedOwn(options.ship, 'requiredQualityGates')
-  ) {
-    return options.ship.requiredQualityGates;
-  }
-
-  if (
-    config?.ship &&
-    typeof config.ship === 'object' &&
-    hasDefinedOwn(config.ship, 'requiredQualityGates')
-  ) {
-    return config.ship.requiredQualityGates;
-  }
-
-  if (hasDefinedOwn(config, 'requiredQualityGates')) {
-    return config.requiredQualityGates;
-  }
-
-  return undefined;
+    return selectOwnProperty('requiredQualityGates', [options, propertyValue(options, 'ship'), propertyValue(config, 'ship'), config], { skipUndefined: true });
 }
-
 function resolveClusterRequiredQualityGates(config = {}, options = {}) {
-  const configuredSource = getClusterRequiredQualityGateSource(config, options);
-  if (configuredSource !== undefined) {
-    return normalizeRequiredQualityGates(configuredSource);
-  }
-
-  return resolveRequiredQualityGates({ ...options, cwd: options.cwd || process.cwd() });
+    const configuredSource = getClusterRequiredQualityGateSource(config, options);
+    if (configuredSource !== undefined) {
+        return normalizeRequiredQualityGates(configuredSource);
+    }
+    return resolveRequiredQualityGates({ ...options, cwd: options.cwd || process.cwd() });
 }
-
 module.exports = {
-  normalizeRequiredQualityGates,
-  resolveRequiredQualityGates,
-  resolveClusterRequiredQualityGates,
+    normalizeRequiredQualityGates,
+    resolveRequiredQualityGates,
+    resolveClusterRequiredQualityGates,
 };

package/src/quality-gates.ts

@@ -0,0 +1,149 @@
+import repoSettingsAccess = require('./repo-settings-access');
+
+type StringGateField = 'scope' | 'description' | 'command' | 'profile' | 'proofProfile';
+
+interface RequiredQualityGate {
+  id: string;
+  scope?: string;
+  description?: string;
+  command?: string;
+  profile?: string;
+  proofProfile?: string;
+  commandProof?: true;
+}
+
+interface QualityGateOptions {
+  cwd?: string;
+  requiredQualityGates?: unknown;
+  ship?: unknown;
+  [key: string]: unknown;
+}
+
+interface QualityGateConfig {
+  requiredQualityGates?: unknown;
+  ship?: unknown;
+  [key: string]: unknown;
+}
+
+const { isRecord, propertyValue, readRepoSettingsValue, selectOwnProperty } = repoSettingsAccess;
+
+function getGateId(gate: Record<string, unknown>): string | null {
+  if (typeof gate.id === 'string' && gate.id.trim()) {
+    return gate.id.trim();
+  }
+
+  if (typeof gate.name === 'string' && gate.name.trim()) {
+    return gate.name.trim();
+  }
+
+  return null;
+}
+
+function normalizeStringGate(gate: string): RequiredQualityGate | null {
+  const id = gate.trim();
+  return id ? { id } : null;
+}
+
+function setOptionalString(
+  target: RequiredQualityGate,
+  source: Record<string, unknown>,
+  key: StringGateField
+): void {
+  const value = source[key];
+  if (typeof value === 'string' && value.trim()) {
+    target[key] = value.trim();
+  }
+}
+
+function normalizeObjectGate(gate: unknown): RequiredQualityGate | null {
+  if (!isRecord(gate)) {
+    return null;
+  }
+
+  const id = getGateId(gate);
+  if (!id) {
+    return null;
+  }
+
+  const normalized: RequiredQualityGate = { id };
+  setOptionalString(normalized, gate, 'scope');
+  setOptionalString(normalized, gate, 'description');
+  setOptionalString(normalized, gate, 'command');
+  setOptionalString(normalized, gate, 'profile');
+  setOptionalString(normalized, gate, 'proofProfile');
+  if (gate.commandProof === true) {
+    normalized.commandProof = true;
+  }
+  return normalized;
+}
+
+function isRequiredQualityGate(gate: RequiredQualityGate | null): gate is RequiredQualityGate {
+  return gate !== null;
+}
+
+function normalizeRequiredQualityGates(value: unknown): RequiredQualityGate[] {
+  if (!Array.isArray(value)) {
+    return [];
+  }
+
+  return value
+    .map((gate) => {
+      if (typeof gate === 'string') {
+        return normalizeStringGate(gate);
+      }
+      return normalizeObjectGate(gate);
+    })
+    .filter(isRequiredQualityGate);
+}
+
+function getRequiredQualityGateSource(options: QualityGateOptions, repoSettings: unknown): unknown {
+  const explicitSource = selectOwnProperty(
+    'requiredQualityGates',
+    [options, propertyValue(options, 'ship')],
+    { skipUndefined: true }
+  );
+  if (explicitSource !== undefined) {
+    return explicitSource;
+  }
+
+  const repoSource = selectOwnProperty('requiredQualityGates', [
+    propertyValue(repoSettings, 'ship'),
+    repoSettings,
+  ]);
+  return repoSource === undefined ? [] : repoSource;
+}
+
+function resolveRequiredQualityGates(options: QualityGateOptions = {}): RequiredQualityGate[] {
+  const repoSettings = readRepoSettingsValue(options.cwd || process.cwd());
+  const source = getRequiredQualityGateSource(options, repoSettings);
+  return normalizeRequiredQualityGates(source);
+}
+
+function getClusterRequiredQualityGateSource(
+  config: QualityGateConfig,
+  options: QualityGateOptions
+): unknown {
+  return selectOwnProperty(
+    'requiredQualityGates',
+    [options, propertyValue(options, 'ship'), propertyValue(config, 'ship'), config],
+    { skipUndefined: true }
+  );
+}
+
+function resolveClusterRequiredQualityGates(
+  config: QualityGateConfig = {},
+  options: QualityGateOptions = {}
+): RequiredQualityGate[] {
+  const configuredSource = getClusterRequiredQualityGateSource(config, options);
+  if (configuredSource !== undefined) {
+    return normalizeRequiredQualityGates(configuredSource);
+  }
+
+  return resolveRequiredQualityGates({ ...options, cwd: options.cwd || process.cwd() });
+}
+
+export = {
+  normalizeRequiredQualityGates,
+  resolveRequiredQualityGates,
+  resolveClusterRequiredQualityGates,
+};

package/src/repo-settings-access.js

@@ -0,0 +1,40 @@
+"use strict";
+function isRepoSettingsModule(value) {
+    return (typeof value === 'object' &&
+        value !== null &&
+        'readRepoSettings' in value &&
+        typeof value.readRepoSettings === 'function');
+}
+const repoSettingsModule = require('../lib/repo-settings');
+if (!isRepoSettingsModule(repoSettingsModule)) {
+    throw new TypeError('repo-settings must export readRepoSettings');
+}
+const readRepoSettings = repoSettingsModule.readRepoSettings;
+function isRecord(value) {
+    return typeof value === 'object' && value !== null;
+}
+function propertyValue(value, key) {
+    return isRecord(value) ? value[key] : undefined;
+}
+function selectOwnProperty(key, candidates, options = {}) {
+    for (const candidate of candidates) {
+        if (!Object.prototype.hasOwnProperty.call(candidate || {}, key)) {
+            continue;
+        }
+        const value = propertyValue(candidate, key);
+        if (options.skipUndefined && value === undefined) {
+            continue;
+        }
+        return value;
+    }
+    return undefined;
+}
+function readRepoSettingsValue(startDir) {
+    return readRepoSettings(startDir).settings || {};
+}
+module.exports = {
+    isRecord,
+    propertyValue,
+    readRepoSettingsValue,
+    selectOwnProperty,
+};

package/src/repo-settings-access.ts

@@ -0,0 +1,64 @@
+interface RepoSettingsResult {
+  settings?: unknown;
+}
+
+interface RepoSettingsModule {
+  readRepoSettings(startDir: string): RepoSettingsResult;
+}
+
+interface PropertySelectionOptions {
+  skipUndefined?: boolean;
+}
+
+function isRepoSettingsModule(value: unknown): value is RepoSettingsModule {
+  return (
+    typeof value === 'object' &&
+    value !== null &&
+    'readRepoSettings' in value &&
+    typeof value.readRepoSettings === 'function'
+  );
+}
+
+const repoSettingsModule: unknown = require('../lib/repo-settings');
+if (!isRepoSettingsModule(repoSettingsModule)) {
+  throw new TypeError('repo-settings must export readRepoSettings');
+}
+const readRepoSettings = repoSettingsModule.readRepoSettings;
+
+function isRecord(value: unknown): value is Record<string, unknown> {
+  return typeof value === 'object' && value !== null;
+}
+
+function propertyValue(value: unknown, key: string): unknown {
+  return isRecord(value) ? value[key] : undefined;
+}
+
+function selectOwnProperty(
+  key: string,
+  candidates: readonly unknown[],
+  options: PropertySelectionOptions = {}
+): unknown {
+  for (const candidate of candidates) {
+    if (!Object.prototype.hasOwnProperty.call(candidate || {}, key)) {
+      continue;
+    }
+
+    const value = propertyValue(candidate, key);
+    if (options.skipUndefined && value === undefined) {
+      continue;
+    }
+    return value;
+  }
+  return undefined;
+}
+
+function readRepoSettingsValue(startDir: string): unknown {
+  return readRepoSettings(startDir).settings || {};
+}
+
+export = {
+  isRecord,
+  propertyValue,
+  readRepoSettingsValue,
+  selectOwnProperty,
+};