@thatopen/components 2.4.3 → 2.4.4

package/dist/core/Components/index.d.ts

@@ -6,7 +6,7 @@ export declare class Components implements Disposable {
     /**
      * The version of the @thatopen/components library.
      */
-    static readonly release = "2.4.3";
+    static readonly release = "2.4.4";
     /** {@link Disposable.onDisposed} */
     readonly onDisposed: Event<void>;
     /**

package/dist/ifc/IfcPropertiesManager/index.d.ts

@@ -284,6 +284,6 @@ export declare class IfcPropertiesManager extends Component implements Disposabl
         handle: WEBIFC.Handle<unknown>;
     }>;
     registerChange(model: FragmentsGroup, ...expressID: number[]): void;
-    private newSingleProperty;
+    newSingleProperty(model: FragmentsGroup, type: string, name: string, value: string | number | boolean): Promise<WEBIFC.IFC4.IfcPropertySingleValue | WEBIFC.IFC2X3.IfcPropertySingleValue | WEBIFC.IFC4X3.IfcPropertySingleValue>;
 }
 export * from "./src";

package/dist/index.cjs

@@ -6312,7 +6312,7 @@ const _Components = class _Components {
 /**
  * The version of the @thatopen/components library.
  */
-__publicField(_Components, "release", "2.4.3");
+__publicField(_Components, "release", "2.4.4");
 let Components = _Components;
 class SimpleWorld extends Base {
   constructor() {
@@ -21106,10 +21106,8 @@ function readDocType$1(xmlData, i) {
           i += 8;
         else if (hasBody && isNotation(xmlData, i))
           i += 9;
-        else if (isComment)
-          comment = true;
         else
-          throw new Error("Invalid DOCTYPE");
+          comment = true;
         angleBracketsCount++;
         exp = "";
       } else if (xmlData[i] === ">") {
@@ -21153,11 +21151,6 @@ function readEntityExp(xmlData, i) {
   }
   return [entityName2, val2, i];
 }
-function isComment(xmlData, i) {
-  if (xmlData[i + 1] === "!" && xmlData[i + 2] === "-" && xmlData[i + 3] === "-")
-    return true;
-  return false;
-}
 function isEntity(xmlData, i) {
   if (xmlData[i + 1] === "!" && xmlData[i + 2] === "E" && xmlData[i + 3] === "N" && xmlData[i + 4] === "T" && xmlData[i + 5] === "I" && xmlData[i + 6] === "T" && xmlData[i + 7] === "Y")
     return true;
@@ -23198,7 +23191,7 @@ ${users}
       Comment: CommentText,
       Viewpoint: Viewpoint2
     } = markupComment;
-    if (!(Guid && CommentDate && Author && (Comment || Viewpoint2)))
+    if (!(Guid && CommentDate && Author && Comment))
       return null;
     const viewpoints = this.components.get(Viewpoints);
     const comment = new Comment(this.components, CommentText ?? "");
@@ -27248,10 +27241,10 @@ class IDSFacet {
         let minPass = true;
         let maxPass = true;
         if (min !== void 0) {
-          minPass = minInclusive ? value <= min : value < min;
+          minPass = minInclusive ? value >= min : value > min;
         }
         if (max !== void 0) {
-          maxPass = maxInclusive ? value >= max : value > max;
+          maxPass = maxInclusive ? value <= max : value < max;
         }
         pass = minPass && maxPass;
       }
@@ -27976,16 +27969,15 @@ class IDSProperty extends IDSFacet {
       this.testResult.push(result2);
       const sets = await this.getPsets(model, expressID);
       const matchingSets = sets.filter((set) => {
-        var _a2;
         const result3 = this.evalRequirement(
-          ((_a2 = set.Name) == null ? void 0 : _a2.value) ?? null,
+          set.Name ?? null,
           this.propertySet,
           "PropertySet"
         );
         if (!result3)
           return false;
         checks.push({
-          currentValue: set.Name.value,
+          currentValue: set.Name,
           parameter: "PropertySet",
           pass: true,
           requiredValue: this.propertySet.parameter
@@ -28002,8 +27994,7 @@ class IDSProperty extends IDSFacet {
         continue;
       }
       for (const set of matchingSets) {
-        const itemsAttrName = this.getItemsAttrName(set.type);
-        if (!itemsAttrName) {
+        if (!("Properties" in set)) {
           checks.push({
             currentValue: null,
             parameter: "BaseName",
@@ -28012,7 +28003,7 @@ class IDSProperty extends IDSFacet {
           });
           continue;
         }
-        const items = set[itemsAttrName];
+        const items = set.Properties;
         const matchingItems = items.filter((item) => {
           var _a2;
           if (this._unsupportedTypes.includes(item.type)) {
@@ -28067,18 +28058,22 @@ class IDSProperty extends IDSFacet {
       (name) => name.endsWith("Value") || name.endsWith("Values")
     );
   }
-  async getPsetProps(model, attrs, propsListName) {
-    const attrsClone = structuredClone(attrs);
+  async simplifyPset(model, attrs, propsListName) {
+    var _a;
     const props = [];
-    const list = attrsClone[propsListName];
+    const list = attrs[propsListName];
     if (!list)
-      return props;
+      return attrs;
     for (const { value } of list) {
       const propAttrs = await model.getProperties(value);
       if (propAttrs)
         props.push(propAttrs);
     }
-    attrsClone[propsListName] = props;
+    const attrsClone = {
+      Name: (_a = attrs.Name) == null ? void 0 : _a.value,
+      Properties: props,
+      type: attrs.type
+    };
     return attrsClone;
   }
   async getTypePsets(model, expressID) {
@@ -28096,13 +28091,14 @@ class IDSProperty extends IDSFacet {
       if (!(psetAttrs && "HasProperties" in psetAttrs && Array.isArray(psetAttrs.HasProperties))) {
         continue;
       }
-      const pset = await this.getPsetProps(model, psetAttrs, "HasProperties");
+      const pset = await this.simplifyPset(model, psetAttrs, "HasProperties");
       sets.push(pset);
     }
     return sets;
   }
   async getPsets(model, expressID) {
-    const sets = await this.getTypePsets(model, expressID);
+    var _a;
+    const typePsets = await this.getTypePsets(model, expressID);
     const indexer = this.components.get(IfcRelationsIndexer);
     const definitions = indexer.getEntityRelations(
       model,
@@ -28110,7 +28106,8 @@ class IDSProperty extends IDSFacet {
       "IsDefinedBy"
     );
     if (!definitions)
-      return sets;
+      return typePsets;
+    const sets = [];
     for (const definitionID of definitions) {
       const attrs = await model.getProperties(definitionID);
       if (!attrs)
@@ -28118,8 +28115,25 @@ class IDSProperty extends IDSFacet {
       const propsListName = this.getItemsAttrName(attrs.type);
       if (!propsListName)
         continue;
-      const pset = await this.getPsetProps(model, attrs, propsListName);
-      sets.push(pset);
+      const occurencePset = await this.simplifyPset(
+        model,
+        attrs,
+        propsListName
+      );
+      const typePset = typePsets.find(
+        ({ Name }) => Name === occurencePset.Name
+      );
+      if (typePset) {
+        for (const prop of typePset.Properties) {
+          const name = (_a = prop.Name) == null ? void 0 : _a.value;
+          const existingProp = occurencePset.Properties.find(
+            ({ Name }) => Name.value === name
+          );
+          if (!existingProp)
+            occurencePset.Properties.push(prop);
+        }
+      }
+      sets.push(occurencePset);
     }
     return sets;
   }