@thanh01.pmt/curriculum-kit 1.4.48 → 1.4.50

package/dist/index.cjs

@@ -4875,9 +4875,9 @@ Evaluate the candidate artifact across these 6 dimensions:
    - 0 pts: Missing critical sections.
 
 5. **Technical & Conceptual Accuracy (15 pts):**
-   - 15 pts: Code snippets, logic flows, architectural descriptions, and Mermaid diagrams are conceptually sound and valid. If \`canonicalExposition\` or \`[KNOWLEDGE_EXPOSITION]\` is provided, content strictly adheres to canonical concepts without contradicting definitions or examples.
+   - 15 pts: Code snippets, logic flows, architectural descriptions, and Mermaid diagrams are conceptually sound and valid. Every code identifier uses the REAL standard-library/API spelling of the declared stack (grounded in REFERENCE_PACK / canonical LESSON) \u2014 internal consistency with a glossary term name is NOT evidence of correctness. If \`canonicalExposition\` or \`[KNOWLEDGE_EXPOSITION]\` is provided, content strictly adheres to canonical concepts without contradicting definitions or examples.
    - 8 pts: Minor syntax inaccuracies or unidiomatic code that does not break core concepts.
-   - 0 pts: Severe technical hallucinations, broken logic, invalid diagrams, or direct contradiction of canonical exposition knowledge.
+   - 0 pts: Severe technical hallucinations, broken logic, invalid diagrams, invented casing/spelling rules for standard-library identifiers, or direct contradiction of canonical exposition knowledge.
 
 6. **Contract Consistency & Zero-Drift (10 pts):**
    - 10 pts: Satellite artifact strictly adheres to the scope, tech stack, and objectives of Lesson ${lessonId} without introducing unrelated topics. If \`canonicalLessonExcerpt\` is present in candidate JSON, all satellite phases/activities strictly operationalize the master Lesson Flow and Activity Sequence without inventing divergent timelines.
@@ -10208,6 +10208,38 @@ function checkScopeDrift(content, scopedKeywords, tolerance = 0) {
     evidence: drift
   };
 }
+function checkIdentifierCasing(content, refPack) {
+  if (!refPack || !refPack.trim()) return null;
+  const canonical = /* @__PURE__ */ new Map();
+  const remember = (id) => {
+    if (id.length < 2) return;
+    const key = id.toLowerCase().replace(/_/g, "");
+    if (!canonical.has(key)) canonical.set(key, id);
+  };
+  for (const m of refPack.matchAll(/`([A-Za-z_][A-Za-z0-9_]*)\s*\(/g)) remember(m[1]);
+  for (const m of refPack.matchAll(/\b([A-Za-z_][A-Za-z0-9_]*)\s*\(/g)) remember(m[1]);
+  for (const m of refPack.matchAll(/`([A-Za-z_][A-Za-z0-9_]*)`/g)) remember(m[1]);
+  if (canonical.size === 0) return null;
+  const RESERVED = /* @__PURE__ */ new Set(["if", "for", "while", "switch", "func", "return", "guard", "catch", "else", "in"]);
+  const violations = [];
+  const fenceRe = /```[a-zA-Z]*\n([\s\S]*?)```/g;
+  for (const fence of content.matchAll(fenceRe)) {
+    for (const m of fence[1].matchAll(/\b([A-Za-z_][A-Za-z0-9_]*)\s*\(/g)) {
+      const tok = m[1];
+      if (RESERVED.has(tok.toLowerCase())) continue;
+      const real = canonical.get(tok.toLowerCase().replace(/_/g, ""));
+      if (real && real !== tok && !violations.includes(`${tok} \u2192 ${real}`)) {
+        violations.push(`${tok} \u2192 ${real}`);
+      }
+    }
+  }
+  if (violations.length === 0) return null;
+  return {
+    code: "identifier-casing",
+    detail: `Code d\xF9ng identifier l\u1EC7ch casing so v\u1EDBi REFERENCE_PACK (ngu\u1ED3n s\u1EF1 th\u1EADt k\u1EF9 thu\u1EADt): ${violations.join(", ")}. Identifier trong code PH\u1EA2I copy nguy\xEAn d\u1EA1ng t\u1EEB REFERENCE_PACK \u2014 KH\xD4NG suy ra casing t\u1EEB t\xEAn keyword/concept (ch\xFAng l\xE0 nh\xE3n s\u01B0 ph\u1EA1m, kh\xF4ng ph\u1EA3i API).`,
+    evidence: violations.slice(0, 5)
+  };
+}
 function validateArtifactDeterministic(input) {
   const issues = [];
   const cjk = scanCjkLeaks(input.content);
@@ -10215,6 +10247,8 @@ function validateArtifactDeterministic(input) {
   if (input.refPack) {
     const ver = checkVersionGroundTruth(input.content, input.refPack);
     if (ver) issues.push(ver);
+    const casing = checkIdentifierCasing(input.content, input.refPack);
+    if (casing) issues.push(casing);
   }
   if (input.scopedKeywords && input.scopedKeywords.length > 0) {
     const scope = checkScopeDrift(input.content, input.scopedKeywords);
@@ -10326,9 +10360,10 @@ function buildSystemPrompt(targetLanguage = "vi", techStack, hardwarePlatform) {
     "Rules:",
     "1. Cover EXACTLY the scoped keywords and concepts \u2014 nothing beyond the session scope.",
     "2. Every Key Term definition must be consistent with the glossary entry provided.",
-    "3. Respect each concept depth target (ULO/CIO/SIO) \u2014 do not overshoot.",
-    "4. Student-facing only: no teacher instructions, no classroom management text.",
-    "5. Output the full markdown document following the provided section skeleton exactly (headers and placeholders preserved).",
+    '3. IDENTIFIER GROUND TRUTH: glossary/keyword names are pedagogical concept labels \u2014 NEVER derive code identifier casing or spelling from them. In code samples, copy identifiers EXACTLY from the REFERENCE_PACK ground truth (e.g. the standard library function is `print` lowercase; "Print" as a topic label is not an API symbol).',
+    "4. Respect each concept depth target (ULO/CIO/SIO) \u2014 do not overshoot.",
+    "5. Student-facing only: no teacher instructions, no classroom management text.",
+    "6. Output the full markdown document following the provided section skeleton exactly (headers and placeholders preserved).",
     domainGuardrails,
     langDirective
   ].join("\n");
@@ -10995,10 +11030,13 @@ function buildUnitGroupings(graph, orderedIds) {
 }
 function computePackingSpec(constraints) {
   const overheadMinutes = Math.round(constraints.session_duration_minutes * constraints.overhead_ratio);
+  const upperAge = constraints.age_band?.[1];
+  const maxNew = upperAge !== void 0 && upperAge > 15 ? MAX_NEW_CONCEPTS_PER_SESSION_ADULT : MAX_NEW_CONCEPTS_PER_SESSION_K12;
   return {
     contentBudget: constraints.session_duration_minutes - overheadMinutes,
     overheadMinutes,
-    sessionDurationMinutes: constraints.session_duration_minutes
+    sessionDurationMinutes: constraints.session_duration_minutes,
+    maxNewConceptsPerSession: maxNew
   };
 }
 var filledOf = (s) => s.knowledgeMinutes + s.practiceMinutes;
@@ -11081,6 +11119,15 @@ function packUnitSessions(group, nodeById, spec, warnings) {
       continue;
     }
     const minutes = node.estimated_minutes;
+    if (spec.maxNewConceptsPerSession && spec.maxNewConceptsPerSession > 0 && current.entries.length > 0) {
+      const currentConcepts = new Set(current.nodeIds.flatMap((nid) => nodeById.get(nid)?.concept_codes || []));
+      const incoming = nodeById.get(id)?.concept_codes || [];
+      const wouldAdd = incoming.filter((c) => !currentConcepts.has(c)).length;
+      if (currentConcepts.size + wouldAdd > spec.maxNewConceptsPerSession) {
+        warnings.push(`ZPD pack flush: session ${group.key}#${sessions.length + 1} cut at ${currentConcepts.size} new concepts (budget ${spec.maxNewConceptsPerSession})`);
+        flush();
+      }
+    }
     if (current.entries.length > 0 && filled() + minutes > spec.contentBudget) {
       const displaced = cutBackToCheckpoint(current, nodeById, spec, warnings);
       if (displaced.length > 0) {
@@ -11239,12 +11286,12 @@ function checkSessionZpd(sessionIndex, nodeIds, nodeById, allSeenConcepts, allSe
   const knownKeywords = allKeywords.filter((k) => allSeenKeywords.has(k.toLowerCase()) || entryKw.has(k.toLowerCase()));
   const issues = [];
   let verdict = "OK";
-  if (concepts.length > 0 && newConcepts.length > 2) {
-    verdict = "TOO_MANY_NEW";
-    issues.push(`${newConcepts.length} new concepts exceed ZPD limit (max 2)`);
-  } else if (concepts.length === 0 && newKeywords.length > 4) {
+  if (newConcepts.length > MAX_NEW_CONCEPTS_PER_SESSION_K12) {
     verdict = "TOO_MANY_NEW";
-    issues.push(`${newKeywords.length} new keywords exceed ZPD limit (max 4)`);
+    issues.push(`${newConcepts.length} new concepts exceed ZPD limit (max ${MAX_NEW_CONCEPTS_PER_SESSION_K12})`);
+  }
+  if (newKeywords.length > 4) {
+    issues.push(`Evidence for judge: ${newKeywords.length} new keywords in session (noisy proxy, not a gate)`);
   }
   if (sessionIndex > 0) {
     if (concepts.length > 1 && knownConcepts.length === 0) {
@@ -27356,6 +27403,7 @@ Your task is to author a canonical, publication-grade learning artifact of type
 ${langDirective}
 ${headingDirective}
 2. NON-MOCK CODE INVARIANT: Any code snippet provided MUST be 100% syntactically valid, idiomatic, and executable without placeholders or fake functions.
+2b. IDENTIFIER GROUND TRUTH: Never derive identifier casing/spelling from glossary term or concept names (they are pedagogical labels). Copy identifiers EXACTLY from the canonical LESSON and REFERENCE_PACK ground truth present in the context.
 3. PEDAGOGICAL GROUNDING: Strictly align with the ${pedagogy.toUpperCase()} model, Bloom's Revised Taxonomy, and IEEE/ACM CS2023 guidelines.
 4. SCAFFOLDING LEVEL: "${scaffoldingLevel.toUpperCase()}".${scaffoldingRule}
 5. TARGET AUDIENCE: ${gradeLevel ? `Grade ${gradeLevel}, ` : ""}${targetAge} on ${hwStr}.${deviceRule}${classDynamicsRule}${extraContextRule}
@@ -29915,14 +29963,14 @@ var DeterministicStructuralLinter = class {
     let score = 100;
     for (const s of plan.sessions) {
       if (s.zpd_status?.verdict === "TOO_MANY_NEW") {
-        score -= 10;
+        score -= 25;
         findings.push({
           id: `PLAN_TOO_MANY_NEW_${s.id}`,
           dimension: "CONSTRUCTIVE_ALIGNMENT",
-          severity: "MINOR",
+          severity: "CRITICAL",
           title: `Cognitive Overload in Session ${s.id}`,
-          description: s.zpd_status.issues.join("; ") || `Session introduces too many new concepts/keywords, exceeding ZPD capacity.`,
-          remediationAdvice: `Distribute new concepts across multiple sessions or introduce via scaffolding.`,
+          description: s.zpd_status.issues.join("; ") || `Session introduces more new concepts than the ZPD limit allows.`,
+          remediationAdvice: `Split the session: move overflow concepts to a later session (the packer flushes on concept budget automatically).`,
           affectedElement: s.id
         });
       } else if (s.zpd_status?.verdict === "NO_ZPD_BRIDGE") {