@testim/testim-cli 3.286.0 → 3.287.0

package/agent/routers/cliJsCode/service.js

@@ -2,18 +2,20 @@
 
 'use strict';
 
-const path = require('path');
+const fs = require('fs');
 const os = require('os');
-const dataUriToBuffer = require('data-uri-to-buffer');
-const { spawn: threadSpawn, config } = require('threads');
+const path = require('path');
 const fse = require('fs-extra');
-const fs = require('fs');
+const dataUriToBuffer = require('data-uri-to-buffer');
 const utils = require('../../../utils');
-const logger = require('../../../commons/logger').getLogger('cli-service');
-const { getS3Artifact } = require('../../../commons/testimServicesApi');
 const npmWrapper = require('../../../commons/npmWrapper');
 const featureFlags = require('../../../commons/featureFlags');
+const { spawn: threadSpawn, config } = require('threads');
 const { TimeoutError } = require('../../../errors');
+const { getLogger } = require('../../../commons/logger');
+const { getS3Artifact } = require('../../../commons/testimServicesApi');
+
+const logger = getLogger('cli-service');
 
 /** @type {import('worker_threads') | false} */
 let workerThreads;
@@ -270,16 +272,17 @@ function runCode(transactionId, incomingParams, context, code, packageLocalLocat
         .finally(() => thread?.kill());
 }
 
-function requireOrImportMethod(path) {
+/** @param {string} _path */
+function requireOrImportMethod(_path) {
     try {
-        return { sync: true, lib: require(path) };
+        return { sync: true, lib: require(_path) };
     } catch (err) {
         if (err.code === 'ERR_REQUIRE_ESM') {
             const pathModule = require('path');
 
             const lib = fs.promises.readFile(`${path}${pathModule.sep}package.json`).then(file => {
                 const packageJson = JSON.parse(file);
-                const fullPath = pathModule.join(path, packageJson.main || `${pathModule.sep}index.js`);
+                const fullPath = pathModule.join(_path, packageJson.main || `${pathModule.sep}index.js`);
                 return import(fullPath);
             });
 
@@ -563,6 +566,7 @@ function runCodeWithWorkerThread(
         .finally(() => thread?.terminate());
 }
 
+/** @param {string} installFolder */
 async function removeFolder(installFolder) {
     try {
         await fse.remove(installFolder);
@@ -571,10 +575,24 @@ async function removeFolder(installFolder) {
     }
 }
 
+/**
+ * @param {string} stepResultId
+ * @param {string} testResultId
+ * @param {string} stepId
+ * @param {number} retryIndex
+ */
 function getTransactionId(stepResultId, testResultId, stepId, retryIndex) {
     return `${testResultId}_${stepId}_${stepResultId}_${retryIndex}`;
 }
 
+/**
+ * @param {string} stepId
+ * @param {string} testResultId
+ * @param {number} retryIndex
+ * @param {{ packageName: string; packageVersion: string }[]} packageData
+ * @param {string} stepResultId
+ * @param {number} timeout
+ */
 function installPackage(stepId, testResultId, retryIndex, packageData, stepResultId, timeout) {
     const transactionId = getTransactionId(stepResultId, testResultId, stepId, retryIndex);
     return runNpmInstall(transactionId, packageData, timeout).then(({ data }) => data);
@@ -622,6 +640,11 @@ function runCodeWithPackages(code, stepId, incomingParams, context, testResultId
     }).then(res => Object.assign({}, res, { nodeVersion: process.version }));
 }
 
+/**
+ * @param {string} transactionId
+ * @param {{ packageName: string; packageVersion: string }[]} packageData
+ * @param {number} timeout
+ */
 async function runNpmInstall(transactionId, packageData, timeout) {
     const packages = packageData.map(data => `${data.packageName}@${data.packageVersion}`);
     const localPackageInstallFolder = getLocalPackageInstallFolder();

package/agent/routers/codim/service.js

@@ -150,19 +150,22 @@ async function compileFunctionsLibrary({ fileSystem, bypassWebpack } = {}, optio
         const Module = require('module');
         // attempt to require without webpack compile - useful for puppeteer/selenium hybrid
         const originalRequire = Module.prototype.require;
-        Module.prototype.require = function requireThatOverridesSessionPlayer(id) {
+        Module.prototype.require = function requireThatOverridesTestimTDK(id) {
             if (id === 'testim') {
                 return bypassWebpack.testim;
             }
             // eslint-disable-next-line prefer-rest-params
             return originalRequire.apply(this, arguments);
         };
-        // delete references to the old __testim from previous invocations
-        delete require.cache[require.resolve(functionsFile)];
-        const functions = require(functionsFile);
-        // asynchronous required not supported - is this fine?
-        Module.prototype.require = originalRequire;
-        return functions;
+        try {
+            // delete references to the old __testim from previous invocations
+            delete require.cache[require.resolve(functionsFile)];
+            const functions = require(functionsFile); // eslint-disable-line import/no-dynamic-require
+            // asynchronous require not supported - is this fine?
+            return functions;
+        } finally {
+            Module.prototype.require = originalRequire;
+        }
     }
     const functionsAsAWebpackModule = await buildCodeTests([functionsFile], {
         output: {

package/cli/writeStackTrace.js

@@ -1,26 +1,27 @@
+/* eslint-disable no-console */
 
+const os = require('os');
+const path = require('path');
+const chalk = require('chalk');
+const fse = require('fs-extra');
 
 module.exports.writeStackTrace = function writeStackTrace(err) {
-    if(err && err.message && err.message.includes('SIGINT')) {
+    if (err?.message?.includes('SIGINT')) {
         return; // no need to generate a log file for a sigint.
     }
     try {
-        const homedir = require('os-homedir')();
-        const fse = require('fs-extra');
-        const path = require('path');
+        const homedir = os.homedir();
 
         fse.ensureDirSync(path.resolve(homedir, '.testim_logs'));
-        const logfilename = path.resolve(homedir, '.testim_logs', new Date().toISOString().replace(/:|\./g, '_') + '.log');
+        const logFileName = path.resolve(homedir, '.testim_logs', `${new Date().toISOString().replace(/:|\./g, '_')}.log`);
         console.log('Oops :( The test runner has encountered an unexpected error. A complete log of this run can be found in:');
-        console.log(`\t${logfilename}`);
+        console.log(`\t${logFileName}`);
 
-        if (err && err.message && err.message.includes('Unable to compile TypeScript') && err.stack.includes('runner/src')
-            && process.argv.some(x => x.includes('player-require-path'))) {
-                const chalk = require('chalk');
+        if (err?.message?.includes('Unable to compile TypeScript') && err.stack.includes('runner/src') && process.argv.some(x => x.includes('player-require-path'))) {
             console.log(chalk.red('Looks like you got a TypeScript compile error champ - but it\'s not a very good one because we use TypeScript in transpile-only mode'));
-            console.log(chalk.red(`change require('ts-node/register/transpile-only'); to require('ts-node/register'); for better errors`));
+            console.log(chalk.red('change require(\'ts-node/register/transpile-only\'); to require(\'ts-node/register\'); for better errors'));
         }
 
-        fse.writeFileSync(logfilename, err + "\n" + err.stack + "\n\n" + JSON.stringify(err, Object.getOwnPropertyNames(err), 2));
-    } catch (err) { }
-}
+        fse.writeFileSync(logFileName, `${err}\n${err.stack}\n\n${JSON.stringify(err, Object.getOwnPropertyNames(err), 2)}`);
+    } catch { /* noop */ }
+};

package/cli.js

@@ -4,26 +4,23 @@
 'use strict';
 
 require('./polyfills');
-const options = require('./runOptions');
+const semver = require('semver');
 const EventEmitter = require('events');
-const logger = require('./commons/logger').getLogger('cli-entry');
-const { onExit, ignoreFailingTestsInExitCode } = require('./cli/onExit');
+const utils = require('./utils');
 const testRunner = require('./runner');
+const options = require('./runOptions');
+const agentMode = require('./cliAgentMode');
+const perf = require('./commons/performance-logger');
 const prepareRunner = require('./commons/prepareRunner');
+const prepareRunnerAndTestimStartUtils = require('./commons/prepareRunnerAndTestimStartUtils');
+const { getLogger } = require('./commons/logger');
 const { CLI_MODE } = require('./commons/constants');
+const { registerProcessForCleanup } = require('./processHandler');
+const { NoArgsError, SeleniumError, ArgError } = require('./errors');
+const { onExit, ignoreFailingTestsInExitCode } = require('./cli/onExit');
 const { updateRemoteRunFailure } = require('./commons/testimServicesApi');
-const prepareRunnerAndTestimStartUtils = require('./commons/prepareRunnerAndTestimStartUtils');
 
-const {
-    NoArgsError,
-    SeleniumError,
-    ArgError,
-} = require('./errors');
-
-const utils = require('./utils');
-const semver = require('semver');
-const perf = require('./commons/performance-logger');
-const agentMode = require('./cliAgentMode');
+const logger = getLogger('cli-entry');
 
 try {
     require('./fixLocalBuild');
@@ -56,7 +53,7 @@ async function checkNodeVersion() {
 async function main() {
     console.log('Starting Testim.io CLI');
     perf.log('Starting Testim.io CLI');
-    require('./processHandler')(onExit);
+    registerProcessForCleanup(onExit);
 
     checkNodeVersion().catch(err => {
         console.log('Argument Error:', err.message);

package/commons/getSessionPlayerRequire.js

@@ -1,13 +1,28 @@
 'use strict';
 
-const perf = require('./performance-logger');
+const { join, resolve } = require('path');
 
-perf.log('getSessionPlayerRequire start');
-const { getSessionPlayerFolder } = require('./prepareRunnerAndTestimStartUtils');
+/** @type {{ playerPath: string | undefined }} */ module.exports.options = { playerPath: undefined };
 
-const testimAppDataFolder = getSessionPlayerFolder();
-/** @type {import('clickim/src/background/sessionPlayerInit').SessionPlayerInit} */
-const sessionPlayer = require(require('path').join(testimAppDataFolder, 'sessionPlayer.js')); // eslint-disable-line import/no-dynamic-require
+/** @type {import('clickim/src/background/sessionPlayerInit').SessionPlayerInit | undefined} */ let sessionPlayerInit;
 
-module.exports = sessionPlayer;
-perf.log('getSessionPlayerRequire end');
+module.exports.getSessionPlayer = () => {
+    if (sessionPlayerInit) {
+        return sessionPlayerInit;
+    }
+    const perf = require('./performance-logger');
+
+    perf.log('getSessionPlayerRequire start');
+    const { getSessionPlayerFolder } = require('./prepareRunnerAndTestimStartUtils');
+
+    const testimAppDataFolder = getSessionPlayerFolder();
+    const { options } = module.exports;
+    const path = options.playerPath ? resolve(options.playerPath, 'src/background/sessionPlayerInit.ts') : join(testimAppDataFolder, 'sessionPlayer.js');
+
+    /** @type {import('clickim/src/background/sessionPlayerInit').SessionPlayerInit} */
+    const sessionPlayer = require(path); // eslint-disable-line import/no-dynamic-require
+
+    perf.log('getSessionPlayerRequire end');
+    sessionPlayerInit = sessionPlayer;
+    return sessionPlayer;
+};

package/commons/httpRequestCounters.js

@@ -62,13 +62,13 @@ module.exports.makeCounters = () => {
      * @template T, TArgs
      * @param {(...args: TArgs[]) => T} fn
      * @param {string=} name
-     * @return {(...args: TArgs[]) => Promise<Awaited<T>>}
+     * @return {(...args: TArgs[]) => Promise<T>}
      */
     function wrapWithMonitoring(fn, name = fn.name) {
         return async function (...args) {
             update(counters.call, name);
             try {
-                const result = await fn.call(this, ...args);
+                const result = await fn.call(null, ...args);
                 update(counters.success, name);
                 return result;
             } catch (e) {

package/commons/initializeUserWithAuth.js

@@ -15,7 +15,7 @@ function preloadSlowRequires(mode) {
         }
         // heuristic to pay the cost of loading the sessionPlayer here while we are waiting for the backend
         try {
-            require('./getSessionPlayerRequire');
+            require('./getSessionPlayerRequire').getSessionPlayer();
             // jsdom for the same reason, we don't require workerSelenium here since it actually takes longer to load
             // then it takes for the backend to return 🤯
             require('jsdom');

package/commons/testimDesiredCapabilitiesBuilder.js

@@ -580,6 +580,7 @@ function buildAppiumOptions({ projectType, gridInfo, testRunConfig, nativeApp, o
         hostname: gridInfo.host,
         port: gridInfo.port,
         path: `/v0/${gridInfo.accessToken}/wd/hub`,
+        logLevel: options.appiumLogLevel,
         // connectionRetryTimeout: 900000, -- not used for now
     };
     //TODO: check if more caps should be defined as default

package/npm-shrinkwrap.json

@@ -1,12 +1,12 @@
 {
   "name": "@testim/testim-cli",
-  "version": "3.286.0",
+  "version": "3.287.0",
   "lockfileVersion": 2,
   "requires": true,
   "packages": {
     "": {
       "name": "@testim/testim-cli",
-      "version": "3.286.0",
+      "version": "3.287.0",
       "license": "Proprietary",
       "dependencies": {
         "@applitools/eyes-sdk-core": "13.11.29",
@@ -1275,6 +1275,11 @@
       "integrity": "sha512-HopIwBE7GUXsscmt/J0DhnFXLSmO04AfxT6b8HAprknwka7pqEWquWDMXxCjd+NUHK9MkCe1SDKKsMiNmCItbQ==",
       "dev": true
     },
+    "node_modules/@types/triple-beam": {
+      "version": "1.3.2",
+      "resolved": "https://registry.npmjs.org/@types/triple-beam/-/triple-beam-1.3.2.tgz",
+      "integrity": "sha512-txGIh+0eDFzKGC25zORnswy+br1Ha7hj5cMVwKIU7+s0U2AxxJru/jZSMU6OC9MJWP6+pc/hc6ZjyZShpsyY2g=="
+    },
     "node_modules/@types/ua-parser-js": {
       "version": "0.7.36",
       "resolved": "https://registry.npmjs.org/@types/ua-parser-js/-/ua-parser-js-0.7.36.tgz",
@@ -1427,9 +1432,9 @@
       }
     },
     "node_modules/@wdio/types/node_modules/@types/node": {
-      "version": "18.11.19",
-      "resolved": "https://registry.npmjs.org/@types/node/-/node-18.11.19.tgz",
-      "integrity": "sha512-YUgMWAQBWLObABqrvx8qKO1enAvBUdjZOAWQ5grBAkp5LQv45jBvYKZ3oFS9iKRCQyFjqw6iuEa1vmFqtxYLZw=="
+      "version": "18.13.0",
+      "resolved": "https://registry.npmjs.org/@types/node/-/node-18.13.0.tgz",
+      "integrity": "sha512-gC3TazRzGoOnoKAhUx+Q0t8S9Tzs74z7m0ipwGpSqQrleP14hKxP4/JUeEQcD3W1/aIpnWl8pHowI7WokuZpXg=="
     },
     "node_modules/@wdio/utils": {
       "version": "7.24.0",
@@ -4452,9 +4457,9 @@
       "integrity": "sha512-+iipnm2hvmlWs4MVNx7HwSTxhDxsXnQyK5F1OalZVXeUhdPgP/23T42NCyg0TK3wL/Yg92SVrSuGKqdg12o54w=="
     },
     "node_modules/devtools/node_modules/@types/node": {
-      "version": "18.11.19",
-      "resolved": "https://registry.npmjs.org/@types/node/-/node-18.11.19.tgz",
-      "integrity": "sha512-YUgMWAQBWLObABqrvx8qKO1enAvBUdjZOAWQ5grBAkp5LQv45jBvYKZ3oFS9iKRCQyFjqw6iuEa1vmFqtxYLZw=="
+      "version": "18.13.0",
+      "resolved": "https://registry.npmjs.org/@types/node/-/node-18.13.0.tgz",
+      "integrity": "sha512-gC3TazRzGoOnoKAhUx+Q0t8S9Tzs74z7m0ipwGpSqQrleP14hKxP4/JUeEQcD3W1/aIpnWl8pHowI7WokuZpXg=="
     },
     "node_modules/devtools/node_modules/ua-parser-js": {
       "version": "1.0.33",
@@ -8439,11 +8444,12 @@
       }
     },
     "node_modules/logform": {
-      "version": "2.4.2",
-      "resolved": "https://registry.npmjs.org/logform/-/logform-2.4.2.tgz",
-      "integrity": "sha512-W4c9himeAwXEdZ05dQNerhFz2XG80P9Oj0loPUMV23VC2it0orMHQhJm4hdnnor3rd1HsGf6a2lPwBM1zeXHGw==",
+      "version": "2.5.1",
+      "resolved": "https://registry.npmjs.org/logform/-/logform-2.5.1.tgz",
+      "integrity": "sha512-9FyqAm9o9NKKfiAKfZoYo9bGXXuwMkxQiQttkT4YjjVtQVIQtK6LmVtlxmCaFswo6N4AfEkHqZTV0taDtPotNg==",
       "dependencies": {
         "@colors/colors": "1.5.0",
+        "@types/triple-beam": "^1.3.2",
         "fecha": "^4.2.0",
         "ms": "^2.1.1",
         "safe-stable-stringify": "^2.3.1",
@@ -15817,9 +15823,9 @@
       }
     },
     "node_modules/vm2": {
-      "version": "3.9.13",
-      "resolved": "https://registry.npmjs.org/vm2/-/vm2-3.9.13.tgz",
-      "integrity": "sha512-0rvxpB8P8Shm4wX2EKOiMp7H2zq+HUE/UwodY0pCZXs9IffIKZq6vUti5OgkVCTakKo9e/fgO4X1fkwfjWxE3Q==",
+      "version": "3.9.14",
+      "resolved": "https://registry.npmjs.org/vm2/-/vm2-3.9.14.tgz",
+      "integrity": "sha512-HgvPHYHeQy8+QhzlFryvSteA4uQLBCOub02mgqdR+0bN/akRZ48TGB1v0aCv7ksyc0HXx16AZtMHKS38alc6TA==",
       "dependencies": {
         "acorn": "^8.7.0",
         "acorn-walk": "^8.2.0"
@@ -15892,9 +15898,9 @@
       }
     },
     "node_modules/webdriver/node_modules/@types/node": {
-      "version": "18.11.19",
-      "resolved": "https://registry.npmjs.org/@types/node/-/node-18.11.19.tgz",
-      "integrity": "sha512-YUgMWAQBWLObABqrvx8qKO1enAvBUdjZOAWQ5grBAkp5LQv45jBvYKZ3oFS9iKRCQyFjqw6iuEa1vmFqtxYLZw=="
+      "version": "18.13.0",
+      "resolved": "https://registry.npmjs.org/@types/node/-/node-18.13.0.tgz",
+      "integrity": "sha512-gC3TazRzGoOnoKAhUx+Q0t8S9Tzs74z7m0ipwGpSqQrleP14hKxP4/JUeEQcD3W1/aIpnWl8pHowI7WokuZpXg=="
     },
     "node_modules/webdriverio": {
       "version": "7.24.0",
@@ -15934,9 +15940,9 @@
       }
     },
     "node_modules/webdriverio/node_modules/@types/node": {
-      "version": "18.11.19",
-      "resolved": "https://registry.npmjs.org/@types/node/-/node-18.11.19.tgz",
-      "integrity": "sha512-YUgMWAQBWLObABqrvx8qKO1enAvBUdjZOAWQ5grBAkp5LQv45jBvYKZ3oFS9iKRCQyFjqw6iuEa1vmFqtxYLZw=="
+      "version": "18.13.0",
+      "resolved": "https://registry.npmjs.org/@types/node/-/node-18.13.0.tgz",
+      "integrity": "sha512-gC3TazRzGoOnoKAhUx+Q0t8S9Tzs74z7m0ipwGpSqQrleP14hKxP4/JUeEQcD3W1/aIpnWl8pHowI7WokuZpXg=="
     },
     "node_modules/webdriverio/node_modules/brace-expansion": {
       "version": "2.0.1",
@@ -17403,6 +17409,11 @@
       "integrity": "sha512-HopIwBE7GUXsscmt/J0DhnFXLSmO04AfxT6b8HAprknwka7pqEWquWDMXxCjd+NUHK9MkCe1SDKKsMiNmCItbQ==",
       "dev": true
     },
+    "@types/triple-beam": {
+      "version": "1.3.2",
+      "resolved": "https://registry.npmjs.org/@types/triple-beam/-/triple-beam-1.3.2.tgz",
+      "integrity": "sha512-txGIh+0eDFzKGC25zORnswy+br1Ha7hj5cMVwKIU7+s0U2AxxJru/jZSMU6OC9MJWP6+pc/hc6ZjyZShpsyY2g=="
+    },
     "@types/ua-parser-js": {
       "version": "0.7.36",
       "resolved": "https://registry.npmjs.org/@types/ua-parser-js/-/ua-parser-js-0.7.36.tgz",
@@ -17518,9 +17529,9 @@
       },
       "dependencies": {
         "@types/node": {
-          "version": "18.11.19",
-          "resolved": "https://registry.npmjs.org/@types/node/-/node-18.11.19.tgz",
-          "integrity": "sha512-YUgMWAQBWLObABqrvx8qKO1enAvBUdjZOAWQ5grBAkp5LQv45jBvYKZ3oFS9iKRCQyFjqw6iuEa1vmFqtxYLZw=="
+          "version": "18.13.0",
+          "resolved": "https://registry.npmjs.org/@types/node/-/node-18.13.0.tgz",
+          "integrity": "sha512-gC3TazRzGoOnoKAhUx+Q0t8S9Tzs74z7m0ipwGpSqQrleP14hKxP4/JUeEQcD3W1/aIpnWl8pHowI7WokuZpXg=="
         }
       }
     },
@@ -19930,9 +19941,9 @@
       },
       "dependencies": {
         "@types/node": {
-          "version": "18.11.19",
-          "resolved": "https://registry.npmjs.org/@types/node/-/node-18.11.19.tgz",
-          "integrity": "sha512-YUgMWAQBWLObABqrvx8qKO1enAvBUdjZOAWQ5grBAkp5LQv45jBvYKZ3oFS9iKRCQyFjqw6iuEa1vmFqtxYLZw=="
+          "version": "18.13.0",
+          "resolved": "https://registry.npmjs.org/@types/node/-/node-18.13.0.tgz",
+          "integrity": "sha512-gC3TazRzGoOnoKAhUx+Q0t8S9Tzs74z7m0ipwGpSqQrleP14hKxP4/JUeEQcD3W1/aIpnWl8pHowI7WokuZpXg=="
         },
         "ua-parser-js": {
           "version": "1.0.33",
@@ -23122,11 +23133,12 @@
       }
     },
     "logform": {
-      "version": "2.4.2",
-      "resolved": "https://registry.npmjs.org/logform/-/logform-2.4.2.tgz",
-      "integrity": "sha512-W4c9himeAwXEdZ05dQNerhFz2XG80P9Oj0loPUMV23VC2it0orMHQhJm4hdnnor3rd1HsGf6a2lPwBM1zeXHGw==",
+      "version": "2.5.1",
+      "resolved": "https://registry.npmjs.org/logform/-/logform-2.5.1.tgz",
+      "integrity": "sha512-9FyqAm9o9NKKfiAKfZoYo9bGXXuwMkxQiQttkT4YjjVtQVIQtK6LmVtlxmCaFswo6N4AfEkHqZTV0taDtPotNg==",
       "requires": {
         "@colors/colors": "1.5.0",
+        "@types/triple-beam": "^1.3.2",
         "fecha": "^4.2.0",
         "ms": "^2.1.1",
         "safe-stable-stringify": "^2.3.1",
@@ -28722,9 +28734,9 @@
       }
     },
     "vm2": {
-      "version": "3.9.13",
-      "resolved": "https://registry.npmjs.org/vm2/-/vm2-3.9.13.tgz",
-      "integrity": "sha512-0rvxpB8P8Shm4wX2EKOiMp7H2zq+HUE/UwodY0pCZXs9IffIKZq6vUti5OgkVCTakKo9e/fgO4X1fkwfjWxE3Q==",
+      "version": "3.9.14",
+      "resolved": "https://registry.npmjs.org/vm2/-/vm2-3.9.14.tgz",
+      "integrity": "sha512-HgvPHYHeQy8+QhzlFryvSteA4uQLBCOub02mgqdR+0bN/akRZ48TGB1v0aCv7ksyc0HXx16AZtMHKS38alc6TA==",
       "requires": {
         "acorn": "^8.7.0",
         "acorn-walk": "^8.2.0"
@@ -28783,9 +28795,9 @@
       },
       "dependencies": {
         "@types/node": {
-          "version": "18.11.19",
-          "resolved": "https://registry.npmjs.org/@types/node/-/node-18.11.19.tgz",
-          "integrity": "sha512-YUgMWAQBWLObABqrvx8qKO1enAvBUdjZOAWQ5grBAkp5LQv45jBvYKZ3oFS9iKRCQyFjqw6iuEa1vmFqtxYLZw=="
+          "version": "18.13.0",
+          "resolved": "https://registry.npmjs.org/@types/node/-/node-18.13.0.tgz",
+          "integrity": "sha512-gC3TazRzGoOnoKAhUx+Q0t8S9Tzs74z7m0ipwGpSqQrleP14hKxP4/JUeEQcD3W1/aIpnWl8pHowI7WokuZpXg=="
         }
       }
     },
@@ -28824,9 +28836,9 @@
       },
       "dependencies": {
         "@types/node": {
-          "version": "18.11.19",
-          "resolved": "https://registry.npmjs.org/@types/node/-/node-18.11.19.tgz",
-          "integrity": "sha512-YUgMWAQBWLObABqrvx8qKO1enAvBUdjZOAWQ5grBAkp5LQv45jBvYKZ3oFS9iKRCQyFjqw6iuEa1vmFqtxYLZw=="
+          "version": "18.13.0",
+          "resolved": "https://registry.npmjs.org/@types/node/-/node-18.13.0.tgz",
+          "integrity": "sha512-gC3TazRzGoOnoKAhUx+Q0t8S9Tzs74z7m0ipwGpSqQrleP14hKxP4/JUeEQcD3W1/aIpnWl8pHowI7WokuZpXg=="
         },
         "brace-expansion": {
           "version": "2.0.1",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@testim/testim-cli",
-  "version": "3.286.0",
+  "version": "3.287.0",
   "description": "Command line interface for running Testing on your CI",
   "author": "Oren Rubin",
   "contributors": [{

package/player/appiumTestPlayer.js

@@ -3,29 +3,20 @@
 const webdriverio = require('webdriverio');
 const TabService = require('./services/tabServiceMock');
 const PortSelector = require('./services/portSelector');
-const windowCreationListener = require('./services/windowCreationListener');
+const StepActionUtils = require('./utils/stepActionUtils');
 const frameLocatorFactory = require('./services/mobileFrameLocatorMock');
+const testResultService = require('../commons/socket/testResultService');
+const windowCreationListener = require('./services/windowCreationListener');
+const PlaybackTimeoutCalculator = require('./services/playbackTimeoutCalculator');
 const { isDebuggerConnected } = require('../commons/detectDebugger');
+const { getSessionPlayer } = require('../commons/getSessionPlayerRequire');
 const logger = require('../commons/logger').getLogger('appium-test-player');
 
-const sessionPlayer = require('../commons/getSessionPlayerRequire');
-
-const Player = sessionPlayer.sessionPlayer;
-// delete after https://github.com/testimio/clickim/pull/3430 release to the store
-const assetService = sessionPlayer.assetService;
-const commonConstants = sessionPlayer.commonConstants;
-const StepActionFactory = sessionPlayer.stepActionFactory;
-const mobileLocateElementPlayer = sessionPlayer.MobileLocateElementPlayer;
-const PlaybackTimeoutCalculator = require('./services/playbackTimeoutCalculator');
-const testResultService = require('../commons/socket/testResultService');
-
-// delete after https://github.com/testimio/clickim/pull/3430 release to the store
-const CryptoJS = require('crypto-js');
-const StepActionUtils = require('./utils/stepActionUtils');
 
 class AppiumTestPlayer {
     //eslint-disable-next-line default-param-last
     constructor(id, userParamsData, shouldMonitorPerformance, automationMode = 'code', driver = webdriverio, testRetryCount, previousTestResultId) {
+        const { sessionPlayer: Player, commonConstants, stepActionFactory: StepActionFactory, MobileLocateElementPlayer } = getSessionPlayer();
         this.driver = driver;
         this.id = id;
 
@@ -33,10 +24,6 @@ class AppiumTestPlayer {
         this.stepActionFactory = new StepActionFactory(stepActionUtils);
         require('./stepActions/stepActionRegistrar')(this.driver, this.stepActionFactory, 'selenium');
 
-        if (assetService.setMd5) {
-            // delete after https://github.com/testimio/clickim/pull/3430 release to the store
-            assetService.setMd5(CryptoJS);
-        }
         this.tabService = new TabService(this.driver);
         this.windowCreationListener = windowCreationListener;
         this.playbackTimeoutCalculator = new PlaybackTimeoutCalculator(isDebuggerConnected());
@@ -52,7 +39,7 @@ class AppiumTestPlayer {
             null,
             FrameLocator,
             PortSelector,
-            mobileLocateElementPlayer,
+            MobileLocateElementPlayer,
             null /* Not in use, placeholder for the order of arguments */,
             stepActionUtils,
             this.stepActionFactory,
@@ -86,6 +73,7 @@ class AppiumTestPlayer {
         } catch (error) {
             logger.error('error while deleting appium session', { error });
         } finally {
+            const { commonConstants } = getSessionPlayer();
             this.sessionPlayer.playbackManager.off(commonConstants.playback.RESULT);
             this.sessionPlayer = null;
             this.tabService = null;

package/player/seleniumTestPlayer.js

@@ -1,31 +1,23 @@
 'use strict';
 
+const utils = require('../utils');
+const WebDriver = require('./webdriver');
+const CookieUtils = require('./utils/cookieUtils');
 const TabService = require('./services/tabService');
 const PortSelector = require('./services/portSelector');
-const windowCreationListener = require('./services/windowCreationListener');
-const CookieUtils = require('./utils/cookieUtils');
+const StepActionUtils = require('./utils/stepActionUtils');
 const frameLocatorFactory = require('./services/frameLocator');
-const { isDebuggerConnected } = require('../commons/detectDebugger');
-
-const sessionPlayer = require('../commons/getSessionPlayerRequire');
-
-const Player = sessionPlayer.sessionPlayer;
-// delete after https://github.com/testimio/clickim/pull/3430 release to the store
-const assetService = sessionPlayer.assetService;
-const commonConstants = sessionPlayer.commonConstants;
-const StepActionFactory = sessionPlayer.stepActionFactory;
-const PlaybackTimeoutCalculator = require('./services/playbackTimeoutCalculator');
 const testResultService = require('../commons/socket/testResultService');
+const windowCreationListener = require('./services/windowCreationListener');
+const PlaybackTimeoutCalculator = require('./services/playbackTimeoutCalculator');
+const { isDebuggerConnected } = require('../commons/detectDebugger');
+const { getSessionPlayer } = require('../commons/getSessionPlayerRequire');
 
-const WebDriver = require('./webdriver');
-// delete after https://github.com/testimio/clickim/pull/3430 release to the store
-const CryptoJS = require('crypto-js');
-const StepActionUtils = require('./utils/stepActionUtils');
-const utils = require('../utils');
 
 class SeleniumTestPlayer {
     //eslint-disable-next-line default-param-last
     constructor(id, userParamsData, shouldMonitorPerformance, automationMode = 'code', driver = new WebDriver(), testRetryCount, previousTestResultId) {
+        const { sessionPlayer: Player, commonConstants, stepActionFactory: StepActionFactory } = getSessionPlayer();
         this.driver = driver;
         this.id = id;
 
@@ -33,10 +25,6 @@ class SeleniumTestPlayer {
         this.stepActionFactory = new StepActionFactory(stepActionUtils);
         require('./stepActions/stepActionRegistrar')(this.driver, this.stepActionFactory, 'selenium');
 
-        if (assetService.setMd5) {
-            // delete after https://github.com/testimio/clickim/pull/3430 release to the store
-            assetService.setMd5(CryptoJS);
-        }
         this.tabService = this.driver.tabService || new TabService(this.driver);
         // expose the tabService on the driver so future sessions reusing the driver
         // know the tabs (for example - a TDK Hybrid step)
@@ -90,6 +78,7 @@ class SeleniumTestPlayer {
     }
 
     onDone() {
+        const { commonConstants } = getSessionPlayer();
         const END_DRIVER_TIMEOUT = 1000 * 60 * 2;
         return utils.promiseTimeout(this.driver.end(), END_DRIVER_TIMEOUT)
             .catch(error => {

package/player/services/frameLocator.js

@@ -2,10 +2,11 @@
 
 'use strict';
 
-const logger = require('../../commons/logger').getLogger('frame-locator');
-const { locatorBuilderUtils } = require('../../commons/getSessionPlayerRequire');
 const featureFlags = require('../../commons/featureFlags');
+const { getLogger } = require('../../commons/logger');
+const { getSessionPlayer } = require('../../commons/getSessionPlayerRequire');
 
+const logger = getLogger('frame-locator');
 const SELENIUM_ELEMENT_KEY = 'ELEMENT';
 const SELENIUM_GUID_KEY = 'element-6066-11e4-a52e-4f735466cecf';
 
@@ -61,6 +62,7 @@ module.exports = function frameLocatorFactory(driver) {
         */
         async foundFrameCallback(result, frameTree, testimFrameId) {
             const { frameOffset, locatedElement } = result;
+            const { locatorBuilderUtils } = getSessionPlayer();
             if (locatorBuilderUtils.isEmptyResult(locatedElement)) {
                 const errorMsg = 'got empty result in frame result, not rejected from locate element player';
                 logger.error(errorMsg);