@testim/testim-cli 3.254.0 → 3.256.0

package/runOptions.js

@@ -2,22 +2,20 @@
 
 'use strict';
 
-const { CLI_MODE } = require('./commons/constants');
-const { EDGE_CHROMIUM_MIN_VERSION } = require('./player/constants');
-const program = require('commander');
 const fs = require('fs');
 const ms = require('ms');
-const Promise = require('bluebird');
-const NoArgsError = require('./errors.js').NoArgsError;
-const ArgError = require('./errors.js').ArgError;
 const url = require('url');
 const _ = require('lodash');
 const path = require('path');
+const chalk = require('chalk');
+const program = require('commander');
 const utils = require('./utils');
-const runOptionsAgentFlow = require('./runOptionsAgentFlow');
 const runOptionsUtils = require('./runOptionsUtils');
+const runOptionsAgentFlow = require('./runOptionsAgentFlow');
 const localRunnerCache = require('./commons/runnerFileCache');
-const chalk = require('chalk');
+const { CLI_MODE } = require('./commons/constants');
+const { NoArgsError, ArgError } = require('./errors');
+const { EDGE_CHROMIUM_MIN_VERSION } = require('./player/constants');
 
 const camelizeHyphenValues = (prop) => prop.replace(/-([a-z])/g, (m, w) => w.toUpperCase());
 
@@ -114,6 +112,10 @@ const printUsage = () => {
         return line.includes('--high-speed'); // high speed mode was renamed to turbo mode
     }
 
+    function isTestStartTimeout(line) {
+        return line.includes('--test-start-timeout');
+    }
+
     program.help((txt) => {
         const lines = txt.split('\n');
         return lines
@@ -129,7 +131,8 @@ const printUsage = () => {
                     !isWebdriverTimeout(ln) &&
                     !isSaveRCALocally(ln) &&
                     !isExitCodeIgnoreFailingTests(ln) &&
-                    !isDeprecatedHighSpeed(ln)
+                    !isDeprecatedHighSpeed(ln) &&
+                    !isTestStartTimeout(ln)
             )
             .join('\n');
     });
@@ -217,17 +220,18 @@ program
     .option('--file-cache-location [directory]', ' internal CLI file caching location')
 
     // Timeout
-    .option('--timeout [test-timeout]', 'test run timeout in milliseconds')
-    .option('--browser-timeout [open-browser-timeout]', 'get browser from grid timeout in milliseconds')
-    .option('--new-browser-wait-timeout [max-wait-to-browser]', 'maximum get browser wait in minutes')
+    .option('--test-start-timeout [test-start-timeout]', 'The time to wait for a test to start after getting a browser session', Number, Number(process.env.TESTIM_TEST_START_TIMEOUT) || (2 * 60 * 1000))
+    .option('--timeout [test-timeout]', 'Test run timeout in milliseconds', Number)
+    .option('--browser-timeout [open-browser-timeout]', 'Get browser from grid timeout in milliseconds', Number)
+    .option('--new-browser-wait-timeout [max-wait-to-browser]', 'Maximum get browser wait in minutes', Number)
 
     // New Timeouts
-    .option('--get-browser-timeout [get-browser-timeout]', 'Timeout for a single attempt to get browser from the grid configured in the project\'s plan') // getBrowserTimeout
-    .option('--get-browser-retries [get-browser-retries]', 'Number of attempts to get browser from the grid configured in the project\'s plan') // getBrowserRetries
-    .option('--get-session-timeout [get-session-timeout]', 'Timeout for "/session" request to the selenium server', ms('90s')) // getSessionTimeout
-    .option('--get-session-retries [get-session-retries]', 'Retries for "/session" request to the selenium server', 3) // getSessionRetries
-    .option('--driver-request-timeout [driver-request-timeout]', 'Timeout for any WebDriver request to the grid server', ms('90s')) // driverRequestTimeout
-    .option('--driver-request-retries [driver-request-retries]', 'Retries for any WebDriver request to the grid server', 3) // driverRequestRetries
+    .option('--get-browser-timeout [get-browser-timeout]', 'Timeout for a single attempt to get browser from the grid configured in the project\'s plan', Number) // getBrowserTimeout
+    .option('--get-browser-retries [get-browser-retries]', 'Number of attempts to get browser from the grid configured in the project\'s plan', Number) // getBrowserRetries
+    .option('--get-session-timeout [get-session-timeout]', 'Timeout for "/session" request to the selenium server', Number, ms('90s')) // getSessionTimeout
+    .option('--get-session-retries [get-session-retries]', 'Retries for "/session" request to the selenium server', Number, 3) // getSessionRetries
+    .option('--driver-request-timeout [driver-request-timeout]', 'Timeout for any WebDriver request to the grid server', Number, ms('90s')) // driverRequestTimeout
+    .option('--driver-request-retries [driver-request-retries]', 'Retries for any WebDriver request to the grid server', Number, 3) // driverRequestRetries
 
     // Run chrome ext mode locally
     .option('--use-local-chrome-driver [use-local-chrome-driver]', 'use a local ChromeDriver instance instead of a selenium grid')
@@ -510,8 +514,10 @@ module.exports = {
         try {
             let options = {};
             if (program.configFile) {
+                // eslint-disable-next-line import/no-dynamic-require
                 options = require(path.join(process.cwd(), program.configFile)).config;
             } else if (program.optionsFile) {
+                // eslint-disable-next-line import/no-dynamic-require
                 options = require(path.join(process.cwd(), program.optionsFile));
             }
 
@@ -546,19 +552,20 @@ module.exports = {
         }
 
 
-        const isTestConfigSpecified = (program.testConfig && program.testConfig.length) || (program.testConfigId && program.testConfigId.length);
-        const isTestPlanSpecified = (program.testPlan && program.testPlan.length) || (program.testPlanId && program.testPlanId.length);
-        const isSuiteSpecified = (program.suite && program.suite.length) || (program.suiteId && program.suiteId.length);
+        const isTestConfigSpecified = program.testConfig?.length || program.testConfigId?.length;
+        const isTestPlanSpecified = program.testPlan?.length || program.testPlanId?.length;
+        const isSuiteSpecified = program.suite?.length || program.suiteId?.length;
 
         if (program.seleniumCapsFile) {
             try {
+                // eslint-disable-next-line import/no-dynamic-require
                 seleniumCapsFileContent = require(path.join(process.cwd(), program.seleniumCapsFile));
             } catch (err) {
-                return Promise.reject(new ArgError(`Failed to parse selenium caps file file error: ${err.message}`));
+                throw new ArgError(`Failed to parse selenium caps file file error: ${err.message}`);
             }
         }
 
-        if (program.reporters && program.reporters.includes('junit') && !program.reportFile) {
+        if (program.reporters?.includes('junit') && !program.reportFile) {
             console.log('Warning: please define --report-file option for JUnit reporter');
         }
 
@@ -575,9 +582,10 @@ module.exports = {
         }
         if (program.chromeExtraPrefs) {
             try {
+                // eslint-disable-next-line import/no-dynamic-require
                 chromeExtraPrefs = require(path.join(process.cwd(), program.chromeExtraPrefs));
             } catch (err) {
-                return Promise.reject(new ArgError(`Failed to read/open chrome extra prefs file error: ${err.message}`));
+                throw new ArgError(`Failed to read/open chrome extra prefs file error: ${err.message}`);
             }
         }
 
@@ -598,9 +606,10 @@ module.exports = {
 
         if (program.paramsFile) {
             try {
+                // eslint-disable-next-line import/no-dynamic-require
                 userParamsData = Object.assign({}, userParamsData, require(path.join(process.cwd(), program.paramsFile)));
             } catch (err) {
-                return Promise.reject(new ArgError(`Failed to read/open params file error: ${err.message}`));
+                throw new ArgError(`Failed to read/open params file error: ${err.message}`);
             }
         }
 
@@ -608,7 +617,7 @@ module.exports = {
             try {
                 userParamsData = Object.assign({}, userParamsData, JSON.parse(program.params));
             } catch (err) {
-                return Promise.reject(new ArgError(`Failed to parse params string error: ${err.message}`));
+                throw new ArgError(`Failed to parse params string error: ${err.message}`);
             }
         }
 
@@ -627,6 +636,7 @@ module.exports = {
 
         if (program.sauceOptions) {
             try {
+                // eslint-disable-next-line import/no-dynamic-require
                 const sOptions = require(path.join(process.cwd(), program.sauceOptions));
                 const isMobile = sOptions.platformName && ['ios', 'android'].includes(sOptions.platformName.toLowerCase());
                 if (sOptions.browserName) {
@@ -649,12 +659,12 @@ module.exports = {
 
                 const isBadVersion = parseFloat(sOptions.version) < 50 && !['dev', 'beta'].includes(sOptions.version);
                 if (!isMobile && program.browser === 'chrome' && isBadVersion) {
-                    return Promise.reject(new ArgError('The minimum chrome supported version is 50.0'));
+                    throw new ArgError('The minimum chrome supported version is 50.0');
                 }
 
                 program.saucelabs = Object.assign({}, program.saucelabs, sOptions);
             } catch (err) {
-                return Promise.reject(new ArgError(`Failed to parse saucelabs options file error: ${err.message}`));
+                throw new ArgError(`Failed to parse saucelabs options file error: ${err.message}`);
             }
         }
 
@@ -672,6 +682,7 @@ module.exports = {
 
         if (program.browserstackOptions) {
             try {
+                // eslint-disable-next-line import/no-dynamic-require
                 const bsOptions = require(path.join(process.cwd(), program.browserstackOptions));
                 const isMobile = bsOptions.platform && ['mac', 'android'].includes(bsOptions.platform.toLowerCase());
                 if (bsOptions.browserName) {
@@ -683,12 +694,12 @@ module.exports = {
                 }
 
                 if (!isMobile && parseFloat(bsOptions.browser_version) < 50 && program.browser === 'chrome') {
-                    return Promise.reject(new ArgError('The minimum chrome supported version is 50.0'));
+                    throw new ArgError('The minimum chrome supported version is 50.0');
                 }
 
                 program.browserstack = Object.assign({}, program.browserstack, bsOptions);
             } catch (err) {
-                return Promise.reject(new ArgError(`Failed to parse browserstack options file error: ${err.message}`));
+                throw new ArgError(`Failed to parse browserstack options file error: ${err.message}`);
             }
         }
 
@@ -700,11 +711,12 @@ module.exports = {
 
         if (program.perfectoOptions) {
             try {
+                // eslint-disable-next-line import/no-dynamic-require
                 const perfectoOptions = require(path.join(process.cwd(), program.perfectoOptions));
                 const DEFAULTS = { location: 'US East', securityToken: program.perfectoToken };
                 program.perfecto = Object.assign({}, DEFAULTS, perfectoOptions);
             } catch (err) {
-                return Promise.reject(new ArgError(`Failed to parse perfecto options file error: ${err.message}`));
+                throw new ArgError(`Failed to parse perfecto options file error: ${err.message}`);
             }
         }
 
@@ -716,11 +728,12 @@ module.exports = {
 
         if (program.testobjectOptions) {
             try {
+                // eslint-disable-next-line import/no-dynamic-require
                 const testobjectOptions = require(path.join(process.cwd(), program.testobjectOptions));
                 const DEFAULTS = { testobjectApiKey: program.testobjectKey };
                 program.testobjectSauce = Object.assign({}, DEFAULTS, testobjectOptions);
             } catch (err) {
-                return Promise.reject(new ArgError(`Failed to parse test object options file error: ${err.message}`));
+                throw new ArgError(`Failed to parse test object options file error: ${err.message}`);
             }
         }
 
@@ -751,8 +764,8 @@ module.exports = {
         }
 
         program.retries = !program.retries || typeof program.retries === 'boolean' ? 1 : Number(program.retries) + 1;
-        program.browserTimeout = !program.browserTimeout || typeof program.browserTimeout === 'boolean' ? 60 * 1000 : Number(program.browserTimeout);
-        program.newBrowserWaitTimeout = !program.newBrowserWaitTimeout || typeof program.newBrowserWaitTimeout === 'boolean' ? 10 * 60 * 1000 : Number(program.newBrowserWaitTimeout * 60 * 1000);
+        program.browserTimeout = !program.browserTimeout || typeof program.browserTimeout === 'boolean' ? 60 * 1000 : program.browserTimeout;
+        program.newBrowserWaitTimeout = !program.newBrowserWaitTimeout || typeof program.newBrowserWaitTimeout === 'boolean' ? 10 * 60 * 1000 : program.newBrowserWaitTimeout * 60 * 1000;
 
         if (!program.getBrowserTimeout) {
             program.getBrowserTimeout = program.browserTimeout;
@@ -764,7 +777,7 @@ module.exports = {
         program.driverRequestTimeout = program.browserTimeout < program.driverRequestTimeout ? program.driverRequestTimeout : program.browserTimeout;
 
         const timeoutWasGiven = Boolean(program.timeout);
-        program.timeout = !program.timeout || typeof program.timeout === 'boolean' ? 10 * 60 * 1000 : Number(program.timeout);
+        program.timeout = !program.timeout || typeof program.timeout === 'boolean' ? 10 * 60 * 1000 : program.timeout;
         program.beforeParallel = !program.beforeParallel || typeof program.beforeParallel === 'boolean' ? 1 : Number(program.beforeParallel);
         program.parallel = !program.parallel || typeof program.parallel === 'boolean' ? 1 : Number(program.parallel);
         program.afterParallel = !program.afterParallel || typeof program.afterParallel === 'boolean' ? 1 : Number(program.afterParallel);
@@ -791,7 +804,7 @@ module.exports = {
 
         program.port = program.port && Number(program.port);
 
-        if (program.retries <= 0 || _.isNaN(program.retries)) {
+        if (program.retries <= 0 || Number.isNaN(program.retries)) {
             throw new ArgError('test failure retry count could not be a negative number or string, --retries <max_num_of_retries>');
         }
 
@@ -810,27 +823,27 @@ module.exports = {
             }
         }
 
-        if (program.browserTimeout <= 0 || _.isNaN(program.browserTimeout)) {
+        if (program.browserTimeout <= 0 || Number.isNaN(program.browserTimeout)) {
             throw new ArgError('get browser timeout could not be a negative number, --browser-timeout <get-browser-timeout>');
         }
 
-        if (program.newBrowserWaitTimeout <= 0 || _.isNaN(program.newBrowserWaitTimeout)) {
+        if (program.newBrowserWaitTimeout <= 0 || Number.isNaN(program.newBrowserWaitTimeout)) {
             throw new ArgError('max new browser wait timeout could not be a negative number, --new-browser-wait-timeout <max-wait-to-browser>');
         }
 
-        if (program.timeout <= 0 || _.isNaN(program.timeout)) {
+        if (program.timeout <= 0 || Number.isNaN(program.timeout)) {
             throw new ArgError('test run timeout could not be a negative number, --timeout <run-timeout>');
         }
 
-        if (program.beforeParallel <= 0 || _.isNaN(program.beforeParallel)) {
+        if (program.beforeParallel <= 0 || Number.isNaN(program.beforeParallel)) {
             throw new ArgError('before-parallel could not be a negative number or not number, --before-parallel <number-of-tests>');
         }
 
-        if (program.parallel <= 0 || _.isNaN(program.parallel)) {
+        if (program.parallel <= 0 || Number.isNaN(program.parallel)) {
             throw new ArgError('parallel could not be a negative number or not number, --parallel <number-of-tests>');
         }
 
-        if (program.afterParallel <= 0 || _.isNaN(program.afterParallel)) {
+        if (program.afterParallel <= 0 || Number.isNaN(program.afterParallel)) {
             throw new ArgError('after-parallel could not be a negative number or not number, --after-parallel <number-of-tests>');
         }
 
@@ -901,7 +914,7 @@ module.exports = {
             throw new ArgError('please define exactly one of --grid or --grid-id or --host');
         }
 
-        if (program.host && program.host.includes('/')) {
+        if (program.host?.includes('/')) {
             if (!/^(f|ht)tps?:\/\//i.test(program.host)) {
                 program.host = `http://${program.host}`;
             }
@@ -1009,7 +1022,7 @@ module.exports = {
                 const fileContent = fs.readFileSync(program.tmsFieldFile);
                 program.tmsCustomFields = JSON.parse(fileContent);
             } catch (err) {
-                return Promise.reject(new ArgError(`failed to parse field file error: ${err.message}`));
+                throw new ArgError(`failed to parse field file error: ${err.message}`);
             }
         }
 
@@ -1046,7 +1059,7 @@ module.exports = {
                 const lightweightModeOptions = typeof program.lightweightMode === 'string' ? JSON.parse(program.lightweightMode) : {};
                 program.lightweightMode = Object.assign({}, DEFAULTS, lightweightModeOptions);
             } catch (err) {
-                return Promise.reject(new ArgError(`failed to parse lightweightMode settings error: ${err.message}`));
+                throw new ArgError(`failed to parse lightweightMode settings error: ${err.message}`);
             }
         } else if (program.turboMode && program.mode === CLI_MODE.EXTENSION) {
             program.lightweightMode = {
@@ -1179,6 +1192,8 @@ module.exports = {
             driverRequestTimeout: program.driverRequestTimeout,
             driverRequestRetries: program.driverRequestRetries,
 
+            testStartTimeout: program.testStartTimeout,
+
             testConfigNames: program.testConfig,
             testConfigIds: program.testConfigId,
 

package/runner.js

@@ -1,32 +1,34 @@
 'use strict';
 
 /* eslint-disable no-console */
-const { CLI_MODE } = require('./commons/constants');
 const _ = require('lodash');
-const { EDITOR_URL } = require('./commons/config');
-const tunnel = require('./commons/testimTunnel');
 const utils = require('./utils');
 const reporter = require('./reports/reporter');
-const testimCustomToken = require('./commons/testimCustomToken');
-const socketService = require('./commons/socket/socketService');
-const servicesApi = require('./commons/testimServicesApi.js');
-const npmDriver = require('./testimNpmDriver.js');
+const npmDriver = require('./testimNpmDriver');
+const tunnel = require('./commons/testimTunnel');
+const perf = require('./commons/performance-logger');
+const gridService = require('./services/gridService');
 const analytics = require('./commons/testimAnalytics');
+const featureFlags = require('./commons/featureFlags');
 const branchService = require('./services/branchService');
-const gridService = require('./services/gridService');
+const servicesApi = require('./commons/testimServicesApi');
+const TestPlanRunner = require('./runners/TestPlanRunner');
+const socketService = require('./commons/socket/socketService');
+const testimCustomToken = require('./commons/testimCustomToken');
+const labFeaturesService = require('./services/labFeaturesService');
+const featureAvailabilityService = require('./commons/featureAvailabilityService');
+const { getLogger } = require('./commons/logger');
+const { EDITOR_URL } = require('./commons/config');
+const { CLI_MODE } = require('./commons/constants');
 const { ArgError, QuotaDepletedError } = require('./errors');
-const featureFlags = require('./commons/featureFlags');
-const perf = require('./commons/performance-logger');
 const { prepareMockNetwork, initializeUserWithAuth } = require('./commons/prepareRunner');
 
 const FREE_PLAN_MINIMUM_BROWSER_TIMEOUT = 30 * 60 * 1000;
 
-const TestPlanRunner = require('./runners/TestPlanRunner');
-const labFeaturesService = require('./services/labFeaturesService');
-const featureAvailabilityService = require('./commons/featureAvailabilityService');
 
-const logger = require('./commons/logger').getLogger('runner');
+const logger = getLogger('runner');
 
+/** @param {import('./runOptions').RunnerOptions} options */
 function validateCLIRunsAreAllowed(options) {
     const hasCliAccess = _.get(options, 'company.activePlan.premiumFeatures.allowCLI');
 
@@ -34,14 +36,16 @@ function validateCLIRunsAreAllowed(options) {
         const projectId = options.project;
         analytics.track(options.authData.uid, 'cli-not-supported', { projectId });
         console.warn('Testim CLI is not supported in this plan');
+        // TODO: shouldn't this throw an error? 🤔
     }
 }
 
+/** @param {import('./runOptions').RunnerOptions} options */
 async function validateProjectQuotaNotDepleted(options) {
     const projectId = options.project;
 
     const usage = await servicesApi.getUsageForCurrentBillingPeriod(projectId);
-    const isExecutionBlocked = usage && usage.isExecutionBlocked;
+    const isExecutionBlocked = usage?.isExecutionBlocked;
     if (!isExecutionBlocked) {
         return;
     }
@@ -51,6 +55,10 @@ async function validateProjectQuotaNotDepleted(options) {
     throw new QuotaDepletedError();
 }
 
+/**
+ * @param {import('./runOptions').RunnerOptions} options
+ * @param {Awaited<ReturnType<initializeUserWithAuth>>['companyByProjectId']} company
+ */
 function validateOptionsForCompany(options, company) {
     const optionsRetention = options.retentionDays;
     if (!optionsRetention) {
@@ -63,8 +71,9 @@ function validateOptionsForCompany(options, company) {
     }
 }
 
+/** @param {import('./runOptions').RunnerOptions} options */
 async function validateCliAccount(options) {
-    if (options.lightweightMode && options.lightweightMode.disableQuotaBlocking) {
+    if (options.lightweightMode?.disableQuotaBlocking) {
         return;
     }
     try {
@@ -73,13 +82,14 @@ async function validateCliAccount(options) {
             validateCLIRunsAreAllowed(options),
         ]);
     } catch (err) {
-        if (err instanceof ArgError || err instanceof QuotaDepletedError) {
+        if ([ArgError, QuotaDepletedError].some(errType => err instanceof errType)) {
             throw err;
         }
         logger.error('could not validate cli account', { err });
     }
 }
 
+/** @param {string} projectId */
 function analyticsIdentify(projectId) {
     const authData = testimCustomToken.getTokenV3UserData();
     return analytics.identify({
@@ -95,6 +105,7 @@ function analyticsIdentify(projectId) {
     });
 }
 
+/** @param {string} projectId */
 function initSocketServices(projectId, { disableResults = false, disableRemoteStep = false }) {
     if (featureFlags.flags.useNewWSCLI.isEnabled() && !disableResults && !disableRemoteStep) {
         return socketService.connect(projectId);
@@ -110,6 +121,10 @@ function initSocketServices(projectId, { disableResults = false, disableRemoteSt
     return undefined;
 }
 
+/**
+ * @param {import('./runOptions').RunnerOptions} options
+ * @param {Awaited<ReturnType<initializeUserWithAuth>>['branchName']} branchInfoFromServer
+ */
 function setBranch(options, branchInfoFromServer) {
     const { branch, autoDetect } = options;
     branchService.setCurrentBranch(branchInfoFromServer, autoDetect);
@@ -118,14 +133,19 @@ function setBranch(options, branchInfoFromServer) {
     }
 }
 
+/** @param {import('./runOptions').RunnerOptions} options */
 async function setSfdcCredential(options) {
-    const { projectData: { projectId } } = options;
+    const { projectData: { projectId } = {} } = options;
     const branch = branchService.getCurrentBranch();
     if (_.get(options, 'company.activePlan.premiumFeatures.ttaForSalesforce')) {
         options.sfdcCredential = await servicesApi.loadSfdcCredential({ projectId, branch });
     }
 }
 
+/**
+ * @param {import('./runOptions').RunnerOptions} options
+ * @param {Awaited<ReturnType<initializeUserWithAuth>>['companyByProjectId']} company
+ */
 function setCompany(options, company) {
     const { onprem, id, storageBaseUrl, storageType, name, activePlan = {} } = company;
     if (onprem) {
@@ -161,6 +181,10 @@ function setCompany(options, company) {
     };
 }
 
+/**
+ * @param {import('./runOptions').RunnerOptions} options
+ * @param {Awaited<ReturnType<initializeUserWithAuth>>['editorConfig']} editorConfig
+ */
 function setSystemInfo(options, editorConfig) {
     if (EDITOR_URL) {
         options.editorUrl = EDITOR_URL;
@@ -169,17 +193,30 @@ function setSystemInfo(options, editorConfig) {
     options.editorUrl = editorConfig.editorUrl;
 }
 
+/**
+ * @param {import('./runOptions').RunnerOptions} options
+ * @param {Awaited<ReturnType<initializeUserWithAuth>>['allGrids']} allGrids
+ */
 function setAllGrids(options, allGrids) {
     options.allGrids = allGrids;
 }
 
+/**
+ * @param {import('./runOptions').RunnerOptions} options
+ * @param {Awaited<ReturnType<initializeUserWithAuth>>['authData']} authData
+ */
 function setAuthData(options, authData) {
     options.authData = authData;
 }
 
+/**
+ * @param {import('./runOptions').RunnerOptions} options
+ * @param {Awaited<ReturnType<initializeUserWithAuth>>['projectById']} project
+ */
 function setProject(options, project) {
     const { id, name, type, defaults } = project;
     featureFlags.setProjectId(id);
+    featureFlags.setProjectType(type);
     options.projectData = {
         projectId: id,
         type,
@@ -188,10 +225,12 @@ function setProject(options, project) {
     };
 }
 
+/** @param {import('./runOptions').RunnerOptions} options */
 async function setGrid(options) {
     options.gridData = await gridService.getGridData(options);
 }
 
+/** @param {import('./runOptions').RunnerOptions} options */
 async function setMockNetworkRules(options) {
     const { project } = options;
     const props = { projectId: project };
@@ -203,7 +242,7 @@ async function setMockNetworkRules(options) {
 }
 
 /**
- * @param {Awaited<ReturnType<typeof import('./runOptions')['process']>>} options
+ * @param {import('./runOptions').RunnerOptions} options
  * @param {string=} customExtensionLocalLocation
  */
 async function runRunner(options, customExtensionLocalLocation) {
@@ -235,8 +274,9 @@ async function runRunner(options, customExtensionLocalLocation) {
     return results;
 }
 
+/** @param {import('./runOptions').RunnerOptions} options */
 function showFreeGridRunWarningIfNeeded(options) {
-    if (featureAvailabilityService.shouldShowFreeGridRunWarning(options.gridData && options.gridData.type)) {
+    if (featureAvailabilityService.shouldShowFreeGridRunWarning(options.gridData?.type)) {
         const CYAN = '\x1b[36m';
         const UNDERSCORE = '\x1b[4m';
         const RESET = '\x1b[0m';
@@ -251,15 +291,15 @@ function showFreeGridRunWarningIfNeeded(options) {
  * - Reporting the user to analytics
  * - Authenticating the user and exchanging their token for a jwt
  * - Sets the grids for the company and validates the user has permission to run the CLI
- * @param {Object} options - the run options passed to the CLI, namely the project and token
+ * @param {import('./runOptions').RunnerOptions} options - the run options passed to the CLI, namely the project and token
  */
 async function init(options) {
     perf.log('start runner init');
     const { project, lightweightMode, useChromeLauncher, mode, disableSockets } = options;
     const featureFlagsReady = featureFlags.fetch();
     const socketConnected = initSocketServices(project, {
-        disableResults: disableSockets || Boolean(lightweightMode && lightweightMode.disableResults && (useChromeLauncher || mode !== 'extension')),
-        disableRemoteStep: disableSockets || Boolean(lightweightMode && lightweightMode.disableRemoteStep),
+        disableResults: disableSockets || Boolean(lightweightMode?.disableResults && (useChromeLauncher || mode !== 'extension')),
+        disableRemoteStep: disableSockets || Boolean(lightweightMode?.disableRemoteStep),
     });
 
     featureFlagsReady.catch(() => {}); // suppress unhandled rejection
@@ -279,7 +319,7 @@ async function init(options) {
     setAuthData(options, authData);
     await setSfdcCredential(options);
 
-    if (!(options.lightweightMode && options.lightweightMode.disableLabs)) {
+    if (!options.lightweightMode?.disableLabs) {
         await labFeaturesService.loadLabFeatures(projectById.id, companyByProjectId.activePlan);
     }
 

package/runners/ParallelWorkerManager.js

@@ -54,20 +54,21 @@ class ParallelWorkerManager {
 
         let stoppedOnError = false;
         let runningTests = 0;
-        const runAndWaitToComplete = token => new Promise((resolve, reject) => {
+        const runAndWaitToComplete = token => new Promise((resolve) => {
             const projectId = options.project;
             const executionQueue = new ExecutionQueue(executionId, executionName, testList, options, branchToUse, testStatus);
 
+            /** @type {{ [testResultId: string]: any; }} */
             const combinedTestResults = {};
             const testCount = testList.length;
 
-            const companyId = options.company && options.company.companyId;
-            const companyName = options.company && options.company.name;
+            const companyId = options.company?.companyId;
+            const companyName = options.company?.name;
             const source = options.source || 'cli';
             const user = options.user;
-            const companyPlan = options.company && options.company.planType;
-            const isStartUp = options.company && options.company.isStartUp;
-            const projectName = options.projectData && options.projectData.name;
+            const companyPlan = options.company?.planType;
+            const isStartUp = options.company?.isStartUp;
+            const projectName = options.projectData?.name;
             const lightweightMode = options.lightweightMode;
             const sessionType = utils.getSessionType(options);
 
@@ -95,7 +96,7 @@ class ParallelWorkerManager {
             const onTestCompleted = async (wid, testId, testResult, sessionId, isRerun) => {
                 runningTests--;
                 const update = {};
-                if (lightweightMode && lightweightMode.onlyTestIdsNoSuite) {
+                if (lightweightMode?.onlyTestIdsNoSuite) {
                     update.show = true;
                 }
                 if (testResult.seleniumStats) {
@@ -115,9 +116,9 @@ class ParallelWorkerManager {
                     update.gridHost = options.host;
                 }
                 if (options.grid || options.gridId) {
-                    update.gridName = options.grid || (options.gridData && options.gridData.name);
-                    update.gridType = options.gridData && options.gridData.type;
-                    update.gridProvider = options.gridData && options.gridData.provider;
+                    update.gridName = options.grid || options.gridData?.name;
+                    update.gridType = options.gridData?.type;
+                    update.gridProvider = options.gridData?.provider;
                 } else if (options.useLocalChromeDriver) {
                     update.gridName = 'local-chrome-driver-from-options';
                     update.gridType = 'local-chrome';
@@ -177,7 +178,7 @@ class ParallelWorkerManager {
                 }
             };
 
-            const onGridSlot = (executionId, resultId, gridInfo) => testStatus.onGridSlot(executionId, resultId, gridInfo);
+            const onGridSlot = (_executionId, resultId, gridInfo) => testStatus.onGridSlot(_executionId, resultId, gridInfo);
 
             options.userData = {
                 loginData: Object.assign({}, testimCustomToken.getTokenV3UserData(), {
@@ -214,7 +215,6 @@ class ParallelWorkerManager {
     }
 }
 
-
 function schedule(fn, index) {
     if (index === 0) {
         fn();