@testim/testim-cli 3.253.0 → 3.254.0

package/commons/detectDebugger.js

@@ -1,4 +1,5 @@
-"use strict";
+'use strict';
+
 const { DISABLE_DEBUGGER_INFINITE_TIMEOUT } = require('./config');
 
 module.exports.isDebuggerConnected = () => {
@@ -12,6 +13,7 @@ module.exports.isDebuggerConnected = () => {
             return true;
         }
     } catch (e) {
-        return false;
+        /* empty */
     }
+    return false;
 };

package/commons/lazyRequire.js

@@ -1,13 +1,14 @@
-"use strict";
+'use strict';
 
 const Bluebird = require('bluebird');
 const npmWrapper = require('./npmWrapper');
 const ora = require('ora');
 const path = require('path');
-const logger = require('./logger').getLogger("lazy-require");
+const logger = require('./logger').getLogger('lazy-require');
 const { getCliLocation } = require('../utils');
-const { requireWithFallback } = require("./requireWithFallback")
+const { requireWithFallback } = require('./requireWithFallback');
 
+// eslint-disable-next-line import/no-dynamic-require
 const packageJson = require(path.resolve(getCliLocation(), 'package.json'));
 const ongoingCalls = new Map();
 
@@ -29,14 +30,14 @@ module.exports = async function memoizedLazyRequireApi(dependency, options = {})
         }
         return requiredModule;
     } catch (error) {
-        logger.warn("failed to install dependency lazily", {dependency, err: error});
+        logger.warn('failed to install dependency lazily', { dependency, err: error });
         const depVersionToInstall = getVersionOfLazyDep(dependency);
         const depWithVersions = `${dependency}@${depVersionToInstall}`;
 
         const removeGlobal = process.argv.includes('npx');
-        const globalFlag = removeGlobal ? '' : '-g '
+        const globalFlag = removeGlobal ? '' : '-g ';
         const errorMessage = `Installation of ${dependency} failed. This typically means you are running an out-of-date version of Node.js or NPM.` +
-        `Please manually install by running the following command: npm install ${globalFlag}${depWithVersions}`
+        `Please manually install by running the following command: npm install ${globalFlag}${depWithVersions}`;
 
         if (spinner) {
             spinner.fail(errorMessage);
@@ -52,12 +53,12 @@ async function memoizedLazyRequire(identifier, options = {}) {
     }
 
     ongoingCalls.set(identifier, lazyRequireImpl(identifier, options));
-    ongoingCalls.get(identifier).catch(err => {
+    ongoingCalls.get(identifier).catch(() => {
         ongoingCalls.delete(identifier);
     });
 
     return ongoingCalls.get(identifier);
-};
+}
 
 async function lazyRequireImpl(dependency) {
     const packageLocally = npmWrapper.getPackageIfInstalledLocally(dependency);
@@ -94,7 +95,7 @@ function getVersionOfLazyDep(dependencyToFind) {
         .find(([dep]) => dep === dependencyToFind);
 
     if (!depEntry) {
-        throw new Error("The given package name is not lazyDependencies");
+        throw new Error('The given package name is not lazyDependencies');
     }
 
     return depEntry[1];

package/commons/logger.js

@@ -53,7 +53,7 @@ function getStreamsAndWaitForFlushPromise() {
 const [transports, waitForFlush] = getStreamsAndWaitForFlushPromise();
 const level = config.LOGGER_DEBUG ? 'debug' : 'info';
 const defaultMeta = {};
-if (isLocal.indexOf('@echo') === -1) {
+if (!isLocal.includes('@echo')) {
     Object.assign(defaultMeta, devFlags());
 
 } else {
@@ -149,13 +149,13 @@ class Logger {
         this.innerLog('crit', msg, data);
     }
 
-    innerLog(level, msg, data = {}) {
+    innerLog(logLevel, msg, data = {}) {
         try {
-            this._logger.log(level, Object.assign({ meta: data }, { message: msg }, addExecutionMetadata(data.executionId)));
+            this._logger.log(logLevel, Object.assign({ meta: data }, { message: msg }, addExecutionMetadata(data.executionId)));
         } catch (err) {
             try {
                 this._logger.log('crit', Object.assign({ message: `failed to log message ${err.message}, ${err.stack}` }, addExecutionMetadata(data.executionId)));
-            } catch (err) {
+            } catch (_err) {
                 // well what can we do
             }
         }

package/commons/performance-logger.js

@@ -1,7 +1,9 @@
-"use strict";
+/* eslint-disable no-console */
+
+'use strict';
 
 const MEASURE_TESTIM_CLI_PERFORMANCE = process.env.MEASURE_TESTIM_CLI_PERFORMANCE;
-let epoch = Date.now();
+const epoch = Date.now();
 let last = Date.now();
 
 module.exports = {
@@ -9,7 +11,7 @@ module.exports = {
         if (!MEASURE_TESTIM_CLI_PERFORMANCE) {
             return;
         }
-        let time = Date.now();
+        const time = Date.now();
         console.log(`${time - epoch}\t\t\t${time - last}\t\t\t`, ...args);
         last = time;
     },
@@ -25,7 +27,9 @@ module.exports = {
         }
     },
     patchPromisePrototype() {
-        Promise.prototype.log = function log (message) {
+        // TODO: Stop monkey patching shit
+        // eslint-disable-next-line no-extend-native
+        Promise.prototype.log = function log(message) {
             if (!MEASURE_TESTIM_CLI_PERFORMANCE) {
                 return this;
             }
@@ -40,7 +44,7 @@ module.exports = {
                 return this;
             }
             return this.tap(() => module.exports.log(message));
-        }
+        };
     },
     measureRequireTimes() {
         if (!MEASURE_TESTIM_CLI_PERFORMANCE) {
@@ -48,12 +52,14 @@ module.exports = {
         }
         const {
             performance,
-            PerformanceObserver
+            PerformanceObserver,
         } = require('perf_hooks');
         const mod = require('module');
 
         // Monkey patch the require function
         mod.Module.prototype.require = performance.timerify(mod.Module.prototype.require);
+        // TODO: Stop monkey patching shit
+        // eslint-disable-next-line no-global-assign
         require = performance.timerify(require);
 
         // Activate the observer
@@ -65,8 +71,8 @@ module.exports = {
             obs.disconnect();
         });
         obs.observe({ entryTypes: ['function'], buffered: true });
-    }
-}
+    },
+};
 
 // ew ~ Benji
 module.exports.patchPromisePrototype();

package/commons/prepareRunnerAndTestimStartUtils.js

@@ -3,7 +3,6 @@
 // @ts-ignore
 const Promise = require('bluebird');
 const path = require('path');
-const os = require('os');
 const fs = Promise.promisifyAll(require('fs'));
 const ms = require('ms');
 const { serializeError } = require('serialize-error');
@@ -42,11 +41,11 @@ function prepareCustomExtension(location, unlimitedSize = false) {
         return getRemoteFileSizeInMB(location)
             .then(contentLength => {
                 if (contentLength > MAX_CUSTOM_EXT_SIZE_MB && !unlimitedSize) {
-                    return Promise.reject(new ArgError(MAX_CUSTOM_SIZE_ERROR_MSG));
+                    throw new ArgError(MAX_CUSTOM_SIZE_ERROR_MSG);
                 }
                 return downloadAndSave(location, destFile);
             })
-            .then(() => Promise.resolve(destFile));
+            .then(() => destFile);
     }
 
     const destFile = path.resolve(location);
@@ -70,11 +69,11 @@ function getRemoteFileSizeInMB(url) {
         .then(res => {
             const contentLengthHeader = res.headers['content-length'];
             const contentLengthBytes = contentLengthHeader ? parseInt(contentLengthHeader, 10) : 0;
-            return Promise.resolve(contentLengthBytes / 1000000);
+            return contentLengthBytes / 1000000;
         })
         .catch(err => {
             logger.warn('failed to download custom extension', { err });
-            return Promise.reject(new ArgError(`Failed to download custom extension from location: ${url}`));
+            throw new ArgError(`Failed to download custom extension from location: ${url}`);
         });
 }
 
@@ -135,7 +134,7 @@ async function prepareChromeDriver(userDetails = {}, driverOptions = {}, skipIsR
 function getPlayerVersion() {
     const url = `${config.BLOB_URL}/extension/sessionPlayer_LATEST_RELEASE`;
     return download(url)
-        .then(res => Promise.resolve(res.body.toString('utf8')));
+        .then(res => res.body.toString('utf8'));
 }
 
 /**
@@ -150,7 +149,7 @@ function getPlayerLocation(location, canary) {
     }
 
     return getPlayerVersion()
-        .then(ver => Promise.resolve(`${location}-${ver}`));
+        .then(ver => `${location}-${ver}`);
 }
 
 function getSessionPlayerFolder() {

package/commons/socket/baseSocketServiceSocketIO.js

@@ -1,4 +1,4 @@
-"use strict";
+'use strict';
 
 const Promise = require('bluebird');
 const pRetry = require('p-retry');
@@ -10,22 +10,21 @@ const MAX_RECONNECT_ATTEMPT_BEFORE_SWITCH = 10;
 const EMIT_PROMISE_TIMEOUT = 5000;
 const POLLING_TRANSPORT_TIMEOUT_MS = 10 * 1000;
 
-const logger = require('../logger').getLogger("base socket service");
+const logger = require('../logger').getLogger('base socket service');
 
 class BaseSocketServiceSocketIO {
-
     constructor() {
         this.attempts = 0;
         this.rooms = {};
-        this.emitPromisQueue = undefined;
+        this.emitPromiseQueue = undefined;
     }
 
     joinToMultipleResults() {
         const testResultIds = Object.keys(this.rooms);
-        logger.info("re-join all existing rooms", {testResultIds});
-        testResultIds.map(resultId => {
+        logger.info('re-join all existing rooms', { testResultIds });
+        testResultIds.forEach(resultId => {
             const testId = this.rooms[resultId];
-            this.emitJoinRoom && this.emitJoinRoom(resultId, testId);
+            this.emitJoinRoom?.(resultId, testId);
         });
     }
 
@@ -43,20 +42,22 @@ class BaseSocketServiceSocketIO {
             try {
                 transport = this._socket.io.engine.transport.name;
             } catch (e) {
+                /* empty */
             }
-            logger.error(`Error in SocketService websocket _${method}_ socket ${this._socket.id} is ${this.url} over ${transport}. Reconnect attempts ${this.attempts}. Error is: ${err && err.message}`);
+            logger.error(`Error in SocketService websocket _${method}_ socket ${this._socket.id} ` +
+            `is ${this.url} over ${transport}. Reconnect attempts ${this.attempts}. Error is: ${err?.message}`);
         };
 
         this._socket.on('reconnect_attempt', (attempt) => {
-            socketError('reconnect_attempt', {message: 'reconnect attempt', attempt});
+            socketError('reconnect_attempt', { message: 'reconnect attempt', attempt });
             this.attempts++;
             if (this.attempts === MAX_RECONNECT_ATTEMPT_BEFORE_SWITCH && !this.isAllowedWS) {
                 this._socket.io.opts.transports = ['polling'];
                 this._socket.io.opts.upgrade = false;
             }
             if (this.attempts >= MAX_SOCKET_RECONNECT_ATTEMPT) {
-                throw new Error("Can't connect to Testim Servers.\n" +
-                    "Action required: Please allow opening a websockets connection to " + config.SERVICES_HOST + " in your firewall/proxy");
+                throw new Error('Can\'t connect to Testim Servers.\n' +
+                    `Action required: Please allow opening a websockets connection to ${config.SERVICES_HOST} in your firewall/proxy`);
             }
         });
 
@@ -81,14 +82,14 @@ class BaseSocketServiceSocketIO {
         });
 
         this._socket.on('reconnect', () => {
-            logger.info(`reconnect to socket and re-join to rooms`);
+            logger.info('reconnect to socket and re-join to rooms');
             this.joinToMultipleResults();
         });
 
         this._socket.on('connect', () => {
             this.attempts = 0;
-            if(this.isAllowedWS === undefined) {
-                this.isAllowedWS = this._socket.io.engine.transport && this._socket.io.engine.transport.name === "websocket";
+            if (this.isAllowedWS === undefined) {
+                this.isAllowedWS = this._socket.io.engine.transport && this._socket.io.engine.transport.name === 'websocket';
             }
             if (this.onConnect) {
                 this.onConnect();
@@ -98,7 +99,7 @@ class BaseSocketServiceSocketIO {
 
     initNewSocket(projectId, ns) {
         const opts = {
-            query: {'projectId': projectId},
+            query: { projectId },
             requestTimeout: POLLING_TRANSPORT_TIMEOUT_MS,
             transports: ['websocket'],
             upgrade: false,
@@ -125,7 +126,7 @@ class BaseSocketServiceSocketIO {
 
     init(projectId, ns) {
         const opts = {
-            query: {'projectId': projectId},
+            query: { projectId },
             requestTimeout: POLLING_TRANSPORT_TIMEOUT_MS,
             transports: ['websocket'],
             upgrade: false,
@@ -136,7 +137,7 @@ class BaseSocketServiceSocketIO {
             opts.ca = global.caFileContent;
         }
 
-        if(global.proxyUri) {
+        if (global.proxyUri) {
             opts.agent = new global.ProxyAgent(global.proxyUri);
         }
 
@@ -146,23 +147,20 @@ class BaseSocketServiceSocketIO {
     }
 
     emitPromise(eventName, eventData) {
-        let errorneousEvents = {};
-
-        const emitAndWait = () => {
-            return new Promise((resolve, reject) => {
-                this._socket.emit(eventName, eventData, data => {
-                    if (data && data.success) {
-                        return resolve();
-                    } else {
-                        errorneousEvents[eventName] = eventData;
-
-                        return reject(new Error("bad ack"));
-                    }
-                });
-            }).timeout(EMIT_PROMISE_TIMEOUT);
-        };
+        const errorneousEvents = {};
+
+        const emitAndWait = () => new Promise((resolve, reject) => {
+            this._socket.emit(eventName, eventData, data => {
+                if (data?.success) {
+                    return resolve();
+                }
+                errorneousEvents[eventName] = eventData;
+
+                return reject(new Error('bad ack'));
+            });
+        }).timeout(EMIT_PROMISE_TIMEOUT);
 
-        this.emitPromisQueue = (this.emitPromisQueue || Promise.resolve())
+        this.emitPromiseQueue = (this.emitPromiseQueue || Promise.resolve())
             .then(() => pRetry(emitAndWait, { retries: 200, minTimeout: 3000 }))
             .finally(() => {
                 if (Object.keys(errorneousEvents).length > 0) {
@@ -170,7 +168,7 @@ class BaseSocketServiceSocketIO {
                 }
             });
 
-        return this.emitPromisQueue;
+        return this.emitPromiseQueue;
     }
 }
 

package/commons/socket/realDataService.js

@@ -1,12 +1,12 @@
-"use strict";
+'use strict';
 
 const RealDataServiceSocketIO = require('./realDataServiceSocketIO');
 const socketService = require('./socketService');
 
-const {socketEventTypes} = require('../constants');
+const { socketEventTypes } = require('../constants');
 const featureFlags = require('../featureFlags');
 
-const {TEST_RESULT_CREATED, TEST_RESULT_UPDATED} = socketEventTypes;
+const { TEST_RESULT_CREATED, TEST_RESULT_UPDATED } = socketEventTypes;
 
 class RealDataService {
     constructor() {
@@ -25,12 +25,13 @@ class RealDataService {
 
     joinToTestResultsByRunId(runId, projectId) {
         if (featureFlags.flags.useNewWSCLI.isEnabled()) {
-            return socketService.addFilter(runId, {runId}, [
+            return socketService.addFilter(runId, { runId }, [
                 TEST_RESULT_UPDATED,
-                TEST_RESULT_CREATED
+                TEST_RESULT_CREATED,
             ], true);
         }
         this.realDataServiceSocketIO.joinToTestResultsByRunId(runId, projectId);
+        return undefined;
     }
 
     stopListenToTestResultsByRunId(runId) {

package/commons/socket/realDataServiceSocketIO.js

@@ -1,4 +1,4 @@
-"use strict";
+'use strict';
 
 const BaseSocketService = require('./baseSocketServiceSocketIO');
 
@@ -8,7 +8,7 @@ class RealDataServiceSocketIO extends BaseSocketService {
     }
 
     emitJoinRoom(runId, projectId) {
-        this._socket.emit("testResult:listen", {query: `projectId=${projectId}&runId=${runId}`});
+        this._socket.emit('testResult:listen', { query: `projectId=${projectId}&runId=${runId}` });
     }
 
     joinToTestResultsByRunId(runId, projectId) {
@@ -18,7 +18,7 @@ class RealDataServiceSocketIO extends BaseSocketService {
 
     stopListenToTestResultsByRunId(runId) {
         this.leaveRoom(runId);
-        this._socket.emit("testResult:listen:stop", {});
+        this._socket.emit('testResult:listen:stop', {});
     }
 
     listenToTestResultsByRunId(cb) {
@@ -26,7 +26,7 @@ class RealDataServiceSocketIO extends BaseSocketService {
             cb(data.data);
         }
 
-        this._socket.on("testResult:changes", onDone.bind(this));
+        this._socket.on('testResult:changes', onDone.bind(this));
     }
 }
 

package/commons/socket/remoteStepService.js

@@ -1,8 +1,9 @@
 let remoteStepServiceSocketIO; // required lazily since it takes 150ms to load
 const socketService = require('./socketService');
 
-const {socketEventTypes} = require('../constants');
-const {REMOTE_STEP_SAVED} = socketEventTypes;
+const { socketEventTypes } = require('../constants');
+
+const { REMOTE_STEP_SAVED } = socketEventTypes;
 const featureFlags = require('../featureFlags');
 const Promise = require('bluebird');
 
@@ -17,7 +18,7 @@ class RemoteStepService {
 
     joinToRemoteStep(resultId) {
         if (featureFlags.flags.useNewWSCLI.isEnabled()) {
-            return socketService.addFilter(`${resultId}:remoteStep`, {resultId}, [REMOTE_STEP_SAVED]);
+            return socketService.addFilter(`${resultId}:remoteStep`, { resultId }, [REMOTE_STEP_SAVED]);
         }
         return remoteStepServiceSocketIO.joinToRemoteStep(resultId);
     }

package/commons/socket/remoteStepServiceSocketIO.js

@@ -1,4 +1,4 @@
-"use strict";
+'use strict';
 
 const Promise = require('bluebird');
 const BaseSocketService = require('./baseSocketServiceSocketIO');
@@ -10,15 +10,15 @@ class RemoteStepServiceSocketIO extends BaseSocketService {
     }
 
     emitJoinRoom(resultId) {
-        return this.emitPromise("remoteStep:join", {resultId});
+        return this.emitPromise('remoteStep:join', { resultId });
     }
 
     emitLeaveRoom(resultId) {
-        return this.emitPromise("remoteStep:leave", {resultId});
+        return this.emitPromise('remoteStep:leave', { resultId });
     }
 
     joinToRemoteStep(resultId) {
-        if(this.rooms[resultId]) {
+        if (this.rooms[resultId]) {
             return Promise.resolve();
         }
         this.joinRoom(resultId);
@@ -26,17 +26,16 @@ class RemoteStepServiceSocketIO extends BaseSocketService {
     }
 
     saveRemoteStep(resultId, stepId, remoteStep) {
-        return this.emitPromise("remoteStep:save", {
+        return this.emitPromise('remoteStep:save', {
             resultId,
             stepId,
-            remoteStep
+            remoteStep,
         });
     }
 
     listenToRemoteStep(resultId, onRemoteStep) {
-
-        if(this.listerers[resultId]) {
-            this._socket.off("remoteStep:saved", this.listerers[resultId]);
+        if (this.listerers[resultId]) {
+            this._socket.off('remoteStep:saved', this.listerers[resultId]);
             delete this.listerers[resultId];
         }
 
@@ -45,16 +44,16 @@ class RemoteStepServiceSocketIO extends BaseSocketService {
                 onRemoteStep(data.remoteStep);
             }
         };
-        this._socket.on("remoteStep:saved", this.listerers[resultId]);
+        this._socket.on('remoteStep:saved', this.listerers[resultId]);
     }
 
     unlistenToRemoteStep(resultId) {
-        if(!this.listerers[resultId]) {
+        if (!this.listerers[resultId]) {
             return Promise.resolve();
         }
 
         this.leaveRoom(resultId);
-        this._socket.off("remoteStep:saved", this.listerers[resultId]);
+        this._socket.off('remoteStep:saved', this.listerers[resultId]);
         delete this.listerers[resultId];
         return this.emitLeaveRoom(resultId);
     }