@testim/testim-cli 3.237.0 → 3.240.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@testim/testim-cli",
-  "version": "3.237.0",
+  "version": "3.240.0",
   "description": "Command line interface for running Testing on your CI",
   "author": "Oren Rubin",
   "contributors": [{

package/player/stepActions/scripts/scroll.js

@@ -1,6 +1,13 @@
-"use strict";
-var scroll = function (elementToScrollOn, elementToScrollTo, isScrollToElement, isDynamicScroll, expectedX, expectedY, shouldScrollLeft, shouldScrollTop) {
+// Disabling the eslint to keep this in a format which works on IE 11.
+/* eslint-disable no-var */
+/* eslint-disable no-redeclare */
+/* eslint-disable object-shorthand */
+/* eslint-disable one-var */
+/* eslint-disable operator-linebreak */
+
+'use strict';
 
+var scroll = function (elementToScrollOn, elementToScrollTo, isScrollToElement, isDynamicScroll, expectedX, expectedY, shouldScrollLeft, shouldScrollTop) {
     function doScroll(expectedPosition, element) {
         if (!element) {
             return { success: false };
@@ -17,7 +24,7 @@ var scroll = function (elementToScrollOn, elementToScrollTo, isScrollToElement,
 
     function getExpectedPosition(parentElement, locatedElement, isScrollToElement, expectedX, expectedY, shouldScrollLeft, shouldScrollTop) {
         if (!isScrollToElement) {
-            return {x: expectedX, y: expectedY};
+            return { x: expectedX, y: expectedY };
         }
 
         var target = getLocatedElement(locatedElement);
@@ -26,7 +33,7 @@ var scroll = function (elementToScrollOn, elementToScrollTo, isScrollToElement,
             return { x: parentElement.scrollWidth, y: parentElement.scrollHeight };
         }
 
-        if(!target) {
+        if (!target) {
             throw new Error('could not find target element');
         }
 
@@ -46,7 +53,7 @@ var scroll = function (elementToScrollOn, elementToScrollTo, isScrollToElement,
             ? parentElement.scrollLeft + targetRect.left - Math.min(expectedX, MAX_WIDTH)
             : parentElement.scrollLeft;
 
-        return {x: Math.round(xScroll), y: Math.round(yScroll)};
+        return { x: Math.round(xScroll), y: Math.round(yScroll) };
     }
 
     var isDocument = !elementToScrollOn;
@@ -55,7 +62,7 @@ var scroll = function (elementToScrollOn, elementToScrollTo, isScrollToElement,
     if (!elementToScrollOn) {
         throw new Error('could not find target to scroll on');
     }
-    var positionBeforeScroll = {top: elementToScrollOn.scrollTop, left: elementToScrollOn.scrollLeft};
+    var positionBeforeScroll = { top: elementToScrollOn.scrollTop, left: elementToScrollOn.scrollLeft };
     var expectedPosition = getExpectedPosition(elementToScrollOn, elementToScrollTo, isScrollToElement, expectedX, expectedY, shouldScrollLeft, shouldScrollTop);
 
     var result = doScroll(expectedPosition, elementToScrollOn);
@@ -71,7 +78,7 @@ var scroll = function (elementToScrollOn, elementToScrollTo, isScrollToElement,
     var actualScrollToElement = getLocatedElement(elementToScrollTo);
 
     if (isScrollToElement && isDynamicScroll && !actualScrollToElement) {
-        return { success: false, expectedPosition };
+        return { success: false, expectedPosition: expectedPosition };
     }
 
     if (isScrollToElement) {
@@ -82,7 +89,7 @@ var scroll = function (elementToScrollOn, elementToScrollTo, isScrollToElement,
         actualXString = rect.left;
         actualYString = rect.top;
     }
-    return {success: result.success, actualX: actualXString, actualY: actualYString};
+    return { success: result.success, actualX: actualXString, actualY: actualYString };
 };
 
 module.exports = scroll;

package/runners/ParallelWorkerManager.js

@@ -91,6 +91,7 @@ class ParallelWorkerManager {
             };
 
             const onTestCompleted = async (wid, testId, testResult, sessionId, isRerun) => {
+                runningTests--;
                 const update = {};
                 if (lightweightMode && lightweightMode.onlyTestIdsNoSuite) {
                     update.show = true;
@@ -156,9 +157,8 @@ class ParallelWorkerManager {
                     executionQueue.stop();
                     stoppedOnError = true;
                 }
-                runningTests--;
                 const completedTests = Object.keys(combinedTestResults).length;
-                if (completedTests === testCount || (stopOnError && runningTests === 0)) {
+                if (completedTests === testCount || (stoppedOnError && runningTests === 0)) {
                     resolve(combinedTestResults);
                     return undefined;
                 }
@@ -170,7 +170,7 @@ class ParallelWorkerManager {
                 testStatus.onTestIgnored(wid, testResult.resultId);
                 runningTests--;
                 const completedTests = Object.keys(combinedTestResults).length;
-                if (completedTests === testCount || (stopOnError && runningTests === 0)) {
+                if (completedTests === testCount || (stoppedOnError && runningTests === 0)) {
                     resolve(combinedTestResults);
                 }
             };

package/testRunHandler.js

@@ -248,7 +248,7 @@ class TestRun {
         if (this._options.mockNetworkRules) {
             runData.mockNetworkRules = this._options.mockNetworkRules;
         }
-        const mustClearPreviousStepResults = !this.isAllowReportTestResultRetries() && (this._timeoutRetryCount > 1 || this._retryCount > 1);
+        const mustClearPreviousStepResults = (this._timeoutRetryCount > 1 || this._retryCount > 1);
 
         if (this._options.lightweightMode && this._options.lightweightMode.disableResults &&
             !mustClearPreviousStepResults && canSendRunDataOverUrl(runData)) {