@testim/testim-cli 3.233.0 → 3.236.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@testim/testim-cli",
-  "version": "3.233.0",
+  "version": "3.236.0",
   "description": "Command line interface for running Testing on your CI",
   "author": "Oren Rubin",
   "contributors": [{
@@ -69,7 +69,6 @@
     "data-uri-to-buffer": "2.0.2",
     "decompress": "4.2.1",
     "express": "4.17.3",
-    "find-root": "1.1.0",
     "fkill": "7.2.1",
     "form-data": "3.0.0",
     "fs-extra": "10.0.1",

package/player/stepActions/inputFileStepAction.js

@@ -4,7 +4,7 @@ const StepAction = require('./stepAction');
 const _ = require('lodash');
 const logger = require('../../commons/logger').getLogger('input-file-step-action');
 const { codeSnippets, utils } = require('../../commons/getSessionPlayerRequire');
-const { extractElementId } = require('../../utils');
+const { extractElementId, download } = require('../../utils');
 const inputFileUtils = require('../../inputFileUtils');
 const featureFlagService = require('../../commons/featureFlags');
 
@@ -41,18 +41,15 @@ class InputFileStepAction extends StepAction {
     }
 
     async uploadFilesAndForceVisibility(gridLocalFiles, target) {
-        const preUploadStep = this.driver.isSafari() ?
-            // in safari we force the visibility ahead of time because making it visible the second time around doesn't work
-            this.safariPreUploadActions(target) :
-            Promise.resolve();
-
         try {
-            await preUploadStep;
+            if (this.driver.isSafari()) {
+                await this.safariPreUploadActions(target);
+            }
             await this.uploadFiles(gridLocalFiles, target);
         } catch (err) {
             const edgeErrorEditableMessage = 'The element is not editable';
             const edgeErrorFocusableMessage = 'The element is not focusable';
-            const safariErrorVisibleMessege = 'An element command could not be completed because the element is not visible on the page.';
+            const safariErrorVisibleMessage = 'An element command could not be completed because the element is not visible on the page.';
             const elementNotInteractable = 'element not interactable';
             const elementNotPointerOrKeyboardInteractable = 'element is not pointer- or keyboard interactable';
             const invalidStateMsg = 'invalid element state: Element is not currently interactable and may not be manipulated';
@@ -64,7 +61,7 @@ class InputFileStepAction extends StepAction {
                 _.startsWith(errorMsg, mustBeVisibleMsg) ||
                 _.startsWith(errorMsg, edgeErrorEditableMessage) ||
                 _.startsWith(errorMsg, edgeErrorFocusableMessage) ||
-                _.startsWith(errorMsg, safariErrorVisibleMessege) ||
+                _.startsWith(errorMsg, safariErrorVisibleMessage) ||
                 _.includes(errorMsg, notReachableByKeyboard) ||
                 _.includes(errorMsg, elementNotInteractable) ||
                 _.includes(errorMsg, elementNotPointerOrKeyboardInteractable)
@@ -88,9 +85,18 @@ class InputFileStepAction extends StepAction {
     async performAction() {
         const target = this.context.data[this.step.targetId || 'targetId'];
         const overrideAzureStorageUrl = featureFlagService.flags.overrideAzureStorageUrl.isEnabled();
-
-        const fileUrls = await utils.addTokenToFileUrl(this.context.project.id, this.step.fileUrls, this.stepActionUtils.testimServicesApi, overrideAzureStorageUrl, logger);
         const useJsInputCodeInSafari = featureFlagService.flags.useJsInputCodeInSafari.isEnabled();
+        const downloadToBase64 = featureFlagService.flags.downloadToBase64.isEnabled();
+
+        let fileUrls = await utils.addTokenToFileUrl(this.context.project.id, this.step.fileUrls, this.stepActionUtils.testimServicesApi, overrideAzureStorageUrl, logger);
+
+        if (downloadToBase64) {
+            fileUrls = await Promise.all(fileUrls.map(async ({ name, url }) => {
+                const res = await download(url);
+                return { name, url: `data:${res.type};base64,${Buffer.from(res.body).toString('base64')}` };
+            }));
+        }
+
         if (this.driver.isSafari() && (useJsInputCodeInSafari || fileUrls.length > 1)) {
             await this.driver.executeJSWithArray(`
                 const getLocatedElement = ${codeSnippets.getLocatedElementCode};
@@ -165,15 +171,18 @@ function downloadAndUpload() {
             return new File([blob], name, { type: blob.type });
         }));
 
-        fileList.item = function(ind) { return this[ind]; };
+        const dt = new DataTransfer();
+        for (const file of fileList) {
+            dt.items.add(file);
+        }
+        element.files = dt.files;
+
         let changeWasFired = false;
         const changeFiredHandler = (e) => {
             changeWasFired = true;
         };
 
         element.addEventListener("change", changeFiredHandler, true);
-        Reflect.deleteProperty(element, 'files');
-        Reflect.defineProperty(element, 'files', { get() { return fileList; }, configurable: true });
         await Promise.resolve(); // wait microtick
         element.dispatchEvent(new Event("input", { bubbles: true }));
         if (!changeWasFired) {

package/player/stepActions/textValidationStepAction.js

@@ -1,5 +1,6 @@
 "use strict";
 
+
 const sessionPlayer = require('../../commons/getSessionPlayerRequire');
 
 const StepAction = require('./stepAction');
@@ -7,6 +8,7 @@ const constants = sessionPlayer.commonConstants.stepResult;
 const paramEvaluator = sessionPlayer.stepParamExpressionEvaluator;
 const utils = sessionPlayer.utils;
 
+
 const Promise = require('bluebird');
 
 class TextValidationStepAction extends StepAction {
@@ -15,6 +17,7 @@ class TextValidationStepAction extends StepAction {
         var context = this.context;
         var target = this.getTarget();
         var frameHandler = this.frameHandler;
+        
 
         return new Promise(resolve => {
             var onFail = resultInfo => {

package/player/webdriver.js

@@ -59,6 +59,7 @@ class WebDriver extends WebDriverApi {
         this.cdpUrl = undefined;
         this.browserClosedCallbacks = [];
         this.browserClosedFailedKeepAlives = 0;
+        this.ignoreHiddenTagsText = false;
     }
 
     registerToClosedBrowser(callback) {
@@ -71,6 +72,7 @@ class WebDriver extends WebDriverApi {
 
     async init(browserOptions, testName, testRunConfig, gridInfo, customExtensionLocalLocation, executionId, testResultId, seleniumPerfStats = new SeleniumPerfStats(), fastInit = false, lambdatestService) {
         this.browserClosedFailedKeepAlives = 0;
+        this.ignoreHiddenTagsText = _(browserOptions).get('company.activePlan.premiumFeatures.ignoreHiddenTagsText');
         this.browserClosedCallbacks = [];
         const capabilities = desiredCapabilitiesBuilder.buildSeleniumOptions(browserOptions, testName, testRunConfig, gridInfo, customExtensionLocalLocation, executionId, testResultId, lambdatestService);
         if (capabilities.desiredCapabilities) {
@@ -360,7 +362,14 @@ class WebDriver extends WebDriverApi {
                         return element.shadowRoot.textContent.replace(/(\r\n|\n|\r)/gm, "");
                     }
                 } catch (err) { }
-                return element.textContent.replace(/(\r\n|\n|\r)/gm, "");
+                if (this.ignoreHiddenTagsText && Array.prototype.some.call(element.children, elem => elem.hidden)) {
+                    const dupElement = element.cloneNode(true);
+                    const hiddenChildren = Array.prototype.filter.call(dupElement.children, elem => elem.hidden);
+                    hiddenChildren.forEach(child => {
+                        dupElement.removeChild(child);
+                    });
+                    return dupElement.textContent.replace(/(\r\n|\n|\r)/gm, "");
+                } return element.textContent.replace(/(\r\n|\n|\r)/gm, "");
             }
 
             function getElementTextContent(element) {

package/processHandler.js

@@ -1,3 +1,5 @@
+/* eslint-disable no-console */
+
 'use strict';
 
 const logger = require('./commons/logger').getLogger('process-handler');
@@ -6,9 +8,12 @@ const exitHooks = [];
 const Promise = require('bluebird');
 
 module.exports = function (onExit) {
-    process.on('uncaughtException', async (err) => {
+    async function cleanup(err) {
         // give cleanup and socket reports a chance to run
         await Promise.all(exitHooks.map(x => x())).timeout(10000).catch(() => {});
+        onExit(err);
+    }
+    process.on('uncaughtException', async (err) => {
         logger.error('Caught exception', { err });
         console.log('Uncaught exception');
         if (err.message) {
@@ -17,7 +22,7 @@ module.exports = function (onExit) {
         if (err.reason) {
             console.log('Reason =', err.reason);
         }
-        onExit(err);
+        await cleanup(err);
     });
 
     process.on('unhandledRejection', (reason) => {
@@ -40,7 +45,7 @@ module.exports = function (onExit) {
         const msg = 'Runner aborted - SIGTERM event';
         const err = new Error(msg);
         logger.error(msg);
-        onExit(err);
+        cleanup(err);
         throw err;
     });
 
@@ -48,7 +53,7 @@ module.exports = function (onExit) {
         const msg = 'Runner aborted - SIGINT event';
         const err = new Error(msg);
         logger.error(msg);
-        onExit(err);
+        cleanup(err);
         throw err;
     });
 

package/runOptions.js

@@ -306,6 +306,7 @@ program
     .option('--external-lambdatest-tunnel-id [tunnel-id]', 'use existing lambdatest tunnel ID')
     .option('--external-lambdatest-use-wss', 'use wss instead of ssh for LT', false)
     .option('--external-lambdatest-disable-automation-tunneling', 'don\'t tunnel Testim calls in LT tunnel', true)
+    .option('--external-lambdatest-mitm', 'Turn on LT Man in the middle', false)
 
     .option('--w3c-capabilities [enable-w3c-caps-mode]', 'enable/disable w3c capabilities format (default enable)', JSON.parse, true)
     .option('--old-capabilities [enable-old-caps-mode]', 'enable/disable old capabilities format (default enable)', JSON.parse, true)
@@ -321,6 +322,7 @@ program
     // Agent mode
     .option('connect, --agent [enable-agent-mode]', 'enable Testim CLI agent mode', false)
     .option('start [enable-start]', 'Connect to testim and open the editor in a standalone browser', false)
+    .option('--download-browser', 'when used with the start option, downloads a fixed version to run Testim editor in', false)
     .option('--agent-port [agent-port]', 'set agent port', Number, 42543)
     .option('--agent-bind [agent-host-bind]', 'set agent host bind', '127.0.0.1')
 
@@ -494,7 +496,7 @@ module.exports = {
         }
 
         if (program.proxyForGrid && !program.proxy) {
-            return Promise.reject(new ArgError('missing --proxy option'));
+            throw new ArgError('missing --proxy option');
         }
 
         if (runOptionsAgentFlow.isAgentFlow(program)) {
@@ -553,20 +555,20 @@ module.exports = {
             }
         }
 
-        if (program.reporters && program.reporters.indexOf('junit') > -1 && !program.reportFile) {
+        if (program.reporters && program.reporters.includes('junit') && !program.reportFile) {
             console.log('Warning: please define --report-file option for JUnit reporter');
         }
 
         if (!program.tunnel && program.externalLambdatestTunnelId) {
-            return Promise.reject(new ArgError('missing --tunnel parameter'));
+            throw new ArgError('missing --tunnel parameter');
         }
 
         if (!program.tunnel && program.externalLambdatestUseWss) {
-            return Promise.reject(new ArgError('missing --tunnel parameter'));
+            throw new ArgError('missing --tunnel parameter');
         }
 
         if (!program.tunnel && [program.tunnelPort, program.tunnelHostHeader, program.tunnelRegion, program.tunnelDiagnostics].some(Boolean)) {
-            return Promise.reject(new ArgError('missing --tunnel parameter'));
+            throw new ArgError('missing --tunnel parameter');
         }
         if (program.chromeExtraPrefs) {
             try {
@@ -609,7 +611,7 @@ module.exports = {
 
         // SauceLabs Options
         if ((program.sauceUser && !program.sauceKey) || (!program.sauceUser && program.sauceKey)) {
-            return Promise.reject(new ArgError('missing --sauce-user <sauce-user> or --sauce-key <sauce-key>'));
+            throw new ArgError('missing --sauce-user <sauce-user> or --sauce-key <sauce-key>');
         }
 
         if (program.sauceUser && program.sauceKey) {
@@ -655,7 +657,7 @@ module.exports = {
 
         // BrowserStack options
         if ((program.browserstackUser && !program.browserstackKey) || (!program.browserstackUser && program.browserstackKey)) {
-            return Promise.reject(new ArgError('missing --browserstack-user <browserstack-user> or --browserstack-key <browserstack-key>'));
+            throw new ArgError('missing --browserstack-user <browserstack-user> or --browserstack-key <browserstack-key>');
         }
         if (program.browserstackUser && program.browserstackKey) {
             setHostAndPortForBrowserStack();
@@ -726,7 +728,7 @@ module.exports = {
             if (projectId) {
                 program.project = projectId;
             } else {
-                return Promise.reject(new ArgError('missing project-id info, either --login to provide new credentials or use --project <project-id>'));
+                throw new ArgError('missing project-id info, either --login to provide new credentials or use --project <project-id>');
             }
         }
 
@@ -737,12 +739,12 @@ module.exports = {
 
         if (program.testConfig) {
             // convert single test config inputs to array (e.g. from configFile)
-            program.testConfig = [].concat(program.testConfig);
+            program.testConfig = [program.testConfig].flat();
         }
 
         if (program.testConfigId) {
             // convert single test config inputs to array (e.g. from configFile)
-            program.testConfigId = [].concat(program.testConfigId);
+            program.testConfigId = [program.testConfigId].flat();
         }
 
         program.retries = !program.retries || typeof program.retries === 'boolean' ? 1 : Number(program.retries) + 1;
@@ -764,21 +766,19 @@ module.exports = {
 
 
         if (program.parallel > 1 && program.run && !program.gridId && !program.grid &&
-            ((!program.testPlan || program.testPlan.length === 0) && (!program.testPlanId || !program.testPlanId.length))) {
-            if (process.stdout.isTTY && !program.headless && !process.env.TERM) {
-                const prompts = require('prompts');
-                const response = await prompts({
-                    type: 'toggle',
-                    name: 'isSure',
-                    message: 'Running in parallel without --headless flag will open several browsers on your computer. Are you sure?',
-                    initial: false,
-                    active: 'yes',
-                    inactive: 'no',
-                });
-
-                if (!response.isSure) {
-                    process.exit(0);
-                }
+            ((!program.testPlan || program.testPlan.length === 0) && (!program.testPlanId || !program.testPlanId.length)) && process.stdout.isTTY && !program.headless && !process.env.TERM) {
+            const prompts = require('prompts');
+            const response = await prompts({
+                type: 'toggle',
+                name: 'isSure',
+                message: 'Running in parallel without --headless flag will open several browsers on your computer. Are you sure?',
+                initial: false,
+                active: 'yes',
+                inactive: 'no',
+            });
+
+            if (!response.isSure) {
+                process.exit(0);
             }
         }
 
@@ -787,11 +787,11 @@ module.exports = {
         program.port = program.port && Number(program.port);
 
         if (program.retries <= 0 || _.isNaN(program.retries)) {
-            return Promise.reject(new ArgError('test failure retry count could not be a negative number or string, --retries <max_num_of_retries>'));
+            throw new ArgError('test failure retry count could not be a negative number or string, --retries <max_num_of_retries>');
         }
 
         if (program.retries > 21) {
-            return Promise.reject(new ArgError('Max number of retries exceeded. Number cannot be greater than 20, --retries <max_num_of_retries>'));
+            throw new ArgError('Max number of retries exceeded. Number cannot be greater than 20, --retries <max_num_of_retries>');
         }
 
         if (!program.token) {
@@ -801,33 +801,32 @@ module.exports = {
             if (credentialToken) {
                 program.token = credentialToken;
             } else {
-                return Promise.reject(
-                    new ArgError('missing Testim Access Token, either --login to provide new credentials or use --token <testim-access-token>, contact info@testim.io if you need a new one.'));
+                throw new ArgError('missing Testim Access Token, either --login to provide new credentials or use --token <testim-access-token>, contact info@testim.io if you need a new one.');
             }
         }
 
         if (program.browserTimeout <= 0 || _.isNaN(program.browserTimeout)) {
-            return Promise.reject(new ArgError('get browser timeout could not be a negative number, --browser-timeout <get-browser-timeout>'));
+            throw new ArgError('get browser timeout could not be a negative number, --browser-timeout <get-browser-timeout>');
         }
 
         if (program.newBrowserWaitTimeout <= 0 || _.isNaN(program.newBrowserWaitTimeout)) {
-            return Promise.reject(new ArgError('max new browser wait timeout could not be a negative number, --new-browser-wait-timeout <max-wait-to-browser>'));
+            throw new ArgError('max new browser wait timeout could not be a negative number, --new-browser-wait-timeout <max-wait-to-browser>');
         }
 
         if (program.timeout <= 0 || _.isNaN(program.timeout)) {
-            return Promise.reject(new ArgError('test run timeout could not be a negative number, --timeout <run-timeout>'));
+            throw new ArgError('test run timeout could not be a negative number, --timeout <run-timeout>');
         }
 
         if (program.parallel <= 0 || _.isNaN(program.parallel)) {
-            return Promise.reject(new ArgError('parallel could not be a negative number or not number, --parallel <number-of-tests>'));
+            throw new ArgError('parallel could not be a negative number or not number, --parallel <number-of-tests>');
         }
 
-        if ([CLI_MODE.EXTENSION, CLI_MODE.SELENIUM].indexOf(program.mode) === -1) {
-            return Promise.reject(new ArgError(`runner mode <${program.mode}> is not supported`));
+        if (![CLI_MODE.EXTENSION, CLI_MODE.SELENIUM].includes(program.mode)) {
+            throw new ArgError(`runner mode <${program.mode}> is not supported`);
         }
 
         if ((program.mode !== CLI_MODE.SELENIUM) && program.disableNativeEvents) {
-            return Promise.reject(new ArgError('disable-native-events is only applicable in selenium mode'));
+            throw new ArgError('disable-native-events is only applicable in selenium mode');
         }
 
         if (
@@ -848,9 +847,9 @@ module.exports = {
                 !program.useChromeLauncher &&
                 !program.createPrefechedData
             ) {
-                return Promise.reject(new ArgError(
+                throw new ArgError(
                     'missing remote grid address parameter, specify --host <host-name-or-ip> or --grid <grid-name> or --grid-id <grid-id>'
-                ));
+                );
             }
         } else if (
             program.testId.length ||
@@ -862,9 +861,9 @@ module.exports = {
             program.useLocalChromeDriver ||
             program.useChromeLauncher
         ) {
-            return Promise.reject(new ArgError(
+            throw new ArgError(
                 'cannot set --testId, --label, --name, --browser, --test-config, --test-config-id, --use-local-chrome-driver --use-chrome-launcher or --suite with --test-plan option'
-            ));
+            );
         }
 
         if (
@@ -875,17 +874,17 @@ module.exports = {
                 isSuiteSpecified) &&
             program.file
         ) {
-            return Promise.reject(new ArgError(
+            throw new ArgError(
                 'Cannot pass codeful automation tests with --testId --label --name or --suite'
-            ));
+            );
         }
 
         const numberOfDefinedHosts = [program.host, program.grid, program.gridId].filter(Boolean).length;
         if (numberOfDefinedHosts > 1) {
-            return Promise.reject(new ArgError('please define exactly one of --grid or --grid-id or --host'));
+            throw new ArgError('please define exactly one of --grid or --grid-id or --host');
         }
 
-        if (program.host && program.host.indexOf('/') !== -1) {
+        if (program.host && program.host.includes('/')) {
             if (!/^(f|ht)tps?:\/\//i.test(program.host)) {
                 program.host = `http://${program.host}`;
             }
@@ -896,7 +895,7 @@ module.exports = {
             program.resultLabel = program.resultLabel.map(label => label.trim()).filter(Boolean);
             const invalidLabels = program.resultLabel.filter(label => label.length >= 250).filter(Boolean);
             if (invalidLabels.length) {
-                return Promise.reject(new ArgError('A result label cannot exceed 250 characters'));
+                throw new ArgError('A result label cannot exceed 250 characters');
             }
         }
 
@@ -904,66 +903,66 @@ module.exports = {
         const playerUrl = runOptionsUtils.getPlayerUrl(program);
 
         if (!program.w3cCapabilities && !program.oldCapabilities) {
-            return Promise.reject(new ArgError('cannot set --w3c-capabilities and --old-capabilities options as false'));
+            throw new ArgError('cannot set --w3c-capabilities and --old-capabilities options as false');
         }
         program.protocol = program.protocol || (program.port === 443 ? 'https' : 'http');
         if (!['http', 'https'].includes(program.protocol)) {
-            return Promise.reject(new ArgError('invalid --protocol value, allow --protocol http or https'));
+            throw new ArgError('invalid --protocol value, allow --protocol http or https');
         }
 
         if (program.rerunFailedByRunId && program.branch) {
-            return Promise.reject(new ArgError('It is not possible to use --branch with --rerun-failed-by-run-id. Tests will automatically run on the same branch that was used in the original run'));
+            throw new ArgError('It is not possible to use --branch with --rerun-failed-by-run-id. Tests will automatically run on the same branch that was used in the original run');
         }
 
         if (program.rerunFailedByRunId &&
             (isSuiteSpecified || program.name.length ||
                 program.testId.length || program.label.length || isTestPlanSpecified)) {
-            return Promise.reject(new ArgError('Re-running failed tests is not possible when suite (--suite),' +
-                ' label (--label), plan (--test-plan), or other test flags (--test) are provided. Please remove these flags and try again'));
+            throw new ArgError('Re-running failed tests is not possible when suite (--suite),' +
+                ' label (--label), plan (--test-plan), or other test flags (--test) are provided. Please remove these flags and try again');
         }
 
         if (program.run.length) {
             const glob = require('glob');
             program.files = _.flatMap(program.run, files => glob.sync(files));
             if (program.files.length === 0) {
-                return Promise.reject(new ArgError(`No files found at path '${program.run}'.`));
+                throw new ArgError(`No files found at path '${program.run}'.`);
             }
         } else {
             program.files = [];
         }
 
         if (program.setRetention && !_.inRange(_.parseInt(program.setRetention), 1, 11)) {
-            return Promise.reject(new ArgError('Please provide the number of days that the test results will be retained for (--set-retention must be a whole number between 1 to 10)'));
+            throw new ArgError('Please provide the number of days that the test results will be retained for (--set-retention must be a whole number between 1 to 10)');
         }
         program.setRetention = program.setRetention && Number(program.setRetention);
 
         const mockNetworkDeprecationMsg = 'is no longer supported, please use --override-mapping-file';
         if (program.mockNetworkHar) {
-            return Promise.reject(new ArgError(`--mock-network-har ${mockNetworkDeprecationMsg}`));
+            throw new ArgError(`--mock-network-har ${mockNetworkDeprecationMsg}`);
         }
         if (program.mockNetworkPattern) {
-            return Promise.reject(new ArgError(`--mock-network-pattern ${mockNetworkDeprecationMsg}`));
+            throw new ArgError(`--mock-network-pattern ${mockNetworkDeprecationMsg}`);
         }
 
         if (program.disableMockNetwork && program.overrideMappingFile) {
-            return Promise.reject(new ArgError('You can either use --disable-mock-network or --override-mapping-file'));
+            throw new ArgError('You can either use --disable-mock-network or --override-mapping-file');
         }
 
         if (!program.collectCodeCoverage && program.codeCoverageSourceMapPath) {
-            return Promise.reject(new ArgError('cannot set --code-coverage-source-map-path without passing --collect-code-coverage'));
+            throw new ArgError('cannot set --code-coverage-source-map-path without passing --collect-code-coverage');
         }
 
         if (!program.collectCodeCoverage && program.codeCoverageReporter.length) {
-            return Promise.reject(new ArgError('cannot set --code-coverage-reporter without passing --collect-code-coverage'));
+            throw new ArgError('cannot set --code-coverage-reporter without passing --collect-code-coverage');
         }
 
         if (!program.collectCodeCoverage && program.codeCoverageInclude.length) {
-            return Promise.reject(new ArgError('cannot set --code-coverage-include without passing --collect-code-coverage'));
+            throw new ArgError('cannot set --code-coverage-include without passing --collect-code-coverage');
         }
 
         if (program.collectCodeCoverage && program.codeCoverageReporter && _.difference(program.codeCoverageReporter, CODE_COVERAGE_REPORTER_OPTIONS).length) {
             const diff = _.difference(program.codeCoverageReporter, CODE_COVERAGE_REPORTER_OPTIONS);
-            return Promise.reject(new ArgError(`invalid --code-coverage-reporter parameters ${diff.join('/')}`));
+            throw new ArgError(`invalid --code-coverage-reporter parameters ${diff.join('/')}`);
         }
 
         program.codeCoverageReporter = program.codeCoverageReporter.length === 0 ? ['html', 'text'] : program.codeCoverageReporter;
@@ -982,7 +981,7 @@ module.exports = {
 
         if (program.mode !== CLI_MODE.EXTENSION && usedExtensionOptions.length) {
             const multi = usedExtensionOptions.length > 1 ? 'are' : 'is';
-            return Promise.reject(new ArgError(`${usedExtensionOptions.map(key => extensionOnlyOptions[key]).join(' and ')} ${multi} only applicable in extension mode`));
+            throw new ArgError(`${usedExtensionOptions.map(key => extensionOnlyOptions[key]).join(' and ')} ${multi} only applicable in extension mode`);
         }
 
         if (program.tmsFieldFile) {
@@ -1054,18 +1053,18 @@ module.exports = {
         }
 
         if (typeof program.baseUrl === 'boolean') {
-            return Promise.reject(new ArgError('base url cannot be used as a flag, and must contain a string value'));
+            throw new ArgError('base url cannot be used as a flag, and must contain a string value');
         }
 
         return ({
-            testId: [].concat(program.testId),
-            name: [].concat(program.name),
-            label: [].concat(program.label),
-            suites: [].concat(program.suite),
-            suiteIds: [].concat(program.suiteId),
-            testPlan: [].concat(program.testPlan),
-            testPlanIds: [].concat(program.testPlanId),
-            files: [].concat(program.files),
+            testId: [program.testId].flat(),
+            name: [program.name].flat(),
+            label: [program.label].flat(),
+            suites: [program.suite].flat(),
+            suiteIds: [program.suiteId].flat(),
+            testPlan: [program.testPlan].flat(),
+            testPlanIds: [program.testPlanId].flat(),
+            files: [program.files].flat(),
             webpackConfig: program.webpackConfig,
             reportFile: program.reportFile,
             reportFileClassname: program.overrideReportFileClassname,
@@ -1116,7 +1115,7 @@ module.exports = {
 
             // Extension
             ext: program.ext,
-            extensionLocation: [].concat(program.extensionPath || extHeadlessUrl),
+            extensionLocation: [program.extensionPath || extHeadlessUrl].flat(),
             extensionPath: program.extensionPath,
 
             // Player
@@ -1136,6 +1135,7 @@ module.exports = {
             externalLambdatestTunnelId: program.externalLambdatestTunnelId,
             externalLambdatestUseWss: program.externalLambdatestUseWss || false,
             externalLambdatestDisableAutomationTunneling: Boolean(program.externalLambdatestDisableAutomationTunneling),
+            externalLambdatestMitm: Boolean(program.externalLambdatestMitm),
 
             // Hooks
             beforeTest: program.beforeTest,

package/runOptionsAgentFlow.js

@@ -5,12 +5,16 @@
 const { ArgError } = require('./errors');
 const _ = require('lodash');
 const runOptionsUtils = require('./runOptionsUtils');
+const analytics = require('./commons/testimAnalytics');
 
 /**
  *
  * @param {import("commander").CommanderStatic} program
  */
 function isAgentFlow(program) {
+    if (program.start) {
+        analytics.track(null, 'cli-start-command', { downloadBrowser: Boolean(program.downloadBrowser) });
+    }
     if (program.startV2 || program.start || program.agent) {
         return true;
     }
@@ -73,6 +77,7 @@ async function runAgentFlow(program) {
         canary: program.canary,
         playerPath: program.playerPath,
         playerRequirePath: program.playerRequirePath,
+        downloadBrowser: Boolean(program.downloadBrowser),
     };
 }
 

package/runner.js

@@ -25,7 +25,6 @@ const FREE_PLAN_MINIMUM_BROWSER_TIMEOUT = 30 * 60 * 1000;
 const TestPlanRunner = require('./runners/TestPlanRunner');
 const labFeaturesService = require('./services/labFeaturesService');
 const featureAvailabilityService = require('./commons/featureAvailabilityService');
-const featureFlagService = require('./commons/featureFlags');
 
 const logger = require('./commons/logger').getLogger('runner');
 
@@ -269,7 +268,7 @@ async function init(options) {
         await labFeaturesService.loadLabFeatures(projectById.id, companyByProjectId.activePlan);
     }
 
-    if (options.lightweightMode && options.lightweightMode.type === 'turboMode' && (featureFlagService.flags.highSpeedMode.getValue() === 'disabled' || options.company.planType === 'free')) {
+    if (options.lightweightMode && options.lightweightMode.type === 'turboMode' && (featureFlags.flags.highSpeedMode.getValue() === 'disabled' || options.company.planType === 'free')) {
         delete options.lightweightMode;
     }
 

package/runners/ParallelWorkerManager.js

@@ -8,7 +8,6 @@ const config = require('../commons/config');
 const ExecutionQueue = require('../executionQueue');
 
 const testimCustomToken = require('../commons/testimCustomToken');
-const testimServicesApi = require('../commons/testimServicesApi');
 const labFeaturesService = require('../services/labFeaturesService');
 const perf = require('../commons/performance-logger');
 const { StopRunOnError } = require('../errors');