@testim/testim-cli 3.224.0 → 3.225.0

package/npm-shrinkwrap.json

@@ -1,12 +1,12 @@
 {
   "name": "@testim/testim-cli",
-  "version": "3.224.0",
+  "version": "3.225.0",
   "lockfileVersion": 2,
   "requires": true,
   "packages": {
     "": {
       "name": "@testim/testim-cli",
-      "version": "3.224.0",
+      "version": "3.225.0",
       "license": "Proprietary",
       "dependencies": {
         "@applitools/eyes-sdk-core": "13.0.0",
@@ -15012,7 +15012,7 @@
       "version": "3.8.3",
       "resolved": "https://registry.npmjs.org/superagent/-/superagent-3.8.3.tgz",
       "integrity": "sha512-GLQtLMCoEIK4eDv6OGtkOoSMt3D+oq0y3dsxMuYuDvaNUvuT8eFBuLmfR0iYYzHC1e8hpzC6ZsxbuP6DIalMFA==",
-      "deprecated": "Please upgrade to v7.0.2+ of superagent.  We have fixed numerous issues with streams, form-data, attach(), filesystem errors not bubbling up (ENOENT on attach()), and all tests are now passing.  See the releases tab for more information at <https://github.com/visionmedia/superagent/releases>. Thanks to @shadowgate15, @spence-s, and @niftylettuce. Superagent is sponsored by Forward Email at <https://forwardemail.net>.",
+      "deprecated": "Please upgrade to v7.0.2+ of superagent.  We have fixed numerous issues with streams, form-data, attach(), filesystem errors not bubbling up (ENOENT on attach()), and all tests are now passing.  See the releases tab for more information at <https://github.com/visionmedia/superagent/releases>.",
       "dependencies": {
         "component-emitter": "^1.2.0",
         "cookiejar": "^2.1.0",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@testim/testim-cli",
-  "version": "3.224.0",
+  "version": "3.225.0",
   "description": "Command line interface for running Testing on your CI",
   "author": "Oren Rubin",
   "contributors": [{

package/services/gridService.js

@@ -236,7 +236,26 @@ function getOptionGrid(options) {
 }
 
 async function getTestPlanGridData(options, testPlanData) {
-    return getGridDataByGridId(options.company.companyId, testPlanData.gridId, options.allGrids);
+    const companyId = options.company.companyId;
+    try {
+        return await getGridDataByGridId(companyId, testPlanData.gridId, options.allGrids);
+    } catch (err) {
+        if (err instanceof ArgError) {
+            // this is a fallback to an old behavior that is wrong,
+            // we should remove it in the future
+            const testPlanDatas = await servicesApi.getTestPlan(options.project, options.testPlan);
+            if (testPlanDatas.length === 0) {
+                throw new ArgError(`no test plan to run ${options.testPlan}`);
+            }
+            const testPlanGrids = testPlanDatas.map(d => options.allGrids.find(grid => grid._id === d.gridId));
+            if (testPlanGrids.includes(undefined)) {
+                throw new ArgError('failed to find one of the test plan defined grid');
+            }
+            logger.warn('getTestPlanGridData used fallback and might cause test plans run on a unintended grid', { companyId });
+            return getSerializableObject(_.first(testPlanGrids));
+        }
+        throw err;
+    }
 }
 
 async function getGridData(options) {