@testdriverai/runner 7.9.100-test → 7.9.102-test

package/lib/ably-service.js

@@ -40,16 +40,16 @@ function getLocalVersion() {
 
 /**
  * Upload a screenshot to S3 via presigned URL from the API
- * 
+ *
  * @param {string} apiRoot - API base URL
  * @param {string} apiKey - Team API key
  * @param {string} sandboxId - Sandbox ID
- * @param {string} base64 - Base64-encoded image data
+ * @param {string|Buffer} payload - PNG bytes as a Buffer (preferred) or base64 string
  * @param {string} label - Label for the screenshot (e.g., 'screenshot', 'before', 'after')
  * @returns {Promise<{ s3Key: string, fileName: string } | null>}
  */
-async function uploadToS3(apiRoot, apiKey, sandboxId, base64, label = 'screenshot') {
-  if (!base64 || !apiRoot || !apiKey) return null;
+async function uploadToS3(apiRoot, apiKey, sandboxId, payload, label = 'screenshot') {
+  if (!payload || !apiRoot || !apiKey) return null;
 
   try {
     const fileName = `${label}-${Date.now()}.png`;
@@ -68,8 +68,10 @@ async function uploadToS3(apiRoot, apiKey, sandboxId, base64, label = 'screensho
       return null;
     }
 
-    // Upload to S3 via presigned URL
-    const pngBuffer = Buffer.from(base64, 'base64');
+    // Upload to S3 via presigned URL. Accept either a Buffer (no decode) or
+    // a base64 string (legacy callers) — Buffer is preferred to avoid the
+    // wasteful PNG → base64 → PNG round-trip.
+    const pngBuffer = Buffer.isBuffer(payload) ? payload : Buffer.from(payload, 'base64');
     const url = new URL(uploadUrlResponse.uploadUrl);
     const transport = url.protocol === 'https:' ? https : http;
 

package/lib/automation.js

@@ -591,19 +591,20 @@ class Automation extends EventEmitter {
         // For extract/remember: capture screenshot, upload to S3, return s3Key
         // SDK will then call API with the s3Key
         // For system.screenshot (normalized to 'screenshot'): same flow (return s3Key instead of base64)
-        
-        // Capture screenshot locally
+
+        // Capture screenshot locally — buffer variant avoids an unnecessary
+        // round-trip through base64 (PNG buffer → base64 → PNG buffer) that
+        // doubles peak memory and adds ~10–30 ms of pure encoding cost on
+        // large screenshots.
         console.log('[automation] Step 1: Capturing screenshot...');
-        const screenshot = await this._captureScreenshot();
-        console.log(`[automation] Step 2: Screenshot captured, size: ${screenshot.length} bytes (base64)`);
-        const buffer = Buffer.from(screenshot, 'base64');
-        console.log(`[automation] Step 3: Buffer created, size: ${buffer.length} bytes`);
+        const buffer = await this._captureScreenshotBuffer();
+        console.log(`[automation] Step 2: Screenshot captured, size: ${buffer.length} bytes`);
 
         // Upload screenshot to S3 and return key
-        console.log('[automation] Step 4: Uploading to S3...');
+        console.log('[automation] Step 3: Uploading to S3...');
         const s3Key = await this._uploadToS3(buffer, this._sandboxId, 'image/png');
-        console.log(`[automation] Step 5: Upload complete, s3Key: ${s3Key}`);
-        
+        console.log(`[automation] Step 4: Upload complete, s3Key: ${s3Key}`);
+
         return { s3Key };
       }
 
@@ -668,7 +669,15 @@ class Automation extends EventEmitter {
 
   // ── Screenshot (highest quality PNG, via pyautogui → temp file → sharp) ──
 
-  async _captureScreenshot() {
+  /**
+   * Capture a screenshot and return the raw PNG buffer.
+   *
+   * Prefer this when the next consumer of the bytes is binary (e.g. an HTTP
+   * PUT to S3): it avoids the wasteful PNG → base64 → PNG round-trip that
+   * `_captureScreenshot()` does for backwards compatibility with callers
+   * that still expect a base64 string.
+   */
+  async _captureScreenshotBuffer() {
     const sharp = require('sharp');
     const maxAttempts = 3;
 
@@ -726,8 +735,7 @@ class Automation extends EventEmitter {
           }
         }
 
-        const buffer = await image.png({ compressionLevel: 0 }).toBuffer();
-        return buffer.toString('base64');
+        return await image.png({ compressionLevel: 0 }).toBuffer();
       } finally {
         // Clean up temp file
         try { fs.unlinkSync(tmpFile); } catch {}
@@ -735,6 +743,14 @@ class Automation extends EventEmitter {
     }
   }
 
+  async _captureScreenshot() {
+    // Kept for backwards compatibility with callers (e.g. Ably channel
+    // messages) that still want a base64 string. New code paths should
+    // prefer `_captureScreenshotBuffer()` to avoid the round-trip.
+    const buffer = await this._captureScreenshotBuffer();
+    return buffer.toString('base64');
+  }
+
   // ── Focus window (platform-specific) ───────────────────────────────
 
   async _focusWindow(data) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@testdriverai/runner",
-  "version": "7.9.100-test",
+  "version": "7.9.102-test",
   "description": "TestDriver Runner - Ably-based remote automation agent with Node.js automation",
   "main": "index.js",
   "bin": {