@testdriverai/runner 7.9.10-test → 7.9.12-test

package/lib/ably-service.js

@@ -164,6 +164,7 @@ class AblyService extends EventEmitter {
     this._sessionChannel = null;
     this._connected = false;
     this._statsInterval = null;
+    this._closed = false; // set to true in close() to suppress post-close events
   }
 
   /**
@@ -367,7 +368,10 @@ class AblyService extends EventEmitter {
       if (current === 'disconnected') {
         this._connected = false;
         this.emit('log', `Realtime connection: ${previous} → ${current}${reasonMsg ? ' — ' + reasonMsg : ''}${retryIn ? ' (retryIn=' + retryIn + 'ms)' : ''}`);
-        this.emit('log', 'Ably disconnected — will auto-reconnect');
+        // Suppress auto-reconnect message when we've already initiated a clean close
+        if (!this._closed) {
+          this.emit('log', 'Ably disconnected — will auto-reconnect');
+        }
       } else if (current === 'connected' && previous !== 'initialized') {
         if (!this._connected) {
           this._connected = true;
@@ -390,8 +394,8 @@ class AblyService extends EventEmitter {
         this.emit('log', `Realtime connection: ${previous} → ${current}${reasonMsg ? ' — ' + reasonMsg : ''}`);
       }
 
-      // Capture exceptions for bad states
-      if (current === 'failed' || current === 'suspended' || (current === 'disconnected' && reason)) {
+      // Capture exceptions for bad states — skip if we're in a clean close sequence
+      if (!this._closed && (current === 'failed' || current === 'suspended' || (current === 'disconnected' && reason))) {
         Sentry.withScope((scope) => {
           scope.setTag('ably.client', 'runner');
           scope.setTag('ably.state', current);
@@ -579,6 +583,10 @@ class AblyService extends EventEmitter {
    * so that missed commands are actually executed.
    */
   async _recoverFromDiscontinuity() {
+    // Don't attempt recovery after an intentional close — subscriptions are
+    // nulled out in close() and the channel is being torn down
+    if (this._closed) return;
+
     const subs = [
       { name: 'command', sub: this._commandSubscription, handler: this._onCommandMsg },
       { name: 'control', sub: this._controlSubscription, handler: this._onControlMsg },
@@ -668,6 +676,9 @@ class AblyService extends EventEmitter {
    * Disconnect from Ably and clean up.
    */
   async close() {
+    if (this._closed) return; // Prevent double-close
+    this._closed = true;
+
     this.emit('log', 'Closing realtime service...');
 
     this._stopReadySignal();
@@ -677,6 +688,11 @@ class AblyService extends EventEmitter {
       this._statsInterval = null;
     }
 
+    // Null out subscription refs so _recoverFromDiscontinuity won't replay
+    // messages on a channel that is about to be torn down
+    this._commandSubscription = null;
+    this._controlSubscription = null;
+
     try {
       if (this._sessionChannel) this._sessionChannel.detach();
     } catch { }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@testdriverai/runner",
-  "version": "7.9.10-test",
+  "version": "7.9.12-test",
   "description": "TestDriver Runner - Ably-based remote automation agent with Node.js automation",
   "main": "index.js",
   "bin": {