@terreno/ui 0.13.3 → 0.14.1

package/src/ToastNotifications.tsx

@@ -61,7 +61,7 @@ import {
 // useDimensions hook
 // ============================================================================
 
-function useDimensions() {
+const useDimensions = () => {
   const [dimensions, setDimensions] = useState(Dimensions.get("window"));
 
   const onChange = useCallback(({window}: {window: ScaledSize}) => {
@@ -77,7 +77,7 @@ function useDimensions() {
   }, [onChange]);
 
   return dimensions;
-}
+};
 
 // ============================================================================
 // Toast Options and Props
@@ -177,10 +177,7 @@ export interface ToastOptions {
   /**
    * Payload data for custom toasts. You can pass whatever you want
    */
-  // noExplicitAny: This is the public API of a vendored 3rd-party library
-  // (react-native-toast-notifications); the `data` field is an opaque
-  // user-provided payload. Tightening to `unknown` breaks downstream consumers
-  // that spread `data` into `Toast` (e.g. TerrenoProvider) without refactor.
+  // biome-ignore lint/suspicious/noExplicitAny: This is the public API of a vendored 3rd-party library (react-native-toast-notifications); the data field is an opaque user-provided payload. Tightening to unknown breaks downstream consumers that spread data into Toast (e.g. TerrenoProvider) without refactor.
   data?: any;
 
   swipeEnabled?: boolean;

package/src/Tooltip.test.tsx

@@ -1,9 +1,8 @@
-import {beforeAll, describe, expect, it, mock} from "bun:test";
+import {afterEach, beforeAll, beforeEach, describe, expect, it, mock} from "bun:test";
 import {act} from "@testing-library/react-native";
-import {View} from "react-native";
 
 import {Text} from "./Text";
-import {Tooltip} from "./Tooltip";
+import {Arrow, getTooltipPosition, Tooltip} from "./Tooltip";
 import {renderWithTheme} from "./test-utils";
 
 // Minimal shape of the tree returned by toJSON() that we rely on here.
@@ -20,11 +19,14 @@ interface TestNode {
   children: null | Array<TestNode | string>;
 }
 
-// Mock react-native-portalize so Portal renders inline in tests
-mock.module("react-native-portalize", () => ({
-  Host: ({children}: {children: React.ReactNode}) => <View testID="portal-host">{children}</View>,
-  Portal: ({children}: {children: React.ReactNode}) => <View testID="portal">{children}</View>,
-}));
+type MeasureCallback = (
+  x: number,
+  y: number,
+  width: number,
+  height: number,
+  pageX: number,
+  pageY: number
+) => void;
 
 beforeAll(() => {
   globalThis.requestAnimationFrame = (callback: FrameRequestCallback) => {
@@ -274,6 +276,198 @@ describe("Tooltip", () => {
     }
   });
 
+  it("getTooltipPosition returns empty when not measured", () => {
+    const result = getTooltipPosition({
+      children: {},
+      measured: false,
+      tooltip: {},
+    });
+    expect(result).toEqual({});
+  });
+
+  it("getTooltipPosition places tooltip at top (default) when space allows", () => {
+    const result = getTooltipPosition({
+      children: {height: 40, pageX: 200, pageY: 300, width: 100},
+      idealPosition: "top",
+      measured: true,
+      tooltip: {height: 30, width: 150, x: 0, y: 0},
+    });
+    expect(result).toHaveProperty("finalPosition", "top");
+    expect(result).toHaveProperty("top");
+    expect(result).toHaveProperty("left");
+  });
+
+  it("getTooltipPosition places tooltip at bottom when specified", () => {
+    const result = getTooltipPosition({
+      children: {height: 40, pageX: 200, pageY: 100, width: 100},
+      idealPosition: "bottom",
+      measured: true,
+      tooltip: {height: 30, width: 150, x: 0, y: 0},
+    });
+    expect(result).toHaveProperty("finalPosition", "bottom");
+  });
+
+  it("getTooltipPosition places tooltip at left when space allows", () => {
+    const result = getTooltipPosition({
+      children: {height: 40, pageX: 400, pageY: 200, width: 100},
+      idealPosition: "left",
+      measured: true,
+      tooltip: {height: 30, width: 150, x: 0, y: 0},
+    });
+    expect(result).toHaveProperty("finalPosition", "left");
+  });
+
+  it("getTooltipPosition places tooltip at right when specified", () => {
+    const result = getTooltipPosition({
+      children: {height: 40, pageX: 50, pageY: 200, width: 100},
+      idealPosition: "right",
+      measured: true,
+      tooltip: {height: 30, width: 150, x: 0, y: 0},
+    });
+    expect(result).toHaveProperty("finalPosition", "right");
+  });
+
+  it("getTooltipPosition falls back to bottom when top overflows", () => {
+    const result = getTooltipPosition({
+      children: {height: 40, pageX: 200, pageY: 5, width: 100},
+      idealPosition: "top",
+      measured: true,
+      tooltip: {height: 30, width: 150, x: 0, y: 0},
+    });
+    expect(result).toHaveProperty("finalPosition", "bottom");
+  });
+
+  it("getTooltipPosition falls back to top when bottom overflows", () => {
+    const {Dimensions} = require("react-native");
+    const origGet = Dimensions.get;
+    Dimensions.get = () => ({fontScale: 1, height: 200, scale: 1, width: 800});
+    try {
+      const result = getTooltipPosition({
+        children: {height: 40, pageX: 200, pageY: 160, width: 100},
+        idealPosition: "bottom",
+        measured: true,
+        tooltip: {height: 30, width: 150, x: 0, y: 0},
+      });
+      expect(result).toHaveProperty("finalPosition", "top");
+    } finally {
+      Dimensions.get = origGet;
+    }
+  });
+
+  it("getTooltipPosition falls back to bottom when right overflows", () => {
+    const {Dimensions} = require("react-native");
+    const origGet = Dimensions.get;
+    Dimensions.get = () => ({fontScale: 1, height: 800, scale: 1, width: 300});
+    try {
+      const result = getTooltipPosition({
+        children: {height: 40, pageX: 200, pageY: 200, width: 100},
+        idealPosition: "right",
+        measured: true,
+        tooltip: {height: 30, width: 150, x: 0, y: 0},
+      });
+      // Fallback order is: bottom -> top -> left -> right
+      expect(result).toHaveProperty("finalPosition", "bottom");
+    } finally {
+      Dimensions.get = origGet;
+    }
+  });
+
+  it("getTooltipPosition falls back to left when right, bottom, and top overflow", () => {
+    const {Dimensions} = require("react-native");
+    const origGet = Dimensions.get;
+    Dimensions.get = () => ({fontScale: 1, height: 80, scale: 1, width: 300});
+    try {
+      const result = getTooltipPosition({
+        children: {height: 40, pageX: 200, pageY: 20, width: 40},
+        idealPosition: "right",
+        measured: true,
+        tooltip: {height: 30, width: 150, x: 0, y: 0},
+      });
+      expect(result).toHaveProperty("finalPosition", "left");
+    } finally {
+      Dimensions.get = origGet;
+    }
+  });
+
+  it("getTooltipPosition falls back to right when all other directions overflow", () => {
+    const {Dimensions} = require("react-native");
+    const origGet = Dimensions.get;
+    Dimensions.get = () => ({fontScale: 1, height: 50, scale: 1, width: 50});
+    try {
+      const result = getTooltipPosition({
+        children: {height: 40, pageX: 5, pageY: 5, width: 40},
+        idealPosition: "top",
+        measured: true,
+        tooltip: {height: 30, width: 150, x: 0, y: 0},
+      });
+      expect(result).toHaveProperty("finalPosition", "right");
+    } finally {
+      Dimensions.get = origGet;
+    }
+  });
+
+  it("getTooltipPosition with no idealPosition defaults to top", () => {
+    const result = getTooltipPosition({
+      children: {height: 40, pageX: 200, pageY: 300, width: 100},
+      measured: true,
+      tooltip: {height: 30, width: 150, x: 0, y: 0},
+    });
+    expect(result).toHaveProperty("finalPosition", "top");
+  });
+
+  it("getTooltipPosition falls back when left placement overflows", () => {
+    const result = getTooltipPosition({
+      children: {height: 40, pageX: 10, pageY: 200, width: 100},
+      idealPosition: "left",
+      measured: true,
+      tooltip: {height: 30, width: 150, x: 0, y: 0},
+    });
+    // Left overflows, should fall back to bottom (first available)
+    expect(result).toHaveProperty("finalPosition");
+    const pos = (result as {finalPosition: string}).finalPosition;
+    expect(["top", "bottom", "right"]).toContain(pos);
+  });
+
+  it("Arrow renders for each position", () => {
+    const positions = ["top", "bottom", "left", "right"] as const;
+    for (const position of positions) {
+      const {toJSON} = renderWithTheme(<Arrow color="#333" position={position} />);
+      expect(toJSON()).toBeTruthy();
+    }
+  });
+
+  it("exercises handleClick to hide visible tooltip on web press", async () => {
+    const {queryByTestId, toJSON} = renderWithTheme(
+      <Tooltip text="Click hides">
+        <Text>Click me</Text>
+      </Tooltip>
+    );
+
+    const tree = toJSON() as TestNode;
+    const root = tree.children?.[0] as TestNode;
+
+    // Show the tooltip
+    await act(async () => {
+      root.props.onPointerEnter?.();
+    });
+    await act(async () => {
+      await new Promise((resolve) => setTimeout(resolve, 900));
+    });
+    expect(queryByTestId("tooltip-container")).toBeTruthy();
+
+    // Find the wrapper and trigger onPress (web click)
+    const treeAfter = toJSON() as TestNode;
+    const wrapper = (treeAfter.children as Array<TestNode | string>)[
+      (treeAfter.children as Array<TestNode | string>).length - 1
+    ] as TestNode;
+
+    if (wrapper.props && "onPress" in wrapper.props) {
+      await act(async () => {
+        (wrapper.props as {onPress?: () => void}).onPress?.();
+      });
+    }
+  });
+
   it("renders tooltip with arrow at all idealPositions", async () => {
     const positions: Array<"top" | "bottom" | "left" | "right"> = [
       "top",
@@ -308,4 +502,388 @@ describe("Tooltip", () => {
     // No assertions needed - just ensuring no crashes on unmount.
     expect(true).toBe(true);
   });
+
+  it("hides tooltip when pressing on the tooltip container", async () => {
+    const {queryByTestId, toJSON, getByTestId} = renderWithTheme(
+      <Tooltip text="Click to hide">
+        <Text>Hover me</Text>
+      </Tooltip>
+    );
+
+    const tree = toJSON() as TestNode;
+    const root = tree.children?.[0] as TestNode;
+
+    await act(async () => {
+      root.props.onPointerEnter?.();
+    });
+    await act(async () => {
+      await new Promise((resolve) => setTimeout(resolve, 900));
+    });
+    expect(queryByTestId("tooltip-container")).toBeTruthy();
+
+    const {fireEvent} = await import("@testing-library/react-native");
+    await act(async () => {
+      fireEvent.press(getByTestId("tooltip-container"));
+    });
+    expect(queryByTestId("tooltip-container")).toBeNull();
+  });
+
+  it("handleClick does nothing when tooltip is not visible", async () => {
+    const {queryByTestId, toJSON} = renderWithTheme(
+      <Tooltip text="Click test">
+        <Text>Click me</Text>
+      </Tooltip>
+    );
+
+    const tree = toJSON() as TestNode;
+    const root = tree.children?.[0] as TestNode;
+
+    // Call onPress when tooltip is not visible (no-op)
+    await act(async () => {
+      (root.props as {onPress?: () => void}).onPress?.();
+    });
+    expect(queryByTestId("tooltip-container")).toBeNull();
+  });
+
+  it("handles onLayout with measure callback and sets position", async () => {
+    const {queryByTestId, toJSON, UNSAFE_getAllByType} = renderWithTheme(
+      <Tooltip idealPosition="top" includeArrow text="Layout position test">
+        <Text>Trigger</Text>
+      </Tooltip>
+    );
+
+    const tree = toJSON() as TestNode;
+    const root = tree.children?.[0] as TestNode;
+
+    // Show the tooltip first
+    await act(async () => {
+      root.props.onTouchStart?.({nativeEvent: {}});
+    });
+    await act(async () => {
+      await new Promise((resolve) => setTimeout(resolve, 150));
+    });
+    expect(queryByTestId("tooltip-container")).toBeTruthy();
+
+    const {View: ViewComp} = await import("react-native");
+    const allViews = UNSAFE_getAllByType(ViewComp);
+    for (const v of allViews) {
+      const props = v.props as TestNode["props"];
+      if (props.onLayout) {
+        await act(async () => {
+          props.onLayout?.({
+            nativeEvent: {
+              layout: {height: 40, width: 200, x: 0, y: 0},
+            },
+          });
+        });
+      }
+    }
+  });
+
+  it("exercises getTooltipPosition with all ideal positions", async () => {
+    const positions: Array<"top" | "bottom" | "left" | "right"> = [
+      "top",
+      "bottom",
+      "left",
+      "right",
+    ];
+
+    for (const pos of positions) {
+      const {queryByTestId, toJSON, UNSAFE_getAllByType, unmount} = renderWithTheme(
+        <Tooltip idealPosition={pos} includeArrow text={`${pos} test`}>
+          <Text>Position {pos}</Text>
+        </Tooltip>
+      );
+
+      const tree = toJSON() as TestNode;
+      const root = tree.children?.[0] as TestNode;
+
+      await act(async () => {
+        root.props.onTouchStart?.({nativeEvent: {}});
+      });
+      await act(async () => {
+        await new Promise((resolve) => setTimeout(resolve, 150));
+      });
+      expect(queryByTestId("tooltip-container")).toBeTruthy();
+
+      const {View: ViewComp} = await import("react-native");
+      const allViews = UNSAFE_getAllByType(ViewComp);
+      for (const v of allViews) {
+        const props = v.props as TestNode["props"];
+        if (props.onLayout) {
+          await act(async () => {
+            props.onLayout?.({
+              nativeEvent: {
+                layout: {height: 30, width: 100, x: 50, y: 50},
+              },
+            });
+          });
+        }
+      }
+      unmount();
+    }
+  });
+
+  it("renders arrow styles for all positions when tooltip is shown with arrow", async () => {
+    const positions: Array<"top" | "bottom" | "left" | "right"> = [
+      "top",
+      "bottom",
+      "left",
+      "right",
+    ];
+
+    for (const pos of positions) {
+      const {queryByTestId, toJSON, unmount} = renderWithTheme(
+        <Tooltip idealPosition={pos} includeArrow text={`Arrow ${pos}`}>
+          <Text>Arrow</Text>
+        </Tooltip>
+      );
+
+      const tree = toJSON() as TestNode;
+      const root = tree.children?.[0] as TestNode;
+
+      await act(async () => {
+        root.props.onPointerEnter?.();
+      });
+      await act(async () => {
+        await new Promise((resolve) => setTimeout(resolve, 900));
+      });
+      expect(queryByTestId("tooltip-container")).toBeTruthy();
+      unmount();
+    }
+  });
+
+  it("mobilePressProps fires children onClick when not touched", async () => {
+    const onClick = mock(() => {});
+    const TestChild: React.FC<{onClick?: () => void}> = () => <Text>Pressable child</Text>;
+
+    const {toJSON} = renderWithTheme(
+      <Tooltip text="Mobile test">
+        <TestChild onClick={onClick} />
+      </Tooltip>
+    );
+
+    const tree = toJSON() as TestNode;
+    const root = tree.children?.[0] as TestNode;
+
+    // Fire onPress (mobilePressProps) without having touched first
+    await act(async () => {
+      (root.props as {onPress?: () => void}).onPress?.();
+    });
+    expect(onClick).toHaveBeenCalled();
+  });
+
+  it("getArrowContainerStyle returns empty when includeArrow is false", async () => {
+    const {queryByTestId, toJSON} = renderWithTheme(
+      <Tooltip text="No arrow test">
+        <Text>No arrow</Text>
+      </Tooltip>
+    );
+
+    const tree = toJSON() as TestNode;
+    const root = tree.children?.[0] as TestNode;
+
+    await act(async () => {
+      root.props.onPointerEnter?.();
+    });
+    await act(async () => {
+      await new Promise((resolve) => setTimeout(resolve, 900));
+    });
+    expect(queryByTestId("tooltip-container")).toBeTruthy();
+  });
+
+  describe("web platform behavior", () => {
+    let Platform: {OS: string};
+
+    beforeEach(async () => {
+      const rn = await import("react-native");
+      Platform = rn.Platform;
+      Platform.OS = "web";
+    });
+
+    afterEach(() => {
+      Platform.OS = "ios";
+    });
+
+    it("renders Arrow component when isWeb and includeArrow", async () => {
+      const {queryByTestId, toJSON} = renderWithTheme(
+        <Tooltip idealPosition="top" includeArrow text="Web arrow">
+          <Text>Arrow child</Text>
+        </Tooltip>
+      );
+
+      const tree = toJSON() as TestNode;
+      const root = tree.children?.[0] as TestNode;
+
+      await act(async () => {
+        root.props.onPointerEnter?.();
+      });
+      await act(async () => {
+        await new Promise((resolve) => setTimeout(resolve, 900));
+      });
+      expect(queryByTestId("tooltip-container")).toBeTruthy();
+    });
+
+    it("renders Arrow for all positions on web", async () => {
+      const positions: Array<"top" | "bottom" | "left" | "right"> = [
+        "top",
+        "bottom",
+        "left",
+        "right",
+      ];
+      for (const pos of positions) {
+        const {queryByTestId, toJSON, unmount} = renderWithTheme(
+          <Tooltip idealPosition={pos} includeArrow text={`Web ${pos}`}>
+            <Text>{pos}</Text>
+          </Tooltip>
+        );
+
+        const tree = toJSON() as TestNode;
+        const root = tree.children?.[0] as TestNode;
+
+        await act(async () => {
+          root.props.onTouchStart?.({nativeEvent: {}});
+        });
+        await act(async () => {
+          await new Promise((resolve) => setTimeout(resolve, 150));
+        });
+        expect(queryByTestId("tooltip-container")).toBeTruthy();
+        unmount();
+      }
+    });
+
+    it("handleClick hides tooltip on web when visible", async () => {
+      const {queryByTestId, toJSON} = renderWithTheme(
+        <Tooltip text="Web click hide">
+          <Text>Click me</Text>
+        </Tooltip>
+      );
+
+      const tree = toJSON() as TestNode;
+      const root = tree.children?.[0] as TestNode;
+
+      await act(async () => {
+        root.props.onPointerEnter?.();
+      });
+      await act(async () => {
+        await new Promise((resolve) => setTimeout(resolve, 900));
+      });
+      expect(queryByTestId("tooltip-container")).toBeTruthy();
+
+      // On web, onPress is handleClick which hides tooltip when visible
+      const treeAfter = toJSON() as TestNode;
+      const wrapper = (treeAfter.children as TestNode[]).find(
+        (c: TestNode) => c.props && (c.props as {hitSlop?: object}).hitSlop !== undefined
+      ) as TestNode | undefined;
+      await act(async () => {
+        (wrapper?.props as {onPress?: () => void}).onPress?.();
+      });
+      expect(queryByTestId("tooltip-container")).toBeNull();
+    });
+
+    it("exercises measure callback and getTooltipPosition for all positions", async () => {
+      const positions: Array<"top" | "bottom" | "left" | "right"> = [
+        "top",
+        "bottom",
+        "left",
+        "right",
+      ];
+
+      for (const pos of positions) {
+        const {toJSON, UNSAFE_getAllByType, unmount} = renderWithTheme(
+          <Tooltip idealPosition={pos} includeArrow text={`Measure ${pos}`}>
+            <Text>{pos}</Text>
+          </Tooltip>
+        );
+
+        const tree = toJSON() as TestNode;
+        const root = tree.children?.[0] as TestNode;
+
+        await act(async () => {
+          root.props.onTouchStart?.({nativeEvent: {}});
+        });
+        await act(async () => {
+          await new Promise((resolve) => setTimeout(resolve, 150));
+        });
+
+        // Find the ref-holding View (has hitSlop) and inject measure via fiber ref
+        const {View: ViewComp} = await import("react-native");
+        const allViews = UNSAFE_getAllByType(ViewComp);
+        for (const v of allViews) {
+          if (!(v.props as {hitSlop?: object}).hitSlop) {
+            continue;
+          }
+          const fiber = (v as unknown as {_fiber?: {ref?: {current: unknown}}})._fiber;
+          if (fiber?.ref && typeof fiber.ref === "object") {
+            const pageX = pos === "left" ? 400 : pos === "right" ? 50 : 200;
+            const pageY = pos === "top" ? 400 : 100;
+            fiber.ref.current = {
+              measure: (cb: MeasureCallback) => {
+                cb(0, 0, 100, 40, pageX, pageY);
+              },
+            };
+          }
+        }
+
+        // Trigger onLayout to invoke measure and getTooltipPosition
+        for (const v of allViews) {
+          const props = v.props as TestNode["props"];
+          if (props.onLayout) {
+            await act(async () => {
+              props.onLayout?.({
+                nativeEvent: {layout: {height: 30, width: 80, x: 0, y: 0}},
+              });
+            });
+          }
+        }
+        unmount();
+      }
+    });
+
+    it("getTooltipPosition fallback when all positions overflow", async () => {
+      const {toJSON, UNSAFE_getAllByType, unmount} = renderWithTheme(
+        <Tooltip idealPosition="top" text="Overflow">
+          <Text>Overflow</Text>
+        </Tooltip>
+      );
+
+      const tree = toJSON() as TestNode;
+      const root = tree.children?.[0] as TestNode;
+
+      await act(async () => {
+        root.props.onTouchStart?.({nativeEvent: {}});
+      });
+      await act(async () => {
+        await new Promise((resolve) => setTimeout(resolve, 150));
+      });
+
+      const {View: ViewComp} = await import("react-native");
+      const allViews = UNSAFE_getAllByType(ViewComp);
+      for (const v of allViews) {
+        if (!(v.props as {hitSlop?: object}).hitSlop) {
+          continue;
+        }
+        const fiber = (v as unknown as {_fiber?: {ref?: {current: unknown}}})._fiber;
+        if (fiber?.ref && typeof fiber.ref === "object") {
+          fiber.ref.current = {
+            measure: (cb: MeasureCallback) => {
+              cb(0, 0, 900, 900, 0, 0);
+            },
+          };
+        }
+      }
+
+      for (const v of allViews) {
+        const props = v.props as TestNode["props"];
+        if (props.onLayout) {
+          await act(async () => {
+            props.onLayout?.({
+              nativeEvent: {layout: {height: 900, width: 900, x: 0, y: 0}},
+            });
+          });
+        }
+      }
+      unmount();
+    });
+  });
 });

package/src/Tooltip.tsx

@@ -39,7 +39,7 @@ interface ChildrenProps {
   onHoverOut?: () => void;
 }
 
-const getTooltipPosition = ({
+export const getTooltipPosition = ({
   children,
   tooltip,
   measured,
@@ -117,7 +117,7 @@ const getTooltipPosition = ({
   }
 };
 
-const Arrow: FC<{position: TooltipPosition; color: string}> = ({position, color}) => {
+export const Arrow: FC<{position: TooltipPosition; color: string}> = ({position, color}) => {
   const getArrowStyle = (): ViewStyle => {
     const arrowStyles = {
       bottom: {