@terreno/ui 0.13.3 → 0.14.0

package/src/SplitPage.tsx

@@ -40,6 +40,7 @@ export const SplitPage = ({
   const elementArray = Children.toArray(children).filter((c) => c !== null);
 
   const onItemSelect = useCallback(
+    // biome-ignore lint/suspicious/noExplicitAny: SplitPage accepts heterogeneous list item shapes from consumers; the generic propagates from listViewData
     async (item: ListRenderItemInfo<any>): Promise<void> => {
       setSelectedId(item.index);
       await onSelectionChange(item);
@@ -69,6 +70,7 @@ export const SplitPage = ({
     return null;
   }
 
+  // biome-ignore lint/suspicious/noExplicitAny: SplitPage accepts heterogeneous list item shapes from consumers; the generic propagates from listViewData
   const renderItem = (itemInfo: ListRenderItemInfo<any>) => {
     return (
       <Box
@@ -297,7 +299,10 @@ export const SplitPage = ({
       padding={2}
       width="100%"
     >
-      {loading === true && <Spinner color={theme.text.primary as any} size="md" />}
+      {loading === true && (
+        // biome-ignore lint/suspicious/noExplicitAny: Spinner color is a token enum but the legacy code passes theme.text.primary (a resolved hex string); preserving original behavior
+        <Spinner color={theme.text.primary as any} size="md" />
+      )}
       {isMobileDevice ? renderMobileSplitPage() : renderSplitPage()}
     </Box>
   );

package/src/TapToEdit.test.tsx

@@ -1,3 +1,4 @@
+// biome-ignore-all lint/suspicious/noExplicitAny: test mock typing
 import {describe, expect, it, mock} from "bun:test";
 import {act, fireEvent} from "@testing-library/react-native";
 import {Linking} from "react-native";
@@ -211,6 +212,22 @@ describe("TapToEdit", () => {
     expect(setValue).toHaveBeenCalled();
   });
 
+  it("reverts to original value (not edited value) when Cancel is pressed", async () => {
+    const setValue = mock((_v: unknown) => {});
+    const {getByLabelText, getByText} = renderWithTheme(
+      <TapToEdit setValue={setValue} title="Name" value="Jane" />
+    );
+    await act(async () => {
+      fireEvent.press(getByLabelText("Edit"));
+    });
+    // Simulate user having changed the value during editing
+    setValue("Edited Value");
+    await act(async () => {
+      fireEvent.press(getByText("Cancel"));
+    });
+    expect(setValue).toHaveBeenLastCalledWith("Jane");
+  });
+
   it("clears value when Clear button is pressed", async () => {
     const setValue = mock(() => {});
     const onSave = mock(() => Promise.resolve());

package/src/TapToEdit.tsx

@@ -81,15 +81,11 @@ export const TapToEdit: FC<TapToEditProps> = ({
   ...fieldProps
 }) => {
   const [editing, setEditing] = useState(false);
-  const [initialValue, setInitialValue] = useState();
+  const initialValueRef = useRef<unknown>(undefined);
   const helperText: string | undefined = propsHelperText;
-  // setInitialValue is called after initial render to handle the case where the value is updated
-  useEffect(() => {
-    setInitialValue(value);
-    // do not update if value changes
-  }, [value]);
 
   // TODO: Auto focus on input when editing for field types other than text for accessibility
+  // biome-ignore lint/suspicious/noExplicitAny: inputRef references various RN input components (TextInput, etc.) depending on the field type
   const inputRef = useRef<any>(null);
 
   // bring the bring the input into focus when editing from within the component,
@@ -116,13 +112,16 @@ export const TapToEdit: FC<TapToEditProps> = ({
             helperText={helperText}
             inputRef={
               ["text", "textarea", "url", "email", "number"].includes(fieldProps?.type)
-                ? (ref: any) => (inputRef.current = ref)
+                ? (ref: unknown) => {
+                    inputRef.current = ref;
+                  }
                 : undefined
             }
             onChange={setValue ?? (() => {})}
             row={fieldProps?.type === "textarea" ? 5 : undefined}
             type={(fieldProps?.type ?? "text") as NonNullable<FieldProps["type"]>}
             value={value}
+            // biome-ignore lint/suspicious/noExplicitAny: fieldProps is a discriminated union (FieldProps) but the spread loses narrowing; type-checking each variant individually is impractical here
             {...(fieldProps as any)}
           />
           {editing && !isEditing && (
@@ -130,7 +129,7 @@ export const TapToEdit: FC<TapToEditProps> = ({
               <Button
                 onClick={(): void => {
                   if (setValue) {
-                    setValue(initialValue);
+                    setValue(initialValueRef.current);
                   }
                   setEditing(false);
                 }}
@@ -142,7 +141,6 @@ export const TapToEdit: FC<TapToEditProps> = ({
                   onClick={(): void => {
                     if (setValue) {
                       setValue("");
-                      setInitialValue("" as any);
                     }
                     if (onSave) {
                       onSave("");
@@ -161,7 +159,6 @@ export const TapToEdit: FC<TapToEditProps> = ({
                     if (!onSave) {
                       console.error("No onSave provided for editable TapToEdit");
                     } else {
-                      setInitialValue(value);
                       await onSave(value);
                     }
                     setEditing(false);
@@ -271,7 +268,10 @@ export const TapToEdit: FC<TapToEditProps> = ({
                 accessibilityHint=""
                 accessibilityLabel="Edit"
                 marginLeft={2}
-                onClick={(): void => setEditing(true)}
+                onClick={(): void => {
+                  initialValueRef.current = value;
+                  setEditing(true);
+                }}
                 width={16}
               >
                 <Icon iconName="pencil" size="md" />

package/src/Toast.tsx

@@ -48,7 +48,7 @@ export const useToast = (): {
   };
   return {
     catch: (error: unknown, message?: string, options?: UseToastVariantOptions): void => {
-      let exceptionMsg;
+      let exceptionMsg: string;
       if (isAPIError(error)) {
         // Get the error without details.
         exceptionMsg = `${message}: ${printAPIError(error)}`;

package/src/ToastNotifications.tsx

@@ -177,10 +177,7 @@ export interface ToastOptions {
   /**
    * Payload data for custom toasts. You can pass whatever you want
    */
-  // noExplicitAny: This is the public API of a vendored 3rd-party library
-  // (react-native-toast-notifications); the `data` field is an opaque
-  // user-provided payload. Tightening to `unknown` breaks downstream consumers
-  // that spread `data` into `Toast` (e.g. TerrenoProvider) without refactor.
+  // biome-ignore lint/suspicious/noExplicitAny: This is the public API of a vendored 3rd-party library (react-native-toast-notifications); the data field is an opaque user-provided payload. Tightening to unknown breaks downstream consumers that spread data into Toast (e.g. TerrenoProvider) without refactor.
   data?: any;
 
   swipeEnabled?: boolean;

package/src/Tooltip.test.tsx

@@ -1,6 +1,5 @@
 import {beforeAll, describe, expect, it, mock} from "bun:test";
 import {act} from "@testing-library/react-native";
-import {View} from "react-native";
 
 import {Text} from "./Text";
 import {Tooltip} from "./Tooltip";
@@ -20,12 +19,6 @@ interface TestNode {
   children: null | Array<TestNode | string>;
 }
 
-// Mock react-native-portalize so Portal renders inline in tests
-mock.module("react-native-portalize", () => ({
-  Host: ({children}: {children: React.ReactNode}) => <View testID="portal-host">{children}</View>,
-  Portal: ({children}: {children: React.ReactNode}) => <View testID="portal">{children}</View>,
-}));
-
 beforeAll(() => {
   globalThis.requestAnimationFrame = (callback: FrameRequestCallback) => {
     return setTimeout(() => callback(Date.now()), 0) as unknown as number;

package/src/Unifier.ts

@@ -8,6 +8,7 @@ import {requestPermissions} from "./Permissions";
 
 declare global {
   interface Window {
+    // biome-ignore lint/suspicious/noExplicitAny: Google Maps JS SDK global type is loaded dynamically and not bundled as a typed dependency
     google: any;
   }
 }
@@ -25,7 +26,7 @@ export function changeColorLuminance(hex: string, luminanceChange: Luminance) {
   } else if (hex.length !== 6) {
     throw new Error(`Invalid color hex: ${hex}`);
   }
-  let luminance;
+  let luminance: number;
   switch (luminanceChange) {
     case "light":
       luminance = -0.2;
@@ -127,7 +128,7 @@ class UnifierClass {
   };
 
   storage = {
-    getItem: async (key: string, defaultValue?: any) => {
+    getItem: async (key: string, defaultValue?: unknown) => {
       try {
         const jsonValue = await AsyncStorage.getItem(key);
         if (jsonValue) {
@@ -147,13 +148,13 @@ class UnifierClass {
         return defaultValue || null;
       }
     },
-    setItem: async (key: string, item: any) => {
+    setItem: async (key: string, item: unknown) => {
       try {
         const jsonValue = JSON.stringify(item);
         await AsyncStorage.setItem(key, jsonValue);
-      } catch (error: any) {
+      } catch (error: unknown) {
         console.error(`[storage] Error storing ${key}`, item, error);
-        throw new Error(error);
+        throw new Error(error instanceof Error ? error.message : String(error));
       }
     },
   };

package/src/Utilities.tsx

@@ -6,7 +6,10 @@ import {Platform} from "react-native";
 import type {APIError, BaseProfile, IconSize} from "./Common";
 import {COUNTY_AND_COUNTY_EQUIVALENT_ENTITIES} from "./Constants";
 
-export function mergeInlineStyles(inlineStyle?: any, newStyle?: any) {
+export function mergeInlineStyles(
+  inlineStyle?: {__style?: Record<string, unknown>} | undefined,
+  newStyle?: Record<string, unknown> | undefined
+) {
   const inline = get(inlineStyle, "__style");
   return {
     __style: {
@@ -104,7 +107,7 @@ export const toProps = ({
   className,
   inlineStyle,
 }: Style): {className: string; style: InlineStyle} => {
-  const props: any = {};
+  const props: {className?: string; style?: InlineStyle} = {};
 
   if (className.size > 0) {
     // Sorting here ensures that classNames are always stable, reducing diff
@@ -117,7 +120,7 @@ export const toProps = ({
     props.style = inlineStyle;
   }
 
-  return props;
+  return props as {className: string; style: InlineStyle};
 };
 
 /*
@@ -173,7 +176,7 @@ export function bind<T>(
     | {
         readonly [key: string]: string;
       }
-    | any
+    | Record<string, string>
 ): (val: T) => Style {
   const map = mapClassName((name) => scope[name]);
   return (val: T): Style => map(fn(val));
@@ -316,8 +319,8 @@ export function formattedCountyCode(state: string, countyName: string): string {
   return `${countyData.stateFP}${countyData.countyFP}`;
 }
 
-export function isAPIError(error: any): error is APIError {
-  return error?.data?.title;
+export function isAPIError(error: unknown): error is APIError {
+  return Boolean((error as {data?: {title?: unknown}} | null | undefined)?.data?.title);
 }
 
 export function printAPIError(error: APIError, details = true): string {

package/src/__snapshots__/AddressField.test.tsx.snap

@@ -1117,7 +1117,9 @@ exports[`AddressField renders correctly with default props 1`] = `
           },
         ],
         "props": {
-          "style": undefined,
+          "style": {
+            "width": "100%",
+          },
           "testID": undefined,
         },
         "type": "View",

package/src/__snapshots__/Button.test.tsx.snap

@@ -45,9 +45,12 @@ exports[`Button renders correctly with default props 1`] = `
   ],
   "props": {
     "accessibilityHint": "Press to perform action",
-    "aria-label": "Click me",
-    "aria-role": "button",
-    "disabled": undefined,
+    "accessibilityLabel": "Click me",
+    "accessibilityRole": "button",
+    "accessibilityState": {
+      "disabled": false,
+    },
+    "disabled": false,
     "onPress": [Function: debounced],
     "style": {
       "alignItems": "center",
@@ -64,7 +67,7 @@ exports[`Button renders correctly with default props 1`] = `
     },
     "testID": undefined,
   },
-  "type": "Pressable",
+  "type": "PressableScale",
 }
 `;
 
@@ -113,9 +116,12 @@ exports[`Button renders primary variant 1`] = `
   ],
   "props": {
     "accessibilityHint": "Press to perform action",
-    "aria-label": "Primary",
-    "aria-role": "button",
-    "disabled": undefined,
+    "accessibilityLabel": "Primary",
+    "accessibilityRole": "button",
+    "accessibilityState": {
+      "disabled": false,
+    },
+    "disabled": false,
     "onPress": [Function: debounced],
     "style": {
       "alignItems": "center",
@@ -132,7 +138,7 @@ exports[`Button renders primary variant 1`] = `
     },
     "testID": undefined,
   },
-  "type": "Pressable",
+  "type": "PressableScale",
 }
 `;
 
@@ -181,9 +187,12 @@ exports[`Button renders secondary variant 1`] = `
   ],
   "props": {
     "accessibilityHint": "Press to perform action",
-    "aria-label": "Secondary",
-    "aria-role": "button",
-    "disabled": undefined,
+    "accessibilityLabel": "Secondary",
+    "accessibilityRole": "button",
+    "accessibilityState": {
+      "disabled": false,
+    },
+    "disabled": false,
     "onPress": [Function: debounced],
     "style": {
       "alignItems": "center",
@@ -200,7 +209,7 @@ exports[`Button renders secondary variant 1`] = `
     },
     "testID": undefined,
   },
-  "type": "Pressable",
+  "type": "PressableScale",
 }
 `;
 
@@ -249,9 +258,12 @@ exports[`Button renders muted variant 1`] = `
   ],
   "props": {
     "accessibilityHint": "Press to perform action",
-    "aria-label": "Muted",
-    "aria-role": "button",
-    "disabled": undefined,
+    "accessibilityLabel": "Muted",
+    "accessibilityRole": "button",
+    "accessibilityState": {
+      "disabled": false,
+    },
+    "disabled": false,
     "onPress": [Function: debounced],
     "style": {
       "alignItems": "center",
@@ -268,7 +280,7 @@ exports[`Button renders muted variant 1`] = `
     },
     "testID": undefined,
   },
-  "type": "Pressable",
+  "type": "PressableScale",
 }
 `;
 
@@ -317,9 +329,12 @@ exports[`Button renders outline variant 1`] = `
   ],
   "props": {
     "accessibilityHint": "Press to perform action",
-    "aria-label": "Outline",
-    "aria-role": "button",
-    "disabled": undefined,
+    "accessibilityLabel": "Outline",
+    "accessibilityRole": "button",
+    "accessibilityState": {
+      "disabled": false,
+    },
+    "disabled": false,
     "onPress": [Function: debounced],
     "style": {
       "alignItems": "center",
@@ -336,7 +351,7 @@ exports[`Button renders outline variant 1`] = `
     },
     "testID": undefined,
   },
-  "type": "Pressable",
+  "type": "PressableScale",
 }
 `;
 
@@ -385,9 +400,12 @@ exports[`Button renders destructive variant 1`] = `
   ],
   "props": {
     "accessibilityHint": "Press to perform action",
-    "aria-label": "Delete",
-    "aria-role": "button",
-    "disabled": undefined,
+    "accessibilityLabel": "Delete",
+    "accessibilityRole": "button",
+    "accessibilityState": {
+      "disabled": false,
+    },
+    "disabled": false,
     "onPress": [Function: debounced],
     "style": {
       "alignItems": "center",
@@ -404,7 +422,7 @@ exports[`Button renders destructive variant 1`] = `
     },
     "testID": undefined,
   },
-  "type": "Pressable",
+  "type": "PressableScale",
 }
 `;
 
@@ -453,8 +471,11 @@ exports[`Button renders disabled state 1`] = `
   ],
   "props": {
     "accessibilityHint": "Press to perform action",
-    "aria-label": "Disabled",
-    "aria-role": "button",
+    "accessibilityLabel": "Disabled",
+    "accessibilityRole": "button",
+    "accessibilityState": {
+      "disabled": true,
+    },
     "disabled": true,
     "onPress": [Function: debounced],
     "style": {
@@ -521,8 +542,11 @@ exports[`Button applies disabled styles when disabled 1`] = `
   ],
   "props": {
     "accessibilityHint": "Press to perform action",
-    "aria-label": "Disabled",
-    "aria-role": "button",
+    "accessibilityLabel": "Disabled",
+    "accessibilityRole": "button",
+    "accessibilityState": {
+      "disabled": true,
+    },
     "disabled": true,
     "onPress": [Function: debounced],
     "style": {
@@ -612,8 +636,11 @@ exports[`Button renders loading state 1`] = `
   ],
   "props": {
     "accessibilityHint": "Press to perform action",
-    "aria-label": "Loading",
-    "aria-role": "button",
+    "accessibilityLabel": "Loading",
+    "accessibilityRole": "button",
+    "accessibilityState": {
+      "disabled": true,
+    },
     "disabled": true,
     "onPress": [Function: debounced],
     "style": {
@@ -680,9 +707,12 @@ exports[`Button renders fullWidth button 1`] = `
   ],
   "props": {
     "accessibilityHint": "Press to perform action",
-    "aria-label": "Full Width",
-    "aria-role": "button",
-    "disabled": undefined,
+    "accessibilityLabel": "Full Width",
+    "accessibilityRole": "button",
+    "accessibilityState": {
+      "disabled": false,
+    },
+    "disabled": false,
     "onPress": [Function: debounced],
     "style": {
       "alignItems": "center",
@@ -699,7 +729,7 @@ exports[`Button renders fullWidth button 1`] = `
     },
     "testID": undefined,
   },
-  "type": "Pressable",
+  "type": "PressableScale",
 }
 `;
 
@@ -761,9 +791,12 @@ exports[`Button renders with icon on left 1`] = `
   ],
   "props": {
     "accessibilityHint": "Press to perform action",
-    "aria-label": "With Icon",
-    "aria-role": "button",
-    "disabled": undefined,
+    "accessibilityLabel": "With Icon",
+    "accessibilityRole": "button",
+    "accessibilityState": {
+      "disabled": false,
+    },
+    "disabled": false,
     "onPress": [Function: debounced],
     "style": {
       "alignItems": "center",
@@ -780,7 +813,7 @@ exports[`Button renders with icon on left 1`] = `
     },
     "testID": undefined,
   },
-  "type": "Pressable",
+  "type": "PressableScale",
 }
 `;
 
@@ -842,9 +875,12 @@ exports[`Button renders with icon on right 1`] = `
   ],
   "props": {
     "accessibilityHint": "Press to perform action",
-    "aria-label": "Next",
-    "aria-role": "button",
-    "disabled": undefined,
+    "accessibilityLabel": "Next",
+    "accessibilityRole": "button",
+    "accessibilityState": {
+      "disabled": false,
+    },
+    "disabled": false,
     "onPress": [Function: debounced],
     "style": {
       "alignItems": "center",
@@ -861,7 +897,7 @@ exports[`Button renders with icon on right 1`] = `
     },
     "testID": undefined,
   },
-  "type": "Pressable",
+  "type": "PressableScale",
 }
 `;
 
@@ -910,9 +946,12 @@ exports[`Button renders with confirmation modal props 1`] = `
   ],
   "props": {
     "accessibilityHint": "Opens a confirmation dialog",
-    "aria-label": "Delete",
-    "aria-role": "button",
-    "disabled": undefined,
+    "accessibilityLabel": "Delete",
+    "accessibilityRole": "button",
+    "accessibilityState": {
+      "disabled": false,
+    },
+    "disabled": false,
     "onPress": [Function: debounced],
     "style": {
       "alignItems": "center",
@@ -929,7 +968,7 @@ exports[`Button renders with confirmation modal props 1`] = `
     },
     "testID": undefined,
   },
-  "type": "Pressable",
+  "type": "PressableScale",
 }
 `;
 
@@ -978,9 +1017,12 @@ exports[`Button renders with tooltip on desktop (wrapped in Tooltip) 1`] = `
   ],
   "props": {
     "accessibilityHint": "Press to perform action",
-    "aria-label": "Hover me",
-    "aria-role": "button",
-    "disabled": undefined,
+    "accessibilityLabel": "Hover me",
+    "accessibilityRole": "button",
+    "accessibilityState": {
+      "disabled": false,
+    },
+    "disabled": false,
     "onPress": [Function: debounced],
     "style": {
       "alignItems": "center",
@@ -997,6 +1039,6 @@ exports[`Button renders with tooltip on desktop (wrapped in Tooltip) 1`] = `
     },
     "testID": undefined,
   },
-  "type": "Pressable",
+  "type": "PressableScale",
 }
 `;

package/src/__snapshots__/CustomSelectField.test.tsx.snap

@@ -283,7 +283,9 @@ exports[`CustomSelectField renders correctly with default props 1`] = `
             },
           ],
           "props": {
-            "style": undefined,
+            "style": {
+              "width": "100%",
+            },
             "testID": undefined,
           },
           "type": "View",
@@ -610,7 +612,9 @@ exports[`CustomSelectField renders with title 1`] = `
             },
           ],
           "props": {
-            "style": undefined,
+            "style": {
+              "width": "100%",
+            },
             "testID": undefined,
           },
           "type": "View",
@@ -922,7 +926,9 @@ exports[`CustomSelectField renders with placeholder 1`] = `
             },
           ],
           "props": {
-            "style": undefined,
+            "style": {
+              "width": "100%",
+            },
             "testID": undefined,
           },
           "type": "View",
@@ -1234,7 +1240,9 @@ exports[`CustomSelectField renders with selected value 1`] = `
             },
           ],
           "props": {
-            "style": undefined,
+            "style": {
+              "width": "100%",
+            },
             "testID": undefined,
           },
           "type": "View",
@@ -1546,7 +1554,9 @@ exports[`CustomSelectField renders with custom value (not in options) 1`] = `
             },
           ],
           "props": {
-            "style": undefined,
+            "style": {
+              "width": "100%",
+            },
             "testID": undefined,
           },
           "type": "View",
@@ -1964,7 +1974,9 @@ exports[`CustomSelectField renders disabled state 1`] = `
             },
           ],
           "props": {
-            "style": undefined,
+            "style": {
+              "width": "100%",
+            },
             "testID": undefined,
           },
           "type": "View",
@@ -2276,7 +2288,9 @@ exports[`CustomSelectField includes custom option in dropdown 1`] = `
             },
           ],
           "props": {
-            "style": undefined,
+            "style": {
+              "width": "100%",
+            },
             "testID": undefined,
           },
           "type": "View",