@terreno/ai 58.0.5 → 58.1.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (58) hide show
  1. package/CHANGELOG.md +58 -0
  2. package/dist/index.d.ts +2 -1
  3. package/dist/index.js +6 -2
  4. package/dist/models/gptHistory.js +4 -0
  5. package/dist/observability/feedback.d.ts +31 -0
  6. package/dist/observability/feedback.js +218 -0
  7. package/dist/observability/local/datasetStore.d.ts +7 -0
  8. package/dist/observability/local/datasetStore.js +48 -2
  9. package/dist/observability/local/models/obsReviewItem.js +6 -0
  10. package/dist/observability/local/models/obsScore.js +12 -1
  11. package/dist/observability/local/promptStore.d.ts +1 -0
  12. package/dist/observability/local/promptStore.js +1 -0
  13. package/dist/observability/local/reviewStore.d.ts +5 -0
  14. package/dist/observability/local/reviewStore.js +17 -0
  15. package/dist/observability/local/traceStore.d.ts +23 -0
  16. package/dist/observability/local/traceStore.js +121 -10
  17. package/dist/observability/observabilityApp.d.ts +1 -0
  18. package/dist/observability/observabilityApp.js +2 -0
  19. package/dist/observability/observabilityAppRegistry.d.ts +1 -0
  20. package/dist/observability/routes/traces.js +72 -0
  21. package/dist/observability/types.d.ts +8 -1
  22. package/dist/routes/gpt.js +42 -2
  23. package/dist/routes/gptHistories.js +42 -2
  24. package/dist/service/aiService.d.ts +4 -1
  25. package/dist/service/aiService.js +17 -2
  26. package/dist/service/chatTurn.js +10 -1
  27. package/dist/types/index.d.ts +4 -0
  28. package/dist/types/observability.d.ts +1 -1
  29. package/package.json +9 -9
  30. package/src/index.ts +8 -1
  31. package/src/models/gptHistory.ts +5 -0
  32. package/src/observability/feedback.test.ts +688 -0
  33. package/src/observability/feedback.ts +263 -0
  34. package/src/observability/local/datasetStore.ts +57 -2
  35. package/src/observability/local/models/obsReviewItem.ts +9 -0
  36. package/src/observability/local/models/obsScore.ts +18 -1
  37. package/src/observability/local/obsModels.test.ts +10 -2
  38. package/src/observability/local/promptStore.test.ts +2 -0
  39. package/src/observability/local/promptStore.ts +2 -0
  40. package/src/observability/local/reviewStore.test.ts +55 -0
  41. package/src/observability/local/reviewStore.ts +21 -0
  42. package/src/observability/local/traceStore.test.ts +239 -1
  43. package/src/observability/local/traceStore.ts +140 -9
  44. package/src/observability/observabilityApp.ts +2 -0
  45. package/src/observability/observabilityAppRegistry.ts +1 -0
  46. package/src/observability/routes/datasets.test.ts +253 -0
  47. package/src/observability/routes/prompts.test.ts +1 -0
  48. package/src/observability/routes/traces.test.ts +581 -3
  49. package/src/observability/routes/traces.ts +87 -1
  50. package/src/observability/types.ts +6 -1
  51. package/src/routes/gpt.test.ts +263 -1
  52. package/src/routes/gpt.ts +43 -2
  53. package/src/routes/gptHistories.ts +55 -2
  54. package/src/service/aiService.observability.test.ts +244 -0
  55. package/src/service/aiService.ts +15 -2
  56. package/src/service/chatTurn.ts +11 -2
  57. package/src/types/index.ts +4 -0
  58. package/src/types/observability.ts +1 -1
@@ -1,4 +1,5 @@
1
- import {afterEach, beforeEach, describe, expect, it} from "bun:test";
1
+ import {afterEach, beforeEach, describe, expect, it, spyOn} from "bun:test";
2
+ import {logger} from "@terreno/api";
2
3
  import {DateTime} from "luxon";
3
4
  import mongoose from "mongoose";
4
5
 
@@ -14,6 +15,7 @@ import {
14
15
  MemoryScoreSink,
15
16
  MemoryTraceSink,
16
17
  parseTraceListSort,
18
+ resetObsScoreIndexBuild,
17
19
  } from "./traceStore";
18
20
 
19
21
  const iso = (msAgo: number): string => {
@@ -417,3 +419,239 @@ describe("LocalTraceStore", () => {
417
419
  await expect(store.list({prompt: [operator]})).rejects.toMatchObject({status: 400});
418
420
  });
419
421
  });
422
+
423
+ describe("LocalTraceStore caller-supplied trace ids", () => {
424
+ let store: LocalTraceStore;
425
+
426
+ afterEach(() => {
427
+ resetObservabilityApp();
428
+ });
429
+
430
+ beforeEach(async () => {
431
+ new ObservabilityApp({plugins: [createLocalObservabilityPlugin()]});
432
+ store = new LocalTraceStore();
433
+ await registerObsTrace().deleteMany({});
434
+ await registerObsSpan().deleteMany({});
435
+ await registerObsScore().deleteMany({});
436
+ });
437
+
438
+ it("uses a valid ObjectId trace.id as _id and returns it", async () => {
439
+ const id = new mongoose.Types.ObjectId().toString();
440
+
441
+ const exported = await store.exportTrace(baseTrace({id}));
442
+
443
+ expect(String(exported.id)).toBe(id);
444
+ expect(await registerObsTrace().findById(id)).not.toBeNull();
445
+ });
446
+
447
+ it("stores a uuid trace.id under a generated ObjectId and ignores the uuid", async () => {
448
+ const uuid = "123e4567-e89b-42d3-a456-426614174000";
449
+
450
+ const exported = await store.exportTrace(baseTrace({id: uuid}));
451
+
452
+ expect(String(exported.id)).not.toBe(uuid);
453
+ expect(String(exported.id)).toMatch(/^[0-9a-f]{24}$/);
454
+ expect(await registerObsTrace().countDocuments({})).toBe(1);
455
+ });
456
+
457
+ it("spans exported with a caller-supplied id carry that trace id as traceId", async () => {
458
+ const id = new mongoose.Types.ObjectId().toString();
459
+
460
+ await store.exportTrace(baseTrace({id}));
461
+
462
+ const spans = await registerObsSpan().find({});
463
+ expect(spans.length).toBe(1);
464
+ expect(String(spans[0]?.traceId)).toBe(id);
465
+ });
466
+ describe("feedback filters", () => {
467
+ const newId = (): string => new mongoose.Types.ObjectId().toString();
468
+ const ids = async (query: Parameters<LocalTraceStore["list"]>[0]): Promise<string[]> => {
469
+ return (await store.list(query)).data.map((row) => String(row.id)).sort();
470
+ };
471
+ let a: string;
472
+ let b: string;
473
+ let c: string;
474
+ let d: string;
475
+
476
+ const vote = async (traceId: string, value: boolean, comment?: string): Promise<void> => {
477
+ await store.exportScore({
478
+ comment,
479
+ dataType: "boolean",
480
+ name: "thumbs_up",
481
+ source: "user-feedback",
482
+ traceId,
483
+ value,
484
+ });
485
+ };
486
+
487
+ beforeEach(async () => {
488
+ a = newId();
489
+ b = newId();
490
+ c = newId();
491
+ d = newId();
492
+ await store.exportTrace(
493
+ baseTrace({id: a, prompts: [{name: "example-summarize", version: 1}]})
494
+ );
495
+ await store.exportTrace(baseTrace({id: b, prompts: [{name: "other", version: 1}]}));
496
+ await store.exportTrace(baseTrace({id: c, prompts: [{name: "other", version: 1}]}));
497
+ await store.exportTrace(baseTrace({id: d, prompts: [{name: "other", version: 1}]}));
498
+ await vote(a, false, "too long");
499
+ await vote(b, true);
500
+ await store.exportScore({
501
+ dataType: "boolean",
502
+ name: "dismissed",
503
+ source: "user-signal",
504
+ traceId: c,
505
+ value: true,
506
+ });
507
+ });
508
+
509
+ it("thumbs=down matches only the thumbs-down trace", async () => {
510
+ expect(await ids({thumbs: "down"})).toEqual([a]);
511
+ });
512
+
513
+ it("thumbs=up matches only the thumbs-up trace", async () => {
514
+ expect(await ids({thumbs: "up"})).toEqual([b]);
515
+ });
516
+
517
+ it("signal=dismissed matches only the dismissed trace", async () => {
518
+ expect(await ids({signal: "dismissed"})).toEqual([c]);
519
+ });
520
+
521
+ it("signal matches only that signal name", async () => {
522
+ expect(await ids({signal: "copied"})).toEqual([]);
523
+ });
524
+
525
+ it("hasComment=true matches only the trace with a user-feedback comment", async () => {
526
+ expect(await ids({hasComment: true})).toEqual([a]);
527
+ });
528
+
529
+ it("hasComment=false matches every trace without a comment", async () => {
530
+ expect(await ids({hasComment: false})).toEqual([b, c, d].sort());
531
+ });
532
+
533
+ it("an empty comment does not count as a comment", async () => {
534
+ const e = newId();
535
+ await store.exportTrace(baseTrace({id: e}));
536
+ await vote(e, false, "");
537
+ expect(await ids({hasComment: true})).toEqual([a]);
538
+ });
539
+
540
+ it("a comment on a non user-feedback score does not count for hasComment", async () => {
541
+ await store.exportScore({
542
+ comment: "judge says no",
543
+ dataType: "boolean",
544
+ name: "judged",
545
+ source: "llm-judge",
546
+ traceId: d,
547
+ value: false,
548
+ });
549
+ expect(await ids({hasComment: true})).toEqual([a]);
550
+ });
551
+
552
+ it("a user-signal score does not match thumbs filters", async () => {
553
+ expect(await ids({thumbs: "down"})).not.toContain(c);
554
+ expect(await ids({thumbs: "up"})).not.toContain(c);
555
+ });
556
+
557
+ it("thumbs combines with the prompt filter", async () => {
558
+ expect(await ids({prompt: "example-summarize", thumbs: "down"})).toEqual([a]);
559
+ expect(await ids({prompt: "other", thumbs: "down"})).toEqual([]);
560
+ });
561
+
562
+ it("a deselected thumbs vote no longer matches thumbs, hasComment, or hasScore", async () => {
563
+ await store.deleteFeedbackScore({name: "thumbs_up", source: "user-feedback", traceId: a});
564
+ expect(await ids({thumbs: "down"})).toEqual([]);
565
+ expect(await ids({hasComment: true})).toEqual([]);
566
+ expect(await ids({hasComment: false})).toContain(a);
567
+ });
568
+
569
+ it("a changed vote matches its new direction only", async () => {
570
+ await vote(a, true, "actually fine");
571
+ expect(await ids({thumbs: "down"})).toEqual([]);
572
+ expect(await ids({thumbs: "up"})).toEqual([a, b].sort());
573
+ });
574
+
575
+ it("a deselected signal no longer matches", async () => {
576
+ await store.deleteFeedbackScore({name: "dismissed", source: "user-signal", traceId: c});
577
+ expect(await ids({signal: "dismissed"})).toEqual([]);
578
+ });
579
+
580
+ it("totals and pagination reflect the filtered set", async () => {
581
+ // The store returns totals under `meta` (the route derives `more` from them).
582
+ const page = await store.list({hasComment: false, limit: 1, page: 1});
583
+ expect(page.meta.total).toBe(3);
584
+ expect(page.data).toHaveLength(1);
585
+ expect(page.meta.page * page.meta.limit < page.meta.total).toBe(true);
586
+ });
587
+ });
588
+ });
589
+
590
+ describe("LocalTraceStore score index build failure", () => {
591
+ afterEach(() => {
592
+ resetObsScoreIndexBuild();
593
+ });
594
+
595
+ it("logs a failed index build and still upserts end-user scores", async () => {
596
+ resetObsScoreIndexBuild();
597
+ const ObsScore = registerObsScore();
598
+ // Existing duplicates make the unique index build fail with Mongo's duplicate-key code.
599
+ const duplicateError = Object.assign(new Error("E11000 duplicate key"), {code: 11000});
600
+ const initSpy = spyOn(ObsScore, "init").mockImplementation((() =>
601
+ Promise.reject(duplicateError)) as unknown as typeof ObsScore.init);
602
+ const errorSpy = spyOn(logger, "error").mockImplementation(() => logger);
603
+ const traceId = new mongoose.Types.ObjectId().toHexString();
604
+ try {
605
+ const store = new LocalTraceStore();
606
+ await store.exportScore({
607
+ dataType: "boolean",
608
+ name: "thumbs_up",
609
+ source: "user-feedback",
610
+ traceId,
611
+ value: false,
612
+ });
613
+ await store.exportScore({
614
+ dataType: "boolean",
615
+ name: "thumbs_up",
616
+ source: "user-feedback",
617
+ traceId,
618
+ value: true,
619
+ });
620
+ expect(
621
+ errorSpy.mock.calls.filter((call) => String(call[0]).startsWith("ObsScore indexes"))
622
+ ).toHaveLength(1);
623
+ const live = await ObsScore.find({traceId});
624
+ expect(live).toHaveLength(1);
625
+ expect(live[0]?.value).toBe(true);
626
+ } finally {
627
+ initSpy.mockRestore();
628
+ errorSpy.mockRestore();
629
+ }
630
+ });
631
+
632
+ it("rethrows any other index build failure and retries the build on the next write", async () => {
633
+ resetObsScoreIndexBuild();
634
+ const ObsScore = registerObsScore();
635
+ const realInit = ObsScore.init.bind(ObsScore);
636
+ const initSpy = spyOn(ObsScore, "init").mockImplementationOnce((() =>
637
+ Promise.reject(new Error("connection reset"))) as unknown as typeof ObsScore.init);
638
+ const traceId = new mongoose.Types.ObjectId().toHexString();
639
+ const score: ScoreRecord = {
640
+ dataType: "boolean",
641
+ name: "thumbs_up",
642
+ source: "user-feedback",
643
+ traceId,
644
+ value: false,
645
+ };
646
+ try {
647
+ const store = new LocalTraceStore();
648
+ await expect(store.exportScore(score)).rejects.toThrow("connection reset");
649
+ initSpy.mockImplementation(realInit as unknown as typeof ObsScore.init);
650
+ await store.exportScore(score);
651
+ expect(initSpy).toHaveBeenCalledTimes(2);
652
+ expect(await ObsScore.countDocuments({traceId})).toBe(1);
653
+ } finally {
654
+ initSpy.mockRestore();
655
+ }
656
+ });
657
+ });
@@ -1,4 +1,4 @@
1
- import {APIError} from "@terreno/api";
1
+ import {APIError, logger} from "@terreno/api";
2
2
  import {DateTime} from "luxon";
3
3
  import mongoose from "mongoose";
4
4
 
@@ -44,6 +44,12 @@ export interface TraceListQuery {
44
44
  /** One of `TRACE_LIST_SORT_KEYS`, optionally prefixed with `-` for descending. */
45
45
  sort?: string;
46
46
  status?: "error" | "ok";
47
+ /** Traces with a live end-user `thumbs_up` score in that direction. */
48
+ thumbs?: "down" | "up";
49
+ /** Traces with a live `user-signal` score of this name. */
50
+ signal?: string;
51
+ /** Traces with (or without) a live `user-feedback` score carrying a non-empty comment. */
52
+ hasComment?: boolean;
47
53
  to?: string;
48
54
  userId?: string;
49
55
  }
@@ -206,7 +212,11 @@ const countLookupStages = (from: string): mongoose.PipelineStage[] => {
206
212
  as: "_sortCounts",
207
213
  from,
208
214
  let: {traceId: "$_id"},
209
- pipeline: [{$match: {$expr: {$eq: ["$traceId", "$$traceId"]}}}, {$count: "n"}],
215
+ pipeline: [
216
+ // Soft-deleted rows (e.g. a cleared thumbs vote) do not count.
217
+ {$match: {$expr: {$eq: ["$traceId", "$$traceId"]}, deleted: {$ne: true}}},
218
+ {$count: "n"},
219
+ ],
210
220
  },
211
221
  },
212
222
  {$addFields: {_sortValue: {$ifNull: [{$arrayElemAt: ["$_sortCounts.n", 0]}, 0]}}},
@@ -290,7 +300,7 @@ const countByTraceId = async (
290
300
  return counts;
291
301
  }
292
302
  const grouped = (await model.aggregate([
293
- {$match: {traceId: {$in: ids}}},
303
+ {$match: {deleted: {$ne: true}, traceId: {$in: ids}}},
294
304
  {$group: {_id: "$traceId", n: {$sum: 1}}},
295
305
  ])) as Array<{_id: mongoose.Types.ObjectId; n: number}>;
296
306
  for (const row of grouped) {
@@ -299,12 +309,51 @@ const countByTraceId = async (
299
309
  return counts;
300
310
  };
301
311
 
312
+ /** Score sources written by end users; the local store keeps one live score per name. */
313
+ const USER_SCORE_SOURCES: ReadonlySet<string> = new Set(["user-feedback", "user-signal"]);
314
+
315
+ let obsScoreIndexes: Promise<unknown> | undefined;
316
+
317
+ /** Builds ObsScore indexes once, so the unique user-score index exists before the first upsert. */
318
+ const ensureObsScoreIndexes = (): Promise<unknown> => {
319
+ // A database that already holds duplicate live end-user scores (written through the admin
320
+ // scores route before these indexes existed) cannot build them. Feedback must keep working:
321
+ // log once and upsert without the uniqueness guarantee until the duplicates are removed.
322
+ obsScoreIndexes ??= registerObsScore()
323
+ .init()
324
+ .catch((error: unknown) => {
325
+ // Only existing duplicates are tolerated; any other failure retries on the next write.
326
+ if ((error as {code?: number}).code !== 11000) {
327
+ obsScoreIndexes = undefined;
328
+ throw error;
329
+ }
330
+ logger.error(
331
+ "ObsScore indexes failed to build; remove duplicate live user-feedback/user-signal scores per trace and name",
332
+ {error}
333
+ );
334
+ });
335
+ return obsScoreIndexes;
336
+ };
337
+
338
+ /**
339
+ * Forgets the index build so a test can simulate a failed build.
340
+ * @internal Test seam. Production builds the indexes once per process.
341
+ */
342
+ export const resetObsScoreIndexBuild = (): void => {
343
+ obsScoreIndexes = undefined;
344
+ };
345
+
302
346
  export class LocalTraceStore {
303
347
  async exportTrace(trace: TraceRecord): Promise<{id: string}> {
304
348
  const ObsTrace = registerObsTrace();
305
349
  const ObsSpan = registerObsSpan();
306
350
  const userId = objectIdOrUndefined(trace.userId);
351
+ // Only a 24-hex id is a caller-chosen trace id; other ids (uuids from older callers) are ignored.
352
+ const traceId = /^[0-9a-f]{24}$/i.test(trace.id ?? "")
353
+ ? new mongoose.Types.ObjectId(trace.id)
354
+ : undefined;
307
355
  const created = await ObsTrace.create({
356
+ ...(traceId ? {_id: traceId} : {}),
308
357
  endedAt: parseDate(trace.endedAt),
309
358
  errorSummary: firstErrorSummary(trace),
310
359
  flaggedForDataset: trace.flaggedForDataset ?? false,
@@ -353,6 +402,10 @@ export class LocalTraceStore {
353
402
  }
354
403
  const spanId = objectIdOrUndefined(score.spanId);
355
404
  const evaluatorId = objectIdOrUndefined(score.evaluatorId);
405
+ if (USER_SCORE_SOURCES.has(score.source)) {
406
+ await this.upsertUserScore({...score, traceId: String(traceId)});
407
+ return;
408
+ }
356
409
  await registerObsScore().create({
357
410
  comment: score.comment,
358
411
  confidence: score.confidence,
@@ -366,6 +419,64 @@ export class LocalTraceStore {
366
419
  });
367
420
  }
368
421
 
422
+ /**
423
+ * Keeps one live score per (trace, source, name) for end-user sources, so a changed vote
424
+ * replaces the old one. One atomic upsert backed by a partial unique index, so concurrent
425
+ * taps cannot leave two live scores.
426
+ */
427
+ private async upsertUserScore(score: ScoreRecord): Promise<void> {
428
+ const ObsScore = registerObsScore();
429
+ await ensureObsScoreIndexes();
430
+ const filter = {
431
+ deleted: false,
432
+ name: score.name,
433
+ source: score.source,
434
+ traceId: new mongoose.Types.ObjectId(score.traceId),
435
+ };
436
+ const set: Record<string, unknown> = {
437
+ dataType: score.dataType,
438
+ updated: DateTime.utc().toJSDate(),
439
+ value: score.value,
440
+ };
441
+ const unset: Record<string, ""> = {};
442
+ if (score.comment) {
443
+ set.comment = score.comment;
444
+ } else {
445
+ unset.comment = "";
446
+ }
447
+ const update = {
448
+ $set: set,
449
+ $setOnInsert: {created: DateTime.utc().toJSDate()},
450
+ ...(Object.keys(unset).length > 0 ? {$unset: unset} : {}),
451
+ };
452
+ try {
453
+ await ObsScore.collection.updateOne(filter, update, {upsert: true});
454
+ } catch (error) {
455
+ // A concurrent upsert may insert first; the retry then matches and updates that row.
456
+ if ((error as {code?: number}).code !== 11000) {
457
+ throw error;
458
+ }
459
+ await ObsScore.collection.updateOne(filter, update, {upsert: true});
460
+ }
461
+ }
462
+
463
+ /** Soft-deletes the live end-user score for (trace, source, name), e.g. a cleared thumbs vote. */
464
+ async deleteFeedbackScore(params: {
465
+ name: string;
466
+ source: ScoreRecord["source"];
467
+ traceId: string;
468
+ }): Promise<void> {
469
+ await registerObsScore().collection.updateMany(
470
+ {
471
+ deleted: false,
472
+ name: params.name,
473
+ source: params.source,
474
+ traceId: new mongoose.Types.ObjectId(params.traceId),
475
+ },
476
+ {$set: {deleted: true, updated: DateTime.utc().toJSDate()}}
477
+ );
478
+ }
479
+
369
480
  async list(
370
481
  query: TraceListQuery
371
482
  ): Promise<{data: TraceListItem[]; meta: {limit: number; page: number; total: number}}> {
@@ -429,13 +540,33 @@ export class LocalTraceStore {
429
540
  ...(to ? {$lte: to} : {}),
430
541
  };
431
542
  }
543
+ // Score-based filters each narrow the trace ids; `$and` lets several apply at once.
544
+ const idConstraints: Array<Record<string, unknown>> = [];
545
+ const scoredTraceIds = (scoreFilter: Record<string, unknown>): Promise<unknown[]> => {
546
+ return registerObsScore().distinct("traceId", {deleted: {$ne: true}, ...scoreFilter});
547
+ };
432
548
  if (query.hasScore !== undefined) {
433
- const scoredIds = await registerObsScore().distinct("traceId");
434
- if (query.hasScore) {
435
- filter._id = {$in: scoredIds};
436
- } else {
437
- filter._id = {$nin: scoredIds};
438
- }
549
+ const scoredIds = await scoredTraceIds({});
550
+ idConstraints.push({_id: query.hasScore ? {$in: scoredIds} : {$nin: scoredIds}});
551
+ }
552
+ if (query.thumbs) {
553
+ const ids = await scoredTraceIds({
554
+ name: "thumbs_up",
555
+ source: "user-feedback",
556
+ value: query.thumbs === "up",
557
+ });
558
+ idConstraints.push({_id: {$in: ids}});
559
+ }
560
+ if (query.signal) {
561
+ const ids = await scoredTraceIds({name: query.signal, source: "user-signal"});
562
+ idConstraints.push({_id: {$in: ids}});
563
+ }
564
+ if (query.hasComment !== undefined) {
565
+ const ids = await scoredTraceIds({comment: {$nin: [null, ""]}, source: "user-feedback"});
566
+ idConstraints.push({_id: query.hasComment ? {$in: ids} : {$nin: ids}});
567
+ }
568
+ if (idConstraints.length > 0) {
569
+ filter.$and = [...((filter.$and as unknown[] | undefined) ?? []), ...idConstraints];
439
570
  }
440
571
  const ObsTrace = registerObsTrace();
441
572
  const total = await ObsTrace.countDocuments(filter);
@@ -49,6 +49,7 @@ export class ObservabilityApp implements TerrenoPlugin {
49
49
  readonly priceMap: ObservabilityAppOptions["priceMap"];
50
50
  readonly requestAiServiceFactory?: ObservabilityRequestAiServiceFactory;
51
51
  readonly sampleRate: number;
52
+ readonly feedbackReview?: ObservabilityAppOptions["feedbackReview"];
52
53
 
53
54
  constructor(options: ObservabilityAppOptions) {
54
55
  this.accessControl = options.accessControl;
@@ -59,6 +60,7 @@ export class ObservabilityApp implements TerrenoPlugin {
59
60
  this.priceMap = options.priceMap;
60
61
  this.requestAiServiceFactory = options.requestAiServiceFactory;
61
62
  this.sampleRate = options.sampleRate ?? 0;
63
+ this.feedbackReview = options.feedbackReview;
62
64
  registerObservabilityApp(this);
63
65
  }
64
66
 
@@ -12,6 +12,7 @@ import type {
12
12
  export interface RegisteredObservabilityApp {
13
13
  aiService?: ObservabilityGenerateClient;
14
14
  control: ObservabilityControlConfig;
15
+ feedbackReview?: ObservabilityAppOptions["feedbackReview"];
15
16
  plugins: ReadonlyArray<ObservabilityPlugin>;
16
17
  priceMap?: ObservabilityAppOptions["priceMap"];
17
18
  promptRegistry?: PromptRegistry;