@terreno/admin-frontend 58.0.6 → 58.1.1
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CHANGELOG.md +58 -0
- package/dist/AdminNestedArrayField.d.ts.map +1 -1
- package/dist/AdminNestedArrayField.js +6 -5
- package/dist/AdminNestedArrayField.js.map +1 -1
- package/dist/AdminRolesList.d.ts +34 -1
- package/dist/AdminRolesList.d.ts.map +1 -1
- package/dist/AdminRolesList.js +53 -8
- package/dist/AdminRolesList.js.map +1 -1
- package/dist/AdminShell.d.ts.map +1 -1
- package/dist/AdminShell.js +7 -2
- package/dist/AdminShell.js.map +1 -1
- package/dist/index.d.ts +2 -1
- package/dist/index.d.ts.map +1 -1
- package/dist/index.js +2 -1
- package/dist/index.js.map +1 -1
- package/dist/useAdminRoles.d.ts +8 -0
- package/dist/useAdminRoles.d.ts.map +1 -1
- package/dist/useAdminRoles.js +11 -0
- package/dist/useAdminRoles.js.map +1 -1
- package/dist/widgets/aiObservability/datasets/AiDatasetDetailScreen.d.ts.map +1 -1
- package/dist/widgets/aiObservability/datasets/AiDatasetDetailScreen.js +10 -36
- package/dist/widgets/aiObservability/datasets/AiDatasetDetailScreen.js.map +1 -1
- package/dist/widgets/aiObservability/datasets/AiDatasetDetailView.d.ts +4 -6
- package/dist/widgets/aiObservability/datasets/AiDatasetDetailView.d.ts.map +1 -1
- package/dist/widgets/aiObservability/datasets/AiDatasetDetailView.js +11 -64
- package/dist/widgets/aiObservability/datasets/AiDatasetDetailView.js.map +1 -1
- package/dist/widgets/aiObservability/datasets/AiDatasetItemScreen.d.ts +4 -0
- package/dist/widgets/aiObservability/datasets/AiDatasetItemScreen.d.ts.map +1 -0
- package/dist/widgets/aiObservability/datasets/AiDatasetItemScreen.js +204 -0
- package/dist/widgets/aiObservability/datasets/AiDatasetItemScreen.js.map +1 -0
- package/dist/widgets/aiObservability/datasets/AiDatasetItemView.d.ts +23 -0
- package/dist/widgets/aiObservability/datasets/AiDatasetItemView.d.ts.map +1 -0
- package/dist/widgets/aiObservability/datasets/AiDatasetItemView.js +31 -0
- package/dist/widgets/aiObservability/datasets/AiDatasetItemView.js.map +1 -0
- package/dist/widgets/aiObservability/datasets/ExpectedOutputForm.d.ts +12 -0
- package/dist/widgets/aiObservability/datasets/ExpectedOutputForm.d.ts.map +1 -0
- package/dist/widgets/aiObservability/datasets/ExpectedOutputForm.js +101 -0
- package/dist/widgets/aiObservability/datasets/ExpectedOutputForm.js.map +1 -0
- package/dist/widgets/aiObservability/datasets/datasetTypes.d.ts +5 -0
- package/dist/widgets/aiObservability/datasets/datasetTypes.d.ts.map +1 -1
- package/dist/widgets/aiObservability/datasets/datasetTypes.js +9 -0
- package/dist/widgets/aiObservability/datasets/datasetTypes.js.map +1 -1
- package/dist/widgets/aiObservability/datasets/expectedOutputModel.d.ts +44 -0
- package/dist/widgets/aiObservability/datasets/expectedOutputModel.d.ts.map +1 -0
- package/dist/widgets/aiObservability/datasets/expectedOutputModel.js +265 -0
- package/dist/widgets/aiObservability/datasets/expectedOutputModel.js.map +1 -0
- package/dist/widgets/aiObservability/datasets/useAiObservabilityDatasetsApi.d.ts +6 -0
- package/dist/widgets/aiObservability/datasets/useAiObservabilityDatasetsApi.d.ts.map +1 -1
- package/dist/widgets/aiObservability/datasets/useAiObservabilityDatasetsApi.js +8 -0
- package/dist/widgets/aiObservability/datasets/useAiObservabilityDatasetsApi.js.map +1 -1
- package/dist/widgets/aiObservability/prompts/AiPromptEditorView.d.ts.map +1 -1
- package/dist/widgets/aiObservability/prompts/AiPromptEditorView.js +5 -2
- package/dist/widgets/aiObservability/prompts/AiPromptEditorView.js.map +1 -1
- package/dist/widgets/aiObservability/prompts/AiPromptHubView.d.ts.map +1 -1
- package/dist/widgets/aiObservability/prompts/AiPromptHubView.js +4 -3
- package/dist/widgets/aiObservability/prompts/AiPromptHubView.js.map +1 -1
- package/dist/widgets/aiObservability/prompts/AiPromptsListScreen.d.ts.map +1 -1
- package/dist/widgets/aiObservability/prompts/AiPromptsListScreen.js +2 -1
- package/dist/widgets/aiObservability/prompts/AiPromptsListScreen.js.map +1 -1
- package/dist/widgets/aiObservability/prompts/AiPromptsListView.d.ts +2 -0
- package/dist/widgets/aiObservability/prompts/AiPromptsListView.d.ts.map +1 -1
- package/dist/widgets/aiObservability/prompts/AiPromptsListView.js +92 -26
- package/dist/widgets/aiObservability/prompts/AiPromptsListView.js.map +1 -1
- package/dist/widgets/aiObservability/prompts/promptTypes.d.ts +29 -5
- package/dist/widgets/aiObservability/prompts/promptTypes.d.ts.map +1 -1
- package/dist/widgets/aiObservability/prompts/promptTypes.js +114 -11
- package/dist/widgets/aiObservability/prompts/promptTypes.js.map +1 -1
- package/dist/widgets/aiObservability/shell/AiObservabilityScreenWidgets.d.ts.map +1 -1
- package/dist/widgets/aiObservability/shell/AiObservabilityScreenWidgets.js +2 -0
- package/dist/widgets/aiObservability/shell/AiObservabilityScreenWidgets.js.map +1 -1
- package/dist/widgets/aiObservability/shell/aiObservabilityNav.d.ts.map +1 -1
- package/dist/widgets/aiObservability/shell/aiObservabilityNav.js +1 -0
- package/dist/widgets/aiObservability/shell/aiObservabilityNav.js.map +1 -1
- package/dist/widgets/aiObservability/traces/AiTraceDetailView.d.ts.map +1 -1
- package/dist/widgets/aiObservability/traces/AiTraceDetailView.js +15 -1
- package/dist/widgets/aiObservability/traces/AiTraceDetailView.js.map +1 -1
- package/dist/widgets/aiObservability/traces/AiTracesListView.d.ts.map +1 -1
- package/dist/widgets/aiObservability/traces/AiTracesListView.js +23 -1
- package/dist/widgets/aiObservability/traces/AiTracesListView.js.map +1 -1
- package/dist/widgets/aiObservability/traces/traceTypes.d.ts +15 -0
- package/dist/widgets/aiObservability/traces/traceTypes.d.ts.map +1 -1
- package/dist/widgets/aiObservability/traces/traceTypes.js +39 -0
- package/dist/widgets/aiObservability/traces/traceTypes.js.map +1 -1
- package/dist/widgets/aiObservability/traces/useAiObservabilityTracesApi.d.ts.map +1 -1
- package/dist/widgets/aiObservability/traces/useAiObservabilityTracesApi.js +12 -0
- package/dist/widgets/aiObservability/traces/useAiObservabilityTracesApi.js.map +1 -1
- package/package.json +4 -4
- package/src/AdminNestedArrayField.tsx +6 -4
- package/src/AdminRolesList.test.tsx +119 -2
- package/src/AdminRolesList.tsx +171 -13
- package/src/AdminShell.test.tsx +14 -0
- package/src/AdminShell.tsx +7 -1
- package/src/index.tsx +13 -1
- package/src/isolated/AdminNestedArrayField.isolated.tsx +50 -8
- package/src/isolated/aiObservabilityDatasets.isolated.tsx +417 -67
- package/src/isolated/aiObservabilityPrompts.isolated.tsx +42 -24
- package/src/isolated/aiObservabilityTraces.isolated.tsx +2 -1
- package/src/isolated/aiTracesTable.isolated.tsx +24 -1
- package/src/useAdminRoles.test.ts +15 -1
- package/src/useAdminRoles.ts +25 -1
- package/src/widgets/aiObservability/datasets/AiDatasetDetailScreen.tsx +17 -48
- package/src/widgets/aiObservability/datasets/AiDatasetDetailView.test.tsx +40 -77
- package/src/widgets/aiObservability/datasets/AiDatasetDetailView.tsx +29 -153
- package/src/widgets/aiObservability/datasets/AiDatasetItemScreen.tsx +279 -0
- package/src/widgets/aiObservability/datasets/AiDatasetItemView.test.tsx +110 -0
- package/src/widgets/aiObservability/datasets/AiDatasetItemView.tsx +174 -0
- package/src/widgets/aiObservability/datasets/ExpectedOutputForm.test.tsx +234 -0
- package/src/widgets/aiObservability/datasets/ExpectedOutputForm.tsx +313 -0
- package/src/widgets/aiObservability/datasets/datasetTypes.test.ts +31 -0
- package/src/widgets/aiObservability/datasets/datasetTypes.ts +13 -0
- package/src/widgets/aiObservability/datasets/expectedOutputModel.test.ts +285 -0
- package/src/widgets/aiObservability/datasets/expectedOutputModel.ts +338 -0
- package/src/widgets/aiObservability/datasets/useAiObservabilityDatasetsApi.test.ts +11 -0
- package/src/widgets/aiObservability/datasets/useAiObservabilityDatasetsApi.ts +22 -0
- package/src/widgets/aiObservability/prompts/AiPromptEditorView.tsx +7 -2
- package/src/widgets/aiObservability/prompts/AiPromptHubView.tsx +10 -3
- package/src/widgets/aiObservability/prompts/AiPromptsListScreen.tsx +3 -0
- package/src/widgets/aiObservability/prompts/AiPromptsListView.test.tsx +149 -3
- package/src/widgets/aiObservability/prompts/AiPromptsListView.tsx +176 -42
- package/src/widgets/aiObservability/prompts/promptTypes.test.ts +87 -7
- package/src/widgets/aiObservability/prompts/promptTypes.ts +140 -15
- package/src/widgets/aiObservability/shell/AiObservabilityScreenWidgets.tsx +2 -0
- package/src/widgets/aiObservability/shell/aiObservabilityNav.ts +1 -0
- package/src/widgets/aiObservability/traces/AiTraceDetailView.test.tsx +120 -0
- package/src/widgets/aiObservability/traces/AiTraceDetailView.tsx +47 -7
- package/src/widgets/aiObservability/traces/AiTracesListView.tsx +23 -0
- package/src/widgets/aiObservability/traces/traceTypes.test.ts +46 -0
- package/src/widgets/aiObservability/traces/traceTypes.ts +53 -0
- package/src/widgets/aiObservability/traces/useAiObservabilityTracesApi.test.ts +40 -0
- package/src/widgets/aiObservability/traces/useAiObservabilityTracesApi.ts +12 -0
|
@@ -9,6 +9,7 @@ export interface PromptListItem {
|
|
|
9
9
|
latestVersion: number;
|
|
10
10
|
name: string;
|
|
11
11
|
production: number | "—";
|
|
12
|
+
tags?: string[];
|
|
12
13
|
type: "chat" | "text";
|
|
13
14
|
usage7d?: PromptUsage7d;
|
|
14
15
|
}
|
|
@@ -120,12 +121,120 @@ export interface PlaygroundRunResult {
|
|
|
120
121
|
tokens: {inputTokens?: number; outputTokens?: number; totalTokens?: number};
|
|
121
122
|
}
|
|
122
123
|
|
|
123
|
-
export
|
|
124
|
+
export const ALL_FOLDERS = "";
|
|
125
|
+
|
|
126
|
+
/** Split a folder or prompt name on `/`, dropping blank segments from extra slashes. */
|
|
127
|
+
export const pathSegments = (value: string): string[] => {
|
|
128
|
+
return value
|
|
129
|
+
.split("/")
|
|
130
|
+
.map((part) => part.trim())
|
|
131
|
+
.filter((part) => part.length > 0);
|
|
132
|
+
};
|
|
133
|
+
|
|
134
|
+
/** Render a slash path as nested folder segments, e.g. `appointmentAI / intake`. */
|
|
135
|
+
export const formatFolderPath = (folder: string): string => {
|
|
136
|
+
const segments = pathSegments(folder);
|
|
137
|
+
if (segments.length === 0) {
|
|
138
|
+
return folder.trim();
|
|
139
|
+
}
|
|
140
|
+
return segments.join(" / ");
|
|
141
|
+
};
|
|
142
|
+
|
|
143
|
+
export interface PromptLocation {
|
|
144
|
+
/** Nested folder segments. A slash in `folder` or in `name` (except the last) is one level. */
|
|
145
|
+
directories: string[];
|
|
146
|
+
/** `directories` joined with `/`, or `""` when the prompt has no folder segments. */
|
|
147
|
+
directory: string;
|
|
148
|
+
/** Last segment of the name. This is the prompt, not a folder. */
|
|
149
|
+
leaf: string;
|
|
150
|
+
}
|
|
151
|
+
|
|
152
|
+
/**
|
|
153
|
+
* Where a prompt sits in the folder tree.
|
|
154
|
+
* Every `/` in the folder is a folder. Every `/` in the name is a folder too,
|
|
155
|
+
* except the last segment, which is the prompt itself.
|
|
156
|
+
*/
|
|
157
|
+
export const promptLocation = (prompt: Pick<PromptListItem, "folder" | "name">): PromptLocation => {
|
|
158
|
+
const folderParts = pathSegments(prompt.folder);
|
|
159
|
+
const nameParts = pathSegments(prompt.name);
|
|
160
|
+
const leaf =
|
|
161
|
+
nameParts.length > 0 ? (nameParts[nameParts.length - 1] ?? prompt.name) : prompt.name;
|
|
162
|
+
const nameParents = nameParts.slice(0, -1);
|
|
163
|
+
const folderKey = folderParts.join("/");
|
|
164
|
+
const nameParentKey = nameParents.join("/");
|
|
165
|
+
|
|
166
|
+
let directories = folderParts;
|
|
167
|
+
if (nameParents.length > 0) {
|
|
168
|
+
const nameExtendsFolder =
|
|
169
|
+
folderKey.length === 0 ||
|
|
170
|
+
nameParentKey === folderKey ||
|
|
171
|
+
nameParentKey.startsWith(`${folderKey}/`);
|
|
172
|
+
const folderExtendsName =
|
|
173
|
+
nameParentKey.length === 0 ||
|
|
174
|
+
folderKey === nameParentKey ||
|
|
175
|
+
folderKey.startsWith(`${nameParentKey}/`);
|
|
176
|
+
if (nameExtendsFolder) {
|
|
177
|
+
directories = nameParents;
|
|
178
|
+
} else if (folderExtendsName) {
|
|
179
|
+
directories = folderParts;
|
|
180
|
+
} else {
|
|
181
|
+
directories = [...folderParts, ...nameParents];
|
|
182
|
+
}
|
|
183
|
+
}
|
|
184
|
+
|
|
185
|
+
return {
|
|
186
|
+
directories,
|
|
187
|
+
directory: directories.join("/"),
|
|
188
|
+
leaf,
|
|
189
|
+
};
|
|
190
|
+
};
|
|
191
|
+
|
|
192
|
+
export interface FolderNode {
|
|
124
193
|
count: number;
|
|
125
|
-
|
|
194
|
+
name: string;
|
|
195
|
+
path: string;
|
|
126
196
|
}
|
|
127
197
|
|
|
128
|
-
|
|
198
|
+
/** Immediate child folders under `parent` (`""` is the root), with subtree prompt counts. */
|
|
199
|
+
export const childFolders = (prompts: PromptListItem[], parent: string): FolderNode[] => {
|
|
200
|
+
const parentSegments = pathSegments(parent);
|
|
201
|
+
const counts = new Map<string, FolderNode>();
|
|
202
|
+
for (const prompt of prompts) {
|
|
203
|
+
const {directories} = promptLocation(prompt);
|
|
204
|
+
if (directories.length <= parentSegments.length) {
|
|
205
|
+
continue;
|
|
206
|
+
}
|
|
207
|
+
const isInside = parentSegments.every((segment, index) => directories[index] === segment);
|
|
208
|
+
if (!isInside) {
|
|
209
|
+
continue;
|
|
210
|
+
}
|
|
211
|
+
const name = directories[parentSegments.length];
|
|
212
|
+
if (!name) {
|
|
213
|
+
continue;
|
|
214
|
+
}
|
|
215
|
+
const path = [...parentSegments, name].join("/");
|
|
216
|
+
const current = counts.get(path);
|
|
217
|
+
counts.set(path, {
|
|
218
|
+
count: (current?.count ?? 0) + 1,
|
|
219
|
+
name,
|
|
220
|
+
path,
|
|
221
|
+
});
|
|
222
|
+
}
|
|
223
|
+
return [...counts.values()].sort((a, b) => a.path.localeCompare(b.path));
|
|
224
|
+
};
|
|
225
|
+
|
|
226
|
+
/** True when `folder` is the prompt's directory or a parent of it. `""` matches every prompt. */
|
|
227
|
+
const promptInFolder = (
|
|
228
|
+
prompt: Pick<PromptListItem, "folder" | "name">,
|
|
229
|
+
folder: string
|
|
230
|
+
): boolean => {
|
|
231
|
+
const selected = pathSegments(folder).join("/");
|
|
232
|
+
if (selected.length === 0) {
|
|
233
|
+
return true;
|
|
234
|
+
}
|
|
235
|
+
const directory = promptLocation(prompt).directory;
|
|
236
|
+
return directory === selected || directory.startsWith(`${selected}/`);
|
|
237
|
+
};
|
|
129
238
|
|
|
130
239
|
/**
|
|
131
240
|
* The registry tag that pulls another prompt's production body into this one.
|
|
@@ -182,16 +291,18 @@ export const unwrapPromptDetail = (raw: unknown): PromptDetail | undefined => {
|
|
|
182
291
|
return normalizePromptDetail(payload);
|
|
183
292
|
};
|
|
184
293
|
|
|
185
|
-
|
|
186
|
-
|
|
294
|
+
/** Sorted unique tags across the loaded prompts. Blank tags are dropped. */
|
|
295
|
+
export const promptTags = (prompts: PromptListItem[]): string[] => {
|
|
296
|
+
const tags = new Set<string>();
|
|
187
297
|
for (const prompt of prompts) {
|
|
188
|
-
|
|
298
|
+
for (const tag of prompt.tags ?? []) {
|
|
299
|
+
const trimmed = tag.trim();
|
|
300
|
+
if (trimmed.length > 0) {
|
|
301
|
+
tags.add(trimmed);
|
|
302
|
+
}
|
|
303
|
+
}
|
|
189
304
|
}
|
|
190
|
-
return [...
|
|
191
|
-
.sort(([a], [b]) => {
|
|
192
|
-
return a.localeCompare(b);
|
|
193
|
-
})
|
|
194
|
-
.map(([folder, count]) => ({count, folder}));
|
|
305
|
+
return [...tags].sort((left, right) => left.localeCompare(right));
|
|
195
306
|
};
|
|
196
307
|
|
|
197
308
|
export const formatProduction = (production: number | "—"): string => {
|
|
@@ -205,22 +316,36 @@ export const filterPrompts = ({
|
|
|
205
316
|
folder,
|
|
206
317
|
prompts,
|
|
207
318
|
search,
|
|
319
|
+
tag,
|
|
208
320
|
}: {
|
|
209
321
|
folder: string;
|
|
210
322
|
prompts: PromptListItem[];
|
|
211
323
|
search: string;
|
|
324
|
+
tag?: string;
|
|
212
325
|
}): PromptListItem[] => {
|
|
213
326
|
const needle = search.trim().toLowerCase();
|
|
327
|
+
const selectedTag = tag?.trim() ?? "";
|
|
214
328
|
return prompts.filter((prompt) => {
|
|
215
|
-
if (
|
|
329
|
+
if (!promptInFolder(prompt, folder)) {
|
|
330
|
+
return false;
|
|
331
|
+
}
|
|
332
|
+
if (selectedTag && !(prompt.tags ?? []).includes(selectedTag)) {
|
|
216
333
|
return false;
|
|
217
334
|
}
|
|
218
335
|
if (!needle) {
|
|
219
336
|
return true;
|
|
220
337
|
}
|
|
221
|
-
|
|
222
|
-
|
|
223
|
-
|
|
338
|
+
const location = promptLocation(prompt);
|
|
339
|
+
const haystack = [
|
|
340
|
+
prompt.name,
|
|
341
|
+
prompt.folder,
|
|
342
|
+
location.directory,
|
|
343
|
+
location.leaf,
|
|
344
|
+
...(prompt.tags ?? []),
|
|
345
|
+
]
|
|
346
|
+
.join("\n")
|
|
347
|
+
.toLowerCase();
|
|
348
|
+
return haystack.includes(needle);
|
|
224
349
|
});
|
|
225
350
|
};
|
|
226
351
|
|
|
@@ -1,5 +1,6 @@
|
|
|
1
1
|
import type {ScreenWidgetComponent} from "../../../types";
|
|
2
2
|
import {AiDatasetDetailScreenWidget} from "../datasets/AiDatasetDetailScreen";
|
|
3
|
+
import {AiDatasetItemScreenWidget} from "../datasets/AiDatasetItemScreen";
|
|
3
4
|
import {AiDatasetsScreenWidget} from "../datasets/AiDatasetsListScreen";
|
|
4
5
|
import {AiEvaluatorDetailScreenWidget} from "../evaluators/AiEvaluatorDetailScreen";
|
|
5
6
|
import {AiEvaluatorNewScreenWidget} from "../evaluators/AiEvaluatorNewScreen";
|
|
@@ -29,6 +30,7 @@ export {
|
|
|
29
30
|
|
|
30
31
|
export const AI_OBSERVABILITY_WIDGETS: Record<string, ScreenWidgetComponent> = {
|
|
31
32
|
"ai-dataset-detail": AiDatasetDetailScreenWidget,
|
|
33
|
+
"ai-dataset-item": AiDatasetItemScreenWidget,
|
|
32
34
|
"ai-datasets": AiDatasetsScreenWidget,
|
|
33
35
|
"ai-evaluator-detail": AiEvaluatorDetailScreenWidget,
|
|
34
36
|
"ai-evaluator-new": AiEvaluatorNewScreenWidget,
|
|
@@ -32,6 +32,7 @@ const LIST_LEAVES = new Set(["Library", "List", "Queue"]);
|
|
|
32
32
|
|
|
33
33
|
export const AI_OBSERVABILITY_SCREENS: Record<string, AiObservabilityScreenMeta> = {
|
|
34
34
|
"ai-dataset-detail": {leaf: "Detail", section: "Datasets", title: "Dataset"},
|
|
35
|
+
"ai-dataset-item": {leaf: "Expected output", section: "Datasets", title: "Expected output"},
|
|
35
36
|
"ai-datasets": {leaf: "List", section: "Datasets", title: "Datasets"},
|
|
36
37
|
"ai-evaluator-detail": {leaf: "Detail", section: "Evaluators", title: "Evaluator"},
|
|
37
38
|
"ai-evaluator-new": {leaf: "New", section: "Evaluators", title: "New evaluator"},
|
|
@@ -0,0 +1,120 @@
|
|
|
1
|
+
import {describe, expect, it, mock} from "bun:test";
|
|
2
|
+
import {fireEvent} from "@testing-library/react-native";
|
|
3
|
+
import React from "react";
|
|
4
|
+
import {renderWithTheme} from "../../../../../ui/src/test-utils";
|
|
5
|
+
import {AiTraceDetailView} from "./AiTraceDetailView";
|
|
6
|
+
import type {TraceDetail, TraceScore} from "./traceTypes";
|
|
7
|
+
|
|
8
|
+
const buildDetail = (scores: TraceScore[], sensitive = false): TraceDetail => ({
|
|
9
|
+
flaggedForDataset: false,
|
|
10
|
+
id: "trace-1",
|
|
11
|
+
name: "summarize",
|
|
12
|
+
prompts: [],
|
|
13
|
+
scoreCount: scores.length,
|
|
14
|
+
scores,
|
|
15
|
+
sensitive,
|
|
16
|
+
spanCount: 0,
|
|
17
|
+
spans: [],
|
|
18
|
+
startedAt: "2026-09-01T12:00:00.000Z",
|
|
19
|
+
status: "ok",
|
|
20
|
+
});
|
|
21
|
+
|
|
22
|
+
const thumbsDown: TraceScore = {
|
|
23
|
+
comment: "Too long",
|
|
24
|
+
dataType: "boolean",
|
|
25
|
+
name: "thumbs_up",
|
|
26
|
+
source: "user-feedback",
|
|
27
|
+
value: false,
|
|
28
|
+
};
|
|
29
|
+
|
|
30
|
+
const copiedSignal: TraceScore = {
|
|
31
|
+
dataType: "boolean",
|
|
32
|
+
name: "copied",
|
|
33
|
+
source: "user-signal",
|
|
34
|
+
value: true,
|
|
35
|
+
};
|
|
36
|
+
|
|
37
|
+
const renderDetail = (detail: TraceDetail): ReturnType<typeof renderWithTheme> =>
|
|
38
|
+
renderWithTheme(<AiTraceDetailView detail={detail} onBack={mock(() => undefined)} />);
|
|
39
|
+
|
|
40
|
+
describe("AiTraceDetailView scores", () => {
|
|
41
|
+
it("shows the User badge and the comment under a user-feedback score", () => {
|
|
42
|
+
const {getByTestId, getByText} = renderDetail(buildDetail([thumbsDown]));
|
|
43
|
+
expect(getByText("User")).toBeTruthy();
|
|
44
|
+
expect(getByTestId("ai-trace-score-comment-0")).toBeTruthy();
|
|
45
|
+
expect(getByText("Too long")).toBeTruthy();
|
|
46
|
+
});
|
|
47
|
+
|
|
48
|
+
it("shows the Signal badge and no comment row for a user-signal score", () => {
|
|
49
|
+
const {getByText, queryByTestId} = renderDetail(buildDetail([copiedSignal]));
|
|
50
|
+
expect(getByText("Signal")).toBeTruthy();
|
|
51
|
+
expect(queryByTestId("ai-trace-score-comment-0")).toBeNull();
|
|
52
|
+
});
|
|
53
|
+
|
|
54
|
+
it("labels every score source with its badge text", () => {
|
|
55
|
+
const sources: Array<[string, string]> = [
|
|
56
|
+
["user-feedback", "User"],
|
|
57
|
+
["user-signal", "Signal"],
|
|
58
|
+
["human", "Human"],
|
|
59
|
+
["llm-judge", "Judge"],
|
|
60
|
+
["code", "Code"],
|
|
61
|
+
];
|
|
62
|
+
const scores = sources.map(([source], index) => ({
|
|
63
|
+
dataType: "boolean" as const,
|
|
64
|
+
name: `score_${index}`,
|
|
65
|
+
source,
|
|
66
|
+
value: true,
|
|
67
|
+
}));
|
|
68
|
+
const {getByText, queryByText} = renderDetail(buildDetail(scores));
|
|
69
|
+
for (const [source, label] of sources) {
|
|
70
|
+
expect(getByText(label)).toBeTruthy();
|
|
71
|
+
// The raw source string is replaced by the badge label.
|
|
72
|
+
expect(queryByText(source)).toBeNull();
|
|
73
|
+
}
|
|
74
|
+
});
|
|
75
|
+
|
|
76
|
+
it("keeps the empty message when there are no scores", () => {
|
|
77
|
+
const {getByText} = renderDetail(buildDetail([]));
|
|
78
|
+
expect(getByText("No scores on this trace.")).toBeTruthy();
|
|
79
|
+
});
|
|
80
|
+
|
|
81
|
+
it("indexes comment rows by score position", () => {
|
|
82
|
+
const {getByTestId, queryByTestId, getByText} = renderDetail(
|
|
83
|
+
buildDetail([copiedSignal, {...thumbsDown, comment: "Missed the point"}])
|
|
84
|
+
);
|
|
85
|
+
expect(queryByTestId("ai-trace-score-comment-0")).toBeNull();
|
|
86
|
+
expect(getByTestId("ai-trace-score-comment-1")).toBeTruthy();
|
|
87
|
+
expect(getByText("Missed the point")).toBeTruthy();
|
|
88
|
+
});
|
|
89
|
+
|
|
90
|
+
it("hides the comment on a sensitive trace until the disclosure is opened", () => {
|
|
91
|
+
const {getByTestId, queryByTestId, queryByText, getByText} = renderDetail(
|
|
92
|
+
buildDetail([thumbsDown], true)
|
|
93
|
+
);
|
|
94
|
+
expect(queryByText("Too long")).toBeNull();
|
|
95
|
+
|
|
96
|
+
// The disclosure may be an Accordion (toggle child) or a plain button; accept either.
|
|
97
|
+
const id = "ai-trace-score-comment-toggle-0";
|
|
98
|
+
fireEvent.press(queryByTestId(`${id}.toggle`) ?? getByTestId(id));
|
|
99
|
+
expect(getByText("Too long")).toBeTruthy();
|
|
100
|
+
});
|
|
101
|
+
|
|
102
|
+
it("shows a non-sensitive comment without any disclosure", () => {
|
|
103
|
+
const {queryByTestId, getByText} = renderDetail(buildDetail([thumbsDown], false));
|
|
104
|
+
expect(getByText("Too long")).toBeTruthy();
|
|
105
|
+
expect(queryByTestId("ai-trace-score-comment-toggle-0")).toBeNull();
|
|
106
|
+
});
|
|
107
|
+
});
|
|
108
|
+
|
|
109
|
+
describe("AiTraceDetailView tags", () => {
|
|
110
|
+
it("shows the trace tags in the header", () => {
|
|
111
|
+
const detail = {...buildDetail([]), tags: ["model:glm-5.3", "key:shade-general"]};
|
|
112
|
+
const {getByText} = renderDetail(detail);
|
|
113
|
+
expect(getByText("tags model:glm-5.3, key:shade-general")).toBeTruthy();
|
|
114
|
+
});
|
|
115
|
+
|
|
116
|
+
it("omits the tags line when there are none", () => {
|
|
117
|
+
const {queryByTestId} = renderDetail({...buildDetail([]), tags: []});
|
|
118
|
+
expect(queryByTestId("ai-trace-tags")).toBeNull();
|
|
119
|
+
});
|
|
120
|
+
});
|
|
@@ -74,6 +74,19 @@ const SpanRow: React.FC<{
|
|
|
74
74
|
);
|
|
75
75
|
};
|
|
76
76
|
|
|
77
|
+
const SCORE_SOURCE_LABELS: Record<string, string> = {
|
|
78
|
+
code: "Code",
|
|
79
|
+
human: "Human",
|
|
80
|
+
"llm-judge": "Judge",
|
|
81
|
+
"user-feedback": "User",
|
|
82
|
+
"user-signal": "Signal",
|
|
83
|
+
};
|
|
84
|
+
|
|
85
|
+
/** Short badge text for who wrote a score. */
|
|
86
|
+
const scoreSourceLabel = (source: string): string => {
|
|
87
|
+
return SCORE_SOURCE_LABELS[source] ?? source;
|
|
88
|
+
};
|
|
89
|
+
|
|
77
90
|
export const AiTraceDetailView: React.FC<AiTraceDetailViewProps> = ({detail, onBack}) => {
|
|
78
91
|
const flat = useMemo(() => flattenSpans(detail.spans), [detail.spans]);
|
|
79
92
|
const maxDuration = useMemo(() => {
|
|
@@ -108,6 +121,11 @@ export const AiTraceDetailView: React.FC<AiTraceDetailViewProps> = ({detail, onB
|
|
|
108
121
|
detail.sessionId ? ` · session ${detail.sessionId}` : ""
|
|
109
122
|
}`}
|
|
110
123
|
</Text>
|
|
124
|
+
{detail.tags && detail.tags.length > 0 ? (
|
|
125
|
+
<Text color="secondaryDark" size="sm" testID="ai-trace-tags">
|
|
126
|
+
{`tags ${detail.tags.join(", ")}`}
|
|
127
|
+
</Text>
|
|
128
|
+
) : undefined}
|
|
111
129
|
{detail.errorSummary ? <Text color="error">{detail.errorSummary}</Text> : undefined}
|
|
112
130
|
</Box>
|
|
113
131
|
<Button onClick={onBack} text="Back to traces" variant="secondary" />
|
|
@@ -175,13 +193,35 @@ export const AiTraceDetailView: React.FC<AiTraceDetailViewProps> = ({detail, onB
|
|
|
175
193
|
{detail.scores.length === 0 ? (
|
|
176
194
|
<Text color="secondaryDark">No scores on this trace.</Text>
|
|
177
195
|
) : (
|
|
178
|
-
detail.scores.map((score) =>
|
|
179
|
-
|
|
180
|
-
<
|
|
181
|
-
|
|
182
|
-
|
|
183
|
-
|
|
184
|
-
|
|
196
|
+
detail.scores.map((score, index) => {
|
|
197
|
+
const comment = score.comment ? (
|
|
198
|
+
<Box testID={`ai-trace-score-comment-${index}`}>
|
|
199
|
+
<Text size="sm">{score.comment}</Text>
|
|
200
|
+
</Box>
|
|
201
|
+
) : undefined;
|
|
202
|
+
return (
|
|
203
|
+
// Several human or code scores can share a name and source, so key by position.
|
|
204
|
+
<Box gap={1} key={`${index}-${score.name}-${score.source}`}>
|
|
205
|
+
<Box alignItems="center" direction="row" gap={2} wrap>
|
|
206
|
+
<Text bold>{score.name}</Text>
|
|
207
|
+
<Text>{String(score.value)}</Text>
|
|
208
|
+
<Badge status="neutral" value={scoreSourceLabel(score.source)} />
|
|
209
|
+
</Box>
|
|
210
|
+
{comment && detail.sensitive ? (
|
|
211
|
+
// A user's comment on a sensitive trace may hold PHI, so it starts collapsed like I/O.
|
|
212
|
+
<Accordion
|
|
213
|
+
isCollapsed
|
|
214
|
+
testID={`ai-trace-score-comment-toggle-${index}`}
|
|
215
|
+
title="Comment (sensitive)"
|
|
216
|
+
>
|
|
217
|
+
{comment}
|
|
218
|
+
</Accordion>
|
|
219
|
+
) : (
|
|
220
|
+
comment
|
|
221
|
+
)}
|
|
222
|
+
</Box>
|
|
223
|
+
);
|
|
224
|
+
})
|
|
185
225
|
)}
|
|
186
226
|
</Box>
|
|
187
227
|
</Box>
|
|
@@ -23,6 +23,7 @@ import {
|
|
|
23
23
|
DEFAULT_TRACE_SORT,
|
|
24
24
|
type EvaluatorOption,
|
|
25
25
|
selectedSensitiveCount,
|
|
26
|
+
TRACE_FEEDBACK_SIGNALS,
|
|
26
27
|
TRACE_FILTER_FIELDS,
|
|
27
28
|
type TraceListItem,
|
|
28
29
|
type TraceSortKey,
|
|
@@ -60,6 +61,26 @@ const ADDITIONAL_FILTERS: DataTableColumnFilter[] = [
|
|
|
60
61
|
{field: TRACE_FILTER_FIELDS.sensitive, kind: "boolean", label: "Sensitive"},
|
|
61
62
|
{field: TRACE_FILTER_FIELDS.userId, kind: "text", label: "User"},
|
|
62
63
|
{field: TRACE_FILTER_FIELDS.sessionId, kind: "text", label: "Session"},
|
|
64
|
+
{field: TRACE_FILTER_FIELDS.tag, kind: "text", label: "Tag"},
|
|
65
|
+
{
|
|
66
|
+
field: TRACE_FILTER_FIELDS.thumbs,
|
|
67
|
+
kind: "choice",
|
|
68
|
+
label: "Thumbs",
|
|
69
|
+
options: [
|
|
70
|
+
{label: "Up", value: "up"},
|
|
71
|
+
{label: "Down", value: "down"},
|
|
72
|
+
],
|
|
73
|
+
},
|
|
74
|
+
{
|
|
75
|
+
field: TRACE_FILTER_FIELDS.signal,
|
|
76
|
+
kind: "choice",
|
|
77
|
+
label: "Signal",
|
|
78
|
+
options: TRACE_FEEDBACK_SIGNALS.map((signal) => ({
|
|
79
|
+
label: signal.charAt(0).toUpperCase() + signal.slice(1),
|
|
80
|
+
value: signal,
|
|
81
|
+
})),
|
|
82
|
+
},
|
|
83
|
+
{field: TRACE_FILTER_FIELDS.hasComment, kind: "boolean", label: "Has comment"},
|
|
63
84
|
];
|
|
64
85
|
|
|
65
86
|
/** Two-line cells (name plus steps and user) need more than the default 54px row. */
|
|
@@ -159,6 +180,7 @@ const buildColumns = (promptOptions: string[]): DataTableColumn[] => {
|
|
|
159
180
|
title: "Scores",
|
|
160
181
|
width: 140,
|
|
161
182
|
},
|
|
183
|
+
{columnType: "traceText", title: "Tags", width: 260},
|
|
162
184
|
];
|
|
163
185
|
};
|
|
164
186
|
|
|
@@ -437,6 +459,7 @@ export const AiTracesListView: React.FC<AiTracesListViewProps> = ({
|
|
|
437
459
|
{value: formatTraceLatency(trace)},
|
|
438
460
|
{value: formatTraceCost(trace.usage)},
|
|
439
461
|
{value: trace.scoreCount.toLocaleString("en-US")},
|
|
462
|
+
{value: (trace.tags ?? []).join(", ")},
|
|
440
463
|
]);
|
|
441
464
|
}, [traces]);
|
|
442
465
|
|
|
@@ -11,6 +11,7 @@ import {
|
|
|
11
11
|
promptCountLabel,
|
|
12
12
|
selectedSensitiveCount,
|
|
13
13
|
stringifyIo,
|
|
14
|
+
TRACE_FILTER_FIELDS,
|
|
14
15
|
type TraceListItem,
|
|
15
16
|
type TraceSpanNode,
|
|
16
17
|
traceFiltersToFilterValues,
|
|
@@ -113,6 +114,7 @@ describe("traceTypes helpers", () => {
|
|
|
113
114
|
prompts: [],
|
|
114
115
|
sessionId: "",
|
|
115
116
|
status: "",
|
|
117
|
+
tag: "",
|
|
116
118
|
to: "",
|
|
117
119
|
userId: "",
|
|
118
120
|
});
|
|
@@ -135,6 +137,7 @@ describe("traceTypes helpers", () => {
|
|
|
135
137
|
sensitive: true,
|
|
136
138
|
sessionId: "sess-1",
|
|
137
139
|
status: "error" as const,
|
|
140
|
+
tag: "model:glm-5.3",
|
|
138
141
|
to: "2026-09-02T23:59:59.999Z",
|
|
139
142
|
userId: "user-1",
|
|
140
143
|
};
|
|
@@ -147,6 +150,7 @@ describe("traceTypes helpers", () => {
|
|
|
147
150
|
startedAt_gte: "2026-09-01T00:00:00.000Z",
|
|
148
151
|
startedAt_lte: "2026-09-02T23:59:59.999Z",
|
|
149
152
|
status: ["error"],
|
|
153
|
+
tag: "model:glm-5.3",
|
|
150
154
|
userId: "user-1",
|
|
151
155
|
});
|
|
152
156
|
assert.deepEqual(filterValuesToTraceFilters(values, filters), filters);
|
|
@@ -167,10 +171,52 @@ describe("traceTypes helpers", () => {
|
|
|
167
171
|
prompts: ["summarize"],
|
|
168
172
|
sessionId: "",
|
|
169
173
|
status: "",
|
|
174
|
+
tag: "",
|
|
170
175
|
to: "",
|
|
171
176
|
userId: "",
|
|
172
177
|
});
|
|
173
178
|
assert.equal(filterValuesToTraceFilters({status: ["ok", "bogus"]}).status, "ok");
|
|
174
179
|
assert.equal(filterValuesToTraceFilters({hasScore: "false"}).hasScore, false);
|
|
175
180
|
});
|
|
181
|
+
|
|
182
|
+
it("exposes the feedback filter fields", () => {
|
|
183
|
+
expect(TRACE_FILTER_FIELDS.thumbs).toBe("thumbs");
|
|
184
|
+
expect(TRACE_FILTER_FIELDS.signal).toBe("signal");
|
|
185
|
+
expect(TRACE_FILTER_FIELDS.hasComment).toBe("hasComment");
|
|
186
|
+
});
|
|
187
|
+
|
|
188
|
+
it("reads thumbs, signal, and hasComment from DataTable filter values", () => {
|
|
189
|
+
const filters = filterValuesToTraceFilters({
|
|
190
|
+
hasComment: true,
|
|
191
|
+
signal: ["dismissed"],
|
|
192
|
+
thumbs: ["down"],
|
|
193
|
+
});
|
|
194
|
+
expect(filters.thumbs).toBe("down");
|
|
195
|
+
expect(filters.signal).toBe("dismissed");
|
|
196
|
+
expect(filters.hasComment).toBe(true);
|
|
197
|
+
});
|
|
198
|
+
|
|
199
|
+
it("leaves feedback filters unset for Any and ignores unknown values", () => {
|
|
200
|
+
const any = filterValuesToTraceFilters({signal: [], thumbs: []});
|
|
201
|
+
expect(any.thumbs).toBeUndefined();
|
|
202
|
+
expect(any.signal).toBeUndefined();
|
|
203
|
+
expect(any.hasComment).toBeUndefined();
|
|
204
|
+
expect(filterValuesToTraceFilters({thumbs: ["up"]}).thumbs).toBe("up");
|
|
205
|
+
const bogus = filterValuesToTraceFilters({signal: ["nope"], thumbs: ["sideways"]});
|
|
206
|
+
expect(bogus.thumbs).toBeUndefined();
|
|
207
|
+
expect(bogus.signal).toBeUndefined();
|
|
208
|
+
});
|
|
209
|
+
|
|
210
|
+
it("round-trips feedback filters through the DataTable filter values", () => {
|
|
211
|
+
const filters = {
|
|
212
|
+
...emptyTraceFilters(),
|
|
213
|
+
hasComment: false,
|
|
214
|
+
signal: "copied" as const,
|
|
215
|
+
thumbs: "up" as const,
|
|
216
|
+
};
|
|
217
|
+
const roundTripped = filterValuesToTraceFilters(traceFiltersToFilterValues(filters));
|
|
218
|
+
expect(roundTripped.thumbs).toBe("up");
|
|
219
|
+
expect(roundTripped.signal).toBe("copied");
|
|
220
|
+
expect(roundTripped.hasComment).toBe(false);
|
|
221
|
+
});
|
|
176
222
|
});
|
|
@@ -26,6 +26,7 @@ export interface TraceListItem {
|
|
|
26
26
|
spanCount: number;
|
|
27
27
|
startedAt: string;
|
|
28
28
|
status: "error" | "ok";
|
|
29
|
+
tags?: string[];
|
|
29
30
|
usage?: TraceUsage;
|
|
30
31
|
userId?: string;
|
|
31
32
|
}
|
|
@@ -72,15 +73,32 @@ export interface TraceListResponse {
|
|
|
72
73
|
total: number;
|
|
73
74
|
}
|
|
74
75
|
|
|
76
|
+
/** Passive feedback signals the backend records as `user-signal` scores. */
|
|
77
|
+
export const TRACE_FEEDBACK_SIGNALS = [
|
|
78
|
+
"accepted",
|
|
79
|
+
"dismissed",
|
|
80
|
+
"copied",
|
|
81
|
+
"edited",
|
|
82
|
+
"regenerated",
|
|
83
|
+
] as const;
|
|
84
|
+
export type TraceFeedbackSignal = (typeof TRACE_FEEDBACK_SIGNALS)[number];
|
|
85
|
+
|
|
75
86
|
export interface TraceListFilters {
|
|
76
87
|
flaggedForDataset?: boolean;
|
|
77
88
|
from: string;
|
|
89
|
+
/** Traces with (or without) an end-user comment. */
|
|
90
|
+
hasComment?: boolean;
|
|
78
91
|
hasScore?: boolean;
|
|
79
92
|
/** Prompt names; a trace matches when it used any of them. */
|
|
80
93
|
prompts: string[];
|
|
81
94
|
sensitive?: boolean;
|
|
82
95
|
sessionId: string;
|
|
96
|
+
/** A passive signal the user sent, e.g. `dismissed`. */
|
|
97
|
+
signal?: TraceFeedbackSignal;
|
|
83
98
|
status: "" | "error" | "ok";
|
|
99
|
+
tag: string;
|
|
100
|
+
/** End-user thumbs direction. */
|
|
101
|
+
thumbs?: "down" | "up";
|
|
84
102
|
to: string;
|
|
85
103
|
userId: string;
|
|
86
104
|
}
|
|
@@ -114,12 +132,16 @@ export const DEFAULT_TRACE_SORT = "-startedAt";
|
|
|
114
132
|
|
|
115
133
|
/** DataTable filter field keys used by the Traces screen. */
|
|
116
134
|
export const TRACE_FILTER_FIELDS = {
|
|
135
|
+
hasComment: "hasComment",
|
|
117
136
|
hasScore: "hasScore",
|
|
118
137
|
prompt: "prompt",
|
|
119
138
|
sensitive: "sensitive",
|
|
120
139
|
sessionId: "sessionId",
|
|
140
|
+
signal: "signal",
|
|
121
141
|
startedAt: "startedAt",
|
|
122
142
|
status: "status",
|
|
143
|
+
tag: "tag",
|
|
144
|
+
thumbs: "thumbs",
|
|
123
145
|
userId: "userId",
|
|
124
146
|
} as const;
|
|
125
147
|
|
|
@@ -128,6 +150,7 @@ export const emptyTraceFilters = (): TraceListFilters => ({
|
|
|
128
150
|
prompts: [],
|
|
129
151
|
sessionId: "",
|
|
130
152
|
status: "",
|
|
153
|
+
tag: "",
|
|
131
154
|
to: "",
|
|
132
155
|
userId: "",
|
|
133
156
|
});
|
|
@@ -178,12 +201,24 @@ export const traceFiltersToFilterValues = (filters: TraceListFilters): Record<st
|
|
|
178
201
|
if (filters.hasScore !== undefined) {
|
|
179
202
|
values[fields.hasScore] = filters.hasScore;
|
|
180
203
|
}
|
|
204
|
+
if (filters.thumbs) {
|
|
205
|
+
values[fields.thumbs] = [filters.thumbs];
|
|
206
|
+
}
|
|
207
|
+
if (filters.signal) {
|
|
208
|
+
values[fields.signal] = [filters.signal];
|
|
209
|
+
}
|
|
210
|
+
if (filters.hasComment !== undefined) {
|
|
211
|
+
values[fields.hasComment] = filters.hasComment;
|
|
212
|
+
}
|
|
181
213
|
if (filters.userId) {
|
|
182
214
|
values[fields.userId] = filters.userId;
|
|
183
215
|
}
|
|
184
216
|
if (filters.sessionId) {
|
|
185
217
|
values[fields.sessionId] = filters.sessionId;
|
|
186
218
|
}
|
|
219
|
+
if (filters.tag) {
|
|
220
|
+
values[fields.tag] = filters.tag;
|
|
221
|
+
}
|
|
187
222
|
return values;
|
|
188
223
|
};
|
|
189
224
|
|
|
@@ -204,6 +239,7 @@ export const filterValuesToTraceFilters = (
|
|
|
204
239
|
prompts: stringList(values[fields.prompt]),
|
|
205
240
|
sessionId: trimmedString(values[fields.sessionId]),
|
|
206
241
|
status: statuses.length === 1 ? (statuses[0] ?? "") : "",
|
|
242
|
+
tag: trimmedString(values[fields.tag]),
|
|
207
243
|
to: trimmedString(values[`${fields.startedAt}_lte`]),
|
|
208
244
|
userId: trimmedString(values[fields.userId]),
|
|
209
245
|
};
|
|
@@ -215,6 +251,23 @@ export const filterValuesToTraceFilters = (
|
|
|
215
251
|
if (hasScore !== undefined) {
|
|
216
252
|
filters.hasScore = hasScore;
|
|
217
253
|
}
|
|
254
|
+
// Choice filters: one picked value narrows; none (Any) or several means no filter.
|
|
255
|
+
const thumbs = stringList(values[fields.thumbs]).filter(
|
|
256
|
+
(entry): entry is "down" | "up" => entry === "down" || entry === "up"
|
|
257
|
+
);
|
|
258
|
+
if (thumbs.length === 1) {
|
|
259
|
+
filters.thumbs = thumbs[0];
|
|
260
|
+
}
|
|
261
|
+
const signals = stringList(values[fields.signal]).filter((entry): entry is TraceFeedbackSignal =>
|
|
262
|
+
(TRACE_FEEDBACK_SIGNALS as readonly string[]).includes(entry)
|
|
263
|
+
);
|
|
264
|
+
if (signals.length === 1) {
|
|
265
|
+
filters.signal = signals[0];
|
|
266
|
+
}
|
|
267
|
+
const hasComment = optionalBoolean(values[fields.hasComment]);
|
|
268
|
+
if (hasComment !== undefined) {
|
|
269
|
+
filters.hasComment = hasComment;
|
|
270
|
+
}
|
|
218
271
|
if (previous?.flaggedForDataset !== undefined) {
|
|
219
272
|
filters.flaggedForDataset = previous.flaggedForDataset;
|
|
220
273
|
}
|