@terreno/admin-frontend 58.0.6 → 58.1.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (130) hide show
  1. package/CHANGELOG.md +52 -0
  2. package/dist/AdminNestedArrayField.d.ts.map +1 -1
  3. package/dist/AdminNestedArrayField.js +6 -5
  4. package/dist/AdminNestedArrayField.js.map +1 -1
  5. package/dist/AdminRolesList.d.ts +34 -1
  6. package/dist/AdminRolesList.d.ts.map +1 -1
  7. package/dist/AdminRolesList.js +53 -8
  8. package/dist/AdminRolesList.js.map +1 -1
  9. package/dist/AdminShell.d.ts.map +1 -1
  10. package/dist/AdminShell.js +7 -2
  11. package/dist/AdminShell.js.map +1 -1
  12. package/dist/index.d.ts +2 -1
  13. package/dist/index.d.ts.map +1 -1
  14. package/dist/index.js +2 -1
  15. package/dist/index.js.map +1 -1
  16. package/dist/useAdminRoles.d.ts +8 -0
  17. package/dist/useAdminRoles.d.ts.map +1 -1
  18. package/dist/useAdminRoles.js +11 -0
  19. package/dist/useAdminRoles.js.map +1 -1
  20. package/dist/widgets/aiObservability/datasets/AiDatasetDetailScreen.d.ts.map +1 -1
  21. package/dist/widgets/aiObservability/datasets/AiDatasetDetailScreen.js +10 -36
  22. package/dist/widgets/aiObservability/datasets/AiDatasetDetailScreen.js.map +1 -1
  23. package/dist/widgets/aiObservability/datasets/AiDatasetDetailView.d.ts +4 -6
  24. package/dist/widgets/aiObservability/datasets/AiDatasetDetailView.d.ts.map +1 -1
  25. package/dist/widgets/aiObservability/datasets/AiDatasetDetailView.js +11 -64
  26. package/dist/widgets/aiObservability/datasets/AiDatasetDetailView.js.map +1 -1
  27. package/dist/widgets/aiObservability/datasets/AiDatasetItemScreen.d.ts +4 -0
  28. package/dist/widgets/aiObservability/datasets/AiDatasetItemScreen.d.ts.map +1 -0
  29. package/dist/widgets/aiObservability/datasets/AiDatasetItemScreen.js +204 -0
  30. package/dist/widgets/aiObservability/datasets/AiDatasetItemScreen.js.map +1 -0
  31. package/dist/widgets/aiObservability/datasets/AiDatasetItemView.d.ts +23 -0
  32. package/dist/widgets/aiObservability/datasets/AiDatasetItemView.d.ts.map +1 -0
  33. package/dist/widgets/aiObservability/datasets/AiDatasetItemView.js +31 -0
  34. package/dist/widgets/aiObservability/datasets/AiDatasetItemView.js.map +1 -0
  35. package/dist/widgets/aiObservability/datasets/ExpectedOutputForm.d.ts +12 -0
  36. package/dist/widgets/aiObservability/datasets/ExpectedOutputForm.d.ts.map +1 -0
  37. package/dist/widgets/aiObservability/datasets/ExpectedOutputForm.js +101 -0
  38. package/dist/widgets/aiObservability/datasets/ExpectedOutputForm.js.map +1 -0
  39. package/dist/widgets/aiObservability/datasets/datasetTypes.d.ts +5 -0
  40. package/dist/widgets/aiObservability/datasets/datasetTypes.d.ts.map +1 -1
  41. package/dist/widgets/aiObservability/datasets/datasetTypes.js +9 -0
  42. package/dist/widgets/aiObservability/datasets/datasetTypes.js.map +1 -1
  43. package/dist/widgets/aiObservability/datasets/expectedOutputModel.d.ts +44 -0
  44. package/dist/widgets/aiObservability/datasets/expectedOutputModel.d.ts.map +1 -0
  45. package/dist/widgets/aiObservability/datasets/expectedOutputModel.js +265 -0
  46. package/dist/widgets/aiObservability/datasets/expectedOutputModel.js.map +1 -0
  47. package/dist/widgets/aiObservability/datasets/useAiObservabilityDatasetsApi.d.ts +6 -0
  48. package/dist/widgets/aiObservability/datasets/useAiObservabilityDatasetsApi.d.ts.map +1 -1
  49. package/dist/widgets/aiObservability/datasets/useAiObservabilityDatasetsApi.js +8 -0
  50. package/dist/widgets/aiObservability/datasets/useAiObservabilityDatasetsApi.js.map +1 -1
  51. package/dist/widgets/aiObservability/prompts/AiPromptEditorView.d.ts.map +1 -1
  52. package/dist/widgets/aiObservability/prompts/AiPromptEditorView.js +5 -2
  53. package/dist/widgets/aiObservability/prompts/AiPromptEditorView.js.map +1 -1
  54. package/dist/widgets/aiObservability/prompts/AiPromptHubView.d.ts.map +1 -1
  55. package/dist/widgets/aiObservability/prompts/AiPromptHubView.js +4 -3
  56. package/dist/widgets/aiObservability/prompts/AiPromptHubView.js.map +1 -1
  57. package/dist/widgets/aiObservability/prompts/AiPromptsListScreen.d.ts.map +1 -1
  58. package/dist/widgets/aiObservability/prompts/AiPromptsListScreen.js +2 -1
  59. package/dist/widgets/aiObservability/prompts/AiPromptsListScreen.js.map +1 -1
  60. package/dist/widgets/aiObservability/prompts/AiPromptsListView.d.ts +2 -0
  61. package/dist/widgets/aiObservability/prompts/AiPromptsListView.d.ts.map +1 -1
  62. package/dist/widgets/aiObservability/prompts/AiPromptsListView.js +92 -26
  63. package/dist/widgets/aiObservability/prompts/AiPromptsListView.js.map +1 -1
  64. package/dist/widgets/aiObservability/prompts/promptTypes.d.ts +29 -5
  65. package/dist/widgets/aiObservability/prompts/promptTypes.d.ts.map +1 -1
  66. package/dist/widgets/aiObservability/prompts/promptTypes.js +114 -11
  67. package/dist/widgets/aiObservability/prompts/promptTypes.js.map +1 -1
  68. package/dist/widgets/aiObservability/shell/AiObservabilityScreenWidgets.d.ts.map +1 -1
  69. package/dist/widgets/aiObservability/shell/AiObservabilityScreenWidgets.js +2 -0
  70. package/dist/widgets/aiObservability/shell/AiObservabilityScreenWidgets.js.map +1 -1
  71. package/dist/widgets/aiObservability/shell/aiObservabilityNav.d.ts.map +1 -1
  72. package/dist/widgets/aiObservability/shell/aiObservabilityNav.js +1 -0
  73. package/dist/widgets/aiObservability/shell/aiObservabilityNav.js.map +1 -1
  74. package/dist/widgets/aiObservability/traces/AiTraceDetailView.d.ts.map +1 -1
  75. package/dist/widgets/aiObservability/traces/AiTraceDetailView.js +15 -1
  76. package/dist/widgets/aiObservability/traces/AiTraceDetailView.js.map +1 -1
  77. package/dist/widgets/aiObservability/traces/AiTracesListView.d.ts.map +1 -1
  78. package/dist/widgets/aiObservability/traces/AiTracesListView.js +20 -1
  79. package/dist/widgets/aiObservability/traces/AiTracesListView.js.map +1 -1
  80. package/dist/widgets/aiObservability/traces/traceTypes.d.ts +12 -0
  81. package/dist/widgets/aiObservability/traces/traceTypes.d.ts.map +1 -1
  82. package/dist/widgets/aiObservability/traces/traceTypes.js +33 -0
  83. package/dist/widgets/aiObservability/traces/traceTypes.js.map +1 -1
  84. package/dist/widgets/aiObservability/traces/useAiObservabilityTracesApi.d.ts.map +1 -1
  85. package/dist/widgets/aiObservability/traces/useAiObservabilityTracesApi.js +9 -0
  86. package/dist/widgets/aiObservability/traces/useAiObservabilityTracesApi.js.map +1 -1
  87. package/package.json +4 -4
  88. package/src/AdminNestedArrayField.tsx +6 -4
  89. package/src/AdminRolesList.test.tsx +119 -2
  90. package/src/AdminRolesList.tsx +171 -13
  91. package/src/AdminShell.test.tsx +14 -0
  92. package/src/AdminShell.tsx +7 -1
  93. package/src/index.tsx +13 -1
  94. package/src/isolated/AdminNestedArrayField.isolated.tsx +50 -8
  95. package/src/isolated/aiObservabilityDatasets.isolated.tsx +417 -67
  96. package/src/isolated/aiObservabilityPrompts.isolated.tsx +42 -24
  97. package/src/isolated/aiObservabilityTraces.isolated.tsx +2 -1
  98. package/src/isolated/aiTracesTable.isolated.tsx +17 -1
  99. package/src/useAdminRoles.test.ts +15 -1
  100. package/src/useAdminRoles.ts +25 -1
  101. package/src/widgets/aiObservability/datasets/AiDatasetDetailScreen.tsx +17 -48
  102. package/src/widgets/aiObservability/datasets/AiDatasetDetailView.test.tsx +40 -77
  103. package/src/widgets/aiObservability/datasets/AiDatasetDetailView.tsx +29 -153
  104. package/src/widgets/aiObservability/datasets/AiDatasetItemScreen.tsx +279 -0
  105. package/src/widgets/aiObservability/datasets/AiDatasetItemView.test.tsx +110 -0
  106. package/src/widgets/aiObservability/datasets/AiDatasetItemView.tsx +174 -0
  107. package/src/widgets/aiObservability/datasets/ExpectedOutputForm.test.tsx +234 -0
  108. package/src/widgets/aiObservability/datasets/ExpectedOutputForm.tsx +313 -0
  109. package/src/widgets/aiObservability/datasets/datasetTypes.test.ts +31 -0
  110. package/src/widgets/aiObservability/datasets/datasetTypes.ts +13 -0
  111. package/src/widgets/aiObservability/datasets/expectedOutputModel.test.ts +285 -0
  112. package/src/widgets/aiObservability/datasets/expectedOutputModel.ts +338 -0
  113. package/src/widgets/aiObservability/datasets/useAiObservabilityDatasetsApi.test.ts +11 -0
  114. package/src/widgets/aiObservability/datasets/useAiObservabilityDatasetsApi.ts +22 -0
  115. package/src/widgets/aiObservability/prompts/AiPromptEditorView.tsx +7 -2
  116. package/src/widgets/aiObservability/prompts/AiPromptHubView.tsx +10 -3
  117. package/src/widgets/aiObservability/prompts/AiPromptsListScreen.tsx +3 -0
  118. package/src/widgets/aiObservability/prompts/AiPromptsListView.test.tsx +149 -3
  119. package/src/widgets/aiObservability/prompts/AiPromptsListView.tsx +176 -42
  120. package/src/widgets/aiObservability/prompts/promptTypes.test.ts +87 -7
  121. package/src/widgets/aiObservability/prompts/promptTypes.ts +140 -15
  122. package/src/widgets/aiObservability/shell/AiObservabilityScreenWidgets.tsx +2 -0
  123. package/src/widgets/aiObservability/shell/aiObservabilityNav.ts +1 -0
  124. package/src/widgets/aiObservability/traces/AiTraceDetailView.test.tsx +107 -0
  125. package/src/widgets/aiObservability/traces/AiTraceDetailView.tsx +42 -7
  126. package/src/widgets/aiObservability/traces/AiTracesListView.tsx +20 -0
  127. package/src/widgets/aiObservability/traces/traceTypes.test.ts +42 -0
  128. package/src/widgets/aiObservability/traces/traceTypes.ts +45 -0
  129. package/src/widgets/aiObservability/traces/useAiObservabilityTracesApi.test.ts +38 -0
  130. package/src/widgets/aiObservability/traces/useAiObservabilityTracesApi.ts +9 -0
@@ -290,6 +290,7 @@ describe("AiObservabilityChrome", () => {
290
290
  it("registers phase 2 screen widgets including evaluators, datasets, and experiments", () => {
291
291
  expect(Object.keys(AI_OBSERVABILITY_WIDGETS).sort()).toEqual([
292
292
  "ai-dataset-detail",
293
+ "ai-dataset-item",
293
294
  "ai-datasets",
294
295
  "ai-evaluator-detail",
295
296
  "ai-evaluator-new",
@@ -1006,8 +1007,17 @@ describe("AiPromptsListScreen", () => {
1006
1007
  latestVersion: 1,
1007
1008
  name: "summarize",
1008
1009
  production: "—",
1010
+ tags: ["gold"],
1009
1011
  type: "chat",
1010
1012
  },
1013
+ {
1014
+ folder: "ops",
1015
+ latestVersion: 1,
1016
+ name: "triage",
1017
+ production: "—",
1018
+ tags: ["ops"],
1019
+ type: "text",
1020
+ },
1011
1021
  ];
1012
1022
 
1013
1023
  const listState: FakeQueryState = {
@@ -1073,6 +1083,10 @@ describe("AiPromptsListScreen", () => {
1073
1083
  const server = createServer();
1074
1084
  const view = renderWithTheme(<AiPromptsScreenWidget {...widgetProps} server={server} />);
1075
1085
  await flushObservabilityRequests();
1086
+ await act(async () => {
1087
+ fireEvent.press(view.getByTestId("ai-prompts-folder-examples-clickable"));
1088
+ await Promise.resolve();
1089
+ });
1076
1090
  await act(async () => {
1077
1091
  fireEvent.press(view.getByTestId("ai-prompt-open-summarize"));
1078
1092
  await new Promise((resolve) => setTimeout(resolve, 50));
@@ -1133,19 +1147,26 @@ describe("AiPromptsListScreen", () => {
1133
1147
  Object.assign(listState, {data: loaded, error: undefined, isError: false, isLoading: false});
1134
1148
  });
1135
1149
 
1136
- it("filters by folder and search and retries load errors", async () => {
1150
+ it("filters by tag and retries load errors", async () => {
1137
1151
  Object.assign(listState, {data: loaded, error: undefined, isError: false, isLoading: false});
1138
1152
  const view = renderWithTheme(
1139
1153
  <AiPromptsScreenWidget {...widgetProps} server={createServer()} />
1140
1154
  );
1141
1155
  await flushObservabilityRequests();
1142
- fireEvent.changeText(view.getByTestId("ai-prompts-search"), "summ");
1156
+ fireEvent.changeText(view.getByTestId("ai-prompts-search"), "");
1157
+ const tagSelect = view.UNSAFE_root.findAllByType(SelectField).find(
1158
+ (field) => field.props.title === "Tag"
1159
+ );
1160
+ assert.exists(tagSelect);
1161
+ if (!tagSelect) {
1162
+ return;
1163
+ }
1143
1164
  await act(async () => {
1144
- // The folder picker renders above the table, so its segment is the first match.
1145
- fireEvent.press(view.getAllByText("examples")[0]!);
1165
+ fireEvent(tagSelect, "onChange", "gold");
1146
1166
  await Promise.resolve();
1147
1167
  });
1148
- expect(view.getByTestId("ai-prompts-table")).toBeTruthy();
1168
+ expect(view.getByText("summarize")).toBeTruthy();
1169
+ expect(view.queryByText("triage")).toBeNull();
1149
1170
 
1150
1171
  Object.assign(listState, {
1151
1172
  data: undefined,
@@ -1198,12 +1219,14 @@ describe("AiPromptsListView", () => {
1198
1219
  latestVersion: 2,
1199
1220
  name: "summarize",
1200
1221
  production: 1,
1222
+ tags: ["gold"],
1201
1223
  type: "chat",
1202
1224
  usage7d: {calls: 3, costUsd: 0.2},
1203
1225
  },
1204
1226
  ];
1205
1227
 
1206
1228
  const idleHandlers = {
1229
+ folder: "",
1207
1230
  onCreate: () => undefined,
1208
1231
  onCreateDescriptionChange: () => undefined,
1209
1232
  onCreateFolderChange: () => undefined,
@@ -1215,6 +1238,8 @@ describe("AiPromptsListView", () => {
1215
1238
  onOpenCreate: () => undefined,
1216
1239
  onOpenPrompt: () => undefined,
1217
1240
  onSearchChange: () => undefined,
1241
+ onTagChange: () => undefined,
1242
+ tag: "",
1218
1243
  };
1219
1244
 
1220
1245
  describe("AiPromptsListView", () => {
@@ -1227,7 +1252,6 @@ describe("AiPromptsListView", () => {
1227
1252
  createOpen={false}
1228
1253
  createSystem=""
1229
1254
  createTemplate=""
1230
- folder=""
1231
1255
  isLoading
1232
1256
  prompts={[]}
1233
1257
  search=""
@@ -1246,7 +1270,6 @@ describe("AiPromptsListView", () => {
1246
1270
  createOpen={false}
1247
1271
  createSystem=""
1248
1272
  createTemplate=""
1249
- folder=""
1250
1273
  prompts={[]}
1251
1274
  search=""
1252
1275
  {...idleHandlers}
@@ -1256,8 +1279,8 @@ describe("AiPromptsListView", () => {
1256
1279
  expect(getByText("No prompts yet")).toBeTruthy();
1257
1280
  });
1258
1281
 
1259
- it("renders a loaded table with folder counts and newest vs production columns", () => {
1260
- const {getAllByText, getByTestId, getByText} = renderWithTheme(
1282
+ it("renders a loaded table with a tag filter and newest vs production columns", () => {
1283
+ const {getByTestId, getByText} = renderWithTheme(
1261
1284
  <AiPromptsListView
1262
1285
  createDescription=""
1263
1286
  createFolder="examples"
@@ -1265,17 +1288,14 @@ describe("AiPromptsListView", () => {
1265
1288
  createOpen={false}
1266
1289
  createSystem=""
1267
1290
  createTemplate=""
1268
- folder=""
1269
1291
  prompts={prompts}
1270
1292
  search=""
1271
1293
  {...idleHandlers}
1294
+ folder="examples"
1272
1295
  />
1273
1296
  );
1274
1297
  expect(getByTestId("ai-prompts-table")).toBeTruthy();
1275
- expect(getByTestId("ai-prompts-folders")).toBeTruthy();
1276
- expect(getByText("All")).toBeTruthy();
1277
- // Folder segment plus the row's folder line.
1278
- assert.isAtLeast(getAllByText("examples").length, 2);
1298
+ expect(getByTestId("ai-prompts-tag.label")).toBeTruthy();
1279
1299
  expect(getByText("summarize")).toBeTruthy();
1280
1300
  expect(getByText("v2")).toBeTruthy();
1281
1301
  expect(getByText("v1")).toBeTruthy();
@@ -1290,21 +1310,21 @@ describe("AiPromptsListView", () => {
1290
1310
  createOpen={false}
1291
1311
  createSystem=""
1292
1312
  createTemplate=""
1293
- folder=""
1294
1313
  prompts={prompts}
1295
1314
  search=""
1296
1315
  {...idleHandlers}
1316
+ folder="examples"
1297
1317
  />
1298
1318
  );
1299
1319
  expect(getByTestId("ai-prompt-open-summarize")).toBeTruthy();
1300
1320
  });
1301
1321
 
1302
- it("filters by folder and search and wires create modal fields", async () => {
1303
- const onFolderChange = mock(() => undefined);
1322
+ it("wires search, tag, and create modal fields", async () => {
1323
+ const onTagChange = mock(() => undefined);
1304
1324
  const onSearchChange = mock(() => undefined);
1305
1325
  const onCreate = mock(() => undefined);
1306
1326
  const onRetry = mock(() => undefined);
1307
- const {getAllByText, getByTestId, getByText} = renderWithTheme(
1327
+ const {getByTestId, getByText} = renderWithTheme(
1308
1328
  <AiPromptsListView
1309
1329
  createDescription="Short summary"
1310
1330
  createError="Name required"
@@ -1322,22 +1342,20 @@ describe("AiPromptsListView", () => {
1322
1342
  onCreateSystemChange={() => undefined}
1323
1343
  onCreateTemplateChange={() => undefined}
1324
1344
  onDismissCreate={() => undefined}
1325
- onFolderChange={onFolderChange}
1345
+ onFolderChange={() => undefined}
1326
1346
  onOpenCreate={() => undefined}
1327
1347
  onOpenPrompt={() => undefined}
1328
1348
  onRetry={onRetry}
1329
1349
  onSearchChange={onSearchChange}
1350
+ onTagChange={onTagChange}
1330
1351
  prompts={prompts}
1331
1352
  search="summ"
1353
+ tag=""
1332
1354
  />
1333
1355
  );
1334
1356
  fireEvent.changeText(getByTestId("ai-prompts-search"), "note");
1335
1357
  assert.isAtLeast(onSearchChange.mock.calls.length, 1);
1336
- await act(async () => {
1337
- fireEvent.press(getAllByText("examples")[0]!);
1338
- await Promise.resolve();
1339
- });
1340
- assert.isAtLeast(onFolderChange.mock.calls.length, 1);
1358
+ expect(getByTestId("ai-prompts-tag.label")).toBeTruthy();
1341
1359
  await act(async () => {
1342
1360
  fireEvent.press(getByText("Try again"));
1343
1361
  await Promise.resolve();
@@ -230,7 +230,8 @@ describe("AiTraceDetailView", () => {
230
230
  expect(getByText("LLM")).toBeTruthy();
231
231
  expect(getByText("correct")).toBeTruthy();
232
232
  expect(getByText("true")).toBeTruthy();
233
- expect(getByText("human")).toBeTruthy();
233
+ // T10 shows score sources as badges ("human" → "Human").
234
+ expect(getByText("Human")).toBeTruthy();
234
235
  expect(getByTestId("ai-trace-span-input")).toBeTruthy();
235
236
  expect(getByText("Input (sensitive)")).toBeTruthy();
236
237
  expect(queryByText("patient SSN 123-45-6789")).toBeNull();
@@ -213,7 +213,8 @@ describe("AiTracesListView table", () => {
213
213
  assert.equal(columnByTitle(columns, "Scores").filter?.field, "hasScore");
214
214
  assert.deepEqual(
215
215
  (table.props.additionalFilters as Array<{field: string}>).map((filter) => filter.field),
216
- ["sensitive", "userId", "sessionId"]
216
+ // T10 (ai-user-feedback) adds the end-user feedback filters.
217
+ ["sensitive", "userId", "sessionId", "thumbs", "signal", "hasComment"]
217
218
  );
218
219
 
219
220
  // 32px cell padding plus about 9px per character keeps these values on one line.
@@ -357,6 +358,21 @@ describe("AiTracesScreenWidget table query", () => {
357
358
  userId: "user-1",
358
359
  });
359
360
 
361
+ // End-user feedback filters (T10): one picked choice narrows; Any (nothing picked) is absent.
362
+ await fireTable("filterValuesChange", {
363
+ hasComment: true,
364
+ signal: ["dismissed"],
365
+ thumbs: ["down"],
366
+ });
367
+ assert.deepInclude(Object.fromEntries(lastListQuery(server).entries()), {
368
+ hasComment: "true",
369
+ signal: "dismissed",
370
+ thumbs: "down",
371
+ });
372
+ await fireTable("filterValuesChange", {signal: [], thumbs: []});
373
+ assert.isFalse(lastListQuery(server).has("thumbs"));
374
+ assert.isFalse(lastListQuery(server).has("signal"));
375
+
360
376
  await fireTable("filterValuesChange", {});
361
377
  // Cleared filters drop out of the request; sort and paging remain.
362
378
  assert.deepEqual(Object.fromEntries(lastListQuery(server).entries()), {
@@ -1,6 +1,6 @@
1
1
  import {describe, expect, it} from "bun:test";
2
2
 
3
- import {normalizeRoles, normalizeStatements} from "./useAdminRoles";
3
+ import {normalizeRoles, normalizeStatementDescriptions, normalizeStatements} from "./useAdminRoles";
4
4
 
5
5
  describe("normalizeRoles", () => {
6
6
  it("returns arrays unchanged", () => {
@@ -26,3 +26,17 @@ describe("normalizeStatements", () => {
26
26
  expect(normalizeStatements(undefined)).toEqual({});
27
27
  });
28
28
  });
29
+
30
+ describe("normalizeStatementDescriptions", () => {
31
+ it("reads descriptions from either envelope and defaults to empty", () => {
32
+ const descriptions = {todo: {read: "View todos"}};
33
+ expect(normalizeStatementDescriptions({statementDescriptions: descriptions})).toEqual(
34
+ descriptions
35
+ );
36
+ expect(normalizeStatementDescriptions({data: {statementDescriptions: descriptions}})).toEqual(
37
+ descriptions
38
+ );
39
+ expect(normalizeStatementDescriptions(undefined)).toEqual({});
40
+ expect(normalizeStatementDescriptions({statements: {todo: ["read"]}})).toEqual({});
41
+ });
42
+ });
@@ -14,6 +14,11 @@ export interface RbacStatements {
14
14
  [resource: string]: readonly string[];
15
15
  }
16
16
 
17
+ /** Optional labels for permissions, keyed by resource then action. */
18
+ export interface StatementDescriptions {
19
+ [resource: string]: Record<string, string>;
20
+ }
21
+
17
22
  export interface RoleInput {
18
23
  description?: string | null;
19
24
  displayName: string;
@@ -32,7 +37,11 @@ type UpdateRoleMutation = [
32
37
  {isLoading: boolean},
33
38
  ];
34
39
 
35
- type StatementsData = {data?: {statements?: RbacStatements}; statements?: RbacStatements};
40
+ type StatementsData = {
41
+ data?: {statementDescriptions?: StatementDescriptions; statements?: RbacStatements};
42
+ statementDescriptions?: StatementDescriptions;
43
+ statements?: RbacStatements;
44
+ };
36
45
 
37
46
  interface StatementsQueryResult {
38
47
  data?: StatementsData;
@@ -67,6 +76,21 @@ export const normalizeStatements = (data: StatementsQueryResult["data"]): RbacSt
67
76
  return data?.statements ?? data?.data?.statements ?? {};
68
77
  };
69
78
 
79
+ const isDescriptionMap = (value: unknown): value is StatementDescriptions => {
80
+ return typeof value === "object" && value !== null && !Array.isArray(value);
81
+ };
82
+
83
+ /** Reads optional permission labels from either statements envelope. */
84
+ export const normalizeStatementDescriptions = (
85
+ data: StatementsQueryResult["data"]
86
+ ): StatementDescriptions => {
87
+ const raw = data?.statementDescriptions ?? data?.data?.statementDescriptions;
88
+ if (!isDescriptionMap(raw)) {
89
+ return {};
90
+ }
91
+ return raw;
92
+ };
93
+
70
94
  /**
71
95
  * Roles are served by `rbacRouter`, which mounts at the API root rather than under the
72
96
  * admin base, so the admin base segment is trimmed before building the URL.
@@ -7,15 +7,17 @@ import {AiObservabilityChrome} from "../shell/AiObservabilityChrome";
7
7
  import {unwrapObservabilityStatus} from "../shell/aiObservabilityNav";
8
8
  import {observabilityActionAllowed} from "../shell/observabilityPermissions";
9
9
  import {AiDatasetDetailView} from "./AiDatasetDetailView";
10
- import {unwrapDatasetItems, unwrapDatasetRecord} from "./datasetTypes";
10
+ import {type DatasetItemTab, unwrapDatasetItems, unwrapDatasetRecord} from "./datasetTypes";
11
11
  import {useAiObservabilityDatasetsApi} from "./useAiObservabilityDatasetsApi";
12
12
 
13
13
  export const AiDatasetDetailScreenWidget: React.FC<AdminScreenWidgetProps> = (props) => {
14
14
  const {routeBase} = props;
15
- const params = useLocalSearchParams<{id?: string | string[]}>();
15
+ const params = useLocalSearchParams<{id?: string | string[]; tab?: string | string[]}>();
16
16
  const idParam = params.id;
17
17
  const id = Array.isArray(idParam) ? idParam[0] : idParam;
18
- const {useCreateItemMutation, useDetailQuery, useItemsQuery} = useAiObservabilityDatasetsApi();
18
+ const tabParam = Array.isArray(params.tab) ? params.tab[0] : params.tab;
19
+ const initialTab: DatasetItemTab = tabParam === "needsReview" ? "needsReview" : "all";
20
+ const {useDetailQuery, useItemsQuery} = useAiObservabilityDatasetsApi();
19
21
  const {useStatusQuery} = useAiObservabilityPromptsApi();
20
22
  const statusQuery = useStatusQuery();
21
23
  const status = unwrapObservabilityStatus(statusQuery.data);
@@ -40,7 +42,6 @@ export const AiDatasetDetailScreenWidget: React.FC<AdminScreenWidgetProps> = (pr
40
42
  isLoading: isItemsLoading,
41
43
  refetch: refetchItems,
42
44
  } = useItemsQuery(id ?? "", {skip: !id});
43
- const [createItem] = useCreateItemMutation();
44
45
  const dataset = useMemo(() => unwrapDatasetRecord(data), [data]);
45
46
  const items = useMemo(() => unwrapDatasetItems(itemsRaw), [itemsRaw]);
46
47
  const prefix = (routeBase ?? "").replace(/\/$/, "");
@@ -50,51 +51,18 @@ export const AiDatasetDetailScreenWidget: React.FC<AdminScreenWidgetProps> = (pr
50
51
  router.push(`${prefix}/ai-experiment-new?datasetId=${encodeURIComponent(id ?? "")}`);
51
52
  }, [id, prefix]);
52
53
 
53
- const handleOpenTrace = useCallback(
54
- (traceId: string): void => {
55
- router.push(`${prefix}/ai-trace-detail?id=${encodeURIComponent(traceId)}`);
54
+ const handleOpenItem = useCallback(
55
+ (itemId: string): void => {
56
+ router.push(
57
+ `${prefix}/ai-dataset-item?datasetId=${encodeURIComponent(id ?? "")}&itemId=${encodeURIComponent(itemId)}`
58
+ );
56
59
  },
57
- [prefix]
60
+ [id, prefix]
58
61
  );
59
62
 
60
- const handleAddItem = useCallback(
61
- async ({
62
- expectedOutput,
63
- input,
64
- }: {
65
- expectedOutput: string;
66
- input: string;
67
- }): Promise<string | undefined> => {
68
- if (!id) {
69
- return "Missing dataset id.";
70
- }
71
- try {
72
- await createItem({
73
- body: {
74
- expectedOutput: JSON.parse(expectedOutput) as unknown,
75
- input: JSON.parse(input) as unknown,
76
- origin: "manual",
77
- proofread: true,
78
- },
79
- datasetId: id,
80
- }).unwrap();
81
- void refetchItems();
82
- return undefined;
83
- } catch (error) {
84
- if (error instanceof SyntaxError) {
85
- return "Input and expected output must be valid JSON.";
86
- }
87
- if (error && typeof error === "object" && "data" in error) {
88
- const title = (error as {data?: {title?: string}}).data?.title;
89
- if (title) {
90
- return title;
91
- }
92
- }
93
- return "Could not add dataset item.";
94
- }
95
- },
96
- [createItem, id, refetchItems]
97
- );
63
+ const handleCreateItem = useCallback((): void => {
64
+ router.push(`${prefix}/ai-dataset-item?datasetId=${encodeURIComponent(id ?? "")}`);
65
+ }, [id, prefix]);
98
66
 
99
67
  if (!id) {
100
68
  return (
@@ -133,11 +101,12 @@ export const AiDatasetDetailScreenWidget: React.FC<AdminScreenWidgetProps> = (pr
133
101
  canAddItem={canAddItem}
134
102
  canRunExperiment={canRunExperiment}
135
103
  dataset={dataset}
104
+ initialTab={initialTab}
136
105
  isItemsLoading={isItemsLoading}
137
106
  items={items}
138
- onAddItem={handleAddItem}
107
+ onCreateItem={handleCreateItem}
139
108
  onOpenExperiment={handleOpenExperiment}
140
- onOpenTrace={handleOpenTrace}
109
+ onOpenItem={handleOpenItem}
141
110
  onRetryItems={refetchItems}
142
111
  routeBase={prefix}
143
112
  />
@@ -1,5 +1,4 @@
1
1
  import {describe, expect, it, mock} from "bun:test";
2
- import {Modal} from "@terreno/ui";
3
2
  import {act, fireEvent, within} from "@testing-library/react-native";
4
3
  import {assert} from "chai";
5
4
  import React from "react";
@@ -43,10 +42,8 @@ const items: DatasetItemRecord[] = [
43
42
  },
44
43
  ];
45
44
 
46
- type OnAddItem = React.ComponentProps<typeof AiDatasetDetailView>["onAddItem"];
47
-
48
45
  describe("AiDatasetDetailView items table", () => {
49
- it("opens complete item details from a row while keeping wide content readable", async () => {
46
+ it("opens the expected-output page from a row while keeping wide content readable", async () => {
50
47
  const baseItem = items[0];
51
48
  assert.exists(baseItem);
52
49
  const fullQuestion =
@@ -64,13 +61,14 @@ describe("AiDatasetDetailView items table", () => {
64
61
  tags: ["gold", "universal"],
65
62
  },
66
63
  ];
67
- const {getByTestId, queryByTestId, UNSAFE_root} = renderWithTheme(
64
+ const onOpenItem = mock<(itemId: string) => void>(() => undefined);
65
+ const {getByTestId} = renderWithTheme(
68
66
  <AiDatasetDetailView
69
67
  dataset={dataset}
70
68
  items={longItems}
71
- onAddItem={async () => undefined}
69
+ onCreateItem={() => undefined}
72
70
  onOpenExperiment={() => undefined}
73
- onOpenTrace={() => undefined}
71
+ onOpenItem={onOpenItem}
74
72
  routeBase="/admin"
75
73
  />
76
74
  );
@@ -84,26 +82,7 @@ describe("AiDatasetDetailView items table", () => {
84
82
  fireEvent.press(getByTestId("ai-dataset-items-table-row-item-1-clickable"));
85
83
  await Promise.resolve();
86
84
  });
87
- const modal = within(getByTestId("ai-dataset-item-modal"));
88
- expect(modal.getByText(/without duplicating screens/)).toBeTruthy();
89
- expect(modal.getByText(/One React Native codebase ships/)).toBeTruthy();
90
- expect(modal.getByText(/gold import/)).toBeTruthy();
91
- expect(modal.getByText("Outcome: tp")).toBeTruthy();
92
- expect(modal.getByText("Annotator user: user-1")).toBeTruthy();
93
- expect(modal.getByText("Review item: review-1")).toBeTruthy();
94
-
95
- const detailsModal = UNSAFE_root.findAllByType(Modal).find(
96
- (entry) => entry.props.title === "Dataset item details"
97
- );
98
- assert.exists(detailsModal);
99
- if (!detailsModal) {
100
- return;
101
- }
102
- await act(async () => {
103
- fireEvent(detailsModal, "onDismiss");
104
- await Promise.resolve();
105
- });
106
- assert.notExists(queryByTestId("ai-dataset-item-modal"));
85
+ assert.deepEqual(onOpenItem.mock.calls, [["item-1"]]);
107
86
  });
108
87
  });
109
88
 
@@ -113,8 +92,9 @@ describe("AiDatasetDetailView tabs", () => {
113
92
  <AiDatasetDetailView
114
93
  dataset={dataset}
115
94
  items={items.slice(1)}
116
- onAddItem={async () => undefined}
95
+ onCreateItem={() => undefined}
117
96
  onOpenExperiment={() => undefined}
97
+ onOpenItem={() => undefined}
118
98
  routeBase="/admin"
119
99
  />
120
100
  );
@@ -128,15 +108,15 @@ describe("AiDatasetDetailView tabs", () => {
128
108
 
129
109
  it("shows needs review count badge and wires actions", async () => {
130
110
  const onOpenExperiment = mock(() => undefined);
131
- const onOpenTrace = mock(() => undefined);
132
- const onAddItem = mock<OnAddItem>(async () => undefined);
111
+ const onOpenItem = mock<(itemId: string) => void>(() => undefined);
112
+ const onCreateItem = mock(() => undefined);
133
113
  const view = renderWithTheme(
134
114
  <AiDatasetDetailView
135
115
  dataset={dataset}
136
116
  items={items}
137
- onAddItem={onAddItem}
117
+ onCreateItem={onCreateItem}
138
118
  onOpenExperiment={onOpenExperiment}
139
- onOpenTrace={onOpenTrace}
119
+ onOpenItem={onOpenItem}
140
120
  routeBase="/admin"
141
121
  />
142
122
  );
@@ -152,16 +132,7 @@ describe("AiDatasetDetailView tabs", () => {
152
132
  await Promise.resolve();
153
133
  });
154
134
  assert.equal(onOpenExperiment.mock.calls.length, 1);
155
- fireEvent.changeText(view.getByText("Input (JSON)"), '{"q":"new"}');
156
- fireEvent.changeText(view.getByText("Expected output (JSON)"), '{"a":"ok"}');
157
- const addButtons = view.getAllByText("Add item");
158
- const submitAddButton = addButtons.at(-1);
159
- assert.exists(submitAddButton);
160
- await act(async () => {
161
- fireEvent.press(submitAddButton);
162
- await Promise.resolve();
163
- });
164
- assert.isAtLeast(onAddItem.mock.calls.length, 1);
135
+ assert.equal(onCreateItem.mock.calls.length, 1);
165
136
  await act(async () => {
166
137
  fireEvent.press(view.getByText("Auto"));
167
138
  await Promise.resolve();
@@ -170,50 +141,42 @@ describe("AiDatasetDetailView tabs", () => {
170
141
  fireEvent.press(view.getByTestId("ai-dataset-items-table-row-item-2-clickable"));
171
142
  await Promise.resolve();
172
143
  });
173
- await act(async () => {
174
- fireEvent.press(view.getByText("Open source trace"));
175
- await Promise.resolve();
176
- });
177
- assert.equal(onOpenTrace.mock.calls.length, 1);
178
- assert.notExists(view.queryByTestId("ai-dataset-item-modal"));
144
+ assert.deepEqual(onOpenItem.mock.calls, [["item-2"]]);
179
145
  });
146
+ });
180
147
 
181
- it("surfaces add-item errors and dismisses the modal on success", async () => {
182
- const onAddItem = mock<OnAddItem>(async () => "Invalid JSON in input.");
148
+ describe("AiDatasetDetailView review guidance", () => {
149
+ it("explains golden labels on every tab and the review steps on Needs review", () => {
183
150
  const view = renderWithTheme(
184
151
  <AiDatasetDetailView
185
152
  dataset={dataset}
153
+ initialTab="needsReview"
186
154
  items={items}
187
- onAddItem={onAddItem}
188
- onOpenExperiment={() => undefined}
155
+ onCreateItem={mock(() => {})}
156
+ onOpenExperiment={mock(() => {})}
157
+ onOpenItem={mock(() => {})}
189
158
  routeBase="/admin"
190
159
  />
191
160
  );
192
- await act(async () => {
193
- fireEvent.press(view.getByTestId("ai-dataset-add-item"));
194
- await Promise.resolve();
195
- });
196
- const addButtons = view.getAllByText("Add item");
197
- const submitAddButton = addButtons.at(-1);
198
- assert.exists(submitAddButton);
199
- await act(async () => {
200
- fireEvent.press(submitAddButton);
201
- await Promise.resolve();
202
- });
203
- expect(view.getByTestId("ai-dataset-add-item-error")).toBeTruthy();
161
+ expect(view.getByTestId("ai-dataset-golden-guidance")).toBeTruthy();
162
+ expect(view.getByText(/that input\. Experiments score the feature/)).toBeTruthy();
163
+ expect(view.getByTestId("ai-dataset-review-guidance")).toBeTruthy();
164
+ expect(view.getByText(/Save and next to move down this list/)).toBeTruthy();
165
+ expect(view.getByTestId("ai-dataset-items-table")).toBeTruthy();
166
+ });
204
167
 
205
- onAddItem.mockImplementation(async () => undefined);
206
- await act(async () => {
207
- fireEvent.press(view.getByTestId("ai-dataset-add-item"));
208
- await Promise.resolve();
209
- });
210
- const retryButtons = view.getAllByText("Add item");
211
- const retryAddButton = retryButtons.at(-1);
212
- assert.exists(retryAddButton);
213
- await act(async () => {
214
- fireEvent.press(retryAddButton);
215
- await Promise.resolve();
216
- });
217
- expect(view.queryByTestId("ai-dataset-add-item-error")).toBeNull();
168
+ it("opens on the Needs review tab when asked and says so when nothing is left", () => {
169
+ const view = renderWithTheme(
170
+ <AiDatasetDetailView
171
+ dataset={{...dataset, counts: {...dataset.counts, needsReview: 0}}}
172
+ initialTab="needsReview"
173
+ items={[items[0] as DatasetItemRecord]}
174
+ onCreateItem={mock(() => {})}
175
+ onOpenExperiment={mock(() => {})}
176
+ onOpenItem={mock(() => {})}
177
+ routeBase="/admin"
178
+ />
179
+ );
180
+ expect(view.getByText("Nothing needs review. Every item is proofread.")).toBeTruthy();
218
181
  });
219
182
  });