@terpjs/eslint-boundaries 0.11.0 → 0.13.0

package/src/layouts.test.js

@@ -35,14 +35,14 @@ describe("terp/layout-contract", () => {
   it("is inert without an opted-in contract (backwards compatible)", async () => {
     const code =
       'import { HubPage } from "@terpjs/react-core";\n' +
-      "export const W = () => <HubPage title='x'><div /></HubPage>;";
+      "export const W = ({title}) => <HubPage title={title}><div /></HubPage>;";
     expect((await lint(code)).map((m) => m.ruleId)).toEqual([]);
   });
 
   it("refuses a non-conforming child in a HubPage body, with the directive message", async () => {
     const code =
       'import { HubPage, Stack } from "@terpjs/react-core";\n' +
-      "export const W = () => <HubPage title='x'><Stack /></HubPage>;";
+      "export const W = ({title}) => <HubPage title={title}><Stack /></HubPage>;";
     const messages = await lint(code, configWithContract("standard"));
     expect(messages.map((m) => m.ruleId)).toContain("terp/layout-contract");
     expect(messages[0].message).toBe(slotViolationMessage("standard", "HubPage", "<Stack>"));
@@ -51,9 +51,9 @@ describe("terp/layout-contract", () => {
   it("passes a conforming hub / overview / detail composition", async () => {
     const code = [
       'import { Card, DataView, DetailList, HubCard, HubPage, OverviewPage, DetailPage, Stack } from "@terpjs/react-core";',
-      "export const H = () => <HubPage title='x'><HubCard to='/a' title='a' /></HubPage>;",
-      "export const O = () => <OverviewPage title='x'><Card title='open'><DataView /></Card></OverviewPage>;",
-      "export const D = () => <DetailPage title='x' parents={[]}><Card title='a section'>body</Card><Stack><DetailList items={[]} /></Stack></DetailPage>;",
+      "export const H = ({title}) => <HubPage title={title}><HubCard to='/a' title={title} /></HubPage>;",
+      "export const O = ({title}) => <OverviewPage title={title}><Card title={title}><DataView /></Card></OverviewPage>;",
+      "export const D = ({title, body}) => <DetailPage title={title} parents={[]}><Card title={title}>{body}</Card><Stack><DetailList items={[]} /></Stack></DetailPage>;",
     ].join("\n");
     expect((await lint(code, configWithContract("standard"))).map((m) => m.ruleId)).toEqual([]);
   });
@@ -61,19 +61,19 @@ describe("terp/layout-contract", () => {
   it("refuses raw text and recurses through fragments; dynamic children are left to the runtime half", async () => {
     const text =
       'import { OverviewPage } from "@terpjs/react-core";\n' +
-      "export const W = () => <OverviewPage title='x'>loose text</OverviewPage>;";
+      "export const W = ({title}) => <OverviewPage title={title}>loose text</OverviewPage>;";
     expect((await lint(text, configWithContract("standard"))).map((m) => m.ruleId)).toContain(
       "terp/layout-contract",
     );
     const fragment =
       'import { HubPage } from "@terpjs/react-core";\n' +
-      "export const W = () => <HubPage title='x'><><span /></></HubPage>;";
+      "export const W = ({title}) => <HubPage title={title}><><span /></></HubPage>;";
     expect((await lint(fragment, configWithContract("standard"))).map((m) => m.ruleId)).toContain(
       "terp/layout-contract",
     );
     const dynamic =
       'import { HubPage } from "@terpjs/react-core";\n' +
-      "export const W = ({items}) => <HubPage title='x'>{items}</HubPage>;";
+      "export const W = ({title, items}) => <HubPage title={title}>{items}</HubPage>;";
     expect((await lint(dynamic, configWithContract("standard"))).map((m) => m.ruleId)).toEqual([]);
   });
 
@@ -86,7 +86,7 @@ describe("terp/layout-contract", () => {
   it("honours a justified escape-hatch marker (and only a justified one)", async () => {
     const code =
       'import { HubPage } from "@terpjs/react-core";\n' +
-      "export const W = () => <HubPage title='x'>\n" +
+      "export const W = ({title}) => <HubPage title={title}>\n" +
       "  {/* terp-allow-layout-contract: legacy widget pending HubCard port */}\n" +
       "  <div />\n" +
       "</HubPage>;";

package/src/scorecard.js

@@ -54,13 +54,25 @@ export async function buildScorecard() {
     .filter((name) => name.endsWith(".json"))
     .map((name) => JSON.parse(fs.readFileSync(path.join(catalogDir, name), "utf8")))
     .filter((entry) => entry.corpus);
+  const consumedRuleIds = new Set(
+    fs
+      .readdirSync(catalogDir)
+      .filter((name) => name.endsWith(".json"))
+      .map((name) => JSON.parse(fs.readFileSync(path.join(catalogDir, name), "utf8")).id),
+  );
   for (const entry of entries) {
     const ruleDir = path.join(corpusDir, entry.id.split("/")[1]);
     let pass = true;
     for (const caseName of fs.readdirSync(ruleDir).sort()) {
       const caseDir = path.join(ruleDir, caseName);
       if (!fs.statSync(caseDir).isDirectory()) continue;
-      const fired = (await lintCaseFindings(caseDir)).map((finding) => finding.rule);
+      // A framework implementation lands before its Standard candidate can certify.
+      // While running against the last published pin, ignore those forward rule ids;
+      // a substituted candidate includes them in consumedRuleIds and exercises them.
+      // Unattributed findings remain failures rather than disappearing in the filter.
+      const fired = (await lintCaseFindings(caseDir))
+        .filter((finding) => finding.rule === null || consumedRuleIds.has(finding.rule))
+        .map((finding) => finding.rule);
       if (caseName.startsWith("violation-") && !fired.includes(entry.id)) pass = false;
       if (caseName.startsWith("compliant-") && fired.length > 0) pass = false;
     }

package/src/spec.js

@@ -3,8 +3,9 @@
  * ./index.js realises them for the React stack; a future stack (e.g. Svelte) can realise the same
  * spec with its own adapter. The *rules* are shared; only the *enforcement adapter* is per-stack.
  *
- * They apply to the **app-authored surface** (`src/modules/**`) — the code agents and users write —
- * not the framework packages, which legitimately define the very primitives the rules point back to.
+ * Structural/security boundaries apply to `src/modules/**`; localization applies to all
+ * app-authored `src/**`. Framework packages legitimately define the primitives these rules point
+ * back to and are outside an app's boundary config.
  */
 /**
  * The Terp Standard version this adapter is certified against — the `spec_version` a
@@ -15,9 +16,11 @@
  * NOT by this package's own suite, which certification runs against candidate spec releases
  * whose version is allowed to be newer).
  */
-export const SPEC_VERSION = "0.27.0";
+export const SPEC_VERSION = "0.29.1";
 
 export const BOUNDARY_SPEC = {
+  /** Every app-authored TypeScript source file whose user-facing copy must be cataloged. */
+  appFiles: ["**/src/**/*.{ts,tsx}"],
   /** App module files the boundary + frontend security defaults apply to. */
   moduleFiles: ["**/modules/**/*.{ts,tsx}"],
   /**

package/src/surface.test.js

@@ -160,18 +160,23 @@ const CATALOG_ENTRIES = fs
 
 /** A minimal violating line per frontend catalog rule (the marker goes on the line above). */
 const VIOLATION_SNIPPETS = {
-  "frontend/token-styled-elements": "export const W = () => <button>x</button>;",
+  "frontend/locale-catalogs-complete":
+    'export const title = { id: "widgets.title", message: "Widgets" };',
+  "frontend/token-styled-elements": "export const W = ({label}) => <button>{label}</button>;",
   "frontend/no-inline-styling": 'export const W = () => <div className="x" />;',
-  "frontend/router-links": 'export const W = () => <a href="/notes">go</a>;',
+  "frontend/router-links": 'export const W = ({label}) => <a href="/notes">{label}</a>;',
   "frontend/generated-client-only": 'export const ping = () => fetch("/healthz");',
   "frontend/no-deep-imports": 'import { x } from "@terpjs/react-core/src/internal";',
   "frontend/no-style-imports": 'import "./widget.css";',
   "frontend/no-cross-module-imports": 'import { x } from "../other/thing";',
   "frontend/no-dom-html-injection": "export const W = (el, html) => { el.innerHTML = html; };",
   "frontend/no-eval": "export const run = (code) => eval(code);",
-  "frontend/no-unsafe-href": 'export const W = () => <a href="javascript:alert(1)">x</a>;',
+  "frontend/no-unsafe-href":
+    'export const W = ({label}) => <a href="javascript:alert(1)">{label}</a>;',
   "frontend/no-unsafe-target-blank":
-    'export const W = () => <a href="https://example.com" target="_blank">x</a>;',
+    'export const W = ({label}) => <a href="https://example.com" target="_blank">{label}</a>;',
+  "frontend/no-untranslated-ui":
+    'export const W = () => <Text>Untranslated copy</Text>;',
 };
 
 describe(