@tenyokjs/devdevian-cli 0.3.0-alpha.1 → 0.4.0-alpha.1

package/README.md

@@ -18,7 +18,7 @@ The default `devdevian` command and `devdevian tui` open an alternate terminal s
 - **/** focuses search and commands: `/feed`, `/inbox`, `/search query`, `/open 142`, `/ask`, `/review`, `/drafts`, `/communities`, `/devices`, `/help`, `/logout`, `/quit`.
 - **←/→** switch conversation tabs; **Space** reads the selected reply/remark in full. **[ / ]** paginate; **Page Up/Down** scroll.
 - **N** creates a conversation (a community on the Communities screen); **A** asks a question; **R** replies inside a conversation; **Shift+R** refreshes.
-- **C** comments on snippet lines; **E/D** edit/delete your own feedback; **S** resolves/reopens a code remark as the publication author; **!** reports selected code feedback.
+- **C** comments on snippet lines; **E/D** edit/delete your own ordinary replies or code feedback; **S** resolves/reopens a code remark or accepts/removes a reply as the solution (question/review author only); **!** reports selected code feedback.
 - In forms, **Tab/Shift+Tab** change fields, arrows choose options or move the text cursor, **Enter** adds a line, **Ctrl+S** opens the preview. Publication requires a separate confirmation; Escape asks before discarding a draft. Drafts auto-save locally after a short pause and can be restored from **Local drafts** or `/drafts`.
 - **Ctrl+C** exits. With an unsent draft, confirm saving and leaving or press Ctrl+C again to force exit.
 
@@ -26,6 +26,22 @@ The default `devdevian` command and `devdevian tui` open an alternate terminal s
 
 Pages have a bounded 30-second in-memory cache. Refresh explicitly with Shift+R. Network errors stay inside the workspace; failed writes are never automatically retried. Existing web permissions and server validation apply to every operation.
 
+Ordinary reply deletion replaces your text with a placeholder and preserves nested replies. Its attachments become unavailable. Deleting an accepted answer reopens the question. D/d works on a selected reply or while reading it in full; confirmation is required.
+
+## Code and discussion, together
+
+Press **V** in a review to open the code workspace. Wide terminals show the snippet alongside its discussion; narrow terminals show one pane at a time. **W** switches focus. In the code pane, arrows move between lines (left/right scroll horizontally), **Space** anchors a range and **C** opens a prefilled comment form. Remarks may cover at most 50 lines. **Enter** selects a remark covering the current line, if it is on the current page. Markers describe the current page only; **F** cycles all/open/resolved remarks and **[ / ]** page through them.
+
+Selecting a remark highlights its range. A remark on an earlier snippet shows its **saved quote**, not unrelated current lines. Switch to current code with **W** before adding a new remark. Git patch line numbers still include patch headers.
+
+**X** or **?** opens a keyboard action menu for the selected item. It shows edits/deletion for your own content, resolve/reopen for review authors and accepted solutions for question/review authors. Deletion and accepting/removing a solution require confirmation. Feedback reports go to the existing moderation queue. The server checks permissions independently.
+
+## Inbox and live updates
+
+The header shows unread notifications. Live reads run every **45 seconds**, slowing to **3 minutes** after two minutes without input; failures back off up to five minutes. An expired/revoked session pauses updates. Pause/resume from **X → Pause/Resume live updates**, or start with `devdevian tui --no-live`.
+
+Inbox and open discussion views refresh without moving a selected item that still exists. While you type, use a picker, read full text or confirm an action, background reads update only the unread count; they do not replace the view or draft. Polling never marks notifications as read. **X → Mark received notifications as read** affects only notifications through the last loaded boundary; newer arrivals remain unread. Shift+R refreshes manually.
+
 ## Project files and Git changes
 
 Start inside your project (`cd PROJECT1 && devdevian tui`) or use `devdevian tui --project /path/to/PROJECT1`. `devdevian open --project /path/to/PROJECT1` carries the same project into a new terminal window. The project root stays fixed for the session.

package/bin/devdevian.mjs

@@ -39,6 +39,7 @@ const options = {
   json: { type: "boolean" },
   editor: { type: "boolean" },
   "no-open": { type: "boolean" },
+  "no-live": { type: "boolean" },
   help: { type: "boolean", short: "h" },
   version: { type: "boolean", short: "v" },
 };
@@ -95,6 +96,7 @@ const help = `Devdevian CLI ${version} · alpha
   devdevian review reopen POST_ID REVIEW_ID
   devdevian communities [--page 2]
 
+  --no-live          Disable background reads in the live workspace
   --project PATH     Root directory for the live file/diff picker (default: current directory)
   --community ID     Publish to an approved private community
   --editor           Write text in $VISUAL / $EDITOR
@@ -477,6 +479,7 @@ try {
     for (const key of ["host", "name", "project"])
       if (values[key]) args.push("--" + key, values[key]);
     if (values["no-open"]) args.push("--no-open");
+    if (values["no-live"]) args.push("--no-live");
     await (
       await import("../lib/window.mjs")
     ).openWindow({ entry: fileURLToPath(import.meta.url), args });

package/lib/context-actions.mjs

@@ -0,0 +1,53 @@
+// Visibility is a convenience; the API remains the permission authority.
+export function contextActions({ route, data, selected, user, live }) {
+  const actions = [],
+    post = data?.post;
+  const add = (id, label) => actions.push({ id, label });
+  const feedback =
+    route.view === "feedback" ||
+    (route.view === "post" && route.tab === "feedback");
+  const reply =
+    route.view === "thread" ||
+    (route.view === "post" && route.tab === "replies");
+  if (selected) add("read", "Read selected item");
+  if (post && !post.archived_at && !post.locked_at) {
+    add("reply", "Write a reply");
+    if (post.code) add("comment", "Comment on selected code lines");
+  }
+  if (
+    (reply || feedback) &&
+    selected &&
+    user &&
+    selected.user_id === user.id &&
+    !selected.deleted_at
+  ) {
+    add("edit", "Edit your reply / remark");
+    add("delete", "Delete your reply / remark…");
+  }
+  if (post && user && post.user_id === user.id) {
+    const note =
+      route.view === "feedback" ? data.note : feedback ? selected : null;
+    if (note && !note.deleted_at)
+      add("resolve", note.resolved ? "Reopen remark" : "Resolve remark");
+    if (
+      reply &&
+      selected &&
+      !selected.deleted_at &&
+      ["question", "review"].includes(post.kind)
+    )
+      add(
+        "solution",
+        post.accepted_reply_id === selected.id
+          ? "Remove accepted solution…"
+          : "Accept as solution…",
+      );
+  }
+  if (feedback && selected && !selected.deleted_at)
+    add("report", "Report selected feedback…");
+  if (post) add("browser", "Open conversation in browser");
+  if (route.view === "inbox" && data?.unread_count > 0)
+    add("read-all", "Mark received notifications as read");
+  add("sync", "Refresh this view");
+  add("live", live ? "Pause live updates" : "Resume live updates");
+  return actions;
+}

package/lib/live.mjs

@@ -0,0 +1,52 @@
+// Serial, cancellable polling: network failures never retry a mutation.
+export function liveLoop(
+  work,
+  {
+    schedule = setTimeout,
+    cancel = clearTimeout,
+    now = Date.now,
+    activity = () => now(),
+    active = 45000,
+    idle = 180000,
+    onError = () => {},
+  } = {},
+) {
+  const controller = new AbortController();
+  let timer,
+    failures = 0,
+    stopped = false;
+  async function run() {
+    try {
+      await work(controller.signal);
+      failures = 0;
+    } catch (error) {
+      if (stopped) return;
+      failures++;
+      onError(error);
+      if (error.status === 401 || error.status === 403) {
+        stop();
+        return;
+      }
+    }
+    if (stopped) return;
+    const base = now() - activity() > 120000 ? idle : active;
+    timer = schedule(run, Math.min(300000, base * 2 ** Math.min(failures, 3)));
+  }
+  function stop() {
+    stopped = true;
+    cancel(timer);
+    controller.abort();
+  }
+  timer = schedule(run, 0);
+  return stop;
+}
+export function anchoredIndex(previous, next, index) {
+  const row = previous?.[index];
+  if (row) {
+    const found = next.findIndex(
+      (item) => item.id === row.id && item.entryType === row.entryType,
+    );
+    if (found >= 0) return found;
+  }
+  return Math.max(0, Math.min(index, next.length - 1));
+}

package/lib/picker.mjs

@@ -9,17 +9,9 @@ import {
   readDiff,
   selectLines,
 } from "./workspace.mjs";
+import { colors } from "./theme.mjs";
 const h = React.createElement,
-  c = {
-    text: "#e0e7ff",
-    muted: "#8190af",
-    blue: "#79b8ff",
-    purple: "#b29aff",
-    green: "#70d6b0",
-    red: "#ff9baf",
-    bg: "#12192b",
-    selected: "#29345b",
-  };
+  c = { ...colors, bg: colors.panel };
 export function WorkspacePicker({
   root,
   width,

package/lib/review-workspace.mjs

@@ -0,0 +1,157 @@
+import React from "react";
+import { Box, Text } from "ink";
+import { clip, graphemes } from "./tui-model.mjs";
+import { colors as c } from "./theme.mjs";
+const h = React.createElement;
+export function codeRange(line, anchor = null) {
+  return {
+    start: Math.min(line, anchor ?? line) + 1,
+    end: Math.max(line, anchor ?? line) + 1,
+  };
+}
+export function reviewExcerpt(post, note) {
+  // Never attach an old remark to unrelated lines in the new snippet.
+  if (note?.outdated)
+    return {
+      text: note.quote || "Earlier snippet unavailable",
+      first: note.start_line || 1,
+      old: true,
+    };
+  return { text: post?.code || "", first: 1, old: false };
+}
+export function ReviewWorkspace({
+  post,
+  note,
+  items,
+  index,
+  width,
+  height,
+  focus,
+  line,
+  anchor,
+  horizontal = 0,
+  rows,
+}) {
+  const split = width >= 78,
+    codeWidth = split ? Math.floor(width * 0.55) : width;
+  const selectedNote = note || items[index];
+  const excerpt = reviewExcerpt(post, focus === "code" ? null : selectedNote),
+    lines = excerpt.text.split("\n");
+  const range = codeRange(line, anchor);
+  const target = excerpt.old
+    ? 0
+    : focus === "code"
+      ? line
+      : Math.max(0, (selectedNote?.start_line || 1) - 1);
+  const header = height >= 4 ? 2 : 1,
+    count = Math.max(1, height - header),
+    top = Math.max(
+      0,
+      Math.min(lines.length - count, target - Math.floor(count / 3)),
+    );
+  const code = h(
+    Box,
+    { width: codeWidth, height, flexDirection: "column", overflow: "hidden" },
+    h(
+      Text,
+      { color: focus === "code" ? c.blue : c.purple, bold: true },
+      clip(
+        excerpt.old
+          ? "Earlier snippet · saved quote"
+          : "Code · W focus · C comment",
+        codeWidth,
+      ),
+    ),
+    header === 2
+      ? h(
+          Text,
+          { color: c.muted },
+          clip(
+            focus === "code"
+              ? `Lines ${range.start}–${range.end} · Space select`
+              : "Markers: remarks on this page",
+            codeWidth,
+          ),
+        )
+      : null,
+    ...Array.from({ length: count }, (_, i) => {
+      const n = top + i,
+        number = excerpt.first + n;
+      if (n >= lines.length) return h(Text, { key: i }, " ");
+      const marked =
+        !excerpt.old &&
+        items.some(
+          (item) =>
+            !item.outdated &&
+            !item.deleted_at &&
+            number >= item.start_line &&
+            number <= item.end_line,
+        );
+      const highlighted =
+        excerpt.old ||
+        (focus === "code"
+          ? number >= range.start && number <= range.end
+          : selectedNote &&
+            !selectedNote.outdated &&
+            number >= selectedNote.start_line &&
+            number <= selectedNote.end_line);
+      const text = lines[n];
+      return h(
+        Text,
+        {
+          key: i,
+          backgroundColor: highlighted ? c.selected : undefined,
+          color: text.startsWith("+")
+            ? c.green
+            : text.startsWith("-")
+              ? c.red
+              : c.text,
+        },
+        clip(
+          `${marked ? "●" : " "}${String(number).padStart(4)}  ${graphemes(text.replaceAll("\t", "  ")).slice(horizontal).join("")}`,
+          codeWidth,
+        ),
+      );
+    }),
+  );
+  const notesWidth = split ? width - codeWidth - 2 : width;
+  const visible = Math.max(1, Math.floor((height - 2) / 4)),
+    first = Math.max(0, index - visible + 1);
+  const notes = h(
+    Box,
+    { width: notesWidth, height, flexDirection: "column", overflow: "hidden" },
+    h(
+      Text,
+      { color: focus === "notes" ? c.blue : c.purple, bold: true },
+      "Discussion · W focus",
+    ),
+    header === 2
+      ? h(
+          Text,
+          { color: c.muted },
+          clip("Enter thread · Space read · X actions", notesWidth),
+        )
+      : null,
+    ...(items.length
+      ? rows(notesWidth)
+          .slice(first * 4, first * 4 + height - header)
+          .map((row, i) =>
+            h(
+              Text,
+              {
+                key: i,
+                color: row.color || c.text,
+                bold: row.bold,
+                backgroundColor: row.selected ? c.selected : undefined,
+              },
+              clip(typeof row === "string" ? row : row.text, notesWidth),
+            ),
+          )
+      : [h(Text, { key: "empty", color: c.muted }, "No remarks. C adds one.")]),
+  );
+  return h(
+    Box,
+    { height, width, gap: split ? 2 : 0, overflow: "hidden" },
+    ...(split ? [code, notes] : [focus === "code" ? code : notes]),
+  );
+}

package/lib/theme.mjs

@@ -0,0 +1,13 @@
+// One palette for the workspace, file picker and review panes.
+export const colors = Object.freeze({
+  bg: "#0b1020",
+  panel: "#11182b",
+  line: "#303d60",
+  muted: "#8e9ab8",
+  text: "#e5eaff",
+  blue: "#86baff",
+  purple: "#b5a0ff",
+  green: "#7bdcbd",
+  red: "#ffa0b4",
+  selected: "#29365b",
+});

package/lib/tui-data.mjs

@@ -1,3 +1,14 @@
+import { createHash } from "node:crypto";
+export function assertSnippet(code, hash) {
+  if (
+    createHash("sha256")
+      .update(code || "")
+      .digest("hex") !== hash
+  )
+    throw Error(
+      "Code changed while loading. Press Shift+R to refresh before reviewing.",
+    );
+}
 export const navigation = [
   ["inbox", "Inbox", "Replies & mentions"],
   ["feed", "Public feed", "Developer commons"],
@@ -77,15 +88,23 @@ export async function loadPage(api, route, signal) {
     const post = await get("/posts/" + route.id + "?reply_page=" + page);
     let items = post.replies,
       pagination = post.reply_pagination;
+    let snippet_hash;
     if (route.tab === "feedback") {
       const feedback = await get(
-        "/posts/" + route.id + "/code-reviews?page=" + page,
+        "/posts/" +
+          route.id +
+          "/code-reviews?page=" +
+          page +
+          (route.status ? "&status=" + route.status : ""),
       );
+      assertSnippet(post.code, feedback.snippet_hash);
+      snippet_hash = feedback.snippet_hash;
       items = feedback.items;
       pagination = feedback.pagination;
     }
     return {
       post,
+      snippet_hash,
       items,
       pagination,
       title: post.title,
@@ -98,15 +117,29 @@ export async function loadPage(api, route, signal) {
     };
   }
   if (route.view === "thread") {
-    const post = await get("/posts/" + route.postId),
-      replies = await get(
-        `/posts/${route.postId}/replies?parent_id=${route.parent.id}&page=${page}`,
+    const post = await get(
+      "/posts/" + route.postId + "?reply_id=" + route.parent.id,
+    );
+    const target = post.reply_path?.at(-1);
+    let parent = post.replies?.find((r) => r.id === route.parent.id);
+    if (!parent && target) {
+      const siblings = await get(
+        `/posts/${route.postId}/replies?parent_id=${target.parent_id || ""}&page=${target.page}`,
       );
+      parent = siblings.items.find((r) => r.id === route.parent.id);
+    }
+    const replies = await get(
+      `/posts/${route.postId}/replies?parent_id=${route.parent.id}&page=${page}`,
+    );
     return {
       post,
       ...replies,
+      items: [
+        ...(parent ? [{ ...parent, entryType: "parent" }] : []),
+        ...replies.items,
+      ],
       title: "Reply thread",
-      subtitle: "Replying to " + route.parent.name,
+      subtitle: "Replying to " + (parent?.name || route.parent.name),
     };
   }
   if (route.view === "feedback") {
@@ -114,6 +147,7 @@ export async function loadPage(api, route, signal) {
       get("/posts/" + route.postId),
       get(`/posts/${route.postId}/code-reviews?target_id=${route.id}`),
     ]);
+    assertSnippet(post.code, notes.snippet_hash);
     const note = notes.items.find((item) => item.id === Number(route.id));
     if (!note) throw Error("This feedback is no longer available.");
     const replies = await get(
@@ -122,6 +156,7 @@ export async function loadPage(api, route, signal) {
     return {
       post,
       note,
+      snippet_hash: notes.snippet_hash,
       items: [
         { ...note, entryType: "note" },
         ...replies.items.map((item) => ({
@@ -149,6 +184,11 @@ export function contentLines(route, data) {
       "Page Up / Down   Scroll a conversation or list",
       "N / A            New conversation / ask a question",
       "R                Reply in a conversation; refresh a list",
+      "V / W            Open review workspace / switch code and discussion",
+      "Space / C        Select a line range / comment on selected code",
+      "F                Filter remarks: all, open, resolved",
+      "X / ?            Context actions (edit, delete, solution, live updates)",
+      "Live updates     45s active / 3min idle; pause in X actions or --no-live",
       "C                Add feedback on code lines",
       "S                Resolve / reopen selected code feedback",
       "E / D            Edit / delete your own feedback or reply",

package/lib/tui.mjs

@@ -24,20 +24,18 @@ import {
   parseCommand,
   PageCache,
 } from "./tui-model.mjs";
-import { navigation, loadPage, contentLines } from "./tui-data.mjs";
+import {
+  navigation,
+  loadPage,
+  contentLines,
+  assertSnippet,
+} from "./tui-data.mjs";
+import { basename } from "node:path";
+import { colors } from "./theme.mjs";
+import { liveLoop, anchoredIndex } from "./live.mjs";
+import { contextActions } from "./context-actions.mjs";
+import { ReviewWorkspace, codeRange } from "./review-workspace.mjs";
 const h = React.createElement;
-const colors = {
-  bg: "#0d1222",
-  panel: "#12192b",
-  line: "#354266",
-  muted: "#8190af",
-  text: "#e0e7ff",
-  blue: "#79b8ff",
-  purple: "#b29aff",
-  green: "#70d6b0",
-  red: "#ff9baf",
-  selected: "#29345b",
-};
 const itemsOf = (value) => (Array.isArray(value) ? value : value?.items || []);
 const stamp = (value) => {
   const date = new Date(
@@ -333,8 +331,17 @@ function listRows(route, data, index, width) {
         item.name +
         (item.entryType === "note"
           ? " · original remark"
-          : " · reply #" + item.id);
-      meta = stamp(item.created) + (item.edited_at ? " · edited" : "");
+          : item.entryType === "parent"
+            ? " · parent reply"
+            : " · reply #" + item.id) +
+        (data.post?.accepted_reply_id === item.id
+          ? " · accepted solution"
+          : "");
+      meta =
+        stamp(item.created) +
+        ((item.edited_at || item.updated_at) && !item.deleted_at
+          ? " · edited"
+          : "");
       body = item.deleted_at ? "[deleted — discussion preserved]" : item.body;
     } else {
       meta = [
@@ -349,7 +356,7 @@ function listRows(route, data, index, width) {
     const selected = i === index;
     return [
       {
-        text: (selected ? "› " : "  ") + clip(title, width - 3),
+        text: (selected ? "▸ " : "  ") + clip(title, width - 3),
         color: selected ? colors.blue : colors.text,
         bold: selected,
         selected,
@@ -360,7 +367,7 @@ function listRows(route, data, index, width) {
         color: selected ? colors.text : colors.muted,
         selected,
       },
-      "",
+      { text: "  " + "─".repeat(Math.max(0, width - 4)), color: colors.line },
     ];
   });
 }
@@ -396,7 +403,18 @@ function App({ initialConfig, flags, root }) {
     [tick, setTick] = useState(0),
     [reading, setReading] = useState(null),
     [picker, setPicker] = useState(null),
-    [draftSaved, setDraftSaved] = useState(false);
+    [draftSaved, setDraftSaved] = useState(false),
+    [actionIndex, setActionIndex] = useState(null),
+    [reviewFocus, setReviewFocus] = useState("notes"),
+    [reviewLine, setReviewLine] = useState(0),
+    [reviewAnchor, setReviewAnchor] = useState(null),
+    [reviewHorizontal, setReviewHorizontal] = useState(0),
+    [live, setLive] = useState(!flags["no-live"]),
+    [unread, setUnread] = useState(0),
+    [liveStatus, setLiveStatus] = useState("");
+  const activity = useRef(Date.now()),
+    liveView = useRef(null),
+    notificationGeneration = useRef(0);
   const cache = useRef(new PageCache()),
     history = useRef([]),
     busy = useRef(false),
@@ -422,10 +440,92 @@ function App({ initialConfig, flags, root }) {
     sidebar = compact ? 0 : 25,
     bodyHeight = Math.max(1, height - 9),
     contentWidth = Math.max(1, width - sidebar - 6),
-    contentHeight = Math.max(1, bodyHeight - 5);
+    contentHeight = Math.max(1, bodyHeight - 6);
   const key = JSON.stringify(route),
     current = data?.key === key ? data : null;
   const selected = current?.items?.[index];
+  const reviewing =
+    !!current?.post?.code &&
+    (route.view === "feedback" ||
+      (route.view === "post" && route.tab === "feedback"));
+  const actions = contextActions({
+    route,
+    data: current,
+    selected,
+    user,
+    live,
+  });
+  liveView.current = {
+    route,
+    key,
+    current,
+    index,
+    blocked: !!(
+      form ||
+      preview ||
+      picker ||
+      dialog ||
+      reading ||
+      actionIndex !== null ||
+      loading ||
+      pending ||
+      focus === "prompt"
+    ),
+  };
+  useEffect(() => {
+    if (phase !== "ready" || !api || !live) return;
+    return liveLoop(
+      async (signal) => {
+        const generation = notificationGeneration.current;
+        const count = await api("/notifications?limit=1", { signal });
+        if (signal.aborted || generation !== notificationGeneration.current)
+          return;
+        setUnread(count.unread_count || 0);
+        const before = liveView.current;
+        if (
+          before.blocked ||
+          !["inbox", "post", "feedback", "thread"].includes(before.route.view)
+        ) {
+          setLiveStatus("");
+          return;
+        }
+        const next = await loadPage(api, before.route, signal);
+        const after = liveView.current;
+        if (
+          signal.aborted ||
+          after.key !== before.key ||
+          after.current !== before.current ||
+          after.blocked
+        )
+          return;
+        cache.current.set(before.key, next);
+        setIndex(
+          anchoredIndex(after.current?.items, next.items || [], after.index),
+        );
+        setData({ ...next, key: before.key });
+        setLiveStatus("");
+      },
+      {
+        activity: () => activity.current,
+        onError: (e) => {
+          setLiveStatus(
+            e.status === 401 || e.status === 403
+              ? "Live updates paused: sign in again. Local draft preserved."
+              : "Live updates delayed · automatic retry",
+          );
+          if (e.status === 401 || e.status === 403) setLive(false);
+        },
+      },
+    );
+  }, [api, phase, live]);
+  useEffect(() => {
+    if (current?.unread_count !== undefined) setUnread(current.unread_count);
+  }, [current]);
+  useEffect(() => {
+    setReviewLine(0);
+    setReviewAnchor(null);
+    setReviewHorizontal(0);
+  }, [current?.post?.id, current?.post?.code]);
   const resetAccount = () => {
     cache.current.clear();
     history.current = [];
@@ -453,6 +553,7 @@ function App({ initialConfig, flags, root }) {
     if (!replace) history.current.push({ route, index, scroll });
     if (history.current.length > 30) history.current.shift();
     setReading(null);
+    if (next.view === "feedback") setReviewFocus("notes");
     setRoute(next);
     setIndex(0);
     setScroll(0);
@@ -799,8 +900,25 @@ function App({ initialConfig, flags, root }) {
       setError("Replies are paused.");
       return;
     }
+    const note = route.view === "feedback" ? current.note : selected;
+    const range = reviewing
+      ? reviewFocus === "notes" && note?.start_line
+        ? { start: note.start_line, end: note.end_line }
+        : codeRange(reviewLine, reviewAnchor)
+      : { start: 1, end: 1 };
+    if (reviewing && reviewFocus === "notes" && note?.outdated) {
+      setError(
+        "This remark belongs to an earlier snippet. W switches to current code before adding a new remark.",
+      );
+      return;
+    }
+    if (range.end - range.start >= 50) {
+      setError("Select at most 50 code lines for a remark.");
+      return;
+    }
     await task(async () => {
       const notes = await api(`/posts/${p.id}/code-reviews`);
+      assertSnippet(p.code, notes.snippet_hash);
       openForm({
         kind: "line",
         title: "Comment on code lines",
@@ -809,7 +927,11 @@ function App({ initialConfig, flags, root }) {
         postId: p.id,
         snippetHash: notes.snippet_hash,
         lineCount: p.code.split("\n").length,
-        values: { start_line: "1", end_line: "1", body: "" },
+        values: {
+          start_line: String(range.start),
+          end_line: String(range.end),
+          body: "",
+        },
       });
     });
   }
@@ -1000,11 +1122,14 @@ function App({ initialConfig, flags, root }) {
     }
     if (route.view === "inbox") {
       await task(async () => {
-        if (!item.read_at)
+        if (!item.read_at) {
+          notificationGeneration.current++;
           await api("/notifications/" + item.id + "/read", {
             method: "PATCH",
             body: {},
           });
+          setUnread((v) => Math.max(0, v - 1));
+        }
         cache.current.clear();
         if (item.event_id) {
           openBrowser(
@@ -1035,6 +1160,11 @@ function App({ initialConfig, flags, root }) {
       navigate({ view: "feedback", postId: route.id, id: item.id, page: 1 });
       return;
     }
+    if (route.view === "thread" && item.entryType === "parent") {
+      setReading(item);
+      setScroll(0);
+      return;
+    }
     if (
       (route.view === "post" && route.tab === "replies") ||
       route.view === "thread"
@@ -1116,24 +1246,30 @@ function App({ initialConfig, flags, root }) {
       return;
     }
     const target = editable();
-    if (
-      !target?.feedback ||
-      target.row.user_id !== user.id ||
-      target.row.deleted_at
-    ) {
-      setError("Select your own line feedback or feedback reply to delete.");
+    if (!target || target.row.user_id !== user.id || target.row.deleted_at) {
+      setError(
+        "Select your own reply or code feedback in the Replies / Code feedback tab to delete.",
+      );
       return;
     }
     askConfirm(
-      "Delete your feedback?",
-      "Your text is removed. Other members’ replies are preserved.",
+      target.feedback ? "Delete your feedback?" : "Delete your reply?",
+      "Your text is removed. Other members’ replies are preserved." +
+        (!target.feedback && current.post?.accepted_reply_id === target.row.id
+          ? " Its accepted-solution mark is cleared."
+          : ""),
       () =>
         task(async () => {
           await api(target.url, {
             method: "DELETE",
             body: { revision: target.row.revision },
           });
-          invalidate("Feedback deleted; the discussion is preserved.");
+          setReading(null);
+          invalidate(
+            target.feedback
+              ? "Feedback deleted; the discussion is preserved."
+              : "Reply deleted; other members’ replies are preserved.",
+          );
         }),
     );
   }
@@ -1159,6 +1295,81 @@ function App({ initialConfig, flags, root }) {
       invalidate(note.resolved ? "Feedback reopened." : "Feedback resolved.");
     });
   }
+  function acceptSolution() {
+    const post = current?.post;
+    if (
+      !selected ||
+      selected.deleted_at ||
+      !post ||
+      post.user_id !== user.id ||
+      !["question", "review"].includes(post.kind) ||
+      !(route.view === "thread" || route.tab === "replies")
+    )
+      return;
+    const accepted = post.accepted_reply_id === selected.id;
+    askConfirm(
+      accepted
+        ? "Remove accepted solution?"
+        : "Accept this reply as the solution?",
+      "This changes the solution shown to everyone in the conversation.",
+      () =>
+        task(async () => {
+          await api(`/posts/${post.id}/solution`, {
+            method: "PATCH",
+            body: { reply_id: accepted ? null : selected.id },
+          });
+          invalidate(accepted ? "Solution removed." : "Solution accepted.");
+        }),
+    );
+  }
+  function reportSelected() {
+    const target = editable();
+    if (!target?.feedback || target.row.deleted_at) {
+      setError("Select an existing code remark or feedback reply to report.");
+      return;
+    }
+    const noteId = route.view === "feedback" ? route.id : target.row.id;
+    openForm({
+      kind: "report",
+      feedback: true,
+      title: "Report selected feedback",
+      url: `/posts/${current.post.id}/code-reviews/${noteId}/report`,
+      replyId: target.row.entryType === "feedbackReply" ? target.row.id : 0,
+      audience: "Assigned moderation team",
+      values: { reason: "" },
+    });
+  }
+  function runAction(id) {
+    setActionIndex(null);
+    if (id === "read") {
+      if (current?.post) {
+        setReading(selected);
+        setScroll(0);
+      } else openSelected();
+    } else if (id === "reply") reply();
+    else if (id === "comment") lineFeedback();
+    else if (id === "edit") editSelected();
+    else if (id === "delete") deleteSelected();
+    else if (id === "resolve") resolveSelected();
+    else if (id === "solution") acceptSolution();
+    else if (id === "report") reportSelected();
+    else if (id === "browser")
+      openBrowser(config.origin + "/app#post/" + current.post.id);
+    else if (id === "sync") invalidate("Updated.");
+    else if (id === "live") {
+      setLive((v) => !v);
+      setLiveStatus("");
+    } else if (id === "read-all")
+      task(async () => {
+        notificationGeneration.current++;
+        await api("/notifications/read-all", {
+          method: "PATCH",
+          body: { through_id: current.latest_id },
+        });
+        setUnread(0);
+        invalidate("Received notifications marked as read.");
+      });
+  }
   async function runCommand() {
     const value = command.trim();
     if (!value) return;
@@ -1232,6 +1443,7 @@ function App({ initialConfig, flags, root }) {
     );
   }
   useInput((input, keyEvent) => {
+    activity.current = Date.now();
     if (picker) return;
     if (keyEvent.ctrl && input === "c") {
       if (dialog) {
@@ -1274,6 +1486,15 @@ function App({ initialConfig, flags, root }) {
       return;
     }
     if (busy.current) return;
+    if (actionIndex !== null) {
+      if (keyEvent.escape || input === "x" || input === "X")
+        setActionIndex(null);
+      else if (keyEvent.upArrow) setActionIndex((v) => Math.max(0, v - 1));
+      else if (keyEvent.downArrow)
+        setActionIndex((v) => Math.min(actions.length - 1, v + 1));
+      else if (keyEvent.return) runAction(actions[actionIndex]?.id);
+      return;
+    }
     if (reading) {
       const lines = wrap(
           reading.deleted_at
@@ -1298,9 +1519,11 @@ function App({ initialConfig, flags, root }) {
       else if (input === "r") {
         setReading(null);
         reply();
-      } else if (input === "e") {
+      } else if (input === "e" || input === "E") {
         setReading(null);
         editSelected();
+      } else if (input === "d" || input === "D") {
+        deleteSelected();
       }
       return;
     }
@@ -1459,6 +1682,80 @@ function App({ initialConfig, flags, root }) {
       else if (keyEvent.rightArrow) setFocus("content");
       return;
     }
+    if (input === "x" || input === "X" || input === "?") {
+      setActionIndex(0);
+      return;
+    }
+    if ((input === "v" || input === "V") && current?.post?.code) {
+      navigate({ view: "post", id: current.post.id, tab: "feedback", page: 1 });
+      return;
+    }
+    if (reviewing && (input === "w" || input === "W")) {
+      setReviewFocus((v) => (v === "code" ? "notes" : "code"));
+      return;
+    }
+    if (
+      reviewing &&
+      (input === "f" || input === "F") &&
+      route.view === "post"
+    ) {
+      const filters = [undefined, "open", "resolved"];
+      navigate(
+        {
+          ...route,
+          status: filters[(filters.indexOf(route.status) + 1) % filters.length],
+          page: 1,
+        },
+        { replace: true },
+      );
+      return;
+    }
+    if (reviewing && reviewFocus === "code") {
+      if (
+        keyEvent.upArrow ||
+        keyEvent.downArrow ||
+        keyEvent.pageUp ||
+        keyEvent.pageDown
+      ) {
+        const delta =
+          (keyEvent.upArrow || keyEvent.pageUp ? -1 : 1) *
+          (keyEvent.pageUp || keyEvent.pageDown
+            ? Math.max(1, contentHeight - 2)
+            : 1);
+        setReviewLine((v) =>
+          Math.max(
+            0,
+            Math.min(current.post.code.split("\n").length - 1, v + delta),
+          ),
+        );
+        return;
+      }
+      if (keyEvent.leftArrow || keyEvent.rightArrow) {
+        setReviewHorizontal((v) =>
+          Math.max(0, v + (keyEvent.leftArrow ? -8 : 8)),
+        );
+        return;
+      }
+      if (input === " ") {
+        setReviewAnchor((v) => (v === null ? reviewLine : null));
+        return;
+      }
+      if (keyEvent.return) {
+        const i = current.items.findIndex(
+          (n) =>
+            !n.outdated &&
+            !n.deleted_at &&
+            reviewLine + 1 >= n.start_line &&
+            reviewLine + 1 <= n.end_line,
+        );
+        if (i >= 0) {
+          setIndex(i);
+          setReviewFocus("notes");
+        } else
+          setNotice("No remark on this line on the current page. C adds one.");
+        return;
+      }
+    }
     const prose =
       route.view === "help" ||
       (route.view === "post" && (!route.tab || route.tab === "overview")) ||
@@ -1553,19 +1850,20 @@ function App({ initialConfig, flags, root }) {
       invalidate("Updated.");
       return;
     }
-    if (input === "c") {
+    if (input === "c" || input === "C") {
       lineFeedback();
       return;
     }
-    if (input === "s") {
-      resolveSelected();
+    if (input === "s" || input === "S") {
+      if (route.view === "thread" || route.tab === "replies") acceptSolution();
+      else resolveSelected();
       return;
     }
-    if (input === "e") {
+    if (input === "e" || input === "E") {
       editSelected();
       return;
     }
-    if (input === "d") {
+    if (input === "d" || input === "D") {
       deleteSelected();
       return;
     }
@@ -1590,25 +1888,12 @@ function App({ initialConfig, flags, root }) {
       return;
     }
     if (input === "!" && ["feedback", "post"].includes(route.view)) {
-      const target = editable();
-      if (!target?.feedback || target.row.deleted_at) {
-        setError("Select an existing code remark or feedback reply to report.");
-        return;
-      }
-      const noteId = route.view === "feedback" ? route.id : target.row.id;
-      openForm({
-        kind: "report",
-        feedback: true,
-        title: "Report selected feedback",
-        url: `/posts/${current.post.id}/code-reviews/${noteId}/report`,
-        replyId: target.row.entryType === "feedbackReply" ? target.row.id : 0,
-        audience: "Assigned moderation team",
-        values: { reason: "" },
-      });
+      reportSelected();
     }
   });
   const status =
     error ||
+    liveStatus ||
     notice ||
     (pending
       ? "Saving…"
@@ -1807,6 +2092,61 @@ function App({ initialConfig, flags, root }) {
         { color: colors.muted },
         "Opening " + labelOf(route).toLowerCase() + " " + spin,
       );
+    else if (actionIndex !== null) {
+      const first = Math.max(
+        0,
+        actionIndex - Math.max(1, contentHeight - 2) + 1,
+      );
+      body = h(
+        Box,
+        { height: contentHeight, flexDirection: "column", overflow: "hidden" },
+        h(
+          Text,
+          { bold: true, color: colors.blue },
+          "Actions · ↑↓ choose · Enter run · Esc close",
+        ),
+        contentHeight >= 4
+          ? h(
+              Text,
+              { color: colors.muted },
+              "Available for this selection and your role",
+            )
+          : null,
+        ...actions
+          .slice(
+            first,
+            first + Math.max(1, contentHeight - (contentHeight >= 4 ? 2 : 1)),
+          )
+          .map((action, i) =>
+            h(
+              Text,
+              {
+                key: action.id,
+                color: i + first === actionIndex ? colors.blue : colors.text,
+                backgroundColor:
+                  i + first === actionIndex ? colors.selected : undefined,
+              },
+              clip(
+                (i + first === actionIndex ? "› " : "  ") + action.label,
+                contentWidth,
+              ),
+            ),
+          ),
+      );
+    } else if (reviewing)
+      body = h(ReviewWorkspace, {
+        post: current.post,
+        note: route.view === "feedback" ? current.note : null,
+        items: current.items || [],
+        index,
+        width: contentWidth,
+        height: contentHeight,
+        focus: reviewFocus,
+        line: reviewLine,
+        anchor: reviewAnchor,
+        horizontal: reviewHorizontal,
+        rows: (w) => listRows(route, current, index, w),
+      });
     else {
       const lines = contentLines(route, current || {}).flatMap((line) =>
         wrap(line, contentWidth),
@@ -1922,11 +2262,19 @@ function App({ initialConfig, flags, root }) {
                       ? colors.blue
                       : colors.muted,
                   bold: (route.tab || "overview") === id,
+                  backgroundColor:
+                    (route.tab || "overview") === id
+                      ? colors.selected
+                      : undefined,
                 },
                 " " + label + " ",
               ),
             ),
-            h(Text, { color: colors.muted }, "  ← →"),
+            h(
+              Text,
+              { color: colors.muted },
+              reviewing ? "  W focus · F " + (route.status || "all") : "  ← →",
+            ),
           )
         : h(TextLine, {
             text: form
@@ -1962,7 +2310,7 @@ function App({ initialConfig, flags, root }) {
               paddingX: 1,
               overflow: "hidden",
             },
-            h(Text, { color: colors.muted }, "WORKSPACE"),
+            h(Text, { color: colors.purple, bold: true }, "YOUR SPACE"),
             h(Text, null, " "),
             ...navigation
               .slice(
@@ -1986,9 +2334,16 @@ function App({ initialConfig, flags, root }) {
                     backgroundColor: selected ? colors.selected : undefined,
                     wrap: "truncate",
                   },
-                  (selected ? "› " : "  ") + label,
+                  (selected ? "› " : route.view === id ? "● " : "  ") +
+                    label +
+                    (id === "inbox" && unread ? " · " + unread : ""),
                 );
               }),
+            h(
+              Text,
+              { color: colors.muted, dimColor: true },
+              "  Tab sections · / find",
+            ),
           )
         : null;
     center = h(
@@ -1998,21 +2353,26 @@ function App({ initialConfig, flags, root }) {
       compact && focus === "nav" ? null : pane,
     );
   }
-  const hint = picker
-    ? "Project files stay local until publication is confirmed"
-    : reading
-      ? "↑↓ scroll · R reply · E edit · Esc close"
-      : preview
-        ? "← → choose · Enter confirm · Esc edit"
-        : form
-          ? "Tab field · Ctrl+O files · Ctrl+G diff · Ctrl+S preview · Esc discard"
-          : phase !== "ready"
-            ? "Enter connect / open browser · Ctrl+C exit"
-            : route.view === "feedback"
-              ? "↑↓ select · R reply · E edit · D delete · S resolve · ! report"
-              : route.view === "post"
-                ? "←→ tabs · ↑↓ scroll/select · R reply · C code remark · Space full text · Tab navigate"
-                : "↑↓ select · Enter open · Tab sections · [ ] pages · N new · / search";
+  const hint =
+    actionIndex !== null
+      ? "Actions are scoped to the selected item · Esc closes"
+      : reviewing && !form && !preview && !reading
+        ? "W code / discussion · Space select · C comment · X actions · F filter"
+        : picker
+          ? "Project files stay local until publication is confirmed"
+          : reading
+            ? "↑↓ scroll · R reply · E edit · D delete · Esc close"
+            : preview
+              ? "← → choose · Enter confirm · Esc edit"
+              : form
+                ? "Tab field · Ctrl+O files · Ctrl+G diff · Ctrl+S preview · Esc discard"
+                : phase !== "ready"
+                  ? "Enter connect / open browser · Ctrl+C exit"
+                  : route.view === "feedback"
+                    ? "↑↓ select · R reply · E edit · D delete · S resolve · ! report"
+                    : route.view === "post"
+                      ? "←→ tabs · ↑↓ select · R reply · E edit · D delete · Space read"
+                      : "↑↓ select · Enter open · Tab sections · [ ] pages · N new · / search";
   return h(
     Box,
     {
@@ -2035,12 +2395,22 @@ function App({ initialConfig, flags, root }) {
       h(
         Text,
         { color: colors.purple, bold: true },
-        clip("◈ DEVDEVIAN  /  TERMINAL WORKSPACE", Math.max(10, width - 28)),
+        clip("◈ DEVDEVIAN  ·  " + basename(root), Math.max(10, width - 36)),
       ),
       h(
         Text,
         { color: colors.blue },
-        clip(user ? "@" + user.username : "CLI · ALPHA", 24),
+        clip(
+          user
+            ? "@" +
+                user.username +
+                " · " +
+                unread +
+                " unread · " +
+                (live ? "● Live" : "○ Paused")
+            : "CLI · ALPHA",
+          32,
+        ),
       ),
     ),
     center,
@@ -2068,7 +2438,10 @@ function App({ initialConfig, flags, root }) {
         : h(
             Text,
             { color: colors.muted },
-            clip("Search or /command     ·     Press / to type", width - 6),
+            clip(
+              "Search or /command     ·     Press / to type · X actions",
+              width - 6,
+            ),
           ),
     ),
     h(TextLine, { text: hint, width, color: colors.muted }),

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@tenyokjs/devdevian-cli",
-  "version": "0.3.0-alpha.1",
+  "version": "0.4.0-alpha.1",
   "description": "Devdevian in your terminal: discussions, questions and human code reviews.",
   "type": "module",
   "bin": {