@tenonhq/dovetail-core 0.0.93 → 0.0.94

package/dist/appUtils.js

@@ -36,7 +36,7 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
     return (mod && mod.__esModule) ? mod : { "default": mod };
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.createAndAssignUpdateSet = exports.swapScope = exports.buildFiles = exports.summarizeRecord = exports.pushFiles = exports.getAppFileList = exports.groupAppFiles = exports.processMissingFiles = exports.refreshAllFiles = exports.findMissingFiles = exports.syncManifest = exports.processManifest = exports.normalizeManifestKeys = void 0;
+exports.createAndAssignUpdateSet = exports.swapScope = exports.buildFiles = exports.summarizeRecord = exports.pushFiles = exports.getAppFileList = exports.groupAppFiles = exports.processMissingFiles = exports.refreshAllFiles = exports.findMissingFiles = exports.syncManifest = exports.processManifest = exports.normalizeManifestKeys = exports.toSafeFolderName = void 0;
 const path_1 = __importDefault(require("path"));
 const fs_1 = __importDefault(require("fs"));
 const progress_1 = __importDefault(require("progress"));
@@ -171,9 +171,29 @@ const processTablesInManifest = async (tables, forceWrite, sourcePath, onRecordP
     });
 };
 /**
- * Re-keys manifest records from sys_id to record.name (display value).
+ * Returns a filesystem-safe folder name for a record.
+ *
+ * Dovetail names each record's on-disk folder after the record's display name.
+ * Windows/NTFS forbids these characters in a path component — `< > : " | ? * \ /`
+ * — and forbids a trailing space or trailing dot. A folder whose name violates
+ * this cannot be checked out on Windows (`git clone` aborts with "invalid path"),
+ * even though macOS/Linux accept it. When the display name is unsafe we fall back
+ * to the record's sys_id, which is hex and safe on every OS. The true display name
+ * is unaffected here and is still carried by the server-provided metaData.json.
+ */
+const toSafeFolderName = (record) => {
+    var name = record.name || "";
+    var isUnsafe = /[<>:"|?*\\/]/.test(name) || /[ .]$/.test(name) || name === "";
+    return isUnsafe ? record.sys_id : name;
+};
+exports.toSafeFolderName = toSafeFolderName;
+/**
+ * Re-keys manifest records from sys_id to a filesystem-safe folder name.
  * Some ServiceNow tables return records keyed by sys_id instead of display name.
- * This ensures consistent naming for directories and manifest lookups.
+ * This ensures consistent naming for directories and manifest lookups, and keeps
+ * the on-disk folder name (which every writer derives from `record.name`) equal to
+ * the manifest key that `dove push` looks records up by — so the key ≡ folder
+ * invariant holds even when an unsafe display name forces a sys_id fallback.
  */
 const normalizeManifestKeys = (manifest) => {
     var tables = manifest.tables || {};
@@ -186,11 +206,15 @@ const normalizeManifestKeys = (manifest) => {
         for (var j = 0; j < recordKeys.length; j++) {
             var key = recordKeys[j];
             var record = records[key];
-            var displayKey = record.name || key;
-            // Handle duplicate display names by appending sys_id suffix
+            var displayKey = (0, exports.toSafeFolderName)(record);
+            // Handle duplicate folder names by appending sys_id suffix
             if (normalized[displayKey]) {
                 displayKey = displayKey + " (" + record.sys_id.substring(0, 8) + ")";
             }
+            // Keep record.name === manifest key so all writers (which build the folder
+            // path from record.name) and push (which looks up by folder name) agree.
+            // The real display name lives in the server-provided metaData.json snapshot.
+            record.name = displayKey;
             normalized[displayKey] = record;
         }
         tables[tableName].records = normalized;
@@ -199,6 +223,9 @@ const normalizeManifestKeys = (manifest) => {
 };
 exports.normalizeManifestKeys = normalizeManifestKeys;
 const processManifest = async (manifest, forceWrite = false, sourcePath) => {
+    // Idempotent: guarantees filesystem-safe folder names + key ≡ record.name on
+    // every write path, including downloadCommand which does not normalize upstream.
+    (0, exports.normalizeManifestKeys)(manifest);
     const tableCount = Object.keys(manifest.tables).length;
     FileLogger_1.fileLogger.debug("Processing manifest: " + (manifest.scope || "legacy") + " (" + tableCount + " tables)");
     var recordCount = countRecordsInTables(manifest.tables);

package/dist/tests/normalizeManifestKeys.test.js

@@ -0,0 +1,94 @@
+"use strict";
+// Tests for filesystem-safe folder naming.
+//
+// Dovetail names each record's folder after its ServiceNow display name. Windows
+// forbids `< > : " | ? * \ /`, a trailing space, and a trailing dot in a path
+// component, so a record named "Email Status Change " (trailing space) or an ACL
+// named "x_cadso_work_task.*" cannot be checked out on Windows. toSafeFolderName
+// falls back to the always-safe sys_id for such names; normalizeManifestKeys keeps
+// the on-disk folder name (record.name) equal to the manifest key push looks up by.
+Object.defineProperty(exports, "__esModule", { value: true });
+const appUtils_1 = require("../appUtils");
+const rec = (name, sys_id) => ({
+    name,
+    sys_id,
+    files: [{ name: "metaData", type: "json" }],
+});
+describe("toSafeFolderName", () => {
+    it("leaves a safe display name unchanged", () => {
+        expect((0, appUtils_1.toSafeFolderName)(rec("Send Email", "abc123"))).toBe("Send Email");
+        expect((0, appUtils_1.toSafeFolderName)(rec("Prevent delete - WorkGroup", "abc123"))).toBe("Prevent delete - WorkGroup");
+    });
+    it("falls back to sys_id for a trailing space", () => {
+        expect((0, appUtils_1.toSafeFolderName)(rec("Email Status Change ", "fefb8758"))).toBe("fefb8758");
+    });
+    it("falls back to sys_id for a trailing dot", () => {
+        expect((0, appUtils_1.toSafeFolderName)(rec("weird.", "sid1"))).toBe("sid1");
+    });
+    it("falls back to sys_id for each Windows-illegal character", () => {
+        const illegal = ["<", ">", ":", '"', "|", "?", "*", "\\", "/"];
+        illegal.forEach((ch) => {
+            expect((0, appUtils_1.toSafeFolderName)(rec("name" + ch + "x", "sidX"))).toBe("sidX");
+        });
+    });
+    it("treats the wildcard ACL name as unsafe", () => {
+        expect((0, appUtils_1.toSafeFolderName)(rec("x_cadso_work_task.*", "aclsid"))).toBe("aclsid");
+    });
+    it("falls back to sys_id for an empty name", () => {
+        expect((0, appUtils_1.toSafeFolderName)(rec("", "emptysid"))).toBe("emptysid");
+    });
+});
+describe("normalizeManifestKeys", () => {
+    const buildManifest = (records) => {
+        const byKey = {};
+        records.forEach((r) => {
+            byKey[r.sys_id] = r; // simulate a server manifest keyed by sys_id
+        });
+        return { scope: "x_cadso_test", tables: { sys_script: { records: byKey } } };
+    };
+    it("keys unsafe records by sys_id and safe records by name", () => {
+        const manifest = buildManifest([
+            rec("Send Email", "safe1"),
+            rec("Email Status Change ", "fefb8758330ede107b18bc534d5c7bfb"),
+            rec("x_cadso_work_task.*", "acl9999"),
+        ]);
+        (0, appUtils_1.normalizeManifestKeys)(manifest);
+        const keys = Object.keys(manifest.tables.sys_script.records);
+        expect(keys).toContain("Send Email");
+        expect(keys).toContain("fefb8758330ede107b18bc534d5c7bfb");
+        expect(keys).toContain("acl9999");
+        expect(keys).not.toContain("Email Status Change ");
+        expect(keys).not.toContain("x_cadso_work_task.*");
+    });
+    it("keeps record.name === manifest key for every record (push invariant)", () => {
+        const manifest = buildManifest([
+            rec("Send Email", "safe1"),
+            rec("Email Status Change ", "unsafe1"),
+            rec("h:extended", "unsafe2"),
+        ]);
+        (0, appUtils_1.normalizeManifestKeys)(manifest);
+        const records = manifest.tables.sys_script.records;
+        Object.keys(records).forEach((key) => {
+            expect(records[key].name).toBe(key);
+        });
+    });
+    it("preserves sys_id so push can still resolve the record", () => {
+        const manifest = buildManifest([rec("Email Status Change ", "fefb8758")]);
+        (0, appUtils_1.normalizeManifestKeys)(manifest);
+        const record = manifest.tables.sys_script.records["fefb8758"];
+        expect(record).toBeDefined();
+        expect(record.sys_id).toBe("fefb8758");
+    });
+    it("disambiguates duplicate folder names with a sys_id suffix", () => {
+        const manifest = buildManifest([
+            rec("Duplicate", "1111111111111111"),
+            rec("Duplicate", "2222222222222222"),
+        ]);
+        (0, appUtils_1.normalizeManifestKeys)(manifest);
+        const keys = Object.keys(manifest.tables.sys_script.records);
+        expect(keys).toContain("Duplicate");
+        expect(keys).toContain("Duplicate (22222222)");
+        // invariant still holds for the suffixed record
+        expect(manifest.tables.sys_script.records["Duplicate (22222222)"].name).toBe("Duplicate (22222222)");
+    });
+});

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@tenonhq/dovetail-core",
-  "version": "0.0.93",
+  "version": "0.0.94",
   "description": "Next-gen file syncer",
   "license": "GPL-3.0",
   "main": "./dist/index.js",

package/release-manifest.json

@@ -1,5 +1,84 @@
 {
   "$schema": "dovetail-manifest/v1",
-  "generated_at": "2026-05-28T00:00:00Z",
-  "events": []
+  "generated_at": "2026-05-28T15:54:22.498Z",
+  "events": [
+    {
+      "$schema": "dovetail-release-event/v1",
+      "event_id": "dovetail-claude-plans@0.0.19",
+      "package": "@tenonhq/dovetail-claude-plans",
+      "version": "0.0.19",
+      "prev_version": "0.0.18",
+      "published_at": "2026-05-28T15:54:22.483Z",
+      "git": {
+        "sha": "0247ef6e75093c95359413725977df07bd5bff70",
+        "tag": "dovetail-claude-plans@0.0.19"
+      },
+      "semver_bump": "patch",
+      "commits": [
+        {
+          "sha": "0247ef6e7",
+          "subject": "feat(dashboard): Prompt Lints filters + merged-PR filter for Claude Plans (#116)",
+          "pr": 116
+        },
+        {
+          "sha": "5f14a3421",
+          "subject": "chore(release): @tenonhq/dovetail-claude-plans@0.0.18 [skip ci]"
+        }
+      ],
+      "exports_delta": null,
+      "narrative": null
+    },
+    {
+      "$schema": "dovetail-release-event/v1",
+      "event_id": "dovetail-dashboard@0.0.31",
+      "package": "@tenonhq/dovetail-dashboard",
+      "version": "0.0.31",
+      "prev_version": "0.0.30",
+      "published_at": "2026-05-28T15:54:22.483Z",
+      "git": {
+        "sha": "0247ef6e75093c95359413725977df07bd5bff70",
+        "tag": "dovetail-dashboard@0.0.31"
+      },
+      "semver_bump": "patch",
+      "commits": [
+        {
+          "sha": "0247ef6e7",
+          "subject": "feat(dashboard): Prompt Lints filters + merged-PR filter for Claude Plans (#116)",
+          "pr": 116
+        },
+        {
+          "sha": "c35d549c4",
+          "subject": "chore(release): @tenonhq/dovetail-dashboard@0.0.30 [skip ci]"
+        }
+      ],
+      "exports_delta": null,
+      "narrative": null
+    },
+    {
+      "$schema": "dovetail-release-event/v1",
+      "event_id": "dovetail-core@0.0.93",
+      "package": "@tenonhq/dovetail-core",
+      "version": "0.0.93",
+      "prev_version": "0.0.92",
+      "published_at": "2026-05-28T08:23:44.072Z",
+      "git": {
+        "sha": "f2f4d29e5fbd6197fc501bc803a864ed605cd54a",
+        "tag": "dovetail-core@0.0.93"
+      },
+      "semver_bump": "patch",
+      "commits": [
+        {
+          "sha": "f2f4d29e5",
+          "subject": "feat: release manifest emit + dove knowledge-diff (downstream doc sync) (#114)",
+          "pr": 114
+        },
+        {
+          "sha": "16e4c0cc2",
+          "subject": "chore(release): @tenonhq/dovetail-core@0.0.92 [skip ci]"
+        }
+      ],
+      "exports_delta": null,
+      "narrative": null
+    }
+  ]
 }