@tenonhq/dovetail-core 0.0.90 → 0.0.92

package/dist/snClient.js

@@ -75,9 +75,46 @@ function _resetDovetailApiFallback() {
 function _isUsingLegacyClaudePath() {
     return _dovetailApiUseLegacyClaudePath;
 }
+// SN returns 400 with this body when a Scripted REST endpoint does not exist
+// at the requested URI. The /dovetail -> /claude fallback above only fires on
+// 404, so the same "endpoint missing" condition presents as an opaque 400 to
+// callers. Detect it and surface a clear hint.
+var _SN_MISSING_ENDPOINT_BODY = "Requested URI does not represent any resource";
+function _summarizeResponseBody(data) {
+    if (data === undefined || data === null)
+        return "";
+    try {
+        var asJson = typeof data === "string" ? data : JSON.stringify(data);
+        return asJson.length > 500 ? asJson.slice(0, 500) + "…" : asJson;
+    }
+    catch (_) {
+        return String(data);
+    }
+}
+// Augment an axios error in place with a human-readable message describing
+// the attempted Dovetail REST call. Preserves .response/.code/.config so
+// existing callers and tests that inspect those fields keep working.
+function _enrichDovetailApiError(e, attemptedEndpoint) {
+    if (!axios_1.default.isAxiosError(e))
+        return e;
+    var status = e.response ? e.response.status : undefined;
+    var body = e.response ? _summarizeResponseBody(e.response.data) : "";
+    var missingEndpoint = status === 400 && body.indexOf(_SN_MISSING_ENDPOINT_BODY) !== -1;
+    var hint = missingEndpoint
+        ? " — Scripted REST endpoint not found on this instance. Re-import the Dovetail Scripted REST API XML (see Dovetail/docs/dovetail-servicenow-migration.md)."
+        : "";
+    e.message =
+        "Dovetail REST call failed: " +
+            (status ? "HTTP " + status : "no response") +
+            " " + attemptedEndpoint +
+            (body ? " — " + body : "") +
+            hint;
+    return e;
+}
 async function _callDovetailApi(op, call) {
+    var endpoint = _dovetailEndpoint(op);
     try {
-        return await call(_dovetailEndpoint(op));
+        return await call(endpoint);
     }
     catch (e) {
         if (!_dovetailApiUseLegacyClaudePath && _getHttpStatus(e) === 404) {
@@ -85,9 +122,15 @@ async function _callDovetailApi(op, call) {
                 " returned 404. Falling back to legacy /api/cadso/claude/" + op +
                 ". Re-import the Dovetail Scripted REST API XML on your ServiceNow instance to silence this warning.");
             _dovetailApiUseLegacyClaudePath = true;
-            return await call(_dovetailEndpoint(op));
+            var legacyEndpoint = _dovetailEndpoint(op);
+            try {
+                return await call(legacyEndpoint);
+            }
+            catch (e2) {
+                throw _enrichDovetailApiError(e2, legacyEndpoint);
+            }
         }
-        throw e;
+        throw _enrichDovetailApiError(e, endpoint);
     }
 }
 function _getRetryAfterMs(e) {

package/dist/tests/snClient.fallback.test.js

@@ -21,10 +21,10 @@ jest.mock("../genericUtils", function () {
     return { wait: jest.fn().mockResolvedValue(undefined) };
 });
 const snClient_1 = require("../snClient");
-function makeAxiosError(status) {
+function makeAxiosError(status, data) {
     var error = new Error("Request failed with status " + status);
     error.isAxiosError = true;
-    error.response = { status: status, headers: {}, data: {} };
+    error.response = { status: status, headers: {}, data: data === undefined ? {} : data };
     return error;
 }
 function makeAxiosResponse(data) {
@@ -117,4 +117,84 @@ describe("_callDovetailApi 404 fallback", function () {
         expect((0, snClient_1._isUsingLegacyClaudePath)()).toBe(false);
         expect(mockLogger.warn).not.toHaveBeenCalled();
     });
+    describe("descriptive error enrichment", function () {
+        it("includes status, endpoint, and response body on a 401", async function () {
+            var call = jest.fn(async function (_endpoint) {
+                throw makeAxiosError(401, { error: { message: "User Not Authenticated" } });
+            });
+            try {
+                await (0, snClient_1._callDovetailApi)("changeScope", call);
+                throw new Error("expected rejection");
+            }
+            catch (e) {
+                expect(e.response.status).toBe(401);
+                expect(e.message).toContain("HTTP 401");
+                expect(e.message).toContain("api/cadso/dovetail/changeScope");
+                expect(e.message).toContain("User Not Authenticated");
+            }
+        });
+        it("adds the missing-endpoint hint when SN returns its 400 'Requested URI does not represent any resource'", async function () {
+            var snBody = {
+                error: { message: "Requested URI does not represent any resource", detail: null },
+                status: "failure",
+            };
+            var call = jest.fn(async function (_endpoint) {
+                throw makeAxiosError(400, snBody);
+            });
+            try {
+                await (0, snClient_1._callDovetailApi)("changeScope", call);
+                throw new Error("expected rejection");
+            }
+            catch (e) {
+                expect(e.response.status).toBe(400);
+                expect(e.message).toContain("HTTP 400");
+                expect(e.message).toContain("api/cadso/dovetail/changeScope");
+                expect(e.message).toContain("Re-import the Dovetail Scripted REST API XML");
+            }
+        });
+        it("does NOT add the missing-endpoint hint for unrelated 400s", async function () {
+            var call = jest.fn(async function (_endpoint) {
+                throw makeAxiosError(400, { error: { message: "Invalid scope name" } });
+            });
+            try {
+                await (0, snClient_1._callDovetailApi)("changeScope", call);
+                throw new Error("expected rejection");
+            }
+            catch (e) {
+                expect(e.message).toContain("HTTP 400");
+                expect(e.message).toContain("Invalid scope name");
+                expect(e.message).not.toContain("Re-import the Dovetail Scripted REST API XML");
+            }
+        });
+        it("after fallback latches, errors from the legacy path are also enriched", async function () {
+            var calls = [];
+            var call = jest.fn(async function (endpoint) {
+                calls.push(endpoint);
+                if (endpoint.indexOf("api/cadso/dovetail/") === 0) {
+                    throw makeAxiosError(404, {});
+                }
+                throw makeAxiosError(500, { error: { message: "boom" } });
+            });
+            try {
+                await (0, snClient_1._callDovetailApi)("changeScope", call);
+                throw new Error("expected rejection");
+            }
+            catch (e) {
+                expect(calls).toEqual([
+                    "api/cadso/dovetail/changeScope",
+                    "api/cadso/claude/changeScope",
+                ]);
+                expect(e.response.status).toBe(500);
+                expect(e.message).toContain("HTTP 500");
+                expect(e.message).toContain("api/cadso/claude/changeScope");
+                expect(e.message).toContain("boom");
+            }
+        });
+        it("leaves non-axios errors untouched", async function () {
+            var call = jest.fn(async function (_endpoint) {
+                throw new Error("ECONNREFUSED");
+            });
+            await expect((0, snClient_1._callDovetailApi)("changeScope", call)).rejects.toThrow("ECONNREFUSED");
+        });
+    });
 });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@tenonhq/dovetail-core",
-  "version": "0.0.90",
+  "version": "0.0.92",
   "description": "Next-gen file syncer",
   "license": "GPL-3.0",
   "main": "./dist/index.js",