@tenonhq/dovetail-core 0.0.100 → 0.0.102

package/dist/snClient.js

@@ -111,6 +111,22 @@ function _enrichDovetailApiError(e, attemptedEndpoint) {
             hint;
     return e;
 }
+// True when an error indicates the Dovetail Scripted REST endpoint does not
+// exist on this instance (404, or the 400 "Requested URI does not represent any
+// resource" body). Used to degrade createUpdateSet to the Table API path on
+// instances that do not have the createUpdateSet op deployed yet.
+function _isMissingDovetailEndpoint(e) {
+    if (!axios_1.default.isAxiosError(e))
+        return false;
+    var status = e.response ? e.response.status : undefined;
+    if (status === 404)
+        return true;
+    if (status === 400) {
+        var body = e.response ? _summarizeResponseBody(e.response.data) : "";
+        return body.indexOf(_SN_MISSING_ENDPOINT_BODY) !== -1;
+    }
+    return false;
+}
 async function _callDovetailApi(op, call) {
     var endpoint = _dovetailEndpoint(op);
     try {
@@ -353,8 +369,12 @@ const snClient = (baseURL, username, password) => {
         const endpoint = "api/cadso/dovetail_sync/getCurrentScope";
         return client.get(endpoint);
     };
-    const createUpdateSet = (updateSetName, scopeSysId, description) => {
-        const endpoint = `api/now/table/sys_update_set`;
+    const createUpdateSet = async (updateSetName, scopeSysId, description) => {
+        // Prefer the scope-safe Dovetail server op. It switches the current
+        // application and inserts the set in one server call, so the set always
+        // lands in `scopeSysId`. A raw Table API POST ignores `application` (the
+        // field defaults to the session's current app), and the old
+        // changeScope-then-POST path raced and mis-scoped sets created back to back.
         const data = {
             name: updateSetName,
             state: "in progress",
@@ -365,7 +385,39 @@ const snClient = (baseURL, username, password) => {
         if (description) {
             data.description = description;
         }
-        return client.post(endpoint, data);
+        try {
+            const resp = await _callDovetailApi("createUpdateSet", (endpoint) => client.post(endpoint, data));
+            const payload = resp.data || {};
+            const sysId = payload.sys_id || (payload.result && payload.result.sys_id);
+            if (!sysId) {
+                throw new Error("createUpdateSet endpoint returned no sys_id");
+            }
+            // Normalize to the Table-API shape that unwrapSNResponse expects
+            // (resp.data.result), so callers stay unchanged.
+            return {
+                ...resp,
+                data: {
+                    result: {
+                        sys_id: sysId,
+                        name: payload.name || updateSetName,
+                        application: payload.application,
+                    },
+                },
+            };
+        }
+        catch (e) {
+            if (!_isMissingDovetailEndpoint(e)) {
+                throw e;
+            }
+            // Instance without the createUpdateSet op yet: degrade to the legacy
+            // Table API path so existing flows keep working during rollout. Sets
+            // created this way may be mis-scoped until the op is deployed.
+            Logger_1.logger.warn("Dovetail createUpdateSet endpoint not found on this instance; falling " +
+                "back to the Table API. Update sets may be mis-scoped until the " +
+                "Dovetail createUpdateSet REST op is installed on this instance.");
+            const endpoint = `api/now/table/sys_update_set`;
+            return client.post(endpoint, data);
+        }
     };
     const getCurrentUpdateSetUserPref = (userSysId) => {
         const endpoint = `api/now/table/sys_user_preference`;

package/dist/tests/snClient.createUpdateSet.test.js

@@ -0,0 +1,116 @@
+"use strict";
+// Tests for snClient.createUpdateSet: it must prefer the scope-safe Dovetail
+// `createUpdateSet` server op (normalizing its {sys_id,...} body to the
+// {result:{...}} shape unwrapSNResponse expects), and fall back to the raw
+// Table API ONLY when the endpoint is missing (404 / 400 "Requested URI ...").
+// A 500 or an unrelated 400 must NOT trigger the fallback.
+Object.defineProperty(exports, "__esModule", { value: true });
+var mockLogger = {
+    info: jest.fn(),
+    debug: jest.fn(),
+    warn: jest.fn(),
+    error: jest.fn(),
+    getLogLevel: function () { return "debug"; },
+};
+jest.mock("../Logger", function () {
+    return { logger: mockLogger };
+});
+jest.mock("../FileLogger", function () {
+    return { fileLogger: { debug: jest.fn(), info: jest.fn(), warn: jest.fn(), error: jest.fn() } };
+});
+jest.mock("../genericUtils", function () {
+    return { wait: jest.fn().mockResolvedValue(undefined) };
+});
+const snClient_1 = require("../snClient");
+function makeAxiosError(status, data) {
+    var error = new Error("Request failed with status " + status);
+    error.isAxiosError = true;
+    error.response = { status: status, headers: {}, data: data === undefined ? {} : data };
+    return error;
+}
+function makeAxiosResponse(data) {
+    return { status: 200, data: data, headers: {}, statusText: "OK", config: {} };
+}
+var MISSING_ENDPOINT_BODY = {
+    error: { message: "Requested URI does not represent any resource", detail: null },
+    status: "failure",
+};
+describe("snClient.createUpdateSet", function () {
+    beforeEach(function () {
+        (0, snClient_1._resetDovetailApiFallback)();
+        jest.clearAllMocks();
+    });
+    it("calls the createUpdateSet endpoint and normalizes the response to {result}", async function () {
+        var c = (0, snClient_1.snClient)("https://x.service-now.com/", "u", "p");
+        var post = jest.spyOn(c.client, "post").mockImplementation(async function () {
+            return makeAxiosResponse({ success: true, sys_id: "abc123", name: "My Set", application: "scopeSys" });
+        });
+        var resp = await c.createUpdateSet("My Set", "scopeSys", "a description");
+        expect(post).toHaveBeenCalledTimes(1);
+        expect(post.mock.calls[0][0]).toContain("dovetail_core/createUpdateSet");
+        expect(post.mock.calls[0][1]).toMatchObject({
+            name: "My Set",
+            application: "scopeSys",
+            description: "a description",
+            state: "in progress",
+        });
+        expect(resp.data.result.sys_id).toBe("abc123");
+        expect(resp.data.result.application).toBe("scopeSys");
+    });
+    it("falls back to the Table API when the endpoint 404s", async function () {
+        var c = (0, snClient_1.snClient)("https://x.service-now.com/", "u", "p");
+        var urls = [];
+        jest.spyOn(c.client, "post").mockImplementation(async function (url) {
+            urls.push(url);
+            if (url.indexOf("dovetail") !== -1) {
+                throw makeAxiosError(404, {});
+            }
+            return makeAxiosResponse({ result: { sys_id: "tbl1", name: "My Set" } });
+        });
+        var resp = await c.createUpdateSet("My Set", "scopeSys");
+        // dovetail_core -> legacy dovetail (404 fallback) -> Table API
+        expect(urls[urls.length - 1]).toBe("api/now/table/sys_update_set");
+        expect(resp.data.result.sys_id).toBe("tbl1");
+        expect(mockLogger.warn).toHaveBeenCalled();
+    });
+    it("falls back to the Table API on the 400 missing-endpoint body", async function () {
+        var c = (0, snClient_1.snClient)("https://x.service-now.com/", "u", "p");
+        var urls = [];
+        jest.spyOn(c.client, "post").mockImplementation(async function (url) {
+            urls.push(url);
+            if (url.indexOf("dovetail") !== -1) {
+                throw makeAxiosError(400, MISSING_ENDPOINT_BODY);
+            }
+            return makeAxiosResponse({ result: { sys_id: "tbl2", name: "My Set" } });
+        });
+        var resp = await c.createUpdateSet("My Set", "scopeSys");
+        expect(urls[urls.length - 1]).toBe("api/now/table/sys_update_set");
+        expect(resp.data.result.sys_id).toBe("tbl2");
+    });
+    it("does NOT fall back on an unrelated 400 (rethrows)", async function () {
+        var c = (0, snClient_1.snClient)("https://x.service-now.com/", "u", "p");
+        var tableHit = false;
+        jest.spyOn(c.client, "post").mockImplementation(async function (url) {
+            if (url.indexOf("dovetail") !== -1) {
+                throw makeAxiosError(400, { error: { message: "Invalid update set name" } });
+            }
+            tableHit = true;
+            return makeAxiosResponse({ result: { sys_id: "should-not-happen" } });
+        });
+        await expect(c.createUpdateSet("My Set", "scopeSys")).rejects.toBeDefined();
+        expect(tableHit).toBe(false);
+    });
+    it("does NOT fall back on a 500 (rethrows)", async function () {
+        var c = (0, snClient_1.snClient)("https://x.service-now.com/", "u", "p");
+        var tableHit = false;
+        jest.spyOn(c.client, "post").mockImplementation(async function (url) {
+            if (url.indexOf("dovetail") !== -1) {
+                throw makeAxiosError(500, { error: { message: "boom" } });
+            }
+            tableHit = true;
+            return makeAxiosResponse({ result: { sys_id: "should-not-happen" } });
+        });
+        await expect(c.createUpdateSet("My Set", "scopeSys")).rejects.toBeDefined();
+        expect(tableHit).toBe(false);
+    });
+});

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@tenonhq/dovetail-core",
-  "version": "0.0.100",
+  "version": "0.0.102",
   "description": "Next-gen file syncer",
   "license": "GPL-3.0",
   "main": "./dist/index.js",
@@ -39,7 +39,7 @@
   },
   "dependencies": {
     "@tenonhq/dovetail-clickup": "^0.0.10",
-    "@tenonhq/dovetail-schema": "^0.0.9",
+    "@tenonhq/dovetail-schema": "^0.0.10",
     "axios": "^1.5.1",
     "axios-cookiejar-support": "^4.0.7",
     "axios-rate-limit": "^1.3.0",

package/release-manifest.json

@@ -1,7 +1,59 @@
 {
   "$schema": "dovetail-manifest/v1",
-  "generated_at": "2026-06-02T18:16:07.004Z",
+  "generated_at": "2026-06-04T07:05:38.978Z",
   "events": [
+    {
+      "$schema": "dovetail-release-event/v1",
+      "event_id": "dovetail-core@0.0.101",
+      "package": "@tenonhq/dovetail-core",
+      "version": "0.0.101",
+      "prev_version": "0.0.100",
+      "published_at": "2026-06-04T07:05:38.971Z",
+      "git": {
+        "sha": "7c78a10933956739a7a234e48362cd8dc0b7ad71",
+        "tag": "dovetail-core@0.0.101"
+      },
+      "semver_bump": "patch",
+      "commits": [
+        {
+          "sha": "7c78a1093",
+          "subject": "fix(core): bump dovetail-schema pin ^0.0.9 -> ^0.0.10 (#142)",
+          "pr": 142
+        },
+        {
+          "sha": "6d7b59a14",
+          "subject": "chore(release): @tenonhq/dovetail-core@0.0.100 [skip ci]"
+        }
+      ],
+      "exports_delta": null,
+      "narrative": null
+    },
+    {
+      "$schema": "dovetail-release-event/v1",
+      "event_id": "dovetail-core@0.0.100",
+      "package": "@tenonhq/dovetail-core",
+      "version": "0.0.100",
+      "prev_version": "0.0.99",
+      "published_at": "2026-06-02T21:39:46.687Z",
+      "git": {
+        "sha": "602efb3b4ae7a1c450bdcfacdecea12ee618f085",
+        "tag": "dovetail-core@0.0.100"
+      },
+      "semver_bump": "patch",
+      "commits": [
+        {
+          "sha": "602efb3b4",
+          "subject": "fix(core): Windows-safe folder names in the download writer (#140)",
+          "pr": 140
+        },
+        {
+          "sha": "d3fd80bf7",
+          "subject": "chore(release): @tenonhq/dovetail-core@0.0.99 [skip ci]"
+        }
+      ],
+      "exports_delta": null,
+      "narrative": null
+    },
     {
       "$schema": "dovetail-release-event/v1",
       "event_id": "dovetail-core@0.0.99",