@temporalio/core-bridge 1.6.0 → 1.7.1

package/sdk-core/fsm/rustfsm_procmacro/src/lib.rs

@@ -64,21 +64,21 @@ use syn::{
 /// }
 ///
 /// impl Locked {
-///     fn on_card_readable(&self, shared_dat: SharedState, data: CardData)
+///     fn on_card_readable(&self, shared_dat: &mut SharedState, data: CardData)
 ///       -> CardReaderTransition<ReadingCardOrLocked> {
-///         match shared_dat.last_id {
+///         match &shared_dat.last_id {
 ///             // Arbitrarily deny the same person entering twice in a row
-///             Some(d) if d == data => TransitionResult::ok(vec![], Locked {}.into()),
+///             Some(d) if d == &data => TransitionResult::ok(vec![], Locked {}.into()),
 ///             _ => {
 ///                 // Otherwise issue a processing command. This illustrates using the same handler
 ///                 // for different destinations
-///                 TransitionResult::ok_shared(
+///                 shared_dat.last_id = Some(data.clone());
+///                 TransitionResult::ok(
 ///                     vec![
 ///                         Commands::ProcessData(data.clone()),
 ///                         Commands::StartBlinkingLight,
 ///                     ],
-///                     ReadingCard { card_data: data.clone() }.into(),
-///                     SharedState { last_id: Some(data) }
+///                     ReadingCard { card_data: data }.into(),
 ///                 )
 ///             }
 ///         }
@@ -96,19 +96,19 @@ use syn::{
 ///
 /// # fn main() -> Result<(), Box<dyn std::error::Error>> {
 /// let crs = CardReaderState::Locked(Locked {});
-/// let mut cr = CardReader { state: crs, shared_state: SharedState { last_id: None } };
-/// let cmds = cr.on_event_mut(CardReaderEvents::CardReadable("badguy".to_string()))?;
+/// let mut cr = CardReader::from_parts(crs, SharedState { last_id: None });
+/// let cmds = cr.on_event(CardReaderEvents::CardReadable("badguy".to_string()))?;
 /// assert_eq!(cmds[0], Commands::ProcessData("badguy".to_string()));
 /// assert_eq!(cmds[1], Commands::StartBlinkingLight);
 ///
-/// let cmds = cr.on_event_mut(CardReaderEvents::CardRejected)?;
+/// let cmds = cr.on_event(CardReaderEvents::CardRejected)?;
 /// assert_eq!(cmds[0], Commands::StopBlinkingLight);
 ///
-/// let cmds = cr.on_event_mut(CardReaderEvents::CardReadable("goodguy".to_string()))?;
+/// let cmds = cr.on_event(CardReaderEvents::CardReadable("goodguy".to_string()))?;
 /// assert_eq!(cmds[0], Commands::ProcessData("goodguy".to_string()));
 /// assert_eq!(cmds[1], Commands::StartBlinkingLight);
 ///
-/// let cmds = cr.on_event_mut(CardReaderEvents::CardAccepted)?;
+/// let cmds = cr.on_event(CardReaderEvents::CardAccepted)?;
 /// assert_eq!(cmds[0], Commands::StopBlinkingLight);
 /// # Ok(())
 /// # }
@@ -132,17 +132,17 @@ use syn::{
 /// The macro will generate a few things:
 /// * A struct for the overall state machine, named with the provided name. Here:
 ///   ```text
-///   struct CardMachine {
-///       state: CardMachineState,
-///       shared_state: CardId,
+///   struct CardReader {
+///       state: CardReaderState,
+///       shared_state: SharedState,
 ///   }
 ///   ```
 /// * An enum with a variant for each state, named with the provided name + "State".
 ///   ```text
-///   enum CardMachineState {
+///   enum CardReaderState {
 ///       Locked(Locked),
 ///       ReadingCard(ReadingCard),
-///       Unlocked(Unlocked),
+///       DoorOpen(DoorOpen),
 ///   }
 ///   ```
 ///
@@ -154,15 +154,18 @@ use syn::{
 /// * An enum with a variant for each event. You are expected to define the type (if any) contained
 ///   in the event variant.
 ///   ```text
-///   enum CardMachineEvents {
-///     CardReadable(CardData)
+///   enum CardReaderEvents {
+///     DoorClosed,
+///     CardAccepted,
+///     CardRejected,
+///     CardReadable(CardData),
 ///   }
 ///   ```
 /// * An implementation of the [StateMachine](trait.StateMachine.html) trait for the generated state
-///   machine enum (in this case, `CardMachine`)
+///   machine enum (in this case, `CardReader`)
 /// * A type alias for a [TransitionResult](enum.TransitionResult.html) with the appropriate generic
 ///   parameters set for your machine. It is named as your machine with `Transition` appended. In
-///   this case, `CardMachineTransition`.
+///   this case, `CardReaderTransition`.
 #[proc_macro]
 pub fn fsm(input: TokenStream) -> TokenStream {
     let def: StateMachineDefinition = parse_macro_input!(input as StateMachineDefinition);
@@ -217,7 +220,7 @@ impl Parse for StateMachineDefinition {
         // not ideal.
         let trans_set: HashSet<_> = transitions.iter().collect();
         if trans_set.len() != transitions.len() {
-            return Err(syn::Error::new(
+            return Err(Error::new(
                 input.span(),
                 "Duplicate transitions are not allowed!",
             ));
@@ -360,7 +363,7 @@ impl StateMachineDefinition {
         let machine_struct = quote! {
             #[derive(Clone)]
             #visibility struct #name {
-                state: #state_enum_name,
+                state: ::core::option::Option<#state_enum_name>,
                 shared_state: #shared_state_type
             }
         };
@@ -424,8 +427,18 @@ impl StateMachineDefinition {
                 statemap.insert(s.clone(), vec![]);
             }
         }
+        let transition_result_transform = quote! {
+            match res.into_cmd_result() {
+                Ok((cmds, state)) => {
+                    self.state = Some(state);
+                    Ok(cmds)
+                }
+                Err(e) => Err(e)
+            }
+        };
         let mut multi_dest_enums = vec![];
         let state_branches: Vec<_> = statemap.into_iter().map(|(from, transitions)| {
+            let occupied_current_state = quote! { Some(#state_enum_name::#from(state_data)) };
             // Merge transition dest states with the same handler
             let transitions = merge_transition_dests(transitions);
             let event_branches = transitions
@@ -467,27 +480,27 @@ impl StateMachineDefinition {
                         match ts.event.fields {
                             Fields::Unnamed(_) => {
                                 let arglist = if ts.mutates_shared {
-                                    quote! {self.shared_state, val}
+                                    quote! {&mut self.shared_state, val}
                                 } else {
                                     quote! {val}
                                 };
-                                quote_spanned! {span=>
+                                quote_spanned! { span =>
                                     #events_enum_name::#ev_variant(val) => {
                                         let res: #trans_type = state_data.#ts_fn(#arglist);
-                                        res.into_general()
+                                        #transition_result_transform
                                     }
                                 }
                             }
                             Fields::Unit => {
                                 let arglist = if ts.mutates_shared {
-                                    quote! {self.shared_state}
+                                    quote! {&mut self.shared_state}
                                 } else {
                                     quote! {}
                                 };
-                                quote_spanned! {span=>
+                                quote_spanned! { span =>
                                     #events_enum_name::#ev_variant => {
                                         let res: #trans_type = state_data.#ts_fn(#arglist);
-                                        res.into_general()
+                                        #transition_result_transform
                                     }
                                 }
                             }
@@ -498,39 +511,49 @@ impl StateMachineDefinition {
                         // using `Default`.
                         if let [new_state] = ts.to.as_slice() {
                             let span = new_state.span();
-                            let default_trans = quote_spanned! {span=>
-                            TransitionResult::<_, #new_state>::from::<#from>(state_data).into_general()
-                        };
+                            let default_trans = quote_spanned! { span =>
+                            let res = TransitionResult::<Self, #new_state>::from::<#from>(state_data);
+                                #transition_result_transform
+                            };
                             let span = ts.event.span();
                             match ts.event.fields {
-                                Fields::Unnamed(_) => quote_spanned! {span=>
-                                #events_enum_name::#ev_variant(_val) => {
-                                    #default_trans
-                                }
-                            },
-                                Fields::Unit => quote_spanned! {span=>
-                                #events_enum_name::#ev_variant => {
-                                    #default_trans
-                                }
-                            },
+                                Fields::Unnamed(_) => quote_spanned! { span =>
+                                    #events_enum_name::#ev_variant(_val) => {
+                                        #default_trans
+                                    }
+                                },
+                                Fields::Unit => quote_spanned! { span =>
+                                    #events_enum_name::#ev_variant => {
+                                        #default_trans
+                                    }
+                                },
                                 Fields::Named(_) => unreachable!(),
                             }
-
                         } else {
-                            unreachable!("It should be impossible to have more than one dest state in no-handler transitions")
+                            unreachable!("It should be impossible to have more than one dest state \
+                                          in no-handler transitions")
                         }
                     }
                 })
-                // Since most states won't handle every possible event, return an error to that effect
+                // Since most states won't handle every possible event, return an error to that
+                // effect
                 .chain(std::iter::once(
-                    quote! { _ => { return TransitionResult::InvalidTransition } },
+                    quote! { _ => {
+                        // Restore state in event the transition doesn't match
+                        self.state = #occupied_current_state;
+                        return Err(::rustfsm::MachineError::InvalidTransition)
+                    } },
                 ));
             quote! {
-                #state_enum_name::#from(state_data) => match event {
+                #occupied_current_state => match event {
                     #(#event_branches),*
                 }
             }
-        }).collect();
+        }).chain(std::iter::once(
+            quote! {
+                None => Err(::rustfsm::MachineError::InvalidTransition)
+            }
+        )).collect();
 
         let viz_str = self.visualize();
 
@@ -546,19 +569,21 @@ impl StateMachineDefinition {
                   #name_str
                 }
 
-                fn on_event(self, event: #events_enum_name)
-                  -> ::rustfsm::TransitionResult<Self, Self::State> {
-                    match self.state {
+                fn on_event(&mut self, event: #events_enum_name)
+                  -> ::core::result::Result<::std::vec::Vec<Self::Command>,
+                                            ::rustfsm::MachineError<Self::Error>> {
+                    let taken_state = self.state.take();
+                    match taken_state {
                         #(#state_branches),*
                     }
                 }
 
                 fn state(&self) -> &Self::State {
-                    &self.state
+                    self.state.as_ref().unwrap()
                 }
 
                 fn set_state(&mut self, new: Self::State) {
-                    self.state = new
+                    self.state = Some(new)
                 }
 
                 fn shared_state(&self) -> &Self::SharedState{
@@ -566,11 +591,11 @@ impl StateMachineDefinition {
                 }
 
                 fn has_reached_final_state(&self) -> bool {
-                    self.state.is_final()
+                    self.state.as_ref().unwrap().is_final()
                 }
 
-                fn from_parts(shared: Self::SharedState, state: Self::State) -> Self {
-                    Self { shared_state: shared, state }
+                fn from_parts(state: Self::State, shared: Self::SharedState) -> Self {
+                    Self { shared_state: shared, state: Some(state) }
                 }
 
                 fn visualizer() -> &'static str {

package/sdk-core/fsm/rustfsm_trait/src/lib.rs

@@ -19,44 +19,12 @@ pub trait StateMachine: Sized {
     /// The type used to represent commands the machine issues upon transitions.
     type Command;
 
-    /// Handle an incoming event, returning a transition result which represents updates to apply
-    /// to the state machine.
-    fn on_event(self, event: Self::Event) -> TransitionResult<Self, Self::State>;
-
-    /// Handle an incoming event and mutate the state machine to update to the new state and apply
-    /// any changes to shared state.
-    ///
-    /// Returns the commands issued by the transition on success, otherwise a [MachineError]
-    fn on_event_mut(
+    /// Handle an incoming event, returning any new commands or an error. Implementations may
+    /// mutate current state, possibly moving to a new state.
+    fn on_event(
         &mut self,
         event: Self::Event,
-    ) -> Result<Vec<Self::Command>, MachineError<Self::Error>>
-    where
-        Self: Clone,
-    {
-        // NOTE: This clone is actually nice in some sense, giving us a kind of transactionality.
-        //   However if there are really big things in state it could be an issue.
-        let res = self.clone().on_event(event);
-        match res {
-            TransitionResult::Ok {
-                commands,
-                new_state,
-                shared_state,
-            } => {
-                *self = Self::from_parts(shared_state, new_state);
-                Ok(commands)
-            }
-            TransitionResult::OkNoShare {
-                commands,
-                new_state,
-            } => {
-                self.set_state(new_state);
-                Ok(commands)
-            }
-            TransitionResult::InvalidTransition => Err(MachineError::InvalidTransition),
-            TransitionResult::Err(e) => Err(MachineError::Underlying(e)),
-        }
-    }
+    ) -> Result<Vec<Self::Command>, MachineError<Self::Error>>;
 
     fn name(&self) -> &str;
 
@@ -71,7 +39,7 @@ pub trait StateMachine: Sized {
     fn has_reached_final_state(&self) -> bool;
 
     /// Given the shared data and new state, create a new instance.
-    fn from_parts(shared: Self::SharedState, state: Self::State) -> Self;
+    fn from_parts(state: Self::State, shared: Self::SharedState) -> Self;
 
     /// Return a PlantUML definition of the fsm that can be used to visualize it
     fn visualizer() -> &'static str;
@@ -136,12 +104,6 @@ where
     Ok {
         commands: Vec<Machine::Command>,
         new_state: DestinationState,
-        shared_state: Machine::SharedState,
-    },
-    /// The transition was successful with no shared state change
-    OkNoShare {
-        commands: Vec<Machine::Command>,
-        new_state: DestinationState,
     },
     /// There was some error performing the transition
     Err(Machine::Error),
@@ -157,24 +119,10 @@ where
     pub fn ok<CI>(commands: CI, new_state: Ds) -> Self
     where
         CI: IntoIterator<Item = Sm::Command>,
-    {
-        Self::OkNoShare {
-            commands: commands.into_iter().collect(),
-            new_state,
-        }
-    }
-
-    /// Produce a transition with the provided commands to the provided state with shared state
-    /// changes
-    pub fn ok_shared<CI, SS>(commands: CI, new_state: Ds, new_shared: SS) -> Self
-    where
-        CI: IntoIterator<Item = Sm::Command>,
-        SS: Into<Sm::SharedState>,
     {
         Self::Ok {
             commands: commands.into_iter().collect(),
             new_state,
-            shared_state: new_shared.into(),
         }
     }
 
@@ -185,7 +133,7 @@ where
         CurrentState: Into<Ds>,
     {
         let as_dest: Ds = current_state.into();
-        Self::OkNoShare {
+        Self::Ok {
             commands: vec![],
             new_state: as_dest,
         }
@@ -202,7 +150,7 @@ where
     where
         CI: IntoIterator<Item = Sm::Command>,
     {
-        Self::OkNoShare {
+        Self::Ok {
             commands: commands.into_iter().collect(),
             new_state: Ds::default(),
         }
@@ -215,7 +163,7 @@ where
     Ds: Into<Sm::State> + Default,
 {
     fn default() -> Self {
-        Self::OkNoShare {
+        Self::Ok {
             commands: vec![],
             new_state: Ds::default(),
         }
@@ -234,20 +182,26 @@ where
             TransitionResult::Ok {
                 commands,
                 new_state,
-                shared_state,
             } => TransitionResult::Ok {
                 commands,
                 new_state: new_state.into(),
-                shared_state,
             },
-            TransitionResult::OkNoShare {
-                commands,
+            TransitionResult::Err(e) => TransitionResult::Err(e),
+        }
+    }
+
+    /// Transforms the transition result into a machine-ready outcome with commands and new state,
+    /// or a [MachineError]
+    #[allow(clippy::type_complexity)]
+    pub fn into_cmd_result(self) -> Result<(Vec<Sm::Command>, Sm::State), MachineError<Sm::Error>> {
+        let general = self.into_general();
+        match general {
+            TransitionResult::Ok {
                 new_state,
-            } => TransitionResult::OkNoShare {
                 commands,
-                new_state: new_state.into(),
-            },
-            TransitionResult::Err(e) => TransitionResult::Err(e),
+            } => Ok((commands, new_state)),
+            TransitionResult::InvalidTransition => Err(MachineError::InvalidTransition),
+            TransitionResult::Err(e) => Err(MachineError::Underlying(e)),
         }
     }
 }

package/sdk-core/protos/api_upstream/.github/CODEOWNERS

@@ -1,4 +1,5 @@
 # Syntax is here:
 # https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners#codeowners-syntax
 
-* @temporalio/server @temporalio/sdk
+*                       @temporalio/server @temporalio/sdk
+api/temporal/api/sdk/*  @temporalio/sdk

package/sdk-core/protos/api_upstream/Makefile

@@ -37,7 +37,7 @@ go-grpc: clean $(PROTO_OUT)
 
 gogo-grpc: clean $(PROTO_OUT)
 	printf $(COLOR) "Compile for gogo-gRPC..."
-	$(foreach PROTO_DIR,$(PROTO_DIRS),protoc --fatal_warnings $(PROTO_IMPORTS) --gogoslick_out=Mgoogle/protobuf/wrappers.proto=github.com/gogo/protobuf/types,Mgoogle/protobuf/duration.proto=github.com/gogo/protobuf/types,Mgoogle/protobuf/descriptor.proto=github.com/golang/protobuf/protoc-gen-go/descriptor,Mgoogle/protobuf/timestamp.proto=github.com/gogo/protobuf/types,plugins=grpc,paths=source_relative:$(PROTO_OUT) $(PROTO_DIR)*.proto;)
+	$(foreach PROTO_DIR,$(PROTO_DIRS),protoc --fatal_warnings $(PROTO_IMPORTS) --gogoslick_out=Mgoogle/protobuf/any.proto=github.com/gogo/protobuf/types,Mgoogle/protobuf/wrappers.proto=github.com/gogo/protobuf/types,Mgoogle/protobuf/duration.proto=github.com/gogo/protobuf/types,Mgoogle/protobuf/descriptor.proto=github.com/golang/protobuf/protoc-gen-go/descriptor,Mgoogle/protobuf/timestamp.proto=github.com/gogo/protobuf/types,plugins=grpc,paths=source_relative:$(PROTO_OUT) $(PROTO_DIR)*.proto;)
 
 fix-path:
 	mv -f $(PROTO_OUT)/temporal/api/* $(PROTO_OUT) && rm -rf $(PROTO_OUT)/temporal

package/sdk-core/protos/api_upstream/temporal/api/command/v1/message.proto

@@ -39,7 +39,6 @@ import "temporal/api/enums/v1/workflow.proto";
 import "temporal/api/enums/v1/command_type.proto";
 import "temporal/api/common/v1/message.proto";
 import "temporal/api/failure/v1/message.proto";
-import "temporal/api/interaction/v1/message.proto";
 import "temporal/api/taskqueue/v1/message.proto";
 
 message ScheduleActivityTaskCommandAttributes {
@@ -221,19 +220,9 @@ message StartChildWorkflowExecutionCommandAttributes {
     temporal.api.common.v1.SearchAttributes search_attributes = 16;
 }
 
-message AcceptWorkflowUpdateCommandAttributes {
-    temporal.api.interaction.v1.Meta meta = 1;
-    temporal.api.interaction.v1.Input input = 2;
-}
-
-message CompleteWorkflowUpdateCommandAttributes {
-    temporal.api.interaction.v1.Meta meta = 1;
-    temporal.api.interaction.v1.Output output = 2;
-}
-
-message RejectWorkflowUpdateCommandAttributes {
-    temporal.api.interaction.v1.Meta meta = 1;
-    temporal.api.failure.v1.Failure failure = 2;
+message ProtocolMessageCommandAttributes {
+    // The message ID of the message to which this command is a pointer.
+    string message_id = 1;
 }
 
 message Command {
@@ -252,9 +241,8 @@ message Command {
         StartChildWorkflowExecutionCommandAttributes start_child_workflow_execution_command_attributes = 12;
         SignalExternalWorkflowExecutionCommandAttributes signal_external_workflow_execution_command_attributes = 13;
         UpsertWorkflowSearchAttributesCommandAttributes upsert_workflow_search_attributes_command_attributes = 14;
-        AcceptWorkflowUpdateCommandAttributes accept_workflow_update_command_attributes = 15;
-        CompleteWorkflowUpdateCommandAttributes complete_workflow_update_command_attributes = 16;
+        ProtocolMessageCommandAttributes protocol_message_command_attributes = 15;
+        // 16 is available for use - it was used as part of a prototype that never made it into a release
         ModifyWorkflowPropertiesCommandAttributes modify_workflow_properties_command_attributes = 17;
-        RejectWorkflowUpdateCommandAttributes reject_workflow_update_command_attributes = 18;
     }
 }

package/sdk-core/protos/api_upstream/temporal/api/common/v1/message.proto

@@ -110,3 +110,14 @@ message RetryPolicy {
     // this is not a substring match, the error *type* (not message) must match exactly.
     repeated string non_retryable_error_types = 5;
 }
+
+// Metadata relevant for metering purposes
+message MeteringMetadata {
+    // Count of local activities which have begun an execution attempt during this workflow task,
+    // and whose first attempt occurred in some previous task. This is used for metering
+    // purposes, and does not affect workflow state.
+    //
+    // (-- api-linter: core::0141::forbidden-types=disabled
+    //     aip.dev/not-precedent: Negative values make no sense to represent. --)
+    uint32 nonfirst_local_activity_execution_attempts = 13;
+}

package/sdk-core/protos/api_upstream/temporal/api/enums/v1/command_type.proto

@@ -47,11 +47,6 @@ enum CommandType {
     COMMAND_TYPE_START_CHILD_WORKFLOW_EXECUTION = 11;
     COMMAND_TYPE_SIGNAL_EXTERNAL_WORKFLOW_EXECUTION = 12;
     COMMAND_TYPE_UPSERT_WORKFLOW_SEARCH_ATTRIBUTES = 13;
-    // Indicates that an update has been accepted for processing workflow code
-    COMMAND_TYPE_ACCEPT_WORKFLOW_UPDATE = 14;
-    // Indicates that an update has completed and carries either the success or
-    // failure outcome of said update.
-    COMMAND_TYPE_COMPLETE_WORKFLOW_UPDATE = 15;
+    COMMAND_TYPE_PROTOCOL_MESSAGE = 14;
     COMMAND_TYPE_MODIFY_WORKFLOW_PROPERTIES = 16;
-    COMMAND_TYPE_REJECT_WORKFLOW_UPDATE = 17;
 }

package/sdk-core/protos/api_upstream/temporal/api/enums/v1/event_type.proto

@@ -151,12 +151,12 @@ enum EventType {
     EVENT_TYPE_EXTERNAL_WORKFLOW_EXECUTION_SIGNALED = 39;
     // Workflow search attributes should be updated and synchronized with the visibility store
     EVENT_TYPE_UPSERT_WORKFLOW_SEARCH_ATTRIBUTES = 40;
-    // Workflow update request has been received
-    EVENT_TYPE_WORKFLOW_UPDATE_REJECTED = 41;
-    // Workflow update request has been accepted by user workflow code
-    EVENT_TYPE_WORKFLOW_UPDATE_ACCEPTED = 42;
-    // Workflow update has been completed
-    EVENT_TYPE_WORKFLOW_UPDATE_COMPLETED = 43;
+    // An update was accepted (i.e. validated)
+    EVENT_TYPE_WORKFLOW_EXECUTION_UPDATE_ACCEPTED = 41;
+    // An update was rejected (i.e. failed validation)
+    EVENT_TYPE_WORKFLOW_EXECUTION_UPDATE_REJECTED = 42;
+    // An update completed
+    EVENT_TYPE_WORKFLOW_EXECUTION_UPDATE_COMPLETED = 43;
     // Some property or properties of the workflow as a whole have changed by non-workflow code.
     // The distinction of external vs. command-based modification is important so the SDK can
     // maintain determinism when using the command-based approach.

package/sdk-core/protos/api_upstream/temporal/api/enums/v1/failed_cause.proto

@@ -85,6 +85,11 @@ enum WorkflowTaskFailedCause {
     // Similarly, we have a buffer of pending requests to cancel other workflows. We return this error
     // when our capacity for pending cancel requests is already reached.
     WORKFLOW_TASK_FAILED_CAUSE_PENDING_REQUEST_CANCEL_LIMIT_EXCEEDED = 29;
+    // Workflow execution update message (update.Acceptance, update.Rejection, or update.Response)
+    // has wrong format, or missing required fields.
+    WORKFLOW_TASK_FAILED_CAUSE_BAD_UPDATE_WORKFLOW_EXECUTION_MESSAGE = 30;
+    // Similar to WORKFLOW_TASK_FAILED_CAUSE_UNHANDLED_COMMAND, but for updates.
+    WORKFLOW_TASK_FAILED_CAUSE_UNHANDLED_UPDATE = 31;
 }
 
 enum StartChildWorkflowExecutionFailedCause {

package/sdk-core/protos/api_upstream/temporal/api/enums/v1/update.proto

@@ -31,10 +31,26 @@ option java_outer_classname = "UpdateProto";
 option ruby_package = "Temporalio::Api::Enums::V1";
 option csharp_namespace = "Temporalio.Api.Enums.V1";
 
-enum WorkflowUpdateResultAccessStyle {
-    WORKFLOW_UPDATE_RESULT_ACCESS_STYLE_UNSPECIFIED = 0;
-
-    // Indicates that the update response _must_ be included as part of the gRPC
-    // response body
-    WORKFLOW_UPDATE_RESULT_ACCESS_STYLE_REQUIRE_INLINE = 1;
+// UpdateWorkflowExecutionLifecycleStage is specified by clients invoking
+// workflow execution updates and used to indicate to the server how long the
+// client wishes to wait for a return value from the RPC. If any value other
+// than UPDATE_WORKFLOW_EXECUTION_LIFECYCLE_STAGE_COMPLETED is sent by the
+// client then the RPC will complete before the update is finished and will
+// return a handle to the running update so that it can later be polled for
+// completion.
+enum UpdateWorkflowExecutionLifecycleStage {
+    // An unspecified vale for this enum.
+    UPDATE_WORKFLOW_EXECUTION_LIFECYCLE_STAGE_UNSPECIFIED = 0;
+    // The gRPC call will not return until the update request has been admitted
+    // by the server - it may be the case that due to a considerations like load
+    // or resource limits that an update is made to wait before the server will
+    // indicate that it has been received and will be processed. This value
+    // does not wait for any sort of acknowledgement from a worker.
+    UPDATE_WORKFLOW_EXECUTION_LIFECYCLE_STAGE_ADMITTED = 1;
+    // The gRPC call will not return until the update has passed validation on
+    // a worker.
+    UPDATE_WORKFLOW_EXECUTION_LIFECYCLE_STAGE_ACCEPTED = 2;
+    // The gRPC call will not return until the update has executed to completion
+    // on a worker and has either been rejected or returned a value or an error.
+    UPDATE_WORKFLOW_EXECUTION_LIFECYCLE_STAGE_COMPLETED = 3;
 }