@temporalio/core-bridge 1.14.2-canary-release-testing.0 → 1.16.0

package/sdk-core/crates/common/src/priority.rs

@@ -0,0 +1,110 @@
+use crate::protos::temporal::api::common;
+
+/// Priority contains metadata that controls relative ordering of task processing
+/// when tasks are backlogged in a queue. Initially, Priority will be used in
+/// activity and workflow task queues, which are typically where backlogs exist.
+/// Other queues in the server (such as transfer and timer queues) and rate
+/// limiting decisions do not use Priority, but may in the future.
+///
+/// Priority is attached to workflows and activities. Activities and child
+/// workflows inherit Priority from the workflow that created them, but may
+/// override fields when they are started or modified.
+///
+/// All fields default to `None`, which means "inherit from the calling workflow"
+/// or, if there is no calling workflow, "use the server default."
+///
+/// Despite being named "Priority", this type also contains fields that
+/// control "fairness" mechanisms.
+///
+/// The overall semantics of Priority are:
+/// (more will be added here later)
+/// 1. First, consider "priority_key": lower number goes first.
+#[derive(Debug, Clone, Default, PartialEq)]
+pub struct Priority {
+    /// Priority key is a positive integer from 1 to n, where smaller integers
+    /// correspond to higher priorities (tasks run sooner). In general, tasks in
+    /// a queue should be processed in close to priority order, although small
+    /// deviations are possible.
+    ///
+    /// The maximum priority value (minimum priority) is determined by server
+    /// configuration, and defaults to 5.
+    ///
+    /// The server default priority is `(min + max) / 2`. With the default max
+    /// of 5 and min of 1, that comes out to 3.
+    ///
+    /// `None` means inherit from the calling workflow or use the server default.
+    pub priority_key: Option<u32>,
+
+    /// Fairness key is a short string that's used as a key for a fairness
+    /// balancing mechanism. It may correspond to a tenant id, or to a fixed
+    /// string like "high" or "low".
+    ///
+    /// The fairness mechanism attempts to dispatch tasks for a given key in
+    /// proportion to its weight. For example, using a thousand distinct tenant
+    /// ids, each with a weight of 1.0 (the default) will result in each tenant
+    /// getting a roughly equal share of task dispatch throughput.
+    ///
+    /// (Note: this does not imply equal share of worker capacity! Fairness
+    /// decisions are made based on queue statistics, not current worker load.)
+    ///
+    /// As another example, using keys "high" and "low" with weight 9.0 and 1.0
+    /// respectively will prefer dispatching "high" tasks over "low" tasks at a
+    /// 9:1 ratio, while allowing either key to use all worker capacity if the
+    /// other is not present.
+    ///
+    /// All fairness mechanisms, including rate limits, are best-effort and
+    /// probabilistic. The results may not match what a "perfect" algorithm with
+    /// infinite resources would produce. The more unique keys are used, the less
+    /// accurate the results will be.
+    ///
+    /// Fairness keys are limited to 64 bytes.
+    ///
+    /// `None` means inherit from the calling workflow or use the server default
+    /// (empty string).
+    pub fairness_key: Option<String>,
+
+    /// Fairness weight for a task can come from multiple sources for
+    /// flexibility. From highest to lowest precedence:
+    /// 1. Weights for a small set of keys can be overridden in task queue
+    ///    configuration with an API.
+    /// 2. It can be attached to the workflow/activity in this field.
+    /// 3. The server default weight of 1.0 will be used.
+    ///
+    /// Weight values are clamped by the server to the range \[0.001, 1000\].
+    ///
+    /// `None` means inherit from the calling workflow or use the server default
+    /// (1.0).
+    pub fairness_weight: Option<f32>,
+}
+
+impl From<Priority> for common::v1::Priority {
+    fn from(priority: Priority) -> Self {
+        common::v1::Priority {
+            priority_key: priority.priority_key.unwrap_or(0) as i32,
+            fairness_key: priority.fairness_key.unwrap_or_default(),
+            fairness_weight: priority.fairness_weight.unwrap_or(0.0),
+        }
+    }
+}
+
+impl From<common::v1::Priority> for Priority {
+    fn from(priority: common::v1::Priority) -> Self {
+        Self {
+            priority_key: if priority.priority_key == 0 {
+                None
+            } else {
+                Some(priority.priority_key as u32)
+            },
+            fairness_key: if priority.fairness_key.is_empty() {
+                None
+            } else {
+                Some(priority.fairness_key)
+            },
+            fairness_weight: if priority.fairness_weight == 0.0 {
+                None
+            } else {
+                Some(priority.fairness_weight)
+            },
+        }
+    }
+}

package/sdk-core/crates/common/src/protos/canned_histories.rs

@@ -30,6 +30,7 @@ pub fn single_timer(timer_id: &str) -> TestHistoryBuilder {
     t
 }
 
+/// Like [`single_timer`] but also completes the workflow.
 pub fn single_timer_wf_completes(timer_id: &str) -> TestHistoryBuilder {
     let mut t = single_timer(timer_id);
     t.add_workflow_task_completed();
@@ -272,6 +273,7 @@ pub fn cancel_scheduled_activity(activity_id: &str, signal_id: &str) -> TestHist
         vec![Payload {
             metadata: Default::default(),
             data: b"hello ".to_vec(),
+            external_payloads: Default::default(),
         }],
     );
     t.add_full_wf_task();
@@ -343,6 +345,7 @@ pub fn scheduled_cancelled_activity_timeout(
         vec![Payload {
             metadata: Default::default(),
             data: b"hello ".to_vec(),
+            external_payloads: Default::default(),
         }],
     );
     t.add_full_wf_task();
@@ -421,6 +424,7 @@ pub fn cancel_scheduled_activity_abandon(activity_id: &str, signal_id: &str) ->
         vec![Payload {
             metadata: Default::default(),
             data: b"hello ".to_vec(),
+            external_payloads: Default::default(),
         }],
     );
     t.add_full_wf_task();
@@ -453,6 +457,7 @@ pub fn cancel_started_activity_abandon(activity_id: &str, signal_id: &str) -> Te
         vec![Payload {
             metadata: Default::default(),
             data: b"hello ".to_vec(),
+            external_payloads: Default::default(),
         }],
     );
     t.add_full_wf_task();
@@ -492,6 +497,7 @@ pub fn cancel_scheduled_activity_with_signal_and_activity_task_cancel(
         vec![Payload {
             metadata: Default::default(),
             data: b"hello ".to_vec(),
+            external_payloads: Default::default(),
         }],
     );
     t.add_full_wf_task();
@@ -508,6 +514,7 @@ pub fn cancel_scheduled_activity_with_signal_and_activity_task_cancel(
         vec![Payload {
             metadata: Default::default(),
             data: b"hello ".to_vec(),
+            external_payloads: Default::default(),
         }],
     );
     t.add_full_wf_task();
@@ -561,6 +568,7 @@ pub fn cancel_started_activity_with_signal_and_activity_task_cancel(
         vec![Payload {
             metadata: Default::default(),
             data: b"hello ".to_vec(),
+            external_payloads: Default::default(),
         }],
     );
     t.add_full_wf_task();
@@ -577,6 +585,7 @@ pub fn cancel_started_activity_with_signal_and_activity_task_cancel(
         vec![Payload {
             metadata: Default::default(),
             data: b"hello ".to_vec(),
+            external_payloads: Default::default(),
         }],
     );
     t.add_full_wf_task();
@@ -621,6 +630,7 @@ pub fn cancel_scheduled_activity_with_activity_task_cancel(
         vec![Payload {
             metadata: Default::default(),
             data: b"hello ".to_vec(),
+            external_payloads: Default::default(),
         }],
     );
     t.add_full_wf_task();
@@ -678,6 +688,7 @@ pub fn cancel_started_activity_with_activity_task_cancel(
         vec![Payload {
             metadata: Default::default(),
             data: b"hello ".to_vec(),
+            external_payloads: Default::default(),
         }],
     );
     t.add_full_wf_task();
@@ -720,6 +731,7 @@ pub fn two_signals(sig_1_id: &str, sig_2_id: &str) -> TestHistoryBuilder {
         vec![Payload {
             metadata: Default::default(),
             data: b"hello ".to_vec(),
+            external_payloads: Default::default(),
         }],
     );
     t.add_we_signaled(
@@ -727,6 +739,7 @@ pub fn two_signals(sig_1_id: &str, sig_2_id: &str) -> TestHistoryBuilder {
         vec![Payload {
             metadata: Default::default(),
             data: b"world".to_vec(),
+            external_payloads: Default::default(),
         }],
     );
     t.add_workflow_task_scheduled_and_started();
@@ -777,6 +790,7 @@ pub fn lots_of_big_signals(num_tasks: usize) -> TestHistoryBuilder {
                 vec![Payload {
                     metadata: Default::default(),
                     data: dat.into(),
+                    external_payloads: Default::default(),
                 }],
             );
         }
@@ -846,6 +860,7 @@ pub fn cancel_not_sent_when_also_complete_repro() -> TestHistoryBuilder {
         vec![Payload {
             metadata: Default::default(),
             data: b"hello ".to_vec(),
+            external_payloads: Default::default(),
         }],
     );
     t.add_full_wf_task();
@@ -896,6 +911,7 @@ pub fn wft_timeout_repro() -> TestHistoryBuilder {
         vec![Payload {
             metadata: Default::default(),
             data: b"hello ".to_vec(),
+            external_payloads: Default::default(),
         }],
     );
     t.add_workflow_task_scheduled();
@@ -904,6 +920,7 @@ pub fn wft_timeout_repro() -> TestHistoryBuilder {
         vec![Payload {
             metadata: Default::default(),
             data: b"hello ".to_vec(),
+            external_payloads: Default::default(),
         }],
     );
     let started_event_id = t.add(ActivityTaskStartedEventAttributes {
@@ -958,12 +975,14 @@ pub fn timer_then_continue_as_new(timer_id: &str) -> TestHistoryBuilder {
 pub fn timer_wf_cancel_req_cancelled(timer_id: &str) -> TestHistoryBuilder {
     timer_cancel_req_then(timer_id, TestHistoryBuilder::add_cancelled)
 }
+/// Timer with cancel request followed by workflow execution completed.
 pub fn timer_wf_cancel_req_completed(timer_id: &str) -> TestHistoryBuilder {
     timer_cancel_req_then(
         timer_id,
         TestHistoryBuilder::add_workflow_execution_completed,
     )
 }
+/// Timer with cancel request followed by workflow execution failed.
 pub fn timer_wf_cancel_req_failed(timer_id: &str) -> TestHistoryBuilder {
     timer_cancel_req_then(timer_id, TestHistoryBuilder::add_workflow_execution_failed)
 }

package/sdk-core/crates/common/src/protos/history_builder.rs

@@ -30,11 +30,14 @@ use std::{
 };
 use uuid::Uuid;
 
+/// The workflow type name used by default in test histories.
 pub static DEFAULT_WORKFLOW_TYPE: &str = "default_wf_type";
+/// The activity type name used by default in test histories.
 pub static DEFAULT_ACTIVITY_TYPE: &str = "default_act_type";
 
 type Result<T, E = anyhow::Error> = std::result::Result<T, E>;
 
+/// Builder for constructing synthetic workflow histories for testing.
 #[derive(Default, Clone, Debug)]
 pub struct TestHistoryBuilder {
     events: Vec<HistoryEvent>,
@@ -48,6 +51,7 @@ pub struct TestHistoryBuilder {
 }
 
 impl TestHistoryBuilder {
+    /// Construct from a pre-existing list of history events.
     pub fn from_history(events: Vec<HistoryEvent>) -> Self {
         let find_matching_id = |etype: EventType| {
             events
@@ -96,15 +100,18 @@ impl TestHistoryBuilder {
         self.add_workflow_task_completed();
     }
 
+    /// Add workflow task scheduled and started events.
     pub fn add_workflow_task_scheduled_and_started(&mut self) {
         self.add_workflow_task_scheduled();
         self.add_workflow_task_started();
     }
 
+    /// Add a workflow task scheduled event.
     pub fn add_workflow_task_scheduled(&mut self) {
         self.workflow_task_scheduled_event_id = self.add_by_type(EventType::WorkflowTaskScheduled);
     }
 
+    /// Add a workflow task started event.
     pub fn add_workflow_task_started(&mut self) {
         self.final_workflow_task_started_event_id = self.add(WorkflowTaskStartedEventAttributes {
             scheduled_event_id: self.workflow_task_scheduled_event_id,
@@ -113,6 +120,7 @@ impl TestHistoryBuilder {
         });
     }
 
+    /// Add a workflow task completed event.
     pub fn add_workflow_task_completed(&mut self) {
         let id = self.add(WorkflowTaskCompletedEventAttributes {
             scheduled_event_id: self.workflow_task_scheduled_event_id,
@@ -121,6 +129,7 @@ impl TestHistoryBuilder {
         self.previous_task_completed_id = id;
     }
 
+    /// Add a workflow task timed out event.
     pub fn add_workflow_task_timed_out(&mut self) {
         let attrs = WorkflowTaskTimedOutEventAttributes {
             scheduled_event_id: self.workflow_task_scheduled_event_id,
@@ -129,6 +138,7 @@ impl TestHistoryBuilder {
         self.build_and_push_event(EventType::WorkflowTaskTimedOut, attrs.into());
     }
 
+    /// Add a workflow execution completed event.
     pub fn add_workflow_execution_completed(&mut self) {
         let attrs = WorkflowExecutionCompletedEventAttributes {
             workflow_task_completed_event_id: self.previous_task_completed_id,
@@ -137,6 +147,7 @@ impl TestHistoryBuilder {
         self.build_and_push_event(EventType::WorkflowExecutionCompleted, attrs.into());
     }
 
+    /// Add a workflow execution terminated event.
     pub fn add_workflow_execution_terminated(&mut self) {
         let attrs = WorkflowExecutionTerminatedEventAttributes {
             ..Default::default()
@@ -144,6 +155,7 @@ impl TestHistoryBuilder {
         self.build_and_push_event(EventType::WorkflowExecutionTerminated, attrs.into());
     }
 
+    /// Add a workflow execution timed out event.
     pub fn add_workflow_execution_timed_out(&mut self) {
         let attrs = WorkflowExecutionTimedOutEventAttributes {
             ..Default::default()
@@ -151,6 +163,7 @@ impl TestHistoryBuilder {
         self.build_and_push_event(EventType::WorkflowExecutionTimedOut, attrs.into());
     }
 
+    /// Add a workflow execution failed event.
     pub fn add_workflow_execution_failed(&mut self) {
         let attrs = WorkflowExecutionFailedEventAttributes {
             workflow_task_completed_event_id: self.previous_task_completed_id,
@@ -159,21 +172,25 @@ impl TestHistoryBuilder {
         self.build_and_push_event(EventType::WorkflowExecutionFailed, attrs.into());
     }
 
+    /// Add a workflow execution continued-as-new event.
     pub fn add_continued_as_new(&mut self) {
         let attrs = WorkflowExecutionContinuedAsNewEventAttributes::default();
         self.build_and_push_event(EventType::WorkflowExecutionContinuedAsNew, attrs.into());
     }
 
+    /// Add a workflow execution cancel-requested event.
     pub fn add_cancel_requested(&mut self) {
         let attrs = WorkflowExecutionCancelRequestedEventAttributes::default();
         self.build_and_push_event(EventType::WorkflowExecutionCancelRequested, attrs.into());
     }
 
+    /// Add a workflow execution canceled event.
     pub fn add_cancelled(&mut self) {
         let attrs = WorkflowExecutionCanceledEventAttributes::default();
         self.build_and_push_event(EventType::WorkflowExecutionCanceled, attrs.into());
     }
 
+    /// Add an activity task scheduled event, returning the event ID.
     pub fn add_activity_task_scheduled(&mut self, activity_id: impl Into<String>) -> i64 {
         self.add(ActivityTaskScheduledEventAttributes {
             activity_id: activity_id.into(),
@@ -184,6 +201,7 @@ impl TestHistoryBuilder {
         })
     }
 
+    /// Add an activity task started event, returning the event ID.
     pub fn add_activity_task_started(&mut self, scheduled_event_id: i64) -> i64 {
         self.add(Attributes::ActivityTaskStartedEventAttributes(
             ActivityTaskStartedEventAttributes {
@@ -193,6 +211,7 @@ impl TestHistoryBuilder {
         ))
     }
 
+    /// Add an activity task completed event.
     pub fn add_activity_task_completed(
         &mut self,
         scheduled_event_id: i64,
@@ -207,6 +226,7 @@ impl TestHistoryBuilder {
         });
     }
 
+    /// Add an activity task cancel-requested event.
     pub fn add_activity_task_cancel_requested(&mut self, scheduled_event_id: i64) {
         let attrs = ActivityTaskCancelRequestedEventAttributes {
             scheduled_event_id,
@@ -215,6 +235,7 @@ impl TestHistoryBuilder {
         self.build_and_push_event(EventType::ActivityTaskCancelRequested, attrs.into());
     }
 
+    /// Add a workflow task failed event with a specific failure.
     pub fn add_workflow_task_failed_with_failure(
         &mut self,
         cause: WorkflowTaskFailedCause,
@@ -229,6 +250,7 @@ impl TestHistoryBuilder {
         self.build_and_push_event(EventType::WorkflowTaskFailed, attrs.into());
     }
 
+    /// Add a workflow task failed event with a new run ID.
     pub fn add_workflow_task_failed_new_id(
         &mut self,
         cause: WorkflowTaskFailedCause,
@@ -243,6 +265,7 @@ impl TestHistoryBuilder {
         self.build_and_push_event(EventType::WorkflowTaskFailed, attrs.into());
     }
 
+    /// Add a timer started event, returning the event ID.
     pub fn add_timer_started(&mut self, timer_id: String) -> i64 {
         self.add(TimerStartedEventAttributes {
             timer_id,
@@ -251,6 +274,7 @@ impl TestHistoryBuilder {
         })
     }
 
+    /// Add a timer fired event.
     pub fn add_timer_fired(&mut self, timer_started_evt_id: i64, timer_id: String) {
         self.add(TimerFiredEventAttributes {
             started_event_id: timer_started_evt_id,
@@ -258,6 +282,7 @@ impl TestHistoryBuilder {
         });
     }
 
+    /// Add a workflow execution signaled event.
     pub fn add_we_signaled(&mut self, signal_name: &str, payloads: Vec<Payload>) {
         let attrs = WorkflowExecutionSignaledEventAttributes {
             signal_name: signal_name.to_string(),
@@ -267,6 +292,7 @@ impl TestHistoryBuilder {
         self.build_and_push_event(EventType::WorkflowExecutionSignaled, attrs.into());
     }
 
+    /// Add a patch (has-change) marker event.
     pub fn add_has_change_marker(&mut self, patch_id: &str, deprecated: bool) {
         let attrs = MarkerRecordedEventAttributes {
             marker_name: PATCH_MARKER_NAME.to_string(),
@@ -277,6 +303,7 @@ impl TestHistoryBuilder {
         self.build_and_push_event(EventType::MarkerRecorded, attrs.into());
     }
 
+    /// Add a local activity marker event with optional payload/failure.
     pub fn add_local_activity_marker(
         &mut self,
         seq: u32,
@@ -305,6 +332,7 @@ impl TestHistoryBuilder {
         self.build_and_push_event(EventType::MarkerRecorded, attrs.into());
     }
 
+    /// Add a local activity result marker with a successful payload.
     pub fn add_local_activity_result_marker(
         &mut self,
         seq: u32,
@@ -314,6 +342,7 @@ impl TestHistoryBuilder {
         self.add_local_activity_marker(seq, activity_id, Some(payload), None, |_| {});
     }
 
+    /// Add a local activity result marker with a specific completion time.
     pub fn add_local_activity_result_marker_with_time(
         &mut self,
         seq: u32,
@@ -326,6 +355,7 @@ impl TestHistoryBuilder {
         });
     }
 
+    /// Add a local activity failure marker.
     pub fn add_local_activity_fail_marker(
         &mut self,
         seq: u32,
@@ -335,6 +365,7 @@ impl TestHistoryBuilder {
         self.add_local_activity_marker(seq, activity_id, None, Some(failure), |_| {});
     }
 
+    /// Add a local activity cancellation marker.
     pub fn add_local_activity_cancel_marker(&mut self, seq: u32, activity_id: &str) {
         self.add_local_activity_marker(
             seq,
@@ -354,6 +385,7 @@ impl TestHistoryBuilder {
         );
     }
 
+    /// Add an external signal workflow initiation event, returning the event ID.
     pub fn add_signal_wf(
         &mut self,
         signal_name: impl Into<String>,
@@ -371,6 +403,7 @@ impl TestHistoryBuilder {
         })
     }
 
+    /// Add an external workflow execution signaled event.
     pub fn add_external_signal_completed(&mut self, initiated_id: i64) {
         let attrs = ExternalWorkflowExecutionSignaledEventAttributes {
             initiated_event_id: initiated_id,
@@ -379,6 +412,7 @@ impl TestHistoryBuilder {
         self.build_and_push_event(EventType::ExternalWorkflowExecutionSignaled, attrs.into());
     }
 
+    /// Add a signal external workflow execution failed event.
     pub fn add_external_signal_failed(&mut self, initiated_id: i64) {
         let attrs = SignalExternalWorkflowExecutionFailedEventAttributes {
             initiated_event_id: initiated_id,
@@ -390,6 +424,7 @@ impl TestHistoryBuilder {
         );
     }
 
+    /// Add a cancel external workflow initiation event, returning the event ID.
     pub fn add_cancel_external_wf(&mut self, execution: NamespacedWorkflowExecution) -> i64 {
         self.add(
             RequestCancelExternalWorkflowExecutionInitiatedEventAttributes {
@@ -404,6 +439,7 @@ impl TestHistoryBuilder {
         )
     }
 
+    /// Add a cancel external workflow completed event.
     pub fn add_cancel_external_wf_completed(&mut self, initiated_id: i64) {
         let attrs = ExternalWorkflowExecutionCancelRequestedEventAttributes {
             initiated_event_id: initiated_id,
@@ -415,6 +451,7 @@ impl TestHistoryBuilder {
         );
     }
 
+    /// Add a cancel external workflow failed event.
     pub fn add_cancel_external_wf_failed(&mut self, initiated_id: i64) {
         let attrs = RequestCancelExternalWorkflowExecutionFailedEventAttributes {
             initiated_event_id: initiated_id,
@@ -426,12 +463,14 @@ impl TestHistoryBuilder {
         );
     }
 
+    /// Add a workflow execution started event with a custom workflow task timeout.
     pub fn add_wfe_started_with_wft_timeout(&mut self, dur: Duration) {
         let mut wesattrs = default_wes_attribs();
         wesattrs.workflow_task_timeout = Some(dur.try_into().unwrap());
         self.add(wesattrs);
     }
 
+    /// Add an upsert search attributes event for a patch marker.
     pub fn add_upsert_search_attrs_for_patch(&mut self, attribs: &[String]) {
         let mut indexed_fields = HashMap::new();
         indexed_fields.insert(
@@ -445,6 +484,7 @@ impl TestHistoryBuilder {
         self.build_and_push_event(EventType::UpsertWorkflowSearchAttributes, attrs.into());
     }
 
+    /// Add a workflow execution update accepted event, returning the event ID.
     pub fn add_update_accepted(
         &mut self,
         instance_id: impl Into<String>,
@@ -482,6 +522,7 @@ impl TestHistoryBuilder {
         self.build_and_push_event(EventType::WorkflowExecutionUpdateAccepted, attrs.into())
     }
 
+    /// Add a workflow execution update completed event.
     pub fn add_update_completed(&mut self, accepted_event_id: i64) {
         let attrs = WorkflowExecutionUpdateCompletedEventAttributes {
             meta: None,
@@ -493,6 +534,7 @@ impl TestHistoryBuilder {
         self.build_and_push_event(EventType::WorkflowExecutionUpdateCompleted, attrs.into());
     }
 
+    /// Returns the original run ID from the workflow execution started event.
     pub fn get_orig_run_id(&self) -> &str {
         &self.original_run_id
     }
@@ -509,6 +551,7 @@ impl TestHistoryBuilder {
         HistoryInfo::new_from_history(&self.events.clone().into(), None)
     }
 
+    /// Returns a single incremental workflow task's worth of history.
     pub fn get_one_wft(&self, from_wft_number: usize) -> Result<HistoryInfo, anyhow::Error> {
         let mut histinfo =
             HistoryInfo::new_from_history(&self.events.clone().into(), Some(from_wft_number))?;
@@ -625,6 +668,7 @@ fn default_attribs(et: EventType) -> Result<Attributes> {
     })
 }
 
+/// Returns default workflow execution started attributes for testing.
 pub fn default_wes_attribs() -> WorkflowExecutionStartedEventAttributes {
     WorkflowExecutionStartedEventAttributes {
         original_execution_run_id: Uuid::new_v4().to_string(),
@@ -645,6 +689,7 @@ pub fn default_wes_attribs() -> WorkflowExecutionStartedEventAttributes {
     }
 }
 
+/// Returns a default schedule-activity command for testing.
 pub fn default_act_sched() -> ScheduleActivity {
     ScheduleActivity {
         activity_type: DEFAULT_ACTIVITY_TYPE.to_string(),

package/sdk-core/crates/common/src/protos/history_info.rs

@@ -131,10 +131,12 @@ impl HistoryInfo {
         self.events.drain(0..last_complete_ix);
     }
 
+    /// Returns a slice of all events in this history.
     pub fn events(&self) -> &[HistoryEvent] {
         &self.events
     }
 
+    /// Consumes this instance and returns the underlying events.
     pub fn into_events(self) -> Vec<HistoryEvent> {
         self.events
     }