@temporalio/core-bridge 1.13.0 → 1.13.2

package/sdk-core/sdk-core-protos/protos/api_upstream/openapi/openapiv3.yaml

@@ -1914,6 +1914,44 @@ paths:
             application/json:
               schema:
                 $ref: '#/components/schemas/Status'
+  /api/v1/namespaces/{namespace}/worker-deployments/{deploymentName}/set-manager:
+    post:
+      tags:
+        - WorkflowService
+      description: |-
+        Set/unset the ManagerIdentity of a Worker Deployment.
+         Experimental. This API might significantly change or be removed in a future release.
+      operationId: SetWorkerDeploymentManager
+      parameters:
+        - name: namespace
+          in: path
+          required: true
+          schema:
+            type: string
+        - name: deploymentName
+          in: path
+          required: true
+          schema:
+            type: string
+      requestBody:
+        content:
+          application/json:
+            schema:
+              $ref: '#/components/schemas/SetWorkerDeploymentManagerRequest'
+        required: true
+      responses:
+        "200":
+          description: OK
+          content:
+            application/json:
+              schema:
+                $ref: '#/components/schemas/SetWorkerDeploymentManagerResponse'
+        default:
+          description: Default error response
+          content:
+            application/json:
+              schema:
+                $ref: '#/components/schemas/Status'
   /api/v1/namespaces/{namespace}/worker-deployments/{deploymentName}/set-ramping-version:
     post:
       tags:
@@ -2087,6 +2125,38 @@ paths:
             application/json:
               schema:
                 $ref: '#/components/schemas/Status'
+  /api/v1/namespaces/{namespace}/workers/describe/{workerInstanceKey}:
+    get:
+      tags:
+        - WorkflowService
+      description: DescribeWorker returns information about the specified worker.
+      operationId: DescribeWorker
+      parameters:
+        - name: namespace
+          in: path
+          description: Namespace this worker belongs to.
+          required: true
+          schema:
+            type: string
+        - name: workerInstanceKey
+          in: path
+          description: Worker instance key to describe.
+          required: true
+          schema:
+            type: string
+      responses:
+        "200":
+          description: OK
+          content:
+            application/json:
+              schema:
+                $ref: '#/components/schemas/DescribeWorkerResponse'
+        default:
+          description: Default error response
+          content:
+            application/json:
+              schema:
+                $ref: '#/components/schemas/Status'
   /api/v1/namespaces/{namespace}/workers/fetch-config:
     post:
       tags:
@@ -2540,7 +2610,10 @@ paths:
     get:
       tags:
         - WorkflowService
-      description: "GetWorkflowExecutionHistoryReverse returns the history of specified workflow execution in reverse \n order (starting from last event). Fails with`NotFound` if the specified workflow execution is \n unknown to the service."
+      description: |-
+        GetWorkflowExecutionHistoryReverse returns the history of specified workflow execution in reverse
+         order (starting from last event). Fails with`NotFound` if the specified workflow execution is
+         unknown to the service.
       operationId: GetWorkflowExecutionHistoryReverse
       parameters:
         - name: namespace
@@ -5265,6 +5338,44 @@ paths:
             application/json:
               schema:
                 $ref: '#/components/schemas/Status'
+  /namespaces/{namespace}/worker-deployments/{deploymentName}/set-manager:
+    post:
+      tags:
+        - WorkflowService
+      description: |-
+        Set/unset the ManagerIdentity of a Worker Deployment.
+         Experimental. This API might significantly change or be removed in a future release.
+      operationId: SetWorkerDeploymentManager
+      parameters:
+        - name: namespace
+          in: path
+          required: true
+          schema:
+            type: string
+        - name: deploymentName
+          in: path
+          required: true
+          schema:
+            type: string
+      requestBody:
+        content:
+          application/json:
+            schema:
+              $ref: '#/components/schemas/SetWorkerDeploymentManagerRequest'
+        required: true
+      responses:
+        "200":
+          description: OK
+          content:
+            application/json:
+              schema:
+                $ref: '#/components/schemas/SetWorkerDeploymentManagerResponse'
+        default:
+          description: Default error response
+          content:
+            application/json:
+              schema:
+                $ref: '#/components/schemas/Status'
   /namespaces/{namespace}/worker-deployments/{deploymentName}/set-ramping-version:
     post:
       tags:
@@ -5438,6 +5549,38 @@ paths:
             application/json:
               schema:
                 $ref: '#/components/schemas/Status'
+  /namespaces/{namespace}/workers/describe/{workerInstanceKey}:
+    get:
+      tags:
+        - WorkflowService
+      description: DescribeWorker returns information about the specified worker.
+      operationId: DescribeWorker
+      parameters:
+        - name: namespace
+          in: path
+          description: Namespace this worker belongs to.
+          required: true
+          schema:
+            type: string
+        - name: workerInstanceKey
+          in: path
+          description: Worker instance key to describe.
+          required: true
+          schema:
+            type: string
+      responses:
+        "200":
+          description: OK
+          content:
+            application/json:
+              schema:
+                $ref: '#/components/schemas/DescribeWorkerResponse'
+        default:
+          description: Default error response
+          content:
+            application/json:
+              schema:
+                $ref: '#/components/schemas/Status'
   /namespaces/{namespace}/workers/fetch-config:
     post:
       tags:
@@ -5891,7 +6034,10 @@ paths:
     get:
       tags:
         - WorkflowService
-      description: "GetWorkflowExecutionHistoryReverse returns the history of specified workflow execution in reverse \n order (starting from last event). Fails with`NotFound` if the specified workflow execution is \n unknown to the service."
+      description: |-
+        GetWorkflowExecutionHistoryReverse returns the history of specified workflow execution in reverse
+         order (starting from last event). Fails with`NotFound` if the specified workflow execution is
+         unknown to the service.
       operationId: GetWorkflowExecutionHistoryReverse
       parameters:
         - name: namespace
@@ -7921,6 +8067,11 @@ components:
              Only set if `report_task_queue_stats` is set to true in the request.
              (-- api-linter: core::0140::prepositions=disabled
                  aip.dev/not-precedent: "by" is used to clarify the key. --)
+    DescribeWorkerResponse:
+      type: object
+      properties:
+        workerInfo:
+          $ref: '#/components/schemas/WorkerInfo'
     DescribeWorkflowExecutionResponse:
       type: object
       properties:
@@ -8242,6 +8393,10 @@ components:
           type: string
         visibilityStore:
           type: string
+        initialFailoverVersion:
+          type: string
+        failoverVersionIncrement:
+          type: string
       description: GetClusterInfoResponse contains information about Temporal cluster.
     GetCurrentDeploymentResponse:
       type: object
@@ -9055,6 +9210,12 @@ components:
         asyncUpdate:
           type: boolean
           description: True if the namespace supports async update
+        workerHeartbeats:
+          type: boolean
+          description: True if the namespace supports worker heartbeats
+        reportedProblemsSearchAttribute:
+          type: boolean
+          description: True if the namespace supports reported problems search attribute
       description: Namespace capability details. Should contain what features are enabled in a namespace.
     NamespaceReplicationConfig:
       type: object
@@ -9461,7 +9622,9 @@ components:
           description: Only the activity with this ID will be paused.
         type:
           type: string
-          description: Pause all running activities of this type.
+          description: |-
+            Pause all running activities of this type.
+             Note: Experimental - the behavior of pause by activity type might change in a future release.
         reason:
           type: string
           description: Reason to pause the activity.
@@ -9939,7 +10102,7 @@ components:
              configuration, and defaults to 5.
 
              If priority is not present (or zero), then the effective priority will be
-             the default priority, which is is calculated by (min+max)/2. With the
+             the default priority, which is calculated by (min+max)/2. With the
              default max of 5, and min of 1, that comes out to 3.
           format: int32
         fairnessKey:
@@ -11347,6 +11510,12 @@ components:
              needed. If the request is unexpectedly rejected due to missing pollers, then that means the
              pollers have not reached to the server yet. Only set this if you expect those pollers to
              never arrive.
+        allowNoPollers:
+          type: boolean
+          description: |-
+            Optional. By default this request will be rejected if no pollers have been seen for the proposed
+             Current Version, in order to protect users from routing tasks to pollers that do not exist, leading
+             to possible timeouts. Pass `true` here to bypass this protection.
       description: Set/unset the Current Version of a Worker Deployment.
     SetWorkerDeploymentCurrentVersionResponse:
       type: object
@@ -11365,6 +11534,46 @@ components:
           allOf:
             - $ref: '#/components/schemas/WorkerDeploymentVersion'
           description: The version that was current before executing this operation.
+    SetWorkerDeploymentManagerRequest:
+      type: object
+      properties:
+        namespace:
+          type: string
+        deploymentName:
+          type: string
+        managerIdentity:
+          type: string
+          description: |-
+            Arbitrary value for `manager_identity`.
+             Empty will unset the field.
+        self:
+          type: boolean
+          description: True will set `manager_identity` to `identity`.
+        conflictToken:
+          type: string
+          description: |-
+            Optional. This can be the value of conflict_token from a Describe, or another Worker
+             Deployment API. Passing a non-nil conflict token will cause this request to fail if the
+             Deployment's configuration has been modified between the API call that generated the
+             token and this one.
+          format: bytes
+        identity:
+          type: string
+          description: Required. The identity of the client who initiated this request.
+      description: Update the ManagerIdentity of a Worker Deployment.
+    SetWorkerDeploymentManagerResponse:
+      type: object
+      properties:
+        conflictToken:
+          type: string
+          description: |-
+            This value is returned so that it can be optionally passed to APIs
+             that write to the Worker Deployment state to ensure that the state
+             did not change between this API call and a future write.
+          format: bytes
+        previousManagerIdentity:
+          type: string
+          description: What the `manager_identity` field was before this change.
     SetWorkerDeploymentRampingVersionRequest:
       type: object
       properties:
@@ -11415,6 +11624,12 @@ components:
              Note: this check only happens when the ramping version is about to change, not every time
              that the percentage changes. Also note that the check is against the deployment's Current
              Version, not the previous Ramping Version.
+        allowNoPollers:
+          type: boolean
+          description: |-
+            Optional. By default this request will be rejected if no pollers have been seen for the proposed
+             Current Version, in order to protect users from routing tasks to pollers that do not exist, leading
+             to possible timeouts. Pass `true` here to bypass this protection.
       description: Set/unset the Ramping Version of a Worker Deployment and its ramp percentage.
     SetWorkerDeploymentRampingVersionResponse:
       type: object
@@ -11960,6 +12175,10 @@ components:
           allOf:
             - $ref: '#/components/schemas/Priority'
           description: Priority metadata
+        eagerWorkerDeploymentOptions:
+          allOf:
+            - $ref: '#/components/schemas/WorkerDeploymentOptions'
+          description: Deployment Options of the worker who will process the eager task. Passed when `request_eager_execution=true`.
     StartWorkflowExecutionResponse:
       type: object
       properties:
@@ -12551,7 +12770,10 @@ components:
           type: object
           additionalProperties:
             type: string
-          description: "A key-value map for any customized purpose.\n If data already exists on the namespace, \n this will merge with the existing key values."
+          description: |-
+            A key-value map for any customized purpose.
+             If data already exists on the namespace,
+             this will merge with the existing key values.
         state:
           enum:
             - NAMESPACE_STATE_UNSPECIFIED
@@ -13093,6 +13315,13 @@ components:
             Identity of the last client who modified the configuration of this Deployment. Set to the
              `identity` value sent by APIs such as `SetWorkerDeploymentCurrentVersion` and
              `SetWorkerDeploymentRampingVersion`.
+        managerIdentity:
+          type: string
+          description: |-
+            Identity of the client that has the exclusive right to make changes to this Worker Deployment.
+             Empty by default.
+             If this is set, clients whose identity does not match `manager_identity` will not be able to make changes
+             to this Worker Deployment. They can either set their own identity as the manager or unset the field to proceed.
       description: "A Worker Deployment (Deployment, for short) represents all workers serving \n a shared set of Task Queues. Typically, a Deployment represents one service or \n application.\n A Deployment contains multiple Deployment Versions, each representing a different \n version of workers. (see documentation of WorkerDeploymentVersionInfo)\n Deployment records are created in Temporal server automatically when their\n first poller arrives to the server.\n Experimental. Worker Deployments are experimental and might significantly change in the future."
     WorkerDeploymentInfo_WorkerDeploymentVersionSummary:
       type: object

package/sdk-core/sdk-core-protos/protos/api_upstream/temporal/api/common/v1/message.proto

@@ -280,7 +280,7 @@ message Priority {
     // configuration, and defaults to 5.
     //
     // If priority is not present (or zero), then the effective priority will be
-    // the default priority, which is is calculated by (min+max)/2. With the
+    // the default priority, which is calculated by (min+max)/2. With the
     // default max of 5, and min of 1, that comes out to 3.
     int32 priority_key = 1;
 

package/sdk-core/sdk-core-protos/protos/api_upstream/temporal/api/deployment/v1/message.proto

@@ -195,6 +195,12 @@ message WorkerDeploymentInfo {
     // `SetWorkerDeploymentRampingVersion`.
     string last_modifier_identity = 5;
 
+    // Identity of the client that has the exclusive right to make changes to this Worker Deployment.
+    // Empty by default.
+    // If this is set, clients whose identity does not match `manager_identity` will not be able to make changes
+    // to this Worker Deployment. They can either set their own identity as the manager or unset the field to proceed.
+    string manager_identity = 6;
+
     message WorkerDeploymentVersionSummary {
         // Deprecated. Use `deployment_version`.
         string version = 1 [deprecated = true];

package/sdk-core/sdk-core-protos/protos/api_upstream/temporal/api/namespace/v1/message.proto

@@ -34,6 +34,10 @@ message NamespaceInfo {
         bool sync_update = 2;
         // True if the namespace supports async update
         bool async_update = 3;
+        // True if the namespace supports worker heartbeats
+        bool worker_heartbeats = 4;
+        // True if the namespace supports reported problems search attribute
+        bool reported_problems_search_attribute = 5;
     }
 
     // Whether scheduled workflows are supported on this namespace. This is only needed
@@ -68,8 +72,8 @@ message UpdateNamespaceInfo {
     string description = 1;
     string owner_email = 2;
     // A key-value map for any customized purpose.
-    // If data already exists on the namespace, 
-    // this will merge with the existing key values. 
+    // If data already exists on the namespace,
+    // this will merge with the existing key values.
     map<string, string> data = 3;
     // New namespace state, server will reject if transition is not allowed.
     // Allowed transitions are:

package/sdk-core/sdk-core-protos/protos/api_upstream/temporal/api/workflowservice/v1/request_response.proto

@@ -194,6 +194,8 @@ message StartWorkflowExecutionRequest {
     temporal.api.workflow.v1.OnConflictOptions on_conflict_options = 26;
     // Priority metadata
     temporal.api.common.v1.Priority priority = 27;
+    // Deployment Options of the worker who will process the eager task. Passed when `request_eager_execution=true`.
+    temporal.api.deployment.v1.WorkerDeploymentOptions eager_worker_deployment_options = 28;
 }
 
 message StartWorkflowExecutionResponse {
@@ -1157,6 +1159,8 @@ message GetClusterInfoResponse {
     int32 history_shard_count = 6;
     string persistence_store = 7;
     string visibility_store = 8;
+    int64 initial_failover_version = 9;
+    int64 failover_version_increment = 10;
 }
 
 message GetSystemInfoRequest {
@@ -1938,6 +1942,7 @@ message PauseActivityRequest {
         // Only the activity with this ID will be paused.
         string id = 4;
         // Pause all running activities of this type.
+        // Note: Experimental - the behavior of pause by activity type might change in a future release.
         string type = 5;
     }
 
@@ -2163,6 +2168,10 @@ message SetWorkerDeploymentCurrentVersionRequest {
     // pollers have not reached to the server yet. Only set this if you expect those pollers to
     // never arrive.
     bool ignore_missing_task_queues = 6;
+    // Optional. By default this request will be rejected if no pollers have been seen for the proposed
+    // Current Version, in order to protect users from routing tasks to pollers that do not exist, leading
+    // to possible timeouts. Pass `true` here to bypass this protection.
+    bool allow_no_pollers = 9;
 }
 
 message SetWorkerDeploymentCurrentVersionResponse {
@@ -2215,6 +2224,10 @@ message SetWorkerDeploymentRampingVersionRequest {
     // that the percentage changes. Also note that the check is against the deployment's Current
     // Version, not the previous Ramping Version.
     bool ignore_missing_task_queues = 7;
+    // Optional. By default this request will be rejected if no pollers have been seen for the proposed
+    // Current Version, in order to protect users from routing tasks to pollers that do not exist, leading
+    // to possible timeouts. Pass `true` here to bypass this protection.
+    bool allow_no_pollers = 10;
 }
 
 message SetWorkerDeploymentRampingVersionResponse {
@@ -2248,8 +2261,8 @@ message ListWorkerDeploymentsResponse {
         google.protobuf.Timestamp create_time = 2;
         temporal.api.deployment.v1.RoutingConfig routing_config = 3;
         // Summary of the version that was added most recently in the Worker Deployment.
-        temporal.api.deployment.v1.WorkerDeploymentInfo.WorkerDeploymentVersionSummary latest_version_summary = 4; 
-        // Summary of the current version of the Worker Deployment. 
+        temporal.api.deployment.v1.WorkerDeploymentInfo.WorkerDeploymentVersionSummary latest_version_summary = 4;
+        // Summary of the current version of the Worker Deployment.
         temporal.api.deployment.v1.WorkerDeploymentInfo.WorkerDeploymentVersionSummary current_version_summary = 5;
         // Summary of the ramping version of the Worker Deployment.
         temporal.api.deployment.v1.WorkerDeploymentInfo.WorkerDeploymentVersionSummary ramping_version_summary = 6;
@@ -2309,6 +2322,39 @@ message UpdateWorkerDeploymentVersionMetadataResponse {
     temporal.api.deployment.v1.VersionMetadata metadata = 1;
 }
 
+// Update the ManagerIdentity of a Worker Deployment.
+message SetWorkerDeploymentManagerRequest {
+    string namespace = 1;
+    string deployment_name = 2;
+
+    oneof new_manager_identity {
+      // Arbitrary value for `manager_identity`.
+      // Empty will unset the field.
+      string manager_identity = 3;
+
+      // True will set `manager_identity` to `identity`.
+      bool self = 4;
+    }
+
+    // Optional. This can be the value of conflict_token from a Describe, or another Worker
+    // Deployment API. Passing a non-nil conflict token will cause this request to fail if the
+    // Deployment's configuration has been modified between the API call that generated the
+    // token and this one.
+    bytes conflict_token = 5;
+
+    // Required. The identity of the client who initiated this request.
+    string identity = 6;
+}
+
+message SetWorkerDeploymentManagerResponse {
+    // This value is returned so that it can be optionally passed to APIs
+    // that write to the Worker Deployment state to ensure that the state
+    // did not change between this API call and a future write.
+    bytes conflict_token = 1;
+
+    // What the `manager_identity` field was before this change.
+    string previous_manager_identity = 2;
+}
 
 // Returns the Current Deployment of a deployment series.
 // [cleanup-wv-pre-release] Pre-release deployment APIs, clean up later
@@ -2537,3 +2583,15 @@ message UpdateWorkerConfigResponse {
         // Once we support sending update to a multiple workers - it will be converted into a batch job, and job id will be returned.
     }
 }
+
+message DescribeWorkerRequest {
+    // Namespace this worker belongs to.
+    string namespace = 1;
+
+    // Worker instance key to describe.
+    string worker_instance_key = 2;
+}
+
+message DescribeWorkerResponse {
+    temporal.api.worker.v1.WorkerInfo worker_info = 1;
+}

package/sdk-core/sdk-core-protos/protos/api_upstream/temporal/api/workflowservice/v1/service.proto

@@ -133,9 +133,9 @@ service WorkflowService {
             }
         };
     }
-    
-    // GetWorkflowExecutionHistoryReverse returns the history of specified workflow execution in reverse 
-    // order (starting from last event). Fails with`NotFound` if the specified workflow execution is 
+
+    // GetWorkflowExecutionHistoryReverse returns the history of specified workflow execution in reverse
+    // order (starting from last event). Fails with`NotFound` if the specified workflow execution is
     // unknown to the service.
     rpc GetWorkflowExecutionHistoryReverse (GetWorkflowExecutionHistoryReverseRequest) returns (GetWorkflowExecutionHistoryReverseResponse) {
         option (google.api.http) = {
@@ -458,7 +458,8 @@ service WorkflowService {
         };
     }
 
-    // ScanWorkflowExecutions is a visibility API to list large amount of workflow executions in a specific namespace without order.
+    // ScanWorkflowExecutions _was_ a visibility API to list large amount of workflow executions in a specific namespace without order.
+    // It has since been deprecated in favor of `ListWorkflowExecutions` and rewritten to use `ListWorkflowExecutions` internally.
     //
     // Deprecated: Replaced with `ListWorkflowExecutions`.
     // (-- api-linter: core::0127::http-annotation=disabled
@@ -669,8 +670,8 @@ service WorkflowService {
     // members are compatible with one another.
     //
     // A single build id may be mapped to multiple task queues using this API for cases where a single process hosts
-    // multiple workers. 
-    // 
+    // multiple workers.
+    //
     // To query which workers can be retired, use the `GetWorkerTaskReachability` API.
     //
     // NOTE: The number of task queues mapped to a single build id is limited by the `limit.taskQueuesPerBuildId`
@@ -923,6 +924,19 @@ service WorkflowService {
         };
     }
 
+    // Set/unset the ManagerIdentity of a Worker Deployment.
+    // Experimental. This API might significantly change or be removed in a future release.
+    rpc SetWorkerDeploymentManager (SetWorkerDeploymentManagerRequest) returns (SetWorkerDeploymentManagerResponse) {
+        option (google.api.http) = {
+            post: "/namespaces/{namespace}/worker-deployments/{deployment_name}/set-manager"
+            body: "*"
+            additional_bindings {
+                post: "/api/v1/namespaces/{namespace}/worker-deployments/{deployment_name}/set-manager"
+                body: "*"
+            }
+        };
+    }
+
     // Invokes the specified Update function on user Workflow code.
     rpc UpdateWorkflowExecution(UpdateWorkflowExecutionRequest) returns (UpdateWorkflowExecutionResponse) {
         option (google.api.http) = {
@@ -1235,4 +1249,14 @@ service WorkflowService {
             }
         };
     }
+
+    // DescribeWorker returns information about the specified worker.
+    rpc DescribeWorker (DescribeWorkerRequest) returns (DescribeWorkerResponse) {
+        option (google.api.http) = {
+            get: "/namespaces/{namespace}/workers/describe/{worker_instance_key}"
+            additional_bindings {
+                get: "/api/v1/namespaces/{namespace}/workers/describe/{worker_instance_key}"
+            }
+        };
+    }
 }

package/sdk-core/sdk-core-protos/protos/local/temporal/sdk/core/workflow_activation/workflow_activation.proto

@@ -92,6 +92,8 @@ message WorkflowActivation {
     // build id, if this worker was using the deprecated Build ID-only
     // feature(s).
     common.WorkerDeploymentVersion deployment_version_for_current_task = 9;
+    // The last seen SDK version from the most recent WFT completed event
+    string last_sdk_version = 10;
 }
 
 message WorkflowActivationJob {

package/sdk-core/{test-utils → sdk-core-protos}/src/canned_histories.rs

@@ -1,8 +1,5 @@
-use prost::Message;
-use rand::RngCore;
-use std::{fs::File, io::Write, path::PathBuf};
-use temporal_sdk_core::replay::TestHistoryBuilder;
-use temporal_sdk_core_protos::{
+use crate::{
+    TestHistoryBuilder,
     coresdk::common::NamespacedWorkflowExecution,
     temporal::api::{
         common::v1::{Payload, WorkflowExecution},
@@ -11,6 +8,9 @@ use temporal_sdk_core_protos::{
         history::v1::*,
     },
 };
+use prost::Message;
+use rand::RngCore;
+use std::{fs::File, io::Write, path::PathBuf};
 
 ///  1: EVENT_TYPE_WORKFLOW_EXECUTION_STARTED
 ///  2: EVENT_TYPE_WORKFLOW_TASK_SCHEDULED

package/sdk-core/sdk-core-protos/src/history_builder.rs

@@ -23,7 +23,7 @@ use crate::{
     },
 };
 use anyhow::bail;
-use prost_wkt_types::Timestamp;
+use prost_types::Timestamp;
 use std::{
     collections::HashMap,
     time::{Duration, SystemTime},
@@ -621,7 +621,7 @@ fn default_attribs(et: EventType) -> Result<Attributes> {
         EventType::WorkflowExecutionStarted => default_wes_attribs().into(),
         EventType::WorkflowTaskScheduled => WorkflowTaskScheduledEventAttributes::default().into(),
         EventType::TimerStarted => TimerStartedEventAttributes::default().into(),
-        _ => bail!("Don't know how to construct default attrs for {:?}", et),
+        _ => bail!("Don't know how to construct default attrs for {et:?}"),
     })
 }