@temporalio/core-bridge 1.11.8 → 1.12.0

package/sdk-core/core/src/worker/workflow/workflow_stream.rs

@@ -40,11 +40,11 @@ impl WFStream {
     /// Constructs workflow state management and returns a stream which outputs activations.
     ///
     /// * `wft_stream` is a stream of validated poll responses and fetched history pages as returned
-    ///    by a poller (or mock), via [WFTExtractor].
+    ///   by a poller (or mock), via [WFTExtractor].
     /// * `local_rx` is a stream of actions that workflow state needs to see. Things like
-    ///    completions, local activities finishing, etc. See [LocalInputs].
+    ///   completions, local activities finishing, etc. See [LocalInputs].
     /// * `local_activity_request_sink` is used to handle outgoing requests to start or cancel
-    ///    local activities, and may return resolutions that need to be handled immediately.
+    ///   local activities, and may return resolutions that need to be handled immediately.
     ///
     /// The stream inputs are combined into a stream of [WFActStreamInput]s. The stream processor
     /// then takes action on those inputs, mutating the [WFStream] state, and then may yield
@@ -111,16 +111,16 @@ impl WFStream {
                     }
                     WFStreamInput::Local(local_input) => {
                         let _span_g = local_input.span.enter();
-                        if let Some(rid) = local_input.input.run_id() {
-                            if let Some(rh) = state.runs.get_mut(rid) {
-                                rh.record_span_fields(&local_input.span);
-                            }
+                        if let Some(rid) = local_input.input.run_id()
+                            && let Some(rh) = state.runs.get_mut(rid)
+                        {
+                            rh.record_span_fields(&local_input.span);
                         }
                         match local_input.input {
                             LocalInputs::Completion(completion) => {
-                                activations.extend(
-                                    state.process_completion(NewOrFetchedComplete::New(completion)),
-                                );
+                                activations.extend(state.process_completion(
+                                    NewOrFetchedComplete::New(Box::new(completion)),
+                                ));
                                 None // completions can return more than one activation
                             }
                             LocalInputs::FetchedPageCompletion { paginator, update } => {
@@ -184,13 +184,13 @@ impl WFStream {
                 })
             })
             .inspect(|o| {
-                if let Some(e) = o.as_ref().err() {
-                    if !matches!(e, PollError::ShutDown) {
-                        error!(
-                            "Workflow processing encountered fatal error and must shut down {:?}",
-                            e
-                        );
-                    }
+                if let Some(e) = o.as_ref().err()
+                    && !matches!(e, PollError::ShutDown)
+                {
+                    error!(
+                        "Workflow processing encountered fatal error and must shut down {:?}",
+                        e
+                    );
                 }
             })
             // Stop the stream once we have shut down
@@ -264,10 +264,12 @@ impl WFStream {
                 ValidatedCompletion::Success {
                     commands,
                     used_flags,
+                    versioning_behavior,
                     ..
                 } => match rh.successful_completion(
                     commands,
                     used_flags,
+                    versioning_behavior,
                     complete.response_tx,
                     false,
                 ) {
@@ -379,24 +381,24 @@ impl WFStream {
             }
         }
 
-        if res.is_none() {
-            if let Some(rh) = self.runs.get_mut(run_id) {
-                // Attempt to produce the next activation if needed
-                res = rh.check_more_activations();
-                // If there's no more work and we reported workflow completion to server, evict.
-                if res.is_none()
-                    && rh.workflow_is_finished()
-                    && matches!(report.wft_report_status, WFTReportStatus::Reported { .. })
-                {
-                    res = rh
-                        .request_eviction(RequestEvictMsg {
-                            run_id: run_id.to_string(),
-                            message: "Workflow completed".to_string(),
-                            reason: EvictionReason::WorkflowExecutionEnding,
-                            auto_reply_fail_tt: None,
-                        })
-                        .into_run_update_resp()
-                }
+        if res.is_none()
+            && let Some(rh) = self.runs.get_mut(run_id)
+        {
+            // Attempt to produce the next activation if needed
+            res = rh.check_more_activations();
+            // If there's no more work and we reported workflow completion to server, evict.
+            if res.is_none()
+                && rh.workflow_is_finished()
+                && matches!(report.wft_report_status, WFTReportStatus::Reported { .. })
+            {
+                res = rh
+                    .request_eviction(RequestEvictMsg {
+                        run_id: run_id.to_string(),
+                        message: "Workflow completed".to_string(),
+                        reason: EvictionReason::WorkflowExecutionEnding,
+                        auto_reply_fail_tt: None,
+                    })
+                    .into_run_update_resp()
             }
         }
         res
@@ -710,7 +712,7 @@ impl From<Result<WFTExtractorOutput, tonic::Status>> for ExternalPollerInputs {
 }
 #[derive(Debug)]
 enum NewOrFetchedComplete {
-    New(WFActCompleteMsg),
+    New(Box<WFActCompleteMsg>),
     Fetched(HistoryUpdate, Box<HistoryPaginator>),
 }
 impl NewOrFetchedComplete {

package/sdk-core/core-api/Cargo.toml

@@ -14,15 +14,20 @@ categories = ["development-tools"]
 
 [features]
 otel_impls = ["dep:opentelemetry"]
+envconfig = ["dep:toml", "dep:serde", "dep:dirs", "dep:anyhow"]
 
 [dependencies]
+anyhow = { version = "1.0", optional = true }
 async-trait = "0.1"
+dirs = { version = "5.0", optional = true }
 derive_builder = { workspace = true }
 derive_more = { workspace = true }
 opentelemetry = { workspace = true, optional = true }
 prost = { workspace = true }
+serde = { version = "1.0", features = ["derive"], optional = true }
 serde_json = "1.0"
 thiserror = { workspace = true }
+toml = { version = "0.8", optional = true }
 tonic = { workspace = true }
 tracing-core = "0.1"
 url = "2.3"
@@ -33,3 +38,6 @@ version = "0.1"
 
 [lints]
 workspace = true
+
+[dev-dependencies]
+tempfile = "3.8"