@temporalio/core-bridge 0.23.0 → 1.0.0

package/sdk-core/client/src/raw.rs

@@ -157,7 +157,7 @@ impl AttachMetricLabels {
 impl<RC, T> WorkflowService for RC
 where
     RC: RawClientLike<SvcType = T>,
-    T: tonic::client::GrpcService<tonic::body::BoxBody> + Send + Clone + 'static,
+    T: GrpcService<BoxBody> + Send + Clone + 'static,
     T::ResponseBody: tonic::codegen::Body + Send + 'static,
     T::Error: Into<tonic::codegen::StdError>,
     T::Future: Send,
@@ -183,26 +183,37 @@ macro_rules! proxy {
         }
     };
 }
+macro_rules! proxier {
+    ( $(($method:ident, $req:ident, $resp:ident $(, $closure:expr)?  );)* ) => {
+        #[cfg(test)]
+        const ALL_IMPLEMENTED_RPCS: &'static [&'static str] = &[$(stringify!($method)),*];
+        /// Trait version of the generated workflow service client with modifications to attach appropriate
+        /// metric labels or whatever else to requests
+        pub trait WorkflowService: RawClientLike
+        where
+            // Yo this is wild
+            <Self as RawClientLike>::SvcType: GrpcService<BoxBody> + Send + Clone + 'static,
+            <<Self as RawClientLike>::SvcType as GrpcService<BoxBody>>::ResponseBody:
+                tonic::codegen::Body + Send + 'static,
+            <<Self as RawClientLike>::SvcType as GrpcService<BoxBody>>::Error:
+                Into<tonic::codegen::StdError>,
+            <<Self as RawClientLike>::SvcType as GrpcService<BoxBody>>::Future: Send,
+            <<<Self as RawClientLike>::SvcType as GrpcService<BoxBody>>::ResponseBody
+                as tonic::codegen::Body>::Error: Into<tonic::codegen::StdError> + Send,
+        {
+            $(
+               proxy!($method, $req, $resp $(,$closure)*);
+            )*
+        }
+    };
+}
 // Nice little trick to avoid the callsite asking to type the closure parameter
 fn type_closure_arg<T, R>(arg: T, f: impl FnOnce(T) -> R) -> R {
     f(arg)
 }
 
-/// Trait version of the generated workflow service client with modifications to attach appropriate
-/// metric labels or whatever else to requests
-pub trait WorkflowService: RawClientLike
-where
-    // Yo this is wild
-    <Self as RawClientLike>::SvcType: GrpcService<BoxBody> + Send + Clone + 'static,
-    <<Self as RawClientLike>::SvcType as GrpcService<BoxBody>>::ResponseBody:
-        tonic::codegen::Body + Send + 'static,
-    <<Self as RawClientLike>::SvcType as GrpcService<BoxBody>>::Error:
-        Into<tonic::codegen::StdError>,
-    <<Self as RawClientLike>::SvcType as GrpcService<BoxBody>>::Future: Send,
-    <<<Self as RawClientLike>::SvcType as GrpcService<BoxBody>>::ResponseBody as tonic::codegen::Body>::Error:
-         Into<tonic::codegen::StdError> + Send,
-{
-    proxy!(
+proxier! {
+    (
         register_namespace,
         RegisterNamespaceRequest,
         RegisterNamespaceResponse,
@@ -211,7 +222,7 @@ where
             r.extensions_mut().insert(labels);
         }
     );
-    proxy!(
+    (
         describe_namespace,
         DescribeNamespaceRequest,
         DescribeNamespaceResponse,
@@ -220,12 +231,12 @@ where
             r.extensions_mut().insert(labels);
         }
     );
-    proxy!(
+    (
         list_namespaces,
         ListNamespacesRequest,
         ListNamespacesResponse
     );
-    proxy!(
+    (
         update_namespace,
         UpdateNamespaceRequest,
         UpdateNamespaceResponse,
@@ -234,7 +245,7 @@ where
             r.extensions_mut().insert(labels);
         }
     );
-    proxy!(
+    (
         deprecate_namespace,
         DeprecateNamespaceRequest,
         DeprecateNamespaceResponse,
@@ -243,7 +254,7 @@ where
             r.extensions_mut().insert(labels);
         }
     );
-    proxy!(
+    (
         start_workflow_execution,
         StartWorkflowExecutionRequest,
         StartWorkflowExecutionResponse,
@@ -253,7 +264,7 @@ where
             r.extensions_mut().insert(labels);
         }
     );
-    proxy!(
+    (
         get_workflow_execution_history,
         GetWorkflowExecutionHistoryRequest,
         GetWorkflowExecutionHistoryResponse,
@@ -262,7 +273,16 @@ where
             r.extensions_mut().insert(labels);
         }
     );
-    proxy!(
+    (
+        get_workflow_execution_history_reverse,
+        GetWorkflowExecutionHistoryReverseRequest,
+        GetWorkflowExecutionHistoryReverseResponse,
+        |r| {
+            let labels = AttachMetricLabels::namespace(r.get_ref().namespace.clone());
+            r.extensions_mut().insert(labels);
+        }
+    );
+    (
         poll_workflow_task_queue,
         PollWorkflowTaskQueueRequest,
         PollWorkflowTaskQueueResponse,
@@ -273,7 +293,7 @@ where
             r.set_timeout(LONG_POLL_TIMEOUT);
         }
     );
-    proxy!(
+    (
         respond_workflow_task_completed,
         RespondWorkflowTaskCompletedRequest,
         RespondWorkflowTaskCompletedResponse,
@@ -282,7 +302,7 @@ where
             r.extensions_mut().insert(labels);
         }
     );
-    proxy!(
+    (
         respond_workflow_task_failed,
         RespondWorkflowTaskFailedRequest,
         RespondWorkflowTaskFailedResponse,
@@ -291,7 +311,7 @@ where
             r.extensions_mut().insert(labels);
         }
     );
-    proxy!(
+    (
         poll_activity_task_queue,
         PollActivityTaskQueueRequest,
         PollActivityTaskQueueResponse,
@@ -302,7 +322,7 @@ where
             r.set_timeout(LONG_POLL_TIMEOUT);
         }
     );
-    proxy!(
+    (
         record_activity_task_heartbeat,
         RecordActivityTaskHeartbeatRequest,
         RecordActivityTaskHeartbeatResponse,
@@ -311,7 +331,7 @@ where
             r.extensions_mut().insert(labels);
         }
     );
-    proxy!(
+    (
         record_activity_task_heartbeat_by_id,
         RecordActivityTaskHeartbeatByIdRequest,
         RecordActivityTaskHeartbeatByIdResponse,
@@ -320,7 +340,7 @@ where
             r.extensions_mut().insert(labels);
         }
     );
-    proxy!(
+    (
         respond_activity_task_completed,
         RespondActivityTaskCompletedRequest,
         RespondActivityTaskCompletedResponse,
@@ -329,7 +349,7 @@ where
             r.extensions_mut().insert(labels);
         }
     );
-    proxy!(
+    (
         respond_activity_task_completed_by_id,
         RespondActivityTaskCompletedByIdRequest,
         RespondActivityTaskCompletedByIdResponse,
@@ -339,7 +359,7 @@ where
         }
     );
 
-    proxy!(
+    (
         respond_activity_task_failed,
         RespondActivityTaskFailedRequest,
         RespondActivityTaskFailedResponse,
@@ -348,7 +368,7 @@ where
             r.extensions_mut().insert(labels);
         }
     );
-    proxy!(
+    (
         respond_activity_task_failed_by_id,
         RespondActivityTaskFailedByIdRequest,
         RespondActivityTaskFailedByIdResponse,
@@ -357,7 +377,7 @@ where
             r.extensions_mut().insert(labels);
         }
     );
-    proxy!(
+    (
         respond_activity_task_canceled,
         RespondActivityTaskCanceledRequest,
         RespondActivityTaskCanceledResponse,
@@ -366,7 +386,7 @@ where
             r.extensions_mut().insert(labels);
         }
     );
-    proxy!(
+    (
         respond_activity_task_canceled_by_id,
         RespondActivityTaskCanceledByIdRequest,
         RespondActivityTaskCanceledByIdResponse,
@@ -375,7 +395,7 @@ where
             r.extensions_mut().insert(labels);
         }
     );
-    proxy!(
+    (
         request_cancel_workflow_execution,
         RequestCancelWorkflowExecutionRequest,
         RequestCancelWorkflowExecutionResponse,
@@ -384,7 +404,7 @@ where
             r.extensions_mut().insert(labels);
         }
     );
-    proxy!(
+    (
         signal_workflow_execution,
         SignalWorkflowExecutionRequest,
         SignalWorkflowExecutionResponse,
@@ -393,7 +413,7 @@ where
             r.extensions_mut().insert(labels);
         }
     );
-    proxy!(
+    (
         signal_with_start_workflow_execution,
         SignalWithStartWorkflowExecutionRequest,
         SignalWithStartWorkflowExecutionResponse,
@@ -403,7 +423,7 @@ where
             r.extensions_mut().insert(labels);
         }
     );
-    proxy!(
+    (
         reset_workflow_execution,
         ResetWorkflowExecutionRequest,
         ResetWorkflowExecutionResponse,
@@ -412,7 +432,7 @@ where
             r.extensions_mut().insert(labels);
         }
     );
-    proxy!(
+    (
         terminate_workflow_execution,
         TerminateWorkflowExecutionRequest,
         TerminateWorkflowExecutionResponse,
@@ -421,7 +441,7 @@ where
             r.extensions_mut().insert(labels);
         }
     );
-    proxy!(
+    (
         list_open_workflow_executions,
         ListOpenWorkflowExecutionsRequest,
         ListOpenWorkflowExecutionsResponse,
@@ -430,7 +450,7 @@ where
             r.extensions_mut().insert(labels);
         }
     );
-    proxy!(
+    (
         list_closed_workflow_executions,
         ListClosedWorkflowExecutionsRequest,
         ListClosedWorkflowExecutionsResponse,
@@ -439,7 +459,7 @@ where
             r.extensions_mut().insert(labels);
         }
     );
-    proxy!(
+    (
         list_workflow_executions,
         ListWorkflowExecutionsRequest,
         ListWorkflowExecutionsResponse,
@@ -448,7 +468,7 @@ where
             r.extensions_mut().insert(labels);
         }
     );
-    proxy!(
+    (
         list_archived_workflow_executions,
         ListArchivedWorkflowExecutionsRequest,
         ListArchivedWorkflowExecutionsResponse,
@@ -457,7 +477,7 @@ where
             r.extensions_mut().insert(labels);
         }
     );
-    proxy!(
+    (
         scan_workflow_executions,
         ScanWorkflowExecutionsRequest,
         ScanWorkflowExecutionsResponse,
@@ -466,7 +486,7 @@ where
             r.extensions_mut().insert(labels);
         }
     );
-    proxy!(
+    (
         count_workflow_executions,
         CountWorkflowExecutionsRequest,
         CountWorkflowExecutionsResponse,
@@ -475,12 +495,12 @@ where
             r.extensions_mut().insert(labels);
         }
     );
-    proxy!(
+    (
         get_search_attributes,
         GetSearchAttributesRequest,
         GetSearchAttributesResponse
     );
-    proxy!(
+    (
         respond_query_task_completed,
         RespondQueryTaskCompletedRequest,
         RespondQueryTaskCompletedResponse,
@@ -489,7 +509,7 @@ where
             r.extensions_mut().insert(labels);
         }
     );
-    proxy!(
+    (
         reset_sticky_task_queue,
         ResetStickyTaskQueueRequest,
         ResetStickyTaskQueueResponse,
@@ -498,7 +518,7 @@ where
             r.extensions_mut().insert(labels);
         }
     );
-    proxy!(
+    (
         query_workflow,
         QueryWorkflowRequest,
         QueryWorkflowResponse,
@@ -507,7 +527,7 @@ where
             r.extensions_mut().insert(labels);
         }
     );
-    proxy!(
+    (
         describe_workflow_execution,
         DescribeWorkflowExecutionRequest,
         DescribeWorkflowExecutionResponse,
@@ -516,7 +536,7 @@ where
             r.extensions_mut().insert(labels);
         }
     );
-    proxy!(
+    (
         describe_task_queue,
         DescribeTaskQueueRequest,
         DescribeTaskQueueResponse,
@@ -526,17 +546,17 @@ where
             r.extensions_mut().insert(labels);
         }
     );
-    proxy!(
+    (
         get_cluster_info,
         GetClusterInfoRequest,
         GetClusterInfoResponse
     );
-    proxy!(
+    (
         get_system_info,
         GetSystemInfoRequest,
         GetSystemInfoResponse
     );
-    proxy!(
+    (
         list_task_queue_partitions,
         ListTaskQueuePartitionsRequest,
         ListTaskQueuePartitionsResponse,
@@ -546,12 +566,76 @@ where
             r.extensions_mut().insert(labels);
         }
     );
+    (
+        create_schedule,
+        CreateScheduleRequest,
+        CreateScheduleResponse,
+        |r| {
+            let labels = AttachMetricLabels::namespace(r.get_ref().namespace.clone());
+            r.extensions_mut().insert(labels);
+        }
+    );
+    (
+        describe_schedule,
+        DescribeScheduleRequest,
+        DescribeScheduleResponse,
+        |r| {
+            let labels = AttachMetricLabels::namespace(r.get_ref().namespace.clone());
+            r.extensions_mut().insert(labels);
+        }
+    );
+    (
+        update_schedule,
+        UpdateScheduleRequest,
+        UpdateScheduleResponse,
+        |r| {
+            let labels = AttachMetricLabels::namespace(r.get_ref().namespace.clone());
+            r.extensions_mut().insert(labels);
+        }
+    );
+    (
+        patch_schedule,
+        PatchScheduleRequest,
+        PatchScheduleResponse,
+        |r| {
+            let labels = AttachMetricLabels::namespace(r.get_ref().namespace.clone());
+            r.extensions_mut().insert(labels);
+        }
+    );
+    (
+        list_schedule_matching_times,
+        ListScheduleMatchingTimesRequest,
+        ListScheduleMatchingTimesResponse,
+        |r| {
+            let labels = AttachMetricLabels::namespace(r.get_ref().namespace.clone());
+            r.extensions_mut().insert(labels);
+        }
+    );
+    (
+        delete_schedule,
+        DeleteScheduleRequest,
+        DeleteScheduleResponse,
+        |r| {
+            let labels = AttachMetricLabels::namespace(r.get_ref().namespace.clone());
+            r.extensions_mut().insert(labels);
+        }
+    );
+    (
+        list_schedules,
+        ListSchedulesRequest,
+        ListSchedulesResponse,
+        |r| {
+            let labels = AttachMetricLabels::namespace(r.get_ref().namespace.clone());
+            r.extensions_mut().insert(labels);
+        }
+    );
 }
 
 #[cfg(test)]
 mod tests {
     use super::*;
     use crate::{ClientOptionsBuilder, RetryClient, WorkflowServiceClientWithMetrics};
+    use std::collections::HashSet;
     use temporal_sdk_core_protos::temporal::api::workflowservice::v1::ListNamespacesRequest;
 
     // Just to help make sure some stuff compiles. Not run.
@@ -571,4 +655,32 @@ mod tests {
             .await
             .unwrap();
     }
+
+    #[test]
+    fn verify_all_methods_implemented() {
+        // This is less work than trying to hook into the codegen process
+        let proto_def =
+            include_str!("../../protos/api_upstream/temporal/api/workflowservice/v1/service.proto");
+        let methods: Vec<_> = proto_def
+            .lines()
+            .map(|l| l.trim())
+            .filter(|l| l.starts_with("rpc"))
+            .map(|l| {
+                let stripped = l.strip_prefix("rpc ").unwrap();
+                (&stripped[..stripped.find('(').unwrap()]).trim()
+            })
+            .collect();
+        let no_underscores: HashSet<_> = ALL_IMPLEMENTED_RPCS
+            .iter()
+            .map(|x| x.replace('_', ""))
+            .collect();
+        for method in methods {
+            if !no_underscores.contains(&method.to_lowercase()) {
+                panic!(
+                    "WorkflowService RPC method {} is not implemented by raw client",
+                    method
+                )
+            }
+        }
+    }
 }

package/sdk-core/client/src/retry.rs

@@ -6,10 +6,13 @@ use backoff::{backoff::Backoff, ExponentialBackoff};
 use futures_retry::{ErrorHandler, FutureRetry, RetryPolicy};
 use std::{fmt::Debug, future::Future, time::Duration};
 use temporal_sdk_core_protos::{
-    coresdk::{common::Payload, workflow_commands::QueryResult},
+    coresdk::workflow_commands::QueryResult,
     temporal::api::{
-        common::v1::Payloads, enums::v1::WorkflowTaskFailedCause, failure::v1::Failure,
-        query::v1::WorkflowQuery, workflowservice::v1::*,
+        common::v1::{Payload, Payloads},
+        enums::v1::WorkflowTaskFailedCause,
+        failure::v1::Failure,
+        query::v1::WorkflowQuery,
+        workflowservice::v1::*,
     },
     TaskToken,
 };
@@ -403,12 +406,14 @@ where
         &self,
         workflow_id: String,
         run_id: Option<String>,
+        reason: String,
     ) -> Result<RequestCancelWorkflowExecutionResponse> {
         retry_call!(
             self,
             cancel_workflow_execution,
             workflow_id.clone(),
-            run_id.clone()
+            run_id.clone(),
+            reason.clone()
         )
     }
 

package/sdk-core/client/src/workflow_handle/mod.rs

@@ -2,9 +2,11 @@ use crate::{InterceptedMetricsSvc, RawClientLike};
 use anyhow::{anyhow, bail};
 use std::marker::PhantomData;
 use temporal_sdk_core_protos::{
-    coresdk::{common::Payload, FromPayloadsExt},
+    coresdk::FromPayloadsExt,
     temporal::api::{
-        common::v1::WorkflowExecution, enums::v1::HistoryEventFilterType, failure::v1::Failure,
+        common::v1::{Payload, WorkflowExecution},
+        enums::v1::HistoryEventFilterType,
+        failure::v1::Failure,
         history::v1::history_event::Attributes,
         workflowservice::v1::GetWorkflowExecutionHistoryRequest,
     },

package/sdk-core/core/Cargo.toml

@@ -15,6 +15,7 @@ categories = ["development-tools"]
 [dependencies]
 anyhow = "1.0"
 arc-swap = "1.3"
+async-channel = "1.6"
 async-trait = "0.1"
 base64 = "0.13"
 crossbeam = "0.8"
@@ -23,6 +24,7 @@ derive_builder = "0.11"
 derive_more = "0.99"
 enum_dispatch = "0.3"
 futures = "0.3"
+governor = "0.4"
 http = "0.2"
 hyper = "0.14"
 itertools = "0.10"