@temporalio/client 1.3.0 → 1.4.1

package/src/index.ts

@@ -17,16 +17,16 @@ export {
   DataConverter,
   defaultPayloadConverter,
   ProtoFailure,
+  RetryPolicy,
   ServerFailure,
   TemporalFailure,
   TerminatedFailure,
   TimeoutFailure,
 } from '@temporalio/common';
-export { TLSConfig } from '@temporalio/internal-non-workflow-common';
-export { RetryPolicy } from '@temporalio/internal-workflow-common';
-export * from '@temporalio/internal-workflow-common/lib/errors';
-export * from '@temporalio/internal-workflow-common/lib/interfaces';
-export * from '@temporalio/internal-workflow-common/lib/workflow-handle';
+export { TLSConfig } from '@temporalio/common/lib/internal-non-workflow';
+export * from '@temporalio/common/lib/errors';
+export * from '@temporalio/common/lib/interfaces';
+export * from '@temporalio/common/lib/workflow-handle';
 export * from './async-completion-client';
 export * from './client';
 export { Connection, ConnectionOptions, ConnectionOptionsWithDefaults, LOCAL_TARGET } from './connection';

package/src/interceptors.ts

@@ -4,7 +4,7 @@
  * @module
  */
 
-import { Headers, Next } from '@temporalio/internal-workflow-common';
+import { Headers, Next } from '@temporalio/common';
 import { temporal } from '@temporalio/proto';
 import {
   DescribeWorkflowExecutionResponse,

package/src/types.ts

@@ -1,4 +1,4 @@
-import type { SearchAttributes } from '@temporalio/internal-workflow-common';
+import type { SearchAttributes } from '@temporalio/common';
 import * as proto from '@temporalio/proto';
 import type * as grpc from '@grpc/grpc-js';
 

package/src/workflow-client.ts

@@ -21,22 +21,21 @@ import {
   filterNullAndUndefined,
   isLoadedDataConverter,
   loadDataConverter,
-} from '@temporalio/internal-non-workflow-common';
+} from '@temporalio/common/lib/internal-non-workflow';
 import {
   BaseWorkflowHandle,
   compileRetryPolicy,
-  composeInterceptors,
-  optionalTsToDate,
   QueryDefinition,
-  Replace,
   SearchAttributes,
   SignalDefinition,
-  tsToDate,
   WithWorkflowArgs,
   Workflow,
   WorkflowNotFoundError,
   WorkflowResultType,
-} from '@temporalio/internal-workflow-common';
+} from '@temporalio/common';
+import { optionalTsToDate, tsToDate } from '@temporalio/common/lib/time';
+import { composeInterceptors } from '@temporalio/common/lib/interceptors';
+import { Replace } from '@temporalio/common/lib/type-helpers';
 import { temporal } from '@temporalio/proto';
 import os from 'os';
 import { v4 as uuid4 } from 'uuid';
@@ -503,14 +502,9 @@ export class WorkflowClient {
       } catch (err) {
         this.rethrowGrpcError(err, { workflowId, runId }, 'Failed to get Workflow execution history');
       }
-      if (!res.history) {
-        throw new Error('No history returned by service');
-      }
-      const { events } = res.history;
-      if (!events) {
-        throw new Error('No events in history returned by service');
-      }
-      if (events.length === 0) {
+      const events = res.history?.events;
+
+      if (events == null || events.length === 0) {
         req.nextPageToken = res.nextPageToken;
         continue;
       }
@@ -877,10 +871,14 @@ export class WorkflowClient {
           executionTime: optionalTsToDate(raw.workflowExecutionInfo!.executionTime),
           closeTime: optionalTsToDate(raw.workflowExecutionInfo!.closeTime),
           memo: await decodeMapFromPayloads(this.client.dataConverter, raw.workflowExecutionInfo!.memo?.fields),
-          searchAttributes: mapFromPayloads(
-            searchAttributePayloadConverter,
-            raw.workflowExecutionInfo!.searchAttributes?.indexedFields ?? {}
-          ) as SearchAttributes,
+          searchAttributes: Object.fromEntries(
+            Object.entries(
+              mapFromPayloads(
+                searchAttributePayloadConverter,
+                raw.workflowExecutionInfo!.searchAttributes?.indexedFields ?? {}
+              ) as SearchAttributes
+            ).filter(([_, v]) => v && v.length > 0) // Filter out empty arrays returned by pre 1.18 servers
+          ),
           parentExecution: raw.workflowExecutionInfo?.parentExecution
             ? {
                 workflowId: raw.workflowExecutionInfo.parentExecution.workflowId!,

package/src/workflow-options.ts

@@ -1,10 +1,6 @@
-import {
-  CommonWorkflowOptions,
-  SignalDefinition,
-  WithCompiledWorkflowOptions,
-} from '@temporalio/internal-workflow-common';
+import { CommonWorkflowOptions, SignalDefinition, WithCompiledWorkflowOptions } from '@temporalio/common';
 
-export * from '@temporalio/internal-workflow-common/lib/workflow-options';
+export * from '@temporalio/common/lib/workflow-options';
 
 export interface CompiledWorkflowOptions extends WithCompiledWorkflowOptions<WorkflowOptions> {
   args: unknown[];