@telos-dev-team/dealernode-permissions 1.0.7 → 1.1.2

package/dist/permissions.d.ts

@@ -710,11 +710,11 @@ export declare const PERMISSIONS: {
             readonly DELETE: "authorization.user_dealer_permission.delete";
         };
     };
-    readonly FAILED_ACTION: {
+    readonly AUTOMATIC_ACTION: {
         readonly OPERATIONS: {
-            readonly VIEW: "failed_action.operations.view";
-            readonly DELETE: "failed_action.operations.delete";
-            readonly EXECUTE: "failed_action.operations.execute";
+            readonly VIEW: "automatic_action.operations.view";
+            readonly DELETE: "automatic_action.operations.delete";
+            readonly EXECUTE: "automatic_action.operations.execute";
         };
     };
     readonly CALENDAR: {
@@ -723,5 +723,21 @@ export declare const PERMISSIONS: {
             readonly UPDATE: "calendar.operations.update";
         };
     };
+    readonly GPS_PROVIDER: {
+        readonly CONFIG: {
+            readonly OPERATIONS: {
+                readonly CREATE: "gps-provider.config.operations.create";
+                readonly VIEW: "gps-provider.config.operations.view";
+                readonly UPDATE: "gps-provider.config.operations.update";
+                readonly DELETE: "gps-provider.config.operations.delete";
+            };
+        };
+        readonly DEVICE: {
+            readonly OPERATIONS: {
+                readonly VIEW: "gps-provider.device.operations.view";
+                readonly LOCATE: "gps-provider.device.operations.locate";
+            };
+        };
+    };
 };
 export type Permission = typeof PERMISSIONS;

package/dist/permissions.js

@@ -774,13 +774,13 @@ exports.PERMISSIONS = {
         },
     },
     // ============================================
-    // FAILED_ACTION
+    // AUTOMATIC_ACTION
     // ============================================
-    FAILED_ACTION: {
+    AUTOMATIC_ACTION: {
         OPERATIONS: {
-            VIEW: 'failed_action.operations.view',
-            DELETE: 'failed_action.operations.delete',
-            EXECUTE: 'failed_action.operations.execute',
+            VIEW: 'automatic_action.operations.view',
+            DELETE: 'automatic_action.operations.delete',
+            EXECUTE: 'automatic_action.operations.execute',
         },
     },
     // ============================================
@@ -792,4 +792,23 @@ exports.PERMISSIONS = {
             UPDATE: 'calendar.operations.update',
         },
     },
+    // ============================================
+    // GPS PROVIDER
+    // ============================================
+    GPS_PROVIDER: {
+        CONFIG: {
+            OPERATIONS: {
+                CREATE: 'gps-provider.config.operations.create',
+                VIEW: 'gps-provider.config.operations.view',
+                UPDATE: 'gps-provider.config.operations.update',
+                DELETE: 'gps-provider.config.operations.delete',
+            },
+        },
+        DEVICE: {
+            OPERATIONS: {
+                VIEW: 'gps-provider.device.operations.view',
+                LOCATE: 'gps-provider.device.operations.locate',
+            },
+        },
+    },
 };

package/gps-provider-permissions.md

@@ -0,0 +1,109 @@
+# GPS Provider — Permisos a agregar al paquete común
+
+Este documento define los permisos del módulo `gps-provider` para integrarlos al
+paquete `@telos-dev-team/dealernode-permissions` (la fuente de verdad de
+permisos de DealerNode). Una vez agregados y publicada una nueva versión del
+paquete, `dealernode-backend` los importa desde `PERMISSIONS.GPS_PROVIDER.*` y
+los persiste en DB con `npm run sync:permissions`.
+
+## Bloque TypeScript a agregar en `src/permissions.ts`
+
+Insertar como un top-level más del objeto `PERMISSIONS` (mismo nivel que
+`DEAL`, `CAR`, `PAYMENT`, etc.):
+
+```ts
+GPS_PROVIDER: {
+  CONFIG: {
+    OPERATIONS: {
+      CREATE: 'gps-provider.config.operations.create',
+      VIEW:   'gps-provider.config.operations.view',
+      UPDATE: 'gps-provider.config.operations.update',
+      DELETE: 'gps-provider.config.operations.delete',
+    },
+  },
+  DEVICE: {
+    OPERATIONS: {
+      VIEW:   'gps-provider.device.operations.view',
+      LOCATE: 'gps-provider.device.operations.locate',
+    },
+  },
+},
+```
+
+Total: **6 permisos nuevos**.
+
+### Naming
+
+Sigue la convención existente del paquete: `module.resource.operations.action`,
+con `kebab-case` en el slug del módulo cuando lleva guión (como ya hace el
+paquete para `connected-account`).
+
+### Por qué dos sub-recursos (`CONFIG` y `DEVICE`)
+
+- `CONFIG` controla quién puede administrar la configuración del proveedor GPS
+  por dealer (credenciales, nombre, tipo de proveedor). Es un recurso CRUD
+  clásico → 4 acciones.
+- `DEVICE` controla quién puede consultar dispositivos GPS contra el proveedor
+  externo. Se separa en dos por costo:
+  - `VIEW` cubre las lecturas (location, history, status, info, mileage,
+    alerts, active, search).
+  - `LOCATE` controla el único endpoint que **dispara un ping on-demand al
+    dispositivo** (`POST /gps-provider/devices/:imei/locate`), que consume cuota
+    del proveedor. Tiene sentido restringirlo aparte.
+
+## Mapeo endpoint → permiso
+
+| Controller / Método | HTTP | Permiso |
+|---|---|---|
+| `DealerGpsConfigController.create` | `POST /gps-provider/config` | `GPS_PROVIDER.CONFIG.OPERATIONS.CREATE` |
+| `DealerGpsConfigController.findAllByDealer` | `GET /gps-provider/config` | `GPS_PROVIDER.CONFIG.OPERATIONS.VIEW` |
+| `DealerGpsConfigController.findById` | `GET /gps-provider/config/:configId` | `GPS_PROVIDER.CONFIG.OPERATIONS.VIEW` |
+| `DealerGpsConfigController.update` | `PUT /gps-provider/config/:configId` | `GPS_PROVIDER.CONFIG.OPERATIONS.UPDATE` |
+| `DealerGpsConfigController.delete` | `DELETE /gps-provider/config/:configId` | `GPS_PROVIDER.CONFIG.OPERATIONS.DELETE` |
+| `GpsDeviceController.findByImei` | `GET /gps-provider/devices/search` | `GPS_PROVIDER.DEVICE.OPERATIONS.VIEW` |
+| `GpsDeviceController.getDeviceLocation` | `GET /gps-provider/devices/:imei/location` | `GPS_PROVIDER.DEVICE.OPERATIONS.VIEW` |
+| `GpsDeviceController.locateDeviceNow` | `POST /gps-provider/devices/:imei/locate` | `GPS_PROVIDER.DEVICE.OPERATIONS.LOCATE` |
+| `GpsDeviceController.getDeviceHistory` | `GET /gps-provider/devices/:imei/history` | `GPS_PROVIDER.DEVICE.OPERATIONS.VIEW` |
+| `GpsDeviceController.getDeviceStatus` | `GET /gps-provider/devices/:imei/status` | `GPS_PROVIDER.DEVICE.OPERATIONS.VIEW` |
+| `GpsDeviceController.getDeviceInfo` | `GET /gps-provider/devices/:imei/info` | `GPS_PROVIDER.DEVICE.OPERATIONS.VIEW` |
+| `GpsDeviceController.getDeviceMileage` | `GET /gps-provider/devices/:imei/mileage` | `GPS_PROVIDER.DEVICE.OPERATIONS.VIEW` |
+| `GpsDeviceController.getDeviceAlerts` | `GET /gps-provider/devices/:imei/alerts` | `GPS_PROVIDER.DEVICE.OPERATIONS.VIEW` |
+| `GpsDeviceController.isDeviceActive` | `GET /gps-provider/devices/:imei/active` | `GPS_PROVIDER.DEVICE.OPERATIONS.VIEW` |
+
+## Estado anterior (qué se reemplaza)
+
+Antes de esta integración, los endpoints del módulo dependían de permisos
+prestados o no validaban:
+
+- `POST/PUT /gps-provider/config` usaba `DEALER.OPERATIONS.UPDATE`.
+- `DELETE /gps-provider/config/:id` usaba `DEALER.OPERATIONS.DELETE`.
+- `GET /gps-provider/config` y `GET /gps-provider/config/:id` **no validaban
+  permiso alguno** (sólo JWT + filtro por `dealerId`).
+- Los 9 endpoints de `GpsDeviceController` usaban `CAR.GPS.OPERATIONS.VIEW`
+  (prestado del módulo `car`), sin distinguir `locate` de lecturas pasivas.
+
+## Pasos de release
+
+1. **Repo del paquete `@telos-dev-team/dealernode-permissions`**: pegar el
+   bloque `GPS_PROVIDER` en `src/permissions.ts`, abrir PR, bumpear versión
+   (minor: `1.x.0`), publicar.
+2. **dealernode-backend**:
+   - `npm install @telos-dev-team/dealernode-permissions@<nueva-versión>` y
+     commitear `package.json` + lockfile.
+   - Aplicar los reemplazos en commands y queries del módulo gps-provider
+     (los 14 endpoints, ver tabla de arriba).
+3. **Deploy**.
+4. **Post-deploy**: correr `npm run sync:permissions` contra el ambiente para
+   crear los 6 permisos nuevos en la tabla `permission`. El script es
+   idempotente y debe imprimir `6 created, 0 deleted`.
+5. **Operativo**: asignar los nuevos permisos a los roles correspondientes
+   (super_admin, dealer_admin, manager según política). No se hace por código.
+
+## Notas
+
+- No se elimina ningún permiso existente; los `CAR.GPS.OPERATIONS.*` y
+  `DEAL.GPS.OPERATIONS.*` siguen siendo válidos para sus propios módulos
+  (`car`/`deal`). Sólo se deja de **reusarlos** desde `gps-provider`.
+- Si en el futuro hace falta granularidad adicional para device (p. ej.
+  separar `VIEW_HISTORY` o `VIEW_ALERTS`), se agrega como una nueva acción
+  bajo `GPS_PROVIDER.DEVICE.OPERATIONS` sin romper compatibilidad.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@telos-dev-team/dealernode-permissions",
-  "version": "1.0.7",
+  "version": "1.1.2",
   "description": "Shared permissions constants for dealernode projects",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",

package/src/permissions.ts

@@ -792,13 +792,13 @@ export const PERMISSIONS = {
   },
 
   // ============================================
-  // FAILED_ACTION
+  // AUTOMATIC_ACTION
   // ============================================
-  FAILED_ACTION: {
+  AUTOMATIC_ACTION: {
     OPERATIONS: {
-      VIEW: 'failed_action.operations.view',
-      DELETE: 'failed_action.operations.delete',
-      EXECUTE: 'failed_action.operations.execute',
+      VIEW: 'automatic_action.operations.view',
+      DELETE: 'automatic_action.operations.delete',
+      EXECUTE: 'automatic_action.operations.execute',
     },
   },
 
@@ -811,6 +811,26 @@ export const PERMISSIONS = {
       UPDATE: 'calendar.operations.update',
     },
   },
+  
+  // ============================================
+  // GPS PROVIDER
+  // ============================================
+  GPS_PROVIDER: {
+    CONFIG: {
+      OPERATIONS: {
+        CREATE: 'gps-provider.config.operations.create',
+        VIEW: 'gps-provider.config.operations.view',
+        UPDATE: 'gps-provider.config.operations.update',
+        DELETE: 'gps-provider.config.operations.delete',
+      },
+    },
+    DEVICE: {
+      OPERATIONS: {
+        VIEW: 'gps-provider.device.operations.view',
+        LOCATE: 'gps-provider.device.operations.locate',
+      },
+    },
+  },
 } as const;
 
 export type Permission = typeof PERMISSIONS;