@telorun/templating 0.16.0 → 0.17.0

package/dist/engine.d.ts

@@ -19,6 +19,18 @@ export interface CompileEnv {
 export interface AnalyzeEnv {
     readonly celEnv: Environment;
     readonly contextSchema: Record<string, unknown> | null;
+    /**
+     * The caller vouches that `celEnv` declares EVERY name legal at this site, so
+     * a root identifier it does not know is undeclared rather than merely
+     * unmodelled.
+     *
+     * Opt-in because the environment is only that complete when someone built it
+     * for a specific site: the base environment declares CEL's own type names and
+     * nothing else, so checking roots against it would report `variables` itself
+     * as unknown. Absent means the check is skipped, which is what every caller
+     * did before it existed.
+     */
+    readonly rootsDeclared?: boolean;
 }
 /** A mechanically applicable repair for a diagnostic. `replacement` is the
  *  **whole analyzed source**, corrected — never a fragment — so a consumer can

package/dist/engine.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"engine.d.ts","sourceRoot":"","sources":["../src/engine.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,WAAW,EAAE,MAAM,sBAAsB,CAAC;AACxD,OAAO,KAAK,EAAE,aAAa,EAAE,MAAM,cAAc,CAAC;AAElD;;wEAEwE;AACxE,MAAM,WAAW,UAAU;IACzB,QAAQ,CAAC,MAAM,EAAE,WAAW,CAAC;CAC9B;AAED;;;;;;;;;eASe;AACf,MAAM,WAAW,UAAU;IACzB,QAAQ,CAAC,MAAM,EAAE,WAAW,CAAC;IAC7B,QAAQ,CAAC,aAAa,EAAE,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,GAAG,IAAI,CAAC;CACxD;AAED;;;;;;;;;;;;;0EAa0E;AAC1E,MAAM,WAAW,aAAa;IAC5B,QAAQ,CAAC,WAAW,EAAE,MAAM,CAAC;CAC9B;AAED;;oDAEoD;AACpD,MAAM,WAAW,gBAAgB;IAC/B,QAAQ,CAAC,OAAO,EAAE,MAAM,CAAC;IACzB,QAAQ,CAAC,IAAI,CAAC,EAAE,MAAM,CAAC;IACvB,QAAQ,CAAC,GAAG,CAAC,EAAE,aAAa,CAAC;CAC9B;AAED;;;;yBAIyB;AACzB,MAAM,WAAW,QAAQ;IACvB,QAAQ,CAAC,IAAI,EAAE,MAAM,CAAC;IACtB,8CAA8C;IAC9C,QAAQ,CAAC,IAAI,EAAE,QAAQ,GAAG,UAAU,CAAC;IACrC,wDAAwD;IACxD,QAAQ,CAAC,KAAK,EAAE,MAAM,CAAC;IACvB,4DAA4D;IAC5D,QAAQ,CAAC,KAAK,EAAE,MAAM,CAAC;IACvB,QAAQ,CAAC,GAAG,EAAE,MAAM,CAAC;IACrB;;oDAEgD;IAChD,QAAQ,CAAC,aAAa,CAAC,EAAE,OAAO,CAAC;CAClC;AAED;;;iFAGiF;AACjF,MAAM,WAAW,aAAa;IAC5B,QAAQ,CAAC,WAAW,EAAE,SAAS,gBAAgB,EAAE,CAAC;IAClD,6EAA6E;IAC7E,QAAQ,CAAC,IAAI,CAAC,EAAE,MAAM,CAAC;IACvB,0DAA0D;IAC1D,QAAQ,CAAC,KAAK,EAAE,SAAS,QAAQ,EAAE,CAAC;CACrC;AAED;;;;;;;;;;;;;;;;4CAgB4C;AAC5C,MAAM,WAAW,eAAe;IAC9B,QAAQ,CAAC,IAAI,EAAE,MAAM,CAAC;CACvB;AAED;;wBAEwB;AACxB,MAAM,WAAW,gBAAgB;IAC/B,6DAA6D;IAC7D,QAAQ,CAAC,IAAI,EAAE,MAAM,CAAC;IAEtB;;;;;2EAKuE;IACvE,QAAQ,CAAC,QAAQ,CAAC,EAAE,MAAM,CAAC;IAE3B;;;yDAGqD;IACrD,OAAO,CAAC,MAAM,EAAE,MAAM,EAAE,GAAG,EAAE,UAAU,GAAG,aAAa,GAAG,OAAO,CAAC;IAElE;;iEAE6D;IAC7D,OAAO,CAAC,MAAM,EAAE,MAAM,EAAE,GAAG,EAAE,UAAU,GAAG,aAAa,CAAC;IAExD;;;;;;;;;;;;uBAYmB;IACnB,UAAU,CAAC,CAAC,MAAM,EAAE,MAAM,GAAG,SAAS,eAAe,EAAE,CAAC;IAExD;;;;;;;;;;;;;;;;;2CAiBuC;IACvC,YAAY,CAAC,IAAI,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,CAAC;CAC1C"}
+{"version":3,"file":"engine.d.ts","sourceRoot":"","sources":["../src/engine.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,WAAW,EAAE,MAAM,sBAAsB,CAAC;AACxD,OAAO,KAAK,EAAE,aAAa,EAAE,MAAM,cAAc,CAAC;AAElD;;wEAEwE;AACxE,MAAM,WAAW,UAAU;IACzB,QAAQ,CAAC,MAAM,EAAE,WAAW,CAAC;CAC9B;AAED;;;;;;;;;eASe;AACf,MAAM,WAAW,UAAU;IACzB,QAAQ,CAAC,MAAM,EAAE,WAAW,CAAC;IAC7B,QAAQ,CAAC,aAAa,EAAE,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,GAAG,IAAI,CAAC;IACvD;;;;;;;;;;OAUG;IACH,QAAQ,CAAC,aAAa,CAAC,EAAE,OAAO,CAAC;CAClC;AAED;;;;;;;;;;;;;0EAa0E;AAC1E,MAAM,WAAW,aAAa;IAC5B,QAAQ,CAAC,WAAW,EAAE,MAAM,CAAC;CAC9B;AAED;;oDAEoD;AACpD,MAAM,WAAW,gBAAgB;IAC/B,QAAQ,CAAC,OAAO,EAAE,MAAM,CAAC;IACzB,QAAQ,CAAC,IAAI,CAAC,EAAE,MAAM,CAAC;IACvB,QAAQ,CAAC,GAAG,CAAC,EAAE,aAAa,CAAC;CAC9B;AAED;;;;yBAIyB;AACzB,MAAM,WAAW,QAAQ;IACvB,QAAQ,CAAC,IAAI,EAAE,MAAM,CAAC;IACtB,8CAA8C;IAC9C,QAAQ,CAAC,IAAI,EAAE,QAAQ,GAAG,UAAU,CAAC;IACrC,wDAAwD;IACxD,QAAQ,CAAC,KAAK,EAAE,MAAM,CAAC;IACvB,4DAA4D;IAC5D,QAAQ,CAAC,KAAK,EAAE,MAAM,CAAC;IACvB,QAAQ,CAAC,GAAG,EAAE,MAAM,CAAC;IACrB;;oDAEgD;IAChD,QAAQ,CAAC,aAAa,CAAC,EAAE,OAAO,CAAC;CAClC;AAED;;;iFAGiF;AACjF,MAAM,WAAW,aAAa;IAC5B,QAAQ,CAAC,WAAW,EAAE,SAAS,gBAAgB,EAAE,CAAC;IAClD,6EAA6E;IAC7E,QAAQ,CAAC,IAAI,CAAC,EAAE,MAAM,CAAC;IACvB,0DAA0D;IAC1D,QAAQ,CAAC,KAAK,EAAE,SAAS,QAAQ,EAAE,CAAC;CACrC;AAED;;;;;;;;;;;;;;;;4CAgB4C;AAC5C,MAAM,WAAW,eAAe;IAC9B,QAAQ,CAAC,IAAI,EAAE,MAAM,CAAC;CACvB;AAED;;wBAEwB;AACxB,MAAM,WAAW,gBAAgB;IAC/B,6DAA6D;IAC7D,QAAQ,CAAC,IAAI,EAAE,MAAM,CAAC;IAEtB;;;;;2EAKuE;IACvE,QAAQ,CAAC,QAAQ,CAAC,EAAE,MAAM,CAAC;IAE3B;;;yDAGqD;IACrD,OAAO,CAAC,MAAM,EAAE,MAAM,EAAE,GAAG,EAAE,UAAU,GAAG,aAAa,GAAG,OAAO,CAAC;IAElE;;iEAE6D;IAC7D,OAAO,CAAC,MAAM,EAAE,MAAM,EAAE,GAAG,EAAE,UAAU,GAAG,aAAa,CAAC;IAExD;;;;;;;;;;;;uBAYmB;IACnB,UAAU,CAAC,CAAC,MAAM,EAAE,MAAM,GAAG,SAAS,eAAe,EAAE,CAAC;IAExD;;;;;;;;;;;;;;;;;2CAiBuC;IACvC,YAAY,CAAC,IAAI,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,CAAC;CAC1C"}

package/dist/engines/cel.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"cel.d.ts","sourceRoot":"","sources":["../../src/engines/cel.ts"],"names":[],"mappings":"AAOA,OAAO,KAAK,EAAE,UAAU,EAAE,aAAa,EAAoB,gBAAgB,EAAE,MAAM,cAAc,CAAC;AAElG;;;;;;;;;;2BAU2B;AAC3B,wBAAgB,oBAAoB,CAAC,MAAM,EAAE,MAAM,EAAE,GAAG,EAAE,UAAU,GAAG,aAAa,CAgFnF;AAYD;yCACyC;AACzC,eAAO,MAAM,SAAS,EAAE,gBAWvB,CAAC"}
+{"version":3,"file":"cel.d.ts","sourceRoot":"","sources":["../../src/engines/cel.ts"],"names":[],"mappings":"AAOA,OAAO,KAAK,EAAE,UAAU,EAAE,aAAa,EAAoB,gBAAgB,EAAE,MAAM,cAAc,CAAC;AAElG;;;;;;;;;;2BAU2B;AAC3B,wBAAgB,oBAAoB,CAAC,MAAM,EAAE,MAAM,EAAE,GAAG,EAAE,UAAU,GAAG,aAAa,CAqGnF;AAYD;yCACyC;AACzC,eAAO,MAAM,SAAS,EAAE,gBAWvB,CAAC"}

package/dist/engines/cel.js

@@ -69,6 +69,27 @@ export function analyzeCelExpression(source, env) {
             });
         }
     }
+    // An undeclared ROOT identifier. cel-js types an unknown name as `dyn` and
+    // accepts it, so `!cel "fff"` type-checked, reached the runtime and resolved
+    // to nothing — the one CEL mistake with no static report at all. Member
+    // access on a KNOWN root was already covered ("No such key"), which is why a
+    // typo one level in was caught and a typo at the root was not.
+    //
+    // Comprehension variables are not roots: `extractAccessChains` drops the
+    // names a `.all(x, …)` binds, so the check never sees them.
+    if (env.rootsDeclared) {
+        const reported = new Set();
+        for (const chain of extractAccessChains(parsed.ast)) {
+            const root = chain[0];
+            if (!root || reported.has(root) || env.celEnv.hasVariable(root))
+                continue;
+            reported.add(root);
+            out.push({
+                code: "CEL_UNKNOWN_IDENTIFIER",
+                message: `unknown identifier '${root}' — nothing by that name is in scope here.`,
+            });
+        }
+    }
     if (env.contextSchema) {
         const contextSchema = env.contextSchema;
         for (const chain of extractAccessChains(parsed.ast)) {

package/dist/engines/literal.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"literal.d.ts","sourceRoot":"","sources":["../../src/engines/literal.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,gBAAgB,EAAE,MAAM,cAAc,CAAC;AAErD;;+CAE+C;AAC/C,eAAO,MAAM,aAAa,EAAE,gBAU3B,CAAC"}
+{"version":3,"file":"literal.d.ts","sourceRoot":"","sources":["../../src/engines/literal.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,gBAAgB,EAAE,MAAM,cAAc,CAAC;AAErD;;+CAE+C;AAC/C,eAAO,MAAM,aAAa,EAAE,gBAyB3B,CAAC"}

package/dist/engines/literal.js

@@ -6,6 +6,20 @@ export const literalEngine = {
     compile(source) {
         return source;
     },
+    /**
+     * Opaque text is TEXT — the type is a constant of the tag, exactly as an
+     * embed's is, not a function of the slot.
+     *
+     * Declaring nothing put `!literal` in the other category, the one `!cel` and
+     * `!ref` belong to, and everything downstream then treated it as producing
+     * whatever the slot asked for. So the editor offered it at a boolean
+     * predicate — where opaque text cannot satisfy the slot and `Run.Choice` has
+     * a runtime error saying so — and the analyzer type-checked one against a
+     * slot-shaped placeholder instead of the string it will actually be.
+     */
+    producedType() {
+        return { type: "string" };
+    },
     analyze() {
         return { diagnostics: [], calls: [] };
     },

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@telorun/templating",
-  "version": "0.16.0",
+  "version": "0.17.0",
   "description": "Telo Templating - Engine registry and shared CEL core for Telo manifests.",
   "keywords": [
     "telo",
@@ -44,7 +44,7 @@
     "@types/node": "^20.0.0",
     "typescript": "^5.0.0",
     "vitest": "^2.1.8",
-    "@telorun/sdk": "0.75.0"
+    "@telorun/sdk": "0.82.1"
   },
   "peerDependencies": {
     "@telorun/sdk": "*"

package/src/engine.ts

@@ -21,6 +21,18 @@ export interface CompileEnv {
 export interface AnalyzeEnv {
   readonly celEnv: Environment;
   readonly contextSchema: Record<string, unknown> | null;
+  /**
+   * The caller vouches that `celEnv` declares EVERY name legal at this site, so
+   * a root identifier it does not know is undeclared rather than merely
+   * unmodelled.
+   *
+   * Opt-in because the environment is only that complete when someone built it
+   * for a specific site: the base environment declares CEL's own type names and
+   * nothing else, so checking roots against it would report `variables` itself
+   * as unknown. Absent means the check is skipped, which is what every caller
+   * did before it existed.
+   */
+  readonly rootsDeclared?: boolean;
 }
 
 /** A mechanically applicable repair for a diagnostic. `replacement` is the

package/src/engines/cel.ts

@@ -79,6 +79,27 @@ export function analyzeCelExpression(source: string, env: AnalyzeEnv): AnalyzeRe
     }
   }
 
+  // An undeclared ROOT identifier. cel-js types an unknown name as `dyn` and
+  // accepts it, so `!cel "fff"` type-checked, reached the runtime and resolved
+  // to nothing — the one CEL mistake with no static report at all. Member
+  // access on a KNOWN root was already covered ("No such key"), which is why a
+  // typo one level in was caught and a typo at the root was not.
+  //
+  // Comprehension variables are not roots: `extractAccessChains` drops the
+  // names a `.all(x, …)` binds, so the check never sees them.
+  if (env.rootsDeclared) {
+    const reported = new Set<string>();
+    for (const chain of extractAccessChains(parsed.ast)) {
+      const root = chain[0];
+      if (!root || reported.has(root) || env.celEnv.hasVariable(root)) continue;
+      reported.add(root);
+      out.push({
+        code: "CEL_UNKNOWN_IDENTIFIER",
+        message: `unknown identifier '${root}' — nothing by that name is in scope here.`,
+      });
+    }
+  }
+
   if (env.contextSchema) {
     const contextSchema = env.contextSchema as Record<string, any>;
     for (const chain of extractAccessChains(parsed.ast)) {

package/src/engines/literal.ts

@@ -10,6 +10,21 @@ export const literalEngine: TemplatingEngine = {
     return source;
   },
 
+  /**
+   * Opaque text is TEXT — the type is a constant of the tag, exactly as an
+   * embed's is, not a function of the slot.
+   *
+   * Declaring nothing put `!literal` in the other category, the one `!cel` and
+   * `!ref` belong to, and everything downstream then treated it as producing
+   * whatever the slot asked for. So the editor offered it at a boolean
+   * predicate — where opaque text cannot satisfy the slot and `Run.Choice` has
+   * a runtime error saying so — and the analyzer type-checked one against a
+   * slot-shaped placeholder instead of the string it will actually be.
+   */
+  producedType() {
+    return { type: "string" };
+  },
+
   analyze() {
     return { diagnostics: [], calls: [] };
   },