@telorun/analyzer 0.71.0 → 0.73.0

package/dist/validate-template-body.js

@@ -0,0 +1,246 @@
+import { nearestName } from "./nearest-name.js";
+import { isRefSentinel, isTaggedSentinel } from "@telorun/templating";
+import { refSentinelTarget } from "./ref-sentinel-target.js";
+import { isRefEntry, resolveFieldEntries, satisfiesValueBranch } from "./reference-field-map.js";
+import { templateBodies } from "./template-body.js";
+import { DiagnosticSeverity, DiagnosticTag } from "./types.js";
+const SOURCE = "telo-analyzer";
+/** The four slots a `Telo.Definition` names its dispatch target in.
+ *
+ *  WHAT THE TARGET'S CAPABILITY IS IS DELIBERATELY NOT CHECKED. The kernel tests
+ *  METHOD PRESENCE at dispatch (`entry.instance?.invoke`), so a declared
+ *  capability says nothing about whether a dispatch works — the same structural
+ *  -versus-nominal split that keeps `use` uncross-constrained against a slot's
+ *  target. A check here read `Run.Sequence`'s `capability: Telo.Runnable` and
+ *  rejected `Ai.Buffered`, a shipping module whose sequence implements `invoke()`
+ *  over an inputs/outputs contract and dispatches correctly. Trimming the refused
+ *  set would only move that: any controller may expose a method its capability
+ *  does not name, and a template body is exactly where that is done on purpose. */
+const DISPATCH_SLOTS = ["invoke", "run", "provide", "mount"];
+/**
+ * A TEMPLATE BODY IS WRITTEN LIKE EVERY OTHER MANIFEST, AND CHECKED LIKE ONE.
+ *
+ * A `Telo.Definition` is in both reference skip sets — its body holds
+ * declarations of OTHER kinds, and its dispatch slots carry no `x-telo-ref` — so
+ * no reference pass reached it, and each rule about it was added per construct:
+ * `provide:` and `mount:` had a target check for the `{ kind, name }` object
+ * form, `!ref` had one that switched itself off for any definition with a
+ * CEL-named entry, and `invoke:` / `run:` had none. What was tagged was caught
+ * and what was a plain name was resolved by the kernel alone. This pass is the
+ * one reader of a body's reference surface, and it rests on one spelling:
+ *
+ *  - every `resources:` entry is named by a LITERAL (`TEMPLATE_ENTRY_NAME_DYNAMIC`).
+ *    Each instance of a template owns its children in a child context of its
+ *    own, so a per-instance suffix (`self.name + '-query'`) buys nothing — and a
+ *    `!ref` is looked up verbatim, so a CEL-named sibling is one nothing can name;
+ *  - a dispatch slot is `!ref <entry>` naming an entry
+ *    (`TEMPLATE_DISPATCH_UNKNOWN`); the legacy spellings are deprecated rather
+ *    than refused, since published artifacts carry them. What the target's
+ *    CAPABILITY is stays unchecked — see `DISPATCH_SLOTS`;
+ *  - a reference slot INSIDE an entry follows the rule every other slot does —
+ *    `!ref` or an inline declaration, never `{ kind, name }` or a bare string
+ *    (`INVALID_REFERENCE_FORM`) — and a bare `!ref` names a sibling or a
+ *    resource of the defining module (`TEMPLATE_REF_UNKNOWN`). Slots are found
+ *    through the nested kind's own field map, resolved in the DEFINING module's
+ *    alias scope, since that is where the body's kinds are written.
+ *
+ * Entry-module-scoped, like every other declaration check: a published
+ * dependency's template body is not the consumer's to fix. Browser-safe.
+ */
+export function validateTemplateBody(manifests, registry, aliases, aliasesByModule, rootModules) {
+    const out = [];
+    const scopes = { aliasesByModule, rootModules };
+    // A definition forwarded from an imported library is that library's to fix;
+    // the imports name them (the `validate-extends` rule).
+    const importedModules = new Set();
+    // Every named instance, by declaring module — what a body's bare `!ref` may
+    // reach beside its siblings. A manifest with no stamp belongs to the entry.
+    const instancesByModule = new Map();
+    for (const m of manifests) {
+        const name = m.metadata?.name;
+        if (typeof name !== "string")
+            continue;
+        if (m.kind === "Telo.Import") {
+            const resolved = m.metadata.resolvedModuleName;
+            if (resolved)
+                importedModules.add(resolved);
+            continue;
+        }
+        if (m.kind === "Telo.Definition" || m.kind === "Telo.Abstract")
+            continue;
+        if (m.kind === "Telo.Library" || m.kind === "Telo.Application")
+            continue;
+        const mod = m.metadata?.module;
+        let set = instancesByModule.get(mod);
+        if (!set)
+            instancesByModule.set(mod, (set = new Set()));
+        set.add(name);
+    }
+    for (const m of manifests) {
+        if (m.kind !== "Telo.Definition")
+            continue;
+        const meta = m.metadata;
+        const name = meta?.name;
+        if (!name)
+            continue;
+        if (meta?.module && importedModules.has(meta.module))
+            continue;
+        const bodies = m.resources;
+        const resourceRef = { kind: m.kind, name };
+        const filePath = meta?.source;
+        const label = `${m.kind}/${name}`;
+        const report = (code, path, message, fix) => out.push({
+            severity: DiagnosticSeverity.Error,
+            code,
+            source: SOURCE,
+            message: `${label}: ${message}`,
+            data: {
+                resource: resourceRef,
+                filePath,
+                path,
+                ...(fix ? { fix: { replacement: fix } } : {}),
+            },
+        });
+        /** A spelling the kernel still READS. Warning-grade because refusing it
+         *  would break every app pinning a version that carries it, and tagged so an
+         *  editor strikes it through rather than merely colouring it — the
+         *  `DEPRECATED_KIND` shape, for the same reason. */
+        const deprecate = (code, path, message) => out.push({
+            severity: DiagnosticSeverity.Warning,
+            code,
+            source: SOURCE,
+            message: `${label}: ${message}`,
+            tags: [DiagnosticTag.Deprecated],
+            data: { resource: resourceRef, filePath, path },
+        });
+        const entries = Array.isArray(bodies) ? bodies : [];
+        const siblings = [];
+        let anyDynamic = false;
+        entries.forEach((entry, i) => {
+            const entryName = entry?.metadata?.name;
+            if (typeof entryName === "string" && !entryName.includes("${{")) {
+                siblings.push(entryName);
+                return;
+            }
+            if (entryName === undefined)
+                return;
+            anyDynamic = true;
+            deprecate("DEPRECATED_TEMPLATE_ENTRY_NAME", `resources[${i}].metadata.name`, `a 'resources:' entry named by ${describeDynamic(entryName)} is deprecated — name it ` +
+                `with a literal and dispatch to it with '!ref'. Each instance of a template owns its ` +
+                `children in a child context of its own, so a per-instance suffix buys nothing, and a ` +
+                `'!ref' is looked up verbatim, so nothing can name a computed entry. While one is ` +
+                `present the target checks below are switched off for this kind.`);
+        });
+        // Siblings PLUS the declaring module's own resources, because that is what
+        // the runtime resolves at a reference slot: a body's `!ref` is stamped
+        // `{kind, name}` with an empty kind for a non-sibling, and Phase-5 injection
+        // dispatches by NAME and recovers the kind from the instance it finds — so
+        // `client: !ref moduleClient` in a body reaches the module-level client and
+        // works. (A step's `invoke:` is a different path that does NOT: see the
+        // `resources` note in `validate-template-body`'s own tests.)
+        const reachable = new Set([
+            ...siblings,
+            ...(instancesByModule.get(meta?.module) ?? []),
+        ]);
+        // --- dispatch slots ---
+        for (const slot of DISPATCH_SLOTS) {
+            const value = m[slot];
+            if (value == null)
+                continue;
+            if (!isRefSentinel(value)) {
+                deprecate("DEPRECATED_TEMPLATE_DISPATCH_FORM", slot, `'${slot}:' written as ${describeDispatchValue(value)} is deprecated — ` +
+                    `write '!ref <entry>', the spelling every other reference uses. ` +
+                    `Available: ${siblings.join(", ") || "(none)"}.`);
+                continue;
+            }
+            const source = value.source;
+            const target = source.startsWith("Self.") ? source.slice("Self.".length) : source;
+            if (siblings.includes(target))
+                continue;
+            // A dynamic sibling has already been reported, and might be the one
+            // meant — a second diagnostic about the same line would be noise.
+            if (anyDynamic)
+                continue;
+            const suggestion = nearestName(target, siblings);
+            report("TEMPLATE_DISPATCH_UNKNOWN", slot, `'${slot}: !ref ${source}' names no entry in 'resources:'. ` +
+                `Available: ${siblings.join(", ") || "(none)"}.` +
+                (suggestion ? ` Did you mean '${suggestion}'?` : ""), suggestion);
+        }
+        // --- reference slots inside each entry ---
+        for (const body of templateBodies(m, registry, aliases, scopes)) {
+            const kind = body.manifest.kind;
+            const fieldMap = registry.expandedFieldMapForResource({ ...body.manifest, metadata: { ...(body.manifest.metadata ?? {}), module: meta?.module } }, aliases, aliasesByModule);
+            if (!fieldMap)
+                continue;
+            for (const [fieldPath, entry] of fieldMap) {
+                if (!isRefEntry(entry))
+                    continue;
+                for (const site of resolveFieldEntries(body.manifest, fieldPath)) {
+                    const value = site.value;
+                    if (value == null)
+                        continue;
+                    const path = `${body.prefix}.${site.path}`;
+                    if (isTaggedSentinel(value)) {
+                        const target = refSentinelTarget(value);
+                        if (!target)
+                            continue;
+                        const { alias, name: refName } = target;
+                        if (alias && alias !== "Self")
+                            continue;
+                        if (reachable.has(refName))
+                            continue;
+                        const suggestion = nearestName(refName, [...reachable]);
+                        report("TEMPLATE_REF_UNKNOWN", path, `'${site.path}: !ref ${value.source}' on the ${kind} entry names no sibling ` +
+                            `'resources:' entry and no resource of this module. ` +
+                            `Siblings: ${siblings.filter((s) => s !== body.manifest.metadata?.name).join(", ") || "(none)"}.` +
+                            (suggestion ? ` Did you mean '${suggestion}'?` : ""), suggestion);
+                        continue;
+                    }
+                    const hasValueBranch = (entry.valueBranches?.length ?? 0) > 0;
+                    if (hasValueBranch && typeof value !== "object")
+                        continue;
+                    if (satisfiesValueBranch(value, entry.valueBranches, registry))
+                        continue;
+                    if (typeof value === "string") {
+                        if (value.includes("${{"))
+                            continue;
+                        report("INVALID_REFERENCE_FORM", path, `string reference at '${site.path}' on the ${kind} entry → '${value}' is not ` +
+                            `supported; write it as '!ref ${value}'`);
+                        continue;
+                    }
+                    if (value && typeof value === "object" && !Array.isArray(value)) {
+                        const obj = value;
+                        if (typeof obj.kind === "string" && obj.name !== undefined) {
+                            report("INVALID_REFERENCE_FORM", path, `object reference '{ kind, name }' at '${site.path}' on the ${kind} entry is ` +
+                                `not supported; write it as '!ref ${describeRefName(obj.name)}'`);
+                        }
+                    }
+                }
+            }
+        }
+    }
+    return out;
+}
+function describeDynamic(name) {
+    if (isTaggedSentinel(name))
+        return `the expression '${name.source}'`;
+    if (typeof name === "string")
+        return `the template '${name}'`;
+    return `a ${typeof name}`;
+}
+function describeDispatchValue(value) {
+    if (isTaggedSentinel(value))
+        return `a '!${value.engine}' expression`;
+    if (typeof value === "string")
+        return `the string '${value}'`;
+    if (value && typeof value === "object" && "name" in value)
+        return "the '{ kind, name }' object form";
+    return `a ${typeof value}`;
+}
+function describeRefName(name) {
+    if (typeof name === "string")
+        return name;
+    if (isTaggedSentinel(name))
+        return "<entry>";
+    return String(name);
+}

package/dist/validate-throws-coverage.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"validate-throws-coverage.d.ts","sourceRoot":"","sources":["../src/validate-throws-coverage.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAW,WAAW,EAAE,MAAM,sBAAsB,CAAC;AAEjE,OAAO,EAGL,KAAK,gBAAgB,EACtB,MAAM,cAAc,CAAC;AACtB,OAAO,EAA0B,KAAK,aAAa,EAAE,MAAM,qBAAqB,CAAC;AACjF,OAAO,KAAK,EAAE,kBAAkB,EAAE,MAAM,0BAA0B,CAAC;AAOnE,OAAO,EAAsB,KAAK,kBAAkB,EAAE,MAAM,YAAY,CAAC;AAsfzE,oDAAoD;AACpD,wBAAgB,sBAAsB,CACpC,SAAS,EAAE,gBAAgB,EAAE,EAC7B,IAAI,EAAE,kBAAkB,EACxB,OAAO,EAAE,aAAa,EACtB,GAAG,EAAE,WAAW,EAChB,eAAe,GAAE,GAAG,CAAC,MAAM,EAAE,aAAa,CAAa,EACvD,WAAW,GAAE,GAAG,CAAC,MAAM,CAAa;AACpC;;+BAE+B;AAC/B,eAAe,GAAE,GAAG,CAAC,MAAM,EAAE,gBAAgB,EAAE,CAAa,GAC3D,kBAAkB,EAAE,CAyDtB"}
+{"version":3,"file":"validate-throws-coverage.d.ts","sourceRoot":"","sources":["../src/validate-throws-coverage.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAW,WAAW,EAAE,MAAM,sBAAsB,CAAC;AAEjE,OAAO,EAIL,KAAK,gBAAgB,EACtB,MAAM,cAAc,CAAC;AACtB,OAAO,EAA0B,KAAK,aAAa,EAAE,MAAM,qBAAqB,CAAC;AACjF,OAAO,KAAK,EAAE,kBAAkB,EAAE,MAAM,0BAA0B,CAAC;AAenE,OAAO,EAAsB,KAAK,kBAAkB,EAAE,MAAM,YAAY,CAAC;AA4kBzE,oDAAoD;AACpD,wBAAgB,sBAAsB,CACpC,SAAS,EAAE,gBAAgB,EAAE,EAC7B,IAAI,EAAE,kBAAkB,EACxB,OAAO,EAAE,aAAa,EACtB,GAAG,EAAE,WAAW,EAChB,eAAe,GAAE,GAAG,CAAC,MAAM,EAAE,aAAa,CAAa,EACvD,WAAW,GAAE,GAAG,CAAC,MAAM,CAAa;AACpC;;+BAE+B;AAC/B,eAAe,GAAE,GAAG,CAAC,MAAM,EAAE,gBAAgB,EAAE,CAAa,GAC3D,kBAAkB,EAAE,CAsLtB"}